SMOLNET PORTAL home about changes
ipedantic snprintf() improvement - stagit-gopher - A git gopher frontend. (mirror)	Err	bitreich.org	70
hgit clone git://bitreich.org/stagit-gopher/ git://enlrupgkhuxnvlhsf6lc3fziv5h2hhfrinws65d7roiv6bfj7d652fid.onion/stagit-gopher/	URL:git://bitreich.org/stagit-gopher/ git://enlrupgkhuxnvlhsf6lc3fziv5h2hhfrinws65d7roiv6bfj7d652fid.onion/stagit-gopher/	bitreich.org	70
1Log	/scm/stagit-gopher/log.gph	bitreich.org	70
1Files	/scm/stagit-gopher/files.gph	bitreich.org	70
1Refs	/scm/stagit-gopher/refs.gph	bitreich.org	70
1Tags	/scm/stagit-gopher/tag	bitreich.org	70
1README	/scm/stagit-gopher/file/README.gph	bitreich.org	70
1LICENSE	/scm/stagit-gopher/file/LICENSE.gph	bitreich.org	70
i---	Err	bitreich.org	70
1commit f8a73285fa1ba57d5815a9c365db13772896ad19	/scm/stagit-gopher/commit/f8a73285fa1ba57d5815a9c365db13772896ad19.gph	bitreich.org	70
1parent 77bfd42fb3c139ada3a679a62c56f6eebd38a0c2	/scm/stagit-gopher/commit/77bfd42fb3c139ada3a679a62c56f6eebd38a0c2.gph	bitreich.org	70
hAuthor: Hiltjo Posthuma <hiltjo@codemadness.org>	URL:mailto:hiltjo@codemadness.org	bitreich.org	70
iDate:   Sat,  9 Mar 2019 12:41:38 +0100	Err	bitreich.org	70
i	Err	bitreich.org	70
ipedantic snprintf() improvement	Err	bitreich.org	70
i	Err	bitreich.org	70
iPOSIX says:	Err	bitreich.org	70
i"If an output error was encountered, these functions shall return a negative	Err	bitreich.org	70
ivalue and set errno to indicate the error."	Err	bitreich.org	70
i	Err	bitreich.org	70
iDiffstat:	Err	bitreich.org	70
i  M stagit-gopher-index.c               |       2 +-	Err	bitreich.org	70
i  M stagit-gopher.c                     |       6 +++---	Err	bitreich.org	70
i	Err	bitreich.org	70
i2 files changed, 4 insertions(+), 4 deletions(-)	Err	bitreich.org	70
i---	Err	bitreich.org	70
1diff --git a/stagit-gopher-index.c b/stagit-gopher-index.c	/scm/stagit-gopher/file/stagit-gopher-index.c.gph	bitreich.org	70
i@@ -117,7 +117,7 @@ joinpath(char *buf, size_t bufsiz, const char *path, const char *path2)	Err	bitreich.org	70
i 	Err	bitreich.org	70
i         r = snprintf(buf, bufsiz, "%s%s%s",	Err	bitreich.org	70
i                 path, path[0] && path[strlen(path) - 1] != '/' ? "/" : "", path2);	Err	bitreich.org	70
i-        if (r == -1 || (size_t)r >= bufsiz)	Err	bitreich.org	70
i+        if (r < 0 || (size_t)r >= bufsiz)	Err	bitreich.org	70
i                 errx(1, "path truncated: '%s%s%s'",	Err	bitreich.org	70
i                         path, path[0] && path[strlen(path) - 1] != '/' ? "/" : "", path2);	Err	bitreich.org	70
i }	Err	bitreich.org	70
1diff --git a/stagit-gopher.c b/stagit-gopher.c	/scm/stagit-gopher/file/stagit-gopher.c.gph	bitreich.org	70
i@@ -124,7 +124,7 @@ joinpath(char *buf, size_t bufsiz, const char *path, const char *path2)	Err	bitreich.org	70
i 	Err	bitreich.org	70
i         r = snprintf(buf, bufsiz, "%s%s%s",	Err	bitreich.org	70
i                 path, path[0] && path[strlen(path) - 1] != '/' ? "/" : "", path2);	Err	bitreich.org	70
i-        if (r == -1 || (size_t)r >= bufsiz)	Err	bitreich.org	70
i+        if (r < 0 || (size_t)r >= bufsiz)	Err	bitreich.org	70
i                 errx(1, "path truncated: '%s%s%s'",	Err	bitreich.org	70
i                         path, path[0] && path[strlen(path) - 1] != '/' ? "/" : "", path2);	Err	bitreich.org	70
i }	Err	bitreich.org	70
i@@ -710,7 +710,7 @@ writelog(FILE *fp, const git_oid *oid)	Err	bitreich.org	70
i 	Err	bitreich.org	70
i                 git_oid_tostr(oidstr, sizeof(oidstr), &id);	Err	bitreich.org	70
i                 r = snprintf(path, sizeof(path), "commit/%s.gph", oidstr);	Err	bitreich.org	70
i-                if (r == -1 || (size_t)r >= sizeof(path))	Err	bitreich.org	70
i+                if (r < 0 || (size_t)r >= sizeof(path))	Err	bitreich.org	70
i                         errx(1, "path truncated: 'commit/%s.gph'", oidstr);	Err	bitreich.org	70
i                 r = access(path, F_OK);	Err	bitreich.org	70
i 	Err	bitreich.org	70
i@@ -935,7 +935,7 @@ writefilestree(FILE *fp, git_tree *tree, const char *path)	Err	bitreich.org	70
i 	Err	bitreich.org	70
i                 r = snprintf(filepath, sizeof(filepath), "file/%s.gph",	Err	bitreich.org	70
i                          entrypath);	Err	bitreich.org	70
i-                if (r == -1 || (size_t)r >= sizeof(filepath))	Err	bitreich.org	70
i+                if (r < 0 || (size_t)r >= sizeof(filepath))	Err	bitreich.org	70
i                         errx(1, "path truncated: 'file/%s.gph'", entrypath);	Err	bitreich.org	70
i 	Err	bitreich.org	70
i                 if (!git_tree_entry_to_object(&obj, repo, entry)) {	Err	bitreich.org	70
.
Response: text/plain
Original URLgopher://bitreich.org/0/scm/stagit-gopher/commit/f8a73285...
Content-Typetext/plain; charset=utf-8