iimprove commitinfo_getstats - stagit-gopher - A git gopher frontend. (mirror) Err bitreich.org 70 hgit clone git://bitreich.org/stagit-gopher/ git://enlrupgkhuxnvlhsf6lc3fziv5h2hhfrinws65d7roiv6bfj7d652fid.onion/stagit-gopher/ URL:git://bitreich.org/stagit-gopher/ git://enlrupgkhuxnvlhsf6lc3fziv5h2hhfrinws65d7roiv6bfj7d652fid.onion/stagit-gopher/ bitreich.org 70 1Log /scm/stagit-gopher/log.gph bitreich.org 70 1Files /scm/stagit-gopher/files.gph bitreich.org 70 1Refs /scm/stagit-gopher/refs.gph bitreich.org 70 1Tags /scm/stagit-gopher/tag bitreich.org 70 1README /scm/stagit-gopher/file/README.gph bitreich.org 70 1LICENSE /scm/stagit-gopher/file/LICENSE.gph bitreich.org 70 i--- Err bitreich.org 70 1commit 8fa0effa9846a18a60d3b6a7c96db42a2775a7c6 /scm/stagit-gopher/commit/8fa0effa9846a18a60d3b6a7c96db42a2775a7c6.gph bitreich.org 70 1parent 8eabe24bdda7003453bbd034d82ebc479e2c76bc /scm/stagit-gopher/commit/8eabe24bdda7003453bbd034d82ebc479e2c76bc.gph bitreich.org 70 hAuthor: Hiltjo Posthuma URL:mailto:hiltjo@codemadness.org bitreich.org 70 iDate: Sat, 22 Apr 2017 19:07:07 +0200 Err bitreich.org 70 i Err bitreich.org 70 iimprove commitinfo_getstats Err bitreich.org 70 i Err bitreich.org 70 i- reorder: unnecessary allocation when git_patch_from_diff fails. Err bitreich.org 70 i- no need to free patch object when git_patch_from_diff fails. Err bitreich.org 70 i Err bitreich.org 70 iDiffstat: Err bitreich.org 70 i M stagit.c | 7 ++----- Err bitreich.org 70 i Err bitreich.org 70 i1 file changed, 2 insertions(+), 5 deletions(-) Err bitreich.org 70 i--- Err bitreich.org 70 1diff --git a/stagit.c b/stagit.c /scm/stagit-gopher/file/stagit.c.gph bitreich.org 70 i@@ -110,13 +110,10 @@ commitinfo_getstats(struct commitinfo *ci) Err bitreich.org 70 i err(1, "calloc"); Err bitreich.org 70 i Err bitreich.org 70 i for (i = 0; i < ndeltas; i++) { Err bitreich.org 70 i+ if (git_patch_from_diff(&patch, ci->diff, i)) Err bitreich.org 70 i+ goto err; Err bitreich.org 70 i if (!(di = calloc(1, sizeof(struct deltainfo)))) Err bitreich.org 70 i err(1, "calloc"); Err bitreich.org 70 i- if (git_patch_from_diff(&patch, ci->diff, i)) { Err bitreich.org 70 i- git_patch_free(patch); Err bitreich.org 70 i- free(di); Err bitreich.org 70 i- goto err; Err bitreich.org 70 i- } Err bitreich.org 70 i di->patch = patch; Err bitreich.org 70 i ci->deltas[i] = di; Err bitreich.org 70 i Err bitreich.org 70 .