Jira

[MDEV-27096] [ERROR] mysqld got signal 11

Till Kraemer — Sat, 20 Nov 2021 12:22:50 +0000

Err codemadness.org 70 i 87 Err codemadness.org 70 i 88 Err codemadness.org 70 i 97 Err codemadness.org 70 i 98 Err codemadness.org 70 i 99 Err codemadness.org 70 i 100 Err codemadness.org 70 i 101 Err codemadness.org 70 i 102 Err codemadness.org 70 i 103 Err codemadness.org 70 i 104 Err codemadness.org 70 i 105 Err codemadness.org 70 i 106 Err codemadness.org 70 i 107 Err codemadness.org 70 i 108 Err codemadness.org 70 i 109 Err codemadness.org 70 i 112 Err codemadness.org 70 i 113 Err codemadness.org 70 i 114 Err codemadness.org 70 i 115 Err codemadness.org 70 i 116 Err codemadness.org 70 i 117 Err codemadness.org 70 i 119 Err codemadness.org 70 i 120 Err codemadness.org 70 i 121 Err codemadness.org 70 i 122 Err codemadness.org 70 i 123 Err codemadness.org 70 i 124 Err codemadness.org 70 i 127 Err codemadness.org 70 i 128 Err codemadness.org 70 i 129

Err codemadness.org 70 i 89 Err codemadness.org 70 i 90 [MDEV-27096] [ERROR] mysqld got signal 11 Err codemadness.org 70 i 91 Err codemadness.org 70 i 92 Created: 2021-11-20 Updated: 2021-11-20 Err codemadness.org 70 i 93 Err codemadness.org 70 i 94 Err codemadness.org 70 i 95 Err codemadness.org 70 i 96
Status:	Open
Project:	MariaDB Server
Component/s:	Err codemadness.org 70 i 110 None Err codemadness.org 70 i 111
Affects Version/s:	Err codemadness.org 70 i 118 10.6.4
Fix Version/s:	Err codemadness.org 70 i 125 None Err codemadness.org 70 i 126

Err codemadness.org 70 i 130 Err codemadness.org 70 i 131

Err codemadness.org 70 i 132 Err codemadness.org 70 i 133 Err codemadness.org 70 i 134 Err codemadness.org 70 i 137 Err codemadness.org 70 i 140 Err codemadness.org 70 i 141 Err codemadness.org 70 i 144 Err codemadness.org 70 i 147 Err codemadness.org 70 i 148 Err codemadness.org 70 i 149 Err codemadness.org 70 i 152 Err codemadness.org 70 i 155 Err codemadness.org 70 i 156 Err codemadness.org 70 i 159 Err codemadness.org 70 i 162 Err codemadness.org 70 i 163 Err codemadness.org 70 i 164 Err codemadness.org 70 i 167 Err codemadness.org 70 i 170 Err codemadness.org 70 i 173 Err codemadness.org 70 i 176 Err codemadness.org 70 i 177 Err codemadness.org 70 i 178 Err codemadness.org 70 i 179 Err codemadness.org 70 i 180 Err codemadness.org 70 i 183 Err codemadness.org 70 i 185 Err codemadness.org 70 i 186 Err codemadness.org 70 i 187 Err codemadness.org 70 i 188 Err codemadness.org 70 i 189 Err codemadness.org 70 i 190 Err codemadness.org 70 i 191 Err codemadness.org 70 i 192 Err codemadness.org 70 i 193 Err codemadness.org 70 i 196 Err codemadness.org 70 i 199 Err codemadness.org 70 i 200

Err codemadness.org 70 i 135 Type: Err codemadness.org 70 i 136

Err codemadness.org 70 i 138 Bug Err codemadness.org 70 i 139

Err codemadness.org 70 i 142 Priority: Err codemadness.org 70 i 143

Err codemadness.org 70 i 145 Blocker Err codemadness.org 70 i 146

Err codemadness.org 70 i 150 Reporter: Err codemadness.org 70 i 151

Err codemadness.org 70 i 153 Till Kraemer Err codemadness.org 70 i 154

Err codemadness.org 70 i 157 Assignee: Err codemadness.org 70 i 158

Err codemadness.org 70 i 160 Unassigned Err codemadness.org 70 i 161

Err codemadness.org 70 i 165 Resolution: Err codemadness.org 70 i 166

Err codemadness.org 70 i 168 Unresolved Err codemadness.org 70 i 169

Err codemadness.org 70 i 171 Votes: Err codemadness.org 70 i 172

Err codemadness.org 70 i 174 0 Err codemadness.org 70 i 175

Err codemadness.org 70 i 181 Labels: Err codemadness.org 70 i 182

Err codemadness.org 70 i 184 innodb

Err codemadness.org 70 i 194 Environment: Err codemadness.org 70 i 195

Err codemadness.org 70 i 197

OpenBSD 7.0 GENERIC.MP#1 amd64

Err codemadness.org 70 i 198

Err codemadness.org 70 i 201 Err codemadness.org 70 i 202 Err codemadness.org 70 i 203 Err codemadness.org 70 i 204

Err codemadness.org 70 i 205 Err codemadness.org 70 i 206 Err codemadness.org 70 i 207 Err codemadness.org 70 i 208 Err codemadness.org 70 i 209 Err codemadness.org 70 i 210 Err codemadness.org 70 i 211 Err codemadness.org 70 i 212 Err codemadness.org 70 i 213 Err codemadness.org 70 i 214

Err codemadness.org 70 i 215 Err codemadness.org 70 i 216

Err codemadness.org 70 i 217 Err codemadness.org 70 i 218 Err codemadness.org 70 i 219 Err codemadness.org 70 i 220 Err codemadness.org 70 i 223 Err codemadness.org 70 i 224 Err codemadness.org 70 i 225

Err codemadness.org 70 i 221 Description Err codemadness.org 70 i 222

Err codemadness.org 70 i 226 Err codemadness.org 70 i 227 Err codemadness.org 70 i 228 Err codemadness.org 70 i 229 Err codemadness.org 70 i 755 Err codemadness.org 70 i 756

Err codemadness.org 70 i 230

Hi,

Err codemadness.org 70 i 231 Err codemadness.org 70 i 232

I'm running mariadb-client-10.6.4v1 and mariadb-server-10.6.4p2v1 installed from the packages on OpenBSD 7.0 which I just upgraded.

Err codemadness.org 70 i 233 I'm also trying to upgrade multiple wikis to MediaWiki 1.37.0. All databases combined are around 800 MB. When updating the smaller wikis I have no issues. However, when running the update script on the biggest wiki, the following error shows up:

Err codemadness.org 70 i 234 Err codemadness.org 70 i 235

Err codemadness.org 70 i 236

Err codemadness.org 70 i 237 Err codemadness.org 70 i 238 Err codemadness.org 70 i 239 Err codemadness.org 70 i 240 Err codemadness.org 70 i 243 Err codemadness.org 70 i 244 Err codemadness.org 70 i 245 Err codemadness.org 70 i 248 Err codemadness.org 70 i 249 Err codemadness.org 70 i 250 Err codemadness.org 70 i 253 Err codemadness.org 70 i 254 Err codemadness.org 70 i 255 Err codemadness.org 70 i 258 Err codemadness.org 70 i 259 Err codemadness.org 70 i 260 Err codemadness.org 70 i 263 Err codemadness.org 70 i 264 Err codemadness.org 70 i 265 Err codemadness.org 70 i 269 Err codemadness.org 70 i 270 Err codemadness.org 70 i 271

Err codemadness.org 70 i 241

Beginning migration of log_search

Err codemadness.org 70 i 242

Err codemadness.org 70 i 246

... target_author_id, ls_value=1 ls_log_id=94785

Err codemadness.org 70 i 247

Err codemadness.org 70 i 251

Wikimedia\Rdbms\DBQueryDisconnectedError from line 1807 of /path/to/project/de/w/includes/libs/rdbms/database/Database.php: A connection error occurred during a query.

Err codemadness.org 70 i 252

Err codemadness.org 70 i 256

Query: SELECT  ls_value,ls_log_id,actor_id  FROM `log_search` LEFT JOIN `actor` ON ((actor_user = CAST( ls_value AS SIGNED )))   WHERE ls_field = 'target_author_id' AND (ls_value > '1' OR ls_value = '1' AND (ls_log_id > '94785'))  ORDER BY ls_value,ls_log_id LIMIT 100

Err codemadness.org 70 i 257

Err codemadness.org 70 i 261

Function: MigrateActors::migrateLogSearch

Err codemadness.org 70 i 262

Err codemadness.org 70 i 266

Error: 2006 MySQL server has gone away (127.0.0.1)	Err	codemadness.org	70
i   267

Err codemadness.org 70 i 268

Err codemadness.org 70 i 272

Err codemadness.org 70 i 273

Err codemadness.org 70 i 274 Err codemadness.org 70 i 275

I also tried this:

Err codemadness.org 70 i 276 Err codemadness.org 70 i 277

Err codemadness.org 70 i 278

Err codemadness.org 70 i 279 Err codemadness.org 70 i 280 Err codemadness.org 70 i 281 Err codemadness.org 70 i 282 Err codemadness.org 70 i 285 Err codemadness.org 70 i 286 Err codemadness.org 70 i 287 Err codemadness.org 70 i 290 Err codemadness.org 70 i 291 Err codemadness.org 70 i 292 Err codemadness.org 70 i 295 Err codemadness.org 70 i 296 Err codemadness.org 70 i 297 Err codemadness.org 70 i 300 Err codemadness.org 70 i 301 Err codemadness.org 70 i 302 Err codemadness.org 70 i 305 Err codemadness.org 70 i 306 Err codemadness.org 70 i 307 Err codemadness.org 70 i 310 Err codemadness.org 70 i 311 Err codemadness.org 70 i 312 Err codemadness.org 70 i 315 Err codemadness.org 70 i 316 Err codemadness.org 70 i 317 Err codemadness.org 70 i 320 Err codemadness.org 70 i 321 Err codemadness.org 70 i 322 Err codemadness.org 70 i 325 Err codemadness.org 70 i 326 Err codemadness.org 70 i 327 Err codemadness.org 70 i 330 Err codemadness.org 70 i 331 Err codemadness.org 70 i 332 Err codemadness.org 70 i 335 Err codemadness.org 70 i 336 Err codemadness.org 70 i 337 Err codemadness.org 70 i 340 Err codemadness.org 70 i 341 Err codemadness.org 70 i 342 Err codemadness.org 70 i 345 Err codemadness.org 70 i 346 Err codemadness.org 70 i 347 Err codemadness.org 70 i 351 Err codemadness.org 70 i 352 Err codemadness.org 70 i 353

Err codemadness.org 70 i 283

MariaDB [dewiki]> select * from log_search where ls_log_id = 94785;

Err codemadness.org 70 i 284

Err codemadness.org 70 i 288

ERROR 2006 (HY000): Server has gone away

Err codemadness.org 70 i 289

Err codemadness.org 70 i 293

No connection. Trying to reconnect...

Err codemadness.org 70 i 294

Err codemadness.org 70 i 298

Connection id:    2216

Err codemadness.org 70 i 299

Err codemadness.org 70 i 303

Current database: dewiki

Err codemadness.org 70 i 304

Err codemadness.org 70 i 308

Err codemadness.org 70 i 309

Err codemadness.org 70 i 313

+---------------------+----------+-----------+

Err codemadness.org 70 i 314

Err codemadness.org 70 i 318

| ls_field            | ls_value | ls_log_id |

Err codemadness.org 70 i 319

Err codemadness.org 70 i 323

+---------------------+----------+-----------+

Err codemadness.org 70 i 324

Err codemadness.org 70 i 328

| log_id              | 93322    |     94785 |

Err codemadness.org 70 i 329

Err codemadness.org 70 i 333

| target_author_actor | 1        |     94785 |

Err codemadness.org 70 i 334

Err codemadness.org 70 i 338

| target_author_id    | 1        |     94785 |

Err codemadness.org 70 i 339

Err codemadness.org 70 i 343

+---------------------+----------+-----------+

Err codemadness.org 70 i 344

Err codemadness.org 70 i 348

3 rows in set (0.002 sec)	Err	codemadness.org	70
i   349

Err codemadness.org 70 i 350

Err codemadness.org 70 i 354

Err codemadness.org 70 i 355

Err codemadness.org 70 i 356 Err codemadness.org 70 i 357

My log file looks like this:

Err codemadness.org 70 i 358 Err codemadness.org 70 i 359

Err codemadness.org 70 i 360

Err codemadness.org 70 i 361 Err codemadness.org 70 i 362 Err codemadness.org 70 i 363 Err codemadness.org 70 i 364 Err codemadness.org 70 i 367 Err codemadness.org 70 i 368 Err codemadness.org 70 i 369 Err codemadness.org 70 i 372 Err codemadness.org 70 i 373 Err codemadness.org 70 i 374 Err codemadness.org 70 i 377 Err codemadness.org 70 i 378 Err codemadness.org 70 i 379 Err codemadness.org 70 i 382 Err codemadness.org 70 i 383 Err codemadness.org 70 i 384 Err codemadness.org 70 i 387 Err codemadness.org 70 i 388 Err codemadness.org 70 i 389 Err codemadness.org 70 i 392 Err codemadness.org 70 i 393 Err codemadness.org 70 i 394 Err codemadness.org 70 i 397 Err codemadness.org 70 i 398 Err codemadness.org 70 i 399 Err codemadness.org 70 i 402 Err codemadness.org 70 i 403 Err codemadness.org 70 i 404 Err codemadness.org 70 i 407 Err codemadness.org 70 i 408 Err codemadness.org 70 i 409 Err codemadness.org 70 i 412 Err codemadness.org 70 i 413 Err codemadness.org 70 i 414 Err codemadness.org 70 i 417 Err codemadness.org 70 i 418 Err codemadness.org 70 i 419 Err codemadness.org 70 i 422 Err codemadness.org 70 i 423 Err codemadness.org 70 i 424 Err codemadness.org 70 i 427 Err codemadness.org 70 i 428 Err codemadness.org 70 i 429 Err codemadness.org 70 i 432 Err codemadness.org 70 i 433 Err codemadness.org 70 i 434 Err codemadness.org 70 i 437 Err codemadness.org 70 i 438 Err codemadness.org 70 i 439 Err codemadness.org 70 i 442 Err codemadness.org 70 i 443 Err codemadness.org 70 i 444 Err codemadness.org 70 i 447 Err codemadness.org 70 i 448 Err codemadness.org 70 i 449 Err codemadness.org 70 i 452 Err codemadness.org 70 i 453 Err codemadness.org 70 i 454 Err codemadness.org 70 i 457 Err codemadness.org 70 i 458 Err codemadness.org 70 i 459 Err codemadness.org 70 i 462 Err codemadness.org 70 i 463 Err codemadness.org 70 i 464 Err codemadness.org 70 i 467 Err codemadness.org 70 i 468 Err codemadness.org 70 i 469 Err codemadness.org 70 i 472 Err codemadness.org 70 i 473 Err codemadness.org 70 i 474 Err codemadness.org 70 i 477 Err codemadness.org 70 i 478 Err codemadness.org 70 i 479 Err codemadness.org 70 i 482 Err codemadness.org 70 i 483 Err codemadness.org 70 i 484 Err codemadness.org 70 i 487 Err codemadness.org 70 i 488 Err codemadness.org 70 i 489 Err codemadness.org 70 i 492 Err codemadness.org 70 i 493 Err codemadness.org 70 i 494 Err codemadness.org 70 i 497 Err codemadness.org 70 i 498 Err codemadness.org 70 i 499 Err codemadness.org 70 i 502 Err codemadness.org 70 i 503 Err codemadness.org 70 i 504 Err codemadness.org 70 i 507 Err codemadness.org 70 i 508 Err codemadness.org 70 i 509 Err codemadness.org 70 i 512 Err codemadness.org 70 i 513 Err codemadness.org 70 i 514 Err codemadness.org 70 i 517 Err codemadness.org 70 i 518 Err codemadness.org 70 i 519 Err codemadness.org 70 i 522 Err codemadness.org 70 i 523 Err codemadness.org 70 i 524 Err codemadness.org 70 i 527 Err codemadness.org 70 i 528 Err codemadness.org 70 i 529 Err codemadness.org 70 i 532 Err codemadness.org 70 i 533 Err codemadness.org 70 i 534 Err codemadness.org 70 i 537 Err codemadness.org 70 i 538 Err codemadness.org 70 i 539 Err codemadness.org 70 i 542 Err codemadness.org 70 i 543 Err codemadness.org 70 i 544 Err codemadness.org 70 i 547 Err codemadness.org 70 i 548 Err codemadness.org 70 i 549 Err codemadness.org 70 i 552 Err codemadness.org 70 i 553 Err codemadness.org 70 i 554 Err codemadness.org 70 i 557 Err codemadness.org 70 i 558 Err codemadness.org 70 i 559 Err codemadness.org 70 i 562 Err codemadness.org 70 i 563 Err codemadness.org 70 i 564 Err codemadness.org 70 i 567 Err codemadness.org 70 i 568 Err codemadness.org 70 i 569 Err codemadness.org 70 i 572 Err codemadness.org 70 i 573 Err codemadness.org 70 i 574 Err codemadness.org 70 i 577 Err codemadness.org 70 i 578 Err codemadness.org 70 i 579 Err codemadness.org 70 i 582 Err codemadness.org 70 i 583 Err codemadness.org 70 i 584 Err codemadness.org 70 i 587 Err codemadness.org 70 i 588 Err codemadness.org 70 i 589 Err codemadness.org 70 i 592 Err codemadness.org 70 i 593 Err codemadness.org 70 i 594 Err codemadness.org 70 i 597 Err codemadness.org 70 i 598 Err codemadness.org 70 i 599 Err codemadness.org 70 i 602 Err codemadness.org 70 i 603 Err codemadness.org 70 i 604 Err codemadness.org 70 i 607 Err codemadness.org 70 i 608 Err codemadness.org 70 i 609 Err codemadness.org 70 i 612 Err codemadness.org 70 i 613 Err codemadness.org 70 i 614 Err codemadness.org 70 i 617 Err codemadness.org 70 i 618 Err codemadness.org 70 i 619 Err codemadness.org 70 i 622 Err codemadness.org 70 i 623 Err codemadness.org 70 i 624 Err codemadness.org 70 i 627 Err codemadness.org 70 i 628 Err codemadness.org 70 i 629 Err codemadness.org 70 i 632 Err codemadness.org 70 i 633 Err codemadness.org 70 i 634 Err codemadness.org 70 i 637 Err codemadness.org 70 i 638 Err codemadness.org 70 i 639 Err codemadness.org 70 i 642 Err codemadness.org 70 i 643 Err codemadness.org 70 i 644 Err codemadness.org 70 i 647 Err codemadness.org 70 i 648 Err codemadness.org 70 i 649 Err codemadness.org 70 i 652 Err codemadness.org 70 i 653 Err codemadness.org 70 i 654 Err codemadness.org 70 i 657 Err codemadness.org 70 i 658 Err codemadness.org 70 i 659 Err codemadness.org 70 i 662 Err codemadness.org 70 i 663 Err codemadness.org 70 i 664 Err codemadness.org 70 i 667 Err codemadness.org 70 i 668 Err codemadness.org 70 i 669 Err codemadness.org 70 i 672 Err codemadness.org 70 i 673 Err codemadness.org 70 i 674 Err codemadness.org 70 i 677 Err codemadness.org 70 i 678 Err codemadness.org 70 i 679 Err codemadness.org 70 i 682 Err codemadness.org 70 i 683 Err codemadness.org 70 i 684 Err codemadness.org 70 i 687 Err codemadness.org 70 i 688 Err codemadness.org 70 i 689 Err codemadness.org 70 i 692 Err codemadness.org 70 i 693 Err codemadness.org 70 i 694 Err codemadness.org 70 i 697 Err codemadness.org 70 i 698 Err codemadness.org 70 i 699 Err codemadness.org 70 i 702 Err codemadness.org 70 i 703 Err codemadness.org 70 i 704 Err codemadness.org 70 i 707 Err codemadness.org 70 i 708 Err codemadness.org 70 i 709 Err codemadness.org 70 i 712 Err codemadness.org 70 i 713 Err codemadness.org 70 i 714 Err codemadness.org 70 i 717 Err codemadness.org 70 i 718 Err codemadness.org 70 i 719 Err codemadness.org 70 i 722 Err codemadness.org 70 i 723 Err codemadness.org 70 i 724 Err codemadness.org 70 i 727 Err codemadness.org 70 i 728 Err codemadness.org 70 i 729 Err codemadness.org 70 i 732 Err codemadness.org 70 i 733 Err codemadness.org 70 i 734 Err codemadness.org 70 i 738 Err codemadness.org 70 i 739 Err codemadness.org 70 i 740

Err codemadness.org 70 i 365

211120  9:34:08 [ERROR] mysqld got signal 11 ;

Err codemadness.org 70 i 366

Err codemadness.org 70 i 370

This could be because you hit a bug. It is also possible that this binary

Err codemadness.org 70 i 371

Err codemadness.org 70 i 375

or one of the libraries it was linked against is corrupt, improperly built,

Err codemadness.org 70 i 376

Err codemadness.org 70 i 380

or misconfigured. This error can also be caused by malfunctioning hardware.

Err codemadness.org 70 i 381

Err codemadness.org 70 i 385

Err codemadness.org 70 i 386

Err codemadness.org 70 i 390

To report this bug, see https://mariadb.com/kb/en/reporting-bugs

Err codemadness.org 70 i 391

Err codemadness.org 70 i 395

Err codemadness.org 70 i 396

Err codemadness.org 70 i 400

We will try our best to scrape up some info that will hopefully help

Err codemadness.org 70 i 401

Err codemadness.org 70 i 405

diagnose the problem, but since we have already crashed,

Err codemadness.org 70 i 406

Err codemadness.org 70 i 410

something is definitely wrong and this may fail.

Err codemadness.org 70 i 411

Err codemadness.org 70 i 415

Err codemadness.org 70 i 416

Err codemadness.org 70 i 420

Server version: 10.6.4-MariaDB-log

Err codemadness.org 70 i 421

Err codemadness.org 70 i 425

key_buffer_size=104857600

Err codemadness.org 70 i 426

Err codemadness.org 70 i 430

read_buffer_size=2621440

Err codemadness.org 70 i 431

Err codemadness.org 70 i 435

max_used_connections=30

Err codemadness.org 70 i 436

Err codemadness.org 70 i 440

max_threads=153

Err codemadness.org 70 i 441

Err codemadness.org 70 i 445

thread_count=31

Err codemadness.org 70 i 446

Err codemadness.org 70 i 450

It is possible that mysqld could use up to

Err codemadness.org 70 i 451

Err codemadness.org 70 i 455

key_buffer_size + (read_buffer_size + sort_buffer_size)*max_threads = 1281306 K  bytes of memory

Err codemadness.org 70 i 456

Err codemadness.org 70 i 460

Hope that's ok; if not, decrease some variables in the equation.

Err codemadness.org 70 i 461

Err codemadness.org 70 i 465

Err codemadness.org 70 i 466

Err codemadness.org 70 i 470

Thread pointer: 0x5a866a4c018

Err codemadness.org 70 i 471

Err codemadness.org 70 i 475

Attempting backtrace. You can use the following information to find out

Err codemadness.org 70 i 476

Err codemadness.org 70 i 480

where mysqld died. If you see no messages after this, something went

Err codemadness.org 70 i 481

Err codemadness.org 70 i 485

terribly wrong...

Err codemadness.org 70 i 486

Err codemadness.org 70 i 490

stack_bottom = 0x5a8a20bbed8 thread_stack 0x49000

Err codemadness.org 70 i 491

Err codemadness.org 70 i 495

??:0(my_print_stacktrace)[0x5a65fad84bb]

Err codemadness.org 70 i 496

Err codemadness.org 70 i 500

Err codemadness.org 70 i 501

Err codemadness.org 70 i 505

Trying to get some variables.

Err codemadness.org 70 i 506

Err codemadness.org 70 i 510

Some pointers may be invalid and cause the dump to abort.

Err codemadness.org 70 i 511

Err codemadness.org 70 i 515

Query (0x5a88bb75030): SELECT /* MigrateActors::migrateLogSearch user@project... */  ls_value,ls_log_id,actor_id  FROM `log_search` LEFT JOIN `actor` ON ((actor_user = CAST( ls_value AS SIGNED )))   WHERE ls_field = 'target_author_id' AND (ls_value > '1' OR ls_value = '1' AND (ls_log_id > '94785'))  ORDER BY ls_v

Err codemadness.org 70 i 516

Err codemadness.org 70 i 520

alue,ls_log_id LIMIT 100

Err codemadness.org 70 i 521

Err codemadness.org 70 i 525

Err codemadness.org 70 i 526

Err codemadness.org 70 i 530

Connection ID (thread ID): 204864

Err codemadness.org 70 i 531

Err codemadness.org 70 i 535

Status: NOT_KILLED

Err codemadness.org 70 i 536

Err codemadness.org 70 i 540

Err codemadness.org 70 i 541

Err codemadness.org 70 i 545

Optimizer switch: index_merge=on,index_merge_union=on,index_merge_sort_union=on,index_merge_intersection=on,index_merge_sort_intersection=off,engine_condition_pushdown=off,index_condition_pushdown=on,derived_merge=on,derived_with_keys=on,firstmatch=on,loosescan=on,materialization=on,in_to_exists=on,semijoin=on,parti

Err codemadness.org 70 i 546

Err codemadness.org 70 i 550

al_match_rowid_merge=on,partial_match_table_scan=on,subquery_cache=on,mrr=off,mrr_cost_based=off,mrr_sort_keys=off,outer_join_with_cache=on,semijoin_with_cache=on,join_cache_incremental=on,join_cache_hashed=on,join_cache_bka=on,optimize_join_buffer_size=on,table_elimination=on,extended_keys=on,exists_to_in=on,orderb

Err codemadness.org 70 i 551

Err codemadness.org 70 i 555

y_uses_equalities=on,condition_pushdown_for_derived=on,split_materialized=on,condition_pushdown_for_subquery=on,rowid_filter=on,condition_pushdown_from_having=on,not_null_range_scan=off

Err codemadness.org 70 i 556

Err codemadness.org 70 i 560

Err codemadness.org 70 i 561

Err codemadness.org 70 i 565

The manual page at https://mariadb.com/kb/en/how-to-produce-a-full-stack-trace-for-mysqld/ contains

Err codemadness.org 70 i 566

Err codemadness.org 70 i 570

information that should help you find out what is causing the crash.

Err codemadness.org 70 i 571

Err codemadness.org 70 i 575

2021-11-20  9:34:08 0 [Note] InnoDB: Compressed tables use zlib 1.2.11

Err codemadness.org 70 i 576

Err codemadness.org 70 i 580

2021-11-20  9:34:08 0 [Note] InnoDB: Number of pools: 1

Err codemadness.org 70 i 581

Err codemadness.org 70 i 585

2021-11-20  9:34:08 0 [Note] InnoDB: Using crc32 + pclmulqdq instructions

Err codemadness.org 70 i 586

Err codemadness.org 70 i 590

2021-11-20  9:34:08 0 [Note] InnoDB: Initializing buffer pool, total size = 134217728, chunk size = 134217728

Err codemadness.org 70 i 591

Err codemadness.org 70 i 595

2021-11-20  9:34:08 0 [Note] InnoDB: Completed initialization of buffer pool

Err codemadness.org 70 i 596

Err codemadness.org 70 i 600

2021-11-20  9:34:08 0 [Note] InnoDB: Starting crash recovery from checkpoint LSN=1256130111787,1256130114039

Err codemadness.org 70 i 601

Err codemadness.org 70 i 605

2021-11-20  9:34:08 0 [Note] InnoDB: Transaction 4832069210 was in the XA prepared state.

Err codemadness.org 70 i 606

Err codemadness.org 70 i 610

2021-11-20  9:34:08 0 [Note] InnoDB: 1 transaction(s) which must be rolled back or cleaned up in total 0 row operations to undo

Err codemadness.org 70 i 611

Err codemadness.org 70 i 615

2021-11-20  9:34:08 0 [Note] InnoDB: Trx id counter is 4832069211

Err codemadness.org 70 i 616

Err codemadness.org 70 i 620

2021-11-20  9:34:08 0 [Note] InnoDB: Starting final batch to recover 76 pages from redo log.

Err codemadness.org 70 i 621

Err codemadness.org 70 i 625

2021-11-20  9:34:09 0 [Note] InnoDB: Last binlog file './mysql-bin.000317', position 20068278

Err codemadness.org 70 i 626

Err codemadness.org 70 i 630

2021-11-20  9:34:09 0 [Note] InnoDB: 128 rollback segments are active.

Err codemadness.org 70 i 631

Err codemadness.org 70 i 635

2021-11-20  9:34:09 0 [Note] InnoDB: Starting in background the rollback of recovered transactions

Err codemadness.org 70 i 636

Err codemadness.org 70 i 640

2021-11-20  9:34:09 0 [Note] InnoDB: Rollback of non-prepared transactions completed

Err codemadness.org 70 i 641

Err codemadness.org 70 i 645

2021-11-20  9:34:09 0 [Note] InnoDB: Removed temporary tablespace data file: "./ibtmp1"

Err codemadness.org 70 i 646

Err codemadness.org 70 i 650

2021-11-20  9:34:09 0 [Note] InnoDB: Creating shared tablespace for temporary tables

Err codemadness.org 70 i 651

Err codemadness.org 70 i 655

2021-11-20  9:34:09 0 [Note] InnoDB: Setting file './ibtmp1' size to 12 MB. Physically writing the file full; Please wait ...

Err codemadness.org 70 i 656

Err codemadness.org 70 i 660

2021-11-20  9:34:09 0 [Note] InnoDB: File './ibtmp1' size is now 12 MB.

Err codemadness.org 70 i 661

Err codemadness.org 70 i 665

2021-11-20  9:34:09 0 [Note] InnoDB: 10.6.4 started; log sequence number 1256130420821; transaction id 4832069212

Err codemadness.org 70 i 666

Err codemadness.org 70 i 670

2021-11-20  9:34:09 0 [Note] InnoDB: Loading buffer pool(s) from /var/mysql/ib_buffer_pool

Err codemadness.org 70 i 671

Err codemadness.org 70 i 675

2021-11-20  9:34:09 0 [Note] Plugin 'FEEDBACK' is disabled.

Err codemadness.org 70 i 676

Err codemadness.org 70 i 680

2021-11-20  9:34:09 0 [Note] Recovering after a crash using mysql-bin

Err codemadness.org 70 i 681

Err codemadness.org 70 i 685

2021-11-20  9:34:09 0 [Note] Starting table crash recovery...

Err codemadness.org 70 i 686

Err codemadness.org 70 i 690

2021-11-20  9:34:09 0 [Note] InnoDB: Starting recovery for XA transactions...

Err codemadness.org 70 i 691

Err codemadness.org 70 i 695

2021-11-20  9:34:09 0 [Note] InnoDB: Transaction 4832069210 in prepared state after recovery

Err codemadness.org 70 i 696

Err codemadness.org 70 i 700

2021-11-20  9:34:09 0 [Note] InnoDB: Transaction contains changes to 1 rows

Err codemadness.org 70 i 701

Err codemadness.org 70 i 705

2021-11-20  9:34:09 0 [Note] InnoDB: 1 transactions in prepared state after recovery

Err codemadness.org 70 i 706

Err codemadness.org 70 i 710

2021-11-20  9:34:09 0 [Note] Found 1 prepared transaction(s) in InnoDB

Err codemadness.org 70 i 711

Err codemadness.org 70 i 715

2021-11-20  9:34:09 0 [Note] Crash table recovery finished.

Err codemadness.org 70 i 716

Err codemadness.org 70 i 720

2021-11-20  9:34:09 0 [Note] InnoDB: Buffer pool(s) load completed at 211120  9:34:09

Err codemadness.org 70 i 721

Err codemadness.org 70 i 725

2021-11-20  9:34:09 0 [Note] Server socket created on IP: '127.0.0.1'.

Err codemadness.org 70 i 726

Err codemadness.org 70 i 730

2021-11-20  9:34:09 0 [Note] /usr/local/libexec/mariadbd: ready for connections.

Err codemadness.org 70 i 731

Err codemadness.org 70 i 735

Version: '10.6.4-MariaDB-log'  socket: '/var/run/mysql/mysql.sock'  port: 3306  OpenBSD port: mariadb-server-10.6.4p2v1	Err	codemadness.org	70
i   736

Err codemadness.org 70 i 737

Err codemadness.org 70 i 741

Err codemadness.org 70 i 742

Err codemadness.org 70 i 743 Err codemadness.org 70 i 744

I already increased key_buffer_size, read_buffer_size and sort_buffer_size but the error still occurs.

Err codemadness.org 70 i 745 Err codemadness.org 70 i 746

The same error also appeared when I tried to make a backup via mysqldump but TRUNCATE TABLE objectcache fixed this.

Err codemadness.org 70 i 747 Err codemadness.org 70 i 748

I already performed mariadb-upgrade. I also uninstalled and reinstalled mariadb-client-10.6.4v1 and mariadb-server-10.6.4p2v1 but the error still occurs. I don't really know what to do anymore so any help is more than appreciated!

Err codemadness.org 70 i 749 Err codemadness.org 70 i 750

Thanks and cheers,

Err codemadness.org 70 i 751 Err codemadness.org 70 i 752

Till

Err codemadness.org 70 i 753

Err codemadness.org 70 i 754

Err codemadness.org 70 i 757 Err codemadness.org 70 i 758

Err codemadness.org 70 i 759 Err codemadness.org 70 i 760 Err codemadness.org 70 i 761 Err codemadness.org 70 i 762 Err codemadness.org 70 i 765 Err codemadness.org 70 i 766 Err codemadness.org 70 i 767

Err codemadness.org 70 i 763 Comments Err codemadness.org 70 i 764

Err codemadness.org 70 i 768 Err codemadness.org 70 i 769 Err codemadness.org 70 i 770 Err codemadness.org 70 i 781 Err codemadness.org 70 i 788

Err codemadness.org 70 i 771 Comment by Err codemadness.org 70 i 772 Till Kraemer Err codemadness.org 70 i 773 Err codemadness.org 70 i 774 [ Err codemadness.org 70 i 775 2021-11-20 Err codemadness.org 70 i 776 Err codemadness.org 70 i 777 ] Err codemadness.org 70 i 778 Err codemadness.org 70 i 779 Err codemadness.org 70 i 780

Err codemadness.org 70 i 782

I ran mysqlcheck -o --databases dewiki and now it works! Thank you so much for the suggestion, billynoah from Database Administrators on Stack Exchange!

Err codemadness.org 70 i 783 Err codemadness.org 70 i 784

Thanks, cheers and all the best!

Err codemadness.org 70 i 785 Err codemadness.org 70 i 786

Till

Err codemadness.org 70 i 787

Err codemadness.org 70 i 789

[MDEV-27097] MariaDB download not possible

Marc — Sat, 20 Nov 2021 11:44:02 +0000

Err codemadness.org 70 i 865 Err codemadness.org 70 i 866 Err codemadness.org 70 i 875 Err codemadness.org 70 i 876 Err codemadness.org 70 i 877 Err codemadness.org 70 i 878 Err codemadness.org 70 i 879 Err codemadness.org 70 i 880 Err codemadness.org 70 i 881 Err codemadness.org 70 i 882 Err codemadness.org 70 i 883 Err codemadness.org 70 i 884 Err codemadness.org 70 i 885 Err codemadness.org 70 i 886 Err codemadness.org 70 i 887 Err codemadness.org 70 i 890 Err codemadness.org 70 i 891 Err codemadness.org 70 i 892 Err codemadness.org 70 i 893 Err codemadness.org 70 i 894 Err codemadness.org 70 i 895 Err codemadness.org 70 i 897 Err codemadness.org 70 i 898 Err codemadness.org 70 i 899 Err codemadness.org 70 i 900 Err codemadness.org 70 i 901 Err codemadness.org 70 i 902 Err codemadness.org 70 i 905 Err codemadness.org 70 i 906 Err codemadness.org 70 i 907

Err codemadness.org 70 i 867 Err codemadness.org 70 i 868 [MDEV-27097] MariaDB download not possible Err codemadness.org 70 i 869 Err codemadness.org 70 i 870 Created: 2021-11-20 Updated: 2021-11-20 Err codemadness.org 70 i 871 Err codemadness.org 70 i 872 Err codemadness.org 70 i 873 Err codemadness.org 70 i 874
Status:	Open
Project:	MariaDB Server
Component/s:	Err codemadness.org 70 i 888 None Err codemadness.org 70 i 889
Affects Version/s:	Err codemadness.org 70 i 896 10.6.5
Fix Version/s:	Err codemadness.org 70 i 903 None Err codemadness.org 70 i 904

Err codemadness.org 70 i 908 Err codemadness.org 70 i 909

Err codemadness.org 70 i 910 Err codemadness.org 70 i 911 Err codemadness.org 70 i 912 Err codemadness.org 70 i 915 Err codemadness.org 70 i 918 Err codemadness.org 70 i 919 Err codemadness.org 70 i 922 Err codemadness.org 70 i 925 Err codemadness.org 70 i 926 Err codemadness.org 70 i 927 Err codemadness.org 70 i 930 Err codemadness.org 70 i 933 Err codemadness.org 70 i 934 Err codemadness.org 70 i 937 Err codemadness.org 70 i 940 Err codemadness.org 70 i 941 Err codemadness.org 70 i 942 Err codemadness.org 70 i 945 Err codemadness.org 70 i 948 Err codemadness.org 70 i 951 Err codemadness.org 70 i 954 Err codemadness.org 70 i 955 Err codemadness.org 70 i 956 Err codemadness.org 70 i 957 Err codemadness.org 70 i 958 Err codemadness.org 70 i 961 Err codemadness.org 70 i 964 Err codemadness.org 70 i 965 Err codemadness.org 70 i 966 Err codemadness.org 70 i 967 Err codemadness.org 70 i 968 Err codemadness.org 70 i 969 Err codemadness.org 70 i 970

Err codemadness.org 70 i 913 Type: Err codemadness.org 70 i 914

Err codemadness.org 70 i 916 Bug Err codemadness.org 70 i 917

Err codemadness.org 70 i 920 Priority: Err codemadness.org 70 i 921

Err codemadness.org 70 i 923 Blocker Err codemadness.org 70 i 924

Err codemadness.org 70 i 928 Reporter: Err codemadness.org 70 i 929

Err codemadness.org 70 i 931 Marc Err codemadness.org 70 i 932

Err codemadness.org 70 i 935 Assignee: Err codemadness.org 70 i 936

Err codemadness.org 70 i 938 Unassigned Err codemadness.org 70 i 939

Err codemadness.org 70 i 943 Resolution: Err codemadness.org 70 i 944

Err codemadness.org 70 i 946 Unresolved Err codemadness.org 70 i 947

Err codemadness.org 70 i 949 Votes: Err codemadness.org 70 i 950

Err codemadness.org 70 i 952 0 Err codemadness.org 70 i 953

Err codemadness.org 70 i 959 Labels: Err codemadness.org 70 i 960

Err codemadness.org 70 i 962 None Err codemadness.org 70 i 963

Err codemadness.org 70 i 971 Err codemadness.org 70 i 972 Err codemadness.org 70 i 973 Err codemadness.org 70 i 974

Err codemadness.org 70 i 975 Err codemadness.org 70 i 976 Err codemadness.org 70 i 977 Err codemadness.org 70 i 978 Err codemadness.org 70 i 979 Err codemadness.org 70 i 980 Err codemadness.org 70 i 981 Err codemadness.org 70 i 982 Err codemadness.org 70 i 983 Err codemadness.org 70 i 984

Err codemadness.org 70 i 985 Err codemadness.org 70 i 986

Err codemadness.org 70 i 987 Err codemadness.org 70 i 988 Err codemadness.org 70 i 989 Err codemadness.org 70 i 990 Err codemadness.org 70 i 993 Err codemadness.org 70 i 994 Err codemadness.org 70 i 995

Err codemadness.org 70 i 991 Description Err codemadness.org 70 i 992

Err codemadness.org 70 i 996 Err codemadness.org 70 i 997 Err codemadness.org 70 i 998 Err codemadness.org 70 i 999 Err codemadness.org 70 i 1007 Err codemadness.org 70 i 1008

Err codemadness.org 70 i 1000

Downloads like we had for years, e.g. for updating rpm's do not work anymore. Manual downloads stop and can't resume. At least the manual downloaded files (if it works) have different structure.

Err codemadness.org 70 i 1001 Err codemadness.org 70 i 1002

I usually downloaded the files via:

Err codemadness.org 70 i 1003 wget https://downloads.mariadb.org/interstitial/mariadb-10.6.5/source/mariadb-10.6.5.tar.gz

Err codemadness.org 70 i 1004 (automatically via rpm-update) to provide the package for Mageia distribution. Now this does not work anymore. Why? Can you reenable it?

Err codemadness.org 70 i 1005

Err codemadness.org 70 i 1006

Err codemadness.org 70 i 1009 Err codemadness.org 70 i 1010

[MDEV-15250] UPSERT during ALTER-TABLE results in 'Duplicate entry' error for alter

sjon — Tue, 16 Nov 2021 13:29:15 +0000

Err codemadness.org 70 i 1086 Err codemadness.org 70 i 1087 Err codemadness.org 70 i 1096 Err codemadness.org 70 i 1097 Err codemadness.org 70 i 1098 Err codemadness.org 70 i 1099 Err codemadness.org 70 i 1100 Err codemadness.org 70 i 1101 Err codemadness.org 70 i 1102 Err codemadness.org 70 i 1103 Err codemadness.org 70 i 1104 Err codemadness.org 70 i 1105 Err codemadness.org 70 i 1106 Err codemadness.org 70 i 1107 Err codemadness.org 70 i 1108 Err codemadness.org 70 i 1110 Err codemadness.org 70 i 1111 Err codemadness.org 70 i 1112 Err codemadness.org 70 i 1113 Err codemadness.org 70 i 1114 Err codemadness.org 70 i 1115 Err codemadness.org 70 i 1117 Err codemadness.org 70 i 1118 Err codemadness.org 70 i 1119 Err codemadness.org 70 i 1120 Err codemadness.org 70 i 1121 Err codemadness.org 70 i 1122 Err codemadness.org 70 i 1124 Err codemadness.org 70 i 1125 Err codemadness.org 70 i 1126

Err codemadness.org 70 i 1088 Err codemadness.org 70 i 1089 [MDEV-15250] UPSERT during ALTER-TABLE results in 'Duplicate entry' error for alter Err codemadness.org 70 i 1090 Err codemadness.org 70 i 1091 Created: 2018-02-08 Updated: 2021-11-16 Err codemadness.org 70 i 1092 Err codemadness.org 70 i 1093 Err codemadness.org 70 i 1094 Err codemadness.org 70 i 1095
Status:	Stalled
Project:	MariaDB Server
Component/s:	Err codemadness.org 70 i 1109 Data Definition - Alter Table, Locking, Replication, Storage Engine - InnoDB
Affects Version/s:	Err codemadness.org 70 i 1116 10.0, 10.1, 10.2, 10.3, 10.1.30, 10.4, 10.5, 10.6, 10.7, 10.8
Fix Version/s:	Err codemadness.org 70 i 1123 10.3, 10.4, 10.5, 10.6, 10.7, 10.8

Err codemadness.org 70 i 1127 Err codemadness.org 70 i 1128

Err codemadness.org 70 i 1129 Err codemadness.org 70 i 1130 Err codemadness.org 70 i 1131 Err codemadness.org 70 i 1134 Err codemadness.org 70 i 1137 Err codemadness.org 70 i 1138 Err codemadness.org 70 i 1141 Err codemadness.org 70 i 1144 Err codemadness.org 70 i 1145 Err codemadness.org 70 i 1146 Err codemadness.org 70 i 1149 Err codemadness.org 70 i 1152 Err codemadness.org 70 i 1153 Err codemadness.org 70 i 1156 Err codemadness.org 70 i 1159 Err codemadness.org 70 i 1160 Err codemadness.org 70 i 1161 Err codemadness.org 70 i 1164 Err codemadness.org 70 i 1167 Err codemadness.org 70 i 1170 Err codemadness.org 70 i 1173 Err codemadness.org 70 i 1174 Err codemadness.org 70 i 1175 Err codemadness.org 70 i 1176 Err codemadness.org 70 i 1177 Err codemadness.org 70 i 1180 Err codemadness.org 70 i 1183 Err codemadness.org 70 i 1184 Err codemadness.org 70 i 1185 Err codemadness.org 70 i 1186 Err codemadness.org 70 i 1187 Err codemadness.org 70 i 1188 Err codemadness.org 70 i 1189

Err codemadness.org 70 i 1132 Type: Err codemadness.org 70 i 1133

Err codemadness.org 70 i 1135 Bug Err codemadness.org 70 i 1136

Err codemadness.org 70 i 1139 Priority: Err codemadness.org 70 i 1140

Err codemadness.org 70 i 1142 Blocker Err codemadness.org 70 i 1143

Err codemadness.org 70 i 1147 Reporter: Err codemadness.org 70 i 1148

Err codemadness.org 70 i 1150 sjon Err codemadness.org 70 i 1151

Err codemadness.org 70 i 1154 Assignee: Err codemadness.org 70 i 1155

Err codemadness.org 70 i 1157 Marko Mäkelä Err codemadness.org 70 i 1158

Err codemadness.org 70 i 1162 Resolution: Err codemadness.org 70 i 1163

Err codemadness.org 70 i 1165 Unresolved Err codemadness.org 70 i 1166

Err codemadness.org 70 i 1168 Votes: Err codemadness.org 70 i 1169

Err codemadness.org 70 i 1171 1 Err codemadness.org 70 i 1172

Err codemadness.org 70 i 1178 Labels: Err codemadness.org 70 i 1179

Err codemadness.org 70 i 1181 None Err codemadness.org 70 i 1182

Err codemadness.org 70 i 1190 Err codemadness.org 70 i 1191 Err codemadness.org 70 i 1192 Err codemadness.org 70 i 1193

Err codemadness.org 70 i 1194 Err codemadness.org 70 i 1195 Err codemadness.org 70 i 1196 Err codemadness.org 70 i 1197 Err codemadness.org 70 i 1198 Err codemadness.org 70 i 1199 Err codemadness.org 70 i 1200 Err codemadness.org 70 i 1203 Err codemadness.org 70 i 1242 Err codemadness.org 70 i 1243 Err codemadness.org 70 i 1244 Err codemadness.org 70 i 1245 Err codemadness.org 70 i 1246 Err codemadness.org 70 i 1247

Err codemadness.org 70 i 1201 Issue Links: Err codemadness.org 70 i 1202

Err codemadness.org 70 i 1204 Err codemadness.org 70 i 1205 Err codemadness.org 70 i 1206 Err codemadness.org 70 i 1209 Err codemadness.org 70 i 1210 Err codemadness.org 70 i 1211 Err codemadness.org 70 i 1214 Err codemadness.org 70 i 1218 Err codemadness.org 70 i 1221 Err codemadness.org 70 i 1224 Err codemadness.org 70 i 1225 Err codemadness.org 70 i 1226 Err codemadness.org 70 i 1229 Err codemadness.org 70 i 1233 Err codemadness.org 70 i 1236 Err codemadness.org 70 i 1239 Err codemadness.org 70 i 1240

Err codemadness.org 70 i 1207 Relates Err codemadness.org 70 i 1208
Err codemadness.org 70 i 1212 relates to Err codemadness.org 70 i 1213	Err codemadness.org 70 i 1215 Err codemadness.org 70 i 1216 ~~MDEV-14535~~ Err codemadness.org 70 i 1217	Err codemadness.org 70 i 1219 Duplicate entry on ALTER TABLE ADD CO... Err codemadness.org 70 i 1220	Err codemadness.org 70 i 1222 Closed Err codemadness.org 70 i 1223
Err codemadness.org 70 i 1227 relates to Err codemadness.org 70 i 1228	Err codemadness.org 70 i 1230 Err codemadness.org 70 i 1231 MDEV-16329 Err codemadness.org 70 i 1232	Err codemadness.org 70 i 1234 ALTER ONLINE TABLE Err codemadness.org 70 i 1235	Err codemadness.org 70 i 1237 In Review Err codemadness.org 70 i 1238

Err codemadness.org 70 i 1241

Err codemadness.org 70 i 1248 Err codemadness.org 70 i 1249

Err codemadness.org 70 i 1250 Err codemadness.org 70 i 1251 Err codemadness.org 70 i 1252 Err codemadness.org 70 i 1253 Err codemadness.org 70 i 1256 Err codemadness.org 70 i 1257 Err codemadness.org 70 i 1258

Err codemadness.org 70 i 1254 Description Err codemadness.org 70 i 1255

Err codemadness.org 70 i 1259 Err codemadness.org 70 i 1260 Err codemadness.org 70 i 1261 Err codemadness.org 70 i 1262 Err codemadness.org 70 i 1270 Err codemadness.org 70 i 1271

Err codemadness.org 70 i 1263

I have a master that very frequently executes INSERT ON DUPLICATE KEY UPDATE. On a slave I executed ALTER TABLE xx row_format=COMPRESSED;, however this resulted in an error (the specific key is a UNIQUE) from the ALTER statement, which did not succeed:

Err codemadness.org 70 i 1264 Err codemadness.org 70 i 1265

ERROR 1062 (23000): Duplicate entry 'xxx-xxx' for key 'xxx'

Err codemadness.org 70 i 1266 Err codemadness.org 70 i 1267

I assume this is because it received an UPSERT while it was altering the table. I think this shouldn't happen as the alter-table should have a lock on the table.

Err codemadness.org 70 i 1268

Err codemadness.org 70 i 1269

Err codemadness.org 70 i 1272 Err codemadness.org 70 i 1273

Err codemadness.org 70 i 1274 Err codemadness.org 70 i 1275 Err codemadness.org 70 i 1276 Err codemadness.org 70 i 1277 Err codemadness.org 70 i 1280 Err codemadness.org 70 i 1281 Err codemadness.org 70 i 1282

Err codemadness.org 70 i 1278 Comments Err codemadness.org 70 i 1279

Err codemadness.org 70 i 1283 Err codemadness.org 70 i 1284 Err codemadness.org 70 i 1285 Err codemadness.org 70 i 1296 Err codemadness.org 70 i 1299 Err codemadness.org 70 i 1310 Err codemadness.org 70 i 1313 Err codemadness.org 70 i 1324 Err codemadness.org 70 i 1331 Err codemadness.org 70 i 1342 Err codemadness.org 70 i 1345

Err codemadness.org 70 i 1286 Comment by Err codemadness.org 70 i 1287 Elena Stepanova Err codemadness.org 70 i 1288 Err codemadness.org 70 i 1289 [ Err codemadness.org 70 i 1290 2018-03-07 Err codemadness.org 70 i 1291 Err codemadness.org 70 i 1292 ] Err codemadness.org 70 i 1293 Err codemadness.org 70 i 1294 Err codemadness.org 70 i 1295

Err codemadness.org 70 i 1297

Please provide SHOW CREATE TABLE for the table before and after ALTER, indicate what exactly UPDATE updates, and attach your config files. Thanks.

Err codemadness.org 70 i 1298

Err codemadness.org 70 i 1300 Comment by Err codemadness.org 70 i 1301 Marko Mäkelä Err codemadness.org 70 i 1302 Err codemadness.org 70 i 1303 [ Err codemadness.org 70 i 1304 2021-11-12 Err codemadness.org 70 i 1305 Err codemadness.org 70 i 1306 ] Err codemadness.org 70 i 1307 Err codemadness.org 70 i 1308 Err codemadness.org 70 i 1309

Err codemadness.org 70 i 1311

I do not need a test case to confirm that this is a problem of my design of WL#5526 and WL#6255 in MySQL 5.6, affecting MariaDB 10.0 and later. The same issue was mentioned in ~~MDEV-14535~~ but fixed in a special case.

Err codemadness.org 70 i 1312

Err codemadness.org 70 i 1314 Comment by Err codemadness.org 70 i 1315 Marko Mäkelä Err codemadness.org 70 i 1316 Err codemadness.org 70 i 1317 [ Err codemadness.org 70 i 1318 2021-11-12 Err codemadness.org 70 i 1319 Err codemadness.org 70 i 1320 ] Err codemadness.org 70 i 1321 Err codemadness.org 70 i 1322 Err codemadness.org 70 i 1323

Err codemadness.org 70 i 1325

The design problem is that currently, any DML operations that are being executed concurrently with an online index creation (MySQL WL#5526) or online table rebuild (MySQL WL#6625) will be logged immediately. For example, BEGIN;INSERT;ROLLBACK; will be logged as INSERT and DELETE.

Err codemadness.org 70 i 1326 Err codemadness.org 70 i 1327

To prevent the ‘fake’ duplicates, we can simply write online_log on transaction commit. In that way, any duplicate key errors during online table rebuild will be filtered out from the online_log, because such duplicate key errors would also occur on the original table, leading to full or partial rollback of the transaction.

Err codemadness.org 70 i 1328 Err codemadness.org 70 i 1329

That is, on transaction commit, we would check if any table in trx_t::mod_tables requires changes to be logged. If yes, we would scan the undo logs that the transaction generated, and write online_log to the affected tables during transaction commit.

Err codemadness.org 70 i 1330

Err codemadness.org 70 i 1332 Comment by Err codemadness.org 70 i 1333 Marko Mäkelä Err codemadness.org 70 i 1334 Err codemadness.org 70 i 1335 [ Err codemadness.org 70 i 1336 2021-11-13 Err codemadness.org 70 i 1337 Err codemadness.org 70 i 1338 ] Err codemadness.org 70 i 1339 Err codemadness.org 70 i 1340 Err codemadness.org 70 i 1341

Err codemadness.org 70 i 1343

In secondary index creation (especially CREATE UNIQUE INDEX or ALTER TABLE…ADD UNIQUE INDEX) there is an additional phenomenon: A secondary index may be complete but not committed. That is, the online secondary index creation operation would wait for an exclusive metadata lock so that the operation can be committed. A conflicting metadata lock could be held by a transaction that is concurrently modifying the table. Such transactions will have to update the uncommitted index directly. Duplicate key errors must not be reported to the DML transaction if the unique index has not been committed yet. They are reported to the DDL transaction. Also such reporting is now premature and could lead to false duplicates. I think that we can apply changes to uncommitted indexes at transaction commit time.

Err codemadness.org 70 i 1344

Err codemadness.org 70 i 1346

[MDEV-25785] Add support for OpenSSL 3.0

Honza Horak — Sat, 20 Nov 2021 12:54:17 +0000

Err codemadness.org 70 i 1422 Err codemadness.org 70 i 1423 Err codemadness.org 70 i 1432 Err codemadness.org 70 i 1433 Err codemadness.org 70 i 1434 Err codemadness.org 70 i 1435 Err codemadness.org 70 i 1436 Err codemadness.org 70 i 1437 Err codemadness.org 70 i 1438 Err codemadness.org 70 i 1439 Err codemadness.org 70 i 1440 Err codemadness.org 70 i 1441 Err codemadness.org 70 i 1442 Err codemadness.org 70 i 1443 Err codemadness.org 70 i 1444 Err codemadness.org 70 i 1446 Err codemadness.org 70 i 1447 Err codemadness.org 70 i 1448 Err codemadness.org 70 i 1449 Err codemadness.org 70 i 1450 Err codemadness.org 70 i 1451 Err codemadness.org 70 i 1452 Err codemadness.org 70 i 1453 Err codemadness.org 70 i 1455 Err codemadness.org 70 i 1456 Err codemadness.org 70 i 1457

Err codemadness.org 70 i 1424 Err codemadness.org 70 i 1425 [MDEV-25785] Add support for OpenSSL 3.0 Err codemadness.org 70 i 1426 Err codemadness.org 70 i 1427 Created: 2021-05-26 Updated: 2021-11-20 Err codemadness.org 70 i 1428 Err codemadness.org 70 i 1429 Err codemadness.org 70 i 1430 Err codemadness.org 70 i 1431
Status:	Stalled
Project:	MariaDB Server
Component/s:	Err codemadness.org 70 i 1445 Compiling
Fix Version/s:	Err codemadness.org 70 i 1454 10.8

Err codemadness.org 70 i 1458 Err codemadness.org 70 i 1459

Err codemadness.org 70 i 1460 Err codemadness.org 70 i 1461 Err codemadness.org 70 i 1462 Err codemadness.org 70 i 1465 Err codemadness.org 70 i 1468 Err codemadness.org 70 i 1469 Err codemadness.org 70 i 1472 Err codemadness.org 70 i 1475 Err codemadness.org 70 i 1476 Err codemadness.org 70 i 1477 Err codemadness.org 70 i 1480 Err codemadness.org 70 i 1483 Err codemadness.org 70 i 1484 Err codemadness.org 70 i 1487 Err codemadness.org 70 i 1490 Err codemadness.org 70 i 1491 Err codemadness.org 70 i 1492 Err codemadness.org 70 i 1495 Err codemadness.org 70 i 1498 Err codemadness.org 70 i 1501 Err codemadness.org 70 i 1504 Err codemadness.org 70 i 1505 Err codemadness.org 70 i 1506 Err codemadness.org 70 i 1507 Err codemadness.org 70 i 1508 Err codemadness.org 70 i 1511 Err codemadness.org 70 i 1514 Err codemadness.org 70 i 1515 Err codemadness.org 70 i 1516 Err codemadness.org 70 i 1517 Err codemadness.org 70 i 1518 Err codemadness.org 70 i 1519 Err codemadness.org 70 i 1520

Err codemadness.org 70 i 1463 Type: Err codemadness.org 70 i 1464

Err codemadness.org 70 i 1466 Task Err codemadness.org 70 i 1467

Err codemadness.org 70 i 1470 Priority: Err codemadness.org 70 i 1471

Err codemadness.org 70 i 1473 Critical Err codemadness.org 70 i 1474

Err codemadness.org 70 i 1478 Reporter: Err codemadness.org 70 i 1479

Err codemadness.org 70 i 1481 Honza Horak Err codemadness.org 70 i 1482

Err codemadness.org 70 i 1485 Assignee: Err codemadness.org 70 i 1486

Err codemadness.org 70 i 1488 Vladislav Vaintroub Err codemadness.org 70 i 1489

Err codemadness.org 70 i 1493 Resolution: Err codemadness.org 70 i 1494

Err codemadness.org 70 i 1496 Unresolved Err codemadness.org 70 i 1497

Err codemadness.org 70 i 1499 Votes: Err codemadness.org 70 i 1500

Err codemadness.org 70 i 1502 2 Err codemadness.org 70 i 1503

Err codemadness.org 70 i 1509 Labels: Err codemadness.org 70 i 1510

Err codemadness.org 70 i 1512 None Err codemadness.org 70 i 1513

Err codemadness.org 70 i 1521 Err codemadness.org 70 i 1522 Err codemadness.org 70 i 1523 Err codemadness.org 70 i 1524

Err codemadness.org 70 i 1525 Err codemadness.org 70 i 1526 Err codemadness.org 70 i 1527 Err codemadness.org 70 i 1528 Err codemadness.org 70 i 1529 Err codemadness.org 70 i 1530 Err codemadness.org 70 i 1533 Err codemadness.org 70 i 1537 Err codemadness.org 70 i 1538 Err codemadness.org 70 i 1539 Err codemadness.org 70 i 1540 Err codemadness.org 70 i 1543 Err codemadness.org 70 i 1657 Err codemadness.org 70 i 1658 Err codemadness.org 70 i 1659 Err codemadness.org 70 i 1660 Err codemadness.org 70 i 1661 Err codemadness.org 70 i 1662 Err codemadness.org 70 i 1663

Err codemadness.org 70 i 1531 Attachments: Err codemadness.org 70 i 1532

Err codemadness.org 70 i 1534 Err codemadness.org 70 i 1535 screenshot-1.png Err codemadness.org 70 i 1536

Err codemadness.org 70 i 1541 Issue Links: Err codemadness.org 70 i 1542

Err codemadness.org 70 i 1544 Err codemadness.org 70 i 1545 Err codemadness.org 70 i 1546 Err codemadness.org 70 i 1549 Err codemadness.org 70 i 1550 Err codemadness.org 70 i 1551 Err codemadness.org 70 i 1554 Err codemadness.org 70 i 1558 Err codemadness.org 70 i 1561 Err codemadness.org 70 i 1564 Err codemadness.org 70 i 1565 Err codemadness.org 70 i 1566 Err codemadness.org 70 i 1569 Err codemadness.org 70 i 1570 Err codemadness.org 70 i 1571 Err codemadness.org 70 i 1574 Err codemadness.org 70 i 1578 Err codemadness.org 70 i 1581 Err codemadness.org 70 i 1584 Err codemadness.org 70 i 1585 Err codemadness.org 70 i 1586 Err codemadness.org 70 i 1589 Err codemadness.org 70 i 1590 Err codemadness.org 70 i 1591 Err codemadness.org 70 i 1594 Err codemadness.org 70 i 1598 Err codemadness.org 70 i 1601 Err codemadness.org 70 i 1604 Err codemadness.org 70 i 1605 Err codemadness.org 70 i 1606 Err codemadness.org 70 i 1609 Err codemadness.org 70 i 1613 Err codemadness.org 70 i 1616 Err codemadness.org 70 i 1619 Err codemadness.org 70 i 1620 Err codemadness.org 70 i 1621 Err codemadness.org 70 i 1624 Err codemadness.org 70 i 1628 Err codemadness.org 70 i 1631 Err codemadness.org 70 i 1634 Err codemadness.org 70 i 1635 Err codemadness.org 70 i 1636 Err codemadness.org 70 i 1639 Err codemadness.org 70 i 1640 Err codemadness.org 70 i 1641 Err codemadness.org 70 i 1644 Err codemadness.org 70 i 1648 Err codemadness.org 70 i 1651 Err codemadness.org 70 i 1654 Err codemadness.org 70 i 1655

Err codemadness.org 70 i 1547 Blocks Err codemadness.org 70 i 1548
Err codemadness.org 70 i 1552 blocks Err codemadness.org 70 i 1553	Err codemadness.org 70 i 1555 Err codemadness.org 70 i 1556 MDEV-25949 Err codemadness.org 70 i 1557	Err codemadness.org 70 i 1559 Add support for OpenSSL 3.0 in Galera Err codemadness.org 70 i 1560	Err codemadness.org 70 i 1562 Open Err codemadness.org 70 i 1563
Err codemadness.org 70 i 1567 Duplicate Err codemadness.org 70 i 1568
Err codemadness.org 70 i 1572 duplicates Err codemadness.org 70 i 1573	Err codemadness.org 70 i 1575 Err codemadness.org 70 i 1576 ~~MDEV-26950~~ Err codemadness.org 70 i 1577	Err codemadness.org 70 i 1579 mysqld got signal 6 Err codemadness.org 70 i 1580	Err codemadness.org 70 i 1582 Closed Err codemadness.org 70 i 1583
Err codemadness.org 70 i 1587 PartOf Err codemadness.org 70 i 1588
Err codemadness.org 70 i 1592 includes Err codemadness.org 70 i 1593	Err codemadness.org 70 i 1595 Err codemadness.org 70 i 1596 MDEV-26015 Err codemadness.org 70 i 1597	Err codemadness.org 70 i 1599 Remove DH param stuff Err codemadness.org 70 i 1600	Err codemadness.org 70 i 1602 In Review Err codemadness.org 70 i 1603
Err codemadness.org 70 i 1607 includes Err codemadness.org 70 i 1608	Err codemadness.org 70 i 1610 Err codemadness.org 70 i 1611 MDEV-26302 Err codemadness.org 70 i 1612	Err codemadness.org 70 i 1614 Unittest failures with OpenSSL-3: aes... Err codemadness.org 70 i 1615	Err codemadness.org 70 i 1617 Open Err codemadness.org 70 i 1618
Err codemadness.org 70 i 1622 includes Err codemadness.org 70 i 1623	Err codemadness.org 70 i 1625 Err codemadness.org 70 i 1626 MDEV-26771 Err codemadness.org 70 i 1627	Err codemadness.org 70 i 1629 crash with OpenSSL 3.0.0 Err codemadness.org 70 i 1630	Err codemadness.org 70 i 1632 Open Err codemadness.org 70 i 1633
Err codemadness.org 70 i 1637 Relates Err codemadness.org 70 i 1638
Err codemadness.org 70 i 1642 relates to Err codemadness.org 70 i 1643	Err codemadness.org 70 i 1645 Err codemadness.org 70 i 1646 ~~CONC-503~~ Err codemadness.org 70 i 1647	Err codemadness.org 70 i 1649 Add support for OpenSSL 3.0 Err codemadness.org 70 i 1650	Err codemadness.org 70 i 1652 Closed Err codemadness.org 70 i 1653

Err codemadness.org 70 i 1656

Err codemadness.org 70 i 1664 Err codemadness.org 70 i 1665

Err codemadness.org 70 i 1666 Err codemadness.org 70 i 1667 Err codemadness.org 70 i 1668 Err codemadness.org 70 i 1669 Err codemadness.org 70 i 1672 Err codemadness.org 70 i 1673 Err codemadness.org 70 i 1674

Err codemadness.org 70 i 1670 Description Err codemadness.org 70 i 1671

Err codemadness.org 70 i 1675 Err codemadness.org 70 i 1676 Err codemadness.org 70 i 1677 Err codemadness.org 70 i 1678 Err codemadness.org 70 i 1694 Err codemadness.org 70 i 1695

Err codemadness.org 70 i 1679

OpenSSL 3.0 is not yet released as GA, but we already experiment with the builds in Fedora (Copr repository available: https://copr.fedorainfracloud.org/coprs/saprasad/openssl-3.0/) or in CentOS Stream 9 (https://kojihub.stream.centos.org/koji/buildinfo?buildID=7571).

Err codemadness.org 70 i 1680 Err codemadness.org 70 i 1681

There are some documented changes in OpenSSL 3.0: https://wiki.openssl.org/index.php/OpenSSL_3.0 but there are also some changes that should not be visible. However, since other SW depends on some internals, the changes actually affect the compatibility more than documented.

Err codemadness.org 70 i 1682 Err codemadness.org 70 i 1683

MariaDB 10.5.9 (expecting 10.6.x behaves the same) fails to build with this upcoming OpenSSL 3.0.

Err codemadness.org 70 i 1684 Err codemadness.org 70 i 1685

The problem is mainly with md5, sha and crypto parts.

Err codemadness.org 70 i 1686 Err codemadness.org 70 i 1687

A partial fix is proposed here:

Err codemadness.org 70 i 1688 https://gitlab.com/redhat/centos-stream/rpms/mariadb/-/merge_requests/4

Err codemadness.org 70 i 1689 but some tests (related to encrypting) fail even with this patch, so it is definitely not complete.

Err codemadness.org 70 i 1690 Err codemadness.org 70 i 1691

MySQL report is https://bugs.mysql.com/bug.php?id=103818

Err codemadness.org 70 i 1692

Err codemadness.org 70 i 1693

Err codemadness.org 70 i 1696 Err codemadness.org 70 i 1697

Err codemadness.org 70 i 1698 Err codemadness.org 70 i 1699 Err codemadness.org 70 i 1700 Err codemadness.org 70 i 1701 Err codemadness.org 70 i 1704 Err codemadness.org 70 i 1705 Err codemadness.org 70 i 1706

Err codemadness.org 70 i 1702 Comments Err codemadness.org 70 i 1703

Err codemadness.org 70 i 1707 Err codemadness.org 70 i 1708 Err codemadness.org 70 i 1709 Err codemadness.org 70 i 1720 Err codemadness.org 70 i 1725 Err codemadness.org 70 i 1736 Err codemadness.org 70 i 1741 Err codemadness.org 70 i 1752 Err codemadness.org 70 i 1759 Err codemadness.org 70 i 1770 Err codemadness.org 70 i 1775 Err codemadness.org 70 i 1786 Err codemadness.org 70 i 1789 Err codemadness.org 70 i 1800 Err codemadness.org 70 i 1829 Err codemadness.org 70 i 1840 Err codemadness.org 70 i 1848 Err codemadness.org 70 i 1859 Err codemadness.org 70 i 1862 Err codemadness.org 70 i 1873 Err codemadness.org 70 i 1876 Err codemadness.org 70 i 1887 Err codemadness.org 70 i 1893 Err codemadness.org 70 i 1904 Err codemadness.org 70 i 1914 Err codemadness.org 70 i 1925 Err codemadness.org 70 i 1930 Err codemadness.org 70 i 1941 Err codemadness.org 70 i 1944 Err codemadness.org 70 i 1955 Err codemadness.org 70 i 1966 Err codemadness.org 70 i 1977 Err codemadness.org 70 i 1980

Err codemadness.org 70 i 1710 Comment by Err codemadness.org 70 i 1711 Honza Horak Err codemadness.org 70 i 1712 Err codemadness.org 70 i 1713 [ Err codemadness.org 70 i 1714 2021-06-17 Err codemadness.org 70 i 1715 Err codemadness.org 70 i 1716 ] Err codemadness.org 70 i 1717 Err codemadness.org 70 i 1718 Err codemadness.org 70 i 1719

Err codemadness.org 70 i 1721

OpenSSL 3.0.0 is now released as RC, so the design and functionality should not be changed any more: https://www.openssl.org/blog/blog/2021/06/17/OpenSSL3.0ReleaseCandidate/

Err codemadness.org 70 i 1722 Err codemadness.org 70 i 1723

Can I kindly ask whether "Fix versions: 10.6" means somebody is looking at this soon or what is the rough ETA?

Err codemadness.org 70 i 1724

Err codemadness.org 70 i 1726 Comment by Err codemadness.org 70 i 1727 Honza Horak Err codemadness.org 70 i 1728 Err codemadness.org 70 i 1729 [ Err codemadness.org 70 i 1730 2021-06-17 Err codemadness.org 70 i 1731 Err codemadness.org 70 i 1732 ] Err codemadness.org 70 i 1733 Err codemadness.org 70 i 1734 Err codemadness.org 70 i 1735

Err codemadness.org 70 i 1737

I've asked Sahana to update the copr repository https://copr.fedorainfracloud.org/coprs/saprasad/openssl-3.0/ with this newest release, so at last for fedora users, there would be a simple way to get the openssl 3.0.0 RC soon.

Err codemadness.org 70 i 1738 Err codemadness.org 70 i 1739

Is there anything else we can help with in order to make mariadb work fine with newer openssl? We can for example provide contacts to Red Hat colleagues from OpenSSL upstream if something needs to be discussed in more detail...

Err codemadness.org 70 i 1740

Err codemadness.org 70 i 1742 Comment by Err codemadness.org 70 i 1743 Sergei Golubchik Err codemadness.org 70 i 1744 Err codemadness.org 70 i 1745 [ Err codemadness.org 70 i 1746 2021-06-17 Err codemadness.org 70 i 1747 Err codemadness.org 70 i 1748 ] Err codemadness.org 70 i 1749 Err codemadness.org 70 i 1750 Err codemadness.org 70 i 1751

Err codemadness.org 70 i 1753

No, at the moment nobody is looking into it. But we'll do it, of course, we cannot ignore the new major OpenSSL version.

Err codemadness.org 70 i 1754 Err codemadness.org 70 i 1755

But it's not a simple task, we'll have to change the way MariaDB uses OpenSSL, it'll be a big refactoring.

Err codemadness.org 70 i 1756 Err codemadness.org 70 i 1757

The problem is that for a long time, since OpenSSL 0.9, the code heavily relied on various OpenSSL contexts allocated on the stack for one function only. Like create an MD5 context, calculate the hash, destroy the context. With OpenSSL making all objects opaque, we can no longer do it. And we don't want to replace all those stack allocations with malloc(), the server tries rather hard to avoid malloc(). So, we'll need to implement an approach that will work with opaque objects created by OpenSSL and still doesn't call malloc() every time we need to encrypt or hash something.

Err codemadness.org 70 i 1758

Err codemadness.org 70 i 1760 Comment by Err codemadness.org 70 i 1761 Honza Horak Err codemadness.org 70 i 1762 Err codemadness.org 70 i 1763 [ Err codemadness.org 70 i 1764 2021-06-18 Err codemadness.org 70 i 1765 Err codemadness.org 70 i 1766 ] Err codemadness.org 70 i 1767 Err codemadness.org 70 i 1768 Err codemadness.org 70 i 1769

Err codemadness.org 70 i 1771

Do you think it makes sense to start with using deprecated functionality first (which is still available) and make it work with 3.0.0 at least somehow before doing it "correctly" without the deprecated functionality?

Err codemadness.org 70 i 1772 Err codemadness.org 70 i 1773

The patch I mentioned in the description makes the code compile this way, does not replace more than is necessary, and works find with many tests.. But it still does not address some other cases, mostly binlog_encryption suite fails (server crashes). It still seems quite doable without a big rewriting at least as the first step.

Err codemadness.org 70 i 1774

Err codemadness.org 70 i 1776 Comment by Err codemadness.org 70 i 1777 Georg Richter Err codemadness.org 70 i 1778 Err codemadness.org 70 i 1779 [ Err codemadness.org 70 i 1780 2021-06-24 Err codemadness.org 70 i 1781 Err codemadness.org 70 i 1782 ] Err codemadness.org 70 i 1783 Err codemadness.org 70 i 1784 Err codemadness.org 70 i 1785

Err codemadness.org 70 i 1787

A simple (and faster) solution would be to reuse contexts. In current implementation every encryption or hashing operation creates a new context on stack and initializes it. Instead an existing context should be resetted (e.g. EVP_MD_CTX_reset) and reused.

Err codemadness.org 70 i 1788

Err codemadness.org 70 i 1790 Comment by Err codemadness.org 70 i 1791 Georg Richter Err codemadness.org 70 i 1792 Err codemadness.org 70 i 1793 [ Err codemadness.org 70 i 1794 2021-06-24 Err codemadness.org 70 i 1795 Err codemadness.org 70 i 1796 ] Err codemadness.org 70 i 1797 Err codemadness.org 70 i 1798 Err codemadness.org 70 i 1799

Err codemadness.org 70 i 1801

After some more investigation, here is a short summary:

Err codemadness.org 70 i 1802 Err codemadness.org 70 i 1803

TLS protocol

Err codemadness.org 70 i 1804 Err codemadness.org 70 i 1805

Remove DH param stuff and use SSL_CTX_set_dh_auto() instead (MDEV-26015)
type of options parameter for SSL_CTX_set_options changed from long to uint64_t

Err codemadness.org 70 i 1809 Err codemadness.org 70 i 1810 Err codemadness.org 70 i 1811

Cryptography (Hashing and Encryption)

Err codemadness.org 70 i 1812 Err codemadness.org 70 i 1813

Almost all Crypto API calls generate "deprecation" warnings, they need to be replaced by EVP_ functions.
Reuse contexts for hashing and encryption: instead of allocating and freeing context we should reset handle (around 20% faster, maybe more if the same algorithm can be reused). This would also help to reduce memory allocations
Preferrable also reduce the number of functions: my_sha(hashing_algorithm, data, len, digest) instead of single functions for each algorithm. Same is valid for encryption and decryption.
Function EVP_CIPHER_CTX_buf_noconst (deprecated) needs to be replaced to detect overlapping bytes for non padding encryption.

Err codemadness.org 70 i 1819 Err codemadness.org 70 i 1820 Err codemadness.org 70 i 1821

Concerns/Possible problems

Err codemadness.org 70 i 1822

WolfSSL doesn't seem to provide compatibility layer for OSSL 3.0
We still have to support platforms which ship eoled OSSL versions (1.0.x)

Err codemadness.org 70 i 1826 Err codemadness.org 70 i 1827 Err codemadness.org 70 i 1828

Err codemadness.org 70 i 1830 Comment by Err codemadness.org 70 i 1831 Vladislav Vaintroub Err codemadness.org 70 i 1832 Err codemadness.org 70 i 1833 [ Err codemadness.org 70 i 1834 2021-11-08 Err codemadness.org 70 i 1835 Err codemadness.org 70 i 1836 ] Err codemadness.org 70 i 1837 Err codemadness.org 70 i 1838 Err codemadness.org 70 i 1839

Err codemadness.org 70 i 1841

Not much has to be changed for OpenSSL 3.0.

Err codemadness.org 70 i 1842 The "opacity" is of no concern. We already treat contexts as opaque. what's new, is that context have to be 16 bytes aligned, but we had seen it already with Wolfssl before. We have to guess the size of context, or we could see memory overwrites, but it is not really new either, we have been doing it for a while.

Err codemadness.org 70 i 1843 Err codemadness.org 70 i 1844

The biggest challenge in this version is broken EVP_CIPHER_CTX_buf_noconst, though I never found it to be documented.

Err codemadness.org 70 i 1845 The whole functional change (including suppressing the warnings) is some 30 lines of code

Err codemadness.org 70 i 1846 plus a little rework of aes-t code.

Err codemadness.org 70 i 1847

Err codemadness.org 70 i 1849 Comment by Err codemadness.org 70 i 1850 Mingli-Yu Err codemadness.org 70 i 1851 Err codemadness.org 70 i 1852 [ Err codemadness.org 70 i 1853 2021-11-18 Err codemadness.org 70 i 1854 Err codemadness.org 70 i 1855 ] Err codemadness.org 70 i 1856 Err codemadness.org 70 i 1857 Err codemadness.org 70 i 1858

Err codemadness.org 70 i 1860

I notice the status is changed to "IN REVIEW", is the patch available now? Thanks!

Err codemadness.org 70 i 1861

Err codemadness.org 70 i 1863 Comment by Err codemadness.org 70 i 1864 Jan Lindström Err codemadness.org 70 i 1865 Err codemadness.org 70 i 1866 [ Err codemadness.org 70 i 1867 2021-11-18 Err codemadness.org 70 i 1868 Err codemadness.org 70 i 1869 ] Err codemadness.org 70 i 1870 Err codemadness.org 70 i 1871 Err codemadness.org 70 i 1872

Err codemadness.org 70 i 1874

I hope that before anything is pushed to main branches there is done some consideration and testing done that if server uses OpenSSL 3.0 Galera would also work (using OpenSSL x where x might not be same as 3.0 or where x = 3.0). See MDEV-25949 (at the moment I do not know if Galera library even compiles with OpenSSL 3.0). Remember that currently server and Galera library are build separately and there is no restriction to use older Galera library version than latest one i.e. for OpenSSL 3.0 if you can't use different versions we need to restrict also what Galera library version can be used.

Err codemadness.org 70 i 1875

Err codemadness.org 70 i 1877 Comment by Err codemadness.org 70 i 1878 Vladislav Vaintroub Err codemadness.org 70 i 1879 Err codemadness.org 70 i 1880 [ Err codemadness.org 70 i 1881 2021-11-18 Err codemadness.org 70 i 1882 Err codemadness.org 70 i 1883 ] Err codemadness.org 70 i 1884 Err codemadness.org 70 i 1885 Err codemadness.org 70 i 1886

Err codemadness.org 70 i 1888

I think this hope is unfounded, Jan Lindström The server builds with OpenSSL, with or without -DWITH_WSREP. This work won't port Galera to OpenSSL 3.0. In case of negative outcome because of Galera, what should server do? Refuse to build does not make any sense, so either Galera works with OpeSSL 3.0, or we'll allow people who do not use Galera to use OpenSSL 3.0

Err codemadness.org 70 i 1889 Err codemadness.org 70 i 1890

The Server is not even aware Galera uses SSL or OpenSSL. Even if WSREP now spread over the entire codebase, Galera is logically, a plugin, which on whatever reasons, chose to build outside of the server.

Err codemadness.org 70 i 1891 Err codemadness.org 70 i 1892

Err codemadness.org 70 i 1894 Comment by Err codemadness.org 70 i 1895 Jan Lindström Err codemadness.org 70 i 1896 Err codemadness.org 70 i 1897 [ Err codemadness.org 70 i 1898 2021-11-18 Err codemadness.org 70 i 1899 Err codemadness.org 70 i 1900 ] Err codemadness.org 70 i 1901 Err codemadness.org 70 i 1902 Err codemadness.org 70 i 1903

Err codemadness.org 70 i 1905

Some questions:

Err codemadness.org 70 i 1906

If server uses OpenSSL 3.0 can for example mysql client use OpenSSL 1.x or 2.x to connect ?
If server uses OpenSSL < 3.0 can for example mysql client use OpenSSL 3.x to connect ?
If both are true then what OpenSSL Galera uses is not relevant
If they are false then we need to have both MDEVs done before feature is released

Err codemadness.org 70 i 1912 Err codemadness.org 70 i 1913

Err codemadness.org 70 i 1915 Comment by Err codemadness.org 70 i 1916 Vladislav Vaintroub Err codemadness.org 70 i 1917 Err codemadness.org 70 i 1918 [ Err codemadness.org 70 i 1919 2021-11-18 Err codemadness.org 70 i 1920 Err codemadness.org 70 i 1921 ] Err codemadness.org 70 i 1922 Err codemadness.org 70 i 1923 Err codemadness.org 70 i 1924

Err codemadness.org 70 i 1926

SSL is network level protocol, while OpenSSL 3.0 is a library implementing this protocol. Of course, different servers can be connected to different clients, as exemplified by Schannel , or GNUTLS, or OpenSSL, or for example Java clients successfully connecting to either OpenSSL, or to WolfSSL servers.

Err codemadness.org 70 i 1927 Err codemadness.org 70 i 1928

What OpenSSL Galera uses might be relevant, because it is not known (and Galera team will have to to find it out), whether 2 different OpenSSL libraries can coexist peacefully inside the same mariadbd process.

Err codemadness.org 70 i 1929

Err codemadness.org 70 i 1931 Comment by Err codemadness.org 70 i 1932 Vladislav Vaintroub Err codemadness.org 70 i 1933 Err codemadness.org 70 i 1934 [ Err codemadness.org 70 i 1935 2021-11-18 Err codemadness.org 70 i 1936 Err codemadness.org 70 i 1937 ] Err codemadness.org 70 i 1938 Err codemadness.org 70 i 1939 Err codemadness.org 70 i 1940

Err codemadness.org 70 i 1942

Mingli-Yu, on the right side of this page, at least in desktop JIRA variant click under "1 commit" , it will bring show you the commit (in colors!), and give the github link which is currently https://github.com/MariaDB/server/commit/c80991c79f701dac42c630af4bd39593b0c7efb4

Err codemadness.org 70 i 1943

Err codemadness.org 70 i 1945 Comment by Err codemadness.org 70 i 1946 Lukas Javorsky Err codemadness.org 70 i 1947 Err codemadness.org 70 i 1948 [ Err codemadness.org 70 i 1949 2021-11-19 Err codemadness.org 70 i 1950 Err codemadness.org 70 i 1951 ] Err codemadness.org 70 i 1952 Err codemadness.org 70 i 1953 Err codemadness.org 70 i 1954

Err codemadness.org 70 i 1956

I would just add one note from our OpenSSL team, which we got when we tried to implement the support ourselves (keep this just as heads-up).

Err codemadness.org 70 i 1957 Err codemadness.org 70 i 1958

Usage of MD5... How do you ensure that the legacy provider is loaded?

Err codemadness.org 70 i 1959

OpenSSL 3.0 has a provider architecture and if you use, say, weak cipher algorithms (single DES, RC4) or hash algorithms (RIPEMD160), you need to ensure that the legacy provider is loaded.

Err codemadness.org 70 i 1962 Err codemadness.org 70 i 1963 Err codemadness.org 70 i 1964

If you already knew about this new change, just ignore this comment

Err codemadness.org 70 i 1965

Err codemadness.org 70 i 1967 Comment by Err codemadness.org 70 i 1968 Vladislav Vaintroub Err codemadness.org 70 i 1969 Err codemadness.org 70 i 1970 [ Err codemadness.org 70 i 1971 2021-11-20 Err codemadness.org 70 i 1972 Err codemadness.org 70 i 1973 ] Err codemadness.org 70 i 1974 Err codemadness.org 70 i 1975 Err codemadness.org 70 i 1976

Err codemadness.org 70 i 1978

I do not ensure it is loaded. It appears to work, as you can check by applying the patch.

Err codemadness.org 70 i 1979

Err codemadness.org 70 i 1981

[MDEV-27088] Server crash on ARM (WMM architecture) due to missing barriers in lf-hash

Martin Beck — Sat, 20 Nov 2021 12:22:09 +0000

Err codemadness.org 70 i 2057 Err codemadness.org 70 i 2058 Err codemadness.org 70 i 2067 Err codemadness.org 70 i 2068 Err codemadness.org 70 i 2069 Err codemadness.org 70 i 2070 Err codemadness.org 70 i 2071 Err codemadness.org 70 i 2072 Err codemadness.org 70 i 2073 Err codemadness.org 70 i 2074 Err codemadness.org 70 i 2075 Err codemadness.org 70 i 2076 Err codemadness.org 70 i 2077 Err codemadness.org 70 i 2078 Err codemadness.org 70 i 2079 Err codemadness.org 70 i 2081 Err codemadness.org 70 i 2082 Err codemadness.org 70 i 2083 Err codemadness.org 70 i 2084 Err codemadness.org 70 i 2085 Err codemadness.org 70 i 2086 Err codemadness.org 70 i 2088 Err codemadness.org 70 i 2089 Err codemadness.org 70 i 2090 Err codemadness.org 70 i 2091 Err codemadness.org 70 i 2092 Err codemadness.org 70 i 2093 Err codemadness.org 70 i 2095 Err codemadness.org 70 i 2096 Err codemadness.org 70 i 2097

Err codemadness.org 70 i 2059 Err codemadness.org 70 i 2060 [MDEV-27088] Server crash on ARM (WMM architecture) due to missing barriers in lf-hash Err codemadness.org 70 i 2061 Err codemadness.org 70 i 2062 Created: 2021-11-19 Updated: 2021-11-20 Err codemadness.org 70 i 2063 Err codemadness.org 70 i 2064 Err codemadness.org 70 i 2065 Err codemadness.org 70 i 2066
Status:	Confirmed
Project:	MariaDB Server
Component/s:	Err codemadness.org 70 i 2080 Server
Affects Version/s:	Err codemadness.org 70 i 2087 10.7
Fix Version/s:	Err codemadness.org 70 i 2094 10.2, 10.3, 10.4, 10.5, 10.6

Err codemadness.org 70 i 2098 Err codemadness.org 70 i 2099

Err codemadness.org 70 i 2100 Err codemadness.org 70 i 2101 Err codemadness.org 70 i 2102 Err codemadness.org 70 i 2105 Err codemadness.org 70 i 2108 Err codemadness.org 70 i 2109 Err codemadness.org 70 i 2112 Err codemadness.org 70 i 2115 Err codemadness.org 70 i 2116 Err codemadness.org 70 i 2117 Err codemadness.org 70 i 2120 Err codemadness.org 70 i 2123 Err codemadness.org 70 i 2124 Err codemadness.org 70 i 2127 Err codemadness.org 70 i 2130 Err codemadness.org 70 i 2131 Err codemadness.org 70 i 2132 Err codemadness.org 70 i 2135 Err codemadness.org 70 i 2138 Err codemadness.org 70 i 2141 Err codemadness.org 70 i 2144 Err codemadness.org 70 i 2145 Err codemadness.org 70 i 2146 Err codemadness.org 70 i 2147 Err codemadness.org 70 i 2148 Err codemadness.org 70 i 2151 Err codemadness.org 70 i 2153 Err codemadness.org 70 i 2154 Err codemadness.org 70 i 2155 Err codemadness.org 70 i 2156 Err codemadness.org 70 i 2157 Err codemadness.org 70 i 2158 Err codemadness.org 70 i 2159 Err codemadness.org 70 i 2160 Err codemadness.org 70 i 2161 Err codemadness.org 70 i 2164 Err codemadness.org 70 i 2167 Err codemadness.org 70 i 2168

Err codemadness.org 70 i 2103 Type: Err codemadness.org 70 i 2104

Err codemadness.org 70 i 2106 Bug Err codemadness.org 70 i 2107

Err codemadness.org 70 i 2110 Priority: Err codemadness.org 70 i 2111

Err codemadness.org 70 i 2113 Critical Err codemadness.org 70 i 2114

Err codemadness.org 70 i 2118 Reporter: Err codemadness.org 70 i 2119

Err codemadness.org 70 i 2121 Martin Beck Err codemadness.org 70 i 2122

Err codemadness.org 70 i 2125 Assignee: Err codemadness.org 70 i 2126

Err codemadness.org 70 i 2128 Daniel Black Err codemadness.org 70 i 2129

Err codemadness.org 70 i 2133 Resolution: Err codemadness.org 70 i 2134

Err codemadness.org 70 i 2136 Unresolved Err codemadness.org 70 i 2137

Err codemadness.org 70 i 2139 Votes: Err codemadness.org 70 i 2140

Err codemadness.org 70 i 2142 0 Err codemadness.org 70 i 2143

Err codemadness.org 70 i 2149 Labels: Err codemadness.org 70 i 2150

Err codemadness.org 70 i 2152 ARMv8, crash, hash, lock-free, synchronization

Err codemadness.org 70 i 2162 Environment: Err codemadness.org 70 i 2163

Err codemadness.org 70 i 2165

ARMv8 architecture, Ubuntu bionic, LLVM-8

Err codemadness.org 70 i 2166

Err codemadness.org 70 i 2169 Err codemadness.org 70 i 2170 Err codemadness.org 70 i 2171 Err codemadness.org 70 i 2172

Err codemadness.org 70 i 2173 Err codemadness.org 70 i 2174 Err codemadness.org 70 i 2175 Err codemadness.org 70 i 2176 Err codemadness.org 70 i 2177 Err codemadness.org 70 i 2178 Err codemadness.org 70 i 2181 Err codemadness.org 70 i 2193 Err codemadness.org 70 i 2194 Err codemadness.org 70 i 2195 Err codemadness.org 70 i 2196 Err codemadness.org 70 i 2199 Err codemadness.org 70 i 2223 Err codemadness.org 70 i 2224 Err codemadness.org 70 i 2225 Err codemadness.org 70 i 2226 Err codemadness.org 70 i 2227 Err codemadness.org 70 i 2228

Err codemadness.org 70 i 2179 Attachments: Err codemadness.org 70 i 2180

Err codemadness.org 70 i 2182 Err codemadness.org 70 i 2183 abstracted_crash_mwe.c Err codemadness.org 70 i 2184 Err codemadness.org 70 i 2185 abstracted_crash_mwe_fixed.c Err codemadness.org 70 i 2186 Err codemadness.org 70 i 2187 build.sh Err codemadness.org 70 i 2188 Err codemadness.org 70 i 2189 parallel.sh Err codemadness.org 70 i 2190 Err codemadness.org 70 i 2191 purgatory_fix.diff Err codemadness.org 70 i 2192

Err codemadness.org 70 i 2197 Issue Links: Err codemadness.org 70 i 2198

Err codemadness.org 70 i 2200 Err codemadness.org 70 i 2201 Err codemadness.org 70 i 2202 Err codemadness.org 70 i 2205 Err codemadness.org 70 i 2206 Err codemadness.org 70 i 2207 Err codemadness.org 70 i 2210 Err codemadness.org 70 i 2214 Err codemadness.org 70 i 2217 Err codemadness.org 70 i 2220 Err codemadness.org 70 i 2221

Err codemadness.org 70 i 2203 PartOf Err codemadness.org 70 i 2204
Err codemadness.org 70 i 2208 includes Err codemadness.org 70 i 2209	Err codemadness.org 70 i 2211 Err codemadness.org 70 i 2212 ~~MDEV-23510~~ Err codemadness.org 70 i 2213	Err codemadness.org 70 i 2215 Crash in my_strnncoll_binary while ru... Err codemadness.org 70 i 2216	Err codemadness.org 70 i 2218 Closed Err codemadness.org 70 i 2219

Err codemadness.org 70 i 2222

Err codemadness.org 70 i 2229 Err codemadness.org 70 i 2230

Err codemadness.org 70 i 2231 Err codemadness.org 70 i 2232 Err codemadness.org 70 i 2233 Err codemadness.org 70 i 2234 Err codemadness.org 70 i 2237 Err codemadness.org 70 i 2238 Err codemadness.org 70 i 2239

Err codemadness.org 70 i 2235 Description Err codemadness.org 70 i 2236

Err codemadness.org 70 i 2240 Err codemadness.org 70 i 2241 Err codemadness.org 70 i 2242 Err codemadness.org 70 i 2243 Err codemadness.org 70 i 2509 Err codemadness.org 70 i 2510

Err codemadness.org 70 i 2244

MariaDB server crashes on ARM (weak memory model architecture) while concurrently executing l_find to load node->key and add_to_purgatory to store node->key = NULL. l_find then uses key (which is NULL), to pass it to a comparison function.

Err codemadness.org 70 i 2245 Err codemadness.org 70 i 2246

The specific problem is the out-of-order execution that happens on a weak memory model architecture. Two essential reorderings are possible, which need to be prevented.

Err codemadness.org 70 i 2247 Err codemadness.org 70 i 2248

a) As l_find has no barriers in place between the optimistic read of the key field lf_hash.cc#L117 and the verification of link lf_hash.cc#L124, the processor can reorder the load to happen after the while-loop.

Err codemadness.org 70 i 2249 Err codemadness.org 70 i 2250

In that case, a concurrent thread executing add_to_purgatory on the same node can be scheduled to store NULL at the key field lf_alloc-pin.c#L253 before key is loaded in l_find.

Err codemadness.org 70 i 2251 Err codemadness.org 70 i 2252

b) A node is marked as deleted by a CAS in l_delete lf_hash.cc#L247 and taken off the list with an upfollowing CAS lf_hash.cc#L252. Only if both CAS succeed, the key field is written to by add_to_purgatory. However, due to a missing barrier, the relaxed store of key lf_alloc-pin.c#L253 can be moved ahead of the two CAS operations, which makes the value of the local purgatory list stored by add_to_purgatory visible to all threads operating on the list. As the node is not marked as deleted yet, the same error occurs in l_find.

Err codemadness.org 70 i 2253 Err codemadness.org 70 i 2254

Stack trace

Err codemadness.org 70 i 2255 Err codemadness.org 70 i 2256 Err codemadness.org 70 i 2257 Err codemadness.org 70 i 2258

Err codemadness.org 70 i 2259

Err codemadness.org 70 i 2260 Err codemadness.org 70 i 2261 Err codemadness.org 70 i 2262 Err codemadness.org 70 i 2263 Err codemadness.org 70 i 2266 Err codemadness.org 70 i 2267 Err codemadness.org 70 i 2268 Err codemadness.org 70 i 2271 Err codemadness.org 70 i 2272 Err codemadness.org 70 i 2273 Err codemadness.org 70 i 2276 Err codemadness.org 70 i 2277 Err codemadness.org 70 i 2278 Err codemadness.org 70 i 2281 Err codemadness.org 70 i 2282 Err codemadness.org 70 i 2283 Err codemadness.org 70 i 2286 Err codemadness.org 70 i 2287 Err codemadness.org 70 i 2288 Err codemadness.org 70 i 2291 Err codemadness.org 70 i 2292 Err codemadness.org 70 i 2293 Err codemadness.org 70 i 2296 Err codemadness.org 70 i 2297 Err codemadness.org 70 i 2298 Err codemadness.org 70 i 2301 Err codemadness.org 70 i 2302 Err codemadness.org 70 i 2303 Err codemadness.org 70 i 2306 Err codemadness.org 70 i 2307 Err codemadness.org 70 i 2308 Err codemadness.org 70 i 2311 Err codemadness.org 70 i 2312 Err codemadness.org 70 i 2313 Err codemadness.org 70 i 2316 Err codemadness.org 70 i 2317 Err codemadness.org 70 i 2318 Err codemadness.org 70 i 2321 Err codemadness.org 70 i 2322 Err codemadness.org 70 i 2323 Err codemadness.org 70 i 2326 Err codemadness.org 70 i 2327 Err codemadness.org 70 i 2328 Err codemadness.org 70 i 2331 Err codemadness.org 70 i 2332 Err codemadness.org 70 i 2333 Err codemadness.org 70 i 2336 Err codemadness.org 70 i 2337 Err codemadness.org 70 i 2338 Err codemadness.org 70 i 2341 Err codemadness.org 70 i 2342 Err codemadness.org 70 i 2343 Err codemadness.org 70 i 2346 Err codemadness.org 70 i 2347 Err codemadness.org 70 i 2348 Err codemadness.org 70 i 2351 Err codemadness.org 70 i 2352 Err codemadness.org 70 i 2353 Err codemadness.org 70 i 2356 Err codemadness.org 70 i 2357 Err codemadness.org 70 i 2358 Err codemadness.org 70 i 2361 Err codemadness.org 70 i 2362 Err codemadness.org 70 i 2363 Err codemadness.org 70 i 2367 Err codemadness.org 70 i 2368 Err codemadness.org 70 i 2369

Err codemadness.org 70 i 2264

Thread 179 "lf-t" received signal SIGSEGV, Segmentation fault.

Err codemadness.org 70 i 2265

Err codemadness.org 70 i 2269

[Switching to Thread 0xffff9e7cf1d0 (LWP 1256877)]

Err codemadness.org 70 i 2270

Err codemadness.org 70 i 2274

0x0000fffff772c8d8 in memcmp () from /lib/aarch64-linux-gnu/libc.so.6

Err codemadness.org 70 i 2275

Err codemadness.org 70 i 2279

(gdb) bt

Err codemadness.org 70 i 2280

Err codemadness.org 70 i 2284

#0  0x0000fffff772c8d8 in memcmp () from /lib/aarch64-linux-gnu/libc.so.6

Err codemadness.org 70 i 2285

Err codemadness.org 70 i 2289

#1  0x0000000000405580 in my_strnncoll_binary (cs=<optimized out>, s=0x0, slen=4,

Err codemadness.org 70 i 2290

Err codemadness.org 70 i 2294

    t=0xffff9e7ce968 "\234\267\277xz", tlen=<optimized out>, t_is_prefix=<optimized out>)

Err codemadness.org 70 i 2295

Err codemadness.org 70 i 2299

    at /workspace/mariadb-server/strings/ctype-bin.c:87

Err codemadness.org 70 i 2300

Err codemadness.org 70 i 2304

#2  0x0000000000405038 in l_find (head=<optimized out>, cs=<optimized out>,

Err codemadness.org 70 i 2305

Err codemadness.org 70 i 2309

    hashnr=<optimized out>, key=<optimized out>, keylen=<optimized out>,

Err codemadness.org 70 i 2310

Err codemadness.org 70 i 2314

    cursor=<optimized out>, pins=<optimized out>, callback=<optimized out>)

Err codemadness.org 70 i 2315

Err codemadness.org 70 i 2319

    at /workspace/mariadb-server/mysys/lf_hash.c:133

Err codemadness.org 70 i 2320

Err codemadness.org 70 i 2324

#3  0x0000000000403bec in l_delete (head=0xffffe8003500, cs=0x434458 <my_charset_bin>,

Err codemadness.org 70 i 2325

Err codemadness.org 70 i 2329

    hashnr=807645945, key=<optimized out>, keylen=4, pins=<optimized out>)

Err codemadness.org 70 i 2330

Err codemadness.org 70 i 2334

    at /workspace/mariadb-server/mysys/lf_hash.c:231

Err codemadness.org 70 i 2335

Err codemadness.org 70 i 2339

#4  lf_hash_delete (pins=<optimized out>, key=<optimized out>, keylen=4,

Err codemadness.org 70 i 2340

Err codemadness.org 70 i 2344

    hash=<optimized out>) at /workspace/mariadb-server/mysys/lf_hash.c:455

Err codemadness.org 70 i 2345

Err codemadness.org 70 i 2349

#5  test_lf_hash (arg=<optimized out>)

Err codemadness.org 70 i 2350

Err codemadness.org 70 i 2354

    at /workspace/mariadb-server/unittest/mysys/lf-t.c:155

Err codemadness.org 70 i 2355

Err codemadness.org 70 i 2359

#6  0x0000fffff7b17088 in start_thread () from /lib/aarch64-linux-gnu/libpthread.so.0

Err codemadness.org 70 i 2360

Err codemadness.org 70 i 2364

#7  0x0000fffff777fffc in ?? () from /lib/aarch64-linux-gnu/libc.so.6	Err	codemadness.org	70
i  2365

Err codemadness.org 70 i 2366

Err codemadness.org 70 i 2370

Err codemadness.org 70 i 2371

Err codemadness.org 70 i 2372 Err codemadness.org 70 i 2373

In frame #1 my_strnncoll_binary gets s=0x0 as a source pointer from l_find and hands that to memcmp, which causes a SEGV upon NULL pointer input.

Err codemadness.org 70 i 2374 Err codemadness.org 70 i 2375

Reproduce

Err codemadness.org 70 i 2376 Err codemadness.org 70 i 2377

The crash can be observed by running the lf-t unittest, as well as the oltp_write sysbench benchmark upon the most recent repository version. The server is build using optimization level -O0 or -O1. No other change to the configuration is done. unittest/mysys/lf-t is run until the crash is triggered.

Err codemadness.org 70 i 2378 Err codemadness.org 70 i 2379

The probability of hitting the bug can be increased easily.

Err codemadness.org 70 i 2380 Err codemadness.org 70 i 2381

The build script (build.sh) used to generate the faulty binary is attached.

Err codemadness.org 70 i 2382 To increase the probability the following changes can be done.

Err codemadness.org 70 i 2383 Err codemadness.org 70 i 2384

#define CYCLES 300000 in unittest/mysys/thr_template.c
#define THREADS 2 in unittest/mysys/thr_template.c
Disable the first 5 tests in unittest/mysys/lf-t.c, only keeping the last lf_hash (without my_thread_init) enabled

Err codemadness.org 70 i 2389 Err codemadness.org 70 i 2390 Err codemadness.org 70 i 2391

Output

Err codemadness.org 70 i 2392 Err codemadness.org 70 i 2393

The current repository version produces a crash. (unfixed)

Err codemadness.org 70 i 2394 Err codemadness.org 70 i 2395

Err codemadness.org 70 i 2396

Err codemadness.org 70 i 2397 Err codemadness.org 70 i 2398 Err codemadness.org 70 i 2399 Err codemadness.org 70 i 2400 Err codemadness.org 70 i 2403 Err codemadness.org 70 i 2404 Err codemadness.org 70 i 2405 Err codemadness.org 70 i 2408 Err codemadness.org 70 i 2409 Err codemadness.org 70 i 2410 Err codemadness.org 70 i 2413 Err codemadness.org 70 i 2414 Err codemadness.org 70 i 2415 Err codemadness.org 70 i 2418 Err codemadness.org 70 i 2419 Err codemadness.org 70 i 2420 Err codemadness.org 70 i 2423 Err codemadness.org 70 i 2424 Err codemadness.org 70 i 2425 Err codemadness.org 70 i 2429 Err codemadness.org 70 i 2430 Err codemadness.org 70 i 2431

Err codemadness.org 70 i 2401

./lf-t

Err codemadness.org 70 i 2402

Err codemadness.org 70 i 2406

# N CPUs: 96

Err codemadness.org 70 i 2407

Err codemadness.org 70 i 2411

1..6

Err codemadness.org 70 i 2412

Err codemadness.org 70 i 2416

# Testing lf_hash (without my_thread_init) with 30 threads, 3000000 iterations...

Err codemadness.org 70 i 2417

Err codemadness.org 70 i 2421

Bail out! Signal 11 thrown

Err codemadness.org 70 i 2422

Err codemadness.org 70 i 2426

# 6 tests planned,  0 failed,  0 was last executed	Err	codemadness.org	70
i  2427

Err codemadness.org 70 i 2428

Err codemadness.org 70 i 2432

Err codemadness.org 70 i 2433

Err codemadness.org 70 i 2434 Err codemadness.org 70 i 2435

The version with the propsed fix finishes as expected.

Err codemadness.org 70 i 2436 Err codemadness.org 70 i 2437

Err codemadness.org 70 i 2438

Err codemadness.org 70 i 2439 Err codemadness.org 70 i 2440 Err codemadness.org 70 i 2441 Err codemadness.org 70 i 2442 Err codemadness.org 70 i 2445 Err codemadness.org 70 i 2446 Err codemadness.org 70 i 2447 Err codemadness.org 70 i 2450 Err codemadness.org 70 i 2451 Err codemadness.org 70 i 2452 Err codemadness.org 70 i 2455 Err codemadness.org 70 i 2456 Err codemadness.org 70 i 2457 Err codemadness.org 70 i 2460 Err codemadness.org 70 i 2461 Err codemadness.org 70 i 2462 Err codemadness.org 70 i 2465 Err codemadness.org 70 i 2466 Err codemadness.org 70 i 2467 Err codemadness.org 70 i 2470 Err codemadness.org 70 i 2471 Err codemadness.org 70 i 2472 Err codemadness.org 70 i 2476 Err codemadness.org 70 i 2477 Err codemadness.org 70 i 2478

Err codemadness.org 70 i 2443

./lf-t

Err codemadness.org 70 i 2444

Err codemadness.org 70 i 2448

# N CPUs: 96

Err codemadness.org 70 i 2449

Err codemadness.org 70 i 2453

1..6

Err codemadness.org 70 i 2454

Err codemadness.org 70 i 2458

# Testing lf_hash (without my_thread_init) with 30 threads, 3000000 iterations...

Err codemadness.org 70 i 2459

Err codemadness.org 70 i 2463

# 0 mallocs, 30 pins in stack, 4096 hash size, 37857309 inserts, 721149 scans

Err codemadness.org 70 i 2464

Err codemadness.org 70 i 2468

ok 1 - tested lf_hash (without my_thread_init) in 82.0496 secs (0)

Err codemadness.org 70 i 2469

Err codemadness.org 70 i 2473

# 6 tests planned but only 1 executed	Err	codemadness.org	70
i  2474

Err codemadness.org 70 i 2475

Err codemadness.org 70 i 2479

Err codemadness.org 70 i 2480

Err codemadness.org 70 i 2481 Err codemadness.org 70 i 2482

Solution

Err codemadness.org 70 i 2483 Err codemadness.org 70 i 2484

Find attached a diff that changes three accesses to be atomic.

Err codemadness.org 70 i 2485 Err codemadness.org 70 i 2486

optimistic read of key in l_find lf_hash.cc#L117
read of link for verification lf_hash.cc#L124
write of key in add_to_purgatory lf_alloc-pin.c#L253

Err codemadness.org 70 i 2491 Err codemadness.org 70 i 2492 Err codemadness.org 70 i 2493

(1 & 2) The implicit SC fence of the atomic load of key and link disallows reordering the load of key after load of link. (3) The implicit RELEASE fence of the atomic write of key disallows reordering the write of key to happen before the CAS that removed the node from the list.

Err codemadness.org 70 i 2494 Err codemadness.org 70 i 2495

Attached is also a minimal working example for the bug, which was used to verify the fixed version with GenMC, a model checker for weak memory models. The model checker can be applied to the attached MWE to get an execution on a weak memory model architecture that leads to the bug. It was also applied to a much more complete extraction of the actual lock-free hash from MariaDB to verify the data structure. However, due to ease of presentation, only the MWE is included here. If there is further interest in the extracted lf-hash and its verification with GenMC, it can be supplied.

Err codemadness.org 70 i 2496 Err codemadness.org 70 i 2497

Relation to MDEV-23510

Err codemadness.org 70 i 2498 Err codemadness.org 70 i 2499

The problem described in ~~MDEV-23510~~ is the result of the herein described bug.

Err codemadness.org 70 i 2500 However, the commit attached to it d30c1331a18d875e553f3fcf544997e4f33fb943, is not fixing the bug, but hiding it, partially.

Err codemadness.org 70 i 2501 Err codemadness.org 70 i 2502

The bug is not related to the cache line size, or splitting between two cache lines.

Err codemadness.org 70 i 2503 Still the commit affects the crash.

Err codemadness.org 70 i 2504 Moving link and key right next to each other in memory, plus removing the volatile declaration of link allows an optimization to take place during code generation for ARM that combines two load ldr instructions for consecutive memory positions into a single ldp instruction for loading a pair. This instruction loads link and key together in a single instruction. Reordering this instruction to happen after the loop verification (L124) is not possible, as the load of link needs to happen for the verification. As such the load of key cannot be reordered to be executed after verification.

Err codemadness.org 70 i 2505 Err codemadness.org 70 i 2506

However, depending on a specific compiler optimization (Aarch64 Load Store Optimization) for correctness of the algorithm is risky and the algorithm is still incorrect. This can easily be seen as optimization levels -O0 and -O1 do not produce assembly containing the necessary pair load ldp of link and key. As such, both versions do crash on ARM. This fragile state might break due to changes in the struct LF_SLIST, changes to the algorithm or compiler changes.

Err codemadness.org 70 i 2507

Err codemadness.org 70 i 2508

Err codemadness.org 70 i 2511 Err codemadness.org 70 i 2512

Err codemadness.org 70 i 2513 Err codemadness.org 70 i 2514 Err codemadness.org 70 i 2515 Err codemadness.org 70 i 2516 Err codemadness.org 70 i 2519 Err codemadness.org 70 i 2520 Err codemadness.org 70 i 2521

Err codemadness.org 70 i 2517 Comments Err codemadness.org 70 i 2518

Err codemadness.org 70 i 2522 Err codemadness.org 70 i 2523 Err codemadness.org 70 i 2524 Err codemadness.org 70 i 2535 Err codemadness.org 70 i 2824 Err codemadness.org 70 i 2835 Err codemadness.org 70 i 2953

Err codemadness.org 70 i 2525 Comment by Err codemadness.org 70 i 2526 Daniel Black Err codemadness.org 70 i 2527 Err codemadness.org 70 i 2528 [ Err codemadness.org 70 i 2529 2021-11-20 Err codemadness.org 70 i 2530 Err codemadness.org 70 i 2531 ] Err codemadness.org 70 i 2532 Err codemadness.org 70 i 2533 Err codemadness.org 70 i 2534

Err codemadness.org 70 i 2536

Thansk Martin Beck for the detail and why the previous only partially worked.

Err codemadness.org 70 i 2537 Err codemadness.org 70 i 2538

Err codemadness.org 70 i 2539

Err codemadness.org 70 i 2540 Err codemadness.org 70 i 2541 Err codemadness.org 70 i 2542 Err codemadness.org 70 i 2543 Err codemadness.org 70 i 2546 Err codemadness.org 70 i 2547 Err codemadness.org 70 i 2548 Err codemadness.org 70 i 2551 Err codemadness.org 70 i 2552 Err codemadness.org 70 i 2553 Err codemadness.org 70 i 2556 Err codemadness.org 70 i 2557 Err codemadness.org 70 i 2558 Err codemadness.org 70 i 2561 Err codemadness.org 70 i 2562 Err codemadness.org 70 i 2563 Err codemadness.org 70 i 2566 Err codemadness.org 70 i 2567 Err codemadness.org 70 i 2568 Err codemadness.org 70 i 2571 Err codemadness.org 70 i 2572 Err codemadness.org 70 i 2573 Err codemadness.org 70 i 2576 Err codemadness.org 70 i 2577 Err codemadness.org 70 i 2578 Err codemadness.org 70 i 2581 Err codemadness.org 70 i 2582 Err codemadness.org 70 i 2583 Err codemadness.org 70 i 2586 Err codemadness.org 70 i 2587 Err codemadness.org 70 i 2588 Err codemadness.org 70 i 2591 Err codemadness.org 70 i 2592 Err codemadness.org 70 i 2593 Err codemadness.org 70 i 2596 Err codemadness.org 70 i 2597 Err codemadness.org 70 i 2598 Err codemadness.org 70 i 2601 Err codemadness.org 70 i 2602 Err codemadness.org 70 i 2603 Err codemadness.org 70 i 2606 Err codemadness.org 70 i 2607 Err codemadness.org 70 i 2608 Err codemadness.org 70 i 2611 Err codemadness.org 70 i 2612 Err codemadness.org 70 i 2613 Err codemadness.org 70 i 2616 Err codemadness.org 70 i 2617 Err codemadness.org 70 i 2618 Err codemadness.org 70 i 2621 Err codemadness.org 70 i 2622 Err codemadness.org 70 i 2623 Err codemadness.org 70 i 2626 Err codemadness.org 70 i 2627 Err codemadness.org 70 i 2628 Err codemadness.org 70 i 2631 Err codemadness.org 70 i 2632 Err codemadness.org 70 i 2633 Err codemadness.org 70 i 2636 Err codemadness.org 70 i 2637 Err codemadness.org 70 i 2638 Err codemadness.org 70 i 2641 Err codemadness.org 70 i 2642 Err codemadness.org 70 i 2643 Err codemadness.org 70 i 2646 Err codemadness.org 70 i 2647 Err codemadness.org 70 i 2648 Err codemadness.org 70 i 2651 Err codemadness.org 70 i 2652 Err codemadness.org 70 i 2653 Err codemadness.org 70 i 2656 Err codemadness.org 70 i 2657 Err codemadness.org 70 i 2658 Err codemadness.org 70 i 2661 Err codemadness.org 70 i 2662 Err codemadness.org 70 i 2663 Err codemadness.org 70 i 2666 Err codemadness.org 70 i 2667 Err codemadness.org 70 i 2668 Err codemadness.org 70 i 2671 Err codemadness.org 70 i 2672 Err codemadness.org 70 i 2673 Err codemadness.org 70 i 2676 Err codemadness.org 70 i 2677 Err codemadness.org 70 i 2678 Err codemadness.org 70 i 2681 Err codemadness.org 70 i 2682 Err codemadness.org 70 i 2683 Err codemadness.org 70 i 2686 Err codemadness.org 70 i 2687 Err codemadness.org 70 i 2688 Err codemadness.org 70 i 2691 Err codemadness.org 70 i 2692 Err codemadness.org 70 i 2693 Err codemadness.org 70 i 2696 Err codemadness.org 70 i 2697 Err codemadness.org 70 i 2698 Err codemadness.org 70 i 2701 Err codemadness.org 70 i 2702 Err codemadness.org 70 i 2703 Err codemadness.org 70 i 2706 Err codemadness.org 70 i 2707 Err codemadness.org 70 i 2708 Err codemadness.org 70 i 2711 Err codemadness.org 70 i 2712 Err codemadness.org 70 i 2713 Err codemadness.org 70 i 2716 Err codemadness.org 70 i 2717 Err codemadness.org 70 i 2718 Err codemadness.org 70 i 2721 Err codemadness.org 70 i 2722 Err codemadness.org 70 i 2723 Err codemadness.org 70 i 2726 Err codemadness.org 70 i 2727 Err codemadness.org 70 i 2728 Err codemadness.org 70 i 2731 Err codemadness.org 70 i 2732 Err codemadness.org 70 i 2733 Err codemadness.org 70 i 2736 Err codemadness.org 70 i 2737 Err codemadness.org 70 i 2738 Err codemadness.org 70 i 2741 Err codemadness.org 70 i 2742 Err codemadness.org 70 i 2743 Err codemadness.org 70 i 2746 Err codemadness.org 70 i 2747 Err codemadness.org 70 i 2748 Err codemadness.org 70 i 2751 Err codemadness.org 70 i 2752 Err codemadness.org 70 i 2753 Err codemadness.org 70 i 2756 Err codemadness.org 70 i 2757 Err codemadness.org 70 i 2758 Err codemadness.org 70 i 2761 Err codemadness.org 70 i 2762 Err codemadness.org 70 i 2763 Err codemadness.org 70 i 2766 Err codemadness.org 70 i 2767 Err codemadness.org 70 i 2768 Err codemadness.org 70 i 2771 Err codemadness.org 70 i 2772 Err codemadness.org 70 i 2773 Err codemadness.org 70 i 2776 Err codemadness.org 70 i 2777 Err codemadness.org 70 i 2778 Err codemadness.org 70 i 2781 Err codemadness.org 70 i 2782 Err codemadness.org 70 i 2783 Err codemadness.org 70 i 2786 Err codemadness.org 70 i 2787 Err codemadness.org 70 i 2788 Err codemadness.org 70 i 2791 Err codemadness.org 70 i 2792 Err codemadness.org 70 i 2793 Err codemadness.org 70 i 2796 Err codemadness.org 70 i 2797 Err codemadness.org 70 i 2798 Err codemadness.org 70 i 2801 Err codemadness.org 70 i 2802 Err codemadness.org 70 i 2803 Err codemadness.org 70 i 2807 Err codemadness.org 70 i 2808 Err codemadness.org 70 i 2809

Err codemadness.org 70 i 2544

dan@eq-arm1:~/build-mariadb-10.2$ /usr/bin/clang --version

Err codemadness.org 70 i 2545

Err codemadness.org 70 i 2549

Debian clang version 11.0.1-2

Err codemadness.org 70 i 2550

Err codemadness.org 70 i 2554

Target: aarch64-unknown-linux-gnu

Err codemadness.org 70 i 2555

Err codemadness.org 70 i 2559

Thread model: posix

Err codemadness.org 70 i 2560

Err codemadness.org 70 i 2564

Err codemadness.org 70 i 2565

Err codemadness.org 70 i 2569

dan@eq-arm1:~/build-mariadb-10.2$ cmake  ../mariadb-10.2/ -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_FLAGS="-O1" -DCMAKE_CXX_FLAGS=-O1

Err codemadness.org 70 i 2570

Err codemadness.org 70 i 2574

Err codemadness.org 70 i 2575

Err codemadness.org 70 i 2579

dan@eq-arm1:~/build-mariadb-10.2$ cmake --build . --verbose

Err codemadness.org 70 i 2580

Err codemadness.org 70 i 2584

[1/7] cd /home/dan/build-mariadb-10.2 && /usr/bin/cmake -P /home/dan/mariadb-10.2/cmake/info_bin.cmake

Err codemadness.org 70 i 2585

Err codemadness.org 70 i 2589

[2/7] cd /home/dan/build-mariadb-10.2 && /usr/bin/cmake -P /home/dan/mariadb-10.2/cmake/info_src.cmake

Err codemadness.org 70 i 2590

Err codemadness.org 70 i 2594

[3/7] cd /home/dan/build-mariadb-10.2 && /usr/bin/cmake -DCOMPILER=/usr/bin/clang -DSOURCE_DIR=/home/dan/mariadb-10.2 -DBINARY_DIR=/home/dan/build-mariadb-10.2 "-DABI_HEADERS=/home/dan/mariadb-10.2/include/mysql/plugin_audit.h;/home/dan/mariadb-10.2/include/mysql/plugin_ftparser.h;/home/dan/mariadb-10.2/include/mysql.h;/home/dan/mariadb-10.2/include/mysql/psi/psi_abi_v1.h;/home/dan/mariadb-10.2/include/mysql/psi/psi_abi_v2.h;/home/dan/mariadb-10.2/include/mysql/client_plugin.h;/home/dan/mariadb-10.2/include/mysql/plugin_auth.h;/home/dan/mariadb-10.2/include/mysql/plugin_password_validation.h;/home/dan/mariadb-10.2/include/mysql/plugin_encryption.h" -P /home/dan/mariadb-10.2/cmake/do_abi_check.cmake

Err codemadness.org 70 i 2595

Err codemadness.org 70 i 2599

[4/7] /usr/bin/clang -DDBUG_TRACE -DHAVE_CONFIG_H -D_FILE_OFFSET_BITS=64 -Iinclude -I/home/dan/mariadb-10.2/include -I/home/dan/mariadb-10.2/unittest/mytap -O1 -fstack-protector --param=ssp-buffer-size=4 -O2 -g -DNDEBUG -D_FORTIFY_SOURCE=2 -DDBUG_OFF -Wall -Wdeclaration-after-statement -Wextra -Wformat-security -Wno-init-self -Wno-null-conversion -Wno-unused-parameter -Wno-unused-private-field -Woverloaded-virtual -Wvla -Wwrite-strings   -DHAVE_YASSL -DYASSL_PREFIX -DHAVE_OPENSSL -DMULTI_THREADED -MD -MT unittest/mysys/CMakeFiles/lf-t.dir/lf-t.c.o -MF unittest/mysys/CMakeFiles/lf-t.dir/lf-t.c.o.d -o unittest/mysys/CMakeFiles/lf-t.dir/lf-t.c.o -c /home/dan/mariadb-10.2/unittest/mysys/lf-t.c

Err codemadness.org 70 i 2600

Err codemadness.org 70 i 2604

[5/7] /usr/bin/clang -DDBUG_TRACE -DHAVE_CONFIG_H -D_FILE_OFFSET_BITS=64 -Iinclude -I/home/dan/mariadb-10.2/include -I/home/dan/mariadb-10.2/unittest/mytap -O1 -fstack-protector --param=ssp-buffer-size=4 -O2 -g -DNDEBUG -D_FORTIFY_SOURCE=2 -DDBUG_OFF -Wall -Wdeclaration-after-statement -Wextra -Wformat-security -Wno-init-self -Wno-null-conversion -Wno-unused-parameter -Wno-unused-private-field -Woverloaded-virtual -Wvla -Wwrite-strings   -DHAVE_YASSL -DYASSL_PREFIX -DHAVE_OPENSSL -DMULTI_THREADED -MD -MT unittest/mysys/CMakeFiles/my_atomic-t.dir/my_atomic-t.c.o -MF unittest/mysys/CMakeFiles/my_atomic-t.dir/my_atomic-t.c.o.d -o unittest/mysys/CMakeFiles/my_atomic-t.dir/my_atomic-t.c.o -c /home/dan/mariadb-10.2/unittest/mysys/my_atomic-t.c

Err codemadness.org 70 i 2605

Err codemadness.org 70 i 2609

[6/7] : && /usr/bin/clang++ -O1 -fstack-protector --param=ssp-buffer-size=4 -fno-rtti -O2 -g -DNDEBUG -D_FORTIFY_SOURCE=2 -DDBUG_OFF -Wall -Wdeclaration-after-statement -Wextra -Wformat-security -Wno-init-self -Wno-null-conversion -Wno-unused-parameter -Wno-unused-private-field -Woverloaded-virtual -Wvla -Wwrite-strings -Wl,-z,relro,-z,now unittest/mysys/CMakeFiles/lf-t.dir/lf-t.c.o -o unittest/mysys/lf-t  -lpthread  unittest/mytap/libmytap.a  mysys/libmysys.a  dbug/libdbug.a  mysys/libmysys.a  dbug/libdbug.a  strings/libstrings.a  -lz  -lm  -ldl  -lpthread && :

Err codemadness.org 70 i 2610

Err codemadness.org 70 i 2614

[7/7] : && /usr/bin/clang++ -O1 -fstack-protector --param=ssp-buffer-size=4 -fno-rtti -O2 -g -DNDEBUG -D_FORTIFY_SOURCE=2 -DDBUG_OFF -Wall -Wdeclaration-after-statement -Wextra -Wformat-security -Wno-init-self -Wno-null-conversion -Wno-unused-parameter -Wno-unused-private-field -Woverloaded-virtual -Wvla -Wwrite-strings -Wl,-z,relro,-z,now unittest/mysys/CMakeFiles/my_atomic-t.dir/my_atomic-t.c.o -o unittest/mysys/my_atomic-t  -lpthread  unittest/mytap/libmytap.a  mysys/libmysys.a  dbug/libdbug.a  mysys/libmysys.a  dbug/libdbug.a  strings/libstrings.a  -lz  -lm  -ldl  -lpthread && :

Err codemadness.org 70 i 2615

Err codemadness.org 70 i 2619

dan@eq-arm1:~/build-mariadb-10.2$ ./unittest/mysys/lf-t

Err codemadness.org 70 i 2620

Err codemadness.org 70 i 2624

# N CPUs: 160, atomic ops: gcc-atomics-smp

Err codemadness.org 70 i 2625

Err codemadness.org 70 i 2629

1..7

Err codemadness.org 70 i 2630

Err codemadness.org 70 i 2634

ok 1 - my_atomic_initialize() returned 0

Err codemadness.org 70 i 2635

Err codemadness.org 70 i 2639

# Testing lf_hash (without my_thread_init) with 160 threads, 300000 iterations...

Err codemadness.org 70 i 2640

Err codemadness.org 70 i 2644

# 0 mallocs, 160 pins in stack, 4096 hash size, 16167030 inserts, 54494 scans

Err codemadness.org 70 i 2645

Err codemadness.org 70 i 2649

ok 2 - tested lf_hash (without my_thread_init) in 115.919 secs (0)

Err codemadness.org 70 i 2650

Err codemadness.org 70 i 2654

# 7 tests planned but only 2 executed

Err codemadness.org 70 i 2655

Err codemadness.org 70 i 2659

dan@eq-arm1:~/build-mariadb-10.2$ cmake --build .

Err codemadness.org 70 i 2660

Err codemadness.org 70 i 2664

[7/7] Linking CXX executable unittest/mysys/lf-t

Err codemadness.org 70 i 2665

Err codemadness.org 70 i 2669

dan@eq-arm1:~/build-mariadb-10.2$ ./unittest/mysys/lf-t

Err codemadness.org 70 i 2670

Err codemadness.org 70 i 2674

# N CPUs: 160, atomic ops: gcc-atomics-smp

Err codemadness.org 70 i 2675

Err codemadness.org 70 i 2679

1..7

Err codemadness.org 70 i 2680

Err codemadness.org 70 i 2684

ok 1 - my_atomic_initialize() returned 0

Err codemadness.org 70 i 2685

Err codemadness.org 70 i 2689

# Testing lf_hash (without my_thread_init) with 2 threads, 30000000 iterations...

Err codemadness.org 70 i 2690

Err codemadness.org 70 i 2694

# 0 mallocs, 2 pins in stack, 2048 hash size, 14880152 inserts, 7568227 scans

Err codemadness.org 70 i 2695

Err codemadness.org 70 i 2699

ok 2 - tested lf_hash (without my_thread_init) in 126.009 secs (0)

Err codemadness.org 70 i 2700

Err codemadness.org 70 i 2704

# 7 tests planned but only 2 executed

Err codemadness.org 70 i 2705

Err codemadness.org 70 i 2709

dan@eq-arm1:~/build-mariadb-10.2$  /usr/bin/clang -DDBUG_TRACE -DHAVE_CONFIG_H -D_FILE_OFFSET_BITS=64 -Iinclude -I/home/dan/mariadb-10.2/include -I/home/dan/mariadb-10.2/unittest/mytap -O1 -fstack-protector --param=ssp-buffer-size=4 -g -DNDEBUG -D_FORTIFY_SOURCE=2 -DDBUG_OFF -Wall -Wdeclaration-after-statement -Wextra -Wformat-security -Wno-init-self -Wno-null-conversion -Wno-unused-parameter -Wno-unused-private-field -Woverloaded-virtual -Wvla -Wwrite-strings   -DHAVE_YASSL -DYASSL_PREFIX -DHAVE_OPENSSL -DMULTI_THREADED -MD -MT unittest/mysys/CMakeFiles/lf-t.dir/lf-t.c.o -MF unittest/mysys/CMakeFiles/lf-t.dir/lf-t.c.o.d -o unittest/mysys/CMakeFiles/lf-t.dir/lf-t.c.o -c /home/dan/mariadb-10.2/unittest/mysys/lf-t.c

Err codemadness.org 70 i 2710

Err codemadness.org 70 i 2714

dan@eq-arm1:~/build-mariadb-10.2$ /usr/bin/clang++ -O1 -fstack-protector --param=ssp-buffer-size=4 -fno-rtti  -g -DNDEBUG -D_FORTIFY_SOURCE=2 -DDBUG_OFF -Wall -Wdeclaration-after-statement -Wextra -Wformat-security -Wno-init-self -Wno-null-conversion -Wno-unused-parameter -Wno-unused-private-field -Woverloaded-virtual -Wvla -Wwrite-strings -Wl,-z,relro,-z,now unittest/mysys/CMakeFiles/lf-t.dir/lf-t.c.o -o unittest/mysys/lf-t  -lpthread  unittest/mytap/libmytap.a  mysys/libmysys.a  dbug/libdbug.a  mysys/libmysys.a  dbug/libdbug.a  strings/libstrings.a  -lz  -lm  -ldl  -lpthread

Err codemadness.org 70 i 2715

Err codemadness.org 70 i 2719

dan@eq-arm1:~/build-mariadb-10.2$ ./unittest/mysys/lf-t

Err codemadness.org 70 i 2720

Err codemadness.org 70 i 2724

# N CPUs: 160, atomic ops: gcc-atomics-smp

Err codemadness.org 70 i 2725

Err codemadness.org 70 i 2729

1..7

Err codemadness.org 70 i 2730

Err codemadness.org 70 i 2734

ok 1 - my_atomic_initialize() returned 0

Err codemadness.org 70 i 2735

Err codemadness.org 70 i 2739

# Testing lf_hash (without my_thread_init) with 2 threads, 30000000 iterations...

Err codemadness.org 70 i 2740

Err codemadness.org 70 i 2744

# 0 mallocs, 2 pins in stack, 1024 hash size, 14999984 inserts, 7490617 scans

Err codemadness.org 70 i 2745

Err codemadness.org 70 i 2749

ok 2 - tested lf_hash (without my_thread_init) in 107.189 secs (0)

Err codemadness.org 70 i 2750

Err codemadness.org 70 i 2754

# 7 tests planned but only 2 executed

Err codemadness.org 70 i 2755

Err codemadness.org 70 i 2759

Err codemadness.org 70 i 2760

Err codemadness.org 70 i 2764

dan@eq-arm1:~/build-mariadb-10.2$ more /proc/cpuinfo

Err codemadness.org 70 i 2765

Err codemadness.org 70 i 2769

processor        : 0

Err codemadness.org 70 i 2770

Err codemadness.org 70 i 2774

BogoMIPS        : 50.00

Err codemadness.org 70 i 2775

Err codemadness.org 70 i 2779

Features        : fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm lrcpc dcpop asimddp ssbs

Err codemadness.org 70 i 2780

Err codemadness.org 70 i 2784

CPU implementer        : 0x41

Err codemadness.org 70 i 2785

Err codemadness.org 70 i 2789

CPU architecture: 8

Err codemadness.org 70 i 2790

Err codemadness.org 70 i 2794

CPU variant        : 0x3

Err codemadness.org 70 i 2795

Err codemadness.org 70 i 2799

CPU part        : 0xd0c

Err codemadness.org 70 i 2800

Err codemadness.org 70 i 2804

CPU revision        : 1	Err	codemadness.org	70
i  2805

Err codemadness.org 70 i 2806

Err codemadness.org 70 i 2810

Err codemadness.org 70 i 2811

Err codemadness.org 70 i 2812 Err codemadness.org 70 i 2813

So I'm having trouble reproducing it. Your threads shows 30 despite being 2 in the descriptoin.

Err codemadness.org 70 i 2814 Err codemadness.org 70 i 2815

With changes, this does passes mtr and lf-t in loop

Err codemadness.org 70 i 2816 Err codemadness.org 70 i 2817

I do believe you however:

Err codemadness.org 70 i 2818 Err codemadness.org 70 i 2819

https://github.com/MariaDB/server/pull/1951 (10.2) - please check I did the casts right here.

Err codemadness.org 70 i 2820 https://github.com/MariaDB/server/pull/1952 (minor differences in 10.5 compared to 10.2)

Err codemadness.org 70 i 2821 Err codemadness.org 70 i 2822

Should the unit tests CYCLES be increased to your reproducer values?

Err codemadness.org 70 i 2823

Err codemadness.org 70 i 2825 Comment by Err codemadness.org 70 i 2826 Martin Beck Err codemadness.org 70 i 2827 Err codemadness.org 70 i 2828 [ Err codemadness.org 70 i 2829 2021-11-20 Err codemadness.org 70 i 2830 Err codemadness.org 70 i 2831 ] Err codemadness.org 70 i 2832 Err codemadness.org 70 i 2833 Err codemadness.org 70 i 2834

Err codemadness.org 70 i 2836

The number of CYCLES and THREADS did influence the probability of hitting the bug during execution. I just reran with 30 threads and a cycle count of 30000 and hit the bug within a few seconds.

Err codemadness.org 70 i 2837 Err codemadness.org 70 i 2838

With the previous patch (compiled with -O1; at commit e0ba68ba34f5623cfa3c61e2e1966971703297f5) I get about 6% (213/3200) chance to hit the bug:

Err codemadness.org 70 i 2839

Err codemadness.org 70 i 2840

Err codemadness.org 70 i 2841 Err codemadness.org 70 i 2842 Err codemadness.org 70 i 2843 Err codemadness.org 70 i 2844 Err codemadness.org 70 i 2847 Err codemadness.org 70 i 2848 Err codemadness.org 70 i 2849 Err codemadness.org 70 i 2853 Err codemadness.org 70 i 2854 Err codemadness.org 70 i 2855

Err codemadness.org 70 i 2845

$ for i in `seq 100`; do ./parallel.sh ./lf-t; done | grep 'Bail out' | wc -l

Err codemadness.org 70 i 2846

Err codemadness.org 70 i 2850

213	Err	codemadness.org	70
i  2851

Err codemadness.org 70 i 2852

Err codemadness.org 70 i 2856

Err codemadness.org 70 i 2857

Err codemadness.org 70 i 2858 Err codemadness.org 70 i 2859

Without that patch (compiled with -O3 at commit 666565c7f00b0f39bbb459a428efd0093ed05fc8) the chance to hit the bug is about 38% (1247/3200):

Err codemadness.org 70 i 2860

Err codemadness.org 70 i 2861

Err codemadness.org 70 i 2862 Err codemadness.org 70 i 2863 Err codemadness.org 70 i 2864 Err codemadness.org 70 i 2865 Err codemadness.org 70 i 2868 Err codemadness.org 70 i 2869 Err codemadness.org 70 i 2870 Err codemadness.org 70 i 2874 Err codemadness.org 70 i 2875 Err codemadness.org 70 i 2876

Err codemadness.org 70 i 2866

$ for i in `seq 100`; do ./parallel.sh ./lf-t; done | grep 'Bail out' | wc -l

Err codemadness.org 70 i 2867

Err codemadness.org 70 i 2871

1247	Err	codemadness.org	70
i  2872

Err codemadness.org 70 i 2873

Err codemadness.org 70 i 2877

Err codemadness.org 70 i 2878

Err codemadness.org 70 i 2879 Err codemadness.org 70 i 2880

On 10.2.41, without changing THREADS or CYCLES, just the vanilla source, 0.5% chance (16/3200):

Err codemadness.org 70 i 2881

Err codemadness.org 70 i 2882

Err codemadness.org 70 i 2883 Err codemadness.org 70 i 2884 Err codemadness.org 70 i 2885 Err codemadness.org 70 i 2886 Err codemadness.org 70 i 2889 Err codemadness.org 70 i 2890 Err codemadness.org 70 i 2891 Err codemadness.org 70 i 2894 Err codemadness.org 70 i 2895 Err codemadness.org 70 i 2896 Err codemadness.org 70 i 2899 Err codemadness.org 70 i 2900 Err codemadness.org 70 i 2901 Err codemadness.org 70 i 2905 Err codemadness.org 70 i 2906 Err codemadness.org 70 i 2907

Err codemadness.org 70 i 2887

$ cmake  ../mariadb-10.2/ -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_FLAGS="-O1" -DCMAKE_CXX_FLAGS=-O1

Err codemadness.org 70 i 2888

Err codemadness.org 70 i 2892

$ cmake --build . --parallel=100 --verbose

Err codemadness.org 70 i 2893

Err codemadness.org 70 i 2897

$ for i in `seq 100`; do ../parallel.sh unittest/mysys/lf-t; done | grep 'Bail out' | wc -l

Err codemadness.org 70 i 2898

Err codemadness.org 70 i 2902

16	Err	codemadness.org	70
i  2903

Err codemadness.org 70 i 2904

Err codemadness.org 70 i 2908

Err codemadness.org 70 i 2909

Err codemadness.org 70 i 2910 Err codemadness.org 70 i 2911

parallel.sh is attached, but basically just spawns 32 processes in parallel and waits.

Err codemadness.org 70 i 2912 parallel.sh

Err codemadness.org 70 i 2913 Err codemadness.org 70 i 2914

Err codemadness.org 70 i 2915

Err codemadness.org 70 i 2916 Err codemadness.org 70 i 2917 Err codemadness.org 70 i 2918 Err codemadness.org 70 i 2919 Err codemadness.org 70 i 2922 Err codemadness.org 70 i 2923 Err codemadness.org 70 i 2924 Err codemadness.org 70 i 2927 Err codemadness.org 70 i 2928 Err codemadness.org 70 i 2929 Err codemadness.org 70 i 2932 Err codemadness.org 70 i 2933 Err codemadness.org 70 i 2934 Err codemadness.org 70 i 2937 Err codemadness.org 70 i 2938 Err codemadness.org 70 i 2939 Err codemadness.org 70 i 2943 Err codemadness.org 70 i 2944 Err codemadness.org 70 i 2945

Err codemadness.org 70 i 2920

clang --version

Err codemadness.org 70 i 2921

Err codemadness.org 70 i 2925

clang version 8.0.0-3~ubuntu18.04.2 (tags/RELEASE_800/final)

Err codemadness.org 70 i 2926

Err codemadness.org 70 i 2930

Target: aarch64-unknown-linux-gnu

Err codemadness.org 70 i 2931

Err codemadness.org 70 i 2935

Thread model: posix

Err codemadness.org 70 i 2936

Err codemadness.org 70 i 2940

InstalledDir: /usr/bin	Err	codemadness.org	70
i  2941

Err codemadness.org 70 i 2942

Err codemadness.org 70 i 2946

Err codemadness.org 70 i 2947

Err codemadness.org 70 i 2948 Err codemadness.org 70 i 2949

The default CYCLE count is rather low to exhibit concurrency bugs, as there is not much time for the OS to generate many interleavings. The probability of this bug appearing is increased by increasing CYCLES. 30000 was just a tradeoff that worked in my case.

Err codemadness.org 70 i 2950 Err codemadness.org 70 i 2951

I will review the propositions (pull 1951 / 1952 later)

Err codemadness.org 70 i 2952

Err codemadness.org 70 i 2954

[MDEV-5816] MySQL WL#4179 - Stored programs: validation of stored program statements

Sergey Vojtovich — Sat, 20 Nov 2021 11:49:02 +0000

Err codemadness.org 70 i 3030 Err codemadness.org 70 i 3031 Err codemadness.org 70 i 3040 Err codemadness.org 70 i 3041 Err codemadness.org 70 i 3042 Err codemadness.org 70 i 3043 Err codemadness.org 70 i 3044 Err codemadness.org 70 i 3045 Err codemadness.org 70 i 3046 Err codemadness.org 70 i 3047 Err codemadness.org 70 i 3048 Err codemadness.org 70 i 3049 Err codemadness.org 70 i 3050 Err codemadness.org 70 i 3051 Err codemadness.org 70 i 3052 Err codemadness.org 70 i 3055 Err codemadness.org 70 i 3056 Err codemadness.org 70 i 3057 Err codemadness.org 70 i 3058 Err codemadness.org 70 i 3059 Err codemadness.org 70 i 3060 Err codemadness.org 70 i 3061 Err codemadness.org 70 i 3062 Err codemadness.org 70 i 3064 Err codemadness.org 70 i 3065 Err codemadness.org 70 i 3066

Err codemadness.org 70 i 3032 Err codemadness.org 70 i 3033 [MDEV-5816] MySQL WL#4179 - Stored programs: validation of stored program statements Err codemadness.org 70 i 3034 Err codemadness.org 70 i 3035 Created: 2014-03-11 Updated: 2021-11-20 Err codemadness.org 70 i 3036 Err codemadness.org 70 i 3037 Err codemadness.org 70 i 3038 Err codemadness.org 70 i 3039
Status:	In Progress
Project:	MariaDB Server
Component/s:	Err codemadness.org 70 i 3053 None Err codemadness.org 70 i 3054
Fix Version/s:	Err codemadness.org 70 i 3063 10.8

Err codemadness.org 70 i 3067 Err codemadness.org 70 i 3068

Err codemadness.org 70 i 3069 Err codemadness.org 70 i 3070 Err codemadness.org 70 i 3071 Err codemadness.org 70 i 3074 Err codemadness.org 70 i 3077 Err codemadness.org 70 i 3078 Err codemadness.org 70 i 3081 Err codemadness.org 70 i 3084 Err codemadness.org 70 i 3085 Err codemadness.org 70 i 3086 Err codemadness.org 70 i 3089 Err codemadness.org 70 i 3092 Err codemadness.org 70 i 3093 Err codemadness.org 70 i 3096 Err codemadness.org 70 i 3099 Err codemadness.org 70 i 3100 Err codemadness.org 70 i 3101 Err codemadness.org 70 i 3104 Err codemadness.org 70 i 3107 Err codemadness.org 70 i 3110 Err codemadness.org 70 i 3113 Err codemadness.org 70 i 3114 Err codemadness.org 70 i 3115 Err codemadness.org 70 i 3116 Err codemadness.org 70 i 3117 Err codemadness.org 70 i 3120 Err codemadness.org 70 i 3122 Err codemadness.org 70 i 3123 Err codemadness.org 70 i 3124 Err codemadness.org 70 i 3125 Err codemadness.org 70 i 3126 Err codemadness.org 70 i 3127 Err codemadness.org 70 i 3128

Err codemadness.org 70 i 3072 Type: Err codemadness.org 70 i 3073

Err codemadness.org 70 i 3075 Task Err codemadness.org 70 i 3076

Err codemadness.org 70 i 3079 Priority: Err codemadness.org 70 i 3080

Err codemadness.org 70 i 3082 Critical Err codemadness.org 70 i 3083

Err codemadness.org 70 i 3087 Reporter: Err codemadness.org 70 i 3088

Err codemadness.org 70 i 3090 Sergey Vojtovich Err codemadness.org 70 i 3091

Err codemadness.org 70 i 3094 Assignee: Err codemadness.org 70 i 3095

Err codemadness.org 70 i 3097 Dmitry Shulga Err codemadness.org 70 i 3098

Err codemadness.org 70 i 3102 Resolution: Err codemadness.org 70 i 3103

Err codemadness.org 70 i 3105 Unresolved Err codemadness.org 70 i 3106

Err codemadness.org 70 i 3108 Votes: Err codemadness.org 70 i 3109

Err codemadness.org 70 i 3111 2 Err codemadness.org 70 i 3112

Err codemadness.org 70 i 3118 Labels: Err codemadness.org 70 i 3119

Err codemadness.org 70 i 3121 upstream-fixed

Err codemadness.org 70 i 3129 Err codemadness.org 70 i 3130 Err codemadness.org 70 i 3131 Err codemadness.org 70 i 3132

Err codemadness.org 70 i 3133 Err codemadness.org 70 i 3134 Err codemadness.org 70 i 3135 Err codemadness.org 70 i 3136 Err codemadness.org 70 i 3137 Err codemadness.org 70 i 3138 Err codemadness.org 70 i 3141 Err codemadness.org 70 i 3147 Err codemadness.org 70 i 3148 Err codemadness.org 70 i 3149 Err codemadness.org 70 i 3150 Err codemadness.org 70 i 3153 Err codemadness.org 70 i 3352 Err codemadness.org 70 i 3353 Err codemadness.org 70 i 3354 Err codemadness.org 70 i 3355 Err codemadness.org 70 i 3356 Err codemadness.org 70 i 3357

Err codemadness.org 70 i 3139 Attachments: Err codemadness.org 70 i 3140

Err codemadness.org 70 i 3142 Err codemadness.org 70 i 3143 wl4179-add.patch Err codemadness.org 70 i 3144 Err codemadness.org 70 i 3145 wl4179.patch Err codemadness.org 70 i 3146

Err codemadness.org 70 i 3151 Issue Links: Err codemadness.org 70 i 3152

Err codemadness.org 70 i 3154 Err codemadness.org 70 i 3155 Err codemadness.org 70 i 3156 Err codemadness.org 70 i 3159 Err codemadness.org 70 i 3160 Err codemadness.org 70 i 3161 Err codemadness.org 70 i 3164 Err codemadness.org 70 i 3168 Err codemadness.org 70 i 3171 Err codemadness.org 70 i 3174 Err codemadness.org 70 i 3175 Err codemadness.org 70 i 3176 Err codemadness.org 70 i 3179 Err codemadness.org 70 i 3183 Err codemadness.org 70 i 3186 Err codemadness.org 70 i 3189 Err codemadness.org 70 i 3190 Err codemadness.org 70 i 3191 Err codemadness.org 70 i 3194 Err codemadness.org 70 i 3198 Err codemadness.org 70 i 3201 Err codemadness.org 70 i 3204 Err codemadness.org 70 i 3205 Err codemadness.org 70 i 3206 Err codemadness.org 70 i 3209 Err codemadness.org 70 i 3213 Err codemadness.org 70 i 3216 Err codemadness.org 70 i 3219 Err codemadness.org 70 i 3220 Err codemadness.org 70 i 3221 Err codemadness.org 70 i 3224 Err codemadness.org 70 i 3228 Err codemadness.org 70 i 3231 Err codemadness.org 70 i 3234 Err codemadness.org 70 i 3235 Err codemadness.org 70 i 3236 Err codemadness.org 70 i 3239 Err codemadness.org 70 i 3243 Err codemadness.org 70 i 3246 Err codemadness.org 70 i 3249 Err codemadness.org 70 i 3250 Err codemadness.org 70 i 3251 Err codemadness.org 70 i 3254 Err codemadness.org 70 i 3255 Err codemadness.org 70 i 3256 Err codemadness.org 70 i 3259 Err codemadness.org 70 i 3263 Err codemadness.org 70 i 3266 Err codemadness.org 70 i 3269 Err codemadness.org 70 i 3270 Err codemadness.org 70 i 3271 Err codemadness.org 70 i 3274 Err codemadness.org 70 i 3278 Err codemadness.org 70 i 3281 Err codemadness.org 70 i 3284 Err codemadness.org 70 i 3285 Err codemadness.org 70 i 3286 Err codemadness.org 70 i 3289 Err codemadness.org 70 i 3293 Err codemadness.org 70 i 3296 Err codemadness.org 70 i 3299 Err codemadness.org 70 i 3300 Err codemadness.org 70 i 3301 Err codemadness.org 70 i 3304 Err codemadness.org 70 i 3305 Err codemadness.org 70 i 3306 Err codemadness.org 70 i 3309 Err codemadness.org 70 i 3313 Err codemadness.org 70 i 3316 Err codemadness.org 70 i 3319 Err codemadness.org 70 i 3320 Err codemadness.org 70 i 3321 Err codemadness.org 70 i 3324 Err codemadness.org 70 i 3328 Err codemadness.org 70 i 3331 Err codemadness.org 70 i 3334 Err codemadness.org 70 i 3335 Err codemadness.org 70 i 3336 Err codemadness.org 70 i 3339 Err codemadness.org 70 i 3343 Err codemadness.org 70 i 3346 Err codemadness.org 70 i 3349 Err codemadness.org 70 i 3350

Err codemadness.org 70 i 3157 Blocks Err codemadness.org 70 i 3158
Err codemadness.org 70 i 3162 blocks Err codemadness.org 70 i 3163	Err codemadness.org 70 i 3165 Err codemadness.org 70 i 3166 MDEV-11225 Err codemadness.org 70 i 3167	Err codemadness.org 70 i 3169 SELECT from view, which was replaced ... Err codemadness.org 70 i 3170	Err codemadness.org 70 i 3172 Stalled Err codemadness.org 70 i 3173
Err codemadness.org 70 i 3177 blocks Err codemadness.org 70 i 3178	Err codemadness.org 70 i 3180 Err codemadness.org 70 i 3181 MDEV-11652 Err codemadness.org 70 i 3182	Err codemadness.org 70 i 3184 SP with cursors does not work well in... Err codemadness.org 70 i 3185	Err codemadness.org 70 i 3187 Open Err codemadness.org 70 i 3188
Err codemadness.org 70 i 3192 blocks Err codemadness.org 70 i 3193	Err codemadness.org 70 i 3195 Err codemadness.org 70 i 3196 MDEV-14557 Err codemadness.org 70 i 3197	Err codemadness.org 70 i 3199 Assertion `m_sp == __null' failed in ... Err codemadness.org 70 i 3200	Err codemadness.org 70 i 3202 Stalled Err codemadness.org 70 i 3203
Err codemadness.org 70 i 3207 is blocked by Err codemadness.org 70 i 3208	Err codemadness.org 70 i 3210 Err codemadness.org 70 i 3211 ~~MDEV-19637~~ Err codemadness.org 70 i 3212	Err codemadness.org 70 i 3214 Crash on an SP variable assignment to... Err codemadness.org 70 i 3215	Err codemadness.org 70 i 3217 Closed Err codemadness.org 70 i 3218
Err codemadness.org 70 i 3222 is blocked by Err codemadness.org 70 i 3223	Err codemadness.org 70 i 3225 Err codemadness.org 70 i 3226 ~~MDEV-19639~~ Err codemadness.org 70 i 3227	Err codemadness.org 70 i 3229 sql_mode=ORACLE: Wrong SHOW PROCEDURE... Err codemadness.org 70 i 3230	Err codemadness.org 70 i 3232 Closed Err codemadness.org 70 i 3233
Err codemadness.org 70 i 3237 is blocked by Err codemadness.org 70 i 3238	Err codemadness.org 70 i 3240 Err codemadness.org 70 i 3241 ~~MDEV-19640~~ Err codemadness.org 70 i 3242	Err codemadness.org 70 i 3244 Wrong SHOW PROCEDURE output for SET G... Err codemadness.org 70 i 3245	Err codemadness.org 70 i 3247 Closed Err codemadness.org 70 i 3248
Err codemadness.org 70 i 3252 PartOf Err codemadness.org 70 i 3253
Err codemadness.org 70 i 3257 includes Err codemadness.org 70 i 3258	Err codemadness.org 70 i 3260 Err codemadness.org 70 i 3261 MDEV-774 Err codemadness.org 70 i 3262	Err codemadness.org 70 i 3264 LP:948583 - Stored procedure doesn't ... Err codemadness.org 70 i 3265	Err codemadness.org 70 i 3267 Confirmed Err codemadness.org 70 i 3268
Err codemadness.org 70 i 3272 includes Err codemadness.org 70 i 3273	Err codemadness.org 70 i 3275 Err codemadness.org 70 i 3276 MDEV-6488 Err codemadness.org 70 i 3277	Err codemadness.org 70 i 3279 Autodiscover + CONNECT + OR REPLACE Err codemadness.org 70 i 3280	Err codemadness.org 70 i 3282 Open Err codemadness.org 70 i 3283
Err codemadness.org 70 i 3287 is part of Err codemadness.org 70 i 3288	Err codemadness.org 70 i 3290 Err codemadness.org 70 i 3291 MDEV-4784 Err codemadness.org 70 i 3292	Err codemadness.org 70 i 3294 merge test cases from 5.6 Err codemadness.org 70 i 3295	Err codemadness.org 70 i 3297 Stalled Err codemadness.org 70 i 3298
Err codemadness.org 70 i 3302 Relates Err codemadness.org 70 i 3303
Err codemadness.org 70 i 3307 relates to Err codemadness.org 70 i 3308	Err codemadness.org 70 i 3310 Err codemadness.org 70 i 3311 MDEV-26048 Err codemadness.org 70 i 3312	Err codemadness.org 70 i 3314 Table 'test._test_new' doesn't exist ... Err codemadness.org 70 i 3315	Err codemadness.org 70 i 3317 Stalled Err codemadness.org 70 i 3318
Err codemadness.org 70 i 3322 relates to Err codemadness.org 70 i 3323	Err codemadness.org 70 i 3325 Err codemadness.org 70 i 3326 ~~MDEV-7410~~ Err codemadness.org 70 i 3327	Err codemadness.org 70 i 3329 Temporary table name conflict between... Err codemadness.org 70 i 3330	Err codemadness.org 70 i 3332 Closed Err codemadness.org 70 i 3333
Err codemadness.org 70 i 3337 relates to Err codemadness.org 70 i 3338	Err codemadness.org 70 i 3340 Err codemadness.org 70 i 3341 MDEV-12166 Err codemadness.org 70 i 3342	Err codemadness.org 70 i 3344 PROCEDURE using a SELECT from a tempo... Err codemadness.org 70 i 3345	Err codemadness.org 70 i 3347 Open Err codemadness.org 70 i 3348

Err codemadness.org 70 i 3351

Err codemadness.org 70 i 3358 Err codemadness.org 70 i 3359

Err codemadness.org 70 i 3360 Err codemadness.org 70 i 3361 Err codemadness.org 70 i 3362 Err codemadness.org 70 i 3363 Err codemadness.org 70 i 3366 Err codemadness.org 70 i 3367 Err codemadness.org 70 i 3368

Err codemadness.org 70 i 3364 Description Err codemadness.org 70 i 3365

Err codemadness.org 70 i 3369 Err codemadness.org 70 i 3370 Err codemadness.org 70 i 3371 Err codemadness.org 70 i 3372 Err codemadness.org 70 i 3378 Err codemadness.org 70 i 3379

Err codemadness.org 70 i 3373

Test case for MySQL "WL#4179 - Stored programs: validation of stored program statements" fails in 10.0.

Err codemadness.org 70 i 3374 Err codemadness.org 70 i 3375

Test diff attached. Please try to apply test case as is unless it is applicable.

Err codemadness.org 70 i 3376

Err codemadness.org 70 i 3377

Err codemadness.org 70 i 3380 Err codemadness.org 70 i 3381

Err codemadness.org 70 i 3382 Err codemadness.org 70 i 3383 Err codemadness.org 70 i 3384 Err codemadness.org 70 i 3385 Err codemadness.org 70 i 3388 Err codemadness.org 70 i 3389 Err codemadness.org 70 i 3390

Err codemadness.org 70 i 3386 Comments Err codemadness.org 70 i 3387

Err codemadness.org 70 i 3391 Err codemadness.org 70 i 3392 Err codemadness.org 70 i 3393 Err codemadness.org 70 i 3404 Err codemadness.org 70 i 3407 Err codemadness.org 70 i 3418 Err codemadness.org 70 i 3421 Err codemadness.org 70 i 3432 Err codemadness.org 70 i 3435 Err codemadness.org 70 i 3446 Err codemadness.org 70 i 3468 Err codemadness.org 70 i 3479 Err codemadness.org 70 i 3497 Err codemadness.org 70 i 3508 Err codemadness.org 70 i 3513

Err codemadness.org 70 i 3394 Comment by Err codemadness.org 70 i 3395 Sergey Vojtovich Err codemadness.org 70 i 3396 Err codemadness.org 70 i 3397 [ Err codemadness.org 70 i 3398 2014-03-14 Err codemadness.org 70 i 3399 Err codemadness.org 70 i 3400 ] Err codemadness.org 70 i 3401 Err codemadness.org 70 i 3402 Err codemadness.org 70 i 3403

Err codemadness.org 70 i 3405

Additional coverage for WL#4179 attached.

Err codemadness.org 70 i 3406

Err codemadness.org 70 i 3408 Comment by Err codemadness.org 70 i 3409 Oleksandr Byelkin Err codemadness.org 70 i 3410 Err codemadness.org 70 i 3411 [ Err codemadness.org 70 i 3412 2014-03-18 Err codemadness.org 70 i 3413 Err codemadness.org 70 i 3414 ] Err codemadness.org 70 i 3415 Err codemadness.org 70 i 3416 Err codemadness.org 70 i 3417

Err codemadness.org 70 i 3419

It involves a lot of SP code refactoring so moved to 10.1.

Err codemadness.org 70 i 3420

Err codemadness.org 70 i 3422 Comment by Err codemadness.org 70 i 3423 Oleksandr Byelkin Err codemadness.org 70 i 3424 Err codemadness.org 70 i 3425 [ Err codemadness.org 70 i 3426 2018-06-27 Err codemadness.org 70 i 3427 Err codemadness.org 70 i 3428 ] Err codemadness.org 70 i 3429 Err codemadness.org 70 i 3430 Err codemadness.org 70 i 3431

Err codemadness.org 70 i 3433

We have several bugs which depends on this, so I have risen priority and put version here.

Err codemadness.org 70 i 3434

Err codemadness.org 70 i 3436 Comment by Err codemadness.org 70 i 3437 Oleksandr Byelkin Err codemadness.org 70 i 3438 Err codemadness.org 70 i 3439 [ Err codemadness.org 70 i 3440 2018-07-03 Err codemadness.org 70 i 3441 Err codemadness.org 70 i 3442 ] Err codemadness.org 70 i 3443 Err codemadness.org 70 i 3444 Err codemadness.org 70 i 3445

Err codemadness.org 70 i 3447

f832c661e637b6725e4af3f20c5a458757d1ca3b

Err codemadness.org 70 i 3448 f7bbb16a65abdbd03d50b1147c07e64249b80cfe

Err codemadness.org 70 i 3449 f3163a0b6e6b6d82f1b31ac62e835d3d1b5cd38c

Err codemadness.org 70 i 3450 7535096a79e68be1860fc7a3ddc3e2210bd616f4

Err codemadness.org 70 i 3451 010a900fcbb733b0b79e16710b979b4bce0e041d

Err codemadness.org 70 i 3452 Err codemadness.org 70 i 3453

a1b500f3b1b5f945f41b457301fe12ec4e68a131

Err codemadness.org 70 i 3454 Err codemadness.org 70 i 3455

2007d5060786552e191abe0933a22ef978d2b91a

Err codemadness.org 70 i 3456 a03792d4ea64af8cac286aa07637a75d59640d34

Err codemadness.org 70 i 3457 4478f48e46b4356c1295b1f62ac538362cc8f4d6

Err codemadness.org 70 i 3458 ffe63d62b45040194ec9c5e6dca325c26eb3300e

Err codemadness.org 70 i 3459 9d035190ea869337a42eada305161c3097664ad5

Err codemadness.org 70 i 3460 5f96951d37c5ee578d4957d59340bb4929ab6324

Err codemadness.org 70 i 3461 Err codemadness.org 70 i 3462

381346992345c6ea7bc94864b8f5b8a16265489d

Err codemadness.org 70 i 3463 5c436cf54805d91579ff838bfd52ed538ed6b9b8

Err codemadness.org 70 i 3464 Err codemadness.org 70 i 3465

-078166b94c1ca3f0f00df5f3724cf211c6e3ed58

Err codemadness.org 70 i 3466 -a4dd7f95c8a355009f317cff214568f220f0b6db

Err codemadness.org 70 i 3467

Err codemadness.org 70 i 3469 Comment by Err codemadness.org 70 i 3470 Oleksandr Byelkin Err codemadness.org 70 i 3471 Err codemadness.org 70 i 3472 [ Err codemadness.org 70 i 3473 2019-05-26 Err codemadness.org 70 i 3474 Err codemadness.org 70 i 3475 ] Err codemadness.org 70 i 3476 Err codemadness.org 70 i 3477 Err codemadness.org 70 i 3478

Err codemadness.org 70 i 3480

it looks like we need:

Err codemadness.org 70 i 3481 1) reorder sp_instr to have 1 class for all statements using expression (and so lex)

Err codemadness.org 70 i 3482 Err codemadness.org 70 i 3483

1.1) the class should contain:

Err codemadness.org 70 i 3484 Err codemadness.org 70 i 3485

copy of statement or expression to parse
MEM_ROOT and be able reparse content
list of connected sp (triggers) and tables

Err codemadness.org 70 i 3490 Err codemadness.org 70 i 3491 Err codemadness.org 70 i 3492

1.2) how to make it parsed in the instruction memory? (probably impossible)

Err codemadness.org 70 i 3493 2) lex_keeper probably should go tho above sp_instr

Err codemadness.org 70 i 3494 Err codemadness.org 70 i 3495

above needs discussion

Err codemadness.org 70 i 3496

Err codemadness.org 70 i 3498 Comment by Err codemadness.org 70 i 3499 Oleksandr Byelkin Err codemadness.org 70 i 3500 Err codemadness.org 70 i 3501 [ Err codemadness.org 70 i 3502 2019-05-27 Err codemadness.org 70 i 3503 Err codemadness.org 70 i 3504 ] Err codemadness.org 70 i 3505 Err codemadness.org 70 i 3506 Err codemadness.org 70 i 3507

Err codemadness.org 70 i 3509

Parametric cursors already has its own arena.

Err codemadness.org 70 i 3510 Err codemadness.org 70 i 3511

Probably it is possible to switch arenas for each instruction as lex switched

Err codemadness.org 70 i 3512

Err codemadness.org 70 i 3514

[MDEV-20605] With optimistic and aggressive modes of parallel replication, some replicated statements have no effect

Geoff Montee — Fri, 19 Nov 2021 18:48:27 +0000

Err codemadness.org 70 i 3590 Err codemadness.org 70 i 3591 Err codemadness.org 70 i 3600 Err codemadness.org 70 i 3601 Err codemadness.org 70 i 3602 Err codemadness.org 70 i 3603 Err codemadness.org 70 i 3604 Err codemadness.org 70 i 3605 Err codemadness.org 70 i 3606 Err codemadness.org 70 i 3607 Err codemadness.org 70 i 3608 Err codemadness.org 70 i 3609 Err codemadness.org 70 i 3610 Err codemadness.org 70 i 3611 Err codemadness.org 70 i 3612 Err codemadness.org 70 i 3614 Err codemadness.org 70 i 3615 Err codemadness.org 70 i 3616 Err codemadness.org 70 i 3617 Err codemadness.org 70 i 3618 Err codemadness.org 70 i 3619 Err codemadness.org 70 i 3621 Err codemadness.org 70 i 3622 Err codemadness.org 70 i 3623 Err codemadness.org 70 i 3624 Err codemadness.org 70 i 3625 Err codemadness.org 70 i 3626 Err codemadness.org 70 i 3628 Err codemadness.org 70 i 3629 Err codemadness.org 70 i 3630

Err codemadness.org 70 i 3592 Err codemadness.org 70 i 3593 [MDEV-20605] With optimistic and aggressive modes of parallel replication, some replicated statements have no effect Err codemadness.org 70 i 3594 Err codemadness.org 70 i 3595 Created: 2019-09-16 Updated: 2021-11-19 Err codemadness.org 70 i 3596 Err codemadness.org 70 i 3597 Err codemadness.org 70 i 3598 Err codemadness.org 70 i 3599
Status:	In Progress
Project:	MariaDB Server
Component/s:	Err codemadness.org 70 i 3613 Replication, Storage Engine - InnoDB
Affects Version/s:	Err codemadness.org 70 i 3620 5.5, 10.0, 10.1, 10.3, 10.2.27, 10.4
Fix Version/s:	Err codemadness.org 70 i 3627 10.2, 10.3, 10.4, 10.5

Err codemadness.org 70 i 3631 Err codemadness.org 70 i 3632

Err codemadness.org 70 i 3633 Err codemadness.org 70 i 3634 Err codemadness.org 70 i 3635 Err codemadness.org 70 i 3638 Err codemadness.org 70 i 3641 Err codemadness.org 70 i 3642 Err codemadness.org 70 i 3645 Err codemadness.org 70 i 3648 Err codemadness.org 70 i 3649 Err codemadness.org 70 i 3650 Err codemadness.org 70 i 3653 Err codemadness.org 70 i 3656 Err codemadness.org 70 i 3657 Err codemadness.org 70 i 3660 Err codemadness.org 70 i 3663 Err codemadness.org 70 i 3664 Err codemadness.org 70 i 3665 Err codemadness.org 70 i 3668 Err codemadness.org 70 i 3671 Err codemadness.org 70 i 3674 Err codemadness.org 70 i 3677 Err codemadness.org 70 i 3678 Err codemadness.org 70 i 3679 Err codemadness.org 70 i 3680 Err codemadness.org 70 i 3681 Err codemadness.org 70 i 3684 Err codemadness.org 70 i 3687 Err codemadness.org 70 i 3688 Err codemadness.org 70 i 3689 Err codemadness.org 70 i 3690 Err codemadness.org 70 i 3691 Err codemadness.org 70 i 3692 Err codemadness.org 70 i 3693

Err codemadness.org 70 i 3636 Type: Err codemadness.org 70 i 3637

Err codemadness.org 70 i 3639 Bug Err codemadness.org 70 i 3640

Err codemadness.org 70 i 3643 Priority: Err codemadness.org 70 i 3644

Err codemadness.org 70 i 3646 Critical Err codemadness.org 70 i 3647

Err codemadness.org 70 i 3651 Reporter: Err codemadness.org 70 i 3652

Err codemadness.org 70 i 3654 Geoff Montee Err codemadness.org 70 i 3655

Err codemadness.org 70 i 3658 Assignee: Err codemadness.org 70 i 3659

Err codemadness.org 70 i 3661 Vladislav Lesin Err codemadness.org 70 i 3662

Err codemadness.org 70 i 3666 Resolution: Err codemadness.org 70 i 3667

Err codemadness.org 70 i 3669 Unresolved Err codemadness.org 70 i 3670

Err codemadness.org 70 i 3672 Votes: Err codemadness.org 70 i 3673

Err codemadness.org 70 i 3675 5 Err codemadness.org 70 i 3676

Err codemadness.org 70 i 3682 Labels: Err codemadness.org 70 i 3683

Err codemadness.org 70 i 3685 None Err codemadness.org 70 i 3686

Err codemadness.org 70 i 3694 Err codemadness.org 70 i 3695 Err codemadness.org 70 i 3696 Err codemadness.org 70 i 3697

Err codemadness.org 70 i 3698 Err codemadness.org 70 i 3699 Err codemadness.org 70 i 3700 Err codemadness.org 70 i 3701 Err codemadness.org 70 i 3702 Err codemadness.org 70 i 3703 Err codemadness.org 70 i 3706 Err codemadness.org 70 i 3720 Err codemadness.org 70 i 3721 Err codemadness.org 70 i 3722 Err codemadness.org 70 i 3723 Err codemadness.org 70 i 3726 Err codemadness.org 70 i 4040 Err codemadness.org 70 i 4041 Err codemadness.org 70 i 4042 Err codemadness.org 70 i 4043 Err codemadness.org 70 i 4044 Err codemadness.org 70 i 4045 Err codemadness.org 70 i 4046

Err codemadness.org 70 i 3704 Attachments: Err codemadness.org 70 i 3705

Err codemadness.org 70 i 3707 Err codemadness.org 70 i 3708 MDEV-20605-deadlock.test Err codemadness.org 70 i 3709 Err codemadness.org 70 i 3710 MDEV-20605-locking.test Err codemadness.org 70 i 3711 Err codemadness.org 70 i 3712 MDEV-20605-restore-cursor-v2.test Err codemadness.org 70 i 3713 Err codemadness.org 70 i 3714 MDEV-20605-restore-cursor.test Err codemadness.org 70 i 3715 Err codemadness.org 70 i 3716 MDEV-20605.patch Err codemadness.org 70 i 3717 Err codemadness.org 70 i 3718 thiru_20605.yy Err codemadness.org 70 i 3719

Err codemadness.org 70 i 3724 Issue Links: Err codemadness.org 70 i 3725

Err codemadness.org 70 i 3727 Err codemadness.org 70 i 3728 Err codemadness.org 70 i 3729 Err codemadness.org 70 i 3732 Err codemadness.org 70 i 3733 Err codemadness.org 70 i 3734 Err codemadness.org 70 i 3737 Err codemadness.org 70 i 3741 Err codemadness.org 70 i 3744 Err codemadness.org 70 i 3747 Err codemadness.org 70 i 3748 Err codemadness.org 70 i 3749 Err codemadness.org 70 i 3752 Err codemadness.org 70 i 3756 Err codemadness.org 70 i 3759 Err codemadness.org 70 i 3762 Err codemadness.org 70 i 3763 Err codemadness.org 70 i 3764 Err codemadness.org 70 i 3767 Err codemadness.org 70 i 3768 Err codemadness.org 70 i 3769 Err codemadness.org 70 i 3772 Err codemadness.org 70 i 3776 Err codemadness.org 70 i 3779 Err codemadness.org 70 i 3782 Err codemadness.org 70 i 3783 Err codemadness.org 70 i 3784 Err codemadness.org 70 i 3787 Err codemadness.org 70 i 3791 Err codemadness.org 70 i 3794 Err codemadness.org 70 i 3797 Err codemadness.org 70 i 3798 Err codemadness.org 70 i 3799 Err codemadness.org 70 i 3802 Err codemadness.org 70 i 3806 Err codemadness.org 70 i 3809 Err codemadness.org 70 i 3812 Err codemadness.org 70 i 3813 Err codemadness.org 70 i 3814 Err codemadness.org 70 i 3817 Err codemadness.org 70 i 3821 Err codemadness.org 70 i 3824 Err codemadness.org 70 i 3827 Err codemadness.org 70 i 3828 Err codemadness.org 70 i 3829 Err codemadness.org 70 i 3832 Err codemadness.org 70 i 3836 Err codemadness.org 70 i 3839 Err codemadness.org 70 i 3842 Err codemadness.org 70 i 3843 Err codemadness.org 70 i 3844 Err codemadness.org 70 i 3847 Err codemadness.org 70 i 3851 Err codemadness.org 70 i 3854 Err codemadness.org 70 i 3857 Err codemadness.org 70 i 3858 Err codemadness.org 70 i 3859 Err codemadness.org 70 i 3862 Err codemadness.org 70 i 3866 Err codemadness.org 70 i 3869 Err codemadness.org 70 i 3872 Err codemadness.org 70 i 3873 Err codemadness.org 70 i 3874 Err codemadness.org 70 i 3877 Err codemadness.org 70 i 3881 Err codemadness.org 70 i 3884 Err codemadness.org 70 i 3887 Err codemadness.org 70 i 3888 Err codemadness.org 70 i 3889 Err codemadness.org 70 i 3892 Err codemadness.org 70 i 3896 Err codemadness.org 70 i 3899 Err codemadness.org 70 i 3902 Err codemadness.org 70 i 3903 Err codemadness.org 70 i 3904 Err codemadness.org 70 i 3907 Err codemadness.org 70 i 3911 Err codemadness.org 70 i 3914 Err codemadness.org 70 i 3917 Err codemadness.org 70 i 3918 Err codemadness.org 70 i 3919 Err codemadness.org 70 i 3922 Err codemadness.org 70 i 3926 Err codemadness.org 70 i 3929 Err codemadness.org 70 i 3932 Err codemadness.org 70 i 3933 Err codemadness.org 70 i 3934 Err codemadness.org 70 i 3937 Err codemadness.org 70 i 3941 Err codemadness.org 70 i 3944 Err codemadness.org 70 i 3947 Err codemadness.org 70 i 3948 Err codemadness.org 70 i 3949 Err codemadness.org 70 i 3952 Err codemadness.org 70 i 3956 Err codemadness.org 70 i 3959 Err codemadness.org 70 i 3962 Err codemadness.org 70 i 3963 Err codemadness.org 70 i 3964 Err codemadness.org 70 i 3967 Err codemadness.org 70 i 3971 Err codemadness.org 70 i 3974 Err codemadness.org 70 i 3977 Err codemadness.org 70 i 3978 Err codemadness.org 70 i 3979 Err codemadness.org 70 i 3982 Err codemadness.org 70 i 3986 Err codemadness.org 70 i 3989 Err codemadness.org 70 i 3992 Err codemadness.org 70 i 3993 Err codemadness.org 70 i 3994 Err codemadness.org 70 i 3997 Err codemadness.org 70 i 4001 Err codemadness.org 70 i 4004 Err codemadness.org 70 i 4007 Err codemadness.org 70 i 4008 Err codemadness.org 70 i 4009 Err codemadness.org 70 i 4012 Err codemadness.org 70 i 4016 Err codemadness.org 70 i 4019 Err codemadness.org 70 i 4022 Err codemadness.org 70 i 4023 Err codemadness.org 70 i 4024 Err codemadness.org 70 i 4027 Err codemadness.org 70 i 4031 Err codemadness.org 70 i 4034 Err codemadness.org 70 i 4037 Err codemadness.org 70 i 4038

Err codemadness.org 70 i 3730 Blocks Err codemadness.org 70 i 3731
Err codemadness.org 70 i 3735 blocks Err codemadness.org 70 i 3736	Err codemadness.org 70 i 3738 Err codemadness.org 70 i 3739 MDEV-17814 Err codemadness.org 70 i 3740	Err codemadness.org 70 i 3742 Server crashes in is_current_stmt_bin... Err codemadness.org 70 i 3743	Err codemadness.org 70 i 3745 Open Err codemadness.org 70 i 3746
Err codemadness.org 70 i 3750 is blocked by Err codemadness.org 70 i 3751	Err codemadness.org 70 i 3753 Err codemadness.org 70 i 3754 ~~MDEV-26206~~ Err codemadness.org 70 i 3755	Err codemadness.org 70 i 3757 gap lock is not set if implicit lock ... Err codemadness.org 70 i 3758	Err codemadness.org 70 i 3760 Closed Err codemadness.org 70 i 3761
Err codemadness.org 70 i 3765 Relates Err codemadness.org 70 i 3766
Err codemadness.org 70 i 3770 relates to Err codemadness.org 70 i 3771	Err codemadness.org 70 i 3773 Err codemadness.org 70 i 3774 MDEV-10962 Err codemadness.org 70 i 3775	Err codemadness.org 70 i 3777 Deadlock with 3 concurrent DELETEs by... Err codemadness.org 70 i 3778	Err codemadness.org 70 i 3780 Stalled Err codemadness.org 70 i 3781
Err codemadness.org 70 i 3785 relates to Err codemadness.org 70 i 3786	Err codemadness.org 70 i 3788 Err codemadness.org 70 i 3789 ~~MDEV-14589~~ Err codemadness.org 70 i 3790	Err codemadness.org 70 i 3792 InnoDB should not lock a delete-marke... Err codemadness.org 70 i 3793	Err codemadness.org 70 i 3795 Closed Err codemadness.org 70 i 3796
Err codemadness.org 70 i 3800 relates to Err codemadness.org 70 i 3801	Err codemadness.org 70 i 3803 Err codemadness.org 70 i 3804 ~~MDEV-18648~~ Err codemadness.org 70 i 3805	Err codemadness.org 70 i 3807 slave_parallel_mode= optimistic defau... Err codemadness.org 70 i 3808	Err codemadness.org 70 i 3810 Closed Err codemadness.org 70 i 3811
Err codemadness.org 70 i 3815 relates to Err codemadness.org 70 i 3816	Err codemadness.org 70 i 3818 Err codemadness.org 70 i 3819 ~~MDEV-19544~~ Err codemadness.org 70 i 3820	Err codemadness.org 70 i 3822 Remove innodb_locks_unsafe_for_binlog Err codemadness.org 70 i 3823	Err codemadness.org 70 i 3825 Closed Err codemadness.org 70 i 3826
Err codemadness.org 70 i 3830 relates to Err codemadness.org 70 i 3831	Err codemadness.org 70 i 3833 Err codemadness.org 70 i 3834 ~~MDEV-20628~~ Err codemadness.org 70 i 3835	Err codemadness.org 70 i 3837 If temporary error occurs with optimi... Err codemadness.org 70 i 3838	Err codemadness.org 70 i 3840 Closed Err codemadness.org 70 i 3841
Err codemadness.org 70 i 3845 relates to Err codemadness.org 70 i 3846	Err codemadness.org 70 i 3848 Err codemadness.org 70 i 3849 ~~MDEV-24224~~ Err codemadness.org 70 i 3850	Err codemadness.org 70 i 3852 Gap lock on delete in 10.5 using READ... Err codemadness.org 70 i 3853	Err codemadness.org 70 i 3855 Closed Err codemadness.org 70 i 3856
Err codemadness.org 70 i 3860 relates to Err codemadness.org 70 i 3861	Err codemadness.org 70 i 3863 Err codemadness.org 70 i 3864 MDEV-25757 Err codemadness.org 70 i 3865	Err codemadness.org 70 i 3867 Assertion `!lock->is_waiting()' in lo... Err codemadness.org 70 i 3868	Err codemadness.org 70 i 3870 Open Err codemadness.org 70 i 3871
Err codemadness.org 70 i 3875 relates to Err codemadness.org 70 i 3876	Err codemadness.org 70 i 3878 Err codemadness.org 70 i 3879 MDEV-26475 Err codemadness.org 70 i 3880	Err codemadness.org 70 i 3882 InnoDB must not lock delete-marked re... Err codemadness.org 70 i 3883	Err codemadness.org 70 i 3885 Open Err codemadness.org 70 i 3886
Err codemadness.org 70 i 3890 relates to Err codemadness.org 70 i 3891	Err codemadness.org 70 i 3893 Err codemadness.org 70 i 3894 MDEV-26670 Err codemadness.org 70 i 3895	Err codemadness.org 70 i 3897 Unable to maintain replication since ... Err codemadness.org 70 i 3898	Err codemadness.org 70 i 3900 Open Err codemadness.org 70 i 3901
Err codemadness.org 70 i 3905 relates to Err codemadness.org 70 i 3906	Err codemadness.org 70 i 3908 Err codemadness.org 70 i 3909 MDEV-16208 Err codemadness.org 70 i 3910	Err codemadness.org 70 i 3912 [Draft] Assertion `lock_get_wait(othe... Err codemadness.org 70 i 3913	Err codemadness.org 70 i 3915 Open Err codemadness.org 70 i 3916
Err codemadness.org 70 i 3920 relates to Err codemadness.org 70 i 3921	Err codemadness.org 70 i 3923 Err codemadness.org 70 i 3924 MDEV-16406 Err codemadness.org 70 i 3925	Err codemadness.org 70 i 3927 Refactor the InnoDB record locks Err codemadness.org 70 i 3928	Err codemadness.org 70 i 3930 Open Err codemadness.org 70 i 3931
Err codemadness.org 70 i 3935 relates to Err codemadness.org 70 i 3936	Err codemadness.org 70 i 3938 Err codemadness.org 70 i 3939 MDEV-17843 Err codemadness.org 70 i 3940	Err codemadness.org 70 i 3942 Assertion `page_rec_is_leaf(rec)' fai... Err codemadness.org 70 i 3943	Err codemadness.org 70 i 3945 Stalled Err codemadness.org 70 i 3946
Err codemadness.org 70 i 3950 relates to Err codemadness.org 70 i 3951	Err codemadness.org 70 i 3953 Err codemadness.org 70 i 3954 MDEV-18706 Err codemadness.org 70 i 3955	Err codemadness.org 70 i 3957 ER_LOCK_DEADLOCK on concurrent read a... Err codemadness.org 70 i 3958	Err codemadness.org 70 i 3960 In Review Err codemadness.org 70 i 3961
Err codemadness.org 70 i 3965 relates to Err codemadness.org 70 i 3966	Err codemadness.org 70 i 3968 Err codemadness.org 70 i 3969 ~~MDEV-20604~~ Err codemadness.org 70 i 3970	Err codemadness.org 70 i 3972 Duplicate key value is silently trunc... Err codemadness.org 70 i 3973	Err codemadness.org 70 i 3975 Closed Err codemadness.org 70 i 3976
Err codemadness.org 70 i 3980 relates to Err codemadness.org 70 i 3981	Err codemadness.org 70 i 3983 Err codemadness.org 70 i 3984 MDEV-22634 Err codemadness.org 70 i 3985	Err codemadness.org 70 i 3987 Assertion `dict_index_is_clust(index)... Err codemadness.org 70 i 3988	Err codemadness.org 70 i 3990 Open Err codemadness.org 70 i 3991
Err codemadness.org 70 i 3995 relates to Err codemadness.org 70 i 3996	Err codemadness.org 70 i 3998 Err codemadness.org 70 i 3999 MDEV-23197 Err codemadness.org 70 i 4000	Err codemadness.org 70 i 4002 Assertion `(index)->is_clust() \|\| !di... Err codemadness.org 70 i 4003	Err codemadness.org 70 i 4005 Open Err codemadness.org 70 i 4006
Err codemadness.org 70 i 4010 relates to Err codemadness.org 70 i 4011	Err codemadness.org 70 i 4013 Err codemadness.org 70 i 4014 ~~MDEV-24224~~ Err codemadness.org 70 i 4015	Err codemadness.org 70 i 4017 Gap lock on delete in 10.5 using READ... Err codemadness.org 70 i 4018	Err codemadness.org 70 i 4020 Closed Err codemadness.org 70 i 4021
Err codemadness.org 70 i 4025 relates to Err codemadness.org 70 i 4026	Err codemadness.org 70 i 4028 Err codemadness.org 70 i 4029 MDEV-27025 Err codemadness.org 70 i 4030	Err codemadness.org 70 i 4032 insert-intention lock conflicts with ... Err codemadness.org 70 i 4033	Err codemadness.org 70 i 4035 Open Err codemadness.org 70 i 4036

Err codemadness.org 70 i 4039

Err codemadness.org 70 i 4047 Err codemadness.org 70 i 4048

Err codemadness.org 70 i 4049 Err codemadness.org 70 i 4050 Err codemadness.org 70 i 4051 Err codemadness.org 70 i 4052 Err codemadness.org 70 i 4055 Err codemadness.org 70 i 4056 Err codemadness.org 70 i 4057

Err codemadness.org 70 i 4053 Description Err codemadness.org 70 i 4054

Err codemadness.org 70 i 4058 Err codemadness.org 70 i 4059 Err codemadness.org 70 i 4060 Err codemadness.org 70 i 4061 Err codemadness.org 70 i 4428 Err codemadness.org 70 i 4429

Err codemadness.org 70 i 4062

Some users are seeing duplicate key errors like the following when using the optimistic and aggressive modes of parallel replication:

Err codemadness.org 70 i 4063 Err codemadness.org 70 i 4064

Err codemadness.org 70 i 4065

Err codemadness.org 70 i 4066 Err codemadness.org 70 i 4067 Err codemadness.org 70 i 4068 Err codemadness.org 70 i 4069 Err codemadness.org 70 i 4072 Err codemadness.org 70 i 4073 Err codemadness.org 70 i 4074 Err codemadness.org 70 i 4077 Err codemadness.org 70 i 4078 Err codemadness.org 70 i 4079 Err codemadness.org 70 i 4082 Err codemadness.org 70 i 4083 Err codemadness.org 70 i 4084 Err codemadness.org 70 i 4087 Err codemadness.org 70 i 4088 Err codemadness.org 70 i 4089 Err codemadness.org 70 i 4092 Err codemadness.org 70 i 4093 Err codemadness.org 70 i 4094 Err codemadness.org 70 i 4097 Err codemadness.org 70 i 4098 Err codemadness.org 70 i 4099 Err codemadness.org 70 i 4102 Err codemadness.org 70 i 4103 Err codemadness.org 70 i 4104 Err codemadness.org 70 i 4107 Err codemadness.org 70 i 4108 Err codemadness.org 70 i 4109 Err codemadness.org 70 i 4112 Err codemadness.org 70 i 4113 Err codemadness.org 70 i 4114 Err codemadness.org 70 i 4117 Err codemadness.org 70 i 4118 Err codemadness.org 70 i 4119 Err codemadness.org 70 i 4122 Err codemadness.org 70 i 4123 Err codemadness.org 70 i 4124 Err codemadness.org 70 i 4127 Err codemadness.org 70 i 4128 Err codemadness.org 70 i 4129 Err codemadness.org 70 i 4132 Err codemadness.org 70 i 4133 Err codemadness.org 70 i 4134 Err codemadness.org 70 i 4137 Err codemadness.org 70 i 4138 Err codemadness.org 70 i 4139 Err codemadness.org 70 i 4142 Err codemadness.org 70 i 4143 Err codemadness.org 70 i 4144 Err codemadness.org 70 i 4147 Err codemadness.org 70 i 4148 Err codemadness.org 70 i 4149 Err codemadness.org 70 i 4152 Err codemadness.org 70 i 4153 Err codemadness.org 70 i 4154 Err codemadness.org 70 i 4157 Err codemadness.org 70 i 4158 Err codemadness.org 70 i 4159 Err codemadness.org 70 i 4162 Err codemadness.org 70 i 4163 Err codemadness.org 70 i 4164 Err codemadness.org 70 i 4167 Err codemadness.org 70 i 4168 Err codemadness.org 70 i 4169 Err codemadness.org 70 i 4172 Err codemadness.org 70 i 4173 Err codemadness.org 70 i 4174 Err codemadness.org 70 i 4177 Err codemadness.org 70 i 4178 Err codemadness.org 70 i 4179 Err codemadness.org 70 i 4182 Err codemadness.org 70 i 4183 Err codemadness.org 70 i 4184 Err codemadness.org 70 i 4187 Err codemadness.org 70 i 4188 Err codemadness.org 70 i 4189 Err codemadness.org 70 i 4192 Err codemadness.org 70 i 4193 Err codemadness.org 70 i 4194 Err codemadness.org 70 i 4197 Err codemadness.org 70 i 4198 Err codemadness.org 70 i 4199 Err codemadness.org 70 i 4202 Err codemadness.org 70 i 4203 Err codemadness.org 70 i 4204 Err codemadness.org 70 i 4207 Err codemadness.org 70 i 4208 Err codemadness.org 70 i 4209 Err codemadness.org 70 i 4212 Err codemadness.org 70 i 4213 Err codemadness.org 70 i 4214 Err codemadness.org 70 i 4217 Err codemadness.org 70 i 4218 Err codemadness.org 70 i 4219 Err codemadness.org 70 i 4222 Err codemadness.org 70 i 4223 Err codemadness.org 70 i 4224 Err codemadness.org 70 i 4227 Err codemadness.org 70 i 4228 Err codemadness.org 70 i 4229 Err codemadness.org 70 i 4232 Err codemadness.org 70 i 4233 Err codemadness.org 70 i 4234 Err codemadness.org 70 i 4237 Err codemadness.org 70 i 4238 Err codemadness.org 70 i 4239 Err codemadness.org 70 i 4242 Err codemadness.org 70 i 4243 Err codemadness.org 70 i 4244 Err codemadness.org 70 i 4247 Err codemadness.org 70 i 4248 Err codemadness.org 70 i 4249 Err codemadness.org 70 i 4252 Err codemadness.org 70 i 4253 Err codemadness.org 70 i 4254 Err codemadness.org 70 i 4257 Err codemadness.org 70 i 4258 Err codemadness.org 70 i 4259 Err codemadness.org 70 i 4262 Err codemadness.org 70 i 4263 Err codemadness.org 70 i 4264 Err codemadness.org 70 i 4267 Err codemadness.org 70 i 4268 Err codemadness.org 70 i 4269 Err codemadness.org 70 i 4272 Err codemadness.org 70 i 4273 Err codemadness.org 70 i 4274 Err codemadness.org 70 i 4277 Err codemadness.org 70 i 4278 Err codemadness.org 70 i 4279 Err codemadness.org 70 i 4282 Err codemadness.org 70 i 4283 Err codemadness.org 70 i 4284 Err codemadness.org 70 i 4287 Err codemadness.org 70 i 4288 Err codemadness.org 70 i 4289 Err codemadness.org 70 i 4292 Err codemadness.org 70 i 4293 Err codemadness.org 70 i 4294 Err codemadness.org 70 i 4297 Err codemadness.org 70 i 4298 Err codemadness.org 70 i 4299 Err codemadness.org 70 i 4302 Err codemadness.org 70 i 4303 Err codemadness.org 70 i 4304 Err codemadness.org 70 i 4307 Err codemadness.org 70 i 4308 Err codemadness.org 70 i 4309 Err codemadness.org 70 i 4312 Err codemadness.org 70 i 4313 Err codemadness.org 70 i 4314 Err codemadness.org 70 i 4317 Err codemadness.org 70 i 4318 Err codemadness.org 70 i 4319 Err codemadness.org 70 i 4322 Err codemadness.org 70 i 4323 Err codemadness.org 70 i 4324 Err codemadness.org 70 i 4327 Err codemadness.org 70 i 4328 Err codemadness.org 70 i 4329 Err codemadness.org 70 i 4333 Err codemadness.org 70 i 4334 Err codemadness.org 70 i 4335

Err codemadness.org 70 i 4070

MariaDB [(none)]> SHOW SLAVE STATUS\G

Err codemadness.org 70 i 4071

Err codemadness.org 70 i 4075

*************************** 1. row ***************************

Err codemadness.org 70 i 4076

Err codemadness.org 70 i 4080

               Slave_IO_State: Waiting for master to send event

Err codemadness.org 70 i 4081

Err codemadness.org 70 i 4085

                  Master_Host: 172.30.0.154

Err codemadness.org 70 i 4086

Err codemadness.org 70 i 4090

                  Master_User: repl

Err codemadness.org 70 i 4091

Err codemadness.org 70 i 4095

                  Master_Port: 3306

Err codemadness.org 70 i 4096

Err codemadness.org 70 i 4100

                Connect_Retry: 60

Err codemadness.org 70 i 4101

Err codemadness.org 70 i 4105

              Master_Log_File: mariadb-bin.000055

Err codemadness.org 70 i 4106

Err codemadness.org 70 i 4110

          Read_Master_Log_Pos: 593262418

Err codemadness.org 70 i 4111

Err codemadness.org 70 i 4115

               Relay_Log_File: ip-172-30-0-228-relay-bin.000002

Err codemadness.org 70 i 4116

Err codemadness.org 70 i 4120

                Relay_Log_Pos: 33725828

Err codemadness.org 70 i 4121

Err codemadness.org 70 i 4125

        Relay_Master_Log_File: mariadb-bin.000039

Err codemadness.org 70 i 4126

Err codemadness.org 70 i 4130

             Slave_IO_Running: Yes

Err codemadness.org 70 i 4131

Err codemadness.org 70 i 4135

            Slave_SQL_Running: No

Err codemadness.org 70 i 4136

Err codemadness.org 70 i 4140

              Replicate_Do_DB:

Err codemadness.org 70 i 4141

Err codemadness.org 70 i 4145

          Replicate_Ignore_DB:

Err codemadness.org 70 i 4146

Err codemadness.org 70 i 4150

           Replicate_Do_Table:

Err codemadness.org 70 i 4151

Err codemadness.org 70 i 4155

       Replicate_Ignore_Table:

Err codemadness.org 70 i 4156

Err codemadness.org 70 i 4160

      Replicate_Wild_Do_Table:

Err codemadness.org 70 i 4161

Err codemadness.org 70 i 4165

  Replicate_Wild_Ignore_Table:

Err codemadness.org 70 i 4166

Err codemadness.org 70 i 4170

                   Last_Errno: 1062

Err codemadness.org 70 i 4171

Err codemadness.org 70 i 4175

                   Last_Error: Error 'Duplicate entry '...' for key 'name'' on query. Default database: 'sample3'. Query: 'INSERT INTO ...'

Err codemadness.org 70 i 4176

Err codemadness.org 70 i 4180

                 Skip_Counter: 0

Err codemadness.org 70 i 4181

Err codemadness.org 70 i 4185

          Exec_Master_Log_Pos: 705697132

Err codemadness.org 70 i 4186

Err codemadness.org 70 i 4190

              Relay_Log_Space: 17101184558

Err codemadness.org 70 i 4191

Err codemadness.org 70 i 4195

              Until_Condition: None

Err codemadness.org 70 i 4196

Err codemadness.org 70 i 4200

               Until_Log_File:

Err codemadness.org 70 i 4201

Err codemadness.org 70 i 4205

                Until_Log_Pos: 0

Err codemadness.org 70 i 4206

Err codemadness.org 70 i 4210

           Master_SSL_Allowed: No

Err codemadness.org 70 i 4211

Err codemadness.org 70 i 4215

           Master_SSL_CA_File:

Err codemadness.org 70 i 4216

Err codemadness.org 70 i 4220

           Master_SSL_CA_Path:

Err codemadness.org 70 i 4221

Err codemadness.org 70 i 4225

              Master_SSL_Cert:

Err codemadness.org 70 i 4226

Err codemadness.org 70 i 4230

            Master_SSL_Cipher:

Err codemadness.org 70 i 4231

Err codemadness.org 70 i 4235

               Master_SSL_Key:

Err codemadness.org 70 i 4236

Err codemadness.org 70 i 4240

        Seconds_Behind_Master: NULL

Err codemadness.org 70 i 4241

Err codemadness.org 70 i 4245

Master_SSL_Verify_Server_Cert: No

Err codemadness.org 70 i 4246

Err codemadness.org 70 i 4250

                Last_IO_Errno: 0

Err codemadness.org 70 i 4251

Err codemadness.org 70 i 4255

                Last_IO_Error:

Err codemadness.org 70 i 4256

Err codemadness.org 70 i 4260

               Last_SQL_Errno: 1062

Err codemadness.org 70 i 4261

Err codemadness.org 70 i 4265

               Last_SQL_Error: Error 'Duplicate entry '...' for key 'name'' on query. Default database: 'sample3'. Query: 'INSERT INTO ...'

Err codemadness.org 70 i 4266

Err codemadness.org 70 i 4270

  Replicate_Ignore_Server_Ids:

Err codemadness.org 70 i 4271

Err codemadness.org 70 i 4275

             Master_Server_Id: 1

Err codemadness.org 70 i 4276

Err codemadness.org 70 i 4280

               Master_SSL_Crl:

Err codemadness.org 70 i 4281

Err codemadness.org 70 i 4285

           Master_SSL_Crlpath:

Err codemadness.org 70 i 4286

Err codemadness.org 70 i 4290

                   Using_Gtid: Slave_Pos

Err codemadness.org 70 i 4291

Err codemadness.org 70 i 4295

                  Gtid_IO_Pos: 0-1-42163518

Err codemadness.org 70 i 4296

Err codemadness.org 70 i 4300

      Replicate_Do_Domain_Ids:

Err codemadness.org 70 i 4301

Err codemadness.org 70 i 4305

  Replicate_Ignore_Domain_Ids:

Err codemadness.org 70 i 4306

Err codemadness.org 70 i 4310

                Parallel_Mode: aggressive

Err codemadness.org 70 i 4311

Err codemadness.org 70 i 4315

                    SQL_Delay: 0

Err codemadness.org 70 i 4316

Err codemadness.org 70 i 4320

          SQL_Remaining_Delay: NULL

Err codemadness.org 70 i 4321

Err codemadness.org 70 i 4325

      Slave_SQL_Running_State:

Err codemadness.org 70 i 4326

Err codemadness.org 70 i 4330

1 row in set (0.00 sec)	Err	codemadness.org	70
i  4331

Err codemadness.org 70 i 4332

Err codemadness.org 70 i 4336

Err codemadness.org 70 i 4337

Err codemadness.org 70 i 4338 Err codemadness.org 70 i 4339

However, when the problem is analyzed, it is clear that the duplicate key should not occur.

Err codemadness.org 70 i 4340 Err codemadness.org 70 i 4341

The configuration:

Err codemadness.org 70 i 4342 Err codemadness.org 70 i 4343

Err codemadness.org 70 i 4344

Err codemadness.org 70 i 4345 Err codemadness.org 70 i 4346 Err codemadness.org 70 i 4347 Err codemadness.org 70 i 4348 Err codemadness.org 70 i 4351 Err codemadness.org 70 i 4352 Err codemadness.org 70 i 4353 Err codemadness.org 70 i 4356 Err codemadness.org 70 i 4357 Err codemadness.org 70 i 4358 Err codemadness.org 70 i 4361 Err codemadness.org 70 i 4362 Err codemadness.org 70 i 4363 Err codemadness.org 70 i 4366 Err codemadness.org 70 i 4367 Err codemadness.org 70 i 4368 Err codemadness.org 70 i 4371 Err codemadness.org 70 i 4372 Err codemadness.org 70 i 4373 Err codemadness.org 70 i 4376 Err codemadness.org 70 i 4377 Err codemadness.org 70 i 4378 Err codemadness.org 70 i 4381 Err codemadness.org 70 i 4382 Err codemadness.org 70 i 4383 Err codemadness.org 70 i 4387 Err codemadness.org 70 i 4388 Err codemadness.org 70 i 4389

Err codemadness.org 70 i 4349

[mariadb]

Err codemadness.org 70 i 4350

Err codemadness.org 70 i 4354

server_id=2

Err codemadness.org 70 i 4355

Err codemadness.org 70 i 4359

log_bin=mariadb-bin

Err codemadness.org 70 i 4360

Err codemadness.org 70 i 4364

log_slave_updates

Err codemadness.org 70 i 4365

Err codemadness.org 70 i 4369

binlog_format=MIXED

Err codemadness.org 70 i 4370

Err codemadness.org 70 i 4374

slave_parallel_threads=16

Err codemadness.org 70 i 4375

Err codemadness.org 70 i 4379

slave_parallel_max_queued=1048576

Err codemadness.org 70 i 4380

Err codemadness.org 70 i 4384

slave_parallel_mode=aggressive	Err	codemadness.org	70
i  4385

Err codemadness.org 70 i 4386

Err codemadness.org 70 i 4390

Err codemadness.org 70 i 4391

Err codemadness.org 70 i 4392 Err codemadness.org 70 i 4393

The configuration with slave_parallel_mode=optimistic was identical.

Err codemadness.org 70 i 4394 Err codemadness.org 70 i 4395

Some observations:

Err codemadness.org 70 i 4396 Err codemadness.org 70 i 4397

When the table is queried on the slave, the row does indeed exists, so it is clear that the duplicate key error is real.

Err codemadness.org 70 i 4400 Err codemadness.org 70 i 4401 Err codemadness.org 70 i 4402

The SQL script contains an UPDATE and a DELETE before the INSERT, so the row should have been deleted, which should have prevented the duplicate key error.

Err codemadness.org 70 i 4405 Err codemadness.org 70 i 4406 Err codemadness.org 70 i 4407

The row still exists, so it seems that the DELETE statement had no effect.

Err codemadness.org 70 i 4410 Err codemadness.org 70 i 4411 Err codemadness.org 70 i 4412

The values in the existing row in the table are the old non-updated values, so it seems that the UPDATE statement also had no effect.

Err codemadness.org 70 i 4415 Err codemadness.org 70 i 4416 Err codemadness.org 70 i 4417

The slave's binary log contains both the UPDATE and DELETE statements, which should indicate that the statements were successfully executed on the slave.

Err codemadness.org 70 i 4420 Err codemadness.org 70 i 4421 Err codemadness.org 70 i 4422

I haven't yet been able to reproduce the problem when the master has binlog_format=ROW set, so row-based replication may be immune to the problem.

Err codemadness.org 70 i 4425 Err codemadness.org 70 i 4426

Err codemadness.org 70 i 4427

Err codemadness.org 70 i 4430 Err codemadness.org 70 i 4431

Err codemadness.org 70 i 4432 Err codemadness.org 70 i 4433 Err codemadness.org 70 i 4434 Err codemadness.org 70 i 4435 Err codemadness.org 70 i 4438 Err codemadness.org 70 i 4439 Err codemadness.org 70 i 4440

Err codemadness.org 70 i 4436 Comments Err codemadness.org 70 i 4437

Err codemadness.org 70 i 4441 Err codemadness.org 70 i 4442 Err codemadness.org 70 i 4443 Err codemadness.org 70 i 4454 Err codemadness.org 70 i 4465 Err codemadness.org 70 i 4476 Err codemadness.org 70 i 4677 Err codemadness.org 70 i 4688 Err codemadness.org 70 i 4780 Err codemadness.org 70 i 4791 Err codemadness.org 70 i 5044 Err codemadness.org 70 i 5055 Err codemadness.org 70 i 5058 Err codemadness.org 70 i 5069 Err codemadness.org 70 i 5271 Err codemadness.org 70 i 5282 Err codemadness.org 70 i 5484 Err codemadness.org 70 i 5495 Err codemadness.org 70 i 5509 Err codemadness.org 70 i 5520 Err codemadness.org 70 i 6302 Err codemadness.org 70 i 6313 Err codemadness.org 70 i 6330 Err codemadness.org 70 i 6341 Err codemadness.org 70 i 6548 Err codemadness.org 70 i 6559 Err codemadness.org 70 i 6848 Err codemadness.org 70 i 6859 Err codemadness.org 70 i 6862 Err codemadness.org 70 i 6873 Err codemadness.org 70 i 6884 Err codemadness.org 70 i 6895 Err codemadness.org 70 i 6910 Err codemadness.org 70 i 6921 Err codemadness.org 70 i 6924 Err codemadness.org 70 i 6935 Err codemadness.org 70 i 7023 Err codemadness.org 70 i 7034 Err codemadness.org 70 i 7045 Err codemadness.org 70 i 7056 Err codemadness.org 70 i 7059 Err codemadness.org 70 i 7070 Err codemadness.org 70 i 7081 Err codemadness.org 70 i 7092 Err codemadness.org 70 i 7097 Err codemadness.org 70 i 7108 Err codemadness.org 70 i 7111 Err codemadness.org 70 i 7122 Err codemadness.org 70 i 7125 Err codemadness.org 70 i 7136 Err codemadness.org 70 i 7141 Err codemadness.org 70 i 7152 Err codemadness.org 70 i 7345 Err codemadness.org 70 i 7356 Err codemadness.org 70 i 7367

Err codemadness.org 70 i 4444 Comment by Err codemadness.org 70 i 4445 Marko Mäkelä Err codemadness.org 70 i 4446 Err codemadness.org 70 i 4447 [ Err codemadness.org 70 i 4448 2019-10-09 Err codemadness.org 70 i 4449 Err codemadness.org 70 i 4450 ] Err codemadness.org 70 i 4451 Err codemadness.org 70 i 4452 Err codemadness.org 70 i 4453

Err codemadness.org 70 i 4455

I debugged this in Andrei Elkin’s environment today and concluded that InnoDB is to blame.

Err codemadness.org 70 i 4456 Err codemadness.org 70 i 4457

The InnoDB purge thread seems to be wrongly converting a waiting gap lock request that is attached to a purgeable record, to a granted gap lock request on the page supremum.

Err codemadness.org 70 i 4458 Err codemadness.org 70 i 4459

I have suspected that the gap-lock-widening of the purge thread could cause problems, but mostly I had the non-waiting scenarios in mind, and did not come up with a specific example. The gap locking rules are summarized in MDEV-16406.

Err codemadness.org 70 i 4460 Err codemadness.org 70 i 4461

MDEV-20605.patch introduces an assertion to the current MariaDB 10.4. It should catch this bug more easily. I hope that Matthias Leich can reproduce this bug with RQG and use the RQG simplifier to produce a simple grammar.

Err codemadness.org 70 i 4462 Err codemadness.org 70 i 4463

The test case that I debugged was running on a replication slave, and it would not fail every time. It is much more convenient to test and fix this without involving replication.

Err codemadness.org 70 i 4464

Err codemadness.org 70 i 4466 Comment by Err codemadness.org 70 i 4467 Matthias Leich Err codemadness.org 70 i 4468 Err codemadness.org 70 i 4469 [ Err codemadness.org 70 i 4470 2019-10-11 Err codemadness.org 70 i 4471 Err codemadness.org 70 i 4472 ] Err codemadness.org 70 i 4473 Err codemadness.org 70 i 4474 Err codemadness.org 70 i 4475

Err codemadness.org 70 i 4477

Err codemadness.org 70 i 4478

Err codemadness.org 70 i 4479 Err codemadness.org 70 i 4480 Err codemadness.org 70 i 4481 Err codemadness.org 70 i 4482 Err codemadness.org 70 i 4485 Err codemadness.org 70 i 4486 Err codemadness.org 70 i 4487 Err codemadness.org 70 i 4490 Err codemadness.org 70 i 4491 Err codemadness.org 70 i 4492 Err codemadness.org 70 i 4495 Err codemadness.org 70 i 4496 Err codemadness.org 70 i 4497 Err codemadness.org 70 i 4500 Err codemadness.org 70 i 4501 Err codemadness.org 70 i 4502 Err codemadness.org 70 i 4505 Err codemadness.org 70 i 4506 Err codemadness.org 70 i 4507 Err codemadness.org 70 i 4510 Err codemadness.org 70 i 4511 Err codemadness.org 70 i 4512 Err codemadness.org 70 i 4515 Err codemadness.org 70 i 4516 Err codemadness.org 70 i 4517 Err codemadness.org 70 i 4520 Err codemadness.org 70 i 4521 Err codemadness.org 70 i 4522 Err codemadness.org 70 i 4525 Err codemadness.org 70 i 4526 Err codemadness.org 70 i 4527 Err codemadness.org 70 i 4530 Err codemadness.org 70 i 4531 Err codemadness.org 70 i 4532 Err codemadness.org 70 i 4535 Err codemadness.org 70 i 4536 Err codemadness.org 70 i 4537 Err codemadness.org 70 i 4540 Err codemadness.org 70 i 4541 Err codemadness.org 70 i 4542 Err codemadness.org 70 i 4545 Err codemadness.org 70 i 4546 Err codemadness.org 70 i 4547 Err codemadness.org 70 i 4550 Err codemadness.org 70 i 4551 Err codemadness.org 70 i 4552 Err codemadness.org 70 i 4555 Err codemadness.org 70 i 4556 Err codemadness.org 70 i 4557 Err codemadness.org 70 i 4560 Err codemadness.org 70 i 4561 Err codemadness.org 70 i 4562 Err codemadness.org 70 i 4565 Err codemadness.org 70 i 4566 Err codemadness.org 70 i 4567 Err codemadness.org 70 i 4570 Err codemadness.org 70 i 4571 Err codemadness.org 70 i 4572 Err codemadness.org 70 i 4575 Err codemadness.org 70 i 4576 Err codemadness.org 70 i 4577 Err codemadness.org 70 i 4580 Err codemadness.org 70 i 4581 Err codemadness.org 70 i 4582 Err codemadness.org 70 i 4585 Err codemadness.org 70 i 4586 Err codemadness.org 70 i 4587 Err codemadness.org 70 i 4590 Err codemadness.org 70 i 4591 Err codemadness.org 70 i 4592 Err codemadness.org 70 i 4595 Err codemadness.org 70 i 4596 Err codemadness.org 70 i 4597 Err codemadness.org 70 i 4600 Err codemadness.org 70 i 4601 Err codemadness.org 70 i 4602 Err codemadness.org 70 i 4605 Err codemadness.org 70 i 4606 Err codemadness.org 70 i 4607 Err codemadness.org 70 i 4610 Err codemadness.org 70 i 4611 Err codemadness.org 70 i 4612 Err codemadness.org 70 i 4615 Err codemadness.org 70 i 4616 Err codemadness.org 70 i 4617 Err codemadness.org 70 i 4620 Err codemadness.org 70 i 4621 Err codemadness.org 70 i 4622 Err codemadness.org 70 i 4625 Err codemadness.org 70 i 4626 Err codemadness.org 70 i 4627 Err codemadness.org 70 i 4630 Err codemadness.org 70 i 4631 Err codemadness.org 70 i 4632 Err codemadness.org 70 i 4635 Err codemadness.org 70 i 4636 Err codemadness.org 70 i 4637 Err codemadness.org 70 i 4640 Err codemadness.org 70 i 4641 Err codemadness.org 70 i 4642 Err codemadness.org 70 i 4645 Err codemadness.org 70 i 4646 Err codemadness.org 70 i 4647 Err codemadness.org 70 i 4650 Err codemadness.org 70 i 4651 Err codemadness.org 70 i 4652 Err codemadness.org 70 i 4655 Err codemadness.org 70 i 4656 Err codemadness.org 70 i 4657 Err codemadness.org 70 i 4660 Err codemadness.org 70 i 4661 Err codemadness.org 70 i 4662 Err codemadness.org 70 i 4665 Err codemadness.org 70 i 4666 Err codemadness.org 70 i 4667 Err codemadness.org 70 i 4671 Err codemadness.org 70 i 4672 Err codemadness.org 70 i 4673

Err codemadness.org 70 i 4483

10.4 b05be3ef8c8668ddbcbe8e1c08dcd4fcc88eb4cf 2019-10-11 + the MDEV-20605.patch mentioned above compiled with debug.

Err codemadness.org 70 i 4484

Err codemadness.org 70 i 4488

I get frequent the following assert

Err codemadness.org 70 i 4489

Err codemadness.org 70 i 4493

Version: '10.4.9-MariaDB-debug-log'  socket: ...

Err codemadness.org 70 i 4494

Err codemadness.org 70 i 4498

2019-10-11 17:01:20 0x7f8100ff9700  InnoDB: Assertion failure in file /home/mleich/work/10.4/storage/innobase/lock/lock0lock.cc line 2447

Err codemadness.org 70 i 4499

Err codemadness.org 70 i 4503

InnoDB: Failing assertion: !interesting || !(lock->type_mode & LOCK_WAIT)

Err codemadness.org 70 i 4504

Err codemadness.org 70 i 4508

...

Err codemadness.org 70 i 4509

Err codemadness.org 70 i 4513

Query (0x0):

Err codemadness.org 70 i 4514

Err codemadness.org 70 i 4518

Connection ID (thread ID): 3

Err codemadness.org 70 i 4519

Err codemadness.org 70 i 4523

Status: NOT_KILLED

Err codemadness.org 70 i 4524

Err codemadness.org 70 i 4528

...

Err codemadness.org 70 i 4529

Err codemadness.org 70 i 4533

#3  <signal handler called>

Err codemadness.org 70 i 4534

Err codemadness.org 70 i 4538

#4  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:58

Err codemadness.org 70 i 4539

Err codemadness.org 70 i 4543

#5  0x00007f815f52437a in __GI_abort () at abort.c:89

Err codemadness.org 70 i 4544

Err codemadness.org 70 i 4548

#6  0x00005628d0b2022a in ut_dbg_assertion_failed (expr=0x5628d12ae780 "!interesting || !(lock->type_mode & LOCK_WAIT)", file=0x5628d12ad928 "storage/innobase/lock/lock0lock.cc", line=2447) at storage/innobase/ut/ut0dbg.cc:60

Err codemadness.org 70 i 4549

Err codemadness.org 70 i 4553

#7  0x00005628d093fd94 in lock_rec_inherit_to_gap (heir_block=0x7f813c02e500, block=0x7f813c02e500, heir_heap_no=1, heap_no=2, interesting=true) at storage/innobase/lock/lock0lock.cc:2447

Err codemadness.org 70 i 4554

Err codemadness.org 70 i 4558

#8  0x00005628d0942b67 in lock_update_delete (block=0x7f813c02e500, rec=0x7f813c97807f "\200", interesting=true) at storage/innobase/lock/lock0lock.cc:3393

Err codemadness.org 70 i 4559

Err codemadness.org 70 i 4563

#9  0x00005628d0b69241 in btr_cur_optimistic_delete (cursor=0x5628d46e5480, flags=0, mtr=0x7f8100ff82d0, interesting=true) at storage/innobase/btr/btr0cur.cc:5721

Err codemadness.org 70 i 4564

Err codemadness.org 70 i 4568

#10 0x00005628d0a66ceb in row_purge_remove_clust_if_poss_low (node=0x5628d46e53d8, mode=2) at storage/innobase/row/row0purge.cc:143

Err codemadness.org 70 i 4569

Err codemadness.org 70 i 4573

#11 0x00005628d0a66f5b in row_purge_remove_clust_if_poss (node=0x5628d46e53d8) at storage/innobase/row/row0purge.cc:194

Err codemadness.org 70 i 4574

Err codemadness.org 70 i 4578

#12 0x00005628d0a68aaf in row_purge_del_mark (node=0x5628d46e53d8) at storage/innobase/row/row0purge.cc:784

Err codemadness.org 70 i 4579

Err codemadness.org 70 i 4583

#13 0x00005628d0a6a67c in row_purge_record_func (node=0x5628d46e53d8, undo_rec=0x5628d46e5988 "", thr=0x5628d46e5208, updated_extern=false) at storage/innobase/row/row0purge.cc:1195

Err codemadness.org 70 i 4584

Err codemadness.org 70 i 4588

#14 0x00005628d0a6a989 in row_purge (node=0x5628d46e53d8, undo_rec=0x5628d46e5988 "", thr=0x5628d46e5208) at storage/innobase/row/row0purge.cc:1262

Err codemadness.org 70 i 4589

Err codemadness.org 70 i 4593

#15 0x00005628d0a6abe6 in row_purge_step (thr=0x5628d46e5208) at storage/innobase/row/row0purge.cc:1321

Err codemadness.org 70 i 4594

Err codemadness.org 70 i 4598

#16 0x00005628d09d55c9 in que_thr_step (thr=0x5628d46e5208) at storage/innobase/que/que0que.cc:1037

Err codemadness.org 70 i 4599

Err codemadness.org 70 i 4603

#17 0x00005628d09d5860 in que_run_threads_low (thr=0x5628d46e5208) at storage/innobase/que/que0que.cc:1099

Err codemadness.org 70 i 4604

Err codemadness.org 70 i 4608

#18 0x00005628d09d5ab0 in que_run_threads (thr=0x5628d46e5208) at storage/innobase/que/que0que.cc:1139

Err codemadness.org 70 i 4609

Err codemadness.org 70 i 4613

#19 0x00005628d0ab5647 in srv_task_execute () at storage/innobase/srv/srv0srv.cc:2457

Err codemadness.org 70 i 4614

Err codemadness.org 70 i 4618

#20 0x00005628d0ab5870 in srv_worker_thread (arg=0x0) at storage/innobase/srv/srv0srv.cc:2505

Err codemadness.org 70 i 4619

Err codemadness.org 70 i 4623

#21 0x00007f81603676da in start_thread (arg=0x7f8100ff9700) at pthread_create.c:456

Err codemadness.org 70 i 4624

Err codemadness.org 70 i 4628

Err codemadness.org 70 i 4629

Err codemadness.org 70 i 4633

The RQG testing scenario:

Err codemadness.org 70 i 4634

Err codemadness.org 70 i 4638

Session 1 at begin:

Err codemadness.org 70 i 4639

Err codemadness.org 70 i 4643

    CREATE TABLE t13 ( pk INTEGER AUTO_INCREMENT, col1 VARCHAR(255), PRIMARY KEY (pk)) ENGINE=innodb ;

Err codemadness.org 70 i 4644

Err codemadness.org 70 i 4648

    INSERT INTO t13 VALUES  (NULL, 'yourself') ;

Err codemadness.org 70 i 4649

Err codemadness.org 70 i 4653

After that run the sessions 1 till 10 again and again only

Err codemadness.org 70 i 4654

Err codemadness.org 70 i 4658

   DELETE FROM t13 WHERE col1 <> ( 'otto' ) ORDER BY `pk` LIMIT 1 ;

Err codemadness.org 70 i 4659

Err codemadness.org 70 i 4663

till the assert above is hit.

Err codemadness.org 70 i 4664

Err codemadness.org 70 i 4668

	Err	codemadness.org	70
i  4669

Err codemadness.org 70 i 4670

Err codemadness.org 70 i 4674

Err codemadness.org 70 i 4675

Err codemadness.org 70 i 4676

Err codemadness.org 70 i 4678 Comment by Err codemadness.org 70 i 4679 Marko Mäkelä Err codemadness.org 70 i 4680 Err codemadness.org 70 i 4681 [ Err codemadness.org 70 i 4682 2019-10-12 Err codemadness.org 70 i 4683 Err codemadness.org 70 i 4684 ] Err codemadness.org 70 i 4685 Err codemadness.org 70 i 4686 Err codemadness.org 70 i 4687

Err codemadness.org 70 i 4689

Let me give some background for understanding the problem and a possible solution.

Err codemadness.org 70 i 4690 Err codemadness.org 70 i 4691

InnoDB implements multi-versioning by guaranteeing to keep the full history of committed transactions until there is no old read view that would see the database state as it was before those transactions were committed. In particular, records are not deleted immediately; they are merely marked for deletion. Only the ROLLBACK of an INSERT can immediately delete a record.

Err codemadness.org 70 i 4692 Err codemadness.org 70 i 4693

So, there may be many delete-marked records in indexes. Some of them could be purgeable. There may be a significant purge lag, for example, in the instant when a very old read view was destroyed when its transaction was committed, millions of records could become purgeable.

Err codemadness.org 70 i 4694 Err codemadness.org 70 i 4695

InnoDB implements next-key locking by gap locks that are anchored to the record that is succeeding the preceding record of the gap. (There are two mutually exclusive types of gap locks, in MDEV-16406 called read-gap and write-gap locks. Traditionally, read-gap locks are called ‘gap locks’ and write-gap locks are ‘insert intention locks.)

Err codemadness.org 70 i 4696 Err codemadness.org 70 i 4697

I think that at the root of the problem is the fact that the anchor records of the gap locks may be committed (and possibly purgeable) delete-marked records. This problem has been described earlier in ~~MDEV-14589~~ (InnoDB should not lock a delete-marked record).

Err codemadness.org 70 i 4698 Err codemadness.org 70 i 4699

The problem

Err codemadness.org 70 i 4700

As proven with MDEV-20605.patch, it seems that when a waiting gap lock request is attached to a purgeable record, and when another transaction holds a conflicting gap lock on the successor of the purgeable record, purge would wrongly convert the waiting gap lock to a granted lock on that successor record, even though another transaction is holding a conflicting type of a gap lock on that record.

Err codemadness.org 70 i 4701 Err codemadness.org 70 i 4702

Possible workaround: Suspend purge

Err codemadness.org 70 i 4703

A simple ‘fix’ could be to stop the purge when it detects this situation. There are numerous problems with this, such as:

Err codemadness.org 70 i 4704

How would purge be signaled that it should retry?
What if other transactions keep arriving, attaching gap locks on the to-be-purged record? Shouldn’t these transactions be blocked, to avoid starving the purge?
How to ensure that purge will proceed nevertheless on shutdown?

Err codemadness.org 70 i 4709 Err codemadness.org 70 i 4710 Err codemadness.org 70 i 4711

Possible fix: Acquire gap locks on all successive delete-marked committed records

Err codemadness.org 70 i 4712

There seems to be another way of guaranteeing that purge will be invisible to transactions. Let us assume that the index contents is as follows, and we want a gap-lock that covers the non-existing key (2):

Err codemadness.org 70 i 4713 Err codemadness.org 70 i 4714

(0),delete-marked(5),delete-marked(9),13

Err codemadness.org 70 i 4715 Err codemadness.org 70 i 4716

Currently, we would only acquire a gap lock on the delete-marked key (5), and this gap lock would cover the keys in the open range (0,5). If purge removes the key (5), it would ‘widen’ the gap by attaching the gap lock on the delete-marked key (9). So, the gap would cover (0,9).

Err codemadness.org 70 i 4717 Err codemadness.org 70 i 4718

What if we changed the gap lock acquisition algorithm? Instead of acquiring a gap lock only on the successor record, let us keep acquiring record+gap locks on its successors until we reach the end of the index, or a record that is not delete-marked. With this approach, we would lock the semi-open ranges (0,5],(5,9] before locking the final open range (9,13). This combined range (0,5],(5,9],(9,13) is equivalent to (0,13). Thus, we are immune to the scenario where purge would remove the delete-marked anchor records in between!

Err codemadness.org 70 i 4719 Err codemadness.org 70 i 4720

Note: I am proposing that we acquire also record locks on the delete-marked records. I think that we are already doing that, except for READ COMMITTED isolation level the fix of ~~MDEV-14589~~ is skipping that.

Err codemadness.org 70 i 4721 Err codemadness.org 70 i 4722

With this extended gap locking, whenever we remove a record, we can simply remove the attached gap lock without having to create a gap lock for the successor record. If there are waiting gap lock requests on the record that we are removing, we would have to wake up the waiting transactions.

Err codemadness.org 70 i 4723 Err codemadness.org 70 i 4724

Note on determinism

Err codemadness.org 70 i 4725

I believe that the extended gap locking could make InnoDB gap locks fully deterministic and thus possibly help make some cases of replication deterministic. Currently, without my proposed change, depending on how much purge is lagging behind, gap locks could be ‘narrow’ or ‘wide’. Let us consider my above example again:

Err codemadness.org 70 i 4726

Err codemadness.org 70 i 4727

Err codemadness.org 70 i 4728 Err codemadness.org 70 i 4729 Err codemadness.org 70 i 4730 Err codemadness.org 70 i 4731 Err codemadness.org 70 i 4734 Err codemadness.org 70 i 4735 Err codemadness.org 70 i 4736 Err codemadness.org 70 i 4739 Err codemadness.org 70 i 4740 Err codemadness.org 70 i 4741 Err codemadness.org 70 i 4744 Err codemadness.org 70 i 4745 Err codemadness.org 70 i 4746 Err codemadness.org 70 i 4749 Err codemadness.org 70 i 4750 Err codemadness.org 70 i 4751 Err codemadness.org 70 i 4754 Err codemadness.org 70 i 4755 Err codemadness.org 70 i 4756 Err codemadness.org 70 i 4759 Err codemadness.org 70 i 4760 Err codemadness.org 70 i 4761 Err codemadness.org 70 i 4764 Err codemadness.org 70 i 4765 Err codemadness.org 70 i 4766 Err codemadness.org 70 i 4770 Err codemadness.org 70 i 4771 Err codemadness.org 70 i 4772

Err codemadness.org 70 i 4732

create table t(k int primary key) engine=innodb;

Err codemadness.org 70 i 4733

Err codemadness.org 70 i 4737

insert into t values (0),(5),(9),(13);

Err codemadness.org 70 i 4738

Err codemadness.org 70 i 4742

delete from t where k=5 or k=9;

Err codemadness.org 70 i 4743

Err codemadness.org 70 i 4747

commit;

Err codemadness.org 70 i 4748

Err codemadness.org 70 i 4752

connection a;

Err codemadness.org 70 i 4753

Err codemadness.org 70 i 4757

begin; select * from t where k=2 lock in share mode;

Err codemadness.org 70 i 4758

Err codemadness.org 70 i 4762

connection b;

Err codemadness.org 70 i 4763

Err codemadness.org 70 i 4767

begin; insert into t set k=10;	Err	codemadness.org	70
i  4768

Err codemadness.org 70 i 4769

Err codemadness.org 70 i 4773

Err codemadness.org 70 i 4774

Err codemadness.org 70 i 4775 Err codemadness.org 70 i 4776

With my proposed fix, both the SELECT and INSERT would lock the whole range of 0<k<13, and they would conflict with each other, leading into a lock wait timeout for one of the transactions if neither transaction is committed.

Err codemadness.org 70 i 4777 Err codemadness.org 70 i 4778

Currently, depending on when purge removes the delete-marked committed keys k=5, k=9, both transactions could actually succeed, and never observe a lock wait timeout, no matter how long they wait. And, I believe that both would eventually be holding conflicting locks (read-gap a.k.a. ‘gap’ lock and write-gap a.k.a. ‘insert intention’ lock) on the full range 0<k<13. This feels very wrong!

Err codemadness.org 70 i 4779

Err codemadness.org 70 i 4781 Comment by Err codemadness.org 70 i 4782 Thirunarayanan Balathandayuthapani Err codemadness.org 70 i 4783 Err codemadness.org 70 i 4784 [ Err codemadness.org 70 i 4785 2019-10-16 Err codemadness.org 70 i 4786 Err codemadness.org 70 i 4787 ] Err codemadness.org 70 i 4788 Err codemadness.org 70 i 4789 Err codemadness.org 70 i 4790

Err codemadness.org 70 i 4792

The following test case can get crash for instrumented patch which basically checks whether purge grants the waiting lock.

Err codemadness.org 70 i 4793 Err codemadness.org 70 i 4794

Err codemadness.org 70 i 4795

Err codemadness.org 70 i 4796 Err codemadness.org 70 i 4797 Err codemadness.org 70 i 4798 Err codemadness.org 70 i 4799 Err codemadness.org 70 i 4802 Err codemadness.org 70 i 4803 Err codemadness.org 70 i 4804 Err codemadness.org 70 i 4807 Err codemadness.org 70 i 4808 Err codemadness.org 70 i 4809 Err codemadness.org 70 i 4812 Err codemadness.org 70 i 4813 Err codemadness.org 70 i 4814 Err codemadness.org 70 i 4817 Err codemadness.org 70 i 4818 Err codemadness.org 70 i 4819 Err codemadness.org 70 i 4822 Err codemadness.org 70 i 4823 Err codemadness.org 70 i 4824 Err codemadness.org 70 i 4827 Err codemadness.org 70 i 4828 Err codemadness.org 70 i 4829 Err codemadness.org 70 i 4832 Err codemadness.org 70 i 4833 Err codemadness.org 70 i 4834 Err codemadness.org 70 i 4837 Err codemadness.org 70 i 4838 Err codemadness.org 70 i 4839 Err codemadness.org 70 i 4842 Err codemadness.org 70 i 4843 Err codemadness.org 70 i 4844 Err codemadness.org 70 i 4847 Err codemadness.org 70 i 4848 Err codemadness.org 70 i 4849 Err codemadness.org 70 i 4852 Err codemadness.org 70 i 4853 Err codemadness.org 70 i 4854 Err codemadness.org 70 i 4857 Err codemadness.org 70 i 4858 Err codemadness.org 70 i 4859 Err codemadness.org 70 i 4862 Err codemadness.org 70 i 4863 Err codemadness.org 70 i 4864 Err codemadness.org 70 i 4867 Err codemadness.org 70 i 4868 Err codemadness.org 70 i 4869 Err codemadness.org 70 i 4872 Err codemadness.org 70 i 4873 Err codemadness.org 70 i 4874 Err codemadness.org 70 i 4877 Err codemadness.org 70 i 4878 Err codemadness.org 70 i 4879 Err codemadness.org 70 i 4882 Err codemadness.org 70 i 4883 Err codemadness.org 70 i 4884 Err codemadness.org 70 i 4887 Err codemadness.org 70 i 4888 Err codemadness.org 70 i 4889 Err codemadness.org 70 i 4892 Err codemadness.org 70 i 4893 Err codemadness.org 70 i 4894 Err codemadness.org 70 i 4897 Err codemadness.org 70 i 4898 Err codemadness.org 70 i 4899 Err codemadness.org 70 i 4902 Err codemadness.org 70 i 4903 Err codemadness.org 70 i 4904 Err codemadness.org 70 i 4907 Err codemadness.org 70 i 4908 Err codemadness.org 70 i 4909 Err codemadness.org 70 i 4912 Err codemadness.org 70 i 4913 Err codemadness.org 70 i 4914 Err codemadness.org 70 i 4917 Err codemadness.org 70 i 4918 Err codemadness.org 70 i 4919 Err codemadness.org 70 i 4922 Err codemadness.org 70 i 4923 Err codemadness.org 70 i 4924 Err codemadness.org 70 i 4927 Err codemadness.org 70 i 4928 Err codemadness.org 70 i 4929 Err codemadness.org 70 i 4932 Err codemadness.org 70 i 4933 Err codemadness.org 70 i 4934 Err codemadness.org 70 i 4937 Err codemadness.org 70 i 4938 Err codemadness.org 70 i 4939 Err codemadness.org 70 i 4942 Err codemadness.org 70 i 4943 Err codemadness.org 70 i 4944 Err codemadness.org 70 i 4947 Err codemadness.org 70 i 4948 Err codemadness.org 70 i 4949 Err codemadness.org 70 i 4953 Err codemadness.org 70 i 4954 Err codemadness.org 70 i 4955

Err codemadness.org 70 i 4800

--source include/have_innodb.inc

Err codemadness.org 70 i 4801

Err codemadness.org 70 i 4805

# Stops the purge

Err codemadness.org 70 i 4806

Err codemadness.org 70 i 4810

connect(con_purge,localhost,root,,);

Err codemadness.org 70 i 4811

Err codemadness.org 70 i 4815

begin;

Err codemadness.org 70 i 4816

Err codemadness.org 70 i 4820

start transaction with consistent snapshot;

Err codemadness.org 70 i 4821

Err codemadness.org 70 i 4825

Err codemadness.org 70 i 4826

Err codemadness.org 70 i 4830

connection default;

Err codemadness.org 70 i 4831

Err codemadness.org 70 i 4835

create table t1 (f1 int not null, primary key(f1))engine=innodb;

Err codemadness.org 70 i 4836

Err codemadness.org 70 i 4840

insert into t1 values(1);

Err codemadness.org 70 i 4841

Err codemadness.org 70 i 4845

delete from t1;

Err codemadness.org 70 i 4846

Err codemadness.org 70 i 4850

Err codemadness.org 70 i 4851

Err codemadness.org 70 i 4855

connect(con1,localhost,root,,);

Err codemadness.org 70 i 4856

Err codemadness.org 70 i 4860

begin;

Err codemadness.org 70 i 4861

Err codemadness.org 70 i 4865

select * from t1 where f1 > 2 for update;

Err codemadness.org 70 i 4866

Err codemadness.org 70 i 4870

f1

Err codemadness.org 70 i 4871

Err codemadness.org 70 i 4875

Err codemadness.org 70 i 4876

Err codemadness.org 70 i 4880

# Connection con2 will wait for LOCK_ORDINARY in delete marked record.

Err codemadness.org 70 i 4881

Err codemadness.org 70 i 4885

connect(con2,localhost,root,,);

Err codemadness.org 70 i 4886

Err codemadness.org 70 i 4890

begin;

Err codemadness.org 70 i 4891

Err codemadness.org 70 i 4895

set debug_sync="lock_wait_suspend_thread_enter SIGNAL purge_start";

Err codemadness.org 70 i 4896

Err codemadness.org 70 i 4900

send select * from t1 where f1 > 2 for update;

Err codemadness.org 70 i 4901

Err codemadness.org 70 i 4905

Err codemadness.org 70 i 4906

Err codemadness.org 70 i 4910

connection con_purge;

Err codemadness.org 70 i 4911

Err codemadness.org 70 i 4915

set debug_sync="now WAIT_FOR purge_start";

Err codemadness.org 70 i 4916

Err codemadness.org 70 i 4920

# Allow purge to start and crash at the instrumented patch. (grant lock_wait for con2)

Err codemadness.org 70 i 4921

Err codemadness.org 70 i 4925

commit;

Err codemadness.org 70 i 4926

Err codemadness.org 70 i 4930

Err codemadness.org 70 i 4931

Err codemadness.org 70 i 4935

connection con2;

Err codemadness.org 70 i 4936

Err codemadness.org 70 i 4940

reap;

Err codemadness.org 70 i 4941

Err codemadness.org 70 i 4945

f1

Err codemadness.org 70 i 4946

Err codemadness.org 70 i 4950

	Err	codemadness.org	70
i  4951

Err codemadness.org 70 i 4952

Err codemadness.org 70 i 4956

Err codemadness.org 70 i 4957

Err codemadness.org 70 i 4958 Err codemadness.org 70 i 4959

I wrote the comments in test case for explanation. I am not convinced that instrumental patch repeats the correct issue.

Err codemadness.org 70 i 4960 The above test case is same as the following one which doesn't have to deal with purge:

Err codemadness.org 70 i 4961 Err codemadness.org 70 i 4962

Err codemadness.org 70 i 4963

Err codemadness.org 70 i 4964 Err codemadness.org 70 i 4965 Err codemadness.org 70 i 4966 Err codemadness.org 70 i 4967 Err codemadness.org 70 i 4970 Err codemadness.org 70 i 4971 Err codemadness.org 70 i 4972 Err codemadness.org 70 i 4975 Err codemadness.org 70 i 4976 Err codemadness.org 70 i 4977 Err codemadness.org 70 i 4980 Err codemadness.org 70 i 4981 Err codemadness.org 70 i 4982 Err codemadness.org 70 i 4985 Err codemadness.org 70 i 4986 Err codemadness.org 70 i 4987 Err codemadness.org 70 i 4990 Err codemadness.org 70 i 4991 Err codemadness.org 70 i 4992 Err codemadness.org 70 i 4995 Err codemadness.org 70 i 4996 Err codemadness.org 70 i 4997 Err codemadness.org 70 i 5000 Err codemadness.org 70 i 5001 Err codemadness.org 70 i 5002 Err codemadness.org 70 i 5005 Err codemadness.org 70 i 5006 Err codemadness.org 70 i 5007 Err codemadness.org 70 i 5010 Err codemadness.org 70 i 5011 Err codemadness.org 70 i 5012 Err codemadness.org 70 i 5015 Err codemadness.org 70 i 5016 Err codemadness.org 70 i 5017 Err codemadness.org 70 i 5020 Err codemadness.org 70 i 5021 Err codemadness.org 70 i 5022 Err codemadness.org 70 i 5025 Err codemadness.org 70 i 5026 Err codemadness.org 70 i 5027 Err codemadness.org 70 i 5030 Err codemadness.org 70 i 5031 Err codemadness.org 70 i 5032 Err codemadness.org 70 i 5036 Err codemadness.org 70 i 5037 Err codemadness.org 70 i 5038

Err codemadness.org 70 i 4968

Err codemadness.org 70 i 4969

Err codemadness.org 70 i 4973

--source include/have_innodb.inc

Err codemadness.org 70 i 4974

Err codemadness.org 70 i 4978

create table t1 (f1 int not null, primary key(f1))engine=innodb;

Err codemadness.org 70 i 4979

Err codemadness.org 70 i 4983

Err codemadness.org 70 i 4984

Err codemadness.org 70 i 4988

connect(con1,localhost,root,,);

Err codemadness.org 70 i 4989

Err codemadness.org 70 i 4993

begin;

Err codemadness.org 70 i 4994

Err codemadness.org 70 i 4998

select * from t1 where f1 > 2 for update;

Err codemadness.org 70 i 4999

Err codemadness.org 70 i 5003

f1

Err codemadness.org 70 i 5004

Err codemadness.org 70 i 5008

Err codemadness.org 70 i 5009

Err codemadness.org 70 i 5013

connect(con2,localhost,root,,);

Err codemadness.org 70 i 5014

Err codemadness.org 70 i 5018

begin;

Err codemadness.org 70 i 5019

Err codemadness.org 70 i 5023

select * from t1 where f1 > 2 for update;

Err codemadness.org 70 i 5024

Err codemadness.org 70 i 5028

f1

Err codemadness.org 70 i 5029

Err codemadness.org 70 i 5033

	Err	codemadness.org	70
i  5034

Err codemadness.org 70 i 5035

Err codemadness.org 70 i 5039

Err codemadness.org 70 i 5040

Err codemadness.org 70 i 5041 Err codemadness.org 70 i 5042

I may need to get the perspective from Marko Mäkelä as well.

Err codemadness.org 70 i 5043

Err codemadness.org 70 i 5045 Comment by Err codemadness.org 70 i 5046 Marko Mäkelä Err codemadness.org 70 i 5047 Err codemadness.org 70 i 5048 [ Err codemadness.org 70 i 5049 2019-10-17 Err codemadness.org 70 i 5050 Err codemadness.org 70 i 5051 ] Err codemadness.org 70 i 5052 Err codemadness.org 70 i 5053 Err codemadness.org 70 i 5054

Err codemadness.org 70 i 5056

My debug instrumentation may be too eager. I still think that my idea of acquiring multiple gap locks (and simply discarding them on purge) is correct. I must to come up with an executable test case that demonstrates my line of thought.

Err codemadness.org 70 i 5057

Err codemadness.org 70 i 5059 Comment by Err codemadness.org 70 i 5060 Marko Mäkelä Err codemadness.org 70 i 5061 Err codemadness.org 70 i 5062 [ Err codemadness.org 70 i 5063 2019-10-18 Err codemadness.org 70 i 5064 Err codemadness.org 70 i 5065 ] Err codemadness.org 70 i 5066 Err codemadness.org 70 i 5067 Err codemadness.org 70 i 5068

Err codemadness.org 70 i 5070

I debugged Thirunarayanan Balathandayuthapani’s test cases (with some fixes) on 10.3, with MDEV-20605.patch ported to 10.3 (one trivial conflict).

Err codemadness.org 70 i 5071

Err codemadness.org 70 i 5072

Err codemadness.org 70 i 5073 Err codemadness.org 70 i 5074 Err codemadness.org 70 i 5075 Err codemadness.org 70 i 5076 Err codemadness.org 70 i 5079 Err codemadness.org 70 i 5080 Err codemadness.org 70 i 5081 Err codemadness.org 70 i 5084 Err codemadness.org 70 i 5085 Err codemadness.org 70 i 5086 Err codemadness.org 70 i 5089 Err codemadness.org 70 i 5090 Err codemadness.org 70 i 5091 Err codemadness.org 70 i 5094 Err codemadness.org 70 i 5095 Err codemadness.org 70 i 5096 Err codemadness.org 70 i 5099 Err codemadness.org 70 i 5100 Err codemadness.org 70 i 5101 Err codemadness.org 70 i 5104 Err codemadness.org 70 i 5105 Err codemadness.org 70 i 5106 Err codemadness.org 70 i 5109 Err codemadness.org 70 i 5110 Err codemadness.org 70 i 5111 Err codemadness.org 70 i 5114 Err codemadness.org 70 i 5115 Err codemadness.org 70 i 5116 Err codemadness.org 70 i 5119 Err codemadness.org 70 i 5120 Err codemadness.org 70 i 5121 Err codemadness.org 70 i 5124 Err codemadness.org 70 i 5125 Err codemadness.org 70 i 5126 Err codemadness.org 70 i 5129 Err codemadness.org 70 i 5130 Err codemadness.org 70 i 5131 Err codemadness.org 70 i 5134 Err codemadness.org 70 i 5135 Err codemadness.org 70 i 5136 Err codemadness.org 70 i 5139 Err codemadness.org 70 i 5140 Err codemadness.org 70 i 5141 Err codemadness.org 70 i 5144 Err codemadness.org 70 i 5145 Err codemadness.org 70 i 5146 Err codemadness.org 70 i 5149 Err codemadness.org 70 i 5150 Err codemadness.org 70 i 5151 Err codemadness.org 70 i 5154 Err codemadness.org 70 i 5155 Err codemadness.org 70 i 5156 Err codemadness.org 70 i 5159 Err codemadness.org 70 i 5160 Err codemadness.org 70 i 5161 Err codemadness.org 70 i 5164 Err codemadness.org 70 i 5165 Err codemadness.org 70 i 5166 Err codemadness.org 70 i 5169 Err codemadness.org 70 i 5170 Err codemadness.org 70 i 5171 Err codemadness.org 70 i 5174 Err codemadness.org 70 i 5175 Err codemadness.org 70 i 5176 Err codemadness.org 70 i 5179 Err codemadness.org 70 i 5180 Err codemadness.org 70 i 5181 Err codemadness.org 70 i 5184 Err codemadness.org 70 i 5185 Err codemadness.org 70 i 5186 Err codemadness.org 70 i 5189 Err codemadness.org 70 i 5190 Err codemadness.org 70 i 5191 Err codemadness.org 70 i 5194 Err codemadness.org 70 i 5195 Err codemadness.org 70 i 5196 Err codemadness.org 70 i 5199 Err codemadness.org 70 i 5200 Err codemadness.org 70 i 5201 Err codemadness.org 70 i 5204 Err codemadness.org 70 i 5205 Err codemadness.org 70 i 5206 Err codemadness.org 70 i 5209 Err codemadness.org 70 i 5210 Err codemadness.org 70 i 5211 Err codemadness.org 70 i 5214 Err codemadness.org 70 i 5215 Err codemadness.org 70 i 5216 Err codemadness.org 70 i 5219 Err codemadness.org 70 i 5220 Err codemadness.org 70 i 5221 Err codemadness.org 70 i 5224 Err codemadness.org 70 i 5225 Err codemadness.org 70 i 5226 Err codemadness.org 70 i 5229 Err codemadness.org 70 i 5230 Err codemadness.org 70 i 5231 Err codemadness.org 70 i 5234 Err codemadness.org 70 i 5235 Err codemadness.org 70 i 5236 Err codemadness.org 70 i 5239 Err codemadness.org 70 i 5240 Err codemadness.org 70 i 5241 Err codemadness.org 70 i 5244 Err codemadness.org 70 i 5245 Err codemadness.org 70 i 5246 Err codemadness.org 70 i 5249 Err codemadness.org 70 i 5250 Err codemadness.org 70 i 5251 Err codemadness.org 70 i 5254 Err codemadness.org 70 i 5255 Err codemadness.org 70 i 5256 Err codemadness.org 70 i 5260 Err codemadness.org 70 i 5261 Err codemadness.org 70 i 5262

Err codemadness.org 70 i 5077

--source include/have_innodb.inc

Err codemadness.org 70 i 5078

Err codemadness.org 70 i 5082

--source include/have_debug.inc

Err codemadness.org 70 i 5083

Err codemadness.org 70 i 5087

--source include/have_debug_sync.inc

Err codemadness.org 70 i 5088

Err codemadness.org 70 i 5092

#--source include/have_sequence.inc

Err codemadness.org 70 i 5093

Err codemadness.org 70 i 5097

Err codemadness.org 70 i 5098

Err codemadness.org 70 i 5102

connect(con_purge,localhost,root,,);

Err codemadness.org 70 i 5103

Err codemadness.org 70 i 5107

start transaction with consistent snapshot;

Err codemadness.org 70 i 5108

Err codemadness.org 70 i 5112

Err codemadness.org 70 i 5113

Err codemadness.org 70 i 5117

connection default;

Err codemadness.org 70 i 5118

Err codemadness.org 70 i 5122

create table t1 (f1 int not null, primary key(f1))engine=innodb;

Err codemadness.org 70 i 5123

Err codemadness.org 70 i 5127

#insert into t1 select -seq from seq_10000_to_1;

Err codemadness.org 70 i 5128

Err codemadness.org 70 i 5132

insert into t1 values(1);

Err codemadness.org 70 i 5133

Err codemadness.org 70 i 5137

delete from t1 where f1=1;

Err codemadness.org 70 i 5138

Err codemadness.org 70 i 5142

Err codemadness.org 70 i 5143

Err codemadness.org 70 i 5147

connect(con1,localhost,root,,);

Err codemadness.org 70 i 5148

Err codemadness.org 70 i 5152

begin;

Err codemadness.org 70 i 5153

Err codemadness.org 70 i 5157

select * from t1 where f1 > 2 for update;

Err codemadness.org 70 i 5158

Err codemadness.org 70 i 5162

Err codemadness.org 70 i 5163

Err codemadness.org 70 i 5167

# Connection con2 will wait for LOCK_ORDINARY in delete marked record.

Err codemadness.org 70 i 5168

Err codemadness.org 70 i 5172

connect(con2,localhost,root,,);

Err codemadness.org 70 i 5173

Err codemadness.org 70 i 5177

begin;

Err codemadness.org 70 i 5178

Err codemadness.org 70 i 5182

set debug_sync="lock_wait_suspend_thread_enter SIGNAL purge_start";

Err codemadness.org 70 i 5183

Err codemadness.org 70 i 5187

send select * from t1 where f1 > 2 for update;

Err codemadness.org 70 i 5188

Err codemadness.org 70 i 5192

Err codemadness.org 70 i 5193

Err codemadness.org 70 i 5197

connection con_purge;

Err codemadness.org 70 i 5198

Err codemadness.org 70 i 5202

Err codemadness.org 70 i 5203

Err codemadness.org 70 i 5207

set debug_sync="now WAIT_FOR purge_start";

Err codemadness.org 70 i 5208

Err codemadness.org 70 i 5212

# Allow purge to start and crash at the instrumented patch. (grant lock_wait for con2)

Err codemadness.org 70 i 5213

Err codemadness.org 70 i 5217

commit;

Err codemadness.org 70 i 5218

Err codemadness.org 70 i 5222

connection con2;

Err codemadness.org 70 i 5223

Err codemadness.org 70 i 5227

reap;

Err codemadness.org 70 i 5228

Err codemadness.org 70 i 5232

disconnect con2;

Err codemadness.org 70 i 5233

Err codemadness.org 70 i 5237

disconnect con_purge;

Err codemadness.org 70 i 5238

Err codemadness.org 70 i 5242

disconnect con1;

Err codemadness.org 70 i 5243

Err codemadness.org 70 i 5247

connection default;

Err codemadness.org 70 i 5248

Err codemadness.org 70 i 5252

drop table t1;

Err codemadness.org 70 i 5253

Err codemadness.org 70 i 5257

SET DEBUG_SYNC='RESET';	Err	codemadness.org	70
i  5258

Err codemadness.org 70 i 5259

Err codemadness.org 70 i 5263

Err codemadness.org 70 i 5264

Err codemadness.org 70 i 5265

Curiously, if I do not add the records f1<0 to the table, the SELECT * FROM t1 WHERE f1>2 FOR UPDATE will actually lock the delete-marked record f1=1, because the WHERE condition would not be passed down to prebuilt->search_tuple. Apparently, it will be a full table scan, via handler::ha_index_first(). This is causing some unnecessary locking.

Err codemadness.org 70 i 5266 Err codemadness.org 70 i 5267

The SELECT should not really acquire a lock on the delete-marked record itself, but instead only acquire a special gap lock that will prevent the delete-marked key from being inserted by other transactions. That is, there should be no conflict between the two locking SELECT operations to begin with, because neither one matched any records. Both SELECT should be allowed to continue in the first place. If the extra records f1<0 are present in the table, then that will be the case: only a gap lock on the supremum record will be acquired, only blocking any future INSERT.

Err codemadness.org 70 i 5268 Err codemadness.org 70 i 5269

I believe that implementing my idea of acquiring multiple gap locks when encountering delete-marked records should fix also this scenario. If the record was committed as delete-marked, we must acquire a read-gap-only lock on that record, and keep advancing to next records until an uncommitted record or committed non-delete-marked record or the end of the index is reached. Furthermore, we must ensure that row_ins_sec_index_entry_by_modify() and row_ins_clust_index_entry_by_modify() and similar functions will conflict with any read-gap-only locks that might exist on the successor of the committed delete-marked record.

Err codemadness.org 70 i 5270

Err codemadness.org 70 i 5272 Comment by Err codemadness.org 70 i 5273 Marko Mäkelä Err codemadness.org 70 i 5274 Err codemadness.org 70 i 5275 [ Err codemadness.org 70 i 5276 2019-10-18 Err codemadness.org 70 i 5277 Err codemadness.org 70 i 5278 ] Err codemadness.org 70 i 5279 Err codemadness.org 70 i 5280 Err codemadness.org 70 i 5281

Err codemadness.org 70 i 5283

I tried and failed to create a test case that involves INSERT (which was part of the original replication scenario). While debugging my test, I see that we are unnecessarily locking a delete-marked committed record f1=1 (but not the preceding gap) here:

Err codemadness.org 70 i 5284

Err codemadness.org 70 i 5285

Err codemadness.org 70 i 5286 Err codemadness.org 70 i 5287 Err codemadness.org 70 i 5288 Err codemadness.org 70 i 5289 Err codemadness.org 70 i 5292 Err codemadness.org 70 i 5293 Err codemadness.org 70 i 5294 Err codemadness.org 70 i 5297 Err codemadness.org 70 i 5298 Err codemadness.org 70 i 5299 Err codemadness.org 70 i 5302 Err codemadness.org 70 i 5303 Err codemadness.org 70 i 5304 Err codemadness.org 70 i 5307 Err codemadness.org 70 i 5308 Err codemadness.org 70 i 5309 Err codemadness.org 70 i 5312 Err codemadness.org 70 i 5313 Err codemadness.org 70 i 5314 Err codemadness.org 70 i 5317 Err codemadness.org 70 i 5318 Err codemadness.org 70 i 5319 Err codemadness.org 70 i 5322 Err codemadness.org 70 i 5323 Err codemadness.org 70 i 5324 Err codemadness.org 70 i 5327 Err codemadness.org 70 i 5328 Err codemadness.org 70 i 5329 Err codemadness.org 70 i 5332 Err codemadness.org 70 i 5333 Err codemadness.org 70 i 5334 Err codemadness.org 70 i 5337 Err codemadness.org 70 i 5338 Err codemadness.org 70 i 5339 Err codemadness.org 70 i 5342 Err codemadness.org 70 i 5343 Err codemadness.org 70 i 5344 Err codemadness.org 70 i 5347 Err codemadness.org 70 i 5348 Err codemadness.org 70 i 5349 Err codemadness.org 70 i 5352 Err codemadness.org 70 i 5353 Err codemadness.org 70 i 5354 Err codemadness.org 70 i 5358 Err codemadness.org 70 i 5359 Err codemadness.org 70 i 5360

Err codemadness.org 70 i 5290

                if (index == clust_index

Err codemadness.org 70 i 5291

Err codemadness.org 70 i 5295

                    && mode == PAGE_CUR_GE

Err codemadness.org 70 i 5296

Err codemadness.org 70 i 5300

                    && direction == 0

Err codemadness.org 70 i 5301

Err codemadness.org 70 i 5305

                    && dtuple_get_n_fields_cmp(search_tuple)

Err codemadness.org 70 i 5306

Err codemadness.org 70 i 5310

                    == dict_index_get_n_unique(index)

Err codemadness.org 70 i 5311

Err codemadness.org 70 i 5315

                    && 0 == cmp_dtuple_rec(search_tuple, rec, offsets)) {

Err codemadness.org 70 i 5316

Err codemadness.org 70 i 5320

no_gap_lock:

Err codemadness.org 70 i 5321

Err codemadness.org 70 i 5325

                        lock_type = LOCK_REC_NOT_GAP;

Err codemadness.org 70 i 5326

Err codemadness.org 70 i 5330

Err codemadness.org 70 i 5331

Err codemadness.org 70 i 5335

Err codemadness.org 70 i 5336

Err codemadness.org 70 i 5340

                err = sel_set_rec_lock(pcur,

Err codemadness.org 70 i 5341

Err codemadness.org 70 i 5345

                                       rec, index, offsets,

Err codemadness.org 70 i 5346

Err codemadness.org 70 i 5350

                                       prebuilt->select_lock_type,

Err codemadness.org 70 i 5351

Err codemadness.org 70 i 5355

                                       lock_type, thr, &mtr);	Err	codemadness.org	70
i  5356

Err codemadness.org 70 i 5357

Err codemadness.org 70 i 5361

Err codemadness.org 70 i 5362

Err codemadness.org 70 i 5363

The current statement is

Err codemadness.org 70 i 5364

Err codemadness.org 70 i 5365

Err codemadness.org 70 i 5366 Err codemadness.org 70 i 5367 Err codemadness.org 70 i 5368 Err codemadness.org 70 i 5369 Err codemadness.org 70 i 5373 Err codemadness.org 70 i 5374 Err codemadness.org 70 i 5375

Err codemadness.org 70 i 5370

select * from t1 where f1 between 1 and 3 for update;	Err	codemadness.org	70
i  5371

Err codemadness.org 70 i 5372

Err codemadness.org 70 i 5376

Err codemadness.org 70 i 5377

Err codemadness.org 70 i 5378

The delete-marked committed record is f1=1, which is at the very start of the search range.

Err codemadness.org 70 i 5379 Err codemadness.org 70 i 5380

The search is also locking ‘one row too much’, f1=4 (and its preceding gap), which is after the search range. If I add two ‘sentinel records’, hoping to not see a conflict between the INSERT and SELECT, also f1=5 will be locked by the SELECT:

Err codemadness.org 70 i 5381

Err codemadness.org 70 i 5382

Err codemadness.org 70 i 5383 Err codemadness.org 70 i 5384 Err codemadness.org 70 i 5385 Err codemadness.org 70 i 5386 Err codemadness.org 70 i 5389 Err codemadness.org 70 i 5390 Err codemadness.org 70 i 5391 Err codemadness.org 70 i 5394 Err codemadness.org 70 i 5395 Err codemadness.org 70 i 5396 Err codemadness.org 70 i 5399 Err codemadness.org 70 i 5400 Err codemadness.org 70 i 5401 Err codemadness.org 70 i 5404 Err codemadness.org 70 i 5405 Err codemadness.org 70 i 5406 Err codemadness.org 70 i 5409 Err codemadness.org 70 i 5410 Err codemadness.org 70 i 5411 Err codemadness.org 70 i 5414 Err codemadness.org 70 i 5415 Err codemadness.org 70 i 5416 Err codemadness.org 70 i 5419 Err codemadness.org 70 i 5420 Err codemadness.org 70 i 5421 Err codemadness.org 70 i 5424 Err codemadness.org 70 i 5425 Err codemadness.org 70 i 5426 Err codemadness.org 70 i 5429 Err codemadness.org 70 i 5430 Err codemadness.org 70 i 5431 Err codemadness.org 70 i 5434 Err codemadness.org 70 i 5435 Err codemadness.org 70 i 5436 Err codemadness.org 70 i 5439 Err codemadness.org 70 i 5440 Err codemadness.org 70 i 5441 Err codemadness.org 70 i 5444 Err codemadness.org 70 i 5445 Err codemadness.org 70 i 5446 Err codemadness.org 70 i 5449 Err codemadness.org 70 i 5450 Err codemadness.org 70 i 5451 Err codemadness.org 70 i 5454 Err codemadness.org 70 i 5455 Err codemadness.org 70 i 5456 Err codemadness.org 70 i 5459 Err codemadness.org 70 i 5460 Err codemadness.org 70 i 5461 Err codemadness.org 70 i 5464 Err codemadness.org 70 i 5465 Err codemadness.org 70 i 5466 Err codemadness.org 70 i 5469 Err codemadness.org 70 i 5470 Err codemadness.org 70 i 5471 Err codemadness.org 70 i 5475 Err codemadness.org 70 i 5476 Err codemadness.org 70 i 5477

Err codemadness.org 70 i 5387

connect(con_purge,localhost,root,,);

Err codemadness.org 70 i 5388

Err codemadness.org 70 i 5392

start transaction with consistent snapshot;

Err codemadness.org 70 i 5393

Err codemadness.org 70 i 5397

Err codemadness.org 70 i 5398

Err codemadness.org 70 i 5402

connection default;

Err codemadness.org 70 i 5403

Err codemadness.org 70 i 5407

create table t1 (f1 int not null, primary key(f1))engine=innodb;

Err codemadness.org 70 i 5408

Err codemadness.org 70 i 5412

insert into t1 select -seq from seq_10000_to_1;

Err codemadness.org 70 i 5413

Err codemadness.org 70 i 5417

insert into t1 values(1),(3),(4);

Err codemadness.org 70 i 5418

Err codemadness.org 70 i 5422

delete from t1 where f1>0;

Err codemadness.org 70 i 5423

Err codemadness.org 70 i 5427

Err codemadness.org 70 i 5428

Err codemadness.org 70 i 5432

connect(con1,localhost,root,,);

Err codemadness.org 70 i 5433

Err codemadness.org 70 i 5437

begin;

Err codemadness.org 70 i 5438

Err codemadness.org 70 i 5442

insert into t1 values(5);

Err codemadness.org 70 i 5443

Err codemadness.org 70 i 5447

Err codemadness.org 70 i 5448

Err codemadness.org 70 i 5452

# Connection con2 will wait for LOCK_ORDINARY in delete marked record.

Err codemadness.org 70 i 5453

Err codemadness.org 70 i 5457

connect(con2,localhost,root,,);

Err codemadness.org 70 i 5458

Err codemadness.org 70 i 5462

begin;

Err codemadness.org 70 i 5463

Err codemadness.org 70 i 5467

set debug_sync="lock_wait_suspend_thread_enter SIGNAL purge_start";

Err codemadness.org 70 i 5468

Err codemadness.org 70 i 5472

send select * from t1 where f1 between 1 and 3 for update;	Err	codemadness.org	70
i  5473

Err codemadness.org 70 i 5474

Err codemadness.org 70 i 5478

Err codemadness.org 70 i 5479

Err codemadness.org 70 i 5480

For that particular bug (locking too many records after a range), MySQL 8.0.18 included a fix that we should evaluate and try to port to MariaDB.

Err codemadness.org 70 i 5481 Err codemadness.org 70 i 5482

Side note: When purge is removing the record f1=1, it is creating a LOCK_GAP|LOCK_X|LOCK_REC on the successor record f1=3, which is delete-marked and committed. It fails to notice that there already was a covering LOCK_X|LOCK_REC on that record, and unnecessarily allocates another record lock. My proposed fix for this bug would avoid any lock creation when purge or rollback are deleting records. Such unnecessary allocation would also be avoided if we introduce a single record lock bitmap with 4 bits per record, as proposed in MDEV-16406.

Err codemadness.org 70 i 5483

Err codemadness.org 70 i 5485 Comment by Err codemadness.org 70 i 5486 Marko Mäkelä Err codemadness.org 70 i 5487 Err codemadness.org 70 i 5488 [ Err codemadness.org 70 i 5489 2019-10-25 Err codemadness.org 70 i 5490 Err codemadness.org 70 i 5491 ] Err codemadness.org 70 i 5492 Err codemadness.org 70 i 5493 Err codemadness.org 70 i 5494

Err codemadness.org 70 i 5496

An alternative approach was suggested, to make purge more visible to concurrent transactions. We already have an unfortunate case of that, for SPATIAL INDEX (see MDEV-15284 and MDEV-16269).

Err codemadness.org 70 i 5497 Err codemadness.org 70 i 5498

What would be the benefit of making purge more visible? To me, doing so would seem to cause more locking inconsistency between server instances in a replication or Galera setup, which is something that should be avoided.

Err codemadness.org 70 i 5499 Err codemadness.org 70 i 5500

I would prefer things to be so regular that they can be described in simple abstract terms. A maintenance task that runs in the background and lacks theoretical foundation should be as invisible as possible. Side note: This was a main motivation for remove the InnoDB background change buffer merge in ~~MDEV-19514~~.

Err codemadness.org 70 i 5501 Err codemadness.org 70 i 5502

It is a bug if purge or rollback are creating or acquiring any locks.

Err codemadness.org 70 i 5503

Anything that rollback is modifying should already be exclusively locked by the transaction that is being rolled back, partially or fully.
By design, the purge of history is supposed to be invisible to any transactions. Purge is not run within a transaction, so it cannot acquire record locks for itself. And I am reasoning that it should not acquire record locks on behalf of other transactions either.

Err codemadness.org 70 i 5507 Err codemadness.org 70 i 5508

Err codemadness.org 70 i 5510 Comment by Err codemadness.org 70 i 5511 Vladislav Lesin Err codemadness.org 70 i 5512 Err codemadness.org 70 i 5513 [ Err codemadness.org 70 i 5514 2019-12-19 Err codemadness.org 70 i 5515 Err codemadness.org 70 i 5516 ] Err codemadness.org 70 i 5517 Err codemadness.org 70 i 5518 Err codemadness.org 70 i 5519

Err codemadness.org 70 i 5521

Let's consider the following test (the same test which was previously considered by Marko Mäkelä and Thirunarayanan Balathandayuthapani under 10.2:

Err codemadness.org 70 i 5522 Err codemadness.org 70 i 5523

Err codemadness.org 70 i 5524

Err codemadness.org 70 i 5525 Err codemadness.org 70 i 5526 Err codemadness.org 70 i 5527 Err codemadness.org 70 i 5528 Err codemadness.org 70 i 5531 Err codemadness.org 70 i 5532 Err codemadness.org 70 i 5533 Err codemadness.org 70 i 5536 Err codemadness.org 70 i 5537 Err codemadness.org 70 i 5538 Err codemadness.org 70 i 5541 Err codemadness.org 70 i 5542 Err codemadness.org 70 i 5543 Err codemadness.org 70 i 5546 Err codemadness.org 70 i 5547 Err codemadness.org 70 i 5548 Err codemadness.org 70 i 5551 Err codemadness.org 70 i 5552 Err codemadness.org 70 i 5553 Err codemadness.org 70 i 5556 Err codemadness.org 70 i 5557 Err codemadness.org 70 i 5558 Err codemadness.org 70 i 5561 Err codemadness.org 70 i 5562 Err codemadness.org 70 i 5563 Err codemadness.org 70 i 5566 Err codemadness.org 70 i 5567 Err codemadness.org 70 i 5568 Err codemadness.org 70 i 5571 Err codemadness.org 70 i 5572 Err codemadness.org 70 i 5573 Err codemadness.org 70 i 5576 Err codemadness.org 70 i 5577 Err codemadness.org 70 i 5578 Err codemadness.org 70 i 5581 Err codemadness.org 70 i 5582 Err codemadness.org 70 i 5583 Err codemadness.org 70 i 5586 Err codemadness.org 70 i 5587 Err codemadness.org 70 i 5588 Err codemadness.org 70 i 5591 Err codemadness.org 70 i 5592 Err codemadness.org 70 i 5593 Err codemadness.org 70 i 5596 Err codemadness.org 70 i 5597 Err codemadness.org 70 i 5598 Err codemadness.org 70 i 5601 Err codemadness.org 70 i 5602 Err codemadness.org 70 i 5603 Err codemadness.org 70 i 5606 Err codemadness.org 70 i 5607 Err codemadness.org 70 i 5608 Err codemadness.org 70 i 5611 Err codemadness.org 70 i 5612 Err codemadness.org 70 i 5613 Err codemadness.org 70 i 5616 Err codemadness.org 70 i 5617 Err codemadness.org 70 i 5618 Err codemadness.org 70 i 5621 Err codemadness.org 70 i 5622 Err codemadness.org 70 i 5623 Err codemadness.org 70 i 5626 Err codemadness.org 70 i 5627 Err codemadness.org 70 i 5628 Err codemadness.org 70 i 5631 Err codemadness.org 70 i 5632 Err codemadness.org 70 i 5633 Err codemadness.org 70 i 5636 Err codemadness.org 70 i 5637 Err codemadness.org 70 i 5638 Err codemadness.org 70 i 5641 Err codemadness.org 70 i 5642 Err codemadness.org 70 i 5643 Err codemadness.org 70 i 5646 Err codemadness.org 70 i 5647 Err codemadness.org 70 i 5648 Err codemadness.org 70 i 5651 Err codemadness.org 70 i 5652 Err codemadness.org 70 i 5653 Err codemadness.org 70 i 5656 Err codemadness.org 70 i 5657 Err codemadness.org 70 i 5658 Err codemadness.org 70 i 5661 Err codemadness.org 70 i 5662 Err codemadness.org 70 i 5663 Err codemadness.org 70 i 5666 Err codemadness.org 70 i 5667 Err codemadness.org 70 i 5668 Err codemadness.org 70 i 5671 Err codemadness.org 70 i 5672 Err codemadness.org 70 i 5673 Err codemadness.org 70 i 5676 Err codemadness.org 70 i 5677 Err codemadness.org 70 i 5678 Err codemadness.org 70 i 5681 Err codemadness.org 70 i 5682 Err codemadness.org 70 i 5683 Err codemadness.org 70 i 5686 Err codemadness.org 70 i 5687 Err codemadness.org 70 i 5688 Err codemadness.org 70 i 5691 Err codemadness.org 70 i 5692 Err codemadness.org 70 i 5693 Err codemadness.org 70 i 5697 Err codemadness.org 70 i 5698 Err codemadness.org 70 i 5699

Err codemadness.org 70 i 5529

--source include/have_innodb.inc

Err codemadness.org 70 i 5530

Err codemadness.org 70 i 5534

--source include/have_debug.inc

Err codemadness.org 70 i 5535

Err codemadness.org 70 i 5539

--source include/have_debug_sync.inc

Err codemadness.org 70 i 5540

Err codemadness.org 70 i 5544

create table t1 (f1 int not null, primary key(f1))engine=innodb;

Err codemadness.org 70 i 5545

Err codemadness.org 70 i 5549

insert into t1 values (10), (20), (30);

Err codemadness.org 70 i 5550

Err codemadness.org 70 i 5554

Err codemadness.org 70 i 5555

Err codemadness.org 70 i 5559

connect(con_purge,localhost,root,,);

Err codemadness.org 70 i 5560

Err codemadness.org 70 i 5564

start transaction with consistent snapshot;

Err codemadness.org 70 i 5565

Err codemadness.org 70 i 5569

Err codemadness.org 70 i 5570

Err codemadness.org 70 i 5574

connection default;

Err codemadness.org 70 i 5575

Err codemadness.org 70 i 5579

delete from t1 where f1 = 10 and f1 = 20;

Err codemadness.org 70 i 5580

Err codemadness.org 70 i 5584

Err codemadness.org 70 i 5585

Err codemadness.org 70 i 5589

connect(con1,localhost,root,,);

Err codemadness.org 70 i 5590

Err codemadness.org 70 i 5594

begin;

Err codemadness.org 70 i 5595

Err codemadness.org 70 i 5599

select * from t1 where f1 < 0 for update; // <--- first select

Err codemadness.org 70 i 5600

Err codemadness.org 70 i 5604

# Connection con2 will wait for LOCK_ORDINARY in delete marked record.

Err codemadness.org 70 i 5605

Err codemadness.org 70 i 5609

connect(con2,localhost,root,,);

Err codemadness.org 70 i 5610

Err codemadness.org 70 i 5614

begin;

Err codemadness.org 70 i 5615

Err codemadness.org 70 i 5619

set debug_sync="lock_wait_suspend_thread_enter SIGNAL purge_start";

Err codemadness.org 70 i 5620

Err codemadness.org 70 i 5624

send select * from t1 where f1 < 0 for update; // <--- second select

Err codemadness.org 70 i 5625

Err codemadness.org 70 i 5629

Err codemadness.org 70 i 5630

Err codemadness.org 70 i 5634

connection con_purge;

Err codemadness.org 70 i 5635

Err codemadness.org 70 i 5639

set debug_sync="now WAIT_FOR purge_start";

Err codemadness.org 70 i 5640

Err codemadness.org 70 i 5644

# Allow purge to start and crash at the instrumented patch. (grant lock_wait for con2)

Err codemadness.org 70 i 5645

Err codemadness.org 70 i 5649

commit;

Err codemadness.org 70 i 5650

Err codemadness.org 70 i 5654

Err codemadness.org 70 i 5655

Err codemadness.org 70 i 5659

connection con2;

Err codemadness.org 70 i 5660

Err codemadness.org 70 i 5664

reap;

Err codemadness.org 70 i 5665

Err codemadness.org 70 i 5669

disconnect con2;

Err codemadness.org 70 i 5670

Err codemadness.org 70 i 5674

disconnect con_purge;

Err codemadness.org 70 i 5675

Err codemadness.org 70 i 5679

disconnect con1;

Err codemadness.org 70 i 5680

Err codemadness.org 70 i 5684

connection default;

Err codemadness.org 70 i 5685

Err codemadness.org 70 i 5689

drop table t1;

Err codemadness.org 70 i 5690

Err codemadness.org 70 i 5694

SET DEBUG_SYNC='RESET';	Err	codemadness.org	70
i  5695

Err codemadness.org 70 i 5696

Err codemadness.org 70 i 5700

Err codemadness.org 70 i 5701

Err codemadness.org 70 i 5702 Err codemadness.org 70 i 5703

The first "select" sets LOCK_ORDINARY locks on delete marked records (10), (20) and on record (30). The locks are set with the following stack trace:

Err codemadness.org 70 i 5704 Err codemadness.org 70 i 5705

Err codemadness.org 70 i 5706

Err codemadness.org 70 i 5707 Err codemadness.org 70 i 5708 Err codemadness.org 70 i 5709 Err codemadness.org 70 i 5710 Err codemadness.org 70 i 5713 Err codemadness.org 70 i 5714 Err codemadness.org 70 i 5715 Err codemadness.org 70 i 5718 Err codemadness.org 70 i 5719 Err codemadness.org 70 i 5720 Err codemadness.org 70 i 5723 Err codemadness.org 70 i 5724 Err codemadness.org 70 i 5725 Err codemadness.org 70 i 5728 Err codemadness.org 70 i 5729 Err codemadness.org 70 i 5730 Err codemadness.org 70 i 5733 Err codemadness.org 70 i 5734 Err codemadness.org 70 i 5735 Err codemadness.org 70 i 5738 Err codemadness.org 70 i 5739 Err codemadness.org 70 i 5740 Err codemadness.org 70 i 5743 Err codemadness.org 70 i 5744 Err codemadness.org 70 i 5745 Err codemadness.org 70 i 5748 Err codemadness.org 70 i 5749 Err codemadness.org 70 i 5750 Err codemadness.org 70 i 5753 Err codemadness.org 70 i 5754 Err codemadness.org 70 i 5755 Err codemadness.org 70 i 5758 Err codemadness.org 70 i 5759 Err codemadness.org 70 i 5760 Err codemadness.org 70 i 5764 Err codemadness.org 70 i 5765 Err codemadness.org 70 i 5766

Err codemadness.org 70 i 5711

#0  lock_rec_lock (impl=false, mode=3, block=0x7ffff40cc260, heap_no=3, index=0x7fff9c112a88, thr=0x7fff9c09ddc8)

Err codemadness.org 70 i 5712

Err codemadness.org 70 i 5716

    at ./storage/innobase/lock/lock0lock.cc:2148

Err codemadness.org 70 i 5717

Err codemadness.org 70 i 5721

#1  0x0000555556008153 in lock_clust_rec_read_check_and_lock (flags=0, block=0x7ffff40cc260, rec=0x7ffff45c4093 "\200", index=0x7fff9c112a88,

Err codemadness.org 70 i 5722

Err codemadness.org 70 i 5726

    offsets=0x7fffefd1a280, mode=LOCK_X, gap_mode=0, thr=0x7fff9c09ddc8)

Err codemadness.org 70 i 5727

Err codemadness.org 70 i 5731

    at ./storage/innobase/lock/lock0lock.cc:6130

Err codemadness.org 70 i 5732

Err codemadness.org 70 i 5736

#2  0x00005555560e8f53 in sel_set_rec_lock (pcur=0x7fff9c09d590, rec=0x7ffff45c4093 "\200", index=0x7fff9c112a88, offsets=0x7fffefd1a280, mode=3,

Err codemadness.org 70 i 5737

Err codemadness.org 70 i 5741

    type=0, thr=0x7fff9c09ddc8, mtr=0x7fffefd1a660) at ./storage/innobase/row/row0sel.cc:1261

Err codemadness.org 70 i 5742

Err codemadness.org 70 i 5746

#3  0x00005555560f143e in row_search_mvcc (buf=0x7fff9c0a0110 "\377", mode=PAGE_CUR_G, prebuilt=0x7fff9c09d3c8, match_mode=0, direction=1)

Err codemadness.org 70 i 5747

Err codemadness.org 70 i 5751

    at ./storage/innobase/row/row0sel.cc:5133

Err codemadness.org 70 i 5752

Err codemadness.org 70 i 5756

#4  0x0000555555f88aec in ha_innobase::general_fetch (this=0x7fff9c09cc38, buf=0x7fff9c0a0110 "\377", direction=1, match_mode=0)

Err codemadness.org 70 i 5757

Err codemadness.org 70 i 5761

    at ./storage/innobase/handler/ha_innodb.cc:9736	Err	codemadness.org	70
i  5762

Err codemadness.org 70 i 5763

Err codemadness.org 70 i 5767

Err codemadness.org 70 i 5768

Err codemadness.org 70 i 5769 Err codemadness.org 70 i 5770

Let's take a look at the following code in row_search_mvcc():

Err codemadness.org 70 i 5771

Err codemadness.org 70 i 5772

Err codemadness.org 70 i 5773 Err codemadness.org 70 i 5774 Err codemadness.org 70 i 5775 Err codemadness.org 70 i 5776 Err codemadness.org 70 i 5779 Err codemadness.org 70 i 5780 Err codemadness.org 70 i 5781 Err codemadness.org 70 i 5784 Err codemadness.org 70 i 5785 Err codemadness.org 70 i 5786 Err codemadness.org 70 i 5789 Err codemadness.org 70 i 5790 Err codemadness.org 70 i 5791 Err codemadness.org 70 i 5794 Err codemadness.org 70 i 5795 Err codemadness.org 70 i 5796 Err codemadness.org 70 i 5799 Err codemadness.org 70 i 5800 Err codemadness.org 70 i 5801 Err codemadness.org 70 i 5804 Err codemadness.org 70 i 5805 Err codemadness.org 70 i 5806 Err codemadness.org 70 i 5809 Err codemadness.org 70 i 5810 Err codemadness.org 70 i 5811 Err codemadness.org 70 i 5814 Err codemadness.org 70 i 5815 Err codemadness.org 70 i 5816 Err codemadness.org 70 i 5819 Err codemadness.org 70 i 5820 Err codemadness.org 70 i 5821 Err codemadness.org 70 i 5824 Err codemadness.org 70 i 5825 Err codemadness.org 70 i 5826 Err codemadness.org 70 i 5829 Err codemadness.org 70 i 5830 Err codemadness.org 70 i 5831 Err codemadness.org 70 i 5834 Err codemadness.org 70 i 5835 Err codemadness.org 70 i 5836 Err codemadness.org 70 i 5839 Err codemadness.org 70 i 5840 Err codemadness.org 70 i 5841 Err codemadness.org 70 i 5844 Err codemadness.org 70 i 5845 Err codemadness.org 70 i 5846 Err codemadness.org 70 i 5849 Err codemadness.org 70 i 5850 Err codemadness.org 70 i 5851 Err codemadness.org 70 i 5854 Err codemadness.org 70 i 5855 Err codemadness.org 70 i 5856 Err codemadness.org 70 i 5859 Err codemadness.org 70 i 5860 Err codemadness.org 70 i 5861 Err codemadness.org 70 i 5864 Err codemadness.org 70 i 5865 Err codemadness.org 70 i 5866 Err codemadness.org 70 i 5869 Err codemadness.org 70 i 5870 Err codemadness.org 70 i 5871 Err codemadness.org 70 i 5874 Err codemadness.org 70 i 5875 Err codemadness.org 70 i 5876 Err codemadness.org 70 i 5879 Err codemadness.org 70 i 5880 Err codemadness.org 70 i 5881 Err codemadness.org 70 i 5884 Err codemadness.org 70 i 5885 Err codemadness.org 70 i 5886 Err codemadness.org 70 i 5889 Err codemadness.org 70 i 5890 Err codemadness.org 70 i 5891 Err codemadness.org 70 i 5894 Err codemadness.org 70 i 5895 Err codemadness.org 70 i 5896 Err codemadness.org 70 i 5899 Err codemadness.org 70 i 5900 Err codemadness.org 70 i 5901 Err codemadness.org 70 i 5904 Err codemadness.org 70 i 5905 Err codemadness.org 70 i 5906 Err codemadness.org 70 i 5909 Err codemadness.org 70 i 5910 Err codemadness.org 70 i 5911 Err codemadness.org 70 i 5914 Err codemadness.org 70 i 5915 Err codemadness.org 70 i 5916 Err codemadness.org 70 i 5919 Err codemadness.org 70 i 5920 Err codemadness.org 70 i 5921 Err codemadness.org 70 i 5924 Err codemadness.org 70 i 5925 Err codemadness.org 70 i 5926 Err codemadness.org 70 i 5929 Err codemadness.org 70 i 5930 Err codemadness.org 70 i 5931 Err codemadness.org 70 i 5934 Err codemadness.org 70 i 5935 Err codemadness.org 70 i 5936 Err codemadness.org 70 i 5939 Err codemadness.org 70 i 5940 Err codemadness.org 70 i 5941 Err codemadness.org 70 i 5944 Err codemadness.org 70 i 5945 Err codemadness.org 70 i 5946 Err codemadness.org 70 i 5949 Err codemadness.org 70 i 5950 Err codemadness.org 70 i 5951 Err codemadness.org 70 i 5954 Err codemadness.org 70 i 5955 Err codemadness.org 70 i 5956 Err codemadness.org 70 i 5959 Err codemadness.org 70 i 5960 Err codemadness.org 70 i 5961 Err codemadness.org 70 i 5964 Err codemadness.org 70 i 5965 Err codemadness.org 70 i 5966 Err codemadness.org 70 i 5969 Err codemadness.org 70 i 5970 Err codemadness.org 70 i 5971 Err codemadness.org 70 i 5974 Err codemadness.org 70 i 5975 Err codemadness.org 70 i 5976 Err codemadness.org 70 i 5979 Err codemadness.org 70 i 5980 Err codemadness.org 70 i 5981 Err codemadness.org 70 i 5984 Err codemadness.org 70 i 5985 Err codemadness.org 70 i 5986 Err codemadness.org 70 i 5989 Err codemadness.org 70 i 5990 Err codemadness.org 70 i 5991 Err codemadness.org 70 i 5995 Err codemadness.org 70 i 5996 Err codemadness.org 70 i 5997

Err codemadness.org 70 i 5777

... row_search_mvcc(...)

Err codemadness.org 70 i 5778

Err codemadness.org 70 i 5782

Err codemadness.org 70 i 5783

Err codemadness.org 70 i 5787

...

Err codemadness.org 70 i 5788

Err codemadness.org 70 i 5792

locks_ok:

Err codemadness.org 70 i 5793

Err codemadness.org 70 i 5797

        /* NOTE that at this point rec can be an old version of a clustered

Err codemadness.org 70 i 5798

Err codemadness.org 70 i 5802

        index record built for a consistent read. We cannot assume after this

Err codemadness.org 70 i 5803

Err codemadness.org 70 i 5807

        point that rec is on a buffer pool page. Functions like

Err codemadness.org 70 i 5808

Err codemadness.org 70 i 5812

        page_rec_is_comp() cannot be used! */

Err codemadness.org 70 i 5813

Err codemadness.org 70 i 5817

Err codemadness.org 70 i 5818

Err codemadness.org 70 i 5822

        if (rec_get_deleted_flag(rec, comp)) {

Err codemadness.org 70 i 5823

Err codemadness.org 70 i 5827

locks_ok_del_marked:

Err codemadness.org 70 i 5828

Err codemadness.org 70 i 5832

                /* In delete-marked records, DB_TRX_ID must

Err codemadness.org 70 i 5833

Err codemadness.org 70 i 5837

                always refer to an existing undo log record. */

Err codemadness.org 70 i 5838

Err codemadness.org 70 i 5842

                ut_ad(index != clust_index

Err codemadness.org 70 i 5843

Err codemadness.org 70 i 5847

                      || row_get_rec_trx_id(rec, index, offsets));

Err codemadness.org 70 i 5848

Err codemadness.org 70 i 5852

Err codemadness.org 70 i 5853

Err codemadness.org 70 i 5857

                /* The record is delete-marked: we can skip it */

Err codemadness.org 70 i 5858

Err codemadness.org 70 i 5862

Err codemadness.org 70 i 5863

Err codemadness.org 70 i 5867

                /* This is an optimization to skip setting the next key lock

Err codemadness.org 70 i 5868

Err codemadness.org 70 i 5872

                on the record that follows this delete-marked record. This

Err codemadness.org 70 i 5873

Err codemadness.org 70 i 5877

                optimization works because of the unique search criteria

Err codemadness.org 70 i 5878

Err codemadness.org 70 i 5882

                which precludes the presence of a range lock between this

Err codemadness.org 70 i 5883

Err codemadness.org 70 i 5887

                delete marked record and the record following it.

Err codemadness.org 70 i 5888

Err codemadness.org 70 i 5892

Err codemadness.org 70 i 5893

Err codemadness.org 70 i 5897

                For now this is applicable only to clustered indexes while

Err codemadness.org 70 i 5898

Err codemadness.org 70 i 5902

                doing a unique search except for HANDLER queries because

Err codemadness.org 70 i 5903

Err codemadness.org 70 i 5907

                HANDLER allows NEXT and PREV even in unique search on

Err codemadness.org 70 i 5908

Err codemadness.org 70 i 5912

                clustered index. There is scope for further optimization

Err codemadness.org 70 i 5913

Err codemadness.org 70 i 5917

                applicable to unique secondary indexes. Current behaviour is

Err codemadness.org 70 i 5918

Err codemadness.org 70 i 5922

                to widen the scope of a lock on an already delete marked record

Err codemadness.org 70 i 5923

Err codemadness.org 70 i 5927

                if the same record is deleted twice by the same transaction */

Err codemadness.org 70 i 5928

Err codemadness.org 70 i 5932

                if (index == clust_index && unique_search

Err codemadness.org 70 i 5933

Err codemadness.org 70 i 5937

                    && !prebuilt->used_in_HANDLER) {

Err codemadness.org 70 i 5938

Err codemadness.org 70 i 5942

Err codemadness.org 70 i 5943

Err codemadness.org 70 i 5947

                        err = DB_RECORD_NOT_FOUND;

Err codemadness.org 70 i 5948

Err codemadness.org 70 i 5952

Err codemadness.org 70 i 5953

Err codemadness.org 70 i 5957

                        goto normal_return;

Err codemadness.org 70 i 5958

Err codemadness.org 70 i 5962

Err codemadness.org 70 i 5963

Err codemadness.org 70 i 5967

Err codemadness.org 70 i 5968

Err codemadness.org 70 i 5972

                goto next_rec;

Err codemadness.org 70 i 5973

Err codemadness.org 70 i 5977

Err codemadness.org 70 i 5978

Err codemadness.org 70 i 5982

Err codemadness.org 70 i 5983

Err codemadness.org 70 i 5987

...

Err codemadness.org 70 i 5988

Err codemadness.org 70 i 5992

}	Err	codemadness.org	70
i  5993

Err codemadness.org 70 i 5994

Err codemadness.org 70 i 5998

Err codemadness.org 70 i 5999

Err codemadness.org 70 i 6000 Err codemadness.org 70 i 6001

Please pay attention on "goto next_rec;". I.e. when delete marked record is locked, the lock on the next record is acquired. That is why the first "select" locks two delete marked records (10), (20) and one record (30).

Err codemadness.org 70 i 6002 Err codemadness.org 70 i 6003

If we apply the patch proposed by Thirunarayanan Balathandayuthapani and modify it a little bit:

Err codemadness.org 70 i 6004 Err codemadness.org 70 i 6005

Err codemadness.org 70 i 6006

Err codemadness.org 70 i 6007 Err codemadness.org 70 i 6008 Err codemadness.org 70 i 6009 Err codemadness.org 70 i 6010 Err codemadness.org 70 i 6013 Err codemadness.org 70 i 6014 Err codemadness.org 70 i 6015 Err codemadness.org 70 i 6018 Err codemadness.org 70 i 6019 Err codemadness.org 70 i 6020 Err codemadness.org 70 i 6023 Err codemadness.org 70 i 6024 Err codemadness.org 70 i 6025 Err codemadness.org 70 i 6028 Err codemadness.org 70 i 6029 Err codemadness.org 70 i 6030 Err codemadness.org 70 i 6033 Err codemadness.org 70 i 6034 Err codemadness.org 70 i 6035 Err codemadness.org 70 i 6038 Err codemadness.org 70 i 6039 Err codemadness.org 70 i 6040 Err codemadness.org 70 i 6043 Err codemadness.org 70 i 6044 Err codemadness.org 70 i 6045 Err codemadness.org 70 i 6048 Err codemadness.org 70 i 6049 Err codemadness.org 70 i 6050 Err codemadness.org 70 i 6053 Err codemadness.org 70 i 6054 Err codemadness.org 70 i 6055 Err codemadness.org 70 i 6059 Err codemadness.org 70 i 6060 Err codemadness.org 70 i 6061

Err codemadness.org 70 i 6011

@@ -3523,8 +3527,8 @@ lock_update_delete(

Err codemadness.org 70 i 6012

Err codemadness.org 70 i 6016

        lock_mutex_enter();

Err codemadness.org 70 i 6017

Err codemadness.org 70 i 6021

Err codemadness.org 70 i 6022

Err codemadness.org 70 i 6026

        /* Let the next record inherit the locks from rec, in gap mode */

Err codemadness.org 70 i 6027

Err codemadness.org 70 i 6031

Err codemadness.org 70 i 6032

Err codemadness.org 70 i 6036

-       lock_rec_inherit_to_gap(block, block, next_heap_no, heap_no);

Err codemadness.org 70 i 6037

Err codemadness.org 70 i 6041

+       if (!interesting)

Err codemadness.org 70 i 6042

Err codemadness.org 70 i 6046

+               lock_rec_inherit_to_gap(block, block, next_heap_no, heap_no, interesting);

Err codemadness.org 70 i 6047

Err codemadness.org 70 i 6051

Err codemadness.org 70 i 6052

Err codemadness.org 70 i 6056

        /* Reset the lock bits on rec and release waiting transactions */	Err	codemadness.org	70
i  6057

Err codemadness.org 70 i 6058

Err codemadness.org 70 i 6062

Err codemadness.org 70 i 6063

Err codemadness.org 70 i 6064 Err codemadness.org 70 i 6065

I.e. purge thread will not extend lock from delete marked record to it's successor, we will see that the second "select" will fail with "lock wait timeout" error even after all delete marked records are purged, because the first "select" set conflicting lock on record (30).

Err codemadness.org 70 i 6066 Err codemadness.org 70 i 6067

In other words the requested by Marko Mäkelä functionality is already implemented.

Err codemadness.org 70 i 6068 Err codemadness.org 70 i 6069

If so then why the lock is granted for the second "select" in the original test after delete marked (10) is purged?

Err codemadness.org 70 i 6070 Err codemadness.org 70 i 6071

Let's now consider the original test. I.e. replace:

Err codemadness.org 70 i 6072

Err codemadness.org 70 i 6073

Err codemadness.org 70 i 6074 Err codemadness.org 70 i 6075 Err codemadness.org 70 i 6076 Err codemadness.org 70 i 6077 Err codemadness.org 70 i 6080 Err codemadness.org 70 i 6081 Err codemadness.org 70 i 6082 Err codemadness.org 70 i 6085 Err codemadness.org 70 i 6086 Err codemadness.org 70 i 6087 Err codemadness.org 70 i 6090 Err codemadness.org 70 i 6091 Err codemadness.org 70 i 6092 Err codemadness.org 70 i 6095 Err codemadness.org 70 i 6096 Err codemadness.org 70 i 6097 Err codemadness.org 70 i 6101 Err codemadness.org 70 i 6102 Err codemadness.org 70 i 6103

Err codemadness.org 70 i 6078

-insert into t1 values (10), (20), (30);

Err codemadness.org 70 i 6079

Err codemadness.org 70 i 6083

+insert into t1 values (10);

Err codemadness.org 70 i 6084

Err codemadness.org 70 i 6088

...

Err codemadness.org 70 i 6089

Err codemadness.org 70 i 6093

-delete from t1 where f1 = 10 and f1 = 20;

Err codemadness.org 70 i 6094

Err codemadness.org 70 i 6098

+delete from t1 where f1 = 10;	Err	codemadness.org	70
i  6099

Err codemadness.org 70 i 6100

Err codemadness.org 70 i 6104

Err codemadness.org 70 i 6105

Err codemadness.org 70 i 6106 Err codemadness.org 70 i 6107

In this case the first "select" locks delete marked (10) record with LOCK_ORDINARY type and supremum. All locks on supremum are considered as gap locks.

Err codemadness.org 70 i 6108 Err codemadness.org 70 i 6109

When purge thread unlocks delete marked (10), the second "select" is unlocked(see lock_rec_reset_and_release_wait() call in lock_update_delete(), which is invoked from purge thread) and acquires lock on supremum. And the lock is granted with the following stack trace:

Err codemadness.org 70 i 6110

Err codemadness.org 70 i 6111

Err codemadness.org 70 i 6112 Err codemadness.org 70 i 6113 Err codemadness.org 70 i 6114 Err codemadness.org 70 i 6115 Err codemadness.org 70 i 6118 Err codemadness.org 70 i 6119 Err codemadness.org 70 i 6120 Err codemadness.org 70 i 6123 Err codemadness.org 70 i 6124 Err codemadness.org 70 i 6125 Err codemadness.org 70 i 6128 Err codemadness.org 70 i 6129 Err codemadness.org 70 i 6130 Err codemadness.org 70 i 6133 Err codemadness.org 70 i 6134 Err codemadness.org 70 i 6135 Err codemadness.org 70 i 6138 Err codemadness.org 70 i 6139 Err codemadness.org 70 i 6140 Err codemadness.org 70 i 6143 Err codemadness.org 70 i 6144 Err codemadness.org 70 i 6145 Err codemadness.org 70 i 6148 Err codemadness.org 70 i 6149 Err codemadness.org 70 i 6150 Err codemadness.org 70 i 6153 Err codemadness.org 70 i 6154 Err codemadness.org 70 i 6155 Err codemadness.org 70 i 6158 Err codemadness.org 70 i 6159 Err codemadness.org 70 i 6160 Err codemadness.org 70 i 6163 Err codemadness.org 70 i 6164 Err codemadness.org 70 i 6165 Err codemadness.org 70 i 6168 Err codemadness.org 70 i 6169 Err codemadness.org 70 i 6170 Err codemadness.org 70 i 6173 Err codemadness.org 70 i 6174 Err codemadness.org 70 i 6175 Err codemadness.org 70 i 6178 Err codemadness.org 70 i 6179 Err codemadness.org 70 i 6180 Err codemadness.org 70 i 6184 Err codemadness.org 70 i 6185 Err codemadness.org 70 i 6186

Err codemadness.org 70 i 6116

#0  lock_rec_has_to_wait (for_locking=true, trx=0x7ffff495b478, type_mode=3, lock2=0x7ffff495a448, lock_is_on_supremum=true)

Err codemadness.org 70 i 6117

Err codemadness.org 70 i 6121

    at ./storage/innobase/lock/lock0lock.cc:669

Err codemadness.org 70 i 6122

Err codemadness.org 70 i 6126

#1  0x0000555555ffa3e9 in lock_rec_other_has_conflicting (mode=3, block=0x7ffff40cc260, heap_no=1, trx=0x7ffff495b478)

Err codemadness.org 70 i 6127

Err codemadness.org 70 i 6131

    at ./storage/innobase/lock/lock0lock.cc:1186

Err codemadness.org 70 i 6132

Err codemadness.org 70 i 6136

#2  0x0000555555ffd37a in lock_rec_lock_slow (impl=0, mode=3, block=0x7ffff40cc260, heap_no=1, index=0x7fff9c112a88, thr=0x7fff9c09ddc8)

Err codemadness.org 70 i 6137

Err codemadness.org 70 i 6141

    at ./storage/innobase/lock/lock0lock.cc:2097

Err codemadness.org 70 i 6142

Err codemadness.org 70 i 6146

#3  0x0000555555ffd676 in lock_rec_lock (impl=false, mode=3, block=0x7ffff40cc260, heap_no=1, index=0x7fff9c112a88, thr=0x7fff9c09ddc8)

Err codemadness.org 70 i 6147

Err codemadness.org 70 i 6151

    at ./storage/innobase/lock/lock0lock.cc:2169

Err codemadness.org 70 i 6152

Err codemadness.org 70 i 6156

#4  0x0000555556008124 in lock_clust_rec_read_check_and_lock (flags=0, block=0x7ffff40cc260, rec=0x7ffff45c4070 "supremum", index=0x7fff9c112a88, offsets=0x7fffefccf400, mode=LOCK_X, gap_mode=0,

Err codemadness.org 70 i 6157

Err codemadness.org 70 i 6161

    thr=0x7fff9c09ddc8) at ./storage/innobase/lock/lock0lock.cc:6130

Err codemadness.org 70 i 6162

Err codemadness.org 70 i 6166

#5  0x00005555560e8f67 in sel_set_rec_lock (pcur=0x7fff9c09d590, rec=0x7ffff45c4070 "supremum", index=0x7fff9c112a88, offsets=0x7fffefccf400, mode=3, type=0, thr=0x7fff9c09ddc8,

Err codemadness.org 70 i 6167

Err codemadness.org 70 i 6171

    mtr=0x7fffefccf7e0) at ./storage/innobase/row/row0sel.cc:1261

Err codemadness.org 70 i 6172

Err codemadness.org 70 i 6176

#6  0x00005555560f07db in row_search_mvcc (buf=0x7fff9c0a0110 "\377", mode=PAGE_CUR_G, prebuilt=0x7fff9c09d3c8, match_mode=0, direction=0)

Err codemadness.org 70 i 6177

Err codemadness.org 70 i 6181

    at ./storage/innobase/row/row0sel.cc:4835	Err	codemadness.org	70
i  6182

Err codemadness.org 70 i 6183

Err codemadness.org 70 i 6187

Err codemadness.org 70 i 6188

Err codemadness.org 70 i 6189 Err codemadness.org 70 i 6190

Let's look at the following code in lock_rec_has_to_wait():

Err codemadness.org 70 i 6191

Err codemadness.org 70 i 6192

Err codemadness.org 70 i 6193 Err codemadness.org 70 i 6194 Err codemadness.org 70 i 6195 Err codemadness.org 70 i 6196 Err codemadness.org 70 i 6199 Err codemadness.org 70 i 6200 Err codemadness.org 70 i 6201 Err codemadness.org 70 i 6204 Err codemadness.org 70 i 6205 Err codemadness.org 70 i 6206 Err codemadness.org 70 i 6209 Err codemadness.org 70 i 6210 Err codemadness.org 70 i 6211 Err codemadness.org 70 i 6214 Err codemadness.org 70 i 6215 Err codemadness.org 70 i 6216 Err codemadness.org 70 i 6219 Err codemadness.org 70 i 6220 Err codemadness.org 70 i 6221 Err codemadness.org 70 i 6224 Err codemadness.org 70 i 6225 Err codemadness.org 70 i 6226 Err codemadness.org 70 i 6229 Err codemadness.org 70 i 6230 Err codemadness.org 70 i 6231 Err codemadness.org 70 i 6234 Err codemadness.org 70 i 6235 Err codemadness.org 70 i 6236 Err codemadness.org 70 i 6239 Err codemadness.org 70 i 6240 Err codemadness.org 70 i 6241 Err codemadness.org 70 i 6244 Err codemadness.org 70 i 6245 Err codemadness.org 70 i 6246 Err codemadness.org 70 i 6249 Err codemadness.org 70 i 6250 Err codemadness.org 70 i 6251 Err codemadness.org 70 i 6254 Err codemadness.org 70 i 6255 Err codemadness.org 70 i 6256 Err codemadness.org 70 i 6259 Err codemadness.org 70 i 6260 Err codemadness.org 70 i 6261 Err codemadness.org 70 i 6264 Err codemadness.org 70 i 6265 Err codemadness.org 70 i 6266 Err codemadness.org 70 i 6269 Err codemadness.org 70 i 6270 Err codemadness.org 70 i 6271 Err codemadness.org 70 i 6274 Err codemadness.org 70 i 6275 Err codemadness.org 70 i 6276 Err codemadness.org 70 i 6279 Err codemadness.org 70 i 6280 Err codemadness.org 70 i 6281 Err codemadness.org 70 i 6284 Err codemadness.org 70 i 6285 Err codemadness.org 70 i 6286 Err codemadness.org 70 i 6290 Err codemadness.org 70 i 6291 Err codemadness.org 70 i 6292

Err codemadness.org 70 i 6197

...

Err codemadness.org 70 i 6198

Err codemadness.org 70 i 6202

lock_rec_has_to_wait()

Err codemadness.org 70 i 6203

Err codemadness.org 70 i 6207

Err codemadness.org 70 i 6208

Err codemadness.org 70 i 6212

...

Err codemadness.org 70 i 6213

Err codemadness.org 70 i 6217

                /* We have somewhat complex rules when gap type record locks

Err codemadness.org 70 i 6218

Err codemadness.org 70 i 6222

                cause waits */

Err codemadness.org 70 i 6223

Err codemadness.org 70 i 6227

Err codemadness.org 70 i 6228

Err codemadness.org 70 i 6232

                if ((lock_is_on_supremum || (type_mode & LOCK_GAP))

Err codemadness.org 70 i 6233

Err codemadness.org 70 i 6237

                    && !(type_mode & LOCK_INSERT_INTENTION)) {

Err codemadness.org 70 i 6238

Err codemadness.org 70 i 6242

Err codemadness.org 70 i 6243

Err codemadness.org 70 i 6247

                        /* Gap type locks without LOCK_INSERT_INTENTION flag

Err codemadness.org 70 i 6248

Err codemadness.org 70 i 6252

                        do not need to wait for anything. This is because

Err codemadness.org 70 i 6253

Err codemadness.org 70 i 6257

                        different users can have conflicting lock types

Err codemadness.org 70 i 6258

Err codemadness.org 70 i 6262

                        on gaps. */

Err codemadness.org 70 i 6263

Err codemadness.org 70 i 6267

Err codemadness.org 70 i 6268

Err codemadness.org 70 i 6272

                        return(FALSE);

Err codemadness.org 70 i 6273

Err codemadness.org 70 i 6277

Err codemadness.org 70 i 6278

Err codemadness.org 70 i 6282

...

Err codemadness.org 70 i 6283

Err codemadness.org 70 i 6287

}	Err	codemadness.org	70
i  6288

Err codemadness.org 70 i 6289

Err codemadness.org 70 i 6293

Err codemadness.org 70 i 6294

Err codemadness.org 70 i 6295 Err codemadness.org 70 i 6296

As locks on supremum are considered as gap locks, and gap locks without LOCK_INSERT_INTENTION flag are not conflicting, then the above code and behaviour are correct.

Err codemadness.org 70 i 6297 Err codemadness.org 70 i 6298

Note if we try to insert some record in the table after delete marked (10) is purged, the "insert" will be locked as expected even if we don't invoke lock_rec_inherit_to_gap() for delete marked (10) from purge thread, because the first "select" set lock on supremum. As well I would add, that even if we invoke lock_rec_inherit_to_gap() from purge thread, it will not add new lock for supremum and for (30) in the previous test, because it does not create new lock if it already exists, so there is no need to change the code here.

Err codemadness.org 70 i 6299 Err codemadness.org 70 i 6300

I have not yet checked the behaviour on "rollback", but the above allows to claim, that the test for the root case is wrong and the requested functionality is already implemented.

Err codemadness.org 70 i 6301

Err codemadness.org 70 i 6303 Comment by Err codemadness.org 70 i 6304 Marko Mäkelä Err codemadness.org 70 i 6305 Err codemadness.org 70 i 6306 [ Err codemadness.org 70 i 6307 2019-12-20 Err codemadness.org 70 i 6308 Err codemadness.org 70 i 6309 ] Err codemadness.org 70 i 6310 Err codemadness.org 70 i 6311 Err codemadness.org 70 i 6312

Err codemadness.org 70 i 6314

A few quick observations:

Err codemadness.org 70 i 6315

The SQL snippets that I posted in this ticket are not the original simplified test case, but something that attempted (and failed) to simplify that test case even further. That test case that I analyzed involves replication and is not completely deterministic.
The fact that the row_search_mvcc() function is acquiring locks on delete-marked records and preceding gaps seems to give us permission to remove the lock_rec_inherit_to_gap() calls from purge, and probably also rollback and all other cases.
The function row_sel() duplicates the logic for the InnoDB internal SQL parser, which is used for updating InnoDB data dictionary statistics, persistent index cardinality statistics, and fulltext indexes. We must ensure that the locking works in the same way in both functions. Both functions are used for locking SELECT as well as UPDATE and DELETE (which is an update of the delete-mark flag).
As hinted in ~~MDEV-14589~~ and MySQL Bug #19762, ideally InnoDB should not lock delete-marked records themselves, but make it appear so that a contiguous gap lock exists all the way from the preceding record to the next visible and committed record, or to the end of the index.
Note: In ~~MDEV-14589~~ we only fixed a special case of "InnoDB should not lock a delete-marked record". Bogus deadlocks are still possible in other cases.

Err codemadness.org 70 i 6322 Err codemadness.org 70 i 6323 Err codemadness.org 70 i 6324

My observation on 2019-10-09 suggests that it is necessary to remove some lock_rec_inherit_to_gap() calls to fix the scenario that I analyzed:

Err codemadness.org 70 i 6325

Err codemadness.org 70 i 6326
The InnoDB purge thread seems to be wrongly converting a waiting gap lock request that is attached to a purgeable record, to a granted gap lock request on the page supremum.

Err codemadness.org 70 i 6327 Err codemadness.org 70 i 6328

It may be the case that in order to fix the problems, we do not only have to remove lock_rec_inherit_to_gap(), but also actually fix ~~MDEV-14589~~ in all cases. That is, we may have to introduce a new gap lock mode that is not considered to lock the committed delete-marked record itself, but instead lock a contiguous gap. For example, if we have the keys (a),(b),(c),(d) in the index and (b) is a committed delete-marked record, and we are doing a locking read of the range between (a) and (c), currently we would acquire{{LOCK_REC_NOT_GAP}} on (a) and LOCK_ORDINARY on both (b) and (c). Perhaps we should acquire a special type of gap record on the delete-marked record (b) that says that (b) itself is not locked. In this way, there would be no bogus locking conflict on (b), if multiple transactions are trying to delete or update (b), which has already been deleted but not purged. Once (b) is finally purged, there should be absolutely no observable change to the gap locks; we would hold a contiguous gap lock that covers the range (a) to (c). Remember: multiple 'read gaps' or 'write gaps' can be acquired on any given gap, as long as all gap locks are of the same type. Implementing this fix might benefit from refactoring the data structures, as suggested in MDEV-16406.

Err codemadness.org 70 i 6329

Err codemadness.org 70 i 6331 Comment by Err codemadness.org 70 i 6332 Marko Mäkelä Err codemadness.org 70 i 6333 Err codemadness.org 70 i 6334 [ Err codemadness.org 70 i 6335 2019-12-20 Err codemadness.org 70 i 6336 Err codemadness.org 70 i 6337 ] Err codemadness.org 70 i 6338 Err codemadness.org 70 i 6339 Err codemadness.org 70 i 6340

Err codemadness.org 70 i 6342

Further observations:

Err codemadness.org 70 i 6343 If we fully fix ~~MDEV-14589~~, then there never should be a lock on a delete-marked record itself, but only a ‘redundant’ gap lock that is by design (of row_search_mvcc() and row_sel()) guaranteed to extend to a gap lock on the following record. Thus, if rollback or purge removes such a purgable record, it will not need to wake up any waiting transactions, and also that wake-up code should be removed.

Err codemadness.org 70 i 6344 Err codemadness.org 70 i 6345

A full fix of ~~MDEV-14589~~ requires ensuring that read-gap and write-gap locks are mutually exclusive. Let me illustrate this with a .test file:

Err codemadness.org 70 i 6346

Err codemadness.org 70 i 6347

Err codemadness.org 70 i 6348 Err codemadness.org 70 i 6349 Err codemadness.org 70 i 6350 Err codemadness.org 70 i 6351 Err codemadness.org 70 i 6354 Err codemadness.org 70 i 6355 Err codemadness.org 70 i 6356 Err codemadness.org 70 i 6359 Err codemadness.org 70 i 6360 Err codemadness.org 70 i 6361 Err codemadness.org 70 i 6364 Err codemadness.org 70 i 6365 Err codemadness.org 70 i 6366 Err codemadness.org 70 i 6369 Err codemadness.org 70 i 6370 Err codemadness.org 70 i 6371 Err codemadness.org 70 i 6374 Err codemadness.org 70 i 6375 Err codemadness.org 70 i 6376 Err codemadness.org 70 i 6379 Err codemadness.org 70 i 6380 Err codemadness.org 70 i 6381 Err codemadness.org 70 i 6384 Err codemadness.org 70 i 6385 Err codemadness.org 70 i 6386 Err codemadness.org 70 i 6389 Err codemadness.org 70 i 6390 Err codemadness.org 70 i 6391 Err codemadness.org 70 i 6394 Err codemadness.org 70 i 6395 Err codemadness.org 70 i 6396 Err codemadness.org 70 i 6399 Err codemadness.org 70 i 6400 Err codemadness.org 70 i 6401 Err codemadness.org 70 i 6404 Err codemadness.org 70 i 6405 Err codemadness.org 70 i 6406 Err codemadness.org 70 i 6409 Err codemadness.org 70 i 6410 Err codemadness.org 70 i 6411 Err codemadness.org 70 i 6414 Err codemadness.org 70 i 6415 Err codemadness.org 70 i 6416 Err codemadness.org 70 i 6419 Err codemadness.org 70 i 6420 Err codemadness.org 70 i 6421 Err codemadness.org 70 i 6424 Err codemadness.org 70 i 6425 Err codemadness.org 70 i 6426 Err codemadness.org 70 i 6429 Err codemadness.org 70 i 6430 Err codemadness.org 70 i 6431 Err codemadness.org 70 i 6434 Err codemadness.org 70 i 6435 Err codemadness.org 70 i 6436 Err codemadness.org 70 i 6439 Err codemadness.org 70 i 6440 Err codemadness.org 70 i 6441 Err codemadness.org 70 i 6444 Err codemadness.org 70 i 6445 Err codemadness.org 70 i 6446 Err codemadness.org 70 i 6449 Err codemadness.org 70 i 6450 Err codemadness.org 70 i 6451 Err codemadness.org 70 i 6454 Err codemadness.org 70 i 6455 Err codemadness.org 70 i 6456 Err codemadness.org 70 i 6459 Err codemadness.org 70 i 6460 Err codemadness.org 70 i 6461 Err codemadness.org 70 i 6464 Err codemadness.org 70 i 6465 Err codemadness.org 70 i 6466 Err codemadness.org 70 i 6469 Err codemadness.org 70 i 6470 Err codemadness.org 70 i 6471 Err codemadness.org 70 i 6474 Err codemadness.org 70 i 6475 Err codemadness.org 70 i 6476 Err codemadness.org 70 i 6479 Err codemadness.org 70 i 6480 Err codemadness.org 70 i 6481 Err codemadness.org 70 i 6484 Err codemadness.org 70 i 6485 Err codemadness.org 70 i 6486 Err codemadness.org 70 i 6489 Err codemadness.org 70 i 6490 Err codemadness.org 70 i 6491 Err codemadness.org 70 i 6494 Err codemadness.org 70 i 6495 Err codemadness.org 70 i 6496 Err codemadness.org 70 i 6499 Err codemadness.org 70 i 6500 Err codemadness.org 70 i 6501 Err codemadness.org 70 i 6504 Err codemadness.org 70 i 6505 Err codemadness.org 70 i 6506 Err codemadness.org 70 i 6509 Err codemadness.org 70 i 6510 Err codemadness.org 70 i 6511 Err codemadness.org 70 i 6514 Err codemadness.org 70 i 6515 Err codemadness.org 70 i 6516 Err codemadness.org 70 i 6519 Err codemadness.org 70 i 6520 Err codemadness.org 70 i 6521 Err codemadness.org 70 i 6524 Err codemadness.org 70 i 6525 Err codemadness.org 70 i 6526 Err codemadness.org 70 i 6529 Err codemadness.org 70 i 6530 Err codemadness.org 70 i 6531 Err codemadness.org 70 i 6535 Err codemadness.org 70 i 6536 Err codemadness.org 70 i 6537

Err codemadness.org 70 i 6352

--source include/have_innodb.inc

Err codemadness.org 70 i 6353

Err codemadness.org 70 i 6357

SET @saved_frequency = @@GLOBAL.innodb_purge_rseg_truncate_frequency;

Err codemadness.org 70 i 6358

Err codemadness.org 70 i 6362

SET GLOBAL innodb_purge_rseg_truncate_frequency = 1;

Err codemadness.org 70 i 6363

Err codemadness.org 70 i 6367

Err codemadness.org 70 i 6368

Err codemadness.org 70 i 6372

let $show_hang=0;

Err codemadness.org 70 i 6373

Err codemadness.org 70 i 6377

--echo # let show_hang=1;

Err codemadness.org 70 i 6378

Err codemadness.org 70 i 6382

Err codemadness.org 70 i 6383

Err codemadness.org 70 i 6387

create table t(k tinyint unsigned primary key) engine=innodb;

Err codemadness.org 70 i 6388

Err codemadness.org 70 i 6392

connect (prevent_purge,localhost,root,,);

Err codemadness.org 70 i 6393

Err codemadness.org 70 i 6397

start transaction with consistent snapshot;

Err codemadness.org 70 i 6398

Err codemadness.org 70 i 6402

connection default;

Err codemadness.org 70 i 6403

Err codemadness.org 70 i 6407

begin;

Err codemadness.org 70 i 6408

Err codemadness.org 70 i 6412

insert into t values (0),(5),(9),(13);

Err codemadness.org 70 i 6413

Err codemadness.org 70 i 6417

delete from t where k=5 or k=9;

Err codemadness.org 70 i 6418

Err codemadness.org 70 i 6422

commit;

Err codemadness.org 70 i 6423

Err codemadness.org 70 i 6427

begin;

Err codemadness.org 70 i 6428

Err codemadness.org 70 i 6432

insert into t values(3);

Err codemadness.org 70 i 6433

Err codemadness.org 70 i 6437

connect (con1,localhost,root,,);

Err codemadness.org 70 i 6438

Err codemadness.org 70 i 6442

set transaction isolation level serializable;

Err codemadness.org 70 i 6443

Err codemadness.org 70 i 6447

begin;

Err codemadness.org 70 i 6448

Err codemadness.org 70 i 6452

select * from t where k=6;

Err codemadness.org 70 i 6453

Err codemadness.org 70 i 6457

connection default;

Err codemadness.org 70 i 6458

Err codemadness.org 70 i 6462

if ($show_hang) {

Err codemadness.org 70 i 6463

Err codemadness.org 70 i 6467

disconnect prevent_purge;

Err codemadness.org 70 i 6468

Err codemadness.org 70 i 6472

--source include/wait_all_purged.inc

Err codemadness.org 70 i 6473

Err codemadness.org 70 i 6477

Err codemadness.org 70 i 6478

Err codemadness.org 70 i 6482

insert into t values(10);

Err codemadness.org 70 i 6483

Err codemadness.org 70 i 6487

if (!$show_hang) {

Err codemadness.org 70 i 6488

Err codemadness.org 70 i 6492

disconnect prevent_purge;

Err codemadness.org 70 i 6493

Err codemadness.org 70 i 6497

--source include/wait_all_purged.inc

Err codemadness.org 70 i 6498

Err codemadness.org 70 i 6502

Err codemadness.org 70 i 6503

Err codemadness.org 70 i 6507

disconnect con1;

Err codemadness.org 70 i 6508

Err codemadness.org 70 i 6512

connection default;

Err codemadness.org 70 i 6513

Err codemadness.org 70 i 6517

rollback;

Err codemadness.org 70 i 6518

Err codemadness.org 70 i 6522

select * from t;

Err codemadness.org 70 i 6523

Err codemadness.org 70 i 6527

drop table t;

Err codemadness.org 70 i 6528

Err codemadness.org 70 i 6532

SET GLOBAL innodb_purge_rseg_truncate_frequency = @saved_frequency;	Err	codemadness.org	70
i  6533

Err codemadness.org 70 i 6534

Err codemadness.org 70 i 6538

Err codemadness.org 70 i 6539

Err codemadness.org 70 i 6540

I was actually expecting that the SELECT would block due to the preceding INSERT, but that is not the case, even if the DELETE statement is removed or the condition k=6 is replaced with anything else than k=3. Only if I change the condition to use >=, such as k>=10, there will be a locking conflict on record heap number 6, which is the record k=3. This is apparently because of an optimizer misfeature that appears to prefer a full table scan over range scans for small tables.

Err codemadness.org 70 i 6541 Err codemadness.org 70 i 6542

Vladislav Lesin, for a complete understanding of this, I hope that you can determine when exactly INSERT is acquiring write-gap locks. I think that in the basic case, INSERT relies solely on implicit locking (no record locks). If the INSERT were acquiring a write-gap lock, then it obviously should block a later locking read operation with k=4, because that key would fall within the same gap.

Err codemadness.org 70 i 6543 Err codemadness.org 70 i 6544

Anyway, the last INSERT after the locking SELECT is showing the problem that I wanted to illustrate. As long as the delete-marked record k=5 exists, the last INSERT can proceed. If the record k=5 is purged while both transactions are active, then we will have both a write-gap and read-gap lock on the remaining gap, which is a violation of the gap locking rules!

Err codemadness.org 70 i 6545 Err codemadness.org 70 i 6546

I think that replication (as well as some users) can reasonably expect locking to be completely agnostic to the purge of history. Fixing this (that is, ensuring that the SELECT and INSERT will conflict no matter if delete-marked records exist between them) might introduce more locking conflicts, so we might want to introduce a configuration option (or abuse innodb_locks_unsafe_for_binlog) to enable the old non-conflicting gap locking. Note: that deprecated option was removed from MariaDB Server 10.5.0 in ~~MDEV-19544~~.

Err codemadness.org 70 i 6547

Err codemadness.org 70 i 6549 Comment by Err codemadness.org 70 i 6550 Vladislav Lesin Err codemadness.org 70 i 6551 Err codemadness.org 70 i 6552 [ Err codemadness.org 70 i 6553 2020-01-09 Err codemadness.org 70 i 6554 Err codemadness.org 70 i 6555 ] Err codemadness.org 70 i 6556 Err codemadness.org 70 i 6557 Err codemadness.org 70 i 6558

Err codemadness.org 70 i 6560

The above test shows the problem. The following is the explanation why the last INSERT is locked after purge and is not locked before purge.

Err codemadness.org 70 i 6561 Err codemadness.org 70 i 6562 Err codemadness.org 70 i 6563

1. Connection "default", repeatable read, "insert into t values(3)":

Err codemadness.org 70 i 6564

Err codemadness.org 70 i 6565

Err codemadness.org 70 i 6566 Err codemadness.org 70 i 6567 Err codemadness.org 70 i 6568 Err codemadness.org 70 i 6569 Err codemadness.org 70 i 6573 Err codemadness.org 70 i 6574 Err codemadness.org 70 i 6575

Err codemadness.org 70 i 6570

(0)...(3 - just inserted, X-lock)...(5 - dmc)...(9 - dmc)...(13)	Err	codemadness.org	70
i  6571

Err codemadness.org 70 i 6572

Err codemadness.org 70 i 6576

Err codemadness.org 70 i 6577

Err codemadness.org 70 i 6578

where dmc - delete-marked committed

Err codemadness.org 70 i 6579 Err codemadness.org 70 i 6580 Err codemadness.org 70 i 6581

2. Connection "con1", serializable, "select * from t where k=6":

Err codemadness.org 70 i 6582

Err codemadness.org 70 i 6583

Err codemadness.org 70 i 6584 Err codemadness.org 70 i 6585 Err codemadness.org 70 i 6586 Err codemadness.org 70 i 6587 Err codemadness.org 70 i 6591 Err codemadness.org 70 i 6592 Err codemadness.org 70 i 6593

Err codemadness.org 70 i 6588

(0)...(3 - X-lock)...(5 - dmc)...(9 - dmc, gap S-lock)...(13)	Err	codemadness.org	70
i  6589

Err codemadness.org 70 i 6590

Err codemadness.org 70 i 6594

Err codemadness.org 70 i 6595

Err codemadness.org 70 i 6596

The lock on (9) is set with the following backtrace:

Err codemadness.org 70 i 6597

Err codemadness.org 70 i 6598

Err codemadness.org 70 i 6599 Err codemadness.org 70 i 6600 Err codemadness.org 70 i 6601 Err codemadness.org 70 i 6602 Err codemadness.org 70 i 6605 Err codemadness.org 70 i 6606 Err codemadness.org 70 i 6607 Err codemadness.org 70 i 6610 Err codemadness.org 70 i 6611 Err codemadness.org 70 i 6612 Err codemadness.org 70 i 6615 Err codemadness.org 70 i 6616 Err codemadness.org 70 i 6617 Err codemadness.org 70 i 6620 Err codemadness.org 70 i 6621 Err codemadness.org 70 i 6622 Err codemadness.org 70 i 6625 Err codemadness.org 70 i 6626 Err codemadness.org 70 i 6627 Err codemadness.org 70 i 6630 Err codemadness.org 70 i 6631 Err codemadness.org 70 i 6632 Err codemadness.org 70 i 6635 Err codemadness.org 70 i 6636 Err codemadness.org 70 i 6637 Err codemadness.org 70 i 6640 Err codemadness.org 70 i 6641 Err codemadness.org 70 i 6642 Err codemadness.org 70 i 6645 Err codemadness.org 70 i 6646 Err codemadness.org 70 i 6647 Err codemadness.org 70 i 6650 Err codemadness.org 70 i 6651 Err codemadness.org 70 i 6652 Err codemadness.org 70 i 6655 Err codemadness.org 70 i 6656 Err codemadness.org 70 i 6657 Err codemadness.org 70 i 6661 Err codemadness.org 70 i 6662 Err codemadness.org 70 i 6663

Err codemadness.org 70 i 6603

 #0  lock_rec_lock (impl=false, mode=514, block=0x7ffff40cc260, heap_no=4, index=0x7fff9c02c468, thr=0x7fff9c02e5a8)

Err codemadness.org 70 i 6604

Err codemadness.org 70 i 6608

     at ./storage/innobase/lock/lock0lock.cc:2148

Err codemadness.org 70 i 6609

Err codemadness.org 70 i 6613

 #1  0x00005555560081f4 in lock_clust_rec_read_check_and_lock (flags=0, block=0x7ffff40cc260, rec=0x7ffff45c40a3 "\t", index=0x7fff9c02c468,

Err codemadness.org 70 i 6614

Err codemadness.org 70 i 6618

     offsets=0x7fffefd1a140, mode=LOCK_S, gap_mode=512, thr=0x7fff9c02e5a8)

Err codemadness.org 70 i 6619

Err codemadness.org 70 i 6623

     at ./storage/innobase/lock/lock0lock.cc:6130

Err codemadness.org 70 i 6624

Err codemadness.org 70 i 6628

 #2  0x00005555560e93e4 in sel_set_rec_lock (pcur=0x7fff9c02dd70, rec=0x7ffff45c40a3 "\t", index=0x7fff9c02c468, offsets=0x7fffefd1a140, mode=2,

Err codemadness.org 70 i 6629

Err codemadness.org 70 i 6633

     type=512, thr=0x7fff9c02e5a8, mtr=0x7fffefd1a520)

Err codemadness.org 70 i 6634

Err codemadness.org 70 i 6638

     at ./storage/innobase/row/row0sel.cc:1261

Err codemadness.org 70 i 6639

Err codemadness.org 70 i 6643

 #3  0x00005555560f143f in row_search_mvcc (buf=0x7fff9c09dac0 "\377", mode=PAGE_CUR_GE, prebuilt=0x7fff9c02dba8, match_mode=1, direction=0)

Err codemadness.org 70 i 6644

Err codemadness.org 70 i 6648

     at ./storage/innobase/row/row0sel.cc:4968

Err codemadness.org 70 i 6649

Err codemadness.org 70 i 6653

 #4  0x0000555555f87f67 in ha_innobase::index_read (this=0x7fff9c09df18, buf=0x7fff9c09dac0 "\377", key_ptr=0x7fff8c013920 "\006", key_len=1,

Err codemadness.org 70 i 6654

Err codemadness.org 70 i 6658

     find_flag=HA_READ_KEY_EXACT) at ./storage/innobase/handler/ha_innodb.cc:9469	Err	codemadness.org	70
i  6659

Err codemadness.org 70 i 6660

Err codemadness.org 70 i 6664

Err codemadness.org 70 i 6665

Err codemadness.org 70 i 6666 Err codemadness.org 70 i 6667 Err codemadness.org 70 i 6668 Err codemadness.org 70 i 6669

3. Connection "default", repeatable read, "insert into t values(10)":

Err codemadness.org 70 i 6670 Err codemadness.org 70 i 6671 Err codemadness.org 70 i 6672

a) before purge

Err codemadness.org 70 i 6673

Err codemadness.org 70 i 6674

Err codemadness.org 70 i 6675 Err codemadness.org 70 i 6676 Err codemadness.org 70 i 6677 Err codemadness.org 70 i 6678 Err codemadness.org 70 i 6682 Err codemadness.org 70 i 6683 Err codemadness.org 70 i 6684

Err codemadness.org 70 i 6679

(0)...(3 - X-lock)...(5 - dmc)...(9 - dmc, gap S-lock)...(10 - just inserted, X-lock)...(13)	Err	codemadness.org	70
i  6680

Err codemadness.org 70 i 6681

Err codemadness.org 70 i 6685

Err codemadness.org 70 i 6686

Err codemadness.org 70 i 6687

(10) is inserted as there is no gap lock on (13)

Err codemadness.org 70 i 6688 Err codemadness.org 70 i 6689 Err codemadness.org 70 i 6690

b) after purge

Err codemadness.org 70 i 6691

Err codemadness.org 70 i 6692

Err codemadness.org 70 i 6693 Err codemadness.org 70 i 6694 Err codemadness.org 70 i 6695 Err codemadness.org 70 i 6696 Err codemadness.org 70 i 6699 Err codemadness.org 70 i 6700 Err codemadness.org 70 i 6701 Err codemadness.org 70 i 6705 Err codemadness.org 70 i 6706 Err codemadness.org 70 i 6707

Err codemadness.org 70 i 6697

(0)...(3 - X-lock)...(13 - gap S-lock inherited from purged 9)

Err codemadness.org 70 i 6698

Err codemadness.org 70 i 6702

                  ^^^(10) can't be inserted as there is gap S-lock on (13)	Err	codemadness.org	70
i  6703

Err codemadness.org 70 i 6704

Err codemadness.org 70 i 6708

Err codemadness.org 70 i 6709

Err codemadness.org 70 i 6710 Err codemadness.org 70 i 6711 Err codemadness.org 70 i 6712

As we can see, the problem is that gap locks on delete-marked records are not propagated till their non-delete-marked successors for point queries:

Err codemadness.org 70 i 6713

Err codemadness.org 70 i 6714

Err codemadness.org 70 i 6715 Err codemadness.org 70 i 6716 Err codemadness.org 70 i 6717 Err codemadness.org 70 i 6718 Err codemadness.org 70 i 6721 Err codemadness.org 70 i 6722 Err codemadness.org 70 i 6723 Err codemadness.org 70 i 6726 Err codemadness.org 70 i 6727 Err codemadness.org 70 i 6728 Err codemadness.org 70 i 6731 Err codemadness.org 70 i 6732 Err codemadness.org 70 i 6733 Err codemadness.org 70 i 6736 Err codemadness.org 70 i 6737 Err codemadness.org 70 i 6738 Err codemadness.org 70 i 6741 Err codemadness.org 70 i 6742 Err codemadness.org 70 i 6743 Err codemadness.org 70 i 6746 Err codemadness.org 70 i 6747 Err codemadness.org 70 i 6748 Err codemadness.org 70 i 6751 Err codemadness.org 70 i 6752 Err codemadness.org 70 i 6753 Err codemadness.org 70 i 6756 Err codemadness.org 70 i 6757 Err codemadness.org 70 i 6758 Err codemadness.org 70 i 6761 Err codemadness.org 70 i 6762 Err codemadness.org 70 i 6763 Err codemadness.org 70 i 6766 Err codemadness.org 70 i 6767 Err codemadness.org 70 i 6768 Err codemadness.org 70 i 6771 Err codemadness.org 70 i 6772 Err codemadness.org 70 i 6773 Err codemadness.org 70 i 6776 Err codemadness.org 70 i 6777 Err codemadness.org 70 i 6778 Err codemadness.org 70 i 6781 Err codemadness.org 70 i 6782 Err codemadness.org 70 i 6783 Err codemadness.org 70 i 6786 Err codemadness.org 70 i 6787 Err codemadness.org 70 i 6788 Err codemadness.org 70 i 6791 Err codemadness.org 70 i 6792 Err codemadness.org 70 i 6793 Err codemadness.org 70 i 6796 Err codemadness.org 70 i 6797 Err codemadness.org 70 i 6798 Err codemadness.org 70 i 6801 Err codemadness.org 70 i 6802 Err codemadness.org 70 i 6803 Err codemadness.org 70 i 6806 Err codemadness.org 70 i 6807 Err codemadness.org 70 i 6808 Err codemadness.org 70 i 6811 Err codemadness.org 70 i 6812 Err codemadness.org 70 i 6813 Err codemadness.org 70 i 6816 Err codemadness.org 70 i 6817 Err codemadness.org 70 i 6818 Err codemadness.org 70 i 6821 Err codemadness.org 70 i 6822 Err codemadness.org 70 i 6823 Err codemadness.org 70 i 6826 Err codemadness.org 70 i 6827 Err codemadness.org 70 i 6828 Err codemadness.org 70 i 6831 Err codemadness.org 70 i 6832 Err codemadness.org 70 i 6833 Err codemadness.org 70 i 6836 Err codemadness.org 70 i 6837 Err codemadness.org 70 i 6838 Err codemadness.org 70 i 6842 Err codemadness.org 70 i 6843 Err codemadness.org 70 i 6844

Err codemadness.org 70 i 6719

dberr_t

Err codemadness.org 70 i 6720

Err codemadness.org 70 i 6724

row_search_mvcc(...)

Err codemadness.org 70 i 6725

Err codemadness.org 70 i 6729

Err codemadness.org 70 i 6730

Err codemadness.org 70 i 6734

...

Err codemadness.org 70 i 6735

Err codemadness.org 70 i 6739

        if (match_mode == ROW_SEL_EXACT) {

Err codemadness.org 70 i 6740

Err codemadness.org 70 i 6744

...

Err codemadness.org 70 i 6745

Err codemadness.org 70 i 6749

                                err = sel_set_rec_lock(

Err codemadness.org 70 i 6750

Err codemadness.org 70 i 6754

                                        pcur,

Err codemadness.org 70 i 6755

Err codemadness.org 70 i 6759

                                        rec, index, offsets,

Err codemadness.org 70 i 6760

Err codemadness.org 70 i 6764

                                        prebuilt->select_lock_type, LOCK_GAP,

Err codemadness.org 70 i 6765

Err codemadness.org 70 i 6769

                                        thr, &mtr);

Err codemadness.org 70 i 6770

Err codemadness.org 70 i 6774

...

Err codemadness.org 70 i 6775

Err codemadness.org 70 i 6779

                        goto normal_return;

Err codemadness.org 70 i 6780

Err codemadness.org 70 i 6784

          } else if (match_mode == ROW_SEL_EXACT_PREFIX) {

Err codemadness.org 70 i 6785

Err codemadness.org 70 i 6789

...

Err codemadness.org 70 i 6790

Err codemadness.org 70 i 6794

                                err = sel_set_rec_lock(

Err codemadness.org 70 i 6795

Err codemadness.org 70 i 6799

                                        pcur,

Err codemadness.org 70 i 6800

Err codemadness.org 70 i 6804

                                        rec, index, offsets,

Err codemadness.org 70 i 6805

Err codemadness.org 70 i 6809

                                        prebuilt->select_lock_type, LOCK_GAP,

Err codemadness.org 70 i 6810

Err codemadness.org 70 i 6814

                                        thr, &mtr);

Err codemadness.org 70 i 6815

Err codemadness.org 70 i 6819

...

Err codemadness.org 70 i 6820

Err codemadness.org 70 i 6824

                        goto normal_return;

Err codemadness.org 70 i 6825

Err codemadness.org 70 i 6829

Err codemadness.org 70 i 6830

Err codemadness.org 70 i 6834

...

Err codemadness.org 70 i 6835

Err codemadness.org 70 i 6839

}	Err	codemadness.org	70
i  6840

Err codemadness.org 70 i 6841

Err codemadness.org 70 i 6845

Err codemadness.org 70 i 6846

Err codemadness.org 70 i 6847

Err codemadness.org 70 i 6849 Comment by Err codemadness.org 70 i 6850 Marko Mäkelä Err codemadness.org 70 i 6851 Err codemadness.org 70 i 6852 [ Err codemadness.org 70 i 6853 2020-08-12 Err codemadness.org 70 i 6854 Err codemadness.org 70 i 6855 ] Err codemadness.org 70 i 6856 Err codemadness.org 70 i 6857 Err codemadness.org 70 i 6858

Err codemadness.org 70 i 6860

I will take over this. But I am afraid that I must address ~~MDEV-23399~~ first. So, this is not truly ‘in progress’ at the moment.

Err codemadness.org 70 i 6861

Err codemadness.org 70 i 6863 Comment by Err codemadness.org 70 i 6864 Vladislav Lesin Err codemadness.org 70 i 6865 Err codemadness.org 70 i 6866 [ Err codemadness.org 70 i 6867 2020-09-14 Err codemadness.org 70 i 6868 Err codemadness.org 70 i 6869 ] Err codemadness.org 70 i 6870 Err codemadness.org 70 i 6871 Err codemadness.org 70 i 6872

Err codemadness.org 70 i 6874

Marko Mäkelä I have just pushed my draft to https://github.com/MariaDB/server/tree/10.2-MDEV-20605-gap-locks-debug.

Err codemadness.org 70 i 6875 Err codemadness.org 70 i 6876

I have implemented and tested changes in row_search_mvcc().

Err codemadness.org 70 i 6877 Err codemadness.org 70 i 6878

I have implemented and not tested changes in row_sel(). I started implementation of system variable to test row_sel(), you can see it in one of the commits.

Err codemadness.org 70 i 6879 Err codemadness.org 70 i 6880

I have implemented changes for foreign key constraints check. But I don't like this implementation, because it's complexity is n*m. See comment in commit message.

Err codemadness.org 70 i 6881 Err codemadness.org 70 i 6882

I have not implemented duplicates check for foreign check.

Err codemadness.org 70 i 6883

Err codemadness.org 70 i 6885 Comment by Err codemadness.org 70 i 6886 Marko Mäkelä Err codemadness.org 70 i 6887 Err codemadness.org 70 i 6888 [ Err codemadness.org 70 i 6889 2021-03-15 Err codemadness.org 70 i 6890 Err codemadness.org 70 i 6891 ] Err codemadness.org 70 i 6892 Err codemadness.org 70 i 6893 Err codemadness.org 70 i 6894

Err codemadness.org 70 i 6896

Sorry for the delay; I was occupied by 10.6 development work.

Err codemadness.org 70 i 6897 Err codemadness.org 70 i 6898

The changes in the 10.2 based branch look mostly OK to me. For testing, I think that we will need a 10.6-based branch.

Err codemadness.org 70 i 6899 Err codemadness.org 70 i 6900

My understanding is that the function row_sel() is never invoked on spatial indexes. It might also be that all locking use of it is for system tables or InnoDB persistent statistics tables. If functions like fts_doc_fetch_by_doc_id() never execute a locking read, then we might not have to modify row_sel() at all.

Err codemadness.org 70 i 6901 Err codemadness.org 70 i 6902

A more thorough description of how gap locks work in the FOREIGN KEY locks will be needed.

Err codemadness.org 70 i 6903 Err codemadness.org 70 i 6904

Also, whenever we check that a record is delete-marked, is it certain that the record has been committed? I am fairly sure that a gap lock can be safely attached to a delete-marked non-committed record.

Err codemadness.org 70 i 6905 Err codemadness.org 70 i 6906

Another related doubt: Is it safe to attach a gap lock to a record that has been inserted by a not-yet-committed transaction? Maybe, in such cases we should always also acquire a lock on the ‘anchor’ record itself (so that we will wait for the transaction commit), and not only on the preceding gap.

Err codemadness.org 70 i 6907 Err codemadness.org 70 i 6908

As part of testing this, I think that we must repeat and analyze the failure of MDEV-22889.

Err codemadness.org 70 i 6909

Err codemadness.org 70 i 6911 Comment by Err codemadness.org 70 i 6912 Larry Adams Err codemadness.org 70 i 6913 Err codemadness.org 70 i 6914 [ Err codemadness.org 70 i 6915 2021-03-17 Err codemadness.org 70 i 6916 Err codemadness.org 70 i 6917 ] Err codemadness.org 70 i 6918 Err codemadness.org 70 i 6919 Err codemadness.org 70 i 6920

Err codemadness.org 70 i 6922

I'm on 10.5.8 and struggling with this problem. The server, in 'optimistic' mode encounters a 1964 error, and the Slave_SQL_Running goes to No, and the whole thing breaks. So, optimistic does not work in 10.5.8. I'm testing with 'conservative', but the slaves are unable to keep up with the master presently. Just watching as I type, I have not seen the Seconds_Behind_Master decrease since I restarted in 'conservative' mode. I'm using the 'mixed' binlog format. Switching to 'row' likely won't help either. We are already generating 5TB of binary log's per day in 'mixed' mode.

Err codemadness.org 70 i 6923

Err codemadness.org 70 i 6925 Comment by Err codemadness.org 70 i 6926 Marko Mäkelä Err codemadness.org 70 i 6927 Err codemadness.org 70 i 6928 [ Err codemadness.org 70 i 6929 2021-03-19 Err codemadness.org 70 i 6930 Err codemadness.org 70 i 6931 ] Err codemadness.org 70 i 6932 Err codemadness.org 70 i 6933 Err codemadness.org 70 i 6934

Err codemadness.org 70 i 6936

I think that the following must be part of the fix:

Err codemadness.org 70 i 6937

Err codemadness.org 70 i 6938

Err codemadness.org 70 i 6939 Err codemadness.org 70 i 6940 Err codemadness.org 70 i 6941 Err codemadness.org 70 i 6942 Err codemadness.org 70 i 6945 Err codemadness.org 70 i 6946 Err codemadness.org 70 i 6947 Err codemadness.org 70 i 6950 Err codemadness.org 70 i 6951 Err codemadness.org 70 i 6952 Err codemadness.org 70 i 6955 Err codemadness.org 70 i 6956 Err codemadness.org 70 i 6957 Err codemadness.org 70 i 6960 Err codemadness.org 70 i 6961 Err codemadness.org 70 i 6962 Err codemadness.org 70 i 6965 Err codemadness.org 70 i 6966 Err codemadness.org 70 i 6967 Err codemadness.org 70 i 6970 Err codemadness.org 70 i 6971 Err codemadness.org 70 i 6972 Err codemadness.org 70 i 6975 Err codemadness.org 70 i 6976 Err codemadness.org 70 i 6977 Err codemadness.org 70 i 6980 Err codemadness.org 70 i 6981 Err codemadness.org 70 i 6982 Err codemadness.org 70 i 6985 Err codemadness.org 70 i 6986 Err codemadness.org 70 i 6987 Err codemadness.org 70 i 6990 Err codemadness.org 70 i 6991 Err codemadness.org 70 i 6992 Err codemadness.org 70 i 6995 Err codemadness.org 70 i 6996 Err codemadness.org 70 i 6997 Err codemadness.org 70 i 7000 Err codemadness.org 70 i 7001 Err codemadness.org 70 i 7002 Err codemadness.org 70 i 7005 Err codemadness.org 70 i 7006 Err codemadness.org 70 i 7007 Err codemadness.org 70 i 7010 Err codemadness.org 70 i 7011 Err codemadness.org 70 i 7012 Err codemadness.org 70 i 7016 Err codemadness.org 70 i 7017 Err codemadness.org 70 i 7018

Err codemadness.org 70 i 6943

diff --git a/storage/innobase/row/row0ins.cc b/storage/innobase/row/row0ins.cc

Err codemadness.org 70 i 6944

Err codemadness.org 70 i 6948

index 635e7f659eb..097b67ca0f0 100644

Err codemadness.org 70 i 6949

Err codemadness.org 70 i 6953

--- a/storage/innobase/row/row0ins.cc

Err codemadness.org 70 i 6954

Err codemadness.org 70 i 6958

+++ b/storage/innobase/row/row0ins.cc

Err codemadness.org 70 i 6959

Err codemadness.org 70 i 6963

@@ -1678,9 +1678,7 @@ row_ins_check_foreign_constraint(

Err codemadness.org 70 i 6964

Err codemadness.org 70 i 6968

                                                             offsets));

Err codemadness.org 70 i 6969

Err codemadness.org 70 i 6973

Err codemadness.org 70 i 6974

Err codemadness.org 70 i 6978

                                 err = row_ins_set_shared_rec_lock(

Err codemadness.org 70 i 6979

Err codemadness.org 70 i 6983

-                                        skip_gap_lock

Err codemadness.org 70 i 6984

Err codemadness.org 70 i 6988

-                                        ? LOCK_REC_NOT_GAP

Err codemadness.org 70 i 6989

Err codemadness.org 70 i 6993

-                                        : LOCK_ORDINARY, block,

Err codemadness.org 70 i 6994

Err codemadness.org 70 i 6998

+                                        LOCK_ORDINARY, block,

Err codemadness.org 70 i 6999

Err codemadness.org 70 i 7003

                                         rec, check_index, offsets, thr);

Err codemadness.org 70 i 7004

Err codemadness.org 70 i 7008

                                 switch (err) {

Err codemadness.org 70 i 7009

Err codemadness.org 70 i 7013

                                 case DB_SUCCESS_LOCKED_REC:	Err	codemadness.org	70
i  7014

Err codemadness.org 70 i 7015

Err codemadness.org 70 i 7019

Err codemadness.org 70 i 7020

Err codemadness.org 70 i 7021

In a FOREIGN KEY check, if we encounter a delete-marked record, we must ensure that the record is committed, by acquiring a lock on both the record and the preceding gap. And if it was the case, we must continue acquiring such locks on succeeding records until the end of the index, or until a record that is not delete-marked. On that non-delete-marked record, we must acquire a gap-only lock. And we must not recurse into that non-delete-marked record, because we already found that the first record was delete-marked.

Err codemadness.org 70 i 7022

Err codemadness.org 70 i 7024 Comment by Err codemadness.org 70 i 7025 Marko Mäkelä Err codemadness.org 70 i 7026 Err codemadness.org 70 i 7027 [ Err codemadness.org 70 i 7028 2021-03-19 Err codemadness.org 70 i 7029 Err codemadness.org 70 i 7030 ] Err codemadness.org 70 i 7031 Err codemadness.org 70 i 7032 Err codemadness.org 70 i 7033

Err codemadness.org 70 i 7035

Why should it suffice to acquire a gap-only lock on that last non-delete-marked record in the traversal in row_ins_check_foreign_constraint()? What if that last record is later delete-marked and committed? Can it be purged, so that the last segment of our gap lock would be widened in purge?

Err codemadness.org 70 i 7036 Err codemadness.org 70 i 7037

The answer is that normally, the transaction that is executing the traversal in row_ins_check_foreign_constraint() has a read view that will be older than a possible future commit of delete-marking the record that was not delete-marked during our traversal. Because purge cannot advance beyond the oldest existing read view, the record could not be purged.

Err codemadness.org 70 i 7038 Err codemadness.org 70 i 7039

However, there are exceptions at two isolation levels:

Err codemadness.org 70 i 7040 READ UNCOMMITTED: The transaction would not have any read view.

Err codemadness.org 70 i 7041 READ COMMITTED: The read view will be reset at statement boundary.

Err codemadness.org 70 i 7042 Err codemadness.org 70 i 7043

In either case, there is nothing that would prevent purge from advancing to that last record. In these cases, it could be simplest to acquire LOCK_ORDINARY on the last segment of the gap (when the anchor record is not delete-marked). That would prevent such a future delete-mark operation from occurring before the gap-owning transaction is committed or rolled back.

Err codemadness.org 70 i 7044

Err codemadness.org 70 i 7046 Comment by Err codemadness.org 70 i 7047 Larry Adams Err codemadness.org 70 i 7048 Err codemadness.org 70 i 7049 [ Err codemadness.org 70 i 7050 2021-03-19 Err codemadness.org 70 i 7051 Err codemadness.org 70 i 7052 ] Err codemadness.org 70 i 7053 Err codemadness.org 70 i 7054 Err codemadness.org 70 i 7055

Err codemadness.org 70 i 7057

Per the recommendation made by others, I switched to ROW. So far so good.

Err codemadness.org 70 i 7058

Err codemadness.org 70 i 7060 Comment by Err codemadness.org 70 i 7061 Marko Mäkelä Err codemadness.org 70 i 7062 Err codemadness.org 70 i 7063 [ Err codemadness.org 70 i 7064 2021-03-22 Err codemadness.org 70 i 7065 Err codemadness.org 70 i 7066 ] Err codemadness.org 70 i 7067 Err codemadness.org 70 i 7068 Err codemadness.org 70 i 7069

Err codemadness.org 70 i 7071

One more thought: In ~~MDEV-19544~~ we finally removed an option that had been deprecated a long time ago:

Err codemadness.org 70 i 7072 Err codemadness.org 70 i 7073

When innodb_locks_unsafe_for_binlog was set, InnoDB would skip gap locking in many cases. The non-descriptive name of the option hints that it was known to break statement-based replication.

Err codemadness.org 70 i 7074 Err codemadness.org 70 i 7075

Later, the option was made redundant by incorporating such logic in the READ UNCOMMITTED and READ COMMITTED isolation levels. That those isolation levels acquire fewer gap locks is expected, as noted in ~~MDEV-24224~~.

Err codemadness.org 70 i 7076 Err codemadness.org 70 i 7077

All this suggests that the limitations that applied to innodb_locks_unsafe_for_binlog=ON will also apply to the READ UNCOMMITTED and READ COMMITTED isolation levels.

Err codemadness.org 70 i 7078 Err codemadness.org 70 i 7079

Having said all this, we definitely do have a problem with the gap locks on delete-marked records that affects the default REPEATABLE READ isolation level.

Err codemadness.org 70 i 7080

Err codemadness.org 70 i 7082 Comment by Err codemadness.org 70 i 7083 Marko Mäkelä Err codemadness.org 70 i 7084 Err codemadness.org 70 i 7085 [ Err codemadness.org 70 i 7086 2021-03-22 Err codemadness.org 70 i 7087 Err codemadness.org 70 i 7088 ] Err codemadness.org 70 i 7089 Err codemadness.org 70 i 7090 Err codemadness.org 70 i 7091

Err codemadness.org 70 i 7093

The option innodb_locks_unsafe_for_binlog was deprecated in MySQL 5.6.3. Already back then, the logic had been incorporated to the READ UNCOMMITTED and READ COMMITTED isolation levels. So, those isolation levels are as unsafe to use with replication as the deprecated setting innodb_locks_unsafe_for_binlog=1. We will not change the reduced acquisition of gap locks in this ticket MDEV-20605 (except when it comes to delete-marked gap anchor records).

Err codemadness.org 70 i 7094 Err codemadness.org 70 i 7095

Note: I do not know what exactly was or is unsafe about innodb_locks_unsafe_for_binlog. I hope that Andrei Elkin can shed light on that.

Err codemadness.org 70 i 7096

Err codemadness.org 70 i 7098 Comment by Err codemadness.org 70 i 7099 Sergei Golubchik Err codemadness.org 70 i 7100 Err codemadness.org 70 i 7101 [ Err codemadness.org 70 i 7102 2021-11-04 Err codemadness.org 70 i 7103 Err codemadness.org 70 i 7104 ] Err codemadness.org 70 i 7105 Err codemadness.org 70 i 7106 Err codemadness.org 70 i 7107

Err codemadness.org 70 i 7109

could you do a small test case to demonstrate that behavior? you can use, for example, sleep() to make sure statements are executed in the desired order on the slave.

Err codemadness.org 70 i 7110

Err codemadness.org 70 i 7112 Comment by Err codemadness.org 70 i 7113 Vladislav Lesin Err codemadness.org 70 i 7114 Err codemadness.org 70 i 7115 [ Err codemadness.org 70 i 7116 2021-11-10 Err codemadness.org 70 i 7117 Err codemadness.org 70 i 7118 ] Err codemadness.org 70 i 7119 Err codemadness.org 70 i 7120 Err codemadness.org 70 i 7121

Err codemadness.org 70 i 7123

The test case is attached. It repeats the customer's root case with secondary keys locking. But more likely the same wrong cursor position restoring behaviour can be repeated for primary keys too. The test was developed for 10.6, I did not check it for the earlier versions, it might be some syncpoints missed for the earlier versions. MDEV-20605-restore-cursor.test

Err codemadness.org 70 i 7124

Err codemadness.org 70 i 7126 Comment by Err codemadness.org 70 i 7127 Vladislav Lesin Err codemadness.org 70 i 7128 Err codemadness.org 70 i 7129 [ Err codemadness.org 70 i 7130 2021-11-10 Err codemadness.org 70 i 7131 Err codemadness.org 70 i 7132 ] Err codemadness.org 70 i 7133 Err codemadness.org 70 i 7134 Err codemadness.org 70 i 7135

Err codemadness.org 70 i 7137

There is one more test case with deadlock. MDEV-20605-deadlock.test

Err codemadness.org 70 i 7138 Err codemadness.org 70 i 7139

It looks strange to me. The situation is the following. We have two transactions and one record. The first transaction holds ORDINARY S-lock on the record, the second transaction created waiting ORDINARY X-lock and waits for the first transaction. Then the first transaction requests insert-intention lock on the record. And this lock conflicts with the waiting ORDINARY X-lock of the second transaction. What causes deadlock. Why it should conflict? The first transaction already holds lock on the record. And the second's transaction lock contains "waiting" flag. This should be reported in the separate MDEV. See MDEV-27025.

Err codemadness.org 70 i 7140

Err codemadness.org 70 i 7142 Comment by Err codemadness.org 70 i 7143 Vladislav Lesin Err codemadness.org 70 i 7144 Err codemadness.org 70 i 7145 [ Err codemadness.org 70 i 7146 2021-11-11 Err codemadness.org 70 i 7147 Err codemadness.org 70 i 7148 ] Err codemadness.org 70 i 7149 Err codemadness.org 70 i 7150 Err codemadness.org 70 i 7151

Err codemadness.org 70 i 7153

Marko Mäkelä, I think the causer is not https://github.com/MariaDB/server/commit/f4fd68857b2e7767b559dbc09a8d4abbe7ccec29 commit. If we take a look the initial 5.0 import to git, we will see the following code:

Err codemadness.org 70 i 7154 Err codemadness.org 70 i 7155

Err codemadness.org 70 i 7156

Err codemadness.org 70 i 7157 Err codemadness.org 70 i 7158 Err codemadness.org 70 i 7159 Err codemadness.org 70 i 7160 Err codemadness.org 70 i 7163 Err codemadness.org 70 i 7164 Err codemadness.org 70 i 7165 Err codemadness.org 70 i 7168 Err codemadness.org 70 i 7169 Err codemadness.org 70 i 7170 Err codemadness.org 70 i 7173 Err codemadness.org 70 i 7174 Err codemadness.org 70 i 7175 Err codemadness.org 70 i 7178 Err codemadness.org 70 i 7179 Err codemadness.org 70 i 7180 Err codemadness.org 70 i 7183 Err codemadness.org 70 i 7184 Err codemadness.org 70 i 7185 Err codemadness.org 70 i 7188 Err codemadness.org 70 i 7189 Err codemadness.org 70 i 7190 Err codemadness.org 70 i 7193 Err codemadness.org 70 i 7194 Err codemadness.org 70 i 7195 Err codemadness.org 70 i 7198 Err codemadness.org 70 i 7199 Err codemadness.org 70 i 7200 Err codemadness.org 70 i 7203 Err codemadness.org 70 i 7204 Err codemadness.org 70 i 7205 Err codemadness.org 70 i 7208 Err codemadness.org 70 i 7209 Err codemadness.org 70 i 7210 Err codemadness.org 70 i 7213 Err codemadness.org 70 i 7214 Err codemadness.org 70 i 7215 Err codemadness.org 70 i 7218 Err codemadness.org 70 i 7219 Err codemadness.org 70 i 7220 Err codemadness.org 70 i 7223 Err codemadness.org 70 i 7224 Err codemadness.org 70 i 7225 Err codemadness.org 70 i 7228 Err codemadness.org 70 i 7229 Err codemadness.org 70 i 7230 Err codemadness.org 70 i 7233 Err codemadness.org 70 i 7234 Err codemadness.org 70 i 7235 Err codemadness.org 70 i 7238 Err codemadness.org 70 i 7239 Err codemadness.org 70 i 7240 Err codemadness.org 70 i 7243 Err codemadness.org 70 i 7244 Err codemadness.org 70 i 7245 Err codemadness.org 70 i 7248 Err codemadness.org 70 i 7249 Err codemadness.org 70 i 7250 Err codemadness.org 70 i 7253 Err codemadness.org 70 i 7254 Err codemadness.org 70 i 7255 Err codemadness.org 70 i 7258 Err codemadness.org 70 i 7259 Err codemadness.org 70 i 7260 Err codemadness.org 70 i 7263 Err codemadness.org 70 i 7264 Err codemadness.org 70 i 7265 Err codemadness.org 70 i 7268 Err codemadness.org 70 i 7269 Err codemadness.org 70 i 7270 Err codemadness.org 70 i 7273 Err codemadness.org 70 i 7274 Err codemadness.org 70 i 7275 Err codemadness.org 70 i 7278 Err codemadness.org 70 i 7279 Err codemadness.org 70 i 7280 Err codemadness.org 70 i 7283 Err codemadness.org 70 i 7284 Err codemadness.org 70 i 7285 Err codemadness.org 70 i 7289 Err codemadness.org 70 i 7290 Err codemadness.org 70 i 7291

Err codemadness.org 70 i 7161

static

Err codemadness.org 70 i 7162

Err codemadness.org 70 i 7166

ibool

Err codemadness.org 70 i 7167

Err codemadness.org 70 i 7171

sel_restore_position_for_mysql(...)

Err codemadness.org 70 i 7172

Err codemadness.org 70 i 7176

Err codemadness.org 70 i 7177

Err codemadness.org 70 i 7181

        ibool   success;

Err codemadness.org 70 i 7182

Err codemadness.org 70 i 7186

        ulint   relative_position;

Err codemadness.org 70 i 7187

Err codemadness.org 70 i 7191

Err codemadness.org 70 i 7192

Err codemadness.org 70 i 7196

        relative_position = pcur->rel_pos;

Err codemadness.org 70 i 7197

Err codemadness.org 70 i 7201

Err codemadness.org 70 i 7202

Err codemadness.org 70 i 7206

        success = btr_pcur_restore_position(latch_mode, pcur, mtr);

Err codemadness.org 70 i 7207

Err codemadness.org 70 i 7211

Err codemadness.org 70 i 7212

Err codemadness.org 70 i 7216

        *same_user_rec = success;

Err codemadness.org 70 i 7217

Err codemadness.org 70 i 7221

Err codemadness.org 70 i 7222

Err codemadness.org 70 i 7226

        if (relative_position == BTR_PCUR_ON) {

Err codemadness.org 70 i 7227

Err codemadness.org 70 i 7231

                if (success) {

Err codemadness.org 70 i 7232

Err codemadness.org 70 i 7236

                        return(FALSE);

Err codemadness.org 70 i 7237

Err codemadness.org 70 i 7241

Err codemadness.org 70 i 7242

Err codemadness.org 70 i 7246

Err codemadness.org 70 i 7247

Err codemadness.org 70 i 7251

                if (moves_up) {

Err codemadness.org 70 i 7252

Err codemadness.org 70 i 7256

                        btr_pcur_move_to_next(pcur, mtr);

Err codemadness.org 70 i 7257

Err codemadness.org 70 i 7261

Err codemadness.org 70 i 7262

Err codemadness.org 70 i 7266

Err codemadness.org 70 i 7267

Err codemadness.org 70 i 7271

                return(TRUE);

Err codemadness.org 70 i 7272

Err codemadness.org 70 i 7276

Err codemadness.org 70 i 7277

Err codemadness.org 70 i 7281

...

Err codemadness.org 70 i 7282

Err codemadness.org 70 i 7286

}	Err	codemadness.org	70
i  7287

Err codemadness.org 70 i 7288

Err codemadness.org 70 i 7292

Err codemadness.org 70 i 7293

Err codemadness.org 70 i 7294 Err codemadness.org 70 i 7295

The comment of btr_pcur_restore_position() says:

Err codemadness.org 70 i 7296 Err codemadness.org 70 i 7297

Err codemadness.org 70 i 7298

Err codemadness.org 70 i 7299 Err codemadness.org 70 i 7300 Err codemadness.org 70 i 7301 Err codemadness.org 70 i 7302 Err codemadness.org 70 i 7305 Err codemadness.org 70 i 7306 Err codemadness.org 70 i 7307 Err codemadness.org 70 i 7310 Err codemadness.org 70 i 7311 Err codemadness.org 70 i 7312 Err codemadness.org 70 i 7315 Err codemadness.org 70 i 7316 Err codemadness.org 70 i 7317 Err codemadness.org 70 i 7320 Err codemadness.org 70 i 7321 Err codemadness.org 70 i 7322 Err codemadness.org 70 i 7326 Err codemadness.org 70 i 7327 Err codemadness.org 70 i 7328

Err codemadness.org 70 i 7303

                                        /* out: TRUE if the cursor position

Err codemadness.org 70 i 7304

Err codemadness.org 70 i 7308

                                        was stored when it was on a user record

Err codemadness.org 70 i 7309

Err codemadness.org 70 i 7313

                                        and it can be restored on a user record

Err codemadness.org 70 i 7314

Err codemadness.org 70 i 7318

                                        whose ordering fields are identical to

Err codemadness.org 70 i 7319

Err codemadness.org 70 i 7323

                                        the ones of the original user record */	Err	codemadness.org	70
i  7324

Err codemadness.org 70 i 7325

Err codemadness.org 70 i 7329

Err codemadness.org 70 i 7330

Err codemadness.org 70 i 7331 Err codemadness.org 70 i 7332

So "success" in sel_restore_position_for_mysql() contains two conditions joined with "and":

Err codemadness.org 70 i 7333

The restored position is not supremum or infinum
The restored position points to the record equals to stored one

Err codemadness.org 70 i 7337 Err codemadness.org 70 i 7338 Err codemadness.org 70 i 7339

I understand why the cursor is moved forward if the first condition is false, i.e. the restored position is infinum or supremum. But I don't understand why it should be moved if the second condition is false. For our case the cursor position was restored to the new record with the same key as in the stored record, but with different value. I think this is error and when the code was developed, the developer took into account the first condition and did not take into account the second one.

Err codemadness.org 70 i 7340 Err codemadness.org 70 i 7341

So the fix could be in dividing those two conditions. btr_pcur_restore_position() could, for example return true if cursor is not supremum or infinum, and have one more out parameter to notify if restored position points to the record with the same fields as the stored one.

Err codemadness.org 70 i 7342 Err codemadness.org 70 i 7343

What do you think about it?

Err codemadness.org 70 i 7344

Err codemadness.org 70 i 7346 Comment by Err codemadness.org 70 i 7347 Vladislav Lesin Err codemadness.org 70 i 7348 Err codemadness.org 70 i 7349 [ Err codemadness.org 70 i 7350 2021-11-19 Err codemadness.org 70 i 7351 Err codemadness.org 70 i 7352 ] Err codemadness.org 70 i 7353 Err codemadness.org 70 i 7354 Err codemadness.org 70 i 7355

Err codemadness.org 70 i 7357

Some update.

Err codemadness.org 70 i 7358 Err codemadness.org 70 i 7359

The first I changed my test a little bit. There is no need to execute the last INSERT in parallel with the previous DELETE. We can finish the previous DELETE, and then execute the INSERT. The updated version is here: MDEV-20605-restore-cursor-v2.test

Err codemadness.org 70 i 7360 Err codemadness.org 70 i 7361

I fixed cursor restore position function and the test passes with the fix. But there are test failures because of the fix: rpl.rpl_parallel_optimistic_nobinlog rpl.rpl_parallel_optimistic. I have not yet fully analysed them, but I suppose the issue is with locking and commit order.

Err codemadness.org 70 i 7362 Err codemadness.org 70 i 7363

About locking order. Andrei Elkin found the the test fails even if we remove purging. I analysed it too and came to conclusion that this is two independent issues. Here is the test: MDEV-20605-locking.test. The locks order is depicted here: https://docs.google.com/presentation/d/1ISG85S8A06kRVO6esq2cWPMMWS-1-fxcxEDVeZ0mu2I/edit?usp=sharing. The issue is that the last INSERT got lock on heap_no 3 before the previous DELETE got lock for heap_no 2 and was executed before the DELETE. I explained it also on the test comment.

Err codemadness.org 70 i 7364 Err codemadness.org 70 i 7365

Theoretically slave must resolve such issues allowing commits on slave to be in the same order as on master. But I have some doubts about it, need to analyse rpl.rpl_parallel_optimistic_nobinlog failures to be sure.

Err codemadness.org 70 i 7366

Err codemadness.org 70 i 7368

[MDEV-14425] Change the InnoDB redo log format to reduce write amplification

Marko Mäkelä — Fri, 19 Nov 2021 17:15:24 +0000

Err codemadness.org 70 i 7444 Err codemadness.org 70 i 7445 Err codemadness.org 70 i 7454 Err codemadness.org 70 i 7455 Err codemadness.org 70 i 7456 Err codemadness.org 70 i 7457 Err codemadness.org 70 i 7458 Err codemadness.org 70 i 7459 Err codemadness.org 70 i 7460 Err codemadness.org 70 i 7461 Err codemadness.org 70 i 7462 Err codemadness.org 70 i 7463 Err codemadness.org 70 i 7464 Err codemadness.org 70 i 7465 Err codemadness.org 70 i 7466 Err codemadness.org 70 i 7468 Err codemadness.org 70 i 7469 Err codemadness.org 70 i 7470 Err codemadness.org 70 i 7471 Err codemadness.org 70 i 7472 Err codemadness.org 70 i 7473 Err codemadness.org 70 i 7474 Err codemadness.org 70 i 7475 Err codemadness.org 70 i 7477 Err codemadness.org 70 i 7478 Err codemadness.org 70 i 7479

Err codemadness.org 70 i 7446 Err codemadness.org 70 i 7447 [MDEV-14425] Change the InnoDB redo log format to reduce write amplification Err codemadness.org 70 i 7448 Err codemadness.org 70 i 7449 Created: 2017-11-17 Updated: 2021-11-19 Err codemadness.org 70 i 7450 Err codemadness.org 70 i 7451 Err codemadness.org 70 i 7452 Err codemadness.org 70 i 7453
Status:	In Progress
Project:	MariaDB Server
Component/s:	Err codemadness.org 70 i 7467 Encryption, mariabackup, Storage Engine - InnoDB
Fix Version/s:	Err codemadness.org 70 i 7476 10.8

Err codemadness.org 70 i 7480 Err codemadness.org 70 i 7481

Err codemadness.org 70 i 7482 Err codemadness.org 70 i 7483 Err codemadness.org 70 i 7484 Err codemadness.org 70 i 7487 Err codemadness.org 70 i 7490 Err codemadness.org 70 i 7491 Err codemadness.org 70 i 7494 Err codemadness.org 70 i 7497 Err codemadness.org 70 i 7498 Err codemadness.org 70 i 7499 Err codemadness.org 70 i 7502 Err codemadness.org 70 i 7505 Err codemadness.org 70 i 7506 Err codemadness.org 70 i 7509 Err codemadness.org 70 i 7512 Err codemadness.org 70 i 7513 Err codemadness.org 70 i 7514 Err codemadness.org 70 i 7517 Err codemadness.org 70 i 7520 Err codemadness.org 70 i 7523 Err codemadness.org 70 i 7526 Err codemadness.org 70 i 7527 Err codemadness.org 70 i 7528 Err codemadness.org 70 i 7529 Err codemadness.org 70 i 7530 Err codemadness.org 70 i 7533 Err codemadness.org 70 i 7535 Err codemadness.org 70 i 7536 Err codemadness.org 70 i 7537 Err codemadness.org 70 i 7538 Err codemadness.org 70 i 7539 Err codemadness.org 70 i 7540 Err codemadness.org 70 i 7541

Err codemadness.org 70 i 7485 Type: Err codemadness.org 70 i 7486

Err codemadness.org 70 i 7488 Task Err codemadness.org 70 i 7489

Err codemadness.org 70 i 7492 Priority: Err codemadness.org 70 i 7493

Err codemadness.org 70 i 7495 Critical Err codemadness.org 70 i 7496

Err codemadness.org 70 i 7500 Reporter: Err codemadness.org 70 i 7501

Err codemadness.org 70 i 7503 Marko Mäkelä Err codemadness.org 70 i 7504

Err codemadness.org 70 i 7507 Assignee: Err codemadness.org 70 i 7508

Err codemadness.org 70 i 7510 Marko Mäkelä Err codemadness.org 70 i 7511

Err codemadness.org 70 i 7515 Resolution: Err codemadness.org 70 i 7516

Err codemadness.org 70 i 7518 Unresolved Err codemadness.org 70 i 7519

Err codemadness.org 70 i 7521 Votes: Err codemadness.org 70 i 7522

Err codemadness.org 70 i 7524 7 Err codemadness.org 70 i 7525

Err codemadness.org 70 i 7531 Labels: Err codemadness.org 70 i 7532

Err codemadness.org 70 i 7534 performance

Err codemadness.org 70 i 7542 Err codemadness.org 70 i 7543 Err codemadness.org 70 i 7544 Err codemadness.org 70 i 7545

Err codemadness.org 70 i 7546 Err codemadness.org 70 i 7547 Err codemadness.org 70 i 7548 Err codemadness.org 70 i 7549 Err codemadness.org 70 i 7550 Err codemadness.org 70 i 7551 Err codemadness.org 70 i 7554 Err codemadness.org 70 i 7560 Err codemadness.org 70 i 7561 Err codemadness.org 70 i 7562 Err codemadness.org 70 i 7563 Err codemadness.org 70 i 7566 Err codemadness.org 70 i 8005 Err codemadness.org 70 i 8006 Err codemadness.org 70 i 8007 Err codemadness.org 70 i 8008 Err codemadness.org 70 i 8009 Err codemadness.org 70 i 8010 Err codemadness.org 70 i 8011

Err codemadness.org 70 i 7552 Attachments: Err codemadness.org 70 i 7553

Err codemadness.org 70 i 7555 Err codemadness.org 70 i 7556 append.c Err codemadness.org 70 i 7557 Err codemadness.org 70 i 7558 preallocate.c Err codemadness.org 70 i 7559

Err codemadness.org 70 i 7564 Issue Links: Err codemadness.org 70 i 7565

Err codemadness.org 70 i 7567 Err codemadness.org 70 i 7568 Err codemadness.org 70 i 7569 Err codemadness.org 70 i 7572 Err codemadness.org 70 i 7573 Err codemadness.org 70 i 7574 Err codemadness.org 70 i 7577 Err codemadness.org 70 i 7581 Err codemadness.org 70 i 7584 Err codemadness.org 70 i 7587 Err codemadness.org 70 i 7588 Err codemadness.org 70 i 7589 Err codemadness.org 70 i 7592 Err codemadness.org 70 i 7596 Err codemadness.org 70 i 7599 Err codemadness.org 70 i 7602 Err codemadness.org 70 i 7603 Err codemadness.org 70 i 7604 Err codemadness.org 70 i 7607 Err codemadness.org 70 i 7611 Err codemadness.org 70 i 7614 Err codemadness.org 70 i 7617 Err codemadness.org 70 i 7618 Err codemadness.org 70 i 7619 Err codemadness.org 70 i 7622 Err codemadness.org 70 i 7626 Err codemadness.org 70 i 7629 Err codemadness.org 70 i 7632 Err codemadness.org 70 i 7633 Err codemadness.org 70 i 7634 Err codemadness.org 70 i 7637 Err codemadness.org 70 i 7641 Err codemadness.org 70 i 7644 Err codemadness.org 70 i 7647 Err codemadness.org 70 i 7648 Err codemadness.org 70 i 7649 Err codemadness.org 70 i 7652 Err codemadness.org 70 i 7653 Err codemadness.org 70 i 7654 Err codemadness.org 70 i 7657 Err codemadness.org 70 i 7661 Err codemadness.org 70 i 7664 Err codemadness.org 70 i 7667 Err codemadness.org 70 i 7668 Err codemadness.org 70 i 7669 Err codemadness.org 70 i 7672 Err codemadness.org 70 i 7673 Err codemadness.org 70 i 7674 Err codemadness.org 70 i 7677 Err codemadness.org 70 i 7681 Err codemadness.org 70 i 7684 Err codemadness.org 70 i 7687 Err codemadness.org 70 i 7688 Err codemadness.org 70 i 7689 Err codemadness.org 70 i 7692 Err codemadness.org 70 i 7696 Err codemadness.org 70 i 7699 Err codemadness.org 70 i 7702 Err codemadness.org 70 i 7703 Err codemadness.org 70 i 7704 Err codemadness.org 70 i 7707 Err codemadness.org 70 i 7711 Err codemadness.org 70 i 7714 Err codemadness.org 70 i 7717 Err codemadness.org 70 i 7718 Err codemadness.org 70 i 7719 Err codemadness.org 70 i 7722 Err codemadness.org 70 i 7726 Err codemadness.org 70 i 7729 Err codemadness.org 70 i 7732 Err codemadness.org 70 i 7733 Err codemadness.org 70 i 7734 Err codemadness.org 70 i 7737 Err codemadness.org 70 i 7741 Err codemadness.org 70 i 7744 Err codemadness.org 70 i 7747 Err codemadness.org 70 i 7748 Err codemadness.org 70 i 7749 Err codemadness.org 70 i 7752 Err codemadness.org 70 i 7756 Err codemadness.org 70 i 7759 Err codemadness.org 70 i 7762 Err codemadness.org 70 i 7763 Err codemadness.org 70 i 7764 Err codemadness.org 70 i 7767 Err codemadness.org 70 i 7771 Err codemadness.org 70 i 7774 Err codemadness.org 70 i 7777 Err codemadness.org 70 i 7778 Err codemadness.org 70 i 7779 Err codemadness.org 70 i 7782 Err codemadness.org 70 i 7786 Err codemadness.org 70 i 7789 Err codemadness.org 70 i 7792 Err codemadness.org 70 i 7793 Err codemadness.org 70 i 7794 Err codemadness.org 70 i 7797 Err codemadness.org 70 i 7801 Err codemadness.org 70 i 7804 Err codemadness.org 70 i 7807 Err codemadness.org 70 i 7808 Err codemadness.org 70 i 7809 Err codemadness.org 70 i 7812 Err codemadness.org 70 i 7816 Err codemadness.org 70 i 7819 Err codemadness.org 70 i 7822 Err codemadness.org 70 i 7823 Err codemadness.org 70 i 7824 Err codemadness.org 70 i 7827 Err codemadness.org 70 i 7831 Err codemadness.org 70 i 7834 Err codemadness.org 70 i 7837 Err codemadness.org 70 i 7838 Err codemadness.org 70 i 7839 Err codemadness.org 70 i 7842 Err codemadness.org 70 i 7846 Err codemadness.org 70 i 7849 Err codemadness.org 70 i 7852 Err codemadness.org 70 i 7853 Err codemadness.org 70 i 7854 Err codemadness.org 70 i 7857 Err codemadness.org 70 i 7861 Err codemadness.org 70 i 7864 Err codemadness.org 70 i 7867 Err codemadness.org 70 i 7868 Err codemadness.org 70 i 7869 Err codemadness.org 70 i 7872 Err codemadness.org 70 i 7876 Err codemadness.org 70 i 7879 Err codemadness.org 70 i 7882 Err codemadness.org 70 i 7883 Err codemadness.org 70 i 7884 Err codemadness.org 70 i 7887 Err codemadness.org 70 i 7891 Err codemadness.org 70 i 7894 Err codemadness.org 70 i 7897 Err codemadness.org 70 i 7898 Err codemadness.org 70 i 7899 Err codemadness.org 70 i 7902 Err codemadness.org 70 i 7906 Err codemadness.org 70 i 7909 Err codemadness.org 70 i 7912 Err codemadness.org 70 i 7913 Err codemadness.org 70 i 7914 Err codemadness.org 70 i 7917 Err codemadness.org 70 i 7921 Err codemadness.org 70 i 7924 Err codemadness.org 70 i 7927 Err codemadness.org 70 i 7928 Err codemadness.org 70 i 7929 Err codemadness.org 70 i 7932 Err codemadness.org 70 i 7936 Err codemadness.org 70 i 7939 Err codemadness.org 70 i 7942 Err codemadness.org 70 i 7943 Err codemadness.org 70 i 7944 Err codemadness.org 70 i 7947 Err codemadness.org 70 i 7951 Err codemadness.org 70 i 7954 Err codemadness.org 70 i 7957 Err codemadness.org 70 i 7958 Err codemadness.org 70 i 7959 Err codemadness.org 70 i 7962 Err codemadness.org 70 i 7966 Err codemadness.org 70 i 7969 Err codemadness.org 70 i 7972 Err codemadness.org 70 i 7973 Err codemadness.org 70 i 7974 Err codemadness.org 70 i 7977 Err codemadness.org 70 i 7981 Err codemadness.org 70 i 7984 Err codemadness.org 70 i 7987 Err codemadness.org 70 i 7988 Err codemadness.org 70 i 7989 Err codemadness.org 70 i 7992 Err codemadness.org 70 i 7996 Err codemadness.org 70 i 7999 Err codemadness.org 70 i 8002 Err codemadness.org 70 i 8003

Err codemadness.org 70 i 7570 Blocks Err codemadness.org 70 i 7571
Err codemadness.org 70 i 7575 blocks Err codemadness.org 70 i 7576	Err codemadness.org 70 i 7578 Err codemadness.org 70 i 7579 MDEV-14462 Err codemadness.org 70 i 7580	Err codemadness.org 70 i 7582 Confusing error message: ib_logfiles ... Err codemadness.org 70 i 7583	Err codemadness.org 70 i 7585 Open Err codemadness.org 70 i 7586
Err codemadness.org 70 i 7590 is blocked by Err codemadness.org 70 i 7591	Err codemadness.org 70 i 7593 Err codemadness.org 70 i 7594 ~~MDEV-14545~~ Err codemadness.org 70 i 7595	Err codemadness.org 70 i 7597 Backup fails due to MLOG_INDEX_LOAD r... Err codemadness.org 70 i 7598	Err codemadness.org 70 i 7600 Closed Err codemadness.org 70 i 7601
Err codemadness.org 70 i 7605 is blocked by Err codemadness.org 70 i 7606	Err codemadness.org 70 i 7608 Err codemadness.org 70 i 7609 ~~MDEV-18115~~ Err codemadness.org 70 i 7610	Err codemadness.org 70 i 7612 Remove dummy tablespace for the redo log Err codemadness.org 70 i 7613	Err codemadness.org 70 i 7615 Closed Err codemadness.org 70 i 7616
Err codemadness.org 70 i 7620 is blocked by Err codemadness.org 70 i 7621	Err codemadness.org 70 i 7623 Err codemadness.org 70 i 7624 ~~MDEV-20907~~ Err codemadness.org 70 i 7625	Err codemadness.org 70 i 7627 Set innodb_log_files_in_group=1 by de... Err codemadness.org 70 i 7628	Err codemadness.org 70 i 7630 Closed Err codemadness.org 70 i 7631
Err codemadness.org 70 i 7635 is blocked by Err codemadness.org 70 i 7636	Err codemadness.org 70 i 7638 Err codemadness.org 70 i 7639 ~~MDEV-21870~~ Err codemadness.org 70 i 7640	Err codemadness.org 70 i 7642 Deprecate and ignore innodb_scrub_log... Err codemadness.org 70 i 7643	Err codemadness.org 70 i 7645 Closed Err codemadness.org 70 i 7646
Err codemadness.org 70 i 7650 PartOf Err codemadness.org 70 i 7651
Err codemadness.org 70 i 7655 includes Err codemadness.org 70 i 7656	Err codemadness.org 70 i 7658 Err codemadness.org 70 i 7659 ~~MDEV-16045~~ Err codemadness.org 70 i 7660	Err codemadness.org 70 i 7662 Allocate log_sys statically Err codemadness.org 70 i 7663	Err codemadness.org 70 i 7665 Closed Err codemadness.org 70 i 7666
Err codemadness.org 70 i 7670 Relates Err codemadness.org 70 i 7671
Err codemadness.org 70 i 7675 relates to Err codemadness.org 70 i 7676	Err codemadness.org 70 i 7678 Err codemadness.org 70 i 7679 ~~MDEV-12699~~ Err codemadness.org 70 i 7680	Err codemadness.org 70 i 7682 Improve crash recovery of corrupted d... Err codemadness.org 70 i 7683	Err codemadness.org 70 i 7685 Closed Err codemadness.org 70 i 7686
Err codemadness.org 70 i 7690 relates to Err codemadness.org 70 i 7691	Err codemadness.org 70 i 7693 Err codemadness.org 70 i 7694 ~~MDEV-13830~~ Err codemadness.org 70 i 7695	Err codemadness.org 70 i 7697 Assertion failed: recv_sys->mlog_chec... Err codemadness.org 70 i 7698	Err codemadness.org 70 i 7700 Closed Err codemadness.org 70 i 7701
Err codemadness.org 70 i 7705 relates to Err codemadness.org 70 i 7706	Err codemadness.org 70 i 7708 Err codemadness.org 70 i 7709 MDEV-14481 Err codemadness.org 70 i 7710	Err codemadness.org 70 i 7712 Execute InnoDB crash recovery in the ... Err codemadness.org 70 i 7713	Err codemadness.org 70 i 7715 Stalled Err codemadness.org 70 i 7716
Err codemadness.org 70 i 7720 relates to Err codemadness.org 70 i 7721	Err codemadness.org 70 i 7723 Err codemadness.org 70 i 7724 MDEV-16232 Err codemadness.org 70 i 7725	Err codemadness.org 70 i 7727 Use fewer mini-transactions Err codemadness.org 70 i 7728	Err codemadness.org 70 i 7730 In Progress Err codemadness.org 70 i 7731
Err codemadness.org 70 i 7735 relates to Err codemadness.org 70 i 7736	Err codemadness.org 70 i 7738 Err codemadness.org 70 i 7739 MDEV-16526 Err codemadness.org 70 i 7740	Err codemadness.org 70 i 7742 Overhaul the InnoDB page flushing Err codemadness.org 70 i 7743	Err codemadness.org 70 i 7745 Open Err codemadness.org 70 i 7746
Err codemadness.org 70 i 7750 relates to Err codemadness.org 70 i 7751	Err codemadness.org 70 i 7753 Err codemadness.org 70 i 7754 ~~MDEV-17138~~ Err codemadness.org 70 i 7755	Err codemadness.org 70 i 7757 Reduce redo log volume for undo table... Err codemadness.org 70 i 7758	Err codemadness.org 70 i 7760 Closed Err codemadness.org 70 i 7761
Err codemadness.org 70 i 7765 relates to Err codemadness.org 70 i 7766	Err codemadness.org 70 i 7768 Err codemadness.org 70 i 7769 ~~MDEV-18370~~ Err codemadness.org 70 i 7770	Err codemadness.org 70 i 7772 InnoDB: Failing assertion: lsn % OS_F... Err codemadness.org 70 i 7773	Err codemadness.org 70 i 7775 Closed Err codemadness.org 70 i 7776
Err codemadness.org 70 i 7780 relates to Err codemadness.org 70 i 7781	Err codemadness.org 70 i 7783 Err codemadness.org 70 i 7784 ~~MDEV-19176~~ Err codemadness.org 70 i 7785	Err codemadness.org 70 i 7787 Do not run out of InnoDB buffer pool ... Err codemadness.org 70 i 7788	Err codemadness.org 70 i 7790 Closed Err codemadness.org 70 i 7791
Err codemadness.org 70 i 7795 relates to Err codemadness.org 70 i 7796	Err codemadness.org 70 i 7798 Err codemadness.org 70 i 7799 ~~MDEV-20474~~ Err codemadness.org 70 i 7800	Err codemadness.org 70 i 7802 Assertion `!recv_no_log_write' failed... Err codemadness.org 70 i 7803	Err codemadness.org 70 i 7805 Closed Err codemadness.org 70 i 7806
Err codemadness.org 70 i 7810 relates to Err codemadness.org 70 i 7811	Err codemadness.org 70 i 7813 Err codemadness.org 70 i 7814 ~~MDEV-20475~~ Err codemadness.org 70 i 7815	Err codemadness.org 70 i 7817 Assertion `flushed_lsn == log_get_lsn... Err codemadness.org 70 i 7818	Err codemadness.org 70 i 7820 Closed Err codemadness.org 70 i 7821
Err codemadness.org 70 i 7825 relates to Err codemadness.org 70 i 7826	Err codemadness.org 70 i 7828 Err codemadness.org 70 i 7829 ~~MDEV-21990~~ Err codemadness.org 70 i 7830	Err codemadness.org 70 i 7832 Issue a message on changing deprecate... Err codemadness.org 70 i 7833	Err codemadness.org 70 i 7835 Closed Err codemadness.org 70 i 7836
Err codemadness.org 70 i 7840 relates to Err codemadness.org 70 i 7841	Err codemadness.org 70 i 7843 Err codemadness.org 70 i 7844 MDEV-23382 Err codemadness.org 70 i 7845	Err codemadness.org 70 i 7847 Change DB_ROLL_PTR format to allow mo... Err codemadness.org 70 i 7848	Err codemadness.org 70 i 7850 Open Err codemadness.org 70 i 7851
Err codemadness.org 70 i 7855 relates to Err codemadness.org 70 i 7856	Err codemadness.org 70 i 7858 Err codemadness.org 70 i 7859 ~~MDEV-8139~~ Err codemadness.org 70 i 7860	Err codemadness.org 70 i 7862 Fix scrubbing Err codemadness.org 70 i 7863	Err codemadness.org 70 i 7865 Closed Err codemadness.org 70 i 7866
Err codemadness.org 70 i 7870 relates to Err codemadness.org 70 i 7871	Err codemadness.org 70 i 7873 Err codemadness.org 70 i 7874 ~~MDEV-11380~~ Err codemadness.org 70 i 7875	Err codemadness.org 70 i 7877 AliSQL: [Perf] Issue#24 SPLIT LOG BUF... Err codemadness.org 70 i 7878	Err codemadness.org 70 i 7880 Closed Err codemadness.org 70 i 7881
Err codemadness.org 70 i 7885 relates to Err codemadness.org 70 i 7886	Err codemadness.org 70 i 7888 Err codemadness.org 70 i 7889 ~~MDEV-12041~~ Err codemadness.org 70 i 7890	Err codemadness.org 70 i 7892 Implement key rotation for innodb_enc... Err codemadness.org 70 i 7893	Err codemadness.org 70 i 7895 Closed Err codemadness.org 70 i 7896
Err codemadness.org 70 i 7900 relates to Err codemadness.org 70 i 7901	Err codemadness.org 70 i 7903 Err codemadness.org 70 i 7904 ~~MDEV-12353~~ Err codemadness.org 70 i 7905	Err codemadness.org 70 i 7907 Efficient InnoDB redo log record format Err codemadness.org 70 i 7908	Err codemadness.org 70 i 7910 Closed Err codemadness.org 70 i 7911
Err codemadness.org 70 i 7915 relates to Err codemadness.org 70 i 7916	Err codemadness.org 70 i 7918 Err codemadness.org 70 i 7919 ~~MDEV-15914~~ Err codemadness.org 70 i 7920	Err codemadness.org 70 i 7922 performance regression for mass update Err codemadness.org 70 i 7923	Err codemadness.org 70 i 7925 Closed Err codemadness.org 70 i 7926
Err codemadness.org 70 i 7930 relates to Err codemadness.org 70 i 7931	Err codemadness.org 70 i 7933 Err codemadness.org 70 i 7934 ~~MDEV-16168~~ Err codemadness.org 70 i 7935	Err codemadness.org 70 i 7937 Performance regression on sysbench wr... Err codemadness.org 70 i 7938	Err codemadness.org 70 i 7940 Closed Err codemadness.org 70 i 7941
Err codemadness.org 70 i 7945 relates to Err codemadness.org 70 i 7946	Err codemadness.org 70 i 7948 Err codemadness.org 70 i 7949 ~~MDEV-18370~~ Err codemadness.org 70 i 7950	Err codemadness.org 70 i 7952 InnoDB: Failing assertion: lsn % OS_F... Err codemadness.org 70 i 7953	Err codemadness.org 70 i 7955 Closed Err codemadness.org 70 i 7956
Err codemadness.org 70 i 7960 relates to Err codemadness.org 70 i 7961	Err codemadness.org 70 i 7963 Err codemadness.org 70 i 7964 MDEV-18606 Err codemadness.org 70 i 7965	Err codemadness.org 70 i 7967 innodb crashes on large update and it... Err codemadness.org 70 i 7968	Err codemadness.org 70 i 7970 Open Err codemadness.org 70 i 7971
Err codemadness.org 70 i 7975 relates to Err codemadness.org 70 i 7976	Err codemadness.org 70 i 7978 Err codemadness.org 70 i 7979 ~~MDEV-21382~~ Err codemadness.org 70 i 7980	Err codemadness.org 70 i 7982 use fdatasync() for redo log where ap... Err codemadness.org 70 i 7983	Err codemadness.org 70 i 7985 Closed Err codemadness.org 70 i 7986
Err codemadness.org 70 i 7990 relates to Err codemadness.org 70 i 7991	Err codemadness.org 70 i 7993 Err codemadness.org 70 i 7994 MDEV-21923 Err codemadness.org 70 i 7995	Err codemadness.org 70 i 7997 Write redo log concurrently without lock Err codemadness.org 70 i 7998	Err codemadness.org 70 i 8000 Open Err codemadness.org 70 i 8001

Err codemadness.org 70 i 8004

Err codemadness.org 70 i 8012 Err codemadness.org 70 i 8013

Err codemadness.org 70 i 8014 Err codemadness.org 70 i 8015 Err codemadness.org 70 i 8016 Err codemadness.org 70 i 8017 Err codemadness.org 70 i 8020 Err codemadness.org 70 i 8021 Err codemadness.org 70 i 8022

Err codemadness.org 70 i 8018 Description Err codemadness.org 70 i 8019

Err codemadness.org 70 i 8023 Err codemadness.org 70 i 8024 Err codemadness.org 70 i 8025 Err codemadness.org 70 i 8026 Err codemadness.org 70 i 8152 Err codemadness.org 70 i 8153

Err codemadness.org 70 i 8027

The InnoDB redo log format is not optimal in many respects:

Err codemadness.org 70 i 8028

At the start of ib_logfile0, there are only two log checkpoint blocks. The rest of the log file is written in a circular fashion.
On log checkpoint, some file name information needs to be appended to the log.
File names that were first changed since the latest checkpoint must be appended to the log. The bookkeeping causes some contention on log_sys.mutex and fil_system.mutex.
The log file was unnecessarily split into multiple files, logically treated as one big circular file. (~~MDEV-20907~~ in MariaDB Server 10.5.0 change the default to 1 file, and later the parameter was deprecated and ignored.)
Log records are divided into tiny blocks of 512 bytes, with 12+4 bytes of header and footer (12+8 bytes with ~~MDEV-12041~~ innodb_encrypt_log (10.4.0)).
We are holding a mutex while zero-filling unused parts of log blocks, encrypting log blocks, or computing checksums.
Mariabackup cannot copy the log without having access to the encryption keys. (It can copy data file pages without encrypting them.)

Err codemadness.org 70 i 8037 Err codemadness.org 70 i 8038 Err codemadness.org 70 i 8039

We had some ideas to move to an append-only file and to partition the log into multiple files, but it turned out that a single fixed-size circular log file would perform best in typical scenarios.

Err codemadness.org 70 i 8040 Err codemadness.org 70 i 8041

We should keep the first 512 bytes of the file ib_logfile0 for compatibility purposes, but everything else could be improved.

Err codemadness.org 70 i 8042

ib_logfile0 (after the 512-byte header) will be append-only, unencrypted, for records containing file names and checkpoint information. A checkpoint record will comprise an LSN and a byte offset in a separate, optionally encrypted, circular log file ib_logdata. The length of each record is explicitly tagged and the payload will be followed by CRC-32C.
The ib_logdata file can be append-only or circular. If it is circular, its fixed size must be an integer multiple of 512 bytes.
We remove log block headers and footers. We really only need is to detect the logical end of the circular log in ib_logdata. That can be achieved by making sure that mini-transactions are terminated by a sequence number (at least one bit) and a checksum. When the circular file wraps around, the sequence number will be incremented (or the sequence bit toggled).
For page-aligned I/O, allow dummy records to be written, to indicate that the next bytes (until the end of the physical page, no matter what the I/O block size is) must be ignored. Thus, there is no need to initialize any padding bytes or encrypt or compute checksums on them.
Encrypt and compute checksums on mtr_t::m_log before initiating a write to the circular log file. The log can be copied and checksums validated without access to encryption keys.
If ib_logdata is on a memory-mapped persistent memory device, then we could bypass log_sys.buf and the file system copy the data directly to the memory-mapped area and flush the CPU cache.

Err codemadness.org 70 i 8050 Err codemadness.org 70 i 8051 Err codemadness.org 70 i 8052

Some old InnoDB redo log parameters will be deprecated and ignored:

Err codemadness.org 70 i 8053

innodb_log_files_in_group (deprecated & ignored in MariaDB 10.5.1)
innodb_log_checksums (already set by default, and forced when innodb_encrypt_log)

Err codemadness.org 70 i 8057 Err codemadness.org 70 i 8058 Err codemadness.org 70 i 8059

The parameter innodb_log_write_ahead_size may be repurposed to indicate the desired physical log block size. For PMEM, it might be 64 bytes (the width of a CPU cache line).

Err codemadness.org 70 i 8060 Err codemadness.org 70 i 8061

The checkpoint and file operations log file `ib_logfile0`

Err codemadness.org 70 i 8062

The file name ib_logfile0 and the existing format of the first 512 bytes will be retained for the purpose of upgrading and preventing downgrading. In the first 512 bytes of the file, the following information will be present:

Err codemadness.org 70 i 8063

InnoDB redo log format version identifier (in the format introduced by MySQL 5.7.9/MariaDB 10.2.2)
The size of the ib_logdata file (the maximum possible size of the file if it is append-only).
All encryption parameters for ib_logdata
CRC-32C checksum

Err codemadness.org 70 i 8068 This file will be append-only. After the first 512 bytes, the format will be:
Optional: FILE_ID records (renamed from FILE_MODIFY) of all .ibd files that existed when the redo log file was created. Each record terminated by CRC-32C.
FILE_CHECKPOINT record with LSN and byte offset in ib_logdata, and sequence bit (in circular ib_logdata file), and CRC-32C. The byte offset will be at least 47 bits (128 TiB). Total size of a checkpoint: at least 1+8+6+4=19 bytes.
Optional: FILE_CREATE, FILE_DELETE, FILE_RENAME records and further FILE_CHECKPOINT records for any file operations or subsequent checkpoints since the redo log was created. Each record will be terminated by CRC-32C.

Err codemadness.org 70 i 8073 Err codemadness.org 70 i 8074 Err codemadness.org 70 i 8075

All writes to ib_logfile0 will be synchronous and durable (O_DSYNC, fdatasync() or O_SYNC, fsync()) .

Err codemadness.org 70 i 8076 Err codemadness.org 70 i 8077

The circular or append-only page-level log file `ib_logdata`

Err codemadness.org 70 i 8078

The ib_logdata file will contain ~~MDEV-12353~~ records except FILE_ records that will be written into ib_logfile0. Each mini-transaction will be followed by a CRC-32C of all the bytes (using the value 0 for the sequence bit or number), so that Mariabackup can avoid recomputing the checksum while copying the log to a new file.

Err codemadness.org 70 i 8079 Err codemadness.org 70 i 8080

If the ib_logdata is append-only, then we could enable log archiving by actually writing to files like ib_logdata.000000, ib_logdata.000001 and so on.

Err codemadness.org 70 i 8081 Err codemadness.org 70 i 8082

Payload encoding

Err codemadness.org 70 i 8083

The exact encoding of ib_logdata is not decided yet. We want to avoid overwriting the last log block, so we cannot have an explicit 'end of log' marker. We must associate each mini-transaction (atomic sequence of log records) with a sequence number (at the minimum, a sequence bit) and a checksum. The 4-byte CRC-32C is a good candidate, because it is already being used in data page checksums.

Err codemadness.org 70 i 8084 Err codemadness.org 70 i 8085

We know that a CRC of nonzero bytes must be nonzero, and the mini-transaction payload cannot be zero, hence the CRC bytes can never be zero.

Err codemadness.org 70 i 8086 Because of this, it would be beneficial to zero-initialize all the skipped bytes to increase the probability of quick detection of the end of the circular log. Compared to the existing format, we would avoid CRC computation or encryption of the skipped bytes, but the zero-filling would still have to be protected with a mutex.

Err codemadness.org 70 i 8087 Err codemadness.org 70 i 8088

Alternative: Prepending a CRC to each MDEV-12353 mini-transaction

Err codemadness.org 70 i 8089

In the ~~MDEV-12353~~ encoding, a record cannot start with the bytes 0x00 or 0x01. Mini-transactions are currently being terminated by the byte 0x00. We could store the sequence bit in the terminating byte of the mini-transaction. The checksum would exclude the terminating byte.

Err codemadness.org 70 i 8090 Err codemadness.org 70 i 8091

Only the payload bytes would be encrypted (not record types or lengths, and not page identifiers either). In that way, records can be parsed and validated efficiently. Decryption would only have to be invoked when the log really needs to be applied on the page. The initialization vector for encryption and decryption can include the unencrypted record header bytes.

Err codemadness.org 70 i 8092 Err codemadness.org 70 i 8093

It is best to store the CRC before the mini-transaction payload, because the CRC cannot be 0. Hence, we can detect the end of the log without even parsing the mini-transaction bytes.

Err codemadness.org 70 i 8094 Err codemadness.org 70 i 8095

For circular log files, we can introduce a special mini-transaction 'Skip the next N bytes', encoded in sizeof(CRC)+2+log(N) bytes: CRC, record type and length, subtype and the value of the sequence bit, and variable-length encoded N. If we need to pad a block with fewer bytes than the minimum size, we would write a record to skip the minimum size.

Err codemadness.org 70 i 8096 Err codemadness.org 70 i 8097

Pros: Minimal overhead: sizeof(CRC) bytes per mini-transaction.

Err codemadness.org 70 i 8098 Cons: Recovery may have to parse a lot of log before determining that the end of the log was reached.

Err codemadness.org 70 i 8099 Err codemadness.org 70 i 8100

Alternative: Prepending a mini-transaction header with length and CRC

Err codemadness.org 70 i 8101

We could encapsulate ~~MDEV-12353~~ records (without the mini-transaction terminating NUL byte) in the following structure:

Err codemadness.org 70 i 8102

variable-length encoded integer of total_length << 2 | sequence_bit
CRC of the data payload and the variable-length encoded integer
the data payload (~~MDEV-12353~~ records); could be encrypted in their entirety

Err codemadness.org 70 i 8107 Err codemadness.org 70 i 8108 Err codemadness.org 70 i 8109

Skipped bytes (at least 5) would be indicated by the following:

Err codemadness.org 70 i 8110

variable-length encoded integer of skipped_length << 2 | 1 << 1 | sequence_bit
CRC of the variable-length encoded integer (not including the skipped bytes)

Err codemadness.org 70 i 8114 Err codemadness.org 70 i 8115 Err codemadness.org 70 i 8116

Pros: Recovery can determine more quickly that the end of the circular log was reached, thanks to the length, sequence bit and (nonzero) CRC being stored at the start.

Err codemadness.org 70 i 8117 Pros: More of the log could be encrypted (at the cost of recovery and backup restoration speed)

Err codemadness.org 70 i 8118 Cons: Slightly more overhead: sizeof(CRC)+log(length * 4) bytes. For length<32 bytes, no change of overhead.

Err codemadness.org 70 i 8119 Err codemadness.org 70 i 8120

Log writing and synchronous flushing

Err codemadness.org 70 i 8121

For the bulk of the changes done by mini-transactions, we do not care about flushing. The file system can write log file blocks as it pleases.

Err codemadness.org 70 i 8122 Err codemadness.org 70 i 8123

Some state changes of the database must be made durable at a specific time. Examples include user transaction COMMIT, XA PREPARE, XA ROLLBACK, and (in case the binlog is not enabled) XA COMMIT.

Err codemadness.org 70 i 8124 Err codemadness.org 70 i 8125

Whenever we want to make a certain change durable, we must flush all log files up to the LSN of the mini-transaction commit that made the change. While doing this, we can pad each log file to the file system block size (the 'skipped bytes'), so that the file system can always write full blocks. The padding could also be helpful when trying to resurrect a corrupted redo log file.

Err codemadness.org 70 i 8126 Err codemadness.org 70 i 8127

If redo log is physically replicated to the buffer pools of slaves (like in PolarDB), then we should first write to the redo log files and only then to the slaves, and we should assume that the writes to the files will always eventually be durable. If that assumption is broken, then all servers would have to be restarted and perform crash recovery. Because the log sequence number will be counted in bytes, we will have to replicate the number of skipped bytes. (But we could omit the skipped bytes themselves when sending over the network.)

Err codemadness.org 70 i 8128 Err codemadness.org 70 i 8129

Crash recovery

Err codemadness.org 70 i 8130

Validate the ib_logfile0 header, including checking the size of the ib_logdata file.
Read the last bytes of ib_logfile0 to see if it ends in a valid FILE_CHECKPOINT record. If not, read the entire ib_logfile0 to find the latest FILE_CHECKPOINT record. (The last write to ib_logfile0 could have been incomplete, and we may have to trim that file.)
If ib_logdata ends at the identified byte position (we got sequence bit mismatch or checksum mismatch), then the database was clean.
Else, recover the file name information based on the ib_logfile0 contents and start recovery.
Parse the ib_logdata until the end. If any tablespace identifiers refer to unknown or inaccessible data files, abort startup unless innodb_force_recovery≥1. Ignore records for those tablespaces for which FILE_DELETE had been recorded.
Now that the log has been validated, start the modifications in recovery. First, trim ib_logfile0 if needed, and replay FILE_DELETE and FILE_RENAME operations.
Shrink any files for which we parsed a TRIM_PAGES record, and extend any files according to changes to FSP_SIZE.
Apply the parsed log to all data files.

Err codemadness.org 70 i 8140 Err codemadness.org 70 i 8141 Err codemadness.org 70 i 8142

Considerations on checkpoints and writing `ib_logdata`

Err codemadness.org 70 i 8143

After completing a checkpoint (the write of the FILE_CHECKPOINT record to ib_logfile0), we could punch a hole in ib_logdata to discard no-longer-needed log records.

Err codemadness.org 70 i 8144 Err codemadness.org 70 i 8145

As an option, the redo log could be rebuilt on a checkpoint, by creating a logically empty set of log files, at the minimum consisting of an empty ib_logdata file and a ib_logfile0 that contains FILE_ID records and a FILE_CHECKPOINT record.

Err codemadness.org 70 i 8146 Err codemadness.org 70 i 8147

If redo log archiving is enabled, when the maximum configured size of a single redo log (which is stored in the ib_logfile0 header) is reached, a new ib_logdata.%06u file will be created. The old file length must be exactly at the maximum length.

Err codemadness.org 70 i 8148 Err codemadness.org 70 i 8149

Writes to ib_logfile0 will not increment the LSN at all! This means that the redo log could be easily rebuilt at any LSN, and Mariabackup could write additional information to that file, removing the need for separate .delta files in incremental backups.

Err codemadness.org 70 i 8150

Err codemadness.org 70 i 8151

Err codemadness.org 70 i 8154 Err codemadness.org 70 i 8155

Err codemadness.org 70 i 8156 Err codemadness.org 70 i 8157 Err codemadness.org 70 i 8158 Err codemadness.org 70 i 8159 Err codemadness.org 70 i 8162 Err codemadness.org 70 i 8163 Err codemadness.org 70 i 8164

Err codemadness.org 70 i 8160 Comments Err codemadness.org 70 i 8161

Err codemadness.org 70 i 8165 Err codemadness.org 70 i 8166 Err codemadness.org 70 i 8167 Err codemadness.org 70 i 8178 Err codemadness.org 70 i 8181 Err codemadness.org 70 i 8192 Err codemadness.org 70 i 8195 Err codemadness.org 70 i 8206 Err codemadness.org 70 i 8214 Err codemadness.org 70 i 8225 Err codemadness.org 70 i 8263 Err codemadness.org 70 i 8274 Err codemadness.org 70 i 8334 Err codemadness.org 70 i 8345 Err codemadness.org 70 i 8348 Err codemadness.org 70 i 8359 Err codemadness.org 70 i 8366 Err codemadness.org 70 i 8377 Err codemadness.org 70 i 8383 Err codemadness.org 70 i 8394 Err codemadness.org 70 i 8405 Err codemadness.org 70 i 8416 Err codemadness.org 70 i 8429 Err codemadness.org 70 i 8440 Err codemadness.org 70 i 8455 Err codemadness.org 70 i 8466 Err codemadness.org 70 i 8473 Err codemadness.org 70 i 8484 Err codemadness.org 70 i 8487 Err codemadness.org 70 i 8498 Err codemadness.org 70 i 8503 Err codemadness.org 70 i 8514 Err codemadness.org 70 i 8518 Err codemadness.org 70 i 8529 Err codemadness.org 70 i 8532 Err codemadness.org 70 i 8543 Err codemadness.org 70 i 8546 Err codemadness.org 70 i 8557 Err codemadness.org 70 i 8560 Err codemadness.org 70 i 8571 Err codemadness.org 70 i 8574 Err codemadness.org 70 i 8585 Err codemadness.org 70 i 8588 Err codemadness.org 70 i 8599 Err codemadness.org 70 i 8621 Err codemadness.org 70 i 8632 Err codemadness.org 70 i 8635 Err codemadness.org 70 i 8646 Err codemadness.org 70 i 8657 Err codemadness.org 70 i 8668 Err codemadness.org 70 i 8693 Err codemadness.org 70 i 8704 Err codemadness.org 70 i 8716 Err codemadness.org 70 i 8727 Err codemadness.org 70 i 8732 Err codemadness.org 70 i 8743 Err codemadness.org 70 i 10501 Err codemadness.org 70 i 10512 Err codemadness.org 70 i 10517 Err codemadness.org 70 i 10528 Err codemadness.org 70 i 10535 Err codemadness.org 70 i 10546 Err codemadness.org 70 i 12055 Err codemadness.org 70 i 12066 Err codemadness.org 70 i 12071 Err codemadness.org 70 i 12082 Err codemadness.org 70 i 12085 Err codemadness.org 70 i 12096 Err codemadness.org 70 i 12102 Err codemadness.org 70 i 12113 Err codemadness.org 70 i 12159 Err codemadness.org 70 i 12170 Err codemadness.org 70 i 12177 Err codemadness.org 70 i 12188 Err codemadness.org 70 i 12195 Err codemadness.org 70 i 12206 Err codemadness.org 70 i 12348 Err codemadness.org 70 i 12359 Err codemadness.org 70 i 12367 Err codemadness.org 70 i 12378 Err codemadness.org 70 i 12383 Err codemadness.org 70 i 12394 Err codemadness.org 70 i 12398 Err codemadness.org 70 i 12409 Err codemadness.org 70 i 12412 Err codemadness.org 70 i 12423 Err codemadness.org 70 i 12429 Err codemadness.org 70 i 12440 Err codemadness.org 70 i 12443 Err codemadness.org 70 i 12454 Err codemadness.org 70 i 12467 Err codemadness.org 70 i 12478 Err codemadness.org 70 i 12494 Err codemadness.org 70 i 12505 Err codemadness.org 70 i 12751 Err codemadness.org 70 i 12762 Err codemadness.org 70 i 12814 Err codemadness.org 70 i 12825 Err codemadness.org 70 i 12835 Err codemadness.org 70 i 12846 Err codemadness.org 70 i 12849 Err codemadness.org 70 i 12860 Err codemadness.org 70 i 12863 Err codemadness.org 70 i 12874 Err codemadness.org 70 i 12934 Err codemadness.org 70 i 12945 Err codemadness.org 70 i 12950

Err codemadness.org 70 i 8168 Comment by Err codemadness.org 70 i 8169 Marko Mäkelä Err codemadness.org 70 i 8170 Err codemadness.org 70 i 8171 [ Err codemadness.org 70 i 8172 2017-11-29 Err codemadness.org 70 i 8173 Err codemadness.org 70 i 8174 ] Err codemadness.org 70 i 8175 Err codemadness.org 70 i 8176 Err codemadness.org 70 i 8177

Err codemadness.org 70 i 8179

As part of this work, the function log_buffer_extend() will be removed.

Err codemadness.org 70 i 8180

Err codemadness.org 70 i 8182 Comment by Err codemadness.org 70 i 8183 Marko Mäkelä Err codemadness.org 70 i 8184 Err codemadness.org 70 i 8185 [ Err codemadness.org 70 i 8186 2017-11-29 Err codemadness.org 70 i 8187 Err codemadness.org 70 i 8188 ] Err codemadness.org 70 i 8189 Err codemadness.org 70 i 8190 Err codemadness.org 70 i 8191

Err codemadness.org 70 i 8193

As part of MDEV-14425 the recovery logic should be improved so that when a redo log block is corrupted, only the mini-transaction(s) that are (partly or fully) contained in the block will be skipped. This would augment ~~MDEV-12699~~, which is about improving the recovery of corrupted data pages.

Err codemadness.org 70 i 8194

Err codemadness.org 70 i 8196 Comment by Err codemadness.org 70 i 8197 Marko Mäkelä Err codemadness.org 70 i 8198 Err codemadness.org 70 i 8199 [ Err codemadness.org 70 i 8200 2017-12-01 Err codemadness.org 70 i 8201 Err codemadness.org 70 i 8202 ] Err codemadness.org 70 i 8203 Err codemadness.org 70 i 8204 Err codemadness.org 70 i 8205

Err codemadness.org 70 i 8207

The function log_free_check() will have to be replaced.

Err codemadness.org 70 i 8208 With the original circularly-written InnoDB redo log, the function seeked to prevent a situation where the tail of the log is overwriting the head before the head is logically truncated by a redo log checkpoint. If such overwriting happens, InnoDB will be unable to recover from a crash. The situation would be normalized by a redo log checkpoint.

Err codemadness.org 70 i 8209 Err codemadness.org 70 i 8210

With these append-only log files, the overwriting issue is replaced with another one: running out of space in the file system. So, we will continue to need a function similar to log_free_check(). If the file system of the current thread’s log file is about to run out of space, the replacement of log_free_check() would return an ‘out of space’ error, which would be returned all the way up the call stack. If the ultimate caller is a client connection, the error would be reported as ER_DISK_FULL.

Err codemadness.org 70 i 8211 Err codemadness.org 70 i 8212

Running out of space should only be an issue when log archiving is enabled (innodb_log_max_size is overridden from its default value).

Err codemadness.org 70 i 8213

Err codemadness.org 70 i 8215 Comment by Err codemadness.org 70 i 8216 Marko Mäkelä Err codemadness.org 70 i 8217 Err codemadness.org 70 i 8218 [ Err codemadness.org 70 i 8219 2018-02-02 Err codemadness.org 70 i 8220 Err codemadness.org 70 i 8221 ] Err codemadness.org 70 i 8222 Err codemadness.org 70 i 8223 Err codemadness.org 70 i 8224

Err codemadness.org 70 i 8226

For the record: Michael Widenius asked me to compare the relative performance of writing to a preallocated file and appending to a file.

Err codemadness.org 70 i 8227 On my HP ZBook 15u G3 laptop, I ran the test programs append.c and preallocate.c to write a 2GiB file on ext4fs, and the results are clear.

Err codemadness.org 70 i 8228 I used 2 SSD devices: 220GiB NVMe that is encrypted by dm-crypt, and a 450GiB SATA SSD that is not encrypted. With 4 programs running in parallel like this:

Err codemadness.org 70 i 8229

Err codemadness.org 70 i 8230

Err codemadness.org 70 i 8231 Err codemadness.org 70 i 8232 Err codemadness.org 70 i 8233 Err codemadness.org 70 i 8234 Err codemadness.org 70 i 8238 Err codemadness.org 70 i 8239 Err codemadness.org 70 i 8240

Err codemadness.org 70 i 8235

time ./append foo1&time ./append foo2&time ./append foo3&time ./append foo4	Err	codemadness.org	70
i  8236

Err codemadness.org 70 i 8237

Err codemadness.org 70 i 8241

Err codemadness.org 70 i 8242

Err codemadness.org 70 i 8243

the reported real time was like this:

Err codemadness.org 70 i 8244

Err codemadness.org 70 i 8245 Err codemadness.org 70 i 8246 Err codemadness.org 70 i 8247 Err codemadness.org 70 i 8248 Err codemadness.org 70 i 8249 Err codemadness.org 70 i 8250 Err codemadness.org 70 i 8251 Err codemadness.org 70 i 8252 Err codemadness.org 70 i 8253 Err codemadness.org 70 i 8254 Err codemadness.org 70 i 8255 Err codemadness.org 70 i 8256 Err codemadness.org 70 i 8257 Err codemadness.org 70 i 8258

append, NVMe	preallocate, NVMe	append, SATA	preallocate, SATA
18.7s	24.2s	21.0s	66.7s

Err codemadness.org 70 i 8259

Err codemadness.org 70 i 8260 Err codemadness.org 70 i 8261

It would be interesting to test other relevant file systems as well as HDD.

Err codemadness.org 70 i 8262

Err codemadness.org 70 i 8264 Comment by Err codemadness.org 70 i 8265 Daniel Black Err codemadness.org 70 i 8266 Err codemadness.org 70 i 8267 [ Err codemadness.org 70 i 8268 2018-02-05 Err codemadness.org 70 i 8269 Err codemadness.org 70 i 8270 ] Err codemadness.org 70 i 8271 Err codemadness.org 70 i 8272 Err codemadness.org 70 i 8273

Err codemadness.org 70 i 8275

Some server hardware stats:

Err codemadness.org 70 i 8276 Err codemadness.org 70 i 8277

Power Systems S822LC "Firestone", Power8 - 10 cores

Err codemadness.org 70 i 8278 Ubuntu-16.04 userspace, Kernel 4.14.0-27552-gadb89ad

Err codemadness.org 70 i 8279 nvme - IBM PCIe3 1.6TB NVMe Flash Adapter

Err codemadness.org 70 i 8280 disk - ST1000NX0313, 7200rpm - SATA 3.1, 2 disks in software raid1 (changed to 4.15.0-10668-g3527799 kernel - managed to hit kernel thread that hung)

Err codemadness.org 70 i 8281 Err codemadness.org 70 i 8282

Err codemadness.org 70 i 8283 Err codemadness.org 70 i 8284 Err codemadness.org 70 i 8285 Err codemadness.org 70 i 8286 Err codemadness.org 70 i 8287 Err codemadness.org 70 i 8288 Err codemadness.org 70 i 8289 Err codemadness.org 70 i 8290 Err codemadness.org 70 i 8291 Err codemadness.org 70 i 8292 Err codemadness.org 70 i 8293 Err codemadness.org 70 i 8294 Err codemadness.org 70 i 8295 Err codemadness.org 70 i 8296 Err codemadness.org 70 i 8297 Err codemadness.org 70 i 8298 Err codemadness.org 70 i 8299 Err codemadness.org 70 i 8300 Err codemadness.org 70 i 8301 Err codemadness.org 70 i 8302 Err codemadness.org 70 i 8303 Err codemadness.org 70 i 8304 Err codemadness.org 70 i 8305 Err codemadness.org 70 i 8306 Err codemadness.org 70 i 8307 Err codemadness.org 70 i 8308 Err codemadness.org 70 i 8309 Err codemadness.org 70 i 8310 Err codemadness.org 70 i 8311 Err codemadness.org 70 i 8312 Err codemadness.org 70 i 8313 Err codemadness.org 70 i 8314 Err codemadness.org 70 i 8315 Err codemadness.org 70 i 8316 Err codemadness.org 70 i 8317 Err codemadness.org 70 i 8318 Err codemadness.org 70 i 8319 Err codemadness.org 70 i 8320 Err codemadness.org 70 i 8321 Err codemadness.org 70 i 8322 Err codemadness.org 70 i 8323 Err codemadness.org 70 i 8324

medium	append	preallocate
nvme, xfs bsize=4096 (default)	6.827s	6.706
nvme, xfs bsize=4096 (using ix10)	57.257	57.650s
nvme, xfs, bsize=16384 (using ix10)	56.621s	55.880s
nvme, ext3	9.191s	9.220s
nvme, ext3 (using ix10)	54.680s	1m45.147s
nvme, ext4 (using ix10)	55.242s	53.415s
disk, ext4 on llvm	1m39.221s	1m42.376s

Err codemadness.org 70 i 8325

Err codemadness.org 70 i 8326 Err codemadness.org 70 i 8327 Err codemadness.org 70 i 8328

ix10 is the i variable in the source * 10. Felt the size was too small at ~6 seconds.

Err codemadness.org 70 i 8329 Err codemadness.org 70 i 8330

error margin seems about 5% based on repetition (most results in the batch of 4 where identical however between batches varied). Assumed to be effects of journalling.

Err codemadness.org 70 i 8331 Err codemadness.org 70 i 8332

So ext3 is worse at prealloc. Multiple runs did occur. otherwise comparable.

Err codemadness.org 70 i 8333

Err codemadness.org 70 i 8335 Comment by Err codemadness.org 70 i 8336 Jun Su Err codemadness.org 70 i 8337 Err codemadness.org 70 i 8338 [ Err codemadness.org 70 i 8339 2018-02-05 Err codemadness.org 70 i 8340 Err codemadness.org 70 i 8341 ] Err codemadness.org 70 i 8342 Err codemadness.org 70 i 8343 Err codemadness.org 70 i 8344

Err codemadness.org 70 i 8346

Your preallocate code doesn't reflect the reality well. Since one log file can be written many times, they contains therandom data instead of just falloc. Your code simulate the situation when first time the log file get writes (brand new server). Please consider adding a command line parameter to open the existing file from previous run and skip falloc to simulate when the log file gets overwrite.

Err codemadness.org 70 i 8347

Err codemadness.org 70 i 8349 Comment by Err codemadness.org 70 i 8350 Marko Mäkelä Err codemadness.org 70 i 8351 Err codemadness.org 70 i 8352 [ Err codemadness.org 70 i 8353 2018-02-05 Err codemadness.org 70 i 8354 Err codemadness.org 70 i 8355 ] Err codemadness.org 70 i 8356 Err codemadness.org 70 i 8357 Err codemadness.org 70 i 8358

Err codemadness.org 70 i 8360

Daniel Black, thanks for your benchmarks!

Err codemadness.org 70 i 8361 Err codemadness.org 70 i 8362

Jun Su, thank you for your comment. Another problem with the test program that there is only a fdatasync() call at the end, while in the reality there would be some fdatasync() whenever we need to make something durable.

Err codemadness.org 70 i 8363 Err codemadness.org 70 i 8364

I am not actively working on this task yet. I would welcome improved versions of the test programs, as well as more benchmarks, especially ones that would seem to indicate that preallocating is faster than appending.

Err codemadness.org 70 i 8365

Err codemadness.org 70 i 8367 Comment by Err codemadness.org 70 i 8368 Marko Mäkelä Err codemadness.org 70 i 8369 Err codemadness.org 70 i 8370 [ Err codemadness.org 70 i 8371 2018-03-06 Err codemadness.org 70 i 8372 Err codemadness.org 70 i 8373 ] Err codemadness.org 70 i 8374 Err codemadness.org 70 i 8375 Err codemadness.org 70 i 8376

Err codemadness.org 70 i 8378

In addition to the proposed parameter innodb_log_max_size there perhaps also should be some time limit after which the excessive old logs will be discarded. Perhaps innodb_log_min_age?

Err codemadness.org 70 i 8379 To ease maintenance and backups, maybe we should have an option to have strictly append-only log files, and should revise the design so that log files are never renamed. Most notably, there should be no header in the partitioned log files; the checkpoint block offsets would be written into the single-block control file ib_logfile0 only.

Err codemadness.org 70 i 8380 Err codemadness.org 70 i 8381

On a related note, last Tuesday I gave a high-level view of the InnoDB internals in a M18 talk Deep Dive: InnoDB Transactions and Write Paths (video). The slides with the diagram on mini-transactions and describing the log checkpoints could be useful background information.

Err codemadness.org 70 i 8382

Err codemadness.org 70 i 8384 Comment by Err codemadness.org 70 i 8385 Inaam Rana Err codemadness.org 70 i 8386 Err codemadness.org 70 i 8387 [ Err codemadness.org 70 i 8388 2018-03-20 Err codemadness.org 70 i 8389 Err codemadness.org 70 i 8390 ] Err codemadness.org 70 i 8391 Err codemadness.org 70 i 8392 Err codemadness.org 70 i 8393

Err codemadness.org 70 i 8395

Marko,

Err codemadness.org 70 i 8396 Err codemadness.org 70 i 8397

This is a very interesting idea. I believe we should think of redo log as nothing but a bunch of ordered changes to the pages. This implies that if for a given page we have all the changes available we should be able to deal with the gaps in the log (obviously, as long as we do flush all log files at checkpoint).

Err codemadness.org 70 i 8398 Err codemadness.org 70 i 8399

How about we map to log partition based on space_id:page_no i.e.: all changes to a page must always go to same logfile. If this invariant is maintained then we don't need to flush anything on mtr_commit(). As a trx touches different pages it will keep track of which logfiles it needs to flush. For small trxs like a single row DML it will be a single file. This calculation can be done at mtr_commit(). At trx_commit() we only flush the relevant files.

Err codemadness.org 70 i 8400 Err codemadness.org 70 i 8401

I think with above scheme we can allow gaps in LSN. Conceptually this design feels intuitive. Redo log records changes to pages. Redo logs are partitioned based on page number. Log buffer can also be partitioned extending the same logic.

Err codemadness.org 70 i 8402 Err codemadness.org 70 i 8403

As an aside, if we redesign the format may be we should add information during mtr_commit() about back pointer to last redo record that changed the page. If we are able to follow the chain of changes to a page that might actually be quite helpful. There might not be an immediate use case for MariaDB but then log format changes are cumbersome to orchestrate.

Err codemadness.org 70 i 8404

Err codemadness.org 70 i 8406 Comment by Err codemadness.org 70 i 8407 Marko Mäkelä Err codemadness.org 70 i 8408 Err codemadness.org 70 i 8409 [ Err codemadness.org 70 i 8410 2018-03-21 Err codemadness.org 70 i 8411 Err codemadness.org 70 i 8412 ] Err codemadness.org 70 i 8413 Err codemadness.org 70 i 8414 Err codemadness.org 70 i 8415

Err codemadness.org 70 i 8417

Inaam Rana, thank you for the valuable feedback.

Err codemadness.org 70 i 8418 Err codemadness.org 70 i 8419

Your suggestion to flush a subset of the log files at transaction commit and to ignoring gaps in the log recovery seems to imply a partial ordering of events. With the added invariant that modifications of a certain page must always go to a certain log file, I cannot see any obvious correctness problem. We would only need an additional field "total number of log files" for the mini-transaction, so that recovery can reject a mini-transaction that was not fully written to all log files. What if this is combined with physical replication? We should only replicate each mini-transaction log up to the latest log flush. Here it could be tricky to guarantee the atomicity of the replicated mini-transactions without flushing all logs up to our mini-transaction commit LSN.

Err codemadness.org 70 i 8420 Err codemadness.org 70 i 8421

This architecture would seem to require some scatter-gather operation or partitioning of the local mini-transaction buffer, so that the log for pages are written to the appropriate log files. Maybe the easiest way to arrange that would be by copying log snippets from local mini-transaction buffers to a per-log global buffer. This would also imply that the mini-transaction log for a given mini-transaction (identified by logical LSN) can exist in multiple log files.

Err codemadness.org 70 i 8422 Err codemadness.org 70 i 8423

For maximum commit concurrency, I think that in this scheme, there should be 1 redo log for each rollback segment (now that with ~~MDEV-15132~~ and ~~MDEV-15158~~ commit only writes to the rollback segment header and undo log header pages, not the TRX_SYS page). For maximal concurrency, we could experiment with dedicated redo logs for transaction metadata, and separate redo logs for data file changes.

Err codemadness.org 70 i 8424 Err codemadness.org 70 i 8425

This is definitely worth trying. I think that we should prototype and benchmark both approaches before committing to a solution.

Err codemadness.org 70 i 8426 Err codemadness.org 70 i 8427

The back-pointer to the last record that changed the page sounds like a good idea to me, and certainly useful for troubleshooting. When the full log is archived, this could allow faster point-in-time recovery. In your suggested scheme, this could be a byte offset from the start of the file. In my original scheme, it should probably be LSN, and some searching would be needed to find the record among the log files.

Err codemadness.org 70 i 8428

Err codemadness.org 70 i 8430 Comment by Err codemadness.org 70 i 8431 Minshen Cai Err codemadness.org 70 i 8432 Err codemadness.org 70 i 8433 [ Err codemadness.org 70 i 8434 2018-04-03 Err codemadness.org 70 i 8435 Err codemadness.org 70 i 8436 ] Err codemadness.org 70 i 8437 Err codemadness.org 70 i 8438 Err codemadness.org 70 i 8439

Err codemadness.org 70 i 8441

In my opinion, there are issues on Inaam's idea. The below is a use case.

Err codemadness.org 70 i 8442 1. Mini-transaction m1 updates page A via log file 1, and updates page B via log file 2.

Err codemadness.org 70 i 8443 2. Mini-transaction m2 updates page A via log file 1.

Err codemadness.org 70 i 8444 3. All write to log file 1 completes.

Err codemadness.org 70 i 8445 4. m2 is in the user transaction tr2. tr2 commits successfully.

Err codemadness.org 70 i 8446 5. But at this time, the write to log file 2 for m1 hasn't been finished

Err codemadness.org 70 i 8447 6. The system is killed.

Err codemadness.org 70 i 8448 7. Recover sees the commit of m2. The change of page A made by m2 is replayed.

Err codemadness.org 70 i 8449 8. Recover doesn't see the completed log events of m1 in log file 2. m1 isn't completed. m1 is discarded. The change of page A which is made by m1 is ignored. By this, page A may be inconsistent.

Err codemadness.org 70 i 8450 Err codemadness.org 70 i 8451

In short, there might be uncommitted transactions which modify the same page of our transaction. The mini transactions of such uncommitted ones may write additional log file which is other than the ones written by our transaction. So to avoid the above issue, when commit our transaction, beside of the redo log file the current transaction writes, we also need to flush all redo log files written by such uncommitted transactions.

Err codemadness.org 70 i 8452 Err codemadness.org 70 i 8453

Because of this, Inaam's idea might not perform well in practice.

Err codemadness.org 70 i 8454

Err codemadness.org 70 i 8456 Comment by Err codemadness.org 70 i 8457 Marko Mäkelä Err codemadness.org 70 i 8458 Err codemadness.org 70 i 8459 [ Err codemadness.org 70 i 8460 2018-04-03 Err codemadness.org 70 i 8461 Err codemadness.org 70 i 8462 ] Err codemadness.org 70 i 8463 Err codemadness.org 70 i 8464 Err codemadness.org 70 i 8465

Err codemadness.org 70 i 8467

I agree with Minshen Cai that likely the only practical solution for preventing the scenario is to flush all redo log files whenever state change needs to be made durable in the database. This would seem to remove any performance benefits of partitioning the log file.

Err codemadness.org 70 i 8468 Err codemadness.org 70 i 8469

Inaam Rana’s idea sould still work in special cases, such as when each mini-transaction modifies its private set of pages, or if a (short) user transaction keeps page locks for the whole duration of the transaction. Maybe we could consider having separate groups of undo-redo-log or rseg-redo-log files, and allowing some level of partial ordering among related mini-transaction commits.

Err codemadness.org 70 i 8470 Err codemadness.org 70 i 8471

I was also thinking about extending the checkpoint information. Perhaps we should store all checkpoints in a separate sequential log file, pointing to the individual log files that contain changes since the start of the checkpoint. Perhaps all MLOG_FILE_ entries should be written to the checkpoint log file, while the log record files would only contain page-level log.

Err codemadness.org 70 i 8472

Err codemadness.org 70 i 8474 Comment by Err codemadness.org 70 i 8475 Inaam Rana Err codemadness.org 70 i 8476 Err codemadness.org 70 i 8477 [ Err codemadness.org 70 i 8478 2018-04-04 Err codemadness.org 70 i 8479 Err codemadness.org 70 i 8480 ] Err codemadness.org 70 i 8481 Err codemadness.org 70 i 8482 Err codemadness.org 70 i 8483

Err codemadness.org 70 i 8485

Minshen Cai you are right. I haven't thought it through enough. Back to the drawing board

Err codemadness.org 70 i 8486

Err codemadness.org 70 i 8488 Comment by Err codemadness.org 70 i 8489 Marko Mäkelä Err codemadness.org 70 i 8490 Err codemadness.org 70 i 8491 [ Err codemadness.org 70 i 8492 2018-04-11 Err codemadness.org 70 i 8493 Err codemadness.org 70 i 8494 ] Err codemadness.org 70 i 8495 Err codemadness.org 70 i 8496 Err codemadness.org 70 i 8497

Err codemadness.org 70 i 8499

Regarding the preallocate.c vs append.c, today I found out that there still exist file systems where writing to a preallocated file is faster than appending to a file. This means that we should continue to offer an option where the log file is preallocated and written in circular fashion, instead of being written in append-only mode.

Err codemadness.org 70 i 8500 Err codemadness.org 70 i 8501

I also ran a modified version of preallocate.c that would omit the O_CREAT flag and the posix_fallocate() call. On ext4, fallocate -l 2g file completed in virtually no time, and using the modified test program to write to the preallocated file took around 25 seconds on the same hardware where I previously reported 24.2 seconds.

Err codemadness.org 70 i 8502

Err codemadness.org 70 i 8504 Comment by Err codemadness.org 70 i 8505 Marko Mäkelä Err codemadness.org 70 i 8506 Err codemadness.org 70 i 8507 [ Err codemadness.org 70 i 8508 2018-04-25 Err codemadness.org 70 i 8509 Err codemadness.org 70 i 8510 ] Err codemadness.org 70 i 8511 Err codemadness.org 70 i 8512 Err codemadness.org 70 i 8513

Err codemadness.org 70 i 8515

~~MDEV-15914~~ (and its main fix) showed that a small change to the redo log volume can have a huge impact on performance.

Err codemadness.org 70 i 8516 I think that the redo log record format must allow multiple byte strings to be written to the same page without repeating the tablespace identifier or page number.

Err codemadness.org 70 i 8517

Err codemadness.org 70 i 8519 Comment by Err codemadness.org 70 i 8520 Marko Mäkelä Err codemadness.org 70 i 8521 Err codemadness.org 70 i 8522 [ Err codemadness.org 70 i 8523 2018-04-25 Err codemadness.org 70 i 8524 Err codemadness.org 70 i 8525 ] Err codemadness.org 70 i 8526 Err codemadness.org 70 i 8527 Err codemadness.org 70 i 8528

Err codemadness.org 70 i 8530

The VCDIFF format implemented in Xdelta could be a good starting point for a new redo log format.

Err codemadness.org 70 i 8531

Err codemadness.org 70 i 8533 Comment by Err codemadness.org 70 i 8534 Marko Mäkelä Err codemadness.org 70 i 8535 Err codemadness.org 70 i 8536 [ Err codemadness.org 70 i 8537 2018-05-23 Err codemadness.org 70 i 8538 Err codemadness.org 70 i 8539 ] Err codemadness.org 70 i 8540 Err codemadness.org 70 i 8541 Err codemadness.org 70 i 8542

Err codemadness.org 70 i 8544

The bsdiff format has a different design goal: using a lot of RAM and CPU, create a minimal "binary patch" that can be distributed to a large number of clients. In InnoDB, there usually is at most 1 "consumer" of the redo log: the InnoDB crash recovery.

Err codemadness.org 70 i 8545

Err codemadness.org 70 i 8547 Comment by Err codemadness.org 70 i 8548 Marko Mäkelä Err codemadness.org 70 i 8549 Err codemadness.org 70 i 8550 [ Err codemadness.org 70 i 8551 2018-05-23 Err codemadness.org 70 i 8552 Err codemadness.org 70 i 8553 ] Err codemadness.org 70 i 8554 Err codemadness.org 70 i 8555 Err codemadness.org 70 i 8556

Err codemadness.org 70 i 8558

Related to this work, ~~MDEV-18115~~ will stop creating a fil_space_t object and using the fil_io() and fil_flush(SRV_LOG_SPACE_FIRST_ID) interfaces for writing to the redo log files. This should reduce contention on fil_system.mutex.

Err codemadness.org 70 i 8559

Err codemadness.org 70 i 8561 Comment by Err codemadness.org 70 i 8562 Marko Mäkelä Err codemadness.org 70 i 8563 Err codemadness.org 70 i 8564 [ Err codemadness.org 70 i 8565 2019-02-27 Err codemadness.org 70 i 8566 Err codemadness.org 70 i 8567 ] Err codemadness.org 70 i 8568 Err codemadness.org 70 i 8569 Err codemadness.org 70 i 8570

Err codemadness.org 70 i 8572

While implementing this, we should ensure that the latest redo log block is never being overwritten. InnoDB is currently doing that, and mariabackup is compensating it by re-reading the latest redo log block if it was not completely filled. Rewriting the latest redo log block feels crash-unsafe: if the server is killed during the write, you could end up with a corrupted log block, and lose a few redo log records. Worst case, you would lose a already durable transaction commit, or some pages would have been already flushed with the LSN of the mini-transaction that was lost because of the log block corruption.

Err codemadness.org 70 i 8573

Err codemadness.org 70 i 8575 Comment by Err codemadness.org 70 i 8576 Marko Mäkelä Err codemadness.org 70 i 8577 Err codemadness.org 70 i 8578 [ Err codemadness.org 70 i 8579 2019-03-11 Err codemadness.org 70 i 8580 Err codemadness.org 70 i 8581 ] Err codemadness.org 70 i 8582 Err codemadness.org 70 i 8583 Err codemadness.org 70 i 8584

Err codemadness.org 70 i 8586

I think that it should be simplest to exclusively use synchronous I/O for the redo log. Currently, the log checkpoint write uses asynchronous I/O.

Err codemadness.org 70 i 8587

Err codemadness.org 70 i 8589 Comment by Err codemadness.org 70 i 8590 Marko Mäkelä Err codemadness.org 70 i 8591 Err codemadness.org 70 i 8592 [ Err codemadness.org 70 i 8593 2019-04-09 Err codemadness.org 70 i 8594 Err codemadness.org 70 i 8595 ] Err codemadness.org 70 i 8596 Err codemadness.org 70 i 8597 Err codemadness.org 70 i 8598

Err codemadness.org 70 i 8600

My reading of man 2 write suggests that whether or not the individual redo log files are append-only or written in a circular fashion, we should not need any mutex to guard concurrent writes from multiple threads to a file through a shared file descriptor:

Err codemadness.org 70 i 8601

Err codemadness.org 70 i 8602
For a seekable file (i.e., one to which lseek(2) may be applied, for example, a regular file) writing takes place at the file offset, and the file offset is incremented by the number of bytes actually written. If the file was open(2)ed with O_APPEND, the file offset is first set to the end of the file before writing. The adjustment of the file offset and the write operation are performed as an atomic step.

Err codemadness.org 70 i 8603 …

Err codemadness.org 70 i 8604 BUGS
Err codemadness.org 70 i 8605 Err codemadness.org 70 i 8606
According to POSIX.1-2008/SUSv4 Section XSI 2.9.7 ("Thread Interactions with Regular File Operations"):
Err codemadness.org 70 i 8607 Err codemadness.org 70 i 8608
"All of the following functions shall be atomic with respect to each other in the effects specified in POSIX.1-2008 when they operate on regular files or symbolic links: ..."
Err codemadness.org 70 i 8609 Err codemadness.org 70 i 8610
Among the APIs subsequently listed are write() and writev(2). And among the effects that should be atomic across threads (and processes) are updates of the file offset. However, on Linux before version 3.14, this was not the case: if two processes that share an open file description (see open(2)) perform a write() (or writev(2)) at the same time, then the I/O op‐ erations were not atomic with respect updating the file offset, with the result that the blocks of data output by the two processes might (incorrectly) overlap. This problem was fixed in Linux 3.14.

Err codemadness.org 70 i 8611

The mentioned Linux kernel bug should not affect InnoDB, because InnoDB would be writing to the log files from multiple threads of the same process.

Err codemadness.org 70 i 8612 Err codemadness.org 70 i 8613

The key seems to be to invoke write() or similar function that uses and updates the current position of the file descriptor. pwrite() would require the caller to keep track of a position, and we would do not want that. All the log of the mini-transaction should be written with a single system call. We will probably want some framing with explicit length and checksum around each mini-transaction log snippet, instead of forcing the log to be structured as blocks.

Err codemadness.org 70 i 8614 Err codemadness.org 70 i 8615

Edit: An open problem with multiple concurrent threads writing to a file is that each write can be truncated into a partial write if the write is interrupted by a signal. If such an interrupting signal can be sent only to a subset of the file-writing threads, the log could easily be corrupted. Having the very last write truncated due to the server being killed is tolerable, but continuing writes to the log after a truncated write is not.

Err codemadness.org 70 i 8616 Err codemadness.org 70 i 8617

Hence, I believe that it could be cleaner to have O_DIRECT synchronous write requests from a single thread, writing full, aligned blocks. Partly filled blocks would only be written on log_write_up_to(), just like it is now. The main difference would be that log could be written into multiple files in parallel.

Err codemadness.org 70 i 8618 Err codemadness.org 70 i 8619

We might also employ some form of Lempel-Ziv compression on the log data that is going to be written. This would require identifying some ‘restart points’ for parsing the log.

Err codemadness.org 70 i 8620

Err codemadness.org 70 i 8622 Comment by Err codemadness.org 70 i 8623 Marko Mäkelä Err codemadness.org 70 i 8624 Err codemadness.org 70 i 8625 [ Err codemadness.org 70 i 8626 2019-05-24 Err codemadness.org 70 i 8627 Err codemadness.org 70 i 8628 ] Err codemadness.org 70 i 8629 Err codemadness.org 70 i 8630 Err codemadness.org 70 i 8631

Err codemadness.org 70 i 8633

~~MDEV-12353~~ will improve the format of individual redo log records. This task will implement some framing around them, such as compression, division into blocks, LSN assignment. I think that for now, we will write the entire log of a single mini-transaction into a single log file.

Err codemadness.org 70 i 8634

Err codemadness.org 70 i 8636 Comment by Err codemadness.org 70 i 8637 Marko Mäkelä Err codemadness.org 70 i 8638 Err codemadness.org 70 i 8639 [ Err codemadness.org 70 i 8640 2019-05-31 Err codemadness.org 70 i 8641 Err codemadness.org 70 i 8642 ] Err codemadness.org 70 i 8643 Err codemadness.org 70 i 8644 Err codemadness.org 70 i 8645

Err codemadness.org 70 i 8647

Some ideas for improving the redo log block format:

Err codemadness.org 70 i 8648

Use a variable block size, so that a mini-transaction will never be split between blocks. Write the size at the start of the block and the checksum at the end. In this way, we can make the collection of log records point directly to the parse buffer, and also remove recv_data_copy_to_buf(). (If log blocks are compressed, decompression would output to the parse buffer.)
Each time a new block is seen, it will mark the start of a new mini-transaction. In this way, the log blocks can avoid encoding the LSN (which would grow by one per mini-transaction commit).
Allow NUL-padding of short blocks to the physical block size, so that if a log flush is needed, read-modify-write on the file system can be avoided.

Err codemadness.org 70 i 8653 Err codemadness.org 70 i 8654 Err codemadness.org 70 i 8655

When it comes to file operations and log checkpoints, I think that it could be worthwhile to have a separate sequential log file that keeps a number of latest checkpoints as well as all the file operations. The checkpoint information in the checkpoint log file would point to the data log files, which would only contain page-level redo log records. This would remove the need to call the equivalent of fil_names_clear() at log checkpoint. Only when emptying or rotating the checkpoint log file we would write the equivalent of MLOG_FILE_NAME records to the new checkpoint log file.

Err codemadness.org 70 i 8656

Err codemadness.org 70 i 8658 Comment by Err codemadness.org 70 i 8659 Marko Mäkelä Err codemadness.org 70 i 8660 Err codemadness.org 70 i 8661 [ Err codemadness.org 70 i 8662 2019-10-31 Err codemadness.org 70 i 8663 Err codemadness.org 70 i 8664 ] Err codemadness.org 70 i 8665 Err codemadness.org 70 i 8666 Err codemadness.org 70 i 8667

Err codemadness.org 70 i 8669

I think that we must abandon the idea of partitioning the redo log. I would go with 3 files:

Err codemadness.org 70 i 8670

mostly dummy ib_logfile0 to identify the file format
an append-only, binlog-style-rotated file for checkpoints and file-level operations (create, delete, rename, modify)
a page-level redo log file, 2 variants: block-oriented circular, or append-only
LSN will be logical, incremented by 1 on mtr_t::commit() when redo log records were generated.

Err codemadness.org 70 i 8676 Err codemadness.org 70 i 8677 Err codemadness.org 70 i 8678

Even in the circular log file format, page-level redo log records will never be interrupted by log block trailers or headers. That is, we will write variable-size blocks, with the LSN at the start of the block (to detect the end of "new" log).

Err codemadness.org 70 i 8679 Err codemadness.org 70 i 8680

In the byte-oriented append-only log file format, if a persistent write is requested (on user transaction commit), we will write an extra record that contains a checksum of the bytes that were written since the previous persistent write. The payload of the stream could even be encrypted.

Err codemadness.org 70 i 8681 Err codemadness.org 70 i 8682

To alleviate the log_sys.mutex and log_sys.write_mutex bottleneck, we will introduce a dedicated log writing task, which will:

Err codemadness.org 70 i 8683

Get mtr_t::log records from and encode them to a private buffer of this task
In case of a circular log file, issue a log checkpoint if the log tail would overwrite the head. (Other calls to log_free_check() can be removed!)
Before a log checkpoint is issued, any background crash recovery (MDEV-14481) must be finished.
If persistence is requested, issue a synchronous write of the data to the log file.

Err codemadness.org 70 i 8689 Err codemadness.org 70 i 8690 Err codemadness.org 70 i 8691

Because page-level log records of any single mini-transaction will be continuous streams of bytes in the log file, on recovery we can avoid copying log record snippets to recv_sys.pages. Instead, we can simply attach pointers to log_sys.buf that was read from the page-level redo log file. This should automatically fix ~~MDEV-19176~~ when using the ~~MDEV-12353~~ format. Note: compressing the log record stream could prevent such optimization, so we will not introduce any compression for now.

Err codemadness.org 70 i 8692

Err codemadness.org 70 i 8694 Comment by Err codemadness.org 70 i 8695 Marko Mäkelä Err codemadness.org 70 i 8696 Err codemadness.org 70 i 8697 [ Err codemadness.org 70 i 8698 2019-11-04 Err codemadness.org 70 i 8699 Err codemadness.org 70 i 8700 ] Err codemadness.org 70 i 8701 Err codemadness.org 70 i 8702 Err codemadness.org 70 i 8703

Err codemadness.org 70 i 8705

Currently, on recovery, redo log records are being copied twice from memory to memory:

Err codemadness.org 70 i 8706

from redo log file blocks to contiguous strings of bytes
from contiguous strings of bytes to recv_t (in limited-size chunks that are allocated from the buffer pool)

Err codemadness.org 70 i 8710 Err codemadness.org 70 i 8711 Err codemadness.org 70 i 8712

We have a 2MiB recv_sys.buf for the initial buffering. The minimum size of log_sys.buf would be 16MiB, and that buffer should be practically unused during recovery. If the buffer pool size is measured in gigabytes, it would indeed make sense to use the buffer pool for the recovered log records.

Err codemadness.org 70 i 8713 Err codemadness.org 70 i 8714

I updated ~~MDEV-19176~~ with a suggested design how to improve the buffer pool utilization during crash recovery. It is independent of the redo log record or file format.

Err codemadness.org 70 i 8715

Err codemadness.org 70 i 8717 Comment by Err codemadness.org 70 i 8718 Marko Mäkelä Err codemadness.org 70 i 8719 Err codemadness.org 70 i 8720 [ Err codemadness.org 70 i 8721 2019-11-28 Err codemadness.org 70 i 8722 Err codemadness.org 70 i 8723 ] Err codemadness.org 70 i 8724 Err codemadness.org 70 i 8725 Err codemadness.org 70 i 8726

Err codemadness.org 70 i 8728

When innodb_scrub_log=ON, log checkpoint should clear the unused part of the redo log, simply by invoking fallocate(fd, FALLOC_FL_PUNCH_HOLE, offset, len) or its Windows equivalent. There is no need for a separate log_scrub_thread. The hole-punching should work with both circular and append-only log files.

Err codemadness.org 70 i 8729 Err codemadness.org 70 i 8730

Removing the log_scrub_thread should fix ~~MDEV-18370~~, ~~MDEV-20474~~, ~~MDEV-20475~~.

Err codemadness.org 70 i 8731

Err codemadness.org 70 i 8733 Comment by Err codemadness.org 70 i 8734 Eugene Kosov Err codemadness.org 70 i 8735 Err codemadness.org 70 i 8736 [ Err codemadness.org 70 i 8737 2020-01-05 Err codemadness.org 70 i 8738 Err codemadness.org 70 i 8739 ] Err codemadness.org 70 i 8740 Err codemadness.org 70 i 8741 Err codemadness.org 70 i 8742

Err codemadness.org 70 i 8744

This is my test program which was created to test performance of writing to circular file and appending to file. I've run test on my laptop with HDD and ext4.

Err codemadness.org 70 i 8745 Err codemadness.org 70 i 8746

Results without fsync():

Err codemadness.org 70 i 8747

Err codemadness.org 70 i 8748

Err codemadness.org 70 i 8749 Err codemadness.org 70 i 8750 Err codemadness.org 70 i 8751 Err codemadness.org 70 i 8752 Err codemadness.org 70 i 8755 Err codemadness.org 70 i 8756 Err codemadness.org 70 i 8757 Err codemadness.org 70 i 8760 Err codemadness.org 70 i 8761 Err codemadness.org 70 i 8762 Err codemadness.org 70 i 8765 Err codemadness.org 70 i 8766 Err codemadness.org 70 i 8767 Err codemadness.org 70 i 8770 Err codemadness.org 70 i 8771 Err codemadness.org 70 i 8772 Err codemadness.org 70 i 8775 Err codemadness.org 70 i 8776 Err codemadness.org 70 i 8777 Err codemadness.org 70 i 8780 Err codemadness.org 70 i 8781 Err codemadness.org 70 i 8782 Err codemadness.org 70 i 8785 Err codemadness.org 70 i 8786 Err codemadness.org 70 i 8787 Err codemadness.org 70 i 8790 Err codemadness.org 70 i 8791 Err codemadness.org 70 i 8792 Err codemadness.org 70 i 8795 Err codemadness.org 70 i 8796 Err codemadness.org 70 i 8797 Err codemadness.org 70 i 8800 Err codemadness.org 70 i 8801 Err codemadness.org 70 i 8802 Err codemadness.org 70 i 8805 Err codemadness.org 70 i 8806 Err codemadness.org 70 i 8807 Err codemadness.org 70 i 8810 Err codemadness.org 70 i 8811 Err codemadness.org 70 i 8812 Err codemadness.org 70 i 8815 Err codemadness.org 70 i 8816 Err codemadness.org 70 i 8817 Err codemadness.org 70 i 8821 Err codemadness.org 70 i 8822 Err codemadness.org 70 i 8823

Err codemadness.org 70 i 8753

File size 524288 Kb

Err codemadness.org 70 i 8754

Err codemadness.org 70 i 8758

Writing 4194304 Kb to it

Err codemadness.org 70 i 8759

Err codemadness.org 70 i 8763

Err codemadness.org 70 i 8764

Err codemadness.org 70 i 8768

Simple cyclic file

Err codemadness.org 70 i 8769

Err codemadness.org 70 i 8773

Took 6 seconds 714 milliseconds

Err codemadness.org 70 i 8774

Err codemadness.org 70 i 8778

Err codemadness.org 70 i 8779

Err codemadness.org 70 i 8783

Mmapped cyclic file

Err codemadness.org 70 i 8784

Err codemadness.org 70 i 8788

Took 0 seconds 532 milliseconds

Err codemadness.org 70 i 8789

Err codemadness.org 70 i 8793

Err codemadness.org 70 i 8794

Err codemadness.org 70 i 8798

O_APPEND append file

Err codemadness.org 70 i 8799

Err codemadness.org 70 i 8803

Took 25 seconds 260 milliseconds

Err codemadness.org 70 i 8804

Err codemadness.org 70 i 8808

Err codemadness.org 70 i 8809

Err codemadness.org 70 i 8813

Simple append file

Err codemadness.org 70 i 8814

Err codemadness.org 70 i 8818

Took 24 seconds 623 milliseconds	Err	codemadness.org	70
i  8819

Err codemadness.org 70 i 8820

Err codemadness.org 70 i 8824

Err codemadness.org 70 i 8825

Err codemadness.org 70 i 8826 Err codemadness.org 70 i 8827

Results with fsync():

Err codemadness.org 70 i 8828

Err codemadness.org 70 i 8829

Err codemadness.org 70 i 8830 Err codemadness.org 70 i 8831 Err codemadness.org 70 i 8832 Err codemadness.org 70 i 8833 Err codemadness.org 70 i 8836 Err codemadness.org 70 i 8837 Err codemadness.org 70 i 8838 Err codemadness.org 70 i 8841 Err codemadness.org 70 i 8842 Err codemadness.org 70 i 8843 Err codemadness.org 70 i 8846 Err codemadness.org 70 i 8847 Err codemadness.org 70 i 8848 Err codemadness.org 70 i 8851 Err codemadness.org 70 i 8852 Err codemadness.org 70 i 8853 Err codemadness.org 70 i 8856 Err codemadness.org 70 i 8857 Err codemadness.org 70 i 8858 Err codemadness.org 70 i 8861 Err codemadness.org 70 i 8862 Err codemadness.org 70 i 8863 Err codemadness.org 70 i 8866 Err codemadness.org 70 i 8867 Err codemadness.org 70 i 8868 Err codemadness.org 70 i 8871 Err codemadness.org 70 i 8872 Err codemadness.org 70 i 8873 Err codemadness.org 70 i 8876 Err codemadness.org 70 i 8877 Err codemadness.org 70 i 8878 Err codemadness.org 70 i 8881 Err codemadness.org 70 i 8882 Err codemadness.org 70 i 8883 Err codemadness.org 70 i 8886 Err codemadness.org 70 i 8887 Err codemadness.org 70 i 8888 Err codemadness.org 70 i 8891 Err codemadness.org 70 i 8892 Err codemadness.org 70 i 8893 Err codemadness.org 70 i 8896 Err codemadness.org 70 i 8897 Err codemadness.org 70 i 8898 Err codemadness.org 70 i 8901 Err codemadness.org 70 i 8902 Err codemadness.org 70 i 8903 Err codemadness.org 70 i 8906 Err codemadness.org 70 i 8907 Err codemadness.org 70 i 8908 Err codemadness.org 70 i 8911 Err codemadness.org 70 i 8912 Err codemadness.org 70 i 8913 Err codemadness.org 70 i 8916 Err codemadness.org 70 i 8917 Err codemadness.org 70 i 8918 Err codemadness.org 70 i 8921 Err codemadness.org 70 i 8922 Err codemadness.org 70 i 8923 Err codemadness.org 70 i 8926 Err codemadness.org 70 i 8927 Err codemadness.org 70 i 8928 Err codemadness.org 70 i 8932 Err codemadness.org 70 i 8933 Err codemadness.org 70 i 8934

Err codemadness.org 70 i 8834

File size 1024 Kb

Err codemadness.org 70 i 8835

Err codemadness.org 70 i 8839

Writing 4096 Kb to it

Err codemadness.org 70 i 8840

Err codemadness.org 70 i 8844

Err codemadness.org 70 i 8845

Err codemadness.org 70 i 8849

Simple cyclic file

Err codemadness.org 70 i 8850

Err codemadness.org 70 i 8854

Took 59 seconds 111 milliseconds

Err codemadness.org 70 i 8855

Err codemadness.org 70 i 8859

Err codemadness.org 70 i 8860

Err codemadness.org 70 i 8864

O_DSYNC cyclic file

Err codemadness.org 70 i 8865

Err codemadness.org 70 i 8869

Took 59 seconds 267 milliseconds

Err codemadness.org 70 i 8870

Err codemadness.org 70 i 8874

Err codemadness.org 70 i 8875

Err codemadness.org 70 i 8879

Mmapped cyclic file

Err codemadness.org 70 i 8880

Err codemadness.org 70 i 8884

Took 58 seconds 516 milliseconds

Err codemadness.org 70 i 8885

Err codemadness.org 70 i 8889

Err codemadness.org 70 i 8890

Err codemadness.org 70 i 8894

O_DIRECT|O_DSYNC cyclic file

Err codemadness.org 70 i 8895

Err codemadness.org 70 i 8899

Took 107 seconds 6 milliseconds

Err codemadness.org 70 i 8900

Err codemadness.org 70 i 8904

Err codemadness.org 70 i 8905

Err codemadness.org 70 i 8909

O_APPEND append file

Err codemadness.org 70 i 8910

Err codemadness.org 70 i 8914

Took 202 seconds 492 milliseconds

Err codemadness.org 70 i 8915

Err codemadness.org 70 i 8919

Err codemadness.org 70 i 8920

Err codemadness.org 70 i 8924

Simple append file

Err codemadness.org 70 i 8925

Err codemadness.org 70 i 8929

Took 249 seconds 301 milliseconds	Err	codemadness.org	70
i  8930

Err codemadness.org 70 i 8931

Err codemadness.org 70 i 8935

Err codemadness.org 70 i 8936

Err codemadness.org 70 i 8937 Err codemadness.org 70 i 8938

And the program itself:

Err codemadness.org 70 i 8939

Err codemadness.org 70 i 8940

Err codemadness.org 70 i 8941 Err codemadness.org 70 i 8942 Err codemadness.org 70 i 8943 Err codemadness.org 70 i 8944 Err codemadness.org 70 i 8947 Err codemadness.org 70 i 8948 Err codemadness.org 70 i 8949 Err codemadness.org 70 i 8952 Err codemadness.org 70 i 8953 Err codemadness.org 70 i 8954 Err codemadness.org 70 i 8957 Err codemadness.org 70 i 8958 Err codemadness.org 70 i 8959 Err codemadness.org 70 i 8962 Err codemadness.org 70 i 8963 Err codemadness.org 70 i 8964 Err codemadness.org 70 i 8967 Err codemadness.org 70 i 8968 Err codemadness.org 70 i 8969 Err codemadness.org 70 i 8972 Err codemadness.org 70 i 8973 Err codemadness.org 70 i 8974 Err codemadness.org 70 i 8977 Err codemadness.org 70 i 8978 Err codemadness.org 70 i 8979 Err codemadness.org 70 i 8982 Err codemadness.org 70 i 8983 Err codemadness.org 70 i 8984 Err codemadness.org 70 i 8987 Err codemadness.org 70 i 8988 Err codemadness.org 70 i 8989 Err codemadness.org 70 i 8992 Err codemadness.org 70 i 8993 Err codemadness.org 70 i 8994 Err codemadness.org 70 i 8997 Err codemadness.org 70 i 8998 Err codemadness.org 70 i 8999 Err codemadness.org 70 i 9002 Err codemadness.org 70 i 9003 Err codemadness.org 70 i 9004 Err codemadness.org 70 i 9007 Err codemadness.org 70 i 9008 Err codemadness.org 70 i 9009 Err codemadness.org 70 i 9012 Err codemadness.org 70 i 9013 Err codemadness.org 70 i 9014 Err codemadness.org 70 i 9017 Err codemadness.org 70 i 9018 Err codemadness.org 70 i 9019 Err codemadness.org 70 i 9022 Err codemadness.org 70 i 9023 Err codemadness.org 70 i 9024 Err codemadness.org 70 i 9027 Err codemadness.org 70 i 9028 Err codemadness.org 70 i 9029 Err codemadness.org 70 i 9032 Err codemadness.org 70 i 9033 Err codemadness.org 70 i 9034 Err codemadness.org 70 i 9037 Err codemadness.org 70 i 9038 Err codemadness.org 70 i 9039 Err codemadness.org 70 i 9042 Err codemadness.org 70 i 9043 Err codemadness.org 70 i 9044 Err codemadness.org 70 i 9047 Err codemadness.org 70 i 9048 Err codemadness.org 70 i 9049 Err codemadness.org 70 i 9052 Err codemadness.org 70 i 9053 Err codemadness.org 70 i 9054 Err codemadness.org 70 i 9057 Err codemadness.org 70 i 9058 Err codemadness.org 70 i 9059 Err codemadness.org 70 i 9062 Err codemadness.org 70 i 9063 Err codemadness.org 70 i 9064 Err codemadness.org 70 i 9067 Err codemadness.org 70 i 9068 Err codemadness.org 70 i 9069 Err codemadness.org 70 i 9072 Err codemadness.org 70 i 9073 Err codemadness.org 70 i 9074 Err codemadness.org 70 i 9077 Err codemadness.org 70 i 9078 Err codemadness.org 70 i 9079 Err codemadness.org 70 i 9082 Err codemadness.org 70 i 9083 Err codemadness.org 70 i 9084 Err codemadness.org 70 i 9087 Err codemadness.org 70 i 9088 Err codemadness.org 70 i 9089 Err codemadness.org 70 i 9092 Err codemadness.org 70 i 9093 Err codemadness.org 70 i 9094 Err codemadness.org 70 i 9097 Err codemadness.org 70 i 9098 Err codemadness.org 70 i 9099 Err codemadness.org 70 i 9102 Err codemadness.org 70 i 9103 Err codemadness.org 70 i 9104 Err codemadness.org 70 i 9107 Err codemadness.org 70 i 9108 Err codemadness.org 70 i 9109 Err codemadness.org 70 i 9112 Err codemadness.org 70 i 9113 Err codemadness.org 70 i 9114 Err codemadness.org 70 i 9117 Err codemadness.org 70 i 9118 Err codemadness.org 70 i 9119 Err codemadness.org 70 i 9122 Err codemadness.org 70 i 9123 Err codemadness.org 70 i 9124 Err codemadness.org 70 i 9127 Err codemadness.org 70 i 9128 Err codemadness.org 70 i 9129 Err codemadness.org 70 i 9132 Err codemadness.org 70 i 9133 Err codemadness.org 70 i 9134 Err codemadness.org 70 i 9137 Err codemadness.org 70 i 9138 Err codemadness.org 70 i 9139 Err codemadness.org 70 i 9142 Err codemadness.org 70 i 9143 Err codemadness.org 70 i 9144 Err codemadness.org 70 i 9147 Err codemadness.org 70 i 9148 Err codemadness.org 70 i 9149 Err codemadness.org 70 i 9152 Err codemadness.org 70 i 9153 Err codemadness.org 70 i 9154 Err codemadness.org 70 i 9157 Err codemadness.org 70 i 9158 Err codemadness.org 70 i 9159 Err codemadness.org 70 i 9162 Err codemadness.org 70 i 9163 Err codemadness.org 70 i 9164 Err codemadness.org 70 i 9167 Err codemadness.org 70 i 9168 Err codemadness.org 70 i 9169 Err codemadness.org 70 i 9172 Err codemadness.org 70 i 9173 Err codemadness.org 70 i 9174 Err codemadness.org 70 i 9177 Err codemadness.org 70 i 9178 Err codemadness.org 70 i 9179 Err codemadness.org 70 i 9182 Err codemadness.org 70 i 9183 Err codemadness.org 70 i 9184 Err codemadness.org 70 i 9187 Err codemadness.org 70 i 9188 Err codemadness.org 70 i 9189 Err codemadness.org 70 i 9192 Err codemadness.org 70 i 9193 Err codemadness.org 70 i 9194 Err codemadness.org 70 i 9197 Err codemadness.org 70 i 9198 Err codemadness.org 70 i 9199 Err codemadness.org 70 i 9202 Err codemadness.org 70 i 9203 Err codemadness.org 70 i 9204 Err codemadness.org 70 i 9207 Err codemadness.org 70 i 9208 Err codemadness.org 70 i 9209 Err codemadness.org 70 i 9212 Err codemadness.org 70 i 9213 Err codemadness.org 70 i 9214 Err codemadness.org 70 i 9217 Err codemadness.org 70 i 9218 Err codemadness.org 70 i 9219 Err codemadness.org 70 i 9222 Err codemadness.org 70 i 9223 Err codemadness.org 70 i 9224 Err codemadness.org 70 i 9227 Err codemadness.org 70 i 9228 Err codemadness.org 70 i 9229 Err codemadness.org 70 i 9232 Err codemadness.org 70 i 9233 Err codemadness.org 70 i 9234 Err codemadness.org 70 i 9237 Err codemadness.org 70 i 9238 Err codemadness.org 70 i 9239 Err codemadness.org 70 i 9242 Err codemadness.org 70 i 9243 Err codemadness.org 70 i 9244 Err codemadness.org 70 i 9247 Err codemadness.org 70 i 9248 Err codemadness.org 70 i 9249 Err codemadness.org 70 i 9252 Err codemadness.org 70 i 9253 Err codemadness.org 70 i 9254 Err codemadness.org 70 i 9257 Err codemadness.org 70 i 9258 Err codemadness.org 70 i 9259 Err codemadness.org 70 i 9262 Err codemadness.org 70 i 9263 Err codemadness.org 70 i 9264 Err codemadness.org 70 i 9267 Err codemadness.org 70 i 9268 Err codemadness.org 70 i 9269 Err codemadness.org 70 i 9272 Err codemadness.org 70 i 9273 Err codemadness.org 70 i 9274 Err codemadness.org 70 i 9277 Err codemadness.org 70 i 9278 Err codemadness.org 70 i 9279 Err codemadness.org 70 i 9282 Err codemadness.org 70 i 9283 Err codemadness.org 70 i 9284 Err codemadness.org 70 i 9287 Err codemadness.org 70 i 9288 Err codemadness.org 70 i 9289 Err codemadness.org 70 i 9292 Err codemadness.org 70 i 9293 Err codemadness.org 70 i 9294 Err codemadness.org 70 i 9297 Err codemadness.org 70 i 9298 Err codemadness.org 70 i 9299 Err codemadness.org 70 i 9302 Err codemadness.org 70 i 9303 Err codemadness.org 70 i 9304 Err codemadness.org 70 i 9307 Err codemadness.org 70 i 9308 Err codemadness.org 70 i 9309 Err codemadness.org 70 i 9312 Err codemadness.org 70 i 9313 Err codemadness.org 70 i 9314 Err codemadness.org 70 i 9317 Err codemadness.org 70 i 9318 Err codemadness.org 70 i 9319 Err codemadness.org 70 i 9322 Err codemadness.org 70 i 9323 Err codemadness.org 70 i 9324 Err codemadness.org 70 i 9327 Err codemadness.org 70 i 9328 Err codemadness.org 70 i 9329 Err codemadness.org 70 i 9332 Err codemadness.org 70 i 9333 Err codemadness.org 70 i 9334 Err codemadness.org 70 i 9337 Err codemadness.org 70 i 9338 Err codemadness.org 70 i 9339 Err codemadness.org 70 i 9342 Err codemadness.org 70 i 9343 Err codemadness.org 70 i 9344 Err codemadness.org 70 i 9347 Err codemadness.org 70 i 9348 Err codemadness.org 70 i 9349 Err codemadness.org 70 i 9352 Err codemadness.org 70 i 9353 Err codemadness.org 70 i 9354 Err codemadness.org 70 i 9357 Err codemadness.org 70 i 9358 Err codemadness.org 70 i 9359 Err codemadness.org 70 i 9362 Err codemadness.org 70 i 9363 Err codemadness.org 70 i 9364 Err codemadness.org 70 i 9367 Err codemadness.org 70 i 9368 Err codemadness.org 70 i 9369 Err codemadness.org 70 i 9372 Err codemadness.org 70 i 9373 Err codemadness.org 70 i 9374 Err codemadness.org 70 i 9377 Err codemadness.org 70 i 9378 Err codemadness.org 70 i 9379 Err codemadness.org 70 i 9382 Err codemadness.org 70 i 9383 Err codemadness.org 70 i 9384 Err codemadness.org 70 i 9387 Err codemadness.org 70 i 9388 Err codemadness.org 70 i 9389 Err codemadness.org 70 i 9392 Err codemadness.org 70 i 9393 Err codemadness.org 70 i 9394 Err codemadness.org 70 i 9397 Err codemadness.org 70 i 9398 Err codemadness.org 70 i 9399 Err codemadness.org 70 i 9402 Err codemadness.org 70 i 9403 Err codemadness.org 70 i 9404 Err codemadness.org 70 i 9407 Err codemadness.org 70 i 9408 Err codemadness.org 70 i 9409 Err codemadness.org 70 i 9412 Err codemadness.org 70 i 9413 Err codemadness.org 70 i 9414 Err codemadness.org 70 i 9417 Err codemadness.org 70 i 9418 Err codemadness.org 70 i 9419 Err codemadness.org 70 i 9422 Err codemadness.org 70 i 9423 Err codemadness.org 70 i 9424 Err codemadness.org 70 i 9427 Err codemadness.org 70 i 9428 Err codemadness.org 70 i 9429 Err codemadness.org 70 i 9432 Err codemadness.org 70 i 9433 Err codemadness.org 70 i 9434 Err codemadness.org 70 i 9437 Err codemadness.org 70 i 9438 Err codemadness.org 70 i 9439 Err codemadness.org 70 i 9442 Err codemadness.org 70 i 9443 Err codemadness.org 70 i 9444 Err codemadness.org 70 i 9447 Err codemadness.org 70 i 9448 Err codemadness.org 70 i 9449 Err codemadness.org 70 i 9452 Err codemadness.org 70 i 9453 Err codemadness.org 70 i 9454 Err codemadness.org 70 i 9457 Err codemadness.org 70 i 9458 Err codemadness.org 70 i 9459 Err codemadness.org 70 i 9462 Err codemadness.org 70 i 9463 Err codemadness.org 70 i 9464 Err codemadness.org 70 i 9467 Err codemadness.org 70 i 9468 Err codemadness.org 70 i 9469 Err codemadness.org 70 i 9472 Err codemadness.org 70 i 9473 Err codemadness.org 70 i 9474 Err codemadness.org 70 i 9477 Err codemadness.org 70 i 9478 Err codemadness.org 70 i 9479 Err codemadness.org 70 i 9482 Err codemadness.org 70 i 9483 Err codemadness.org 70 i 9484 Err codemadness.org 70 i 9487 Err codemadness.org 70 i 9488 Err codemadness.org 70 i 9489 Err codemadness.org 70 i 9492 Err codemadness.org 70 i 9493 Err codemadness.org 70 i 9494 Err codemadness.org 70 i 9497 Err codemadness.org 70 i 9498 Err codemadness.org 70 i 9499 Err codemadness.org 70 i 9502 Err codemadness.org 70 i 9503 Err codemadness.org 70 i 9504 Err codemadness.org 70 i 9507 Err codemadness.org 70 i 9508 Err codemadness.org 70 i 9509 Err codemadness.org 70 i 9512 Err codemadness.org 70 i 9513 Err codemadness.org 70 i 9514 Err codemadness.org 70 i 9517 Err codemadness.org 70 i 9518 Err codemadness.org 70 i 9519 Err codemadness.org 70 i 9522 Err codemadness.org 70 i 9523 Err codemadness.org 70 i 9524 Err codemadness.org 70 i 9527 Err codemadness.org 70 i 9528 Err codemadness.org 70 i 9529 Err codemadness.org 70 i 9532 Err codemadness.org 70 i 9533 Err codemadness.org 70 i 9534 Err codemadness.org 70 i 9537 Err codemadness.org 70 i 9538 Err codemadness.org 70 i 9539 Err codemadness.org 70 i 9542 Err codemadness.org 70 i 9543 Err codemadness.org 70 i 9544 Err codemadness.org 70 i 9547 Err codemadness.org 70 i 9548 Err codemadness.org 70 i 9549 Err codemadness.org 70 i 9552 Err codemadness.org 70 i 9553 Err codemadness.org 70 i 9554 Err codemadness.org 70 i 9557 Err codemadness.org 70 i 9558 Err codemadness.org 70 i 9559 Err codemadness.org 70 i 9562 Err codemadness.org 70 i 9563 Err codemadness.org 70 i 9564 Err codemadness.org 70 i 9567 Err codemadness.org 70 i 9568 Err codemadness.org 70 i 9569 Err codemadness.org 70 i 9572 Err codemadness.org 70 i 9573 Err codemadness.org 70 i 9574 Err codemadness.org 70 i 9577 Err codemadness.org 70 i 9578 Err codemadness.org 70 i 9579 Err codemadness.org 70 i 9582 Err codemadness.org 70 i 9583 Err codemadness.org 70 i 9584 Err codemadness.org 70 i 9587 Err codemadness.org 70 i 9588 Err codemadness.org 70 i 9589 Err codemadness.org 70 i 9592 Err codemadness.org 70 i 9593 Err codemadness.org 70 i 9594 Err codemadness.org 70 i 9597 Err codemadness.org 70 i 9598 Err codemadness.org 70 i 9599 Err codemadness.org 70 i 9602 Err codemadness.org 70 i 9603 Err codemadness.org 70 i 9604 Err codemadness.org 70 i 9607 Err codemadness.org 70 i 9608 Err codemadness.org 70 i 9609 Err codemadness.org 70 i 9612 Err codemadness.org 70 i 9613 Err codemadness.org 70 i 9614 Err codemadness.org 70 i 9617 Err codemadness.org 70 i 9618 Err codemadness.org 70 i 9619 Err codemadness.org 70 i 9622 Err codemadness.org 70 i 9623 Err codemadness.org 70 i 9624 Err codemadness.org 70 i 9627 Err codemadness.org 70 i 9628 Err codemadness.org 70 i 9629 Err codemadness.org 70 i 9632 Err codemadness.org 70 i 9633 Err codemadness.org 70 i 9634 Err codemadness.org 70 i 9637 Err codemadness.org 70 i 9638 Err codemadness.org 70 i 9639 Err codemadness.org 70 i 9642 Err codemadness.org 70 i 9643 Err codemadness.org 70 i 9644 Err codemadness.org 70 i 9647 Err codemadness.org 70 i 9648 Err codemadness.org 70 i 9649 Err codemadness.org 70 i 9652 Err codemadness.org 70 i 9653 Err codemadness.org 70 i 9654 Err codemadness.org 70 i 9657 Err codemadness.org 70 i 9658 Err codemadness.org 70 i 9659 Err codemadness.org 70 i 9662 Err codemadness.org 70 i 9663 Err codemadness.org 70 i 9664 Err codemadness.org 70 i 9667 Err codemadness.org 70 i 9668 Err codemadness.org 70 i 9669 Err codemadness.org 70 i 9672 Err codemadness.org 70 i 9673 Err codemadness.org 70 i 9674 Err codemadness.org 70 i 9677 Err codemadness.org 70 i 9678 Err codemadness.org 70 i 9679 Err codemadness.org 70 i 9682 Err codemadness.org 70 i 9683 Err codemadness.org 70 i 9684 Err codemadness.org 70 i 9687 Err codemadness.org 70 i 9688 Err codemadness.org 70 i 9689 Err codemadness.org 70 i 9692 Err codemadness.org 70 i 9693 Err codemadness.org 70 i 9694 Err codemadness.org 70 i 9697 Err codemadness.org 70 i 9698 Err codemadness.org 70 i 9699 Err codemadness.org 70 i 9702 Err codemadness.org 70 i 9703 Err codemadness.org 70 i 9704 Err codemadness.org 70 i 9707 Err codemadness.org 70 i 9708 Err codemadness.org 70 i 9709 Err codemadness.org 70 i 9712 Err codemadness.org 70 i 9713 Err codemadness.org 70 i 9714 Err codemadness.org 70 i 9717 Err codemadness.org 70 i 9718 Err codemadness.org 70 i 9719 Err codemadness.org 70 i 9722 Err codemadness.org 70 i 9723 Err codemadness.org 70 i 9724 Err codemadness.org 70 i 9727 Err codemadness.org 70 i 9728 Err codemadness.org 70 i 9729 Err codemadness.org 70 i 9732 Err codemadness.org 70 i 9733 Err codemadness.org 70 i 9734 Err codemadness.org 70 i 9737 Err codemadness.org 70 i 9738 Err codemadness.org 70 i 9739 Err codemadness.org 70 i 9742 Err codemadness.org 70 i 9743 Err codemadness.org 70 i 9744 Err codemadness.org 70 i 9747 Err codemadness.org 70 i 9748 Err codemadness.org 70 i 9749 Err codemadness.org 70 i 9752 Err codemadness.org 70 i 9753 Err codemadness.org 70 i 9754 Err codemadness.org 70 i 9757 Err codemadness.org 70 i 9758 Err codemadness.org 70 i 9759 Err codemadness.org 70 i 9762 Err codemadness.org 70 i 9763 Err codemadness.org 70 i 9764 Err codemadness.org 70 i 9767 Err codemadness.org 70 i 9768 Err codemadness.org 70 i 9769 Err codemadness.org 70 i 9772 Err codemadness.org 70 i 9773 Err codemadness.org 70 i 9774 Err codemadness.org 70 i 9777 Err codemadness.org 70 i 9778 Err codemadness.org 70 i 9779 Err codemadness.org 70 i 9782 Err codemadness.org 70 i 9783 Err codemadness.org 70 i 9784 Err codemadness.org 70 i 9787 Err codemadness.org 70 i 9788 Err codemadness.org 70 i 9789 Err codemadness.org 70 i 9792 Err codemadness.org 70 i 9793 Err codemadness.org 70 i 9794 Err codemadness.org 70 i 9797 Err codemadness.org 70 i 9798 Err codemadness.org 70 i 9799 Err codemadness.org 70 i 9802 Err codemadness.org 70 i 9803 Err codemadness.org 70 i 9804 Err codemadness.org 70 i 9807 Err codemadness.org 70 i 9808 Err codemadness.org 70 i 9809 Err codemadness.org 70 i 9812 Err codemadness.org 70 i 9813 Err codemadness.org 70 i 9814 Err codemadness.org 70 i 9817 Err codemadness.org 70 i 9818 Err codemadness.org 70 i 9819 Err codemadness.org 70 i 9822 Err codemadness.org 70 i 9823 Err codemadness.org 70 i 9824 Err codemadness.org 70 i 9827 Err codemadness.org 70 i 9828 Err codemadness.org 70 i 9829 Err codemadness.org 70 i 9832 Err codemadness.org 70 i 9833 Err codemadness.org 70 i 9834 Err codemadness.org 70 i 9837 Err codemadness.org 70 i 9838 Err codemadness.org 70 i 9839 Err codemadness.org 70 i 9842 Err codemadness.org 70 i 9843 Err codemadness.org 70 i 9844 Err codemadness.org 70 i 9847 Err codemadness.org 70 i 9848 Err codemadness.org 70 i 9849 Err codemadness.org 70 i 9852 Err codemadness.org 70 i 9853 Err codemadness.org 70 i 9854 Err codemadness.org 70 i 9857 Err codemadness.org 70 i 9858 Err codemadness.org 70 i 9859 Err codemadness.org 70 i 9862 Err codemadness.org 70 i 9863 Err codemadness.org 70 i 9864 Err codemadness.org 70 i 9867 Err codemadness.org 70 i 9868 Err codemadness.org 70 i 9869 Err codemadness.org 70 i 9872 Err codemadness.org 70 i 9873 Err codemadness.org 70 i 9874 Err codemadness.org 70 i 9877 Err codemadness.org 70 i 9878 Err codemadness.org 70 i 9879 Err codemadness.org 70 i 9882 Err codemadness.org 70 i 9883 Err codemadness.org 70 i 9884 Err codemadness.org 70 i 9887 Err codemadness.org 70 i 9888 Err codemadness.org 70 i 9889 Err codemadness.org 70 i 9892 Err codemadness.org 70 i 9893 Err codemadness.org 70 i 9894 Err codemadness.org 70 i 9897 Err codemadness.org 70 i 9898 Err codemadness.org 70 i 9899 Err codemadness.org 70 i 9902 Err codemadness.org 70 i 9903 Err codemadness.org 70 i 9904 Err codemadness.org 70 i 9907 Err codemadness.org 70 i 9908 Err codemadness.org 70 i 9909 Err codemadness.org 70 i 9912 Err codemadness.org 70 i 9913 Err codemadness.org 70 i 9914 Err codemadness.org 70 i 9917 Err codemadness.org 70 i 9918 Err codemadness.org 70 i 9919 Err codemadness.org 70 i 9922 Err codemadness.org 70 i 9923 Err codemadness.org 70 i 9924 Err codemadness.org 70 i 9927 Err codemadness.org 70 i 9928 Err codemadness.org 70 i 9929 Err codemadness.org 70 i 9932 Err codemadness.org 70 i 9933 Err codemadness.org 70 i 9934 Err codemadness.org 70 i 9937 Err codemadness.org 70 i 9938 Err codemadness.org 70 i 9939 Err codemadness.org 70 i 9942 Err codemadness.org 70 i 9943 Err codemadness.org 70 i 9944 Err codemadness.org 70 i 9947 Err codemadness.org 70 i 9948 Err codemadness.org 70 i 9949 Err codemadness.org 70 i 9952 Err codemadness.org 70 i 9953 Err codemadness.org 70 i 9954 Err codemadness.org 70 i 9957 Err codemadness.org 70 i 9958 Err codemadness.org 70 i 9959 Err codemadness.org 70 i 9962 Err codemadness.org 70 i 9963 Err codemadness.org 70 i 9964 Err codemadness.org 70 i 9967 Err codemadness.org 70 i 9968 Err codemadness.org 70 i 9969 Err codemadness.org 70 i 9972 Err codemadness.org 70 i 9973 Err codemadness.org 70 i 9974 Err codemadness.org 70 i 9977 Err codemadness.org 70 i 9978 Err codemadness.org 70 i 9979 Err codemadness.org 70 i 9982 Err codemadness.org 70 i 9983 Err codemadness.org 70 i 9984 Err codemadness.org 70 i 9987 Err codemadness.org 70 i 9988 Err codemadness.org 70 i 9989 Err codemadness.org 70 i 9992 Err codemadness.org 70 i 9993 Err codemadness.org 70 i 9994 Err codemadness.org 70 i 9997 Err codemadness.org 70 i 9998 Err codemadness.org 70 i 9999 Err codemadness.org 70 i 10002 Err codemadness.org 70 i 10003 Err codemadness.org 70 i 10004 Err codemadness.org 70 i 10007 Err codemadness.org 70 i 10008 Err codemadness.org 70 i 10009 Err codemadness.org 70 i 10012 Err codemadness.org 70 i 10013 Err codemadness.org 70 i 10014 Err codemadness.org 70 i 10017 Err codemadness.org 70 i 10018 Err codemadness.org 70 i 10019 Err codemadness.org 70 i 10022 Err codemadness.org 70 i 10023 Err codemadness.org 70 i 10024 Err codemadness.org 70 i 10027 Err codemadness.org 70 i 10028 Err codemadness.org 70 i 10029 Err codemadness.org 70 i 10032 Err codemadness.org 70 i 10033 Err codemadness.org 70 i 10034 Err codemadness.org 70 i 10037 Err codemadness.org 70 i 10038 Err codemadness.org 70 i 10039 Err codemadness.org 70 i 10042 Err codemadness.org 70 i 10043 Err codemadness.org 70 i 10044 Err codemadness.org 70 i 10047 Err codemadness.org 70 i 10048 Err codemadness.org 70 i 10049 Err codemadness.org 70 i 10052 Err codemadness.org 70 i 10053 Err codemadness.org 70 i 10054 Err codemadness.org 70 i 10057 Err codemadness.org 70 i 10058 Err codemadness.org 70 i 10059 Err codemadness.org 70 i 10062 Err codemadness.org 70 i 10063 Err codemadness.org 70 i 10064 Err codemadness.org 70 i 10067 Err codemadness.org 70 i 10068 Err codemadness.org 70 i 10069 Err codemadness.org 70 i 10072 Err codemadness.org 70 i 10073 Err codemadness.org 70 i 10074 Err codemadness.org 70 i 10077 Err codemadness.org 70 i 10078 Err codemadness.org 70 i 10079 Err codemadness.org 70 i 10082 Err codemadness.org 70 i 10083 Err codemadness.org 70 i 10084 Err codemadness.org 70 i 10087 Err codemadness.org 70 i 10088 Err codemadness.org 70 i 10089 Err codemadness.org 70 i 10092 Err codemadness.org 70 i 10093 Err codemadness.org 70 i 10094 Err codemadness.org 70 i 10097 Err codemadness.org 70 i 10098 Err codemadness.org 70 i 10099 Err codemadness.org 70 i 10102 Err codemadness.org 70 i 10103 Err codemadness.org 70 i 10104 Err codemadness.org 70 i 10107 Err codemadness.org 70 i 10108 Err codemadness.org 70 i 10109 Err codemadness.org 70 i 10112 Err codemadness.org 70 i 10113 Err codemadness.org 70 i 10114 Err codemadness.org 70 i 10117 Err codemadness.org 70 i 10118 Err codemadness.org 70 i 10119 Err codemadness.org 70 i 10122 Err codemadness.org 70 i 10123 Err codemadness.org 70 i 10124 Err codemadness.org 70 i 10127 Err codemadness.org 70 i 10128 Err codemadness.org 70 i 10129 Err codemadness.org 70 i 10132 Err codemadness.org 70 i 10133 Err codemadness.org 70 i 10134 Err codemadness.org 70 i 10137 Err codemadness.org 70 i 10138 Err codemadness.org 70 i 10139 Err codemadness.org 70 i 10142 Err codemadness.org 70 i 10143 Err codemadness.org 70 i 10144 Err codemadness.org 70 i 10147 Err codemadness.org 70 i 10148 Err codemadness.org 70 i 10149 Err codemadness.org 70 i 10152 Err codemadness.org 70 i 10153 Err codemadness.org 70 i 10154 Err codemadness.org 70 i 10157 Err codemadness.org 70 i 10158 Err codemadness.org 70 i 10159 Err codemadness.org 70 i 10162 Err codemadness.org 70 i 10163 Err codemadness.org 70 i 10164 Err codemadness.org 70 i 10167 Err codemadness.org 70 i 10168 Err codemadness.org 70 i 10169 Err codemadness.org 70 i 10172 Err codemadness.org 70 i 10173 Err codemadness.org 70 i 10174 Err codemadness.org 70 i 10177 Err codemadness.org 70 i 10178 Err codemadness.org 70 i 10179 Err codemadness.org 70 i 10182 Err codemadness.org 70 i 10183 Err codemadness.org 70 i 10184 Err codemadness.org 70 i 10187 Err codemadness.org 70 i 10188 Err codemadness.org 70 i 10189 Err codemadness.org 70 i 10192 Err codemadness.org 70 i 10193 Err codemadness.org 70 i 10194 Err codemadness.org 70 i 10197 Err codemadness.org 70 i 10198 Err codemadness.org 70 i 10199 Err codemadness.org 70 i 10202 Err codemadness.org 70 i 10203 Err codemadness.org 70 i 10204 Err codemadness.org 70 i 10207 Err codemadness.org 70 i 10208 Err codemadness.org 70 i 10209 Err codemadness.org 70 i 10212 Err codemadness.org 70 i 10213 Err codemadness.org 70 i 10214 Err codemadness.org 70 i 10217 Err codemadness.org 70 i 10218 Err codemadness.org 70 i 10219 Err codemadness.org 70 i 10222 Err codemadness.org 70 i 10223 Err codemadness.org 70 i 10224 Err codemadness.org 70 i 10227 Err codemadness.org 70 i 10228 Err codemadness.org 70 i 10229 Err codemadness.org 70 i 10232 Err codemadness.org 70 i 10233 Err codemadness.org 70 i 10234 Err codemadness.org 70 i 10237 Err codemadness.org 70 i 10238 Err codemadness.org 70 i 10239 Err codemadness.org 70 i 10242 Err codemadness.org 70 i 10243 Err codemadness.org 70 i 10244 Err codemadness.org 70 i 10247 Err codemadness.org 70 i 10248 Err codemadness.org 70 i 10249 Err codemadness.org 70 i 10252 Err codemadness.org 70 i 10253 Err codemadness.org 70 i 10254 Err codemadness.org 70 i 10257 Err codemadness.org 70 i 10258 Err codemadness.org 70 i 10259 Err codemadness.org 70 i 10262 Err codemadness.org 70 i 10263 Err codemadness.org 70 i 10264 Err codemadness.org 70 i 10267 Err codemadness.org 70 i 10268 Err codemadness.org 70 i 10269 Err codemadness.org 70 i 10272 Err codemadness.org 70 i 10273 Err codemadness.org 70 i 10274 Err codemadness.org 70 i 10277 Err codemadness.org 70 i 10278 Err codemadness.org 70 i 10279 Err codemadness.org 70 i 10282 Err codemadness.org 70 i 10283 Err codemadness.org 70 i 10284 Err codemadness.org 70 i 10287 Err codemadness.org 70 i 10288 Err codemadness.org 70 i 10289 Err codemadness.org 70 i 10292 Err codemadness.org 70 i 10293 Err codemadness.org 70 i 10294 Err codemadness.org 70 i 10297 Err codemadness.org 70 i 10298 Err codemadness.org 70 i 10299 Err codemadness.org 70 i 10302 Err codemadness.org 70 i 10303 Err codemadness.org 70 i 10304 Err codemadness.org 70 i 10307 Err codemadness.org 70 i 10308 Err codemadness.org 70 i 10309 Err codemadness.org 70 i 10312 Err codemadness.org 70 i 10313 Err codemadness.org 70 i 10314 Err codemadness.org 70 i 10317 Err codemadness.org 70 i 10318 Err codemadness.org 70 i 10319 Err codemadness.org 70 i 10322 Err codemadness.org 70 i 10323 Err codemadness.org 70 i 10324 Err codemadness.org 70 i 10327 Err codemadness.org 70 i 10328 Err codemadness.org 70 i 10329 Err codemadness.org 70 i 10332 Err codemadness.org 70 i 10333 Err codemadness.org 70 i 10334 Err codemadness.org 70 i 10337 Err codemadness.org 70 i 10338 Err codemadness.org 70 i 10339 Err codemadness.org 70 i 10342 Err codemadness.org 70 i 10343 Err codemadness.org 70 i 10344 Err codemadness.org 70 i 10347 Err codemadness.org 70 i 10348 Err codemadness.org 70 i 10349 Err codemadness.org 70 i 10352 Err codemadness.org 70 i 10353 Err codemadness.org 70 i 10354 Err codemadness.org 70 i 10357 Err codemadness.org 70 i 10358 Err codemadness.org 70 i 10359 Err codemadness.org 70 i 10362 Err codemadness.org 70 i 10363 Err codemadness.org 70 i 10364 Err codemadness.org 70 i 10367 Err codemadness.org 70 i 10368 Err codemadness.org 70 i 10369 Err codemadness.org 70 i 10372 Err codemadness.org 70 i 10373 Err codemadness.org 70 i 10374 Err codemadness.org 70 i 10377 Err codemadness.org 70 i 10378 Err codemadness.org 70 i 10379 Err codemadness.org 70 i 10382 Err codemadness.org 70 i 10383 Err codemadness.org 70 i 10384 Err codemadness.org 70 i 10387 Err codemadness.org 70 i 10388 Err codemadness.org 70 i 10389 Err codemadness.org 70 i 10392 Err codemadness.org 70 i 10393 Err codemadness.org 70 i 10394 Err codemadness.org 70 i 10397 Err codemadness.org 70 i 10398 Err codemadness.org 70 i 10399 Err codemadness.org 70 i 10402 Err codemadness.org 70 i 10403 Err codemadness.org 70 i 10404 Err codemadness.org 70 i 10407 Err codemadness.org 70 i 10408 Err codemadness.org 70 i 10409 Err codemadness.org 70 i 10412 Err codemadness.org 70 i 10413 Err codemadness.org 70 i 10414 Err codemadness.org 70 i 10417 Err codemadness.org 70 i 10418 Err codemadness.org 70 i 10419 Err codemadness.org 70 i 10422 Err codemadness.org 70 i 10423 Err codemadness.org 70 i 10424 Err codemadness.org 70 i 10427 Err codemadness.org 70 i 10428 Err codemadness.org 70 i 10429 Err codemadness.org 70 i 10432 Err codemadness.org 70 i 10433 Err codemadness.org 70 i 10434 Err codemadness.org 70 i 10437 Err codemadness.org 70 i 10438 Err codemadness.org 70 i 10439 Err codemadness.org 70 i 10442 Err codemadness.org 70 i 10443 Err codemadness.org 70 i 10444 Err codemadness.org 70 i 10447 Err codemadness.org 70 i 10448 Err codemadness.org 70 i 10449 Err codemadness.org 70 i 10452 Err codemadness.org 70 i 10453 Err codemadness.org 70 i 10454 Err codemadness.org 70 i 10457 Err codemadness.org 70 i 10458 Err codemadness.org 70 i 10459 Err codemadness.org 70 i 10462 Err codemadness.org 70 i 10463 Err codemadness.org 70 i 10464 Err codemadness.org 70 i 10467 Err codemadness.org 70 i 10468 Err codemadness.org 70 i 10469 Err codemadness.org 70 i 10472 Err codemadness.org 70 i 10473 Err codemadness.org 70 i 10474 Err codemadness.org 70 i 10477 Err codemadness.org 70 i 10478 Err codemadness.org 70 i 10479 Err codemadness.org 70 i 10482 Err codemadness.org 70 i 10483 Err codemadness.org 70 i 10484 Err codemadness.org 70 i 10487 Err codemadness.org 70 i 10488 Err codemadness.org 70 i 10489 Err codemadness.org 70 i 10493 Err codemadness.org 70 i 10494 Err codemadness.org 70 i 10495

Err codemadness.org 70 i 8945

#include <sys/types.h>

Err codemadness.org 70 i 8946

Err codemadness.org 70 i 8950

#include <sys/mman.h>

Err codemadness.org 70 i 8951

Err codemadness.org 70 i 8955

#include <sys/stat.h>

Err codemadness.org 70 i 8956

Err codemadness.org 70 i 8960

#include <fcntl.h>

Err codemadness.org 70 i 8961

Err codemadness.org 70 i 8965

#include <unistd.h>

Err codemadness.org 70 i 8966

Err codemadness.org 70 i 8970

Err codemadness.org 70 i 8971

Err codemadness.org 70 i 8975

#include <cerrno>

Err codemadness.org 70 i 8976

Err codemadness.org 70 i 8980

#include <cassert>

Err codemadness.org 70 i 8981

Err codemadness.org 70 i 8985

#include <cstdlib>

Err codemadness.org 70 i 8986

Err codemadness.org 70 i 8990

#include <cstring>

Err codemadness.org 70 i 8991

Err codemadness.org 70 i 8995

Err codemadness.org 70 i 8996

Err codemadness.org 70 i 9000

#include <array>

Err codemadness.org 70 i 9001

Err codemadness.org 70 i 9005

#include <chrono>

Err codemadness.org 70 i 9006

Err codemadness.org 70 i 9010

#include <string>

Err codemadness.org 70 i 9011

Err codemadness.org 70 i 9015

#include <iostream>

Err codemadness.org 70 i 9016

Err codemadness.org 70 i 9020

Err codemadness.org 70 i 9021

Err codemadness.org 70 i 9025

static const size_t kWriteTotal = 4 * 1024 * 1024;

Err codemadness.org 70 i 9026

Err codemadness.org 70 i 9030

static const size_t kFileSize = 1 * 1024 * 1024;

Err codemadness.org 70 i 9031

Err codemadness.org 70 i 9035

static const std::array<unsigned char, 1024> kBuf = { 33 };

Err codemadness.org 70 i 9036

Err codemadness.org 70 i 9040

static const std::array<unsigned char, 1024> kAlignedBuf alignas(512) = { 33 };

Err codemadness.org 70 i 9041

Err codemadness.org 70 i 9045

static_assert(kFileSize % kBuf.size() == 0, "");

Err codemadness.org 70 i 9046

Err codemadness.org 70 i 9050

static const std::string kPath = "test_file";

Err codemadness.org 70 i 9051

Err codemadness.org 70 i 9055

Err codemadness.org 70 i 9056

Err codemadness.org 70 i 9060

void ShowErrnoAndExit(std::string function_name) {

Err codemadness.org 70 i 9061

Err codemadness.org 70 i 9065

  std::cerr << function_name << " returned errno " << strerror(errno) << "\n";

Err codemadness.org 70 i 9066

Err codemadness.org 70 i 9070

  std::exit(EXIT_FAILURE);

Err codemadness.org 70 i 9071

Err codemadness.org 70 i 9075

Err codemadness.org 70 i 9076

Err codemadness.org 70 i 9080

Err codemadness.org 70 i 9081

Err codemadness.org 70 i 9085

struct File {

Err codemadness.org 70 i 9086

Err codemadness.org 70 i 9090

  File(std::string path, int additional_flags = 0) : path_(std::move(path)) {

Err codemadness.org 70 i 9091

Err codemadness.org 70 i 9095

    fd_ = open(path_.c_str(),

Err codemadness.org 70 i 9096

Err codemadness.org 70 i 9100

               O_CREAT | O_TRUNC | O_RDWR | additional_flags,

Err codemadness.org 70 i 9101

Err codemadness.org 70 i 9105

               S_IRUSR | S_IWUSR);

Err codemadness.org 70 i 9106

Err codemadness.org 70 i 9110

    if (fd_ == -1)

Err codemadness.org 70 i 9111

Err codemadness.org 70 i 9115

      ShowErrnoAndExit("open()");

Err codemadness.org 70 i 9116

Err codemadness.org 70 i 9120

Err codemadness.org 70 i 9121

Err codemadness.org 70 i 9125

Err codemadness.org 70 i 9126

Err codemadness.org 70 i 9130

  void Resize(off_t length) {

Err codemadness.org 70 i 9131

Err codemadness.org 70 i 9135

    assert(fd_ != -1);

Err codemadness.org 70 i 9136

Err codemadness.org 70 i 9140

Err codemadness.org 70 i 9141

Err codemadness.org 70 i 9145

    if (int ret = posix_fallocate(fd_, 0, length)) {

Err codemadness.org 70 i 9146

Err codemadness.org 70 i 9150

      errno = ret;

Err codemadness.org 70 i 9151

Err codemadness.org 70 i 9155

      ShowErrnoAndExit("posix_fallocate()");

Err codemadness.org 70 i 9156

Err codemadness.org 70 i 9160

Err codemadness.org 70 i 9161

Err codemadness.org 70 i 9165

Err codemadness.org 70 i 9166

Err codemadness.org 70 i 9170

Err codemadness.org 70 i 9171

Err codemadness.org 70 i 9175

  void Write(const void *buf, size_t count) {

Err codemadness.org 70 i 9176

Err codemadness.org 70 i 9180

    assert(fd_ != -1);

Err codemadness.org 70 i 9181

Err codemadness.org 70 i 9185

Err codemadness.org 70 i 9186

Err codemadness.org 70 i 9190

    ssize_t ret = write(fd_, buf, count);

Err codemadness.org 70 i 9191

Err codemadness.org 70 i 9195

    if (ret == -1)

Err codemadness.org 70 i 9196

Err codemadness.org 70 i 9200

      ShowErrnoAndExit("write()");

Err codemadness.org 70 i 9201

Err codemadness.org 70 i 9205

Err codemadness.org 70 i 9206

Err codemadness.org 70 i 9210

    if (static_cast<size_t>(ret) != count) {

Err codemadness.org 70 i 9211

Err codemadness.org 70 i 9215

      std::cerr << "write() partial write\n";

Err codemadness.org 70 i 9216

Err codemadness.org 70 i 9220

      std::exit(EXIT_FAILURE);

Err codemadness.org 70 i 9221

Err codemadness.org 70 i 9225

Err codemadness.org 70 i 9226

Err codemadness.org 70 i 9230

Err codemadness.org 70 i 9231

Err codemadness.org 70 i 9235

Err codemadness.org 70 i 9236

Err codemadness.org 70 i 9240

  void PWrite(const void *buf, size_t count, off_t offset) {

Err codemadness.org 70 i 9241

Err codemadness.org 70 i 9245

    assert(fd_ != -1);

Err codemadness.org 70 i 9246

Err codemadness.org 70 i 9250

Err codemadness.org 70 i 9251

Err codemadness.org 70 i 9255

    ssize_t ret = pwrite(fd_, buf, count, offset);

Err codemadness.org 70 i 9256

Err codemadness.org 70 i 9260

    if (ret == -1)

Err codemadness.org 70 i 9261

Err codemadness.org 70 i 9265

      ShowErrnoAndExit("pwrite()");

Err codemadness.org 70 i 9266

Err codemadness.org 70 i 9270

Err codemadness.org 70 i 9271

Err codemadness.org 70 i 9275

    if (static_cast<size_t>(ret) != count) {

Err codemadness.org 70 i 9276

Err codemadness.org 70 i 9280

      std::cerr << "pwrite() partial write\n";

Err codemadness.org 70 i 9281

Err codemadness.org 70 i 9285

      std::exit(EXIT_FAILURE);

Err codemadness.org 70 i 9286

Err codemadness.org 70 i 9290

Err codemadness.org 70 i 9291

Err codemadness.org 70 i 9295

Err codemadness.org 70 i 9296

Err codemadness.org 70 i 9300

Err codemadness.org 70 i 9301

Err codemadness.org 70 i 9305

  void Fsync() {

Err codemadness.org 70 i 9306

Err codemadness.org 70 i 9310

    assert(fd_ != -1);

Err codemadness.org 70 i 9311

Err codemadness.org 70 i 9315

Err codemadness.org 70 i 9316

Err codemadness.org 70 i 9320

    if (fsync(fd_) == -1)

Err codemadness.org 70 i 9321

Err codemadness.org 70 i 9325

      ShowErrnoAndExit("fsync()");

Err codemadness.org 70 i 9326

Err codemadness.org 70 i 9330

Err codemadness.org 70 i 9331

Err codemadness.org 70 i 9335

Err codemadness.org 70 i 9336

Err codemadness.org 70 i 9340

  void Fdatasync() {

Err codemadness.org 70 i 9341

Err codemadness.org 70 i 9345

    assert(fd_ != -1);

Err codemadness.org 70 i 9346

Err codemadness.org 70 i 9350

Err codemadness.org 70 i 9351

Err codemadness.org 70 i 9355

    if (fdatasync(fd_) == -1)

Err codemadness.org 70 i 9356

Err codemadness.org 70 i 9360

      ShowErrnoAndExit("fdatasync()");

Err codemadness.org 70 i 9361

Err codemadness.org 70 i 9365

Err codemadness.org 70 i 9366

Err codemadness.org 70 i 9370

Err codemadness.org 70 i 9371

Err codemadness.org 70 i 9375

  size_t Size() {

Err codemadness.org 70 i 9376

Err codemadness.org 70 i 9380

    assert(fd_ != 1);

Err codemadness.org 70 i 9381

Err codemadness.org 70 i 9385

Err codemadness.org 70 i 9386

Err codemadness.org 70 i 9390

    struct stat s;

Err codemadness.org 70 i 9391

Err codemadness.org 70 i 9395

    if (fstat(fd_, &s) == -1)

Err codemadness.org 70 i 9396

Err codemadness.org 70 i 9400

      ShowErrnoAndExit("fstat()");

Err codemadness.org 70 i 9401

Err codemadness.org 70 i 9405

Err codemadness.org 70 i 9406

Err codemadness.org 70 i 9410

    return s.st_size;

Err codemadness.org 70 i 9411

Err codemadness.org 70 i 9415

Err codemadness.org 70 i 9416

Err codemadness.org 70 i 9420

Err codemadness.org 70 i 9421

Err codemadness.org 70 i 9425

  void Mmap() {

Err codemadness.org 70 i 9426

Err codemadness.org 70 i 9430

    assert(fd_ != -1);

Err codemadness.org 70 i 9431

Err codemadness.org 70 i 9435

Err codemadness.org 70 i 9436

Err codemadness.org 70 i 9440

    size_t size = Size();

Err codemadness.org 70 i 9441

Err codemadness.org 70 i 9445

    mapped_ = mmap(nullptr, size,

Err codemadness.org 70 i 9446

Err codemadness.org 70 i 9450

                   PROT_READ | PROT_WRITE,

Err codemadness.org 70 i 9451

Err codemadness.org 70 i 9455

                   MAP_SHARED | MAP_POPULATE,

Err codemadness.org 70 i 9456

Err codemadness.org 70 i 9460

                   fd_, 0);

Err codemadness.org 70 i 9461

Err codemadness.org 70 i 9465

    if (mapped_ == MAP_FAILED)

Err codemadness.org 70 i 9466

Err codemadness.org 70 i 9470

      ShowErrnoAndExit("mmap()");

Err codemadness.org 70 i 9471

Err codemadness.org 70 i 9475

Err codemadness.org 70 i 9476

Err codemadness.org 70 i 9480

Err codemadness.org 70 i 9481

Err codemadness.org 70 i 9485

  unsigned char *GetMmappedRegion() {

Err codemadness.org 70 i 9486

Err codemadness.org 70 i 9490

    assert(fd_ != -1);

Err codemadness.org 70 i 9491

Err codemadness.org 70 i 9495

    assert(mapped_);

Err codemadness.org 70 i 9496

Err codemadness.org 70 i 9500

Err codemadness.org 70 i 9501

Err codemadness.org 70 i 9505

    return static_cast<unsigned char *>(mapped_);

Err codemadness.org 70 i 9506

Err codemadness.org 70 i 9510

Err codemadness.org 70 i 9511

Err codemadness.org 70 i 9515

Err codemadness.org 70 i 9516

Err codemadness.org 70 i 9520

  void Msync(void *addr, size_t len) {

Err codemadness.org 70 i 9521

Err codemadness.org 70 i 9525

    if (msync(addr, len, MS_SYNC) == -1) {

Err codemadness.org 70 i 9526

Err codemadness.org 70 i 9530

      ShowErrnoAndExit("msync()");

Err codemadness.org 70 i 9531

Err codemadness.org 70 i 9535

Err codemadness.org 70 i 9536

Err codemadness.org 70 i 9540

Err codemadness.org 70 i 9541

Err codemadness.org 70 i 9545

Err codemadness.org 70 i 9546

Err codemadness.org 70 i 9550

  void Munmap() {

Err codemadness.org 70 i 9551

Err codemadness.org 70 i 9555

    assert(fd_ != -1);

Err codemadness.org 70 i 9556

Err codemadness.org 70 i 9560

    assert(mapped_ != nullptr);

Err codemadness.org 70 i 9561

Err codemadness.org 70 i 9565

Err codemadness.org 70 i 9566

Err codemadness.org 70 i 9570

    if (munmap(mapped_, Size()) == -1)

Err codemadness.org 70 i 9571

Err codemadness.org 70 i 9575

      ShowErrnoAndExit("munmap()");

Err codemadness.org 70 i 9576

Err codemadness.org 70 i 9580

Err codemadness.org 70 i 9581

Err codemadness.org 70 i 9585

    mapped_ = nullptr;

Err codemadness.org 70 i 9586

Err codemadness.org 70 i 9590

Err codemadness.org 70 i 9591

Err codemadness.org 70 i 9595

Err codemadness.org 70 i 9596

Err codemadness.org 70 i 9600

  ~File() {

Err codemadness.org 70 i 9601

Err codemadness.org 70 i 9605

    if (mapped_)

Err codemadness.org 70 i 9606

Err codemadness.org 70 i 9610

      Munmap();

Err codemadness.org 70 i 9611

Err codemadness.org 70 i 9615

Err codemadness.org 70 i 9616

Err codemadness.org 70 i 9620

    if (fd_ != -1 && close(fd_) == -1)

Err codemadness.org 70 i 9621

Err codemadness.org 70 i 9625

      ShowErrnoAndExit("close()");

Err codemadness.org 70 i 9626

Err codemadness.org 70 i 9630

Err codemadness.org 70 i 9631

Err codemadness.org 70 i 9635

Err codemadness.org 70 i 9636

Err codemadness.org 70 i 9640

    if (unlink(path_.c_str()) == -1)

Err codemadness.org 70 i 9641

Err codemadness.org 70 i 9645

      ShowErrnoAndExit("unlink()");

Err codemadness.org 70 i 9646

Err codemadness.org 70 i 9650

Err codemadness.org 70 i 9651

Err codemadness.org 70 i 9655

Err codemadness.org 70 i 9656

Err codemadness.org 70 i 9660

  int fd_{-1};

Err codemadness.org 70 i 9661

Err codemadness.org 70 i 9665

  void *mapped_{nullptr};

Err codemadness.org 70 i 9666

Err codemadness.org 70 i 9670

  std::string path_;

Err codemadness.org 70 i 9671

Err codemadness.org 70 i 9675

};

Err codemadness.org 70 i 9676

Err codemadness.org 70 i 9680

Err codemadness.org 70 i 9681

Err codemadness.org 70 i 9685

struct SimpleCyclicWriter {

Err codemadness.org 70 i 9686

Err codemadness.org 70 i 9690

  SimpleCyclicWriter(std::string path) : file_(path) {

Err codemadness.org 70 i 9691

Err codemadness.org 70 i 9695

    file_.Resize(kFileSize);

Err codemadness.org 70 i 9696

Err codemadness.org 70 i 9700

    file_.Fsync();

Err codemadness.org 70 i 9701

Err codemadness.org 70 i 9705

Err codemadness.org 70 i 9706

Err codemadness.org 70 i 9710

Err codemadness.org 70 i 9711

Err codemadness.org 70 i 9715

  static std::string Name()  { return "Simple cyclic file"; }

Err codemadness.org 70 i 9716

Err codemadness.org 70 i 9720

Err codemadness.org 70 i 9721

Err codemadness.org 70 i 9725

  void Write() {

Err codemadness.org 70 i 9726

Err codemadness.org 70 i 9730

    const off_t offset = offset_ % kFileSize;

Err codemadness.org 70 i 9731

Err codemadness.org 70 i 9735

    file_.PWrite(kBuf.data(), kBuf.size(), offset);

Err codemadness.org 70 i 9736

Err codemadness.org 70 i 9740

    offset_ += kBuf.size();

Err codemadness.org 70 i 9741

Err codemadness.org 70 i 9745

Err codemadness.org 70 i 9746

Err codemadness.org 70 i 9750

Err codemadness.org 70 i 9751

Err codemadness.org 70 i 9755

  void Flush() { file_.Fdatasync(); }

Err codemadness.org 70 i 9756

Err codemadness.org 70 i 9760

Err codemadness.org 70 i 9761

Err codemadness.org 70 i 9765

  File file_;

Err codemadness.org 70 i 9766

Err codemadness.org 70 i 9770

  off_t offset_{0};

Err codemadness.org 70 i 9771

Err codemadness.org 70 i 9775

};

Err codemadness.org 70 i 9776

Err codemadness.org 70 i 9780

Err codemadness.org 70 i 9781

Err codemadness.org 70 i 9785

struct DSyncCyclicWriter {

Err codemadness.org 70 i 9786

Err codemadness.org 70 i 9790

  DSyncCyclicWriter(std::string path) : file_(path, O_DSYNC) {

Err codemadness.org 70 i 9791

Err codemadness.org 70 i 9795

    file_.Resize(kFileSize);

Err codemadness.org 70 i 9796

Err codemadness.org 70 i 9800

    file_.Fsync();

Err codemadness.org 70 i 9801

Err codemadness.org 70 i 9805

Err codemadness.org 70 i 9806

Err codemadness.org 70 i 9810

Err codemadness.org 70 i 9811

Err codemadness.org 70 i 9815

  static std::string Name()  { return "O_DSYNC cyclic file"; }

Err codemadness.org 70 i 9816

Err codemadness.org 70 i 9820

Err codemadness.org 70 i 9821

Err codemadness.org 70 i 9825

  void Write() {

Err codemadness.org 70 i 9826

Err codemadness.org 70 i 9830

    const off_t offset = offset_ % kFileSize;

Err codemadness.org 70 i 9831

Err codemadness.org 70 i 9835

    file_.PWrite(kBuf.data(), kBuf.size(), offset);

Err codemadness.org 70 i 9836

Err codemadness.org 70 i 9840

    offset_ += kBuf.size();

Err codemadness.org 70 i 9841

Err codemadness.org 70 i 9845

Err codemadness.org 70 i 9846

Err codemadness.org 70 i 9850

Err codemadness.org 70 i 9851

Err codemadness.org 70 i 9855

  void Flush() { }

Err codemadness.org 70 i 9856

Err codemadness.org 70 i 9860

Err codemadness.org 70 i 9861

Err codemadness.org 70 i 9865

  File file_;

Err codemadness.org 70 i 9866

Err codemadness.org 70 i 9870

  off_t offset_{0};

Err codemadness.org 70 i 9871

Err codemadness.org 70 i 9875

};

Err codemadness.org 70 i 9876

Err codemadness.org 70 i 9880

Err codemadness.org 70 i 9881

Err codemadness.org 70 i 9885

struct ODirectODsyncCyclicWriter {

Err codemadness.org 70 i 9886

Err codemadness.org 70 i 9890

  ODirectODsyncCyclicWriter(std::string path) :

Err codemadness.org 70 i 9891

Err codemadness.org 70 i 9895

      file_(path, O_DIRECT | O_DSYNC) {

Err codemadness.org 70 i 9896

Err codemadness.org 70 i 9900

    file_.Resize(kFileSize);

Err codemadness.org 70 i 9901

Err codemadness.org 70 i 9905

    file_.Fsync();

Err codemadness.org 70 i 9906

Err codemadness.org 70 i 9910

Err codemadness.org 70 i 9911

Err codemadness.org 70 i 9915

Err codemadness.org 70 i 9916

Err codemadness.org 70 i 9920

  static std::string Name()  { return "O_DIRECT|O_DSYNC cyclic file"; }

Err codemadness.org 70 i 9921

Err codemadness.org 70 i 9925

Err codemadness.org 70 i 9926

Err codemadness.org 70 i 9930

  void Write() {

Err codemadness.org 70 i 9931

Err codemadness.org 70 i 9935

    const off_t offset = offset_ % kFileSize;

Err codemadness.org 70 i 9936

Err codemadness.org 70 i 9940

    file_.PWrite(kAlignedBuf.data(), kAlignedBuf.size(), offset);

Err codemadness.org 70 i 9941

Err codemadness.org 70 i 9945

    offset_ += kAlignedBuf.size();

Err codemadness.org 70 i 9946

Err codemadness.org 70 i 9950

Err codemadness.org 70 i 9951

Err codemadness.org 70 i 9955

Err codemadness.org 70 i 9956

Err codemadness.org 70 i 9960

  void Flush() { }

Err codemadness.org 70 i 9961

Err codemadness.org 70 i 9965

Err codemadness.org 70 i 9966

Err codemadness.org 70 i 9970

  File file_;

Err codemadness.org 70 i 9971

Err codemadness.org 70 i 9975

  off_t offset_{0};

Err codemadness.org 70 i 9976

Err codemadness.org 70 i 9980

};

Err codemadness.org 70 i 9981

Err codemadness.org 70 i 9985

Err codemadness.org 70 i 9986

Err codemadness.org 70 i 9990

struct MmappedCyclicWriter {

Err codemadness.org 70 i 9991

Err codemadness.org 70 i 9995

  MmappedCyclicWriter(std::string path) : file_(path) {

Err codemadness.org 70 i 9996

Err codemadness.org 70 i 10000

    file_.Resize(kFileSize);

Err codemadness.org 70 i 10001

Err codemadness.org 70 i 10005

    file_.Fsync();

Err codemadness.org 70 i 10006

Err codemadness.org 70 i 10010

    file_.Mmap();

Err codemadness.org 70 i 10011

Err codemadness.org 70 i 10015

Err codemadness.org 70 i 10016

Err codemadness.org 70 i 10020

Err codemadness.org 70 i 10021

Err codemadness.org 70 i 10025

  static std::string Name()  { return "Mmapped cyclic file"; }

Err codemadness.org 70 i 10026

Err codemadness.org 70 i 10030

Err codemadness.org 70 i 10031

Err codemadness.org 70 i 10035

  void Write() {

Err codemadness.org 70 i 10036

Err codemadness.org 70 i 10040

    const off_t offset = offset_ % kFileSize;

Err codemadness.org 70 i 10041

Err codemadness.org 70 i 10045

    memcpy(file_.GetMmappedRegion() + offset, kBuf.data(), kBuf.size());

Err codemadness.org 70 i 10046

Err codemadness.org 70 i 10050

    prev_offset_ = offset;

Err codemadness.org 70 i 10051

Err codemadness.org 70 i 10055

    offset_ += kBuf.size();

Err codemadness.org 70 i 10056

Err codemadness.org 70 i 10060

Err codemadness.org 70 i 10061

Err codemadness.org 70 i 10065

Err codemadness.org 70 i 10066

Err codemadness.org 70 i 10070

  void Flush() {

Err codemadness.org 70 i 10071

Err codemadness.org 70 i 10075

    auto *start = file_.GetMmappedRegion() + prev_offset_;

Err codemadness.org 70 i 10076

Err codemadness.org 70 i 10080

    auto *end = start + kBuf.size();

Err codemadness.org 70 i 10081

Err codemadness.org 70 i 10085

    start = start - reinterpret_cast<std::uintptr_t>(start) % page_size_;

Err codemadness.org 70 i 10086

Err codemadness.org 70 i 10090

Err codemadness.org 70 i 10091

Err codemadness.org 70 i 10095

    assert(start >= file_.GetMmappedRegion());

Err codemadness.org 70 i 10096

Err codemadness.org 70 i 10100

    assert(end <= file_.GetMmappedRegion() + file_.Size());

Err codemadness.org 70 i 10101

Err codemadness.org 70 i 10105

    file_.Msync(start, end - start);

Err codemadness.org 70 i 10106

Err codemadness.org 70 i 10110

Err codemadness.org 70 i 10111

Err codemadness.org 70 i 10115

Err codemadness.org 70 i 10116

Err codemadness.org 70 i 10120

  File file_;

Err codemadness.org 70 i 10121

Err codemadness.org 70 i 10125

  uintptr_t page_size_{static_cast<uintptr_t>(sysconf(_SC_PAGE_SIZE))};

Err codemadness.org 70 i 10126

Err codemadness.org 70 i 10130

  off_t prev_offset_{0};

Err codemadness.org 70 i 10131

Err codemadness.org 70 i 10135

  off_t offset_{0};

Err codemadness.org 70 i 10136

Err codemadness.org 70 i 10140

};

Err codemadness.org 70 i 10141

Err codemadness.org 70 i 10145

Err codemadness.org 70 i 10146

Err codemadness.org 70 i 10150

struct OAppendAppendWriter {

Err codemadness.org 70 i 10151

Err codemadness.org 70 i 10155

  OAppendAppendWriter(std::string path) : file_(path, O_APPEND) {}

Err codemadness.org 70 i 10156

Err codemadness.org 70 i 10160

Err codemadness.org 70 i 10161

Err codemadness.org 70 i 10165

  static std::string Name()  { return "O_APPEND append file"; }

Err codemadness.org 70 i 10166

Err codemadness.org 70 i 10170

Err codemadness.org 70 i 10171

Err codemadness.org 70 i 10175

  void Write() { file_.Write(kBuf.data(), kBuf.size()); }

Err codemadness.org 70 i 10176

Err codemadness.org 70 i 10180

  void Flush() { file_.Fsync(); }

Err codemadness.org 70 i 10181

Err codemadness.org 70 i 10185

Err codemadness.org 70 i 10186

Err codemadness.org 70 i 10190

  File file_;

Err codemadness.org 70 i 10191

Err codemadness.org 70 i 10195

};

Err codemadness.org 70 i 10196

Err codemadness.org 70 i 10200

Err codemadness.org 70 i 10201

Err codemadness.org 70 i 10205

struct SimpleAppendWriter {

Err codemadness.org 70 i 10206

Err codemadness.org 70 i 10210

  SimpleAppendWriter(std::string path) : file_(path) {}

Err codemadness.org 70 i 10211

Err codemadness.org 70 i 10215

Err codemadness.org 70 i 10216

Err codemadness.org 70 i 10220

  static std::string Name()  { return "Simple append file"; }

Err codemadness.org 70 i 10221

Err codemadness.org 70 i 10225

Err codemadness.org 70 i 10226

Err codemadness.org 70 i 10230

  void Write() { file_.Write(kBuf.data(), kBuf.size()); }

Err codemadness.org 70 i 10231

Err codemadness.org 70 i 10235

  void Flush() { file_.Fsync(); }

Err codemadness.org 70 i 10236

Err codemadness.org 70 i 10240

Err codemadness.org 70 i 10241

Err codemadness.org 70 i 10245

  File file_;

Err codemadness.org 70 i 10246

Err codemadness.org 70 i 10250

};

Err codemadness.org 70 i 10251

Err codemadness.org 70 i 10255

Err codemadness.org 70 i 10256

Err codemadness.org 70 i 10260

struct Timer {

Err codemadness.org 70 i 10261

Err codemadness.org 70 i 10265

  using Clock = std::chrono::steady_clock;

Err codemadness.org 70 i 10266

Err codemadness.org 70 i 10270

Err codemadness.org 70 i 10271

Err codemadness.org 70 i 10275

  ~Timer() {

Err codemadness.org 70 i 10276

Err codemadness.org 70 i 10280

    auto duration = Clock::now() - now_;

Err codemadness.org 70 i 10281

Err codemadness.org 70 i 10285

    auto ms = std::chrono::duration_cast<std::chrono::milliseconds>(duration);

Err codemadness.org 70 i 10286

Err codemadness.org 70 i 10290

    auto s = std::chrono::duration_cast<std::chrono::seconds>(ms);

Err codemadness.org 70 i 10291

Err codemadness.org 70 i 10295

    ms = ms - s;

Err codemadness.org 70 i 10296

Err codemadness.org 70 i 10300

    std::cout << "Took " << s.count() << " seconds " << ms.count() <<

Err codemadness.org 70 i 10301

Err codemadness.org 70 i 10305

        " milliseconds\n";

Err codemadness.org 70 i 10306

Err codemadness.org 70 i 10310

Err codemadness.org 70 i 10311

Err codemadness.org 70 i 10315

Err codemadness.org 70 i 10316

Err codemadness.org 70 i 10320

  Clock::time_point now_ = Clock::now();

Err codemadness.org 70 i 10321

Err codemadness.org 70 i 10325

};

Err codemadness.org 70 i 10326

Err codemadness.org 70 i 10330

Err codemadness.org 70 i 10331

Err codemadness.org 70 i 10335

template <class Writer>

Err codemadness.org 70 i 10336

Err codemadness.org 70 i 10340

void Test() {

Err codemadness.org 70 i 10341

Err codemadness.org 70 i 10345

  std::cout << Writer::Name() << "\n";

Err codemadness.org 70 i 10346

Err codemadness.org 70 i 10350

  Writer file_(kPath);

Err codemadness.org 70 i 10351

Err codemadness.org 70 i 10355

Err codemadness.org 70 i 10356

Err codemadness.org 70 i 10360

Err codemadness.org 70 i 10361

Err codemadness.org 70 i 10365

    Timer timer;

Err codemadness.org 70 i 10366

Err codemadness.org 70 i 10370

    size_t write_total = kWriteTotal;

Err codemadness.org 70 i 10371

Err codemadness.org 70 i 10375

    while (write_total) {

Err codemadness.org 70 i 10376

Err codemadness.org 70 i 10380

      file_.Write();

Err codemadness.org 70 i 10381

Err codemadness.org 70 i 10385

      file_.Flush();

Err codemadness.org 70 i 10386

Err codemadness.org 70 i 10390

      write_total -= kBuf.size();

Err codemadness.org 70 i 10391

Err codemadness.org 70 i 10395

Err codemadness.org 70 i 10396

Err codemadness.org 70 i 10400

Err codemadness.org 70 i 10401

Err codemadness.org 70 i 10405

Err codemadness.org 70 i 10406

Err codemadness.org 70 i 10410

  std::cout << "\n";

Err codemadness.org 70 i 10411

Err codemadness.org 70 i 10415

Err codemadness.org 70 i 10416

Err codemadness.org 70 i 10420

Err codemadness.org 70 i 10421

Err codemadness.org 70 i 10425

int main() {

Err codemadness.org 70 i 10426

Err codemadness.org 70 i 10430

  std::cout << "File size " << kFileSize / 1024 << " Kb\n";

Err codemadness.org 70 i 10431

Err codemadness.org 70 i 10435

  std::cout << "Writing " << kWriteTotal / 1024 << " Kb to it\n";

Err codemadness.org 70 i 10436

Err codemadness.org 70 i 10440

  std::cout << "\n";

Err codemadness.org 70 i 10441

Err codemadness.org 70 i 10445

Err codemadness.org 70 i 10446

Err codemadness.org 70 i 10450

  Test<SimpleCyclicWriter>();

Err codemadness.org 70 i 10451

Err codemadness.org 70 i 10455

  Test<DSyncCyclicWriter>();

Err codemadness.org 70 i 10456

Err codemadness.org 70 i 10460

  Test<MmappedCyclicWriter>();

Err codemadness.org 70 i 10461

Err codemadness.org 70 i 10465

  Test<ODirectODsyncCyclicWriter>();

Err codemadness.org 70 i 10466

Err codemadness.org 70 i 10470

  Test<OAppendAppendWriter>();

Err codemadness.org 70 i 10471

Err codemadness.org 70 i 10475

  Test<SimpleAppendWriter>();

Err codemadness.org 70 i 10476

Err codemadness.org 70 i 10480

Err codemadness.org 70 i 10481

Err codemadness.org 70 i 10485

  return EXIT_SUCCESS;

Err codemadness.org 70 i 10486

Err codemadness.org 70 i 10490

}	Err	codemadness.org	70
i 10491

Err codemadness.org 70 i 10492

Err codemadness.org 70 i 10496

Err codemadness.org 70 i 10497

Err codemadness.org 70 i 10498 Err codemadness.org 70 i 10499

So, writing to circular file is clearly much faster than appending to file.

Err codemadness.org 70 i 10500

Err codemadness.org 70 i 10502 Comment by Err codemadness.org 70 i 10503 Eugene Kosov Err codemadness.org 70 i 10504 Err codemadness.org 70 i 10505 [ Err codemadness.org 70 i 10506 2020-01-07 Err codemadness.org 70 i 10507 Err codemadness.org 70 i 10508 ] Err codemadness.org 70 i 10509 Err codemadness.org 70 i 10510 Err codemadness.org 70 i 10511

Err codemadness.org 70 i 10513

Jun Su Daniel Black could you please run my program on some server hardware? I have no access to anything but my not so up to date laptop.

Err codemadness.org 70 i 10514 Err codemadness.org 70 i 10515

The biggest questing is to decide what's faster: appending to file or writing to a circular file. Sorry, no CLI interface for my program, but you tweak file size and amount of data to write by changing globals.

Err codemadness.org 70 i 10516

Err codemadness.org 70 i 10518 Comment by Err codemadness.org 70 i 10519 zongzhi chen Err codemadness.org 70 i 10520 Err codemadness.org 70 i 10521 [ Err codemadness.org 70 i 10522 2020-01-07 Err codemadness.org 70 i 10523 Err codemadness.org 70 i 10524 ] Err codemadness.org 70 i 10525 Err codemadness.org 70 i 10526 Err codemadness.org 70 i 10527

Err codemadness.org 70 i 10529

Hey guys. I have done almost the same work. change the redo log from circular file to appending to new file..

Err codemadness.org 70 i 10530 Of course writing to circular file is much faster than appending to file. Since when appending to file, it need to modify the inode and allocate an extent to the file, which need about 8 times than writing to circular file. I have show the result in this slide https://www.slideshare.net/baotiao/polardb-percona19 from page 18.

Err codemadness.org 70 i 10531 However, writing to circular file need to solve "read-on-write" issue, but appending to file don't need it.

Err codemadness.org 70 i 10532 Err codemadness.org 70 i 10533

so the way we use in our environment is that when there is no stale redo log file, we allocate a new redo log file and filling the file with zero. And in the background, if we don't need some stale redo log file, we don't delete directly, we rename the stale file as new redo log file. And in InnoDB, we also padding the write to 4k to avoid the "read-on-write" issue.

Err codemadness.org 70 i 10534

Err codemadness.org 70 i 10536 Comment by Err codemadness.org 70 i 10537 Daniel Black Err codemadness.org 70 i 10538 Err codemadness.org 70 i 10539 [ Err codemadness.org 70 i 10540 2020-01-08 Err codemadness.org 70 i 10541 Err codemadness.org 70 i 10542 ] Err codemadness.org 70 i 10543 Err codemadness.org 70 i 10544 Err codemadness.org 70 i 10545

Err codemadness.org 70 i 10547

Err codemadness.org 70 i 10548

Err codemadness.org 70 i 10549 Err codemadness.org 70 i 10550 Err codemadness.org 70 i 10551 Err codemadness.org 70 i 10552 Err codemadness.org 70 i 10555 Err codemadness.org 70 i 10556 Err codemadness.org 70 i 10557 Err codemadness.org 70 i 10558 Err codemadness.org 70 i 10559 Err codemadness.org 70 i 10562 Err codemadness.org 70 i 10563 Err codemadness.org 70 i 10564 Err codemadness.org 70 i 10567 Err codemadness.org 70 i 10568 Err codemadness.org 70 i 10569 Err codemadness.org 70 i 10573 Err codemadness.org 70 i 10574 Err codemadness.org 70 i 10575

Err codemadness.org 70 i 10553 'expanded size' Err codemadness.org 70 i 10554
Err codemadness.org 70 i 10560 static const size_t kFileSize = 1 * 128 * 1024 * 1024; Err codemadness.org 70 i 10561
Err codemadness.org 70 i 10565 Err codemadness.org 70 i 10566
Err codemadness.org 70 i 10570 static const size_t kWriteTotal = 4 * kFileSize; Err codemadness.org 70 i 10571 Err codemadness.org 70 i 10572

Err codemadness.org 70 i 10576

Err codemadness.org 70 i 10577

Err codemadness.org 70 i 10578 Err codemadness.org 70 i 10579

Err codemadness.org 70 i 10580

Err codemadness.org 70 i 10581 Err codemadness.org 70 i 10582 Err codemadness.org 70 i 10583 Err codemadness.org 70 i 10584 Err codemadness.org 70 i 10587 Err codemadness.org 70 i 10588 Err codemadness.org 70 i 10589 Err codemadness.org 70 i 10590 Err codemadness.org 70 i 10591 Err codemadness.org 70 i 10594 Err codemadness.org 70 i 10595 Err codemadness.org 70 i 10596 Err codemadness.org 70 i 10599 Err codemadness.org 70 i 10600 Err codemadness.org 70 i 10601 Err codemadness.org 70 i 10604 Err codemadness.org 70 i 10605 Err codemadness.org 70 i 10606 Err codemadness.org 70 i 10609 Err codemadness.org 70 i 10610 Err codemadness.org 70 i 10611 Err codemadness.org 70 i 10614 Err codemadness.org 70 i 10615 Err codemadness.org 70 i 10616 Err codemadness.org 70 i 10619 Err codemadness.org 70 i 10620 Err codemadness.org 70 i 10621 Err codemadness.org 70 i 10624 Err codemadness.org 70 i 10625 Err codemadness.org 70 i 10626 Err codemadness.org 70 i 10629 Err codemadness.org 70 i 10630 Err codemadness.org 70 i 10631 Err codemadness.org 70 i 10634 Err codemadness.org 70 i 10635 Err codemadness.org 70 i 10636 Err codemadness.org 70 i 10639 Err codemadness.org 70 i 10640 Err codemadness.org 70 i 10641 Err codemadness.org 70 i 10644 Err codemadness.org 70 i 10645 Err codemadness.org 70 i 10646 Err codemadness.org 70 i 10649 Err codemadness.org 70 i 10650 Err codemadness.org 70 i 10651 Err codemadness.org 70 i 10654 Err codemadness.org 70 i 10655 Err codemadness.org 70 i 10656 Err codemadness.org 70 i 10659 Err codemadness.org 70 i 10660 Err codemadness.org 70 i 10661 Err codemadness.org 70 i 10664 Err codemadness.org 70 i 10665 Err codemadness.org 70 i 10666 Err codemadness.org 70 i 10669 Err codemadness.org 70 i 10670 Err codemadness.org 70 i 10671 Err codemadness.org 70 i 10674 Err codemadness.org 70 i 10675 Err codemadness.org 70 i 10676 Err codemadness.org 70 i 10679 Err codemadness.org 70 i 10680 Err codemadness.org 70 i 10681 Err codemadness.org 70 i 10684 Err codemadness.org 70 i 10685 Err codemadness.org 70 i 10686 Err codemadness.org 70 i 10689 Err codemadness.org 70 i 10690 Err codemadness.org 70 i 10691 Err codemadness.org 70 i 10695 Err codemadness.org 70 i 10696 Err codemadness.org 70 i 10697

Err codemadness.org 70 i 10585 'nvme, ext4 (rw,relatime), kernel 5.3.0 - POWER9 Err codemadness.org 70 i 10586
Err codemadness.org 70 i 10592 $ ~/write_test Err codemadness.org 70 i 10593
Err codemadness.org 70 i 10597 File size 131072 Kb Err codemadness.org 70 i 10598
Err codemadness.org 70 i 10602 Writing 524288 Kb to it Err codemadness.org 70 i 10603
Err codemadness.org 70 i 10607 Err codemadness.org 70 i 10608
Err codemadness.org 70 i 10612 Simple cyclic file Err codemadness.org 70 i 10613
Err codemadness.org 70 i 10617 Took 132 seconds 538 milliseconds Err codemadness.org 70 i 10618
Err codemadness.org 70 i 10622 Err codemadness.org 70 i 10623
Err codemadness.org 70 i 10627 O_DSYNC cyclic file Err codemadness.org 70 i 10628
Err codemadness.org 70 i 10632 Took 61 seconds 86 milliseconds Err codemadness.org 70 i 10633
Err codemadness.org 70 i 10637 Err codemadness.org 70 i 10638
Err codemadness.org 70 i 10642 Mmapped cyclic file Err codemadness.org 70 i 10643
Err codemadness.org 70 i 10647 Took 248 seconds 543 milliseconds Err codemadness.org 70 i 10648
Err codemadness.org 70 i 10652 Err codemadness.org 70 i 10653
Err codemadness.org 70 i 10657 O_DIRECT\|O_DSYNC cyclic file Err codemadness.org 70 i 10658
Err codemadness.org 70 i 10662 pwrite() returned errno Invalid argument Err codemadness.org 70 i 10663
Err codemadness.org 70 i 10667 Err codemadness.org 70 i 10668
Err codemadness.org 70 i 10672 O_APPEND append file Err codemadness.org 70 i 10673
Err codemadness.org 70 i 10677 Took 959 seconds 463 milliseconds Err codemadness.org 70 i 10678
Err codemadness.org 70 i 10682 Err codemadness.org 70 i 10683
Err codemadness.org 70 i 10687 Simple append file Err codemadness.org 70 i 10688
Err codemadness.org 70 i 10692 Took 770 seconds 324 milliseconds Err codemadness.org 70 i 10693 Err codemadness.org 70 i 10694

Err codemadness.org 70 i 10698

Err codemadness.org 70 i 10699

Err codemadness.org 70 i 10700 Err codemadness.org 70 i 10701

Err codemadness.org 70 i 10702

Err codemadness.org 70 i 10703 Err codemadness.org 70 i 10704 Err codemadness.org 70 i 10705 Err codemadness.org 70 i 10706 Err codemadness.org 70 i 10709 Err codemadness.org 70 i 10710 Err codemadness.org 70 i 10711 Err codemadness.org 70 i 10712 Err codemadness.org 70 i 10713 Err codemadness.org 70 i 10716 Err codemadness.org 70 i 10717 Err codemadness.org 70 i 10718 Err codemadness.org 70 i 10721 Err codemadness.org 70 i 10722 Err codemadness.org 70 i 10723 Err codemadness.org 70 i 10726 Err codemadness.org 70 i 10727 Err codemadness.org 70 i 10728 Err codemadness.org 70 i 10731 Err codemadness.org 70 i 10732 Err codemadness.org 70 i 10733 Err codemadness.org 70 i 10736 Err codemadness.org 70 i 10737 Err codemadness.org 70 i 10738 Err codemadness.org 70 i 10741 Err codemadness.org 70 i 10742 Err codemadness.org 70 i 10743 Err codemadness.org 70 i 10746 Err codemadness.org 70 i 10747 Err codemadness.org 70 i 10748 Err codemadness.org 70 i 10751 Err codemadness.org 70 i 10752 Err codemadness.org 70 i 10753 Err codemadness.org 70 i 10756 Err codemadness.org 70 i 10757 Err codemadness.org 70 i 10758 Err codemadness.org 70 i 10761 Err codemadness.org 70 i 10762 Err codemadness.org 70 i 10763 Err codemadness.org 70 i 10766 Err codemadness.org 70 i 10767 Err codemadness.org 70 i 10768 Err codemadness.org 70 i 10771 Err codemadness.org 70 i 10772 Err codemadness.org 70 i 10773 Err codemadness.org 70 i 10776 Err codemadness.org 70 i 10777 Err codemadness.org 70 i 10778 Err codemadness.org 70 i 10781 Err codemadness.org 70 i 10782 Err codemadness.org 70 i 10783 Err codemadness.org 70 i 10786 Err codemadness.org 70 i 10787 Err codemadness.org 70 i 10788 Err codemadness.org 70 i 10791 Err codemadness.org 70 i 10792 Err codemadness.org 70 i 10793 Err codemadness.org 70 i 10796 Err codemadness.org 70 i 10797 Err codemadness.org 70 i 10798 Err codemadness.org 70 i 10801 Err codemadness.org 70 i 10802 Err codemadness.org 70 i 10803 Err codemadness.org 70 i 10806 Err codemadness.org 70 i 10807 Err codemadness.org 70 i 10808 Err codemadness.org 70 i 10811 Err codemadness.org 70 i 10812 Err codemadness.org 70 i 10813 Err codemadness.org 70 i 10817 Err codemadness.org 70 i 10818 Err codemadness.org 70 i 10819

Err codemadness.org 70 i 10707 '2x 12G SAS disks, raid0 - ServeRAID M5210, lvm (1 linear continuous map), xfs (rw,noatime,attr2,inode64,logbufs=8,logbsize=32k,noquota), 5.3.0-24-generic (ubuntu), x86_64' Err codemadness.org 70 i 10708
Err codemadness.org 70 i 10714 ./write_test Err codemadness.org 70 i 10715
Err codemadness.org 70 i 10719 File size 131072 Kb Err codemadness.org 70 i 10720
Err codemadness.org 70 i 10724 Writing 524288 Kb to it Err codemadness.org 70 i 10725
Err codemadness.org 70 i 10729 Err codemadness.org 70 i 10730
Err codemadness.org 70 i 10734 Simple cyclic file Err codemadness.org 70 i 10735
Err codemadness.org 70 i 10739 Took 98 seconds 359 milliseconds Err codemadness.org 70 i 10740
Err codemadness.org 70 i 10744 Err codemadness.org 70 i 10745
Err codemadness.org 70 i 10749 O_DSYNC cyclic file Err codemadness.org 70 i 10750
Err codemadness.org 70 i 10754 Took 99 seconds 659 milliseconds Err codemadness.org 70 i 10755
Err codemadness.org 70 i 10759 Err codemadness.org 70 i 10760
Err codemadness.org 70 i 10764 Mmapped cyclic file Err codemadness.org 70 i 10765
Err codemadness.org 70 i 10769 Took 100 seconds 107 milliseconds Err codemadness.org 70 i 10770
Err codemadness.org 70 i 10774 Err codemadness.org 70 i 10775
Err codemadness.org 70 i 10779 O_DIRECT\|O_DSYNC cyclic file Err codemadness.org 70 i 10780
Err codemadness.org 70 i 10784 Took 42 seconds 208 milliseconds Err codemadness.org 70 i 10785
Err codemadness.org 70 i 10789 Err codemadness.org 70 i 10790
Err codemadness.org 70 i 10794 O_APPEND append file Err codemadness.org 70 i 10795
Err codemadness.org 70 i 10799 Took 300 seconds 383 milliseconds Err codemadness.org 70 i 10800
Err codemadness.org 70 i 10804 Err codemadness.org 70 i 10805
Err codemadness.org 70 i 10809 Simple append file Err codemadness.org 70 i 10810
Err codemadness.org 70 i 10814 Took 303 seconds 216 milliseconds Err codemadness.org 70 i 10815 Err codemadness.org 70 i 10816

Err codemadness.org 70 i 10820

Err codemadness.org 70 i 10821

Err codemadness.org 70 i 10822 Err codemadness.org 70 i 10823

Looking why NVMe was slow - seems to be 4k LBA:

Err codemadness.org 70 i 10824 Err codemadness.org 70 i 10825

Err codemadness.org 70 i 10826

Err codemadness.org 70 i 10827 Err codemadness.org 70 i 10828 Err codemadness.org 70 i 10829 Err codemadness.org 70 i 10830 Err codemadness.org 70 i 10833 Err codemadness.org 70 i 10834 Err codemadness.org 70 i 10835 Err codemadness.org 70 i 10836 Err codemadness.org 70 i 10837 Err codemadness.org 70 i 10840 Err codemadness.org 70 i 10841 Err codemadness.org 70 i 10842 Err codemadness.org 70 i 10845 Err codemadness.org 70 i 10846 Err codemadness.org 70 i 10847 Err codemadness.org 70 i 10850 Err codemadness.org 70 i 10851 Err codemadness.org 70 i 10852 Err codemadness.org 70 i 10855 Err codemadness.org 70 i 10856 Err codemadness.org 70 i 10857 Err codemadness.org 70 i 10860 Err codemadness.org 70 i 10861 Err codemadness.org 70 i 10862 Err codemadness.org 70 i 10865 Err codemadness.org 70 i 10866 Err codemadness.org 70 i 10867 Err codemadness.org 70 i 10870 Err codemadness.org 70 i 10871 Err codemadness.org 70 i 10872 Err codemadness.org 70 i 10875 Err codemadness.org 70 i 10876 Err codemadness.org 70 i 10877 Err codemadness.org 70 i 10880 Err codemadness.org 70 i 10881 Err codemadness.org 70 i 10882 Err codemadness.org 70 i 10885 Err codemadness.org 70 i 10886 Err codemadness.org 70 i 10887 Err codemadness.org 70 i 10890 Err codemadness.org 70 i 10891 Err codemadness.org 70 i 10892 Err codemadness.org 70 i 10895 Err codemadness.org 70 i 10896 Err codemadness.org 70 i 10897 Err codemadness.org 70 i 10900 Err codemadness.org 70 i 10901 Err codemadness.org 70 i 10902 Err codemadness.org 70 i 10905 Err codemadness.org 70 i 10906 Err codemadness.org 70 i 10907 Err codemadness.org 70 i 10910 Err codemadness.org 70 i 10911 Err codemadness.org 70 i 10912 Err codemadness.org 70 i 10915 Err codemadness.org 70 i 10916 Err codemadness.org 70 i 10917 Err codemadness.org 70 i 10920 Err codemadness.org 70 i 10921 Err codemadness.org 70 i 10922 Err codemadness.org 70 i 10925 Err codemadness.org 70 i 10926 Err codemadness.org 70 i 10927 Err codemadness.org 70 i 10930 Err codemadness.org 70 i 10931 Err codemadness.org 70 i 10932 Err codemadness.org 70 i 10935 Err codemadness.org 70 i 10936 Err codemadness.org 70 i 10937 Err codemadness.org 70 i 10940 Err codemadness.org 70 i 10941 Err codemadness.org 70 i 10942 Err codemadness.org 70 i 10945 Err codemadness.org 70 i 10946 Err codemadness.org 70 i 10947 Err codemadness.org 70 i 10950 Err codemadness.org 70 i 10951 Err codemadness.org 70 i 10952 Err codemadness.org 70 i 10955 Err codemadness.org 70 i 10956 Err codemadness.org 70 i 10957 Err codemadness.org 70 i 10960 Err codemadness.org 70 i 10961 Err codemadness.org 70 i 10962 Err codemadness.org 70 i 10965 Err codemadness.org 70 i 10966 Err codemadness.org 70 i 10967 Err codemadness.org 70 i 10970 Err codemadness.org 70 i 10971 Err codemadness.org 70 i 10972 Err codemadness.org 70 i 10975 Err codemadness.org 70 i 10976 Err codemadness.org 70 i 10977 Err codemadness.org 70 i 10980 Err codemadness.org 70 i 10981 Err codemadness.org 70 i 10982 Err codemadness.org 70 i 10985 Err codemadness.org 70 i 10986 Err codemadness.org 70 i 10987 Err codemadness.org 70 i 10990 Err codemadness.org 70 i 10991 Err codemadness.org 70 i 10992 Err codemadness.org 70 i 10995 Err codemadness.org 70 i 10996 Err codemadness.org 70 i 10997 Err codemadness.org 70 i 11000 Err codemadness.org 70 i 11001 Err codemadness.org 70 i 11002 Err codemadness.org 70 i 11005 Err codemadness.org 70 i 11006 Err codemadness.org 70 i 11007 Err codemadness.org 70 i 11010 Err codemadness.org 70 i 11011 Err codemadness.org 70 i 11012 Err codemadness.org 70 i 11015 Err codemadness.org 70 i 11016 Err codemadness.org 70 i 11017 Err codemadness.org 70 i 11020 Err codemadness.org 70 i 11021 Err codemadness.org 70 i 11022 Err codemadness.org 70 i 11025 Err codemadness.org 70 i 11026 Err codemadness.org 70 i 11027 Err codemadness.org 70 i 11030 Err codemadness.org 70 i 11031 Err codemadness.org 70 i 11032 Err codemadness.org 70 i 11035 Err codemadness.org 70 i 11036 Err codemadness.org 70 i 11037 Err codemadness.org 70 i 11040 Err codemadness.org 70 i 11041 Err codemadness.org 70 i 11042 Err codemadness.org 70 i 11045 Err codemadness.org 70 i 11046 Err codemadness.org 70 i 11047 Err codemadness.org 70 i 11050 Err codemadness.org 70 i 11051 Err codemadness.org 70 i 11052 Err codemadness.org 70 i 11055 Err codemadness.org 70 i 11056 Err codemadness.org 70 i 11057 Err codemadness.org 70 i 11060 Err codemadness.org 70 i 11061 Err codemadness.org 70 i 11062 Err codemadness.org 70 i 11065 Err codemadness.org 70 i 11066 Err codemadness.org 70 i 11067 Err codemadness.org 70 i 11070 Err codemadness.org 70 i 11071 Err codemadness.org 70 i 11072 Err codemadness.org 70 i 11075 Err codemadness.org 70 i 11076 Err codemadness.org 70 i 11077 Err codemadness.org 70 i 11080 Err codemadness.org 70 i 11081 Err codemadness.org 70 i 11082 Err codemadness.org 70 i 11085 Err codemadness.org 70 i 11086 Err codemadness.org 70 i 11087 Err codemadness.org 70 i 11090 Err codemadness.org 70 i 11091 Err codemadness.org 70 i 11092 Err codemadness.org 70 i 11095 Err codemadness.org 70 i 11096 Err codemadness.org 70 i 11097 Err codemadness.org 70 i 11100 Err codemadness.org 70 i 11101 Err codemadness.org 70 i 11102 Err codemadness.org 70 i 11105 Err codemadness.org 70 i 11106 Err codemadness.org 70 i 11107 Err codemadness.org 70 i 11110 Err codemadness.org 70 i 11111 Err codemadness.org 70 i 11112 Err codemadness.org 70 i 11115 Err codemadness.org 70 i 11116 Err codemadness.org 70 i 11117 Err codemadness.org 70 i 11120 Err codemadness.org 70 i 11121 Err codemadness.org 70 i 11122 Err codemadness.org 70 i 11125 Err codemadness.org 70 i 11126 Err codemadness.org 70 i 11127 Err codemadness.org 70 i 11130 Err codemadness.org 70 i 11131 Err codemadness.org 70 i 11132 Err codemadness.org 70 i 11135 Err codemadness.org 70 i 11136 Err codemadness.org 70 i 11137 Err codemadness.org 70 i 11140 Err codemadness.org 70 i 11141 Err codemadness.org 70 i 11142 Err codemadness.org 70 i 11145 Err codemadness.org 70 i 11146 Err codemadness.org 70 i 11147 Err codemadness.org 70 i 11150 Err codemadness.org 70 i 11151 Err codemadness.org 70 i 11152 Err codemadness.org 70 i 11155 Err codemadness.org 70 i 11156 Err codemadness.org 70 i 11157 Err codemadness.org 70 i 11160 Err codemadness.org 70 i 11161 Err codemadness.org 70 i 11162 Err codemadness.org 70 i 11165 Err codemadness.org 70 i 11166 Err codemadness.org 70 i 11167 Err codemadness.org 70 i 11170 Err codemadness.org 70 i 11171 Err codemadness.org 70 i 11172 Err codemadness.org 70 i 11175 Err codemadness.org 70 i 11176 Err codemadness.org 70 i 11177 Err codemadness.org 70 i 11180 Err codemadness.org 70 i 11181 Err codemadness.org 70 i 11182 Err codemadness.org 70 i 11185 Err codemadness.org 70 i 11186 Err codemadness.org 70 i 11187 Err codemadness.org 70 i 11190 Err codemadness.org 70 i 11191 Err codemadness.org 70 i 11192 Err codemadness.org 70 i 11195 Err codemadness.org 70 i 11196 Err codemadness.org 70 i 11197 Err codemadness.org 70 i 11200 Err codemadness.org 70 i 11201 Err codemadness.org 70 i 11202 Err codemadness.org 70 i 11205 Err codemadness.org 70 i 11206 Err codemadness.org 70 i 11207 Err codemadness.org 70 i 11210 Err codemadness.org 70 i 11211 Err codemadness.org 70 i 11212 Err codemadness.org 70 i 11215 Err codemadness.org 70 i 11216 Err codemadness.org 70 i 11217 Err codemadness.org 70 i 11220 Err codemadness.org 70 i 11221 Err codemadness.org 70 i 11222 Err codemadness.org 70 i 11225 Err codemadness.org 70 i 11226 Err codemadness.org 70 i 11227 Err codemadness.org 70 i 11230 Err codemadness.org 70 i 11231 Err codemadness.org 70 i 11232 Err codemadness.org 70 i 11235 Err codemadness.org 70 i 11236 Err codemadness.org 70 i 11237 Err codemadness.org 70 i 11240 Err codemadness.org 70 i 11241 Err codemadness.org 70 i 11242 Err codemadness.org 70 i 11245 Err codemadness.org 70 i 11246 Err codemadness.org 70 i 11247 Err codemadness.org 70 i 11250 Err codemadness.org 70 i 11251 Err codemadness.org 70 i 11252 Err codemadness.org 70 i 11255 Err codemadness.org 70 i 11256 Err codemadness.org 70 i 11257 Err codemadness.org 70 i 11260 Err codemadness.org 70 i 11261 Err codemadness.org 70 i 11262 Err codemadness.org 70 i 11265 Err codemadness.org 70 i 11266 Err codemadness.org 70 i 11267 Err codemadness.org 70 i 11270 Err codemadness.org 70 i 11271 Err codemadness.org 70 i 11272 Err codemadness.org 70 i 11275 Err codemadness.org 70 i 11276 Err codemadness.org 70 i 11277 Err codemadness.org 70 i 11280 Err codemadness.org 70 i 11281 Err codemadness.org 70 i 11282 Err codemadness.org 70 i 11285 Err codemadness.org 70 i 11286 Err codemadness.org 70 i 11287 Err codemadness.org 70 i 11290 Err codemadness.org 70 i 11291 Err codemadness.org 70 i 11292 Err codemadness.org 70 i 11295 Err codemadness.org 70 i 11296 Err codemadness.org 70 i 11297 Err codemadness.org 70 i 11300 Err codemadness.org 70 i 11301 Err codemadness.org 70 i 11302 Err codemadness.org 70 i 11305 Err codemadness.org 70 i 11306 Err codemadness.org 70 i 11307 Err codemadness.org 70 i 11310 Err codemadness.org 70 i 11311 Err codemadness.org 70 i 11312 Err codemadness.org 70 i 11315 Err codemadness.org 70 i 11316 Err codemadness.org 70 i 11317 Err codemadness.org 70 i 11320 Err codemadness.org 70 i 11321 Err codemadness.org 70 i 11322 Err codemadness.org 70 i 11325 Err codemadness.org 70 i 11326 Err codemadness.org 70 i 11327 Err codemadness.org 70 i 11330 Err codemadness.org 70 i 11331 Err codemadness.org 70 i 11332 Err codemadness.org 70 i 11335 Err codemadness.org 70 i 11336 Err codemadness.org 70 i 11337 Err codemadness.org 70 i 11340 Err codemadness.org 70 i 11341 Err codemadness.org 70 i 11342 Err codemadness.org 70 i 11345 Err codemadness.org 70 i 11346 Err codemadness.org 70 i 11347 Err codemadness.org 70 i 11350 Err codemadness.org 70 i 11351 Err codemadness.org 70 i 11352 Err codemadness.org 70 i 11355 Err codemadness.org 70 i 11356 Err codemadness.org 70 i 11357 Err codemadness.org 70 i 11360 Err codemadness.org 70 i 11361 Err codemadness.org 70 i 11362 Err codemadness.org 70 i 11365 Err codemadness.org 70 i 11366 Err codemadness.org 70 i 11367 Err codemadness.org 70 i 11370 Err codemadness.org 70 i 11371 Err codemadness.org 70 i 11372 Err codemadness.org 70 i 11376 Err codemadness.org 70 i 11377 Err codemadness.org 70 i 11378

Err codemadness.org 70 i 10831 'smartctl -a /dev/nvme0n1' Err codemadness.org 70 i 10832
Err codemadness.org 70 i 10838 smartctl 6.6 2016-05-31 r4324 [ppc64le-linux-5.3.0] (local build) Err codemadness.org 70 i 10839
Err codemadness.org 70 i 10843 Copyright (C) 2002-16, Bruce Allen, Christian Franke, www.smartmontools.org Err codemadness.org 70 i 10844
Err codemadness.org 70 i 10848 Err codemadness.org 70 i 10849
Err codemadness.org 70 i 10853 === START OF INFORMATION SECTION === Err codemadness.org 70 i 10854
Err codemadness.org 70 i 10858 Model Number: PCIe3 1.6TB NVMe Flash Adapter Err codemadness.org 70 i 10859
Err codemadness.org 70 i 10863 Serial Number: CJH0010003EE Err codemadness.org 70 i 10864
Err codemadness.org 70 i 10868 Firmware Version: KMIPP107 Err codemadness.org 70 i 10869
Err codemadness.org 70 i 10873 PCI Vendor ID: 0x1c58 Err codemadness.org 70 i 10874
Err codemadness.org 70 i 10878 PCI Vendor Subsystem ID: 0x1014 Err codemadness.org 70 i 10879
Err codemadness.org 70 i 10883 IEEE OUI Identifier: 0x000cca Err codemadness.org 70 i 10884
Err codemadness.org 70 i 10888 Controller ID: 1269 Err codemadness.org 70 i 10889
Err codemadness.org 70 i 10893 Number of Namespaces: 1 Err codemadness.org 70 i 10894
Err codemadness.org 70 i 10898 Namespace 1 Size/Capacity: 1,600,321,314,816 [1.60 TB] Err codemadness.org 70 i 10899
Err codemadness.org 70 i 10903 Namespace 1 Formatted LBA Size: 4096 Err codemadness.org 70 i 10904
Err codemadness.org 70 i 10908 Local Time is: Wed Jan 8 13:22:03 2020 AEDT Err codemadness.org 70 i 10909
Err codemadness.org 70 i 10913 Firmware Updates (0x08): 4 Slots Err codemadness.org 70 i 10914
Err codemadness.org 70 i 10918 Optional Admin Commands (0x0006): Format Frmw_DL Err codemadness.org 70 i 10919
Err codemadness.org 70 i 10923 Optional NVM Commands (0x001f): Comp Wr_Unc DS_Mngmt Wr_Zero Sav/Sel_Feat Err codemadness.org 70 i 10924
Err codemadness.org 70 i 10928 Err codemadness.org 70 i 10929
Err codemadness.org 70 i 10933 Supported Power States Err codemadness.org 70 i 10934
Err codemadness.org 70 i 10938 St Op Max Active Idle RL RT WL WT Ent_Lat Ex_Lat Err codemadness.org 70 i 10939
Err codemadness.org 70 i 10943 0 + 25.00W - - 0 0 0 0 15000 15000 Err codemadness.org 70 i 10944
Err codemadness.org 70 i 10948 1 + 20.00W - - 1 1 1 1 15000 15000 Err codemadness.org 70 i 10949
Err codemadness.org 70 i 10953 2 + 15.00W - - 2 2 2 2 15000 15000 Err codemadness.org 70 i 10954
Err codemadness.org 70 i 10958 3 + 10.00W - - 3 3 3 3 15000 15000 Err codemadness.org 70 i 10959
Err codemadness.org 70 i 10963 4 - 10.00W - - 3 3 3 3 15000 15000 Err codemadness.org 70 i 10964
Err codemadness.org 70 i 10968 Err codemadness.org 70 i 10969
Err codemadness.org 70 i 10973 Supported LBA Sizes (NSID 0x1) Err codemadness.org 70 i 10974
Err codemadness.org 70 i 10978 Id Fmt Data Metadt Rel_Perf Err codemadness.org 70 i 10979
Err codemadness.org 70 i 10983 0 + 4096 0 0 Err codemadness.org 70 i 10984
Err codemadness.org 70 i 10988 1 - 4096 8 1 Err codemadness.org 70 i 10989
Err codemadness.org 70 i 10993 Err codemadness.org 70 i 10994
Err codemadness.org 70 i 10998 === START OF SMART DATA SECTION === Err codemadness.org 70 i 10999
Err codemadness.org 70 i 11003 SMART overall-health self-assessment test result: PASSED Err codemadness.org 70 i 11004
Err codemadness.org 70 i 11008 Err codemadness.org 70 i 11009
Err codemadness.org 70 i 11013 SMART/Health Information (NVMe Log 0x02, NSID 0x1) Err codemadness.org 70 i 11014
Err codemadness.org 70 i 11018 Critical Warning: 0x00 Err codemadness.org 70 i 11019
Err codemadness.org 70 i 11023 Temperature: 36 Celsius Err codemadness.org 70 i 11024
Err codemadness.org 70 i 11028 Available Spare: 100% Err codemadness.org 70 i 11029
Err codemadness.org 70 i 11033 Available Spare Threshold: 10% Err codemadness.org 70 i 11034
Err codemadness.org 70 i 11038 Percentage Used: 0%smartctl 6.6 2016-05-31 r4324 [ppc64le-linux-5.3.0] (local build) Err codemadness.org 70 i 11039
Err codemadness.org 70 i 11043 Copyright (C) 2002-16, Bruce Allen, Christian Franke, www.smartmontools.org Err codemadness.org 70 i 11044
Err codemadness.org 70 i 11048 Err codemadness.org 70 i 11049
Err codemadness.org 70 i 11053 === START OF INFORMATION SECTION === Err codemadness.org 70 i 11054
Err codemadness.org 70 i 11058 Model Number: PCIe3 1.6TB NVMe Flash Adapter Err codemadness.org 70 i 11059
Err codemadness.org 70 i 11063 Serial Number: CJH0010003EE Err codemadness.org 70 i 11064
Err codemadness.org 70 i 11068 Firmware Version: KMIPP107 Err codemadness.org 70 i 11069
Err codemadness.org 70 i 11073 PCI Vendor ID: 0x1c58 Err codemadness.org 70 i 11074
Err codemadness.org 70 i 11078 PCI Vendor Subsystem ID: 0x1014 Err codemadness.org 70 i 11079
Err codemadness.org 70 i 11083 IEEE OUI Identifier: 0x000cca Err codemadness.org 70 i 11084
Err codemadness.org 70 i 11088 Controller ID: 1269 Err codemadness.org 70 i 11089
Err codemadness.org 70 i 11093 Number of Namespaces: 1 Err codemadness.org 70 i 11094
Err codemadness.org 70 i 11098 Namespace 1 Size/Capacity: 1,600,321,314,816 [1.60 TB] Err codemadness.org 70 i 11099
Err codemadness.org 70 i 11103 Namespace 1 Formatted LBA Size: 4096 Err codemadness.org 70 i 11104
Err codemadness.org 70 i 11108 Local Time is: Wed Jan 8 13:22:03 2020 AEDT Err codemadness.org 70 i 11109
Err codemadness.org 70 i 11113 Firmware Updates (0x08): 4 Slots Err codemadness.org 70 i 11114
Err codemadness.org 70 i 11118 Optional Admin Commands (0x0006): Format Frmw_DL Err codemadness.org 70 i 11119
Err codemadness.org 70 i 11123 Optional NVM Commands (0x001f): Comp Wr_Unc DS_Mngmt Wr_Zero Sav/Sel_Feat Err codemadness.org 70 i 11124
Err codemadness.org 70 i 11128 Err codemadness.org 70 i 11129
Err codemadness.org 70 i 11133 Supported Power States Err codemadness.org 70 i 11134
Err codemadness.org 70 i 11138 St Op Max Active Idle RL RT WL WT Ent_Lat Ex_Lat Err codemadness.org 70 i 11139
Err codemadness.org 70 i 11143 0 + 25.00W - - 0 0 0 0 15000 15000 Err codemadness.org 70 i 11144
Err codemadness.org 70 i 11148 1 + 20.00W - - 1 1 1 1 15000 15000 Err codemadness.org 70 i 11149
Err codemadness.org 70 i 11153 2 + 15.00W - - 2 2 2 2 15000 15000 Err codemadness.org 70 i 11154
Err codemadness.org 70 i 11158 3 + 10.00W - - 3 3 3 3 15000 15000 Err codemadness.org 70 i 11159
Err codemadness.org 70 i 11163 4 - 10.00W - - 3 3 3 3 15000 15000 Err codemadness.org 70 i 11164
Err codemadness.org 70 i 11168 Err codemadness.org 70 i 11169
Err codemadness.org 70 i 11173 Supported LBA Sizes (NSID 0x1) Err codemadness.org 70 i 11174
Err codemadness.org 70 i 11178 Id Fmt Data Metadt Rel_Perf Err codemadness.org 70 i 11179
Err codemadness.org 70 i 11183 0 + 4096 0 0 Err codemadness.org 70 i 11184
Err codemadness.org 70 i 11188 1 - 4096 8 1 Err codemadness.org 70 i 11189
Err codemadness.org 70 i 11193 Err codemadness.org 70 i 11194
Err codemadness.org 70 i 11198 === START OF SMART DATA SECTION === Err codemadness.org 70 i 11199
Err codemadness.org 70 i 11203 SMART overall-health self-assessment test result: PASSED Err codemadness.org 70 i 11204
Err codemadness.org 70 i 11208 Err codemadness.org 70 i 11209
Err codemadness.org 70 i 11213 SMART/Health Information (NVMe Log 0x02, NSID 0x1) Err codemadness.org 70 i 11214
Err codemadness.org 70 i 11218 Critical Warning: 0x00 Err codemadness.org 70 i 11219
Err codemadness.org 70 i 11223 Temperature: 36 Celsius Err codemadness.org 70 i 11224
Err codemadness.org 70 i 11228 Available Spare: 100% Err codemadness.org 70 i 11229
Err codemadness.org 70 i 11233 Available Spare Threshold: 10% Err codemadness.org 70 i 11234
Err codemadness.org 70 i 11238 Percentage Used: 0% Err codemadness.org 70 i 11239
Err codemadness.org 70 i 11243 Data Units Read: 3,643,068 [1.86 TB] Err codemadness.org 70 i 11244
Err codemadness.org 70 i 11248 Data Units Written: 6,647,820 [3.40 TB] Err codemadness.org 70 i 11249
Err codemadness.org 70 i 11253 Host Read Commands: 83,729,047 Err codemadness.org 70 i 11254
Err codemadness.org 70 i 11258 Host Write Commands: 81,415,498 Err codemadness.org 70 i 11259
Err codemadness.org 70 i 11263 Controller Busy Time: 841 Err codemadness.org 70 i 11264
Err codemadness.org 70 i 11268 Power Cycles: 1,569 Err codemadness.org 70 i 11269
Err codemadness.org 70 i 11273 Power On Hours: 22,345 Err codemadness.org 70 i 11274
Err codemadness.org 70 i 11278 Unsafe Shutdowns: 516 Err codemadness.org 70 i 11279
Err codemadness.org 70 i 11283 Media and Data Integrity Errors: 0 Err codemadness.org 70 i 11284
Err codemadness.org 70 i 11288 Error Information Log Entries: 0 Err codemadness.org 70 i 11289
Err codemadness.org 70 i 11293 Err codemadness.org 70 i 11294
Err codemadness.org 70 i 11298 Error Information (NVMe Log 0x01, max 63 entries) Err codemadness.org 70 i 11299
Err codemadness.org 70 i 11303 No Errors Logged Err codemadness.org 70 i 11304
Err codemadness.org 70 i 11308 Err codemadness.org 70 i 11309
Err codemadness.org 70 i 11313 Data Units Read: 3,643,068 [1.86 TB] Err codemadness.org 70 i 11314
Err codemadness.org 70 i 11318 Data Units Written: 6,647,820 [3.40 TB] Err codemadness.org 70 i 11319
Err codemadness.org 70 i 11323 Host Read Commands: 83,729,047 Err codemadness.org 70 i 11324
Err codemadness.org 70 i 11328 Host Write Commands: 81,415,498 Err codemadness.org 70 i 11329
Err codemadness.org 70 i 11333 Controller Busy Time: 841 Err codemadness.org 70 i 11334
Err codemadness.org 70 i 11338 Power Cycles: 1,569 Err codemadness.org 70 i 11339
Err codemadness.org 70 i 11343 Power On Hours: 22,345 Err codemadness.org 70 i 11344
Err codemadness.org 70 i 11348 Unsafe Shutdowns: 516 Err codemadness.org 70 i 11349
Err codemadness.org 70 i 11353 Media and Data Integrity Errors: 0 Err codemadness.org 70 i 11354
Err codemadness.org 70 i 11358 Error Information Log Entries: 0 Err codemadness.org 70 i 11359
Err codemadness.org 70 i 11363 Err codemadness.org 70 i 11364
Err codemadness.org 70 i 11368 Error Information (NVMe Log 0x01, max 63 entries) Err codemadness.org 70 i 11369
Err codemadness.org 70 i 11373 No Errors Logged Err codemadness.org 70 i 11374 Err codemadness.org 70 i 11375

Err codemadness.org 70 i 11379

Err codemadness.org 70 i 11380

Err codemadness.org 70 i 11381 Err codemadness.org 70 i 11382

Err codemadness.org 70 i 11383

Err codemadness.org 70 i 11384 Err codemadness.org 70 i 11385 Err codemadness.org 70 i 11386 Err codemadness.org 70 i 11387 Err codemadness.org 70 i 11390 Err codemadness.org 70 i 11391 Err codemadness.org 70 i 11392 Err codemadness.org 70 i 11393 Err codemadness.org 70 i 11394 Err codemadness.org 70 i 11397 Err codemadness.org 70 i 11398 Err codemadness.org 70 i 11399 Err codemadness.org 70 i 11402 Err codemadness.org 70 i 11403 Err codemadness.org 70 i 11404 Err codemadness.org 70 i 11407 Err codemadness.org 70 i 11408 Err codemadness.org 70 i 11409 Err codemadness.org 70 i 11412 Err codemadness.org 70 i 11413 Err codemadness.org 70 i 11414 Err codemadness.org 70 i 11417 Err codemadness.org 70 i 11418 Err codemadness.org 70 i 11419 Err codemadness.org 70 i 11422 Err codemadness.org 70 i 11423 Err codemadness.org 70 i 11424 Err codemadness.org 70 i 11427 Err codemadness.org 70 i 11428 Err codemadness.org 70 i 11429 Err codemadness.org 70 i 11432 Err codemadness.org 70 i 11433 Err codemadness.org 70 i 11434 Err codemadness.org 70 i 11437 Err codemadness.org 70 i 11438 Err codemadness.org 70 i 11439 Err codemadness.org 70 i 11442 Err codemadness.org 70 i 11443 Err codemadness.org 70 i 11444 Err codemadness.org 70 i 11447 Err codemadness.org 70 i 11448 Err codemadness.org 70 i 11449 Err codemadness.org 70 i 11452 Err codemadness.org 70 i 11453 Err codemadness.org 70 i 11454 Err codemadness.org 70 i 11457 Err codemadness.org 70 i 11458 Err codemadness.org 70 i 11459 Err codemadness.org 70 i 11462 Err codemadness.org 70 i 11463 Err codemadness.org 70 i 11464 Err codemadness.org 70 i 11467 Err codemadness.org 70 i 11468 Err codemadness.org 70 i 11469 Err codemadness.org 70 i 11472 Err codemadness.org 70 i 11473 Err codemadness.org 70 i 11474 Err codemadness.org 70 i 11477 Err codemadness.org 70 i 11478 Err codemadness.org 70 i 11479 Err codemadness.org 70 i 11482 Err codemadness.org 70 i 11483 Err codemadness.org 70 i 11484 Err codemadness.org 70 i 11487 Err codemadness.org 70 i 11488 Err codemadness.org 70 i 11489 Err codemadness.org 70 i 11492 Err codemadness.org 70 i 11493 Err codemadness.org 70 i 11494 Err codemadness.org 70 i 11497 Err codemadness.org 70 i 11498 Err codemadness.org 70 i 11499 Err codemadness.org 70 i 11502 Err codemadness.org 70 i 11503 Err codemadness.org 70 i 11504 Err codemadness.org 70 i 11507 Err codemadness.org 70 i 11508 Err codemadness.org 70 i 11509 Err codemadness.org 70 i 11512 Err codemadness.org 70 i 11513 Err codemadness.org 70 i 11514 Err codemadness.org 70 i 11517 Err codemadness.org 70 i 11518 Err codemadness.org 70 i 11519 Err codemadness.org 70 i 11522 Err codemadness.org 70 i 11523 Err codemadness.org 70 i 11524 Err codemadness.org 70 i 11527 Err codemadness.org 70 i 11528 Err codemadness.org 70 i 11529 Err codemadness.org 70 i 11532 Err codemadness.org 70 i 11533 Err codemadness.org 70 i 11534 Err codemadness.org 70 i 11537 Err codemadness.org 70 i 11538 Err codemadness.org 70 i 11539 Err codemadness.org 70 i 11542 Err codemadness.org 70 i 11543 Err codemadness.org 70 i 11544 Err codemadness.org 70 i 11547 Err codemadness.org 70 i 11548 Err codemadness.org 70 i 11549 Err codemadness.org 70 i 11552 Err codemadness.org 70 i 11553 Err codemadness.org 70 i 11554 Err codemadness.org 70 i 11557 Err codemadness.org 70 i 11558 Err codemadness.org 70 i 11559 Err codemadness.org 70 i 11562 Err codemadness.org 70 i 11563 Err codemadness.org 70 i 11564 Err codemadness.org 70 i 11567 Err codemadness.org 70 i 11568 Err codemadness.org 70 i 11569 Err codemadness.org 70 i 11572 Err codemadness.org 70 i 11573 Err codemadness.org 70 i 11574 Err codemadness.org 70 i 11577 Err codemadness.org 70 i 11578 Err codemadness.org 70 i 11579 Err codemadness.org 70 i 11582 Err codemadness.org 70 i 11583 Err codemadness.org 70 i 11584 Err codemadness.org 70 i 11587 Err codemadness.org 70 i 11588 Err codemadness.org 70 i 11589 Err codemadness.org 70 i 11592 Err codemadness.org 70 i 11593 Err codemadness.org 70 i 11594 Err codemadness.org 70 i 11597 Err codemadness.org 70 i 11598 Err codemadness.org 70 i 11599 Err codemadness.org 70 i 11602 Err codemadness.org 70 i 11603 Err codemadness.org 70 i 11604 Err codemadness.org 70 i 11607 Err codemadness.org 70 i 11608 Err codemadness.org 70 i 11609 Err codemadness.org 70 i 11612 Err codemadness.org 70 i 11613 Err codemadness.org 70 i 11614 Err codemadness.org 70 i 11617 Err codemadness.org 70 i 11618 Err codemadness.org 70 i 11619 Err codemadness.org 70 i 11622 Err codemadness.org 70 i 11623 Err codemadness.org 70 i 11624 Err codemadness.org 70 i 11627 Err codemadness.org 70 i 11628 Err codemadness.org 70 i 11629 Err codemadness.org 70 i 11632 Err codemadness.org 70 i 11633 Err codemadness.org 70 i 11634 Err codemadness.org 70 i 11637 Err codemadness.org 70 i 11638 Err codemadness.org 70 i 11639 Err codemadness.org 70 i 11642 Err codemadness.org 70 i 11643 Err codemadness.org 70 i 11644 Err codemadness.org 70 i 11647 Err codemadness.org 70 i 11648 Err codemadness.org 70 i 11649 Err codemadness.org 70 i 11652 Err codemadness.org 70 i 11653 Err codemadness.org 70 i 11654 Err codemadness.org 70 i 11657 Err codemadness.org 70 i 11658 Err codemadness.org 70 i 11659 Err codemadness.org 70 i 11663 Err codemadness.org 70 i 11664 Err codemadness.org 70 i 11665

Err codemadness.org 70 i 11388 'dumpe2fs' Err codemadness.org 70 i 11389
Err codemadness.org 70 i 11395 sudo dumpe2fs -h /dev/nvme0n1p1 \| more Err codemadness.org 70 i 11396
Err codemadness.org 70 i 11400 dumpe2fs 1.44.1 (24-Mar-2018) Err codemadness.org 70 i 11401
Err codemadness.org 70 i 11405 Filesystem volume name: scratch Err codemadness.org 70 i 11406
Err codemadness.org 70 i 11410 Last mounted on: /scratch Err codemadness.org 70 i 11411
Err codemadness.org 70 i 11415 Filesystem UUID: 356af640-5d8e-4256-9dce-a0983c9e0e43 Err codemadness.org 70 i 11416
Err codemadness.org 70 i 11420 Filesystem magic number: 0xEF53 Err codemadness.org 70 i 11421
Err codemadness.org 70 i 11425 Filesystem revision #: 1 (dynamic) Err codemadness.org 70 i 11426
Err codemadness.org 70 i 11430 Filesystem features: has_journal ext_attr resize_inode dir_index filetype needs_recovery extent flex_bg sparse_super large_file huge_file dir_nlink extra_isize metadata_csum Err codemadness.org 70 i 11431
Err codemadness.org 70 i 11435 Filesystem flags: unsigned_directory_hash Err codemadness.org 70 i 11436
Err codemadness.org 70 i 11440 Default mount options: user_xattr acl Err codemadness.org 70 i 11441
Err codemadness.org 70 i 11445 Filesystem state: clean Err codemadness.org 70 i 11446
Err codemadness.org 70 i 11450 Errors behavior: Continue Err codemadness.org 70 i 11451
Err codemadness.org 70 i 11455 Filesystem OS type: Linux Err codemadness.org 70 i 11456
Err codemadness.org 70 i 11460 Inode count: 65052672 Err codemadness.org 70 i 11461
Err codemadness.org 70 i 11465 Block count: 260208384 Err codemadness.org 70 i 11466
Err codemadness.org 70 i 11470 Reserved block count: 13010419 Err codemadness.org 70 i 11471
Err codemadness.org 70 i 11475 Free blocks: 132171164 Err codemadness.org 70 i 11476
Err codemadness.org 70 i 11480 Free inodes: 62683469 Err codemadness.org 70 i 11481
Err codemadness.org 70 i 11485 First block: 0 Err codemadness.org 70 i 11486
Err codemadness.org 70 i 11490 Block size: 4096 Err codemadness.org 70 i 11491
Err codemadness.org 70 i 11495 Fragment size: 4096 Err codemadness.org 70 i 11496
Err codemadness.org 70 i 11500 Reserved GDT blocks: 961 Err codemadness.org 70 i 11501
Err codemadness.org 70 i 11505 Blocks per group: 32768 Err codemadness.org 70 i 11506
Err codemadness.org 70 i 11510 Fragments per group: 32768 Err codemadness.org 70 i 11511
Err codemadness.org 70 i 11515 Inodes per group: 8192 Err codemadness.org 70 i 11516
Err codemadness.org 70 i 11520 Inode blocks per group: 512 Err codemadness.org 70 i 11521
Err codemadness.org 70 i 11525 Flex block group size: 16 Err codemadness.org 70 i 11526
Err codemadness.org 70 i 11530 Filesystem created: Wed Nov 22 15:34:07 2017 Err codemadness.org 70 i 11531
Err codemadness.org 70 i 11535 Last mount time: Tue Jan 7 20:38:12 2020 Err codemadness.org 70 i 11536
Err codemadness.org 70 i 11540 Last write time: Tue Jan 7 20:38:12 2020 Err codemadness.org 70 i 11541
Err codemadness.org 70 i 11545 Mount count: 293 Err codemadness.org 70 i 11546
Err codemadness.org 70 i 11550 Maximum mount count: -1 Err codemadness.org 70 i 11551
Err codemadness.org 70 i 11555 Last checked: Wed Nov 22 15:34:07 2017 Err codemadness.org 70 i 11556
Err codemadness.org 70 i 11560 Check interval: 0 (<none>) Err codemadness.org 70 i 11561
Err codemadness.org 70 i 11565 Lifetime writes: 20 TB Err codemadness.org 70 i 11566
Err codemadness.org 70 i 11570 Reserved blocks uid: 0 (user root) Err codemadness.org 70 i 11571
Err codemadness.org 70 i 11575 Reserved blocks gid: 0 (group root) Err codemadness.org 70 i 11576
Err codemadness.org 70 i 11580 First inode: 11 Err codemadness.org 70 i 11581
Err codemadness.org 70 i 11585 Inode size: 256 Err codemadness.org 70 i 11586
Err codemadness.org 70 i 11590 Required extra isize: 32 Err codemadness.org 70 i 11591
Err codemadness.org 70 i 11595 Desired extra isize: 32 Err codemadness.org 70 i 11596
Err codemadness.org 70 i 11600 Journal inode: 8 Err codemadness.org 70 i 11601
Err codemadness.org 70 i 11605 Default directory hash: half_md4 Err codemadness.org 70 i 11606
Err codemadness.org 70 i 11610 Directory Hash Seed: b68c7dc9-1e4b-46d2-b6d2-6f2d0128b12a Err codemadness.org 70 i 11611
Err codemadness.org 70 i 11615 Journal backup: inode blocks Err codemadness.org 70 i 11616
Err codemadness.org 70 i 11620 Checksum type: crc32c Err codemadness.org 70 i 11621
Err codemadness.org 70 i 11625 Checksum: 0xb0abf812 Err codemadness.org 70 i 11626
Err codemadness.org 70 i 11630 Journal features: journal_incompat_revoke journal_checksum_v3 Err codemadness.org 70 i 11631
Err codemadness.org 70 i 11635 Journal size: 1024M Err codemadness.org 70 i 11636
Err codemadness.org 70 i 11640 Journal length: 262144 Err codemadness.org 70 i 11641
Err codemadness.org 70 i 11645 Journal sequence: 0x0050f6ac Err codemadness.org 70 i 11646
Err codemadness.org 70 i 11650 Journal start: 153997 Err codemadness.org 70 i 11651
Err codemadness.org 70 i 11655 Journal checksum type: crc32c Err codemadness.org 70 i 11656
Err codemadness.org 70 i 11660 Journal checksum: 0xc52e4213 Err codemadness.org 70 i 11661 Err codemadness.org 70 i 11662

Err codemadness.org 70 i 11666

Err codemadness.org 70 i 11667

Err codemadness.org 70 i 11668 Err codemadness.org 70 i 11669

Err codemadness.org 70 i 11670

Err codemadness.org 70 i 11671 Err codemadness.org 70 i 11672 Err codemadness.org 70 i 11673 Err codemadness.org 70 i 11674 Err codemadness.org 70 i 11677 Err codemadness.org 70 i 11678 Err codemadness.org 70 i 11679 Err codemadness.org 70 i 11680 Err codemadness.org 70 i 11681 Err codemadness.org 70 i 11684 Err codemadness.org 70 i 11685 Err codemadness.org 70 i 11686 Err codemadness.org 70 i 11689 Err codemadness.org 70 i 11690 Err codemadness.org 70 i 11691 Err codemadness.org 70 i 11694 Err codemadness.org 70 i 11695 Err codemadness.org 70 i 11696 Err codemadness.org 70 i 11699 Err codemadness.org 70 i 11700 Err codemadness.org 70 i 11701 Err codemadness.org 70 i 11704 Err codemadness.org 70 i 11705 Err codemadness.org 70 i 11706 Err codemadness.org 70 i 11709 Err codemadness.org 70 i 11710 Err codemadness.org 70 i 11711 Err codemadness.org 70 i 11714 Err codemadness.org 70 i 11715 Err codemadness.org 70 i 11716 Err codemadness.org 70 i 11719 Err codemadness.org 70 i 11720 Err codemadness.org 70 i 11721 Err codemadness.org 70 i 11725 Err codemadness.org 70 i 11726 Err codemadness.org 70 i 11727

Err codemadness.org 70 i 11675 '4k test' Err codemadness.org 70 i 11676
Err codemadness.org 70 i 11682 static const size_t kFileSize = 1 * 128 * 1024 * 1024; Err codemadness.org 70 i 11683
Err codemadness.org 70 i 11687 Err codemadness.org 70 i 11688
Err codemadness.org 70 i 11692 static const size_t kWriteTotal = 4 * kFileSize; Err codemadness.org 70 i 11693
Err codemadness.org 70 i 11697 Err codemadness.org 70 i 11698
Err codemadness.org 70 i 11702 static const size_t kBuffSize = 4096; Err codemadness.org 70 i 11703
Err codemadness.org 70 i 11707 Err codemadness.org 70 i 11708
Err codemadness.org 70 i 11712 static const std::array<unsigned char, kBuffSize> kBuf = { 33 }; Err codemadness.org 70 i 11713
Err codemadness.org 70 i 11717 Err codemadness.org 70 i 11718
Err codemadness.org 70 i 11722 static const std::array<unsigned char, kBuffSize> kAlignedBuf alignas(kBuffSize) = { 33 }; Err codemadness.org 70 i 11723 Err codemadness.org 70 i 11724

Err codemadness.org 70 i 11728

Err codemadness.org 70 i 11729

Err codemadness.org 70 i 11730 Err codemadness.org 70 i 11731

Err codemadness.org 70 i 11732

Err codemadness.org 70 i 11733 Err codemadness.org 70 i 11734 Err codemadness.org 70 i 11735 Err codemadness.org 70 i 11736 Err codemadness.org 70 i 11739 Err codemadness.org 70 i 11740 Err codemadness.org 70 i 11741 Err codemadness.org 70 i 11742 Err codemadness.org 70 i 11743 Err codemadness.org 70 i 11746 Err codemadness.org 70 i 11747 Err codemadness.org 70 i 11748 Err codemadness.org 70 i 11751 Err codemadness.org 70 i 11752 Err codemadness.org 70 i 11753 Err codemadness.org 70 i 11756 Err codemadness.org 70 i 11757 Err codemadness.org 70 i 11758 Err codemadness.org 70 i 11761 Err codemadness.org 70 i 11762 Err codemadness.org 70 i 11763 Err codemadness.org 70 i 11766 Err codemadness.org 70 i 11767 Err codemadness.org 70 i 11768 Err codemadness.org 70 i 11771 Err codemadness.org 70 i 11772 Err codemadness.org 70 i 11773 Err codemadness.org 70 i 11776 Err codemadness.org 70 i 11777 Err codemadness.org 70 i 11778 Err codemadness.org 70 i 11781 Err codemadness.org 70 i 11782 Err codemadness.org 70 i 11783 Err codemadness.org 70 i 11786 Err codemadness.org 70 i 11787 Err codemadness.org 70 i 11788 Err codemadness.org 70 i 11791 Err codemadness.org 70 i 11792 Err codemadness.org 70 i 11793 Err codemadness.org 70 i 11796 Err codemadness.org 70 i 11797 Err codemadness.org 70 i 11798 Err codemadness.org 70 i 11801 Err codemadness.org 70 i 11802 Err codemadness.org 70 i 11803 Err codemadness.org 70 i 11806 Err codemadness.org 70 i 11807 Err codemadness.org 70 i 11808 Err codemadness.org 70 i 11811 Err codemadness.org 70 i 11812 Err codemadness.org 70 i 11813 Err codemadness.org 70 i 11816 Err codemadness.org 70 i 11817 Err codemadness.org 70 i 11818 Err codemadness.org 70 i 11821 Err codemadness.org 70 i 11822 Err codemadness.org 70 i 11823 Err codemadness.org 70 i 11826 Err codemadness.org 70 i 11827 Err codemadness.org 70 i 11828 Err codemadness.org 70 i 11831 Err codemadness.org 70 i 11832 Err codemadness.org 70 i 11833 Err codemadness.org 70 i 11836 Err codemadness.org 70 i 11837 Err codemadness.org 70 i 11838 Err codemadness.org 70 i 11841 Err codemadness.org 70 i 11842 Err codemadness.org 70 i 11843 Err codemadness.org 70 i 11846 Err codemadness.org 70 i 11847 Err codemadness.org 70 i 11848 Err codemadness.org 70 i 11852 Err codemadness.org 70 i 11853 Err codemadness.org 70 i 11854

Err codemadness.org 70 i 11737 'nvme, ext4 (rw,relatime), kernel 5.3.0 - POWER9 - 4k writes Err codemadness.org 70 i 11738
Err codemadness.org 70 i 11744 File size 131072 Kb Err codemadness.org 70 i 11745
Err codemadness.org 70 i 11749 Writing 524288 Kb to it Err codemadness.org 70 i 11750
Err codemadness.org 70 i 11754 Err codemadness.org 70 i 11755
Err codemadness.org 70 i 11759 Simple cyclic file Err codemadness.org 70 i 11760
Err codemadness.org 70 i 11764 Err codemadness.org 70 i 11765
Err codemadness.org 70 i 11769 Took 49 seconds 300 milliseconds Err codemadness.org 70 i 11770
Err codemadness.org 70 i 11774 Err codemadness.org 70 i 11775
Err codemadness.org 70 i 11779 O_DSYNC cyclic file Err codemadness.org 70 i 11780
Err codemadness.org 70 i 11784 Took 57 seconds 536 milliseconds Err codemadness.org 70 i 11785
Err codemadness.org 70 i 11789 Err codemadness.org 70 i 11790
Err codemadness.org 70 i 11794 Mmapped cyclic file Err codemadness.org 70 i 11795
Err codemadness.org 70 i 11799 Took 75 seconds 627 milliseconds Err codemadness.org 70 i 11800
Err codemadness.org 70 i 11804 Err codemadness.org 70 i 11805
Err codemadness.org 70 i 11809 O_DIRECT\|O_DSYNC cyclic file Err codemadness.org 70 i 11810
Err codemadness.org 70 i 11814 Took 64 seconds 600 milliseconds Err codemadness.org 70 i 11815
Err codemadness.org 70 i 11819 Err codemadness.org 70 i 11820
Err codemadness.org 70 i 11824 O_APPEND append file Err codemadness.org 70 i 11825
Err codemadness.org 70 i 11829 Took 231 seconds 47 milliseconds Err codemadness.org 70 i 11830
Err codemadness.org 70 i 11834 Err codemadness.org 70 i 11835
Err codemadness.org 70 i 11839 Simple append file Err codemadness.org 70 i 11840
Err codemadness.org 70 i 11844 Took 229 seconds 604 milliseconds Err codemadness.org 70 i 11845
Err codemadness.org 70 i 11849 Err codemadness.org 70 i 11850 Err codemadness.org 70 i 11851

Err codemadness.org 70 i 11855

Err codemadness.org 70 i 11856

Err codemadness.org 70 i 11857 Err codemadness.org 70 i 11858 Err codemadness.org 70 i 11859

Err codemadness.org 70 i 11860

Err codemadness.org 70 i 11861 Err codemadness.org 70 i 11862 Err codemadness.org 70 i 11863 Err codemadness.org 70 i 11864 Err codemadness.org 70 i 11867 Err codemadness.org 70 i 11868 Err codemadness.org 70 i 11869 Err codemadness.org 70 i 11870 Err codemadness.org 70 i 11871 Err codemadness.org 70 i 11874 Err codemadness.org 70 i 11875 Err codemadness.org 70 i 11876 Err codemadness.org 70 i 11879 Err codemadness.org 70 i 11880 Err codemadness.org 70 i 11881 Err codemadness.org 70 i 11884 Err codemadness.org 70 i 11885 Err codemadness.org 70 i 11886 Err codemadness.org 70 i 11889 Err codemadness.org 70 i 11890 Err codemadness.org 70 i 11891 Err codemadness.org 70 i 11894 Err codemadness.org 70 i 11895 Err codemadness.org 70 i 11896 Err codemadness.org 70 i 11899 Err codemadness.org 70 i 11900 Err codemadness.org 70 i 11901 Err codemadness.org 70 i 11904 Err codemadness.org 70 i 11905 Err codemadness.org 70 i 11906 Err codemadness.org 70 i 11909 Err codemadness.org 70 i 11910 Err codemadness.org 70 i 11911 Err codemadness.org 70 i 11914 Err codemadness.org 70 i 11915 Err codemadness.org 70 i 11916 Err codemadness.org 70 i 11919 Err codemadness.org 70 i 11920 Err codemadness.org 70 i 11921 Err codemadness.org 70 i 11924 Err codemadness.org 70 i 11925 Err codemadness.org 70 i 11926 Err codemadness.org 70 i 11929 Err codemadness.org 70 i 11930 Err codemadness.org 70 i 11931 Err codemadness.org 70 i 11934 Err codemadness.org 70 i 11935 Err codemadness.org 70 i 11936 Err codemadness.org 70 i 11939 Err codemadness.org 70 i 11940 Err codemadness.org 70 i 11941 Err codemadness.org 70 i 11944 Err codemadness.org 70 i 11945 Err codemadness.org 70 i 11946 Err codemadness.org 70 i 11949 Err codemadness.org 70 i 11950 Err codemadness.org 70 i 11951 Err codemadness.org 70 i 11954 Err codemadness.org 70 i 11955 Err codemadness.org 70 i 11956 Err codemadness.org 70 i 11959 Err codemadness.org 70 i 11960 Err codemadness.org 70 i 11961 Err codemadness.org 70 i 11964 Err codemadness.org 70 i 11965 Err codemadness.org 70 i 11966 Err codemadness.org 70 i 11969 Err codemadness.org 70 i 11970 Err codemadness.org 70 i 11971 Err codemadness.org 70 i 11975 Err codemadness.org 70 i 11976 Err codemadness.org 70 i 11977

Err codemadness.org 70 i 11865 '2x 12G SAS disks, raid0 - ServeRAID M5210, lvm (1 linear continuous map), xfs (rw,noatime,attr2,inode64,logbufs=8,logbsize=32k,noquota), 5.3.0-24-generic (ubuntu), x86_64' - 4K writes Err codemadness.org 70 i 11866
Err codemadness.org 70 i 11872 File size 131072 Kb Err codemadness.org 70 i 11873
Err codemadness.org 70 i 11877 Writing 524288 Kb to it Err codemadness.org 70 i 11878
Err codemadness.org 70 i 11882 Err codemadness.org 70 i 11883
Err codemadness.org 70 i 11887 Simple cyclic file Err codemadness.org 70 i 11888
Err codemadness.org 70 i 11892 Took 16 seconds 5 milliseconds Err codemadness.org 70 i 11893
Err codemadness.org 70 i 11897 Err codemadness.org 70 i 11898
Err codemadness.org 70 i 11902 O_DSYNC cyclic file Err codemadness.org 70 i 11903
Err codemadness.org 70 i 11907 Took 15 seconds 664 milliseconds Err codemadness.org 70 i 11908
Err codemadness.org 70 i 11912 Err codemadness.org 70 i 11913
Err codemadness.org 70 i 11917 Mmapped cyclic file Err codemadness.org 70 i 11918
Err codemadness.org 70 i 11922 Took 17 seconds 846 milliseconds Err codemadness.org 70 i 11923
Err codemadness.org 70 i 11927 Err codemadness.org 70 i 11928
Err codemadness.org 70 i 11932 O_DIRECT\|O_DSYNC cyclic file Err codemadness.org 70 i 11933
Err codemadness.org 70 i 11937 Took 14 seconds 823 milliseconds Err codemadness.org 70 i 11938
Err codemadness.org 70 i 11942 Err codemadness.org 70 i 11943
Err codemadness.org 70 i 11947 O_APPEND append file Err codemadness.org 70 i 11948
Err codemadness.org 70 i 11952 Took 48 seconds 328 milliseconds Err codemadness.org 70 i 11953
Err codemadness.org 70 i 11957 Err codemadness.org 70 i 11958
Err codemadness.org 70 i 11962 Simple append file Err codemadness.org 70 i 11963
Err codemadness.org 70 i 11967 Took 48 seconds 207 milliseconds Err codemadness.org 70 i 11968
Err codemadness.org 70 i 11972 Err codemadness.org 70 i 11973 Err codemadness.org 70 i 11974

Err codemadness.org 70 i 11978

Err codemadness.org 70 i 11979

Err codemadness.org 70 i 11980 Err codemadness.org 70 i 11981

Err codemadness.org 70 i 11982

Err codemadness.org 70 i 11983 Err codemadness.org 70 i 11984 Err codemadness.org 70 i 11985 Err codemadness.org 70 i 11986 Err codemadness.org 70 i 11989 Err codemadness.org 70 i 11990 Err codemadness.org 70 i 11991 Err codemadness.org 70 i 11992 Err codemadness.org 70 i 11993 Err codemadness.org 70 i 11996 Err codemadness.org 70 i 11997 Err codemadness.org 70 i 11998 Err codemadness.org 70 i 12001 Err codemadness.org 70 i 12002 Err codemadness.org 70 i 12003 Err codemadness.org 70 i 12006 Err codemadness.org 70 i 12007 Err codemadness.org 70 i 12008 Err codemadness.org 70 i 12011 Err codemadness.org 70 i 12012 Err codemadness.org 70 i 12013 Err codemadness.org 70 i 12016 Err codemadness.org 70 i 12017 Err codemadness.org 70 i 12018 Err codemadness.org 70 i 12021 Err codemadness.org 70 i 12022 Err codemadness.org 70 i 12023 Err codemadness.org 70 i 12026 Err codemadness.org 70 i 12027 Err codemadness.org 70 i 12028 Err codemadness.org 70 i 12031 Err codemadness.org 70 i 12032 Err codemadness.org 70 i 12033 Err codemadness.org 70 i 12036 Err codemadness.org 70 i 12037 Err codemadness.org 70 i 12038 Err codemadness.org 70 i 12041 Err codemadness.org 70 i 12042 Err codemadness.org 70 i 12043 Err codemadness.org 70 i 12047 Err codemadness.org 70 i 12048 Err codemadness.org 70 i 12049

Err codemadness.org 70 i 11987 'xfs_info' Err codemadness.org 70 i 11988
Err codemadness.org 70 i 11994 xfs_info /var Err codemadness.org 70 i 11995
Err codemadness.org 70 i 11999 meta-data=/dev/mapper/ka4_disks-ka4_var isize=512 agcount=4, agsize=73119744 blks Err codemadness.org 70 i 12000
Err codemadness.org 70 i 12004 = sectsz=4096 attr=2, projid32bit=1 Err codemadness.org 70 i 12005
Err codemadness.org 70 i 12009 = crc=1 finobt=1 spinodes=0 rmapbt=0 Err codemadness.org 70 i 12010
Err codemadness.org 70 i 12014 = reflink=0 Err codemadness.org 70 i 12015
Err codemadness.org 70 i 12019 data = bsize=4096 blocks=292478976, imaxpct=5 Err codemadness.org 70 i 12020
Err codemadness.org 70 i 12024 = sunit=0 swidth=0 blks Err codemadness.org 70 i 12025
Err codemadness.org 70 i 12029 naming =version 2 bsize=4096 ascii-ci=0 ftype=1 Err codemadness.org 70 i 12030
Err codemadness.org 70 i 12034 log =internal bsize=4096 blocks=142812, version=2 Err codemadness.org 70 i 12035
Err codemadness.org 70 i 12039 = sectsz=4096 sunit=1 blks, lazy-count=1 Err codemadness.org 70 i 12040
Err codemadness.org 70 i 12044 realtime =none extsz=4096 blocks=0, rtextents=0 Err codemadness.org 70 i 12045 Err codemadness.org 70 i 12046

Err codemadness.org 70 i 12050

Err codemadness.org 70 i 12051

Err codemadness.org 70 i 12052 Err codemadness.org 70 i 12053

Seems this was setup for 4k too.

Err codemadness.org 70 i 12054

Err codemadness.org 70 i 12056 Comment by Err codemadness.org 70 i 12057 zongzhi chen Err codemadness.org 70 i 12058 Err codemadness.org 70 i 12059 [ Err codemadness.org 70 i 12060 2020-01-09 Err codemadness.org 70 i 12061 Err codemadness.org 70 i 12062 ] Err codemadness.org 70 i 12063 Err codemadness.org 70 i 12064 Err codemadness.org 70 i 12065

Err codemadness.org 70 i 12067

@Marko why did you abandon the work of partitioned the redo log. Since we know that AWS aurora must have done this work. Otherwise, they can't partitioned the data by space_id:page_id into multi storage node. The redo log which modify the page must stay in the same partition with the page. This is the basic design that then can apply the redo log and crash recovery parallel..

Err codemadness.org 70 i 12068 Err codemadness.org 70 i 12069

I really think that partitioned redo log is a good idea, since in the compute-storage separation architecture, InnoDB need to support much more larger data size. such as 20T or 100T. POLARDB has meet this case, If we don't partitioned the redo log and data page, then we can't parallel well..

Err codemadness.org 70 i 12070

Err codemadness.org 70 i 12072 Comment by Err codemadness.org 70 i 12073 Eugene Kosov Err codemadness.org 70 i 12074 Err codemadness.org 70 i 12075 [ Err codemadness.org 70 i 12076 2020-01-10 Err codemadness.org 70 i 12077 Err codemadness.org 70 i 12078 ] Err codemadness.org 70 i 12079 Err codemadness.org 70 i 12080 Err codemadness.org 70 i 12081

Err codemadness.org 70 i 12083

zongzhi chen thank you for your answer! I think to solve `read-on-write` we can use posix_fadvise() or posix_mavdise(). Did you try that? Now as I understand you fill file with zeroes to force OS to cache it. Can you instead preread it somehow? At first glance that looks less invasive than writing.

Err codemadness.org 70 i 12084

Err codemadness.org 70 i 12086 Comment by Err codemadness.org 70 i 12087 zongzhi chen Err codemadness.org 70 i 12088 Err codemadness.org 70 i 12089 [ Err codemadness.org 70 i 12090 2020-01-10 Err codemadness.org 70 i 12091 Err codemadness.org 70 i 12092 ] Err codemadness.org 70 i 12093 Err codemadness.org 70 i 12094 Err codemadness.org 70 i 12095

Err codemadness.org 70 i 12097

NO, The root cause is that if the read size isn't aligned to 4k block, os need to read the whole 4k block, and modify the data you want. The write operation need another read operation

Err codemadness.org 70 i 12098 Err codemadness.org 70 i 12099

The fill file with zero operation solve the allocation of extent when append to file. If the address in file hasn't beed written before then it need allocate extent from file system.

Err codemadness.org 70 i 12100 Err codemadness.org 70 i 12101

Err codemadness.org 70 i 12103 Comment by Err codemadness.org 70 i 12104 Eugene Kosov Err codemadness.org 70 i 12105 Err codemadness.org 70 i 12106 [ Err codemadness.org 70 i 12107 2020-01-29 Err codemadness.org 70 i 12108 Err codemadness.org 70 i 12109 ] Err codemadness.org 70 i 12110 Err codemadness.org 70 i 12111 Err codemadness.org 70 i 12112

Err codemadness.org 70 i 12114

Daniel Black hi. We become interested in write optimization FUA (https://bobsql.com/sql-server-on-linux-forced-unit-access-fua-internals/) It's implemented at least on XFS. And you performed benchmarks on it where `O_DIRECT|O_DSYNC` was the fastest thing. Do you have that FUA enabled? You probably can check it like this:

Err codemadness.org 70 i 12115

Err codemadness.org 70 i 12116

Err codemadness.org 70 i 12117 Err codemadness.org 70 i 12118 Err codemadness.org 70 i 12119 Err codemadness.org 70 i 12120 Err codemadness.org 70 i 12123 Err codemadness.org 70 i 12124 Err codemadness.org 70 i 12125 Err codemadness.org 70 i 12129 Err codemadness.org 70 i 12130 Err codemadness.org 70 i 12131

Err codemadness.org 70 i 12121

$ dmesg | grep -i fua

Err codemadness.org 70 i 12122

Err codemadness.org 70 i 12126

[    1.549434] sd 3:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA	Err	codemadness.org	70
i 12127

Err codemadness.org 70 i 12128

Err codemadness.org 70 i 12132

Err codemadness.org 70 i 12133

Err codemadness.org 70 i 12134 Err codemadness.org 70 i 12135 Err codemadness.org 70 i 12136

Err codemadness.org 70 i 12137

Err codemadness.org 70 i 12138 Err codemadness.org 70 i 12139 Err codemadness.org 70 i 12140 Err codemadness.org 70 i 12141 Err codemadness.org 70 i 12144 Err codemadness.org 70 i 12145 Err codemadness.org 70 i 12146 Err codemadness.org 70 i 12150 Err codemadness.org 70 i 12151 Err codemadness.org 70 i 12152

Err codemadness.org 70 i 12142

O_DIRECT|O_DSYNC cyclic file

Err codemadness.org 70 i 12143

Err codemadness.org 70 i 12147

pwrite() returned errno Invalid argument	Err	codemadness.org	70
i 12148

Err codemadness.org 70 i 12149

Err codemadness.org 70 i 12153

Err codemadness.org 70 i 12154

Err codemadness.org 70 i 12155

Do you think it was a bug in a testing program?

Err codemadness.org 70 i 12156 Err codemadness.org 70 i 12157

Also, maybe you know what `fdatasync()` does for file descriptors opened with `O_DSYNC`? In my understanding it whould be a no-op.

Err codemadness.org 70 i 12158

Err codemadness.org 70 i 12160 Comment by Err codemadness.org 70 i 12161 Daniel Black Err codemadness.org 70 i 12162 Err codemadness.org 70 i 12163 [ Err codemadness.org 70 i 12164 2020-01-30 Err codemadness.org 70 i 12165 Err codemadness.org 70 i 12166 ] Err codemadness.org 70 i 12167 Err codemadness.org 70 i 12168 Err codemadness.org 70 i 12169

Err codemadness.org 70 i 12171

pwrite() returned errno Invalid argument - I assume this was writing a 512 block when the underlying layer was 4k as changing to 4k got a result for this. fstat on the fs and use `st_blksize` probably avoids this.

Err codemadness.org 70 i 12172 Err codemadness.org 70 i 12173

Seem FUA is a standard part of nvme (which I used) and the linux nvme driver has some concept of it based on its codebase.

Err codemadness.org 70 i 12174 Err codemadness.org 70 i 12175

Appears to be nothing special with `O_DSYNC` (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/sync.c?h=v5.5#n196) nothing seemingly special at ext4/xfs implementation either.

Err codemadness.org 70 i 12176

Err codemadness.org 70 i 12178 Comment by Err codemadness.org 70 i 12179 Marko Mäkelä Err codemadness.org 70 i 12180 Err codemadness.org 70 i 12181 [ Err codemadness.org 70 i 12182 2020-02-14 Err codemadness.org 70 i 12183 Err codemadness.org 70 i 12184 ] Err codemadness.org 70 i 12185 Err codemadness.org 70 i 12186 Err codemadness.org 70 i 12187

Err codemadness.org 70 i 12189

zongzhi chen, sorry, I missed your question.

Err codemadness.org 70 i 12190 Err codemadness.org 70 i 12191

I think that if we eliminate the undo log pages and the TRX_SYS page and write all user transaction data only to the redo log, we will remove an artificial synchronization point between independent transactions. I have been toying with the idea, ever since Jun Su challenged me to think how to make more efficient use of NVDIMM or PMEM (byte-addressable persistent storage). The idea would be to write undo log records into the redo log, like many databases do it. The ~~MDEV-12353~~ redo log format does allow this easily. We could even do memory-mapped I/O and let the DB_ROLL_PTR be a direct pointer to the redo log, to speed up MVCC and ROLLBACK. I have not come up with any good solution for the redo log checkpointing, though. In this scheme, an old read view or active transaction can prevent a log checkpoint from being made. (Alternatively, we would have to append old undo log information to the redo log and patch all the DB_ROLL_PTR that are pointing to them.)

Err codemadness.org 70 i 12192 Err codemadness.org 70 i 12193

If transactions are truly independent due to not sharing any undo log pages, then I think that the partitioned log should work.

Err codemadness.org 70 i 12194

Err codemadness.org 70 i 12196 Comment by Err codemadness.org 70 i 12197 Marko Mäkelä Err codemadness.org 70 i 12198 Err codemadness.org 70 i 12199 [ Err codemadness.org 70 i 12200 2020-02-21 Err codemadness.org 70 i 12201 Err codemadness.org 70 i 12202 ] Err codemadness.org 70 i 12203 Err codemadness.org 70 i 12204 Err codemadness.org 70 i 12205

Err codemadness.org 70 i 12207

The current design idea is as follows:

Err codemadness.org 70 i 12208 Err codemadness.org 70 i 12209

Checkpoint information & file operations

Err codemadness.org 70 i 12210

There will be a separate file that contains information about log checkpoints and data file names. This file can contain information about multiple checkpoints. (The old ib_logfile0 only has room for 2 checkpoints.)

Err codemadness.org 70 i 12211 Err codemadness.org 70 i 12212

The checkpoint log file allows to construct the mapping between numeric tablespace identifiers and file names.

Err codemadness.org 70 i 12213 The checkpoint log file is never encrypted. This allows mariabackup --backup to work without having access to encryption keys. Because file names are not encrypted in the file system either, and because LSNs appear unencrypted in the diagnostic output, encrypting this file does not offer any security benefits.

Err codemadness.org 70 i 12214 Err codemadness.org 70 i 12215

A checkpoint log record comprises the checkpoint LSN and a byte offset in the circular log file, pointing to the log right after the LSN. It will also include the value of the sequence_bit that is described below.

Err codemadness.org 70 i 12216 Err codemadness.org 70 i 12217

The circular log

Err codemadness.org 70 i 12218

If any parameters of the log change, the redo log will be rebuilt:

Err codemadness.org 70 i 12219

innodb_log_file_size
innodb_encrypt_log, or the encryption key (key rotation will require the log to be rebuilt)
innodb_log_checksums (if we choose to revive this deprecated parameter and implement a variant that lacks checksums)

Err codemadness.org 70 i 12224 Err codemadness.org 70 i 12225 Err codemadness.org 70 i 12226

There will be no fixed block structure in the circular log file. The LSN will count InnoDB mini-transactions, not bytes. This allows some flexibility: For example, a future version of mariabackup --backup --incremental could inject records to the backup of the main log file, instead of writing separate .delta files.

Err codemadness.org 70 i 12227 Err codemadness.org 70 i 12228

The circular log file will consist of length-tagged sequences of bytes:

Err codemadness.org 70 i 12229

Err codemadness.org 70 i 12230

Err codemadness.org 70 i 12231 Err codemadness.org 70 i 12232 Err codemadness.org 70 i 12233 Err codemadness.org 70 i 12234 Err codemadness.org 70 i 12237 Err codemadness.org 70 i 12238 Err codemadness.org 70 i 12239 Err codemadness.org 70 i 12242 Err codemadness.org 70 i 12243 Err codemadness.org 70 i 12244 Err codemadness.org 70 i 12247 Err codemadness.org 70 i 12248 Err codemadness.org 70 i 12249 Err codemadness.org 70 i 12252 Err codemadness.org 70 i 12253 Err codemadness.org 70 i 12254 Err codemadness.org 70 i 12257 Err codemadness.org 70 i 12258 Err codemadness.org 70 i 12259 Err codemadness.org 70 i 12262 Err codemadness.org 70 i 12263 Err codemadness.org 70 i 12264 Err codemadness.org 70 i 12267 Err codemadness.org 70 i 12268 Err codemadness.org 70 i 12269 Err codemadness.org 70 i 12272 Err codemadness.org 70 i 12273 Err codemadness.org 70 i 12274 Err codemadness.org 70 i 12277 Err codemadness.org 70 i 12278 Err codemadness.org 70 i 12279 Err codemadness.org 70 i 12282 Err codemadness.org 70 i 12283 Err codemadness.org 70 i 12284 Err codemadness.org 70 i 12287 Err codemadness.org 70 i 12288 Err codemadness.org 70 i 12289 Err codemadness.org 70 i 12292 Err codemadness.org 70 i 12293 Err codemadness.org 70 i 12294 Err codemadness.org 70 i 12297 Err codemadness.org 70 i 12298 Err codemadness.org 70 i 12299 Err codemadness.org 70 i 12302 Err codemadness.org 70 i 12303 Err codemadness.org 70 i 12304 Err codemadness.org 70 i 12307 Err codemadness.org 70 i 12308 Err codemadness.org 70 i 12309 Err codemadness.org 70 i 12312 Err codemadness.org 70 i 12313 Err codemadness.org 70 i 12314 Err codemadness.org 70 i 12317 Err codemadness.org 70 i 12318 Err codemadness.org 70 i 12319 Err codemadness.org 70 i 12322 Err codemadness.org 70 i 12323 Err codemadness.org 70 i 12324 Err codemadness.org 70 i 12327 Err codemadness.org 70 i 12328 Err codemadness.org 70 i 12329 Err codemadness.org 70 i 12333 Err codemadness.org 70 i 12334 Err codemadness.org 70 i 12335

Err codemadness.org 70 i 12235

byte *append_log(byte *log, const void *payload, size_t size, bool skip_bit, bool sequence_bit)

Err codemadness.org 70 i 12236

Err codemadness.org 70 i 12240

Err codemadness.org 70 i 12241

Err codemadness.org 70 i 12245

  size_t length= size;

Err codemadness.org 70 i 12246

Err codemadness.org 70 i 12250

  if (!skip_bit && innodb_log_checksums)

Err codemadness.org 70 i 12251

Err codemadness.org 70 i 12255

    length+= 4; /* CRC-32C at the end of the payload */

Err codemadness.org 70 i 12256

Err codemadness.org 70 i 12260

  byte * const start= log;

Err codemadness.org 70 i 12261

Err codemadness.org 70 i 12265

  log= mlog_encode_varint(log, length << 2 | skip_bit << 1 | sequence_bit);

Err codemadness.org 70 i 12266

Err codemadness.org 70 i 12270

  if (!skip_bit)

Err codemadness.org 70 i 12271

Err codemadness.org 70 i 12275

    memcpy(log, payload, size);

Err codemadness.org 70 i 12276

Err codemadness.org 70 i 12280

  log+= size;

Err codemadness.org 70 i 12281

Err codemadness.org 70 i 12285

  if (!skip_bit && innodb_log_checksums)

Err codemadness.org 70 i 12286

Err codemadness.org 70 i 12290

Err codemadness.org 70 i 12291

Err codemadness.org 70 i 12295

    /* Always compute the checksum without the sequence_bit. */

Err codemadness.org 70 i 12296

Err codemadness.org 70 i 12300

    log[-size - 1]&= 0xfe;

Err codemadness.org 70 i 12301

Err codemadness.org 70 i 12305

    mach_write_to_4(log, ut_crc32(start, log - start));

Err codemadness.org 70 i 12306

Err codemadness.org 70 i 12310

    log[-size - 1]|= sequence_bit;

Err codemadness.org 70 i 12311

Err codemadness.org 70 i 12315

    log+= 4;

Err codemadness.org 70 i 12316

Err codemadness.org 70 i 12320

Err codemadness.org 70 i 12321

Err codemadness.org 70 i 12325

  return log;

Err codemadness.org 70 i 12326

Err codemadness.org 70 i 12330

}	Err	codemadness.org	70
i 12331

Err codemadness.org 70 i 12332

Err codemadness.org 70 i 12336

Err codemadness.org 70 i 12337

Err codemadness.org 70 i 12338

Explanation:

Err codemadness.org 70 i 12339

If encryption is enabled, the payload will have been encrypted before the log is written. The length and the checksum will not be encrypted.
The sequence_bit will be toggled whenever the write position jumps from the end of the circular log file to the beginning.
The skip_bit allows us to write a partially filled log block of any size. If we need to persist the log (due to user transaction commit) and we are L bytes into a N-byte block (this depends on the underlying storage!), we can write a special record to say ‘skip the next N-L bytes’. There is no need to initialize (memset()) any skipped garbage bytes.
We assume that the log ends when we get a CRC-32C mismatch or the sequence_bit of the next record differs from what we expect. (The last log record could end exactly at a byte offset where a log record before the last wrap-around had been stored, and that record would have a valid checksum.)
Note: due to the skip_bit and the lack of memset(), it may be necessary to always store checksums, to reliably detect the end of the log.

Err codemadness.org 70 i 12346 Err codemadness.org 70 i 12347

Err codemadness.org 70 i 12349 Comment by Err codemadness.org 70 i 12350 zongzhi chen Err codemadness.org 70 i 12351 Err codemadness.org 70 i 12352 [ Err codemadness.org 70 i 12353 2020-02-24 Err codemadness.org 70 i 12354 Err codemadness.org 70 i 12355 ] Err codemadness.org 70 i 12356 Err codemadness.org 70 i 12357 Err codemadness.org 70 i 12358

Err codemadness.org 70 i 12360

@markoMarko Mäkelä

Err codemadness.org 70 i 12361 Err codemadness.org 70 i 12362

The design right now is that the partition is still based on space_id:page_no, and then if the mtr modify multi page, then we need flush all the redo log that id modified.. Is that right? Please correct me if I misunderstanding something..

Err codemadness.org 70 i 12363 And even though this solution looks like too rought, I think it is a practical solution, since most of the mtr only modify single page, most of the mtr modify multi page is the smo operation and undo operation. And we can write the undo log in the redo log directly, then the undo log will stay the same file with the redo log. And the smo operation is useless..

Err codemadness.org 70 i 12364 Err codemadness.org 70 i 12365

However, how can we keep the operation of flushing multi file atomic?

Err codemadness.org 70 i 12366

Err codemadness.org 70 i 12368 Comment by Err codemadness.org 70 i 12369 Eugene Kosov Err codemadness.org 70 i 12370 Err codemadness.org 70 i 12371 [ Err codemadness.org 70 i 12372 2020-02-25 Err codemadness.org 70 i 12373 Err codemadness.org 70 i 12374 ] Err codemadness.org 70 i 12375 Err codemadness.org 70 i 12376 Err codemadness.org 70 i 12377

Err codemadness.org 70 i 12379

> However, how can we keep the operation of flushing multi file atomic?

Err codemadness.org 70 i 12380 Err codemadness.org 70 i 12381

I don't think we have such a problem at all. Only one file with redo data will exists. Writing to it looks like this: thread which owns mtr_t prepares buffer to write to a file (prepends it's size, computes crc32 and appends it to the end), then takes log mutex to write() buffer, releases mutex and performs fsync(). And that's it. Then, after some LSN is flushed to redo we can write(O_DIRECT|O_APPEND) corresponding checkpoint to a another file. Writes to log file and checkpoint files are not required to be atomical, thus, it's safe to crash right after flushing redo log, and before writing a checkpoint.

Err codemadness.org 70 i 12382

Err codemadness.org 70 i 12384 Comment by Err codemadness.org 70 i 12385 zongzhi chen Err codemadness.org 70 i 12386 Err codemadness.org 70 i 12387 [ Err codemadness.org 70 i 12388 2020-02-25 Err codemadness.org 70 i 12389 Err codemadness.org 70 i 12390 ] Err codemadness.org 70 i 12391 Err codemadness.org 70 i 12392 Err codemadness.org 70 i 12393

Err codemadness.org 70 i 12395

No, If the mtr is a smo operation, then this mtr will include multi page operation..

Err codemadness.org 70 i 12396 Then when mtr commit, it need to change more than one data page, then these two page may exist two different redo files as your partitioned by space_id:page_no. When we commit the trx, then we need to promise that the write to two redo logs is atomic. Since in the origin version, we only need to write to one file. It is easy to guarantee that the write is atomic. We don't have this problem.

Err codemadness.org 70 i 12397

Err codemadness.org 70 i 12399 Comment by Err codemadness.org 70 i 12400 Eugene Kosov Err codemadness.org 70 i 12401 Err codemadness.org 70 i 12402 [ Err codemadness.org 70 i 12403 2020-02-25 Err codemadness.org 70 i 12404 Err codemadness.org 70 i 12405 ] Err codemadness.org 70 i 12406 Err codemadness.org 70 i 12407 Err codemadness.org 70 i 12408

Err codemadness.org 70 i 12410

Sorry, I think you have some misunderstanding. There are no several redo log files partitioned by space_it::page_no. Before 10.5 it was possible to have several redo log files, but they're used as one logical circular file. In current 10.5 it's already impossible to have several log files. And current design for new file format still assumes just one circular redo log file.

Err codemadness.org 70 i 12411

Err codemadness.org 70 i 12413 Comment by Err codemadness.org 70 i 12414 zongzhi chen Err codemadness.org 70 i 12415 Err codemadness.org 70 i 12416 [ Err codemadness.org 70 i 12417 2020-02-26 Err codemadness.org 70 i 12418 Err codemadness.org 70 i 12419 ] Err codemadness.org 70 i 12420 Err codemadness.org 70 i 12421 Err codemadness.org 70 i 12422

Err codemadness.org 70 i 12424

Sorry, I saw the design document

Err codemadness.org 70 i 12425 "The idea: Partition the log into append-only, truncate-the-start files"

Err codemadness.org 70 i 12426 Err codemadness.org 70 i 12427

I suppose we are talking about partition the redo log into multi redo log file..

Err codemadness.org 70 i 12428

Err codemadness.org 70 i 12430 Comment by Err codemadness.org 70 i 12431 Eugene Kosov Err codemadness.org 70 i 12432 Err codemadness.org 70 i 12433 [ Err codemadness.org 70 i 12434 2020-02-26 Err codemadness.org 70 i 12435 Err codemadness.org 70 i 12436 ] Err codemadness.org 70 i 12437 Err codemadness.org 70 i 12438 Err codemadness.org 70 i 12439

Err codemadness.org 70 i 12441

zongzhi chen this initial design was changed. You can find the recent version in comments for this issue. We decided to the the simplest possible thing: metadata file with creator version and such info is a separate file, checkpoints + file operations (create, delete, rename) is a separate append-only file, and actual redo log data is a third separate circular file.

Err codemadness.org 70 i 12442

Err codemadness.org 70 i 12444 Comment by Err codemadness.org 70 i 12445 zongzhi chen Err codemadness.org 70 i 12446 Err codemadness.org 70 i 12447 [ Err codemadness.org 70 i 12448 2020-02-26 Err codemadness.org 70 i 12449 Err codemadness.org 70 i 12450 ] Err codemadness.org 70 i 12451 Err codemadness.org 70 i 12452 Err codemadness.org 70 i 12453

Err codemadness.org 70 i 12455

@Eugene Kosov Ok, I got it..

Err codemadness.org 70 i 12456 Err codemadness.org 70 i 12457

let me summary changes are:

Err codemadness.org 70 i 12458 1. separate the chekpoint information from ib_logfile

Err codemadness.org 70 i 12459 2. add the file operation in the checkpoint file

Err codemadness.org 70 i 12460 3. the undo data in the redo log as comment by marko

Err codemadness.org 70 i 12461 4. lsn count the number of mtr, not byte

Err codemadness.org 70 i 12462 Err codemadness.org 70 i 12463

is it right?

Err codemadness.org 70 i 12464 Err codemadness.org 70 i 12465

However, I really interested in seperate the data into multi redo log files, since in the Architeture like aurora and PolarDB, there will exist about 100T large btree, if we don't partition it, there will only one redo log file, we can't make use of the under layer storage of fs..

Err codemadness.org 70 i 12466

Err codemadness.org 70 i 12468 Comment by Err codemadness.org 70 i 12469 Marko Mäkelä Err codemadness.org 70 i 12470 Err codemadness.org 70 i 12471 [ Err codemadness.org 70 i 12472 2020-02-28 Err codemadness.org 70 i 12473 Err codemadness.org 70 i 12474 ] Err codemadness.org 70 i 12475 Err codemadness.org 70 i 12476 Err codemadness.org 70 i 12477

Err codemadness.org 70 i 12479

zongzhi chen, I have been thinking of the following format:

Err codemadness.org 70 i 12480

Maintain a 512-byte header in ib_logfile0. Add information needed by innodb_encrypt_log there.
After the first 512 bytes, write an append-only log consisting only of file name records (similar to the ~~MDEV-12353~~ FILE_ records) and fixed-length checkpoint records. Each record will be followed by a CRC-32C checksum. The ib_logfile0 will never be encrypted. (File names and LSNs appear unencrypted in the file system and in the logs anyway.)
We write a separate circular file ib_logdata that may be encrypted. The checkpoint records point to a byte offset within this file. This file can support any underlying physical sector size.
LSN will be in bytes, just like before. But, encryption might no longer use LSN as part of the initialization vector, so that we can encrypt mtr_t::m_log before acquiring any mutex.
Rebuilding the redo log file will not affect the LSN.
In the future, mariabackup --backup --incremental could get rid of .delta files and instead write the information to the ib_logfile0 file. Any amount of data can be written to that file without affecting the LSN.

Err codemadness.org 70 i 12488 Err codemadness.org 70 i 12489 Err codemadness.org 70 i 12490

The circular log file could technically be split to multiple files, but we did not see a need for that. I think 128 TiB should suffice for quite some time in the future. The log checkpoint record would be 1+8+6+4=19 bytes.

Err codemadness.org 70 i 12491 Err codemadness.org 70 i 12492

At this point, we will not write undo log data to the redo log. I do not know if we will ever do that. I only mentioned the idea and challenges around it.

Err codemadness.org 70 i 12493

Err codemadness.org 70 i 12495 Comment by Err codemadness.org 70 i 12496 Eugene Kosov Err codemadness.org 70 i 12497 Err codemadness.org 70 i 12498 [ Err codemadness.org 70 i 12499 2020-04-28 Err codemadness.org 70 i 12500 Err codemadness.org 70 i 12501 ] Err codemadness.org 70 i 12502 Err codemadness.org 70 i 12503 Err codemadness.org 70 i 12504

Err codemadness.org 70 i 12506

I did some research on writing to a file from different threads. My testing code is in https://github.com/kevgs/redo/

Err codemadness.org 70 i 12507 Here are the results for single thread for commit 0400fe0cc3829177c05341413e555c1f09f81b54 on my weak laptop with HDD:

Err codemadness.org 70 i 12508

Err codemadness.org 70 i 12509

Err codemadness.org 70 i 12510 Err codemadness.org 70 i 12511 Err codemadness.org 70 i 12512 Err codemadness.org 70 i 12513 Err codemadness.org 70 i 12516 Err codemadness.org 70 i 12517 Err codemadness.org 70 i 12518 Err codemadness.org 70 i 12521 Err codemadness.org 70 i 12522 Err codemadness.org 70 i 12523 Err codemadness.org 70 i 12526 Err codemadness.org 70 i 12527 Err codemadness.org 70 i 12528 Err codemadness.org 70 i 12531 Err codemadness.org 70 i 12532 Err codemadness.org 70 i 12533 Err codemadness.org 70 i 12536 Err codemadness.org 70 i 12537 Err codemadness.org 70 i 12538 Err codemadness.org 70 i 12541 Err codemadness.org 70 i 12542 Err codemadness.org 70 i 12543 Err codemadness.org 70 i 12546 Err codemadness.org 70 i 12547 Err codemadness.org 70 i 12548 Err codemadness.org 70 i 12551 Err codemadness.org 70 i 12552 Err codemadness.org 70 i 12553 Err codemadness.org 70 i 12556 Err codemadness.org 70 i 12557 Err codemadness.org 70 i 12558 Err codemadness.org 70 i 12561 Err codemadness.org 70 i 12562 Err codemadness.org 70 i 12563 Err codemadness.org 70 i 12566 Err codemadness.org 70 i 12567 Err codemadness.org 70 i 12568 Err codemadness.org 70 i 12571 Err codemadness.org 70 i 12572 Err codemadness.org 70 i 12573 Err codemadness.org 70 i 12576 Err codemadness.org 70 i 12577 Err codemadness.org 70 i 12578 Err codemadness.org 70 i 12581 Err codemadness.org 70 i 12582 Err codemadness.org 70 i 12583 Err codemadness.org 70 i 12586 Err codemadness.org 70 i 12587 Err codemadness.org 70 i 12588 Err codemadness.org 70 i 12591 Err codemadness.org 70 i 12592 Err codemadness.org 70 i 12593 Err codemadness.org 70 i 12596 Err codemadness.org 70 i 12597 Err codemadness.org 70 i 12598 Err codemadness.org 70 i 12601 Err codemadness.org 70 i 12602 Err codemadness.org 70 i 12603 Err codemadness.org 70 i 12606 Err codemadness.org 70 i 12607 Err codemadness.org 70 i 12608 Err codemadness.org 70 i 12611 Err codemadness.org 70 i 12612 Err codemadness.org 70 i 12613 Err codemadness.org 70 i 12616 Err codemadness.org 70 i 12617 Err codemadness.org 70 i 12618 Err codemadness.org 70 i 12622 Err codemadness.org 70 i 12623 Err codemadness.org 70 i 12624

Err codemadness.org 70 i 12514

File size: 134217728, threads: 1, duration: 20s

Err codemadness.org 70 i 12515

Err codemadness.org 70 i 12519

Err codemadness.org 70 i 12520

Err codemadness.org 70 i 12524

Circular file:

Err codemadness.org 70 i 12525

Err codemadness.org 70 i 12529

RedoSyncTLSBuffer handled 841 commits

Err codemadness.org 70 i 12530

Err codemadness.org 70 i 12534

RedoSync handled 368 commits

Err codemadness.org 70 i 12535

Err codemadness.org 70 i 12539

RedoSyncBuffer handled 801 commits

Err codemadness.org 70 i 12540

Err codemadness.org 70 i 12544

RedoODirectSparse handled 390 commits

Err codemadness.org 70 i 12545

Err codemadness.org 70 i 12549

RedoODirectBuffer handled 513 commits

Err codemadness.org 70 i 12550

Err codemadness.org 70 i 12554

RedoODirectTwoBuffers handled 747 commits

Err codemadness.org 70 i 12555

Err codemadness.org 70 i 12559

RedoOverlappedFsync handled 670 commits

Err codemadness.org 70 i 12560

Err codemadness.org 70 i 12564

RedoOverlappedMsync handled 3235 commits

Err codemadness.org 70 i 12565

Err codemadness.org 70 i 12569

RedoGroupCommit handled 744 commits

Err codemadness.org 70 i 12570

Err codemadness.org 70 i 12574

Err codemadness.org 70 i 12575

Err codemadness.org 70 i 12579

Append-only file:

Err codemadness.org 70 i 12580

Err codemadness.org 70 i 12584

RedoSyncTLSBuffer handled 758 commits

Err codemadness.org 70 i 12585

Err codemadness.org 70 i 12589

RedoSync handled 361 commits

Err codemadness.org 70 i 12590

Err codemadness.org 70 i 12594

RedoSyncBuffer handled 823 commits

Err codemadness.org 70 i 12595

Err codemadness.org 70 i 12599

RedoODirectSparse handled 365 commits

Err codemadness.org 70 i 12600

Err codemadness.org 70 i 12604

RedoODirectBuffer handled 756 commits

Err codemadness.org 70 i 12605

Err codemadness.org 70 i 12609

RedoODirectTwoBuffers handled 753 commits

Err codemadness.org 70 i 12610

Err codemadness.org 70 i 12614

RedoOverlappedFsync handled 786 commits

Err codemadness.org 70 i 12615

Err codemadness.org 70 i 12619

RedoGroupCommit handled 766 commits	Err	codemadness.org	70
i 12620

Err codemadness.org 70 i 12621

Err codemadness.org 70 i 12625

Err codemadness.org 70 i 12626

Err codemadness.org 70 i 12627 Err codemadness.org 70 i 12628

And for 64 threads:

Err codemadness.org 70 i 12629

Err codemadness.org 70 i 12630

Err codemadness.org 70 i 12631 Err codemadness.org 70 i 12632 Err codemadness.org 70 i 12633 Err codemadness.org 70 i 12634 Err codemadness.org 70 i 12637 Err codemadness.org 70 i 12638 Err codemadness.org 70 i 12639 Err codemadness.org 70 i 12642 Err codemadness.org 70 i 12643 Err codemadness.org 70 i 12644 Err codemadness.org 70 i 12647 Err codemadness.org 70 i 12648 Err codemadness.org 70 i 12649 Err codemadness.org 70 i 12652 Err codemadness.org 70 i 12653 Err codemadness.org 70 i 12654 Err codemadness.org 70 i 12657 Err codemadness.org 70 i 12658 Err codemadness.org 70 i 12659 Err codemadness.org 70 i 12662 Err codemadness.org 70 i 12663 Err codemadness.org 70 i 12664 Err codemadness.org 70 i 12667 Err codemadness.org 70 i 12668 Err codemadness.org 70 i 12669 Err codemadness.org 70 i 12672 Err codemadness.org 70 i 12673 Err codemadness.org 70 i 12674 Err codemadness.org 70 i 12677 Err codemadness.org 70 i 12678 Err codemadness.org 70 i 12679 Err codemadness.org 70 i 12682 Err codemadness.org 70 i 12683 Err codemadness.org 70 i 12684 Err codemadness.org 70 i 12687 Err codemadness.org 70 i 12688 Err codemadness.org 70 i 12689 Err codemadness.org 70 i 12692 Err codemadness.org 70 i 12693 Err codemadness.org 70 i 12694 Err codemadness.org 70 i 12697 Err codemadness.org 70 i 12698 Err codemadness.org 70 i 12699 Err codemadness.org 70 i 12702 Err codemadness.org 70 i 12703 Err codemadness.org 70 i 12704 Err codemadness.org 70 i 12707 Err codemadness.org 70 i 12708 Err codemadness.org 70 i 12709 Err codemadness.org 70 i 12712 Err codemadness.org 70 i 12713 Err codemadness.org 70 i 12714 Err codemadness.org 70 i 12717 Err codemadness.org 70 i 12718 Err codemadness.org 70 i 12719 Err codemadness.org 70 i 12722 Err codemadness.org 70 i 12723 Err codemadness.org 70 i 12724 Err codemadness.org 70 i 12727 Err codemadness.org 70 i 12728 Err codemadness.org 70 i 12729 Err codemadness.org 70 i 12732 Err codemadness.org 70 i 12733 Err codemadness.org 70 i 12734 Err codemadness.org 70 i 12737 Err codemadness.org 70 i 12738 Err codemadness.org 70 i 12739 Err codemadness.org 70 i 12743 Err codemadness.org 70 i 12744 Err codemadness.org 70 i 12745

Err codemadness.org 70 i 12635

File size: 134217728, threads: 64, duration: 20s

Err codemadness.org 70 i 12636

Err codemadness.org 70 i 12640

Err codemadness.org 70 i 12641

Err codemadness.org 70 i 12645

Circular file:

Err codemadness.org 70 i 12646

Err codemadness.org 70 i 12650

RedoSyncTLSBuffer handled 825 commits

Err codemadness.org 70 i 12651

Err codemadness.org 70 i 12655

RedoSync handled 434 commits

Err codemadness.org 70 i 12656

Err codemadness.org 70 i 12660

RedoSyncBuffer handled 823 commits

Err codemadness.org 70 i 12661

Err codemadness.org 70 i 12665

RedoODirectSparse handled 487 commits

Err codemadness.org 70 i 12666

Err codemadness.org 70 i 12670

RedoODirectBuffer handled 851 commits

Err codemadness.org 70 i 12671

Err codemadness.org 70 i 12675

RedoODirectTwoBuffers handled 863 commits

Err codemadness.org 70 i 12676

Err codemadness.org 70 i 12680

RedoOverlappedFsync handled 11242 commits

Err codemadness.org 70 i 12681

Err codemadness.org 70 i 12685

RedoOverlappedMsync handled 58714 commits

Err codemadness.org 70 i 12686

Err codemadness.org 70 i 12690

RedoGroupCommit handled 1035 commits

Err codemadness.org 70 i 12691

Err codemadness.org 70 i 12695

Err codemadness.org 70 i 12696

Err codemadness.org 70 i 12700

Append-only file:

Err codemadness.org 70 i 12701

Err codemadness.org 70 i 12705

RedoSyncTLSBuffer handled 879 commits

Err codemadness.org 70 i 12706

Err codemadness.org 70 i 12710

RedoSync handled 514 commits

Err codemadness.org 70 i 12711

Err codemadness.org 70 i 12715

RedoSyncBuffer handled 855 commits

Err codemadness.org 70 i 12716

Err codemadness.org 70 i 12720

RedoODirectSparse handled 477 commits

Err codemadness.org 70 i 12721

Err codemadness.org 70 i 12725

RedoODirectBuffer handled 830 commits

Err codemadness.org 70 i 12726

Err codemadness.org 70 i 12730

RedoODirectTwoBuffers handled 896 commits

Err codemadness.org 70 i 12731

Err codemadness.org 70 i 12735

RedoOverlappedFsync handled 11318 commits

Err codemadness.org 70 i 12736

Err codemadness.org 70 i 12740

RedoGroupCommit handled 1361 commits	Err	codemadness.org	70
i 12741

Err codemadness.org 70 i 12742

Err codemadness.org 70 i 12746

Err codemadness.org 70 i 12747

Err codemadness.org 70 i 12748 Err codemadness.org 70 i 12749

In multithreaded environment append-only file has the same performance as circular one.

Err codemadness.org 70 i 12750

Err codemadness.org 70 i 12752 Comment by Err codemadness.org 70 i 12753 Eugene Kosov Err codemadness.org 70 i 12754 Err codemadness.org 70 i 12755 [ Err codemadness.org 70 i 12756 2020-04-28 Err codemadness.org 70 i 12757 Err codemadness.org 70 i 12758 ] Err codemadness.org 70 i 12759 Err codemadness.org 70 i 12760 Err codemadness.org 70 i 12761

Err codemadness.org 70 i 12763

Actually with fdatasync() instead of fsync() the picture is different now:

Err codemadness.org 70 i 12764

Err codemadness.org 70 i 12765

Err codemadness.org 70 i 12766 Err codemadness.org 70 i 12767 Err codemadness.org 70 i 12768 Err codemadness.org 70 i 12769 Err codemadness.org 70 i 12772 Err codemadness.org 70 i 12773 Err codemadness.org 70 i 12774 Err codemadness.org 70 i 12777 Err codemadness.org 70 i 12778 Err codemadness.org 70 i 12779 Err codemadness.org 70 i 12782 Err codemadness.org 70 i 12783 Err codemadness.org 70 i 12784 Err codemadness.org 70 i 12787 Err codemadness.org 70 i 12788 Err codemadness.org 70 i 12789 Err codemadness.org 70 i 12792 Err codemadness.org 70 i 12793 Err codemadness.org 70 i 12794 Err codemadness.org 70 i 12797 Err codemadness.org 70 i 12798 Err codemadness.org 70 i 12799 Err codemadness.org 70 i 12802 Err codemadness.org 70 i 12803 Err codemadness.org 70 i 12804 Err codemadness.org 70 i 12808 Err codemadness.org 70 i 12809 Err codemadness.org 70 i 12810

Err codemadness.org 70 i 12770

File size: 134217728, threads: 64, duration: 20s

Err codemadness.org 70 i 12771

Err codemadness.org 70 i 12775

Err codemadness.org 70 i 12776

Err codemadness.org 70 i 12780

Circular file:

Err codemadness.org 70 i 12781

Err codemadness.org 70 i 12785

RedoOverlappedFsync handled 50247 commits

Err codemadness.org 70 i 12786

Err codemadness.org 70 i 12790

Err codemadness.org 70 i 12791

Err codemadness.org 70 i 12795

Append-only file:

Err codemadness.org 70 i 12796

Err codemadness.org 70 i 12800

RedoOverlappedFsync handled 14399 commits

Err codemadness.org 70 i 12801

Err codemadness.org 70 i 12805

	Err	codemadness.org	70
i 12806

Err codemadness.org 70 i 12807

Err codemadness.org 70 i 12811

Err codemadness.org 70 i 12812

Err codemadness.org 70 i 12813

Err codemadness.org 70 i 12815 Comment by Err codemadness.org 70 i 12816 Nuno Err codemadness.org 70 i 12817 Err codemadness.org 70 i 12818 [ Err codemadness.org 70 i 12819 2021-02-04 Err codemadness.org 70 i 12820 Err codemadness.org 70 i 12821 ] Err codemadness.org 70 i 12822 Err codemadness.org 70 i 12823 Err codemadness.org 70 i 12824

Err codemadness.org 70 i 12826

Hi,

Err codemadness.org 70 i 12827 Err codemadness.org 70 i 12828

If " innodb_log_files_in_group " is being removed/ignored, you may want to update the documentation at:

Err codemadness.org 70 i 12829 https://mariadb.com/kb/en/innodb-redo-log/

Err codemadness.org 70 i 12830 Err codemadness.org 70 i 12831

Which advices to configure that variable as required.

Err codemadness.org 70 i 12832 Err codemadness.org 70 i 12833

Thank you.

Err codemadness.org 70 i 12834

Err codemadness.org 70 i 12836 Comment by Err codemadness.org 70 i 12837 Ian Gilfillan Err codemadness.org 70 i 12838 Err codemadness.org 70 i 12839 [ Err codemadness.org 70 i 12840 2021-02-05 Err codemadness.org 70 i 12841 Err codemadness.org 70 i 12842 ] Err codemadness.org 70 i 12843 Err codemadness.org 70 i 12844 Err codemadness.org 70 i 12845

Err codemadness.org 70 i 12847

Thanks Nuno, the documentation has been expanded to mention the 10.5 change in each place where it could be relevant, so hopefully its not misleading any longer.

Err codemadness.org 70 i 12848

Err codemadness.org 70 i 12850 Comment by Err codemadness.org 70 i 12851 Marko Mäkelä Err codemadness.org 70 i 12852 Err codemadness.org 70 i 12853 [ Err codemadness.org 70 i 12854 2021-03-02 Err codemadness.org 70 i 12855 Err codemadness.org 70 i 12856 ] Err codemadness.org 70 i 12857 Err codemadness.org 70 i 12858 Err codemadness.org 70 i 12859

Err codemadness.org 70 i 12861

I am sorry, but it does not look like this can be completed in the 10.6 release. At the time when I was finally ready to resume this, we were already close to a feature freeze, and I was reluctant to start changing the file format and rewriting the recovery code that late. So, instead I spent the time on addressing another bottleneck: lock_sys.mutex. With ~~MDEV-23855~~, ~~MDEV-20612~~ and ~~MDEV-24738~~ completed, the major remaining scalability bottleneck in InnoDB is log_sys.mutex, which will be addressed by this task, hopefully very early during the 10.7 development cycle.

Err codemadness.org 70 i 12862

Err codemadness.org 70 i 12864 Comment by Err codemadness.org 70 i 12865 Marko Mäkelä Err codemadness.org 70 i 12866 Err codemadness.org 70 i 12867 [ Err codemadness.org 70 i 12868 2021-07-26 Err codemadness.org 70 i 12869 Err codemadness.org 70 i 12870 ] Err codemadness.org 70 i 12871 Err codemadness.org 70 i 12872 Err codemadness.org 70 i 12873

Err codemadness.org 70 i 12875

I experimented whether if it makes sense to eliminate FILE_MODIFY and similar records from the normal redo log. The idea was to introduce a separate append-only file exclusively for checkpoint and file name information. I ran Sysbench oltp_update_index using 80×10,000 rows and innodb_log_file_size=2G before and after the change, on the server process pinned to a single Intel® Xeon® E5-2630 processor. During the benchmark, the LSN grew to about 12.6 GiB, that is, 6 times the log file size.

Err codemadness.org 70 i 12876 I observed the following numbers of transactions per second with different numbers of concurrent connections:

Err codemadness.org 70 i 12877

Err codemadness.org 70 i 12878 Err codemadness.org 70 i 12879 Err codemadness.org 70 i 12880 Err codemadness.org 70 i 12881 Err codemadness.org 70 i 12882 Err codemadness.org 70 i 12883 Err codemadness.org 70 i 12884 Err codemadness.org 70 i 12885 Err codemadness.org 70 i 12886 Err codemadness.org 70 i 12887 Err codemadness.org 70 i 12888 Err codemadness.org 70 i 12889 Err codemadness.org 70 i 12890 Err codemadness.org 70 i 12891 Err codemadness.org 70 i 12892 Err codemadness.org 70 i 12893 Err codemadness.org 70 i 12894 Err codemadness.org 70 i 12895 Err codemadness.org 70 i 12896 Err codemadness.org 70 i 12897

server	10/tps	20/tps	30/tps
10.7	100909	157561	159615
10.7-modified	100806	159263	160353

Err codemadness.org 70 i 12898

Err codemadness.org 70 i 12899 Err codemadness.org 70 i 12900

We would seem to need a run with significantly more log checkpoints, because log checkpoints are where I would expect the FILE_MODIFY bookkeeping (the fil_system.named_spaces) to make the most difference. Here is another test with innodb_log_file_size=256M (1/8 of the original log file size):

Err codemadness.org 70 i 12901

Err codemadness.org 70 i 12902 Err codemadness.org 70 i 12903 Err codemadness.org 70 i 12904 Err codemadness.org 70 i 12905 Err codemadness.org 70 i 12906 Err codemadness.org 70 i 12907 Err codemadness.org 70 i 12908 Err codemadness.org 70 i 12909 Err codemadness.org 70 i 12910 Err codemadness.org 70 i 12911 Err codemadness.org 70 i 12912 Err codemadness.org 70 i 12913 Err codemadness.org 70 i 12914 Err codemadness.org 70 i 12915 Err codemadness.org 70 i 12916 Err codemadness.org 70 i 12917 Err codemadness.org 70 i 12918 Err codemadness.org 70 i 12919 Err codemadness.org 70 i 12920 Err codemadness.org 70 i 12921

server	10/tps	20/tps	30/tps
10.7	97272	151572	153554
10.7-modified	99020	154903	157719

Err codemadness.org 70 i 12922

Err codemadness.org 70 i 12923 Err codemadness.org 70 i 12924 Err codemadness.org 70 i 12925

The 2-minute benchmark runs probably are too short for us to draw any conclusions.

Err codemadness.org 70 i 12926 Err codemadness.org 70 i 12927

If this change does not appear to consistently lead to a significant improvement, then I think that it would be best to keep the single circular log file, with a slightly changed structure that I think should be friendly for both persistent memory (PMEM) and computational storage drives (such as those by ScaleFlux):

Err codemadness.org 70 i 12928

2 checkpoint (and file format) information blocks of 4096 bytes each
Circular log file, with arbitrary block size (64 to 4096 bytes); padded with NUL bytes that are not encrypted nor checksummed

Err codemadness.org 70 i 12932 Err codemadness.org 70 i 12933

Err codemadness.org 70 i 12935 Comment by Err codemadness.org 70 i 12936 Marko Mäkelä Err codemadness.org 70 i 12937 Err codemadness.org 70 i 12938 [ Err codemadness.org 70 i 12939 2021-07-30 Err codemadness.org 70 i 12940 Err codemadness.org 70 i 12941 ] Err codemadness.org 70 i 12942 Err codemadness.org 70 i 12943 Err codemadness.org 70 i 12944

Err codemadness.org 70 i 12946

Another benchmark for assessing the impact of eliminating the FILE_MODIFY records showed some improvement at 32 concurrent connections, and virtually no improvement at 16 concurrent connections.

Err codemadness.org 70 i 12947 Err codemadness.org 70 i 12948

It might still turn out that changing the log block format and switching to asynchronous O_DIRECT|O_DSYNC writes of log blocks will reduce contention on log_sys.mutex so much that eliminating the FILE_MODIFY records would not bring significant additional benefit. For this reason, it may be wise to first develop the concurrency-friendlier log block format and then test the removal of the FILE_MODIFY records on top of that.

Err codemadness.org 70 i 12949

Err codemadness.org 70 i 12951

[MDEV-27079] When creating a table, the abnormal default domain will cause the service to hang

willcao — Fri, 19 Nov 2021 09:28:11 +0000

Err codemadness.org 70 i 13027 Err codemadness.org 70 i 13028 Err codemadness.org 70 i 13037 Err codemadness.org 70 i 13038 Err codemadness.org 70 i 13039 Err codemadness.org 70 i 13040 Err codemadness.org 70 i 13041 Err codemadness.org 70 i 13042 Err codemadness.org 70 i 13043 Err codemadness.org 70 i 13044 Err codemadness.org 70 i 13045 Err codemadness.org 70 i 13046 Err codemadness.org 70 i 13047 Err codemadness.org 70 i 13048 Err codemadness.org 70 i 13049 Err codemadness.org 70 i 13051 Err codemadness.org 70 i 13052 Err codemadness.org 70 i 13053 Err codemadness.org 70 i 13054 Err codemadness.org 70 i 13055 Err codemadness.org 70 i 13056 Err codemadness.org 70 i 13058 Err codemadness.org 70 i 13059 Err codemadness.org 70 i 13060 Err codemadness.org 70 i 13061 Err codemadness.org 70 i 13062 Err codemadness.org 70 i 13063 Err codemadness.org 70 i 13066 Err codemadness.org 70 i 13067 Err codemadness.org 70 i 13068

Err codemadness.org 70 i 13029 Err codemadness.org 70 i 13030 [MDEV-27079] When creating a table, the abnormal default domain will cause the service to hang Err codemadness.org 70 i 13031 Err codemadness.org 70 i 13032 Created: 2021-11-18 Updated: 2021-11-19 Err codemadness.org 70 i 13033 Err codemadness.org 70 i 13034 Err codemadness.org 70 i 13035 Err codemadness.org 70 i 13036
Status:	Open
Project:	MariaDB Server
Component/s:	Err codemadness.org 70 i 13050 Server
Affects Version/s:	Err codemadness.org 70 i 13057 10.3.32, 10.4.20, 10.4.21, 10.4.22, 10.5.11, 10.5.12, 10.5.13, 10.6.3, 10.6.4, 10.6.5, 10.7.0, 10.7.1
Fix Version/s:	Err codemadness.org 70 i 13064 None Err codemadness.org 70 i 13065

Err codemadness.org 70 i 13069 Err codemadness.org 70 i 13070

Err codemadness.org 70 i 13071 Err codemadness.org 70 i 13072 Err codemadness.org 70 i 13073 Err codemadness.org 70 i 13076 Err codemadness.org 70 i 13079 Err codemadness.org 70 i 13080 Err codemadness.org 70 i 13083 Err codemadness.org 70 i 13086 Err codemadness.org 70 i 13087 Err codemadness.org 70 i 13088 Err codemadness.org 70 i 13091 Err codemadness.org 70 i 13094 Err codemadness.org 70 i 13095 Err codemadness.org 70 i 13098 Err codemadness.org 70 i 13101 Err codemadness.org 70 i 13102 Err codemadness.org 70 i 13103 Err codemadness.org 70 i 13106 Err codemadness.org 70 i 13109 Err codemadness.org 70 i 13112 Err codemadness.org 70 i 13115 Err codemadness.org 70 i 13116 Err codemadness.org 70 i 13117 Err codemadness.org 70 i 13118 Err codemadness.org 70 i 13119 Err codemadness.org 70 i 13122 Err codemadness.org 70 i 13124 Err codemadness.org 70 i 13125 Err codemadness.org 70 i 13126 Err codemadness.org 70 i 13127 Err codemadness.org 70 i 13128 Err codemadness.org 70 i 13129 Err codemadness.org 70 i 13130 Err codemadness.org 70 i 13131 Err codemadness.org 70 i 13132 Err codemadness.org 70 i 13135 Err codemadness.org 70 i 13141 Err codemadness.org 70 i 13142

Err codemadness.org 70 i 13074 Type: Err codemadness.org 70 i 13075

Err codemadness.org 70 i 13077 Bug Err codemadness.org 70 i 13078

Err codemadness.org 70 i 13081 Priority: Err codemadness.org 70 i 13082

Err codemadness.org 70 i 13084 Critical Err codemadness.org 70 i 13085

Err codemadness.org 70 i 13089 Reporter: Err codemadness.org 70 i 13090

Err codemadness.org 70 i 13092 willcao Err codemadness.org 70 i 13093

Err codemadness.org 70 i 13096 Assignee: Err codemadness.org 70 i 13097

Err codemadness.org 70 i 13099 Unassigned Err codemadness.org 70 i 13100

Err codemadness.org 70 i 13104 Resolution: Err codemadness.org 70 i 13105

Err codemadness.org 70 i 13107 Unresolved Err codemadness.org 70 i 13108

Err codemadness.org 70 i 13110 Votes: Err codemadness.org 70 i 13111

Err codemadness.org 70 i 13113 0 Err codemadness.org 70 i 13114

Err codemadness.org 70 i 13120 Labels: Err codemadness.org 70 i 13121

Err codemadness.org 70 i 13123 crash, need_feedback

Err codemadness.org 70 i 13133 Environment: Err codemadness.org 70 i 13134

Err codemadness.org 70 i 13136

x86 server

Err codemadness.org 70 i 13137 Err codemadness.org 70 i 13138

MariaDB [test]> create table tb6 (col2 date default (col1 mod 68321183.000000), col1 datetime null);

Err codemadness.org 70 i 13139 ERROR 2013 (HY000): Lost connection to MySQL server during query

Err codemadness.org 70 i 13140

Err codemadness.org 70 i 13143 Err codemadness.org 70 i 13144 Err codemadness.org 70 i 13145 Err codemadness.org 70 i 13146

Err codemadness.org 70 i 13147 Err codemadness.org 70 i 13148 Err codemadness.org 70 i 13149 Err codemadness.org 70 i 13150 Err codemadness.org 70 i 13151 Err codemadness.org 70 i 13152 Err codemadness.org 70 i 13153 Err codemadness.org 70 i 13156 Err codemadness.org 70 i 13180 Err codemadness.org 70 i 13181 Err codemadness.org 70 i 13182 Err codemadness.org 70 i 13183 Err codemadness.org 70 i 13184 Err codemadness.org 70 i 13185

Err codemadness.org 70 i 13154 Issue Links: Err codemadness.org 70 i 13155

Err codemadness.org 70 i 13157 Err codemadness.org 70 i 13158 Err codemadness.org 70 i 13159 Err codemadness.org 70 i 13162 Err codemadness.org 70 i 13163 Err codemadness.org 70 i 13164 Err codemadness.org 70 i 13167 Err codemadness.org 70 i 13171 Err codemadness.org 70 i 13174 Err codemadness.org 70 i 13177 Err codemadness.org 70 i 13178

Err codemadness.org 70 i 13160 Relates Err codemadness.org 70 i 13161
Err codemadness.org 70 i 13165 relates to Err codemadness.org 70 i 13166	Err codemadness.org 70 i 13168 Err codemadness.org 70 i 13169 MDEV-25012 Err codemadness.org 70 i 13170	Err codemadness.org 70 i 13172 Server crash in find_field_in_tables,... Err codemadness.org 70 i 13173	Err codemadness.org 70 i 13175 Confirmed Err codemadness.org 70 i 13176

Err codemadness.org 70 i 13179

Err codemadness.org 70 i 13186 Err codemadness.org 70 i 13187

Err codemadness.org 70 i 13188 Err codemadness.org 70 i 13189 Err codemadness.org 70 i 13190 Err codemadness.org 70 i 13191 Err codemadness.org 70 i 13194 Err codemadness.org 70 i 13195 Err codemadness.org 70 i 13196

Err codemadness.org 70 i 13192 Description Err codemadness.org 70 i 13193

Err codemadness.org 70 i 13197 Err codemadness.org 70 i 13198 Err codemadness.org 70 i 13199 Err codemadness.org 70 i 13200 Err codemadness.org 70 i 13391 Err codemadness.org 70 i 13392

Err codemadness.org 70 i 13201

Err codemadness.org 70 i 13202

Err codemadness.org 70 i 13203 Err codemadness.org 70 i 13204 Err codemadness.org 70 i 13205 Err codemadness.org 70 i 13206 Err codemadness.org 70 i 13209 Err codemadness.org 70 i 13210 Err codemadness.org 70 i 13211 Err codemadness.org 70 i 13215 Err codemadness.org 70 i 13216 Err codemadness.org 70 i 13217

Err codemadness.org 70 i 13207

 MariaDB [test]> create table tb6 (col2 date default (col1 mod 68321183.000000), col1 datetime null);

Err codemadness.org 70 i 13208

Err codemadness.org 70 i 13212

ERROR 2013 (HY000): Lost connection to MySQL server during query 	Err	codemadness.org	70
i 13213

Err codemadness.org 70 i 13214

Err codemadness.org 70 i 13218

Err codemadness.org 70 i 13219

Err codemadness.org 70 i 13220

Err codemadness.org 70 i 13221

Err codemadness.org 70 i 13222 Err codemadness.org 70 i 13223 Err codemadness.org 70 i 13224 Err codemadness.org 70 i 13225 Err codemadness.org 70 i 13228 Err codemadness.org 70 i 13229 Err codemadness.org 70 i 13230 Err codemadness.org 70 i 13233 Err codemadness.org 70 i 13234 Err codemadness.org 70 i 13235 Err codemadness.org 70 i 13238 Err codemadness.org 70 i 13239 Err codemadness.org 70 i 13240 Err codemadness.org 70 i 13243 Err codemadness.org 70 i 13244 Err codemadness.org 70 i 13245 Err codemadness.org 70 i 13248 Err codemadness.org 70 i 13249 Err codemadness.org 70 i 13250 Err codemadness.org 70 i 13253 Err codemadness.org 70 i 13254 Err codemadness.org 70 i 13255 Err codemadness.org 70 i 13258 Err codemadness.org 70 i 13259 Err codemadness.org 70 i 13260 Err codemadness.org 70 i 13263 Err codemadness.org 70 i 13264 Err codemadness.org 70 i 13265 Err codemadness.org 70 i 13268 Err codemadness.org 70 i 13269 Err codemadness.org 70 i 13270 Err codemadness.org 70 i 13273 Err codemadness.org 70 i 13274 Err codemadness.org 70 i 13275 Err codemadness.org 70 i 13278 Err codemadness.org 70 i 13279 Err codemadness.org 70 i 13280 Err codemadness.org 70 i 13283 Err codemadness.org 70 i 13284 Err codemadness.org 70 i 13285 Err codemadness.org 70 i 13288 Err codemadness.org 70 i 13289 Err codemadness.org 70 i 13290 Err codemadness.org 70 i 13293 Err codemadness.org 70 i 13294 Err codemadness.org 70 i 13295 Err codemadness.org 70 i 13298 Err codemadness.org 70 i 13299 Err codemadness.org 70 i 13300 Err codemadness.org 70 i 13303 Err codemadness.org 70 i 13304 Err codemadness.org 70 i 13305 Err codemadness.org 70 i 13308 Err codemadness.org 70 i 13309 Err codemadness.org 70 i 13310 Err codemadness.org 70 i 13313 Err codemadness.org 70 i 13314 Err codemadness.org 70 i 13315 Err codemadness.org 70 i 13318 Err codemadness.org 70 i 13319 Err codemadness.org 70 i 13320 Err codemadness.org 70 i 13323 Err codemadness.org 70 i 13324 Err codemadness.org 70 i 13325 Err codemadness.org 70 i 13328 Err codemadness.org 70 i 13329 Err codemadness.org 70 i 13330 Err codemadness.org 70 i 13333 Err codemadness.org 70 i 13334 Err codemadness.org 70 i 13335 Err codemadness.org 70 i 13338 Err codemadness.org 70 i 13339 Err codemadness.org 70 i 13340 Err codemadness.org 70 i 13343 Err codemadness.org 70 i 13344 Err codemadness.org 70 i 13345 Err codemadness.org 70 i 13348 Err codemadness.org 70 i 13349 Err codemadness.org 70 i 13350 Err codemadness.org 70 i 13353 Err codemadness.org 70 i 13354 Err codemadness.org 70 i 13355 Err codemadness.org 70 i 13358 Err codemadness.org 70 i 13359 Err codemadness.org 70 i 13360 Err codemadness.org 70 i 13363 Err codemadness.org 70 i 13364 Err codemadness.org 70 i 13365 Err codemadness.org 70 i 13368 Err codemadness.org 70 i 13369 Err codemadness.org 70 i 13370 Err codemadness.org 70 i 13373 Err codemadness.org 70 i 13374 Err codemadness.org 70 i 13375 Err codemadness.org 70 i 13378 Err codemadness.org 70 i 13379 Err codemadness.org 70 i 13380 Err codemadness.org 70 i 13384 Err codemadness.org 70 i 13385 Err codemadness.org 70 i 13386

Err codemadness.org 70 i 13226

Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".

Err codemadness.org 70 i 13227

Err codemadness.org 70 i 13231

Core was generated by `/usr/sbin/mysqld'.

Err codemadness.org 70 i 13232

Err codemadness.org 70 i 13236

Program terminated with signal SIGSEGV, Segmentation fault.

Err codemadness.org 70 i 13237

Err codemadness.org 70 i 13241

#0  __pthread_kill (threadid=<optimized out>, signo=signo@entry=11) at ../sysdeps/unix/sysv/linux/pthread_kill.c:56

Err codemadness.org 70 i 13242

Err codemadness.org 70 i 13246

56      ../sysdeps/unix/sysv/linux/pthread_kill.c: 没有那个文件或目录.

Err codemadness.org 70 i 13247

Err codemadness.org 70 i 13251

[Current thread is 1 (Thread 0x7fbfdd3fb700 (LWP 8791))]

Err codemadness.org 70 i 13252

Err codemadness.org 70 i 13256

(gdb) bt

Err codemadness.org 70 i 13257

Err codemadness.org 70 i 13261

#0  __pthread_kill (threadid=<optimized out>, signo=signo@entry=11) at ../sysdeps/unix/sysv/linux/pthread_kill.c:56

Err codemadness.org 70 i 13262

Err codemadness.org 70 i 13266

#1  0x00005651f913d30a in my_write_core (sig=sig@entry=11) at /home/uos/fsdownload/mariadb-10.3/mysys/stacktrace.c:481

Err codemadness.org 70 i 13267

Err codemadness.org 70 i 13271

#2  0x00005651f8ccb438 in handle_fatal_signal (sig=11) at /home/uos/fsdownload/mariadb-10.3/sql/signal_handler.cc:343

Err codemadness.org 70 i 13272

Err codemadness.org 70 i 13276

#3  <signal handler called>

Err codemadness.org 70 i 13277

Err codemadness.org 70 i 13281

#4  0x00005651f8ab49bd in find_field_in_table (thd=thd@entry=0x7fbf78000c08, table=0x0, name=name@entry=0x7fbf78011f98 "col1",

Err codemadness.org 70 i 13282

Err codemadness.org 70 i 13286

    length=length@entry=4, allow_rowid=true, cached_field_index_ptr=cached_field_index_ptr@entry=0x7fbf7801207c)

Err codemadness.org 70 i 13287

Err codemadness.org 70 i 13291

    at /home/uos/fsdownload/mariadb-10.3/sql/sql_base.cc:5785

Err codemadness.org 70 i 13292

Err codemadness.org 70 i 13296

#5  0x00005651f8ab50c2 in find_field_in_table_ref (thd=thd@entry=0x7fbf78000c08, table_list=table_list@entry=0x7fbf78011828,

Err codemadness.org 70 i 13297

Err codemadness.org 70 i 13301

    name=name@entry=0x7fbf78011f98 "col1", length=length@entry=4, item_name=0x7fbf78011f98 "col1", db_name=db_name@entry=0x0, table_name=0x0,

Err codemadness.org 70 i 13302

Err codemadness.org 70 i 13306

    ref=0x7fbf78012220, check_privileges=true, allow_rowid=true, cached_field_index_ptr=0x7fbf7801207c, register_tree_change=true,

Err codemadness.org 70 i 13307

Err codemadness.org 70 i 13311

    actual_table=0x7fbfdd3f5728) at /home/uos/fsdownload/mariadb-10.3/sql/sql_base.cc:5949

Err codemadness.org 70 i 13312

Err codemadness.org 70 i 13316

#6  0x00005651f8ab5656 in find_field_in_tables (thd=thd@entry=0x7fbf78000c08, item=item@entry=0x7fbf78011fa8, first_table=<optimized out>,

Err codemadness.org 70 i 13317

Err codemadness.org 70 i 13321

    last_table=0x0, ref=ref@entry=0x7fbf78012220, report_error=IGNORE_EXCEPT_NON_UNIQUE, check_privileges=true, register_tree_change=true)

Err codemadness.org 70 i 13322

Err codemadness.org 70 i 13326

    at /home/uos/fsdownload/mariadb-10.3/sql/sql_base.cc:6242

Err codemadness.org 70 i 13327

Err codemadness.org 70 i 13331

#7  0x00005651f8ceb770 in Item_field::fix_fields (this=0x7fbf78011fa8, thd=0x7fbf78000c08, reference=0x7fbf78012220)

Err codemadness.org 70 i 13332

Err codemadness.org 70 i 13336

    at /home/uos/fsdownload/mariadb-10.3/sql/item.cc:6082

Err codemadness.org 70 i 13337

Err codemadness.org 70 i 13341

#8  0x00005651f8d20c7d in Item::fix_fields_if_needed (ref=0x7fbf78012220, thd=0x7fbf78000c08, this=<optimized out>)

Err codemadness.org 70 i 13342

Err codemadness.org 70 i 13346

    at /home/uos/fsdownload/mariadb-10.3/sql/item.h:821

Err codemadness.org 70 i 13347

Err codemadness.org 70 i 13351

#9  Item::fix_fields_if_needed (ref=0x7fbf78012220, thd=0x7fbf78000c08, this=<optimized out>)

Err codemadness.org 70 i 13352

Err codemadness.org 70 i 13356

    at /home/uos/fsdownload/mariadb-10.3/sql/item.h:821

Err codemadness.org 70 i 13357

Err codemadness.org 70 i 13361

#10 Item_func::fix_fields (ref=<optimized out>, thd=0x7fbf78000c08, this=0x7fbf78012190)

Err codemadness.org 70 i 13362

Err codemadness.org 70 i 13366

    at /home/uos/fsdownload/mariadb-10.3/sql/item_func.cc:365

Err codemadness.org 70 i 13367

Err codemadness.org 70 i 13371

#11 Item_func::fix_fields (this=0x7fbf78012190, thd=0x7fbf78000c08, ref=<optimized out>)

Err codemadness.org 70 i 13372

Err codemadness.org 70 i 13376

    at /home/uos/fsdownload/mariadb-10.3/sql/item_func.cc:332

Err codemadness.org 70 i 13377

Err codemadness.org 70 i 13381

#12 0x00005651f8bc27fa in Item::fix_fields_if_needed (ref=0x7fbfdd3f5d18, thd=0x7fbf78000c08, this=0x7fbf78012190)	Err	codemadness.org	70
i 13382

Err codemadness.org 70 i 13383

Err codemadness.org 70 i 13387

Err codemadness.org 70 i 13388

Err codemadness.org 70 i 13389

Err codemadness.org 70 i 13390

Err codemadness.org 70 i 13393 Err codemadness.org 70 i 13394

Err codemadness.org 70 i 13395 Err codemadness.org 70 i 13396 Err codemadness.org 70 i 13397 Err codemadness.org 70 i 13398 Err codemadness.org 70 i 13401 Err codemadness.org 70 i 13402 Err codemadness.org 70 i 13403

Err codemadness.org 70 i 13399 Comments Err codemadness.org 70 i 13400

Err codemadness.org 70 i 13404 Err codemadness.org 70 i 13405 Err codemadness.org 70 i 13406 Err codemadness.org 70 i 13417 Err codemadness.org 70 i 13659 Err codemadness.org 70 i 13670 Err codemadness.org 70 i 13734

Err codemadness.org 70 i 13407 Comment by Err codemadness.org 70 i 13408 willcao Err codemadness.org 70 i 13409 Err codemadness.org 70 i 13410 [ Err codemadness.org 70 i 13411 2021-11-18 Err codemadness.org 70 i 13412 Err codemadness.org 70 i 13413 ] Err codemadness.org 70 i 13414 Err codemadness.org 70 i 13415 Err codemadness.org 70 i 13416

Err codemadness.org 70 i 13418

Submit the following patch to solve the problem

Err codemadness.org 70 i 13419

Err codemadness.org 70 i 13420

Err codemadness.org 70 i 13421 Err codemadness.org 70 i 13422 Err codemadness.org 70 i 13423 Err codemadness.org 70 i 13424 Err codemadness.org 70 i 13427 Err codemadness.org 70 i 13428 Err codemadness.org 70 i 13429 Err codemadness.org 70 i 13432 Err codemadness.org 70 i 13433 Err codemadness.org 70 i 13434 Err codemadness.org 70 i 13437 Err codemadness.org 70 i 13438 Err codemadness.org 70 i 13439 Err codemadness.org 70 i 13442 Err codemadness.org 70 i 13443 Err codemadness.org 70 i 13444 Err codemadness.org 70 i 13447 Err codemadness.org 70 i 13448 Err codemadness.org 70 i 13449 Err codemadness.org 70 i 13452 Err codemadness.org 70 i 13453 Err codemadness.org 70 i 13454 Err codemadness.org 70 i 13457 Err codemadness.org 70 i 13458 Err codemadness.org 70 i 13459 Err codemadness.org 70 i 13462 Err codemadness.org 70 i 13463 Err codemadness.org 70 i 13464 Err codemadness.org 70 i 13467 Err codemadness.org 70 i 13468 Err codemadness.org 70 i 13469 Err codemadness.org 70 i 13472 Err codemadness.org 70 i 13473 Err codemadness.org 70 i 13474 Err codemadness.org 70 i 13477 Err codemadness.org 70 i 13478 Err codemadness.org 70 i 13479 Err codemadness.org 70 i 13482 Err codemadness.org 70 i 13483 Err codemadness.org 70 i 13484 Err codemadness.org 70 i 13487 Err codemadness.org 70 i 13488 Err codemadness.org 70 i 13489 Err codemadness.org 70 i 13492 Err codemadness.org 70 i 13493 Err codemadness.org 70 i 13494 Err codemadness.org 70 i 13497 Err codemadness.org 70 i 13498 Err codemadness.org 70 i 13499 Err codemadness.org 70 i 13502 Err codemadness.org 70 i 13503 Err codemadness.org 70 i 13504 Err codemadness.org 70 i 13507 Err codemadness.org 70 i 13508 Err codemadness.org 70 i 13509 Err codemadness.org 70 i 13512 Err codemadness.org 70 i 13513 Err codemadness.org 70 i 13514 Err codemadness.org 70 i 13517 Err codemadness.org 70 i 13518 Err codemadness.org 70 i 13519 Err codemadness.org 70 i 13522 Err codemadness.org 70 i 13523 Err codemadness.org 70 i 13524 Err codemadness.org 70 i 13527 Err codemadness.org 70 i 13528 Err codemadness.org 70 i 13529 Err codemadness.org 70 i 13532 Err codemadness.org 70 i 13533 Err codemadness.org 70 i 13534 Err codemadness.org 70 i 13537 Err codemadness.org 70 i 13538 Err codemadness.org 70 i 13539 Err codemadness.org 70 i 13542 Err codemadness.org 70 i 13543 Err codemadness.org 70 i 13544 Err codemadness.org 70 i 13547 Err codemadness.org 70 i 13548 Err codemadness.org 70 i 13549 Err codemadness.org 70 i 13552 Err codemadness.org 70 i 13553 Err codemadness.org 70 i 13554 Err codemadness.org 70 i 13557 Err codemadness.org 70 i 13558 Err codemadness.org 70 i 13559 Err codemadness.org 70 i 13562 Err codemadness.org 70 i 13563 Err codemadness.org 70 i 13564 Err codemadness.org 70 i 13567 Err codemadness.org 70 i 13568 Err codemadness.org 70 i 13569 Err codemadness.org 70 i 13572 Err codemadness.org 70 i 13573 Err codemadness.org 70 i 13574 Err codemadness.org 70 i 13577 Err codemadness.org 70 i 13578 Err codemadness.org 70 i 13579 Err codemadness.org 70 i 13582 Err codemadness.org 70 i 13583 Err codemadness.org 70 i 13584 Err codemadness.org 70 i 13587 Err codemadness.org 70 i 13588 Err codemadness.org 70 i 13589 Err codemadness.org 70 i 13592 Err codemadness.org 70 i 13593 Err codemadness.org 70 i 13594 Err codemadness.org 70 i 13597 Err codemadness.org 70 i 13598 Err codemadness.org 70 i 13599 Err codemadness.org 70 i 13602 Err codemadness.org 70 i 13603 Err codemadness.org 70 i 13604 Err codemadness.org 70 i 13607 Err codemadness.org 70 i 13608 Err codemadness.org 70 i 13609 Err codemadness.org 70 i 13612 Err codemadness.org 70 i 13613 Err codemadness.org 70 i 13614 Err codemadness.org 70 i 13617 Err codemadness.org 70 i 13618 Err codemadness.org 70 i 13619 Err codemadness.org 70 i 13622 Err codemadness.org 70 i 13623 Err codemadness.org 70 i 13624 Err codemadness.org 70 i 13627 Err codemadness.org 70 i 13628 Err codemadness.org 70 i 13629 Err codemadness.org 70 i 13632 Err codemadness.org 70 i 13633 Err codemadness.org 70 i 13634 Err codemadness.org 70 i 13637 Err codemadness.org 70 i 13638 Err codemadness.org 70 i 13639 Err codemadness.org 70 i 13642 Err codemadness.org 70 i 13643 Err codemadness.org 70 i 13644 Err codemadness.org 70 i 13647 Err codemadness.org 70 i 13648 Err codemadness.org 70 i 13649 Err codemadness.org 70 i 13653 Err codemadness.org 70 i 13654 Err codemadness.org 70 i 13655

Err codemadness.org 70 i 13425

diff --git a/sql/sql_base.cc b/sql/sql_base.cc

Err codemadness.org 70 i 13426

Err codemadness.org 70 i 13430

index 0c72b4c1..5588dfac 100644

Err codemadness.org 70 i 13431

Err codemadness.org 70 i 13435

--- a/sql/sql_base.cc

Err codemadness.org 70 i 13436

Err codemadness.org 70 i 13440

+++ b/sql/sql_base.cc

Err codemadness.org 70 i 13441

Err codemadness.org 70 i 13445

@@ -5781,8 +5781,13 @@ Field *

Err codemadness.org 70 i 13446

Err codemadness.org 70 i 13450

 find_field_in_table(THD *thd, TABLE *table, const char *name, size_t length,

Err codemadness.org 70 i 13451

Err codemadness.org 70 i 13455

                     bool allow_rowid, uint *cached_field_index_ptr)

Err codemadness.org 70 i 13456

Err codemadness.org 70 i 13460

Err codemadness.org 70 i 13461

Err codemadness.org 70 i 13465

-  Field *field;

Err codemadness.org 70 i 13466

Err codemadness.org 70 i 13470

-  uint cached_field_index= *cached_field_index_ptr;

Err codemadness.org 70 i 13471

Err codemadness.org 70 i 13475

+  Field *field = nullptr;

Err codemadness.org 70 i 13476

Err codemadness.org 70 i 13480

+  uint cached_field_index=0;

Err codemadness.org 70 i 13481

Err codemadness.org 70 i 13485

+  if(table == nullptr || table->s == nullptr)

Err codemadness.org 70 i 13486

Err codemadness.org 70 i 13490

+  {

Err codemadness.org 70 i 13491

Err codemadness.org 70 i 13495

+    DBUG_RETURN((Field*)0);

Err codemadness.org 70 i 13496

Err codemadness.org 70 i 13500

+  }

Err codemadness.org 70 i 13501

Err codemadness.org 70 i 13505

+  cached_field_index = *cached_field_index_ptr;

Err codemadness.org 70 i 13506

Err codemadness.org 70 i 13510

   DBUG_ENTER("find_field_in_table");

Err codemadness.org 70 i 13511

Err codemadness.org 70 i 13515

   DBUG_PRINT("enter", ("table: '%s', field name: '%s'", table->alias.c_ptr(),

Err codemadness.org 70 i 13516

Err codemadness.org 70 i 13520

                        name));

Err codemadness.org 70 i 13521

Err codemadness.org 70 i 13525

diff --git a/sql/sql_select.cc b/sql/sql_select.cc

Err codemadness.org 70 i 13526

Err codemadness.org 70 i 13530

index ae26458d..20956495 100644

Err codemadness.org 70 i 13531

Err codemadness.org 70 i 13535

--- a/sql/sql_select.cc

Err codemadness.org 70 i 13536

Err codemadness.org 70 i 13540

+++ b/sql/sql_select.cc

Err codemadness.org 70 i 13541

Err codemadness.org 70 i 13545

@@ -9314,6 +9314,10 @@ prev_record_reads(const POSITION *positions, uint idx, table_map found_ref)

Err codemadness.org 70 i 13546

Err codemadness.org 70 i 13550

 static JOIN_TAB *next_breadth_first_tab(JOIN_TAB *first_top_tab,

Err codemadness.org 70 i 13551

Err codemadness.org 70 i 13555

                                         uint n_top_tabs_count, JOIN_TAB *tab)

Err codemadness.org 70 i 13556

Err codemadness.org 70 i 13560

Err codemadness.org 70 i 13561

Err codemadness.org 70 i 13565

+  if(tab == NULL || tab->join == NULL)

Err codemadness.org 70 i 13566

Err codemadness.org 70 i 13570

+  {

Err codemadness.org 70 i 13571

Err codemadness.org 70 i 13575

+    return NULL;

Err codemadness.org 70 i 13576

Err codemadness.org 70 i 13580

+  }

Err codemadness.org 70 i 13581

Err codemadness.org 70 i 13585

   n_top_tabs_count += tab->join->aggr_tables;

Err codemadness.org 70 i 13586

Err codemadness.org 70 i 13590

   if (!tab->bush_root_tab)

Err codemadness.org 70 i 13591

Err codemadness.org 70 i 13595

Err codemadness.org 70 i 13596

Err codemadness.org 70 i 13600

@@ -18018,6 +18022,10 @@ create_tmp_table(THD *thd, TMP_TABLE_PARAM *param, List<Item> &fields,

Err codemadness.org 70 i 13601

Err codemadness.org 70 i 13605

     for (; cur_group ; cur_group= cur_group->next, key_part_info++)

Err codemadness.org 70 i 13606

Err codemadness.org 70 i 13610

Err codemadness.org 70 i 13611

Err codemadness.org 70 i 13615

       Field *field=(*cur_group->item)->get_tmp_table_field();

Err codemadness.org 70 i 13616

Err codemadness.org 70 i 13620

+      if(field == NULL)

Err codemadness.org 70 i 13621

Err codemadness.org 70 i 13625

+      {

Err codemadness.org 70 i 13626

Err codemadness.org 70 i 13630

+        goto err;

Err codemadness.org 70 i 13631

Err codemadness.org 70 i 13635

+      }

Err codemadness.org 70 i 13636

Err codemadness.org 70 i 13640

       DBUG_ASSERT(field->table == table);

Err codemadness.org 70 i 13641

Err codemadness.org 70 i 13645

       bool maybe_null=(*cur_group->item)->maybe_null;

Err codemadness.org 70 i 13646

Err codemadness.org 70 i 13650

       key_part_info->null_bit=0;	Err	codemadness.org	70
i 13651

Err codemadness.org 70 i 13652

Err codemadness.org 70 i 13656

Err codemadness.org 70 i 13657

Err codemadness.org 70 i 13658

Err codemadness.org 70 i 13660 Comment by Err codemadness.org 70 i 13661 Alice Sherepa Err codemadness.org 70 i 13662 Err codemadness.org 70 i 13663 [ Err codemadness.org 70 i 13664 2021-11-18 Err codemadness.org 70 i 13665 Err codemadness.org 70 i 13666 ] Err codemadness.org 70 i 13667 Err codemadness.org 70 i 13668 Err codemadness.org 70 i 13669

Err codemadness.org 70 i 13671

I could not reproduce it:

Err codemadness.org 70 i 13672

Err codemadness.org 70 i 13673

Err codemadness.org 70 i 13674 Err codemadness.org 70 i 13675 Err codemadness.org 70 i 13676 Err codemadness.org 70 i 13677 Err codemadness.org 70 i 13680 Err codemadness.org 70 i 13681 Err codemadness.org 70 i 13682 Err codemadness.org 70 i 13685 Err codemadness.org 70 i 13686 Err codemadness.org 70 i 13687 Err codemadness.org 70 i 13690 Err codemadness.org 70 i 13691 Err codemadness.org 70 i 13692 Err codemadness.org 70 i 13695 Err codemadness.org 70 i 13696 Err codemadness.org 70 i 13697 Err codemadness.org 70 i 13700 Err codemadness.org 70 i 13701 Err codemadness.org 70 i 13702 Err codemadness.org 70 i 13705 Err codemadness.org 70 i 13706 Err codemadness.org 70 i 13707 Err codemadness.org 70 i 13710 Err codemadness.org 70 i 13711 Err codemadness.org 70 i 13712 Err codemadness.org 70 i 13715 Err codemadness.org 70 i 13716 Err codemadness.org 70 i 13717 Err codemadness.org 70 i 13720 Err codemadness.org 70 i 13721 Err codemadness.org 70 i 13722 Err codemadness.org 70 i 13726 Err codemadness.org 70 i 13727 Err codemadness.org 70 i 13728

Err codemadness.org 70 i 13678

MariaDB [test]> select version();

Err codemadness.org 70 i 13679

Err codemadness.org 70 i 13683

+-----------------+

Err codemadness.org 70 i 13684

Err codemadness.org 70 i 13688

| version()       |

Err codemadness.org 70 i 13689

Err codemadness.org 70 i 13693

+-----------------+

Err codemadness.org 70 i 13694

Err codemadness.org 70 i 13698

| 10.3.32-MariaDB |

Err codemadness.org 70 i 13699

Err codemadness.org 70 i 13703

+-----------------+

Err codemadness.org 70 i 13704

Err codemadness.org 70 i 13708

1 row in set (0.000 sec)

Err codemadness.org 70 i 13709

Err codemadness.org 70 i 13713

Err codemadness.org 70 i 13714

Err codemadness.org 70 i 13718

MariaDB [test]> create table tb6 (col2 date default (col1 mod 68321183.000000), col1 datetime null);

Err codemadness.org 70 i 13719

Err codemadness.org 70 i 13723

Query OK, 0 rows affected (0.010 sec)	Err	codemadness.org	70
i 13724

Err codemadness.org 70 i 13725

Err codemadness.org 70 i 13729

Err codemadness.org 70 i 13730

Err codemadness.org 70 i 13731

could you please add your .cnf file?

Err codemadness.org 70 i 13732 Also, I suspect it is similar to MDEV-25012

Err codemadness.org 70 i 13733

Err codemadness.org 70 i 13735

[MDEV-5271] Support engine-defined attributes per partition

Sergei Golubchik — Fri, 19 Nov 2021 07:39:29 +0000

Err codemadness.org 70 i 13811 Err codemadness.org 70 i 13812 Err codemadness.org 70 i 13821 Err codemadness.org 70 i 13822 Err codemadness.org 70 i 13823 Err codemadness.org 70 i 13824 Err codemadness.org 70 i 13825 Err codemadness.org 70 i 13826 Err codemadness.org 70 i 13827 Err codemadness.org 70 i 13828 Err codemadness.org 70 i 13829 Err codemadness.org 70 i 13830 Err codemadness.org 70 i 13831 Err codemadness.org 70 i 13832 Err codemadness.org 70 i 13833 Err codemadness.org 70 i 13835 Err codemadness.org 70 i 13836 Err codemadness.org 70 i 13837 Err codemadness.org 70 i 13838 Err codemadness.org 70 i 13839 Err codemadness.org 70 i 13840 Err codemadness.org 70 i 13841 Err codemadness.org 70 i 13842 Err codemadness.org 70 i 13844 Err codemadness.org 70 i 13845 Err codemadness.org 70 i 13846

Err codemadness.org 70 i 13813 Err codemadness.org 70 i 13814 [MDEV-5271] Support engine-defined attributes per partition Err codemadness.org 70 i 13815 Err codemadness.org 70 i 13816 Created: 2013-11-10 Updated: 2021-11-19 Err codemadness.org 70 i 13817 Err codemadness.org 70 i 13818 Err codemadness.org 70 i 13819 Err codemadness.org 70 i 13820
Status:	In Review
Project:	MariaDB Server
Component/s:	Err codemadness.org 70 i 13834 Partitioning
Fix Version/s:	Err codemadness.org 70 i 13843 10.8

Err codemadness.org 70 i 13847 Err codemadness.org 70 i 13848

Err codemadness.org 70 i 13849 Err codemadness.org 70 i 13850 Err codemadness.org 70 i 13851 Err codemadness.org 70 i 13854 Err codemadness.org 70 i 13857 Err codemadness.org 70 i 13858 Err codemadness.org 70 i 13861 Err codemadness.org 70 i 13864 Err codemadness.org 70 i 13865 Err codemadness.org 70 i 13866 Err codemadness.org 70 i 13869 Err codemadness.org 70 i 13872 Err codemadness.org 70 i 13873 Err codemadness.org 70 i 13876 Err codemadness.org 70 i 13879 Err codemadness.org 70 i 13880 Err codemadness.org 70 i 13881 Err codemadness.org 70 i 13884 Err codemadness.org 70 i 13887 Err codemadness.org 70 i 13890 Err codemadness.org 70 i 13893 Err codemadness.org 70 i 13894 Err codemadness.org 70 i 13895 Err codemadness.org 70 i 13896 Err codemadness.org 70 i 13897 Err codemadness.org 70 i 13900 Err codemadness.org 70 i 13903 Err codemadness.org 70 i 13904 Err codemadness.org 70 i 13905 Err codemadness.org 70 i 13906 Err codemadness.org 70 i 13907 Err codemadness.org 70 i 13908 Err codemadness.org 70 i 13909

Err codemadness.org 70 i 13852 Type: Err codemadness.org 70 i 13853

Err codemadness.org 70 i 13855 Task Err codemadness.org 70 i 13856

Err codemadness.org 70 i 13859 Priority: Err codemadness.org 70 i 13860

Err codemadness.org 70 i 13862 Critical Err codemadness.org 70 i 13863

Err codemadness.org 70 i 13867 Reporter: Err codemadness.org 70 i 13868

Err codemadness.org 70 i 13870 Sergei Golubchik Err codemadness.org 70 i 13871

Err codemadness.org 70 i 13874 Assignee: Err codemadness.org 70 i 13875

Err codemadness.org 70 i 13877 Alexey Botchkov Err codemadness.org 70 i 13878

Err codemadness.org 70 i 13882 Resolution: Err codemadness.org 70 i 13883

Err codemadness.org 70 i 13885 Unresolved Err codemadness.org 70 i 13886

Err codemadness.org 70 i 13888 Votes: Err codemadness.org 70 i 13889

Err codemadness.org 70 i 13891 6 Err codemadness.org 70 i 13892

Err codemadness.org 70 i 13898 Labels: Err codemadness.org 70 i 13899

Err codemadness.org 70 i 13901 None Err codemadness.org 70 i 13902

Err codemadness.org 70 i 13910 Err codemadness.org 70 i 13911 Err codemadness.org 70 i 13912 Err codemadness.org 70 i 13913

Err codemadness.org 70 i 13914 Err codemadness.org 70 i 13915 Err codemadness.org 70 i 13916 Err codemadness.org 70 i 13917 Err codemadness.org 70 i 13918 Err codemadness.org 70 i 13919 Err codemadness.org 70 i 13920 Err codemadness.org 70 i 13923 Err codemadness.org 70 i 14052 Err codemadness.org 70 i 14053 Err codemadness.org 70 i 14054 Err codemadness.org 70 i 14055 Err codemadness.org 70 i 14056 Err codemadness.org 70 i 14057 Err codemadness.org 70 i 14058

Err codemadness.org 70 i 13921 Issue Links: Err codemadness.org 70 i 13922

Err codemadness.org 70 i 13924 Err codemadness.org 70 i 13925 Err codemadness.org 70 i 13926 Err codemadness.org 70 i 13929 Err codemadness.org 70 i 13930 Err codemadness.org 70 i 13931 Err codemadness.org 70 i 13934 Err codemadness.org 70 i 13935 Err codemadness.org 70 i 13936 Err codemadness.org 70 i 13939 Err codemadness.org 70 i 13943 Err codemadness.org 70 i 13946 Err codemadness.org 70 i 13949 Err codemadness.org 70 i 13950 Err codemadness.org 70 i 13951 Err codemadness.org 70 i 13954 Err codemadness.org 70 i 13958 Err codemadness.org 70 i 13961 Err codemadness.org 70 i 13964 Err codemadness.org 70 i 13965 Err codemadness.org 70 i 13966 Err codemadness.org 70 i 13969 Err codemadness.org 70 i 13970 Err codemadness.org 70 i 13971 Err codemadness.org 70 i 13974 Err codemadness.org 70 i 13978 Err codemadness.org 70 i 13981 Err codemadness.org 70 i 13984 Err codemadness.org 70 i 13985 Err codemadness.org 70 i 13986 Err codemadness.org 70 i 13989 Err codemadness.org 70 i 13990 Err codemadness.org 70 i 13991 Err codemadness.org 70 i 13994 Err codemadness.org 70 i 13998 Err codemadness.org 70 i 14001 Err codemadness.org 70 i 14004 Err codemadness.org 70 i 14005 Err codemadness.org 70 i 14006 Err codemadness.org 70 i 14009 Err codemadness.org 70 i 14013 Err codemadness.org 70 i 14016 Err codemadness.org 70 i 14019 Err codemadness.org 70 i 14020 Err codemadness.org 70 i 14021 Err codemadness.org 70 i 14024 Err codemadness.org 70 i 14028 Err codemadness.org 70 i 14031 Err codemadness.org 70 i 14034 Err codemadness.org 70 i 14035 Err codemadness.org 70 i 14036 Err codemadness.org 70 i 14039 Err codemadness.org 70 i 14043 Err codemadness.org 70 i 14046 Err codemadness.org 70 i 14049 Err codemadness.org 70 i 14050

Err codemadness.org 70 i 13927 Blocks Err codemadness.org 70 i 13928
Err codemadness.org 70 i 13932 Duplicate Err codemadness.org 70 i 13933
Err codemadness.org 70 i 13937 duplicates Err codemadness.org 70 i 13938	Err codemadness.org 70 i 13940 Err codemadness.org 70 i 13941 ~~MDEV-8503~~ Err codemadness.org 70 i 13942	Err codemadness.org 70 i 13944 CONNECT STORAGE ENGINE Err codemadness.org 70 i 13945	Err codemadness.org 70 i 13947 Closed Err codemadness.org 70 i 13948
Err codemadness.org 70 i 13952 duplicates Err codemadness.org 70 i 13953	Err codemadness.org 70 i 13955 Err codemadness.org 70 i 13956 ~~MDEV-20635~~ Err codemadness.org 70 i 13957	Err codemadness.org 70 i 13959 Engine specific partition options lik... Err codemadness.org 70 i 13960	Err codemadness.org 70 i 13962 Closed Err codemadness.org 70 i 13963
Err codemadness.org 70 i 13967 PartOf Err codemadness.org 70 i 13968
Err codemadness.org 70 i 13972 is part of Err codemadness.org 70 i 13973	Err codemadness.org 70 i 13975 Err codemadness.org 70 i 13976 MDEV-22168 Err codemadness.org 70 i 13977	Err codemadness.org 70 i 13979 Supporting multiple engines with tabl... Err codemadness.org 70 i 13980	Err codemadness.org 70 i 13982 In Progress Err codemadness.org 70 i 13983
Err codemadness.org 70 i 13987 Relates Err codemadness.org 70 i 13988
Err codemadness.org 70 i 13992 relates to Err codemadness.org 70 i 13993	Err codemadness.org 70 i 13995 Err codemadness.org 70 i 13996 ~~MDEV-6322~~ Err codemadness.org 70 i 13997	Err codemadness.org 70 i 13999 The PARTITION engine can return wrong... Err codemadness.org 70 i 14000	Err codemadness.org 70 i 14002 Closed Err codemadness.org 70 i 14003
Err codemadness.org 70 i 14007 relates to Err codemadness.org 70 i 14008	Err codemadness.org 70 i 14010 Err codemadness.org 70 i 14011 MDEV-3936 Err codemadness.org 70 i 14012	Err codemadness.org 70 i 14014 Storage-engine private data area per ... Err codemadness.org 70 i 14015	Err codemadness.org 70 i 14017 Open Err codemadness.org 70 i 14018
Err codemadness.org 70 i 14022 relates to Err codemadness.org 70 i 14023	Err codemadness.org 70 i 14025 Err codemadness.org 70 i 14026 ~~MDEV-5058~~ Err codemadness.org 70 i 14027	Err codemadness.org 70 i 14029 engine options cannot be set together... Err codemadness.org 70 i 14030	Err codemadness.org 70 i 14032 Closed Err codemadness.org 70 i 14033
Err codemadness.org 70 i 14037 relates to Err codemadness.org 70 i 14038	Err codemadness.org 70 i 14040 Err codemadness.org 70 i 14041 MDEV-22162 Err codemadness.org 70 i 14042	Err codemadness.org 70 i 14044 Make partitions more flexible to use Err codemadness.org 70 i 14045	Err codemadness.org 70 i 14047 Open Err codemadness.org 70 i 14048

Err codemadness.org 70 i 14051

Err codemadness.org 70 i 14059 Err codemadness.org 70 i 14060

Err codemadness.org 70 i 14061 Err codemadness.org 70 i 14062 Err codemadness.org 70 i 14063 Err codemadness.org 70 i 14064 Err codemadness.org 70 i 14067 Err codemadness.org 70 i 14068 Err codemadness.org 70 i 14069

Err codemadness.org 70 i 14065 Description Err codemadness.org 70 i 14066

Err codemadness.org 70 i 14070 Err codemadness.org 70 i 14071 Err codemadness.org 70 i 14072 Err codemadness.org 70 i 14073 Err codemadness.org 70 i 14215 Err codemadness.org 70 i 14216

Err codemadness.org 70 i 14074

Overview

Err codemadness.org 70 i 14075 Err codemadness.org 70 i 14076

MariaDB allows storage engines to define additional attributes per index, field, or table. However, per-table attributes cannot be specified per partition. We should support per-partition attributes for more flexible configurations. Also, this functionality is necessary for other important features (see the issue links below). https://mariadb.com/kb/en/engine-defined-new-tablefieldindex-attributes/

Err codemadness.org 70 i 14077 Err codemadness.org 70 i 14078

Syntax

Err codemadness.org 70 i 14079 Err codemadness.org 70 i 14080

Err codemadness.org 70 i 14081

Err codemadness.org 70 i 14082 Err codemadness.org 70 i 14083 Err codemadness.org 70 i 14084 Err codemadness.org 70 i 14085 Err codemadness.org 70 i 14088 Err codemadness.org 70 i 14089 Err codemadness.org 70 i 14090 Err codemadness.org 70 i 14093 Err codemadness.org 70 i 14094 Err codemadness.org 70 i 14095 Err codemadness.org 70 i 14098 Err codemadness.org 70 i 14099 Err codemadness.org 70 i 14100 Err codemadness.org 70 i 14103 Err codemadness.org 70 i 14104 Err codemadness.org 70 i 14105 Err codemadness.org 70 i 14108 Err codemadness.org 70 i 14109 Err codemadness.org 70 i 14110 Err codemadness.org 70 i 14113 Err codemadness.org 70 i 14114 Err codemadness.org 70 i 14115 Err codemadness.org 70 i 14119 Err codemadness.org 70 i 14120 Err codemadness.org 70 i 14121

Err codemadness.org 70 i 14086

partition_definition:

Err codemadness.org 70 i 14087

Err codemadness.org 70 i 14091

    PARTITION partition_name

Err codemadness.org 70 i 14092

Err codemadness.org 70 i 14096

        [VALUES {LESS THAN {(expr) | MAXVALUE} | IN (value_list)}]

Err codemadness.org 70 i 14097

Err codemadness.org 70 i 14101

        [[STORAGE] ENGINE [=] engine_name]

Err codemadness.org 70 i 14102

Err codemadness.org 70 i 14106

        [engine_defined_options ]

Err codemadness.org 70 i 14107

Err codemadness.org 70 i 14111

...

Err codemadness.org 70 i 14112

Err codemadness.org 70 i 14116

        [(subpartition_definition [, subpartition_definition] ...)]	Err	codemadness.org	70
i 14117

Err codemadness.org 70 i 14118

Err codemadness.org 70 i 14122

Err codemadness.org 70 i 14123

Err codemadness.org 70 i 14124 Err codemadness.org 70 i 14125

https://mariadb.com/kb/en/create-table/#partitions

Err codemadness.org 70 i 14126 Err codemadness.org 70 i 14127

Example

Err codemadness.org 70 i 14128 Err codemadness.org 70 i 14129

Here is a possible use case of the per-partition attributes support. By the use of per-partition attributes, the Spider storage engine (and other federated engines) can provide users with a cleaner way to specify where to connect.

Err codemadness.org 70 i 14130 Err codemadness.org 70 i 14131

Err codemadness.org 70 i 14132

Err codemadness.org 70 i 14133 Err codemadness.org 70 i 14134 Err codemadness.org 70 i 14135 Err codemadness.org 70 i 14136 Err codemadness.org 70 i 14139 Err codemadness.org 70 i 14140 Err codemadness.org 70 i 14141 Err codemadness.org 70 i 14144 Err codemadness.org 70 i 14145 Err codemadness.org 70 i 14146 Err codemadness.org 70 i 14149 Err codemadness.org 70 i 14150 Err codemadness.org 70 i 14151 Err codemadness.org 70 i 14154 Err codemadness.org 70 i 14155 Err codemadness.org 70 i 14156 Err codemadness.org 70 i 14159 Err codemadness.org 70 i 14160 Err codemadness.org 70 i 14161 Err codemadness.org 70 i 14164 Err codemadness.org 70 i 14165 Err codemadness.org 70 i 14166 Err codemadness.org 70 i 14169 Err codemadness.org 70 i 14170 Err codemadness.org 70 i 14171 Err codemadness.org 70 i 14175 Err codemadness.org 70 i 14176 Err codemadness.org 70 i 14177

Err codemadness.org 70 i 14137

CREATE TABLE tbl_a (

Err codemadness.org 70 i 14138

Err codemadness.org 70 i 14142

    a INT,

Err codemadness.org 70 i 14143

Err codemadness.org 70 i 14147

    b VARCHAR(255),

Err codemadness.org 70 i 14148

Err codemadness.org 70 i 14152

    PRIMARY KEY(a)

Err codemadness.org 70 i 14153

Err codemadness.org 70 i 14157

) ENGINE=Spider PARTITION BY RANGE(a) (

Err codemadness.org 70 i 14158

Err codemadness.org 70 i 14162

    PARTITION pt1 VALUES LESS THAN (100) REMOTE_SERVER="s_2_1" REMOTE_TABLE="ta_r1",

Err codemadness.org 70 i 14163

Err codemadness.org 70 i 14167

    PARTITION pt2 VALUES LESS THAN MAXVALUE REMOTE_SERVER="s_2_1", REMOTE_TABLE="ta_r2"

Err codemadness.org 70 i 14168

Err codemadness.org 70 i 14172

)	Err	codemadness.org	70
i 14173

Err codemadness.org 70 i 14174

Err codemadness.org 70 i 14178

Err codemadness.org 70 i 14179

Err codemadness.org 70 i 14180 Err codemadness.org 70 i 14181

Note that the example above doesn't work with the current server implementation.

Err codemadness.org 70 i 14182 Err codemadness.org 70 i 14183

Description

Err codemadness.org 70 i 14184 Err codemadness.org 70 i 14185

If an engine-defined attribute is specified at table-level, it applies to all the partitions in the table (backward compatible behavior).
Specifying an engine-defined attribute at table-level is only possible when all the storage engines composing a partitioned table support this attribute. Currently, it is not possible to use multiple storage engines to create a partitioned table, but this will be possible in MDEV-22168.
One can use both per-table attributes and per-partition attributes for a single table. If the same attribute is specified both at table-level and partition-level, the per-partition attribute takes precedence. So, we can consider per-table attributes as default values.
We do not support, at least in the present issue, engine-defined attributes per subpartitions.

Err codemadness.org 70 i 14191 Err codemadness.org 70 i 14192 Err codemadness.org 70 i 14193

TODO

Err codemadness.org 70 i 14194 Err codemadness.org 70 i 14195

Modify the parser to accept per-partition attributes;
Keep per-partition attributes some in-memory data structure (class partition_element ?);
Pass per-partition attributes to ha_partition::create() as per-table attributes; Err codemadness.org 70 i 14199
- This is to keep the handler mostly oblivious whether it's a partition or a table.
- The partition storage engine has a hook point to modify TABLE_SHARE. We can also set up per-table attributes there. https://github.com/MariaDB/server/blob/mariadb-10.7.1/sql/ha_partition.cc#L2722
- Per-table attributes and per-partition attributes should be merged before table creation.
Err codemadness.org 70 i 14204
Persist per-partition attributes in FRM files;
~~Modify the SHOW function to handle per-partition attributes.~~ (unnecessary)
Make it work with subpartitions
Add test cases (subpartitioning, alter table)
Fix CONNECT tests failures: https://buildbot.mariadb.org/#/builders/236/builds/3094
Refactor the entire patch.

Err codemadness.org 70 i 14212 Err codemadness.org 70 i 14213

Err codemadness.org 70 i 14214

Err codemadness.org 70 i 14217 Err codemadness.org 70 i 14218

Err codemadness.org 70 i 14219 Err codemadness.org 70 i 14220 Err codemadness.org 70 i 14221 Err codemadness.org 70 i 14222 Err codemadness.org 70 i 14225 Err codemadness.org 70 i 14226 Err codemadness.org 70 i 14227

Err codemadness.org 70 i 14223 Comments Err codemadness.org 70 i 14224

Err codemadness.org 70 i 14228 Err codemadness.org 70 i 14229 Err codemadness.org 70 i 14230 Err codemadness.org 70 i 14241 Err codemadness.org 70 i 14250 Err codemadness.org 70 i 14261 Err codemadness.org 70 i 14264 Err codemadness.org 70 i 14275 Err codemadness.org 70 i 14278 Err codemadness.org 70 i 14289 Err codemadness.org 70 i 14292 Err codemadness.org 70 i 14303 Err codemadness.org 70 i 14308 Err codemadness.org 70 i 14319 Err codemadness.org 70 i 14322 Err codemadness.org 70 i 14333 Err codemadness.org 70 i 14337 Err codemadness.org 70 i 14348 Err codemadness.org 70 i 14351 Err codemadness.org 70 i 14362 Err codemadness.org 70 i 14365 Err codemadness.org 70 i 14376 Err codemadness.org 70 i 14379 Err codemadness.org 70 i 14390 Err codemadness.org 70 i 14393

Err codemadness.org 70 i 14231 Comment by Err codemadness.org 70 i 14232 Olivier Bertrand Err codemadness.org 70 i 14233 Err codemadness.org 70 i 14234 [ Err codemadness.org 70 i 14235 2014-06-10 Err codemadness.org 70 i 14236 Err codemadness.org 70 i 14237 ] Err codemadness.org 70 i 14238 Err codemadness.org 70 i 14239 Err codemadness.org 70 i 14240

Err codemadness.org 70 i 14242

There are more problems withe the PARTITION engine, for instances:

Err codemadness.org 70 i 14243 Err codemadness.org 70 i 14244

If the original table has a CONNECTION string, it is lost when calling the partition tables

Err codemadness.org 70 i 14245 Err codemadness.org 70 i 14246

Query pruning can loose existing data (~~MDEV-6322~~)

Err codemadness.org 70 i 14247 Err codemadness.org 70 i 14248

These issues need to be handled.

Err codemadness.org 70 i 14249

Err codemadness.org 70 i 14251 Comment by Err codemadness.org 70 i 14252 Sergei Golubchik Err codemadness.org 70 i 14253 Err codemadness.org 70 i 14254 [ Err codemadness.org 70 i 14255 2020-04-17 Err codemadness.org 70 i 14256 Err codemadness.org 70 i 14257 ] Err codemadness.org 70 i 14258 Err codemadness.org 70 i 14259 Err codemadness.org 70 i 14260

Err codemadness.org 70 i 14262

frm does not store attributes per partition and in memory data structures have only one list of attributes per table.

Err codemadness.org 70 i 14263

Err codemadness.org 70 i 14265 Comment by Err codemadness.org 70 i 14266 Olivier Bertrand Err codemadness.org 70 i 14267 Err codemadness.org 70 i 14268 [ Err codemadness.org 70 i 14269 2020-05-27 Err codemadness.org 70 i 14270 Err codemadness.org 70 i 14271 ] Err codemadness.org 70 i 14272 Err codemadness.org 70 i 14273 Err codemadness.org 70 i 14274

Err codemadness.org 70 i 14276

Why only version 10.6?

Err codemadness.org 70 i 14277

Err codemadness.org 70 i 14279 Comment by Err codemadness.org 70 i 14280 Sergei Golubchik Err codemadness.org 70 i 14281 Err codemadness.org 70 i 14282 [ Err codemadness.org 70 i 14283 2020-05-27 Err codemadness.org 70 i 14284 Err codemadness.org 70 i 14285 ] Err codemadness.org 70 i 14286 Err codemadness.org 70 i 14287 Err codemadness.org 70 i 14288

Err codemadness.org 70 i 14290

it's expected to be a pretty intrusive internal refactoring. If it'll turn out to be something smaller and safer we can backport it to earlier versions.

Err codemadness.org 70 i 14291

Err codemadness.org 70 i 14293 Comment by Err codemadness.org 70 i 14294 Nayuta Yanagisawa Err codemadness.org 70 i 14295 Err codemadness.org 70 i 14296 [ Err codemadness.org 70 i 14297 2021-11-05 Err codemadness.org 70 i 14298 Err codemadness.org 70 i 14299 ] Err codemadness.org 70 i 14300 Err codemadness.org 70 i 14301 Err codemadness.org 70 i 14302

Err codemadness.org 70 i 14304

Ralf Gebhardt and Sergei Golubchik. In MariaDB, there seem to be two types of table options, one is engine-specific and the other is non-engine-specific. And, they seemed to be treated differently. For example, PAGE_COMPRESSED is an InnoDB specific option and STATS_AUTO_RECALC is a non-engine specific option (while STATS_AUTO_RECALC seems to be used only by InnoDB).

Err codemadness.org 70 i 14305 Err codemadness.org 70 i 14306

Can I limit the scope of the issue to the engine-specific options? Of course, we may need to make similar enhancements to the non-engine-specific options, but I would like to make it by a separate task.

Err codemadness.org 70 i 14307

Err codemadness.org 70 i 14309 Comment by Err codemadness.org 70 i 14310 Sergei Golubchik Err codemadness.org 70 i 14311 Err codemadness.org 70 i 14312 [ Err codemadness.org 70 i 14313 2021-11-05 Err codemadness.org 70 i 14314 Err codemadness.org 70 i 14315 ] Err codemadness.org 70 i 14316 Err codemadness.org 70 i 14317 Err codemadness.org 70 i 14318

Err codemadness.org 70 i 14320

Yes, this is only about engine-defined attributes, those that are not hard-coded in the server, but declared by the engine using the dedicated API

Err codemadness.org 70 i 14321

Err codemadness.org 70 i 14323 Comment by Err codemadness.org 70 i 14324 Max Mether Err codemadness.org 70 i 14325 Err codemadness.org 70 i 14326 [ Err codemadness.org 70 i 14327 2021-11-05 Err codemadness.org 70 i 14328 Err codemadness.org 70 i 14329 ] Err codemadness.org 70 i 14330 Err codemadness.org 70 i 14331 Err codemadness.org 70 i 14332

Err codemadness.org 70 i 14334

Just note that we also want to implement MDEV-22168 and that whatever is done in this MDEV should of course support what will be done in that MDEV.

Err codemadness.org 70 i 14335 Err codemadness.org 70 i 14336

Err codemadness.org 70 i 14338 Comment by Err codemadness.org 70 i 14339 Nayuta Yanagisawa Err codemadness.org 70 i 14340 Err codemadness.org 70 i 14341 [ Err codemadness.org 70 i 14342 2021-11-05 Err codemadness.org 70 i 14343 Err codemadness.org 70 i 14344 ] Err codemadness.org 70 i 14345 Err codemadness.org 70 i 14346 Err codemadness.org 70 i 14347

Err codemadness.org 70 i 14349

I understand. Thank you very much!

Err codemadness.org 70 i 14350

Err codemadness.org 70 i 14352 Comment by Err codemadness.org 70 i 14353 Nayuta Yanagisawa Err codemadness.org 70 i 14354 Err codemadness.org 70 i 14355 [ Err codemadness.org 70 i 14356 2021-11-09 Err codemadness.org 70 i 14357 Err codemadness.org 70 i 14358 ] Err codemadness.org 70 i 14359 Err codemadness.org 70 i 14360 Err codemadness.org 70 i 14361

Err codemadness.org 70 i 14363

Sergei Golubchik, Ralf Gebhardt I wrote out some details of the per-partition attribute. Please comment if you have any concerns or if there is anything that needs to be fixed.

Err codemadness.org 70 i 14364

Err codemadness.org 70 i 14366 Comment by Err codemadness.org 70 i 14367 Nayuta Yanagisawa Err codemadness.org 70 i 14368 Err codemadness.org 70 i 14369 [ Err codemadness.org 70 i 14370 2021-11-18 Err codemadness.org 70 i 14371 Err codemadness.org 70 i 14372 ] Err codemadness.org 70 i 14373 Err codemadness.org 70 i 14374 Err codemadness.org 70 i 14375

Err codemadness.org 70 i 14377

Alexey Botchkov Please review: https://github.com/MariaDB/server/commit/473ece969dbba474d2aa146466e66238bb373d28

Err codemadness.org 70 i 14378

Err codemadness.org 70 i 14380 Comment by Err codemadness.org 70 i 14381 Nayuta Yanagisawa Err codemadness.org 70 i 14382 Err codemadness.org 70 i 14383 [ Err codemadness.org 70 i 14384 2021-11-19 Err codemadness.org 70 i 14385 Err codemadness.org 70 i 14386 ] Err codemadness.org 70 i 14387 Err codemadness.org 70 i 14388 Err codemadness.org 70 i 14389

Err codemadness.org 70 i 14391

Alexey Botchkov I slightly updated my patch: https://github.com/MariaDB/server/commit/53fb89c94154ff8879af7a0c1dc8e41bb98164a3

Err codemadness.org 70 i 14392

Err codemadness.org 70 i 14394

[MDEV-14481] Execute InnoDB crash recovery in the background

Marko Mäkelä — Thu, 18 Nov 2021 19:15:44 +0000

Err codemadness.org 70 i 14470 Err codemadness.org 70 i 14471 Err codemadness.org 70 i 14480 Err codemadness.org 70 i 14481 Err codemadness.org 70 i 14482 Err codemadness.org 70 i 14483 Err codemadness.org 70 i 14484 Err codemadness.org 70 i 14485 Err codemadness.org 70 i 14486 Err codemadness.org 70 i 14487 Err codemadness.org 70 i 14488 Err codemadness.org 70 i 14489 Err codemadness.org 70 i 14490 Err codemadness.org 70 i 14491 Err codemadness.org 70 i 14492 Err codemadness.org 70 i 14494 Err codemadness.org 70 i 14495 Err codemadness.org 70 i 14496 Err codemadness.org 70 i 14497 Err codemadness.org 70 i 14498 Err codemadness.org 70 i 14499 Err codemadness.org 70 i 14500 Err codemadness.org 70 i 14501 Err codemadness.org 70 i 14503 Err codemadness.org 70 i 14504 Err codemadness.org 70 i 14505

Err codemadness.org 70 i 14472 Err codemadness.org 70 i 14473 [MDEV-14481] Execute InnoDB crash recovery in the background Err codemadness.org 70 i 14474 Err codemadness.org 70 i 14475 Created: 2017-11-23 Updated: 2021-11-18 Err codemadness.org 70 i 14476 Err codemadness.org 70 i 14477 Err codemadness.org 70 i 14478 Err codemadness.org 70 i 14479
Status:	Stalled
Project:	MariaDB Server
Component/s:	Err codemadness.org 70 i 14493 Storage Engine - InnoDB
Fix Version/s:	Err codemadness.org 70 i 14502 10.8

Err codemadness.org 70 i 14506 Err codemadness.org 70 i 14507

Err codemadness.org 70 i 14508 Err codemadness.org 70 i 14509 Err codemadness.org 70 i 14510 Err codemadness.org 70 i 14513 Err codemadness.org 70 i 14516 Err codemadness.org 70 i 14517 Err codemadness.org 70 i 14520 Err codemadness.org 70 i 14523 Err codemadness.org 70 i 14524 Err codemadness.org 70 i 14525 Err codemadness.org 70 i 14528 Err codemadness.org 70 i 14531 Err codemadness.org 70 i 14532 Err codemadness.org 70 i 14535 Err codemadness.org 70 i 14538 Err codemadness.org 70 i 14539 Err codemadness.org 70 i 14540 Err codemadness.org 70 i 14543 Err codemadness.org 70 i 14546 Err codemadness.org 70 i 14549 Err codemadness.org 70 i 14552 Err codemadness.org 70 i 14553 Err codemadness.org 70 i 14554 Err codemadness.org 70 i 14555 Err codemadness.org 70 i 14556 Err codemadness.org 70 i 14559 Err codemadness.org 70 i 14561 Err codemadness.org 70 i 14562 Err codemadness.org 70 i 14563 Err codemadness.org 70 i 14564 Err codemadness.org 70 i 14565 Err codemadness.org 70 i 14566 Err codemadness.org 70 i 14567

Err codemadness.org 70 i 14511 Type: Err codemadness.org 70 i 14512

Err codemadness.org 70 i 14514 Task Err codemadness.org 70 i 14515

Err codemadness.org 70 i 14518 Priority: Err codemadness.org 70 i 14519

Err codemadness.org 70 i 14521 Critical Err codemadness.org 70 i 14522

Err codemadness.org 70 i 14526 Reporter: Err codemadness.org 70 i 14527

Err codemadness.org 70 i 14529 Marko Mäkelä Err codemadness.org 70 i 14530

Err codemadness.org 70 i 14533 Assignee: Err codemadness.org 70 i 14534

Err codemadness.org 70 i 14536 Eugene Kosov Err codemadness.org 70 i 14537

Err codemadness.org 70 i 14541 Resolution: Err codemadness.org 70 i 14542

Err codemadness.org 70 i 14544 Unresolved Err codemadness.org 70 i 14545

Err codemadness.org 70 i 14547 Votes: Err codemadness.org 70 i 14548

Err codemadness.org 70 i 14550 2 Err codemadness.org 70 i 14551

Err codemadness.org 70 i 14557 Labels: Err codemadness.org 70 i 14558

Err codemadness.org 70 i 14560 performance, recovery

Err codemadness.org 70 i 14568 Err codemadness.org 70 i 14569 Err codemadness.org 70 i 14570 Err codemadness.org 70 i 14571

Err codemadness.org 70 i 14572 Err codemadness.org 70 i 14573 Err codemadness.org 70 i 14574 Err codemadness.org 70 i 14575 Err codemadness.org 70 i 14576 Err codemadness.org 70 i 14577 Err codemadness.org 70 i 14578 Err codemadness.org 70 i 14581 Err codemadness.org 70 i 14855 Err codemadness.org 70 i 14856 Err codemadness.org 70 i 14857 Err codemadness.org 70 i 14858 Err codemadness.org 70 i 14859 Err codemadness.org 70 i 14860 Err codemadness.org 70 i 14861

Err codemadness.org 70 i 14579 Issue Links: Err codemadness.org 70 i 14580

Err codemadness.org 70 i 14582 Err codemadness.org 70 i 14583 Err codemadness.org 70 i 14584 Err codemadness.org 70 i 14587 Err codemadness.org 70 i 14588 Err codemadness.org 70 i 14589 Err codemadness.org 70 i 14592 Err codemadness.org 70 i 14596 Err codemadness.org 70 i 14599 Err codemadness.org 70 i 14602 Err codemadness.org 70 i 14603 Err codemadness.org 70 i 14604 Err codemadness.org 70 i 14607 Err codemadness.org 70 i 14611 Err codemadness.org 70 i 14614 Err codemadness.org 70 i 14617 Err codemadness.org 70 i 14618 Err codemadness.org 70 i 14619 Err codemadness.org 70 i 14622 Err codemadness.org 70 i 14626 Err codemadness.org 70 i 14629 Err codemadness.org 70 i 14632 Err codemadness.org 70 i 14633 Err codemadness.org 70 i 14634 Err codemadness.org 70 i 14637 Err codemadness.org 70 i 14641 Err codemadness.org 70 i 14644 Err codemadness.org 70 i 14647 Err codemadness.org 70 i 14648 Err codemadness.org 70 i 14649 Err codemadness.org 70 i 14652 Err codemadness.org 70 i 14656 Err codemadness.org 70 i 14659 Err codemadness.org 70 i 14662 Err codemadness.org 70 i 14663 Err codemadness.org 70 i 14664 Err codemadness.org 70 i 14667 Err codemadness.org 70 i 14671 Err codemadness.org 70 i 14674 Err codemadness.org 70 i 14677 Err codemadness.org 70 i 14678 Err codemadness.org 70 i 14679 Err codemadness.org 70 i 14682 Err codemadness.org 70 i 14686 Err codemadness.org 70 i 14689 Err codemadness.org 70 i 14692 Err codemadness.org 70 i 14693 Err codemadness.org 70 i 14694 Err codemadness.org 70 i 14697 Err codemadness.org 70 i 14698 Err codemadness.org 70 i 14699 Err codemadness.org 70 i 14702 Err codemadness.org 70 i 14706 Err codemadness.org 70 i 14709 Err codemadness.org 70 i 14712 Err codemadness.org 70 i 14713 Err codemadness.org 70 i 14714 Err codemadness.org 70 i 14717 Err codemadness.org 70 i 14718 Err codemadness.org 70 i 14719 Err codemadness.org 70 i 14722 Err codemadness.org 70 i 14726 Err codemadness.org 70 i 14729 Err codemadness.org 70 i 14732 Err codemadness.org 70 i 14733 Err codemadness.org 70 i 14734 Err codemadness.org 70 i 14737 Err codemadness.org 70 i 14741 Err codemadness.org 70 i 14744 Err codemadness.org 70 i 14747 Err codemadness.org 70 i 14748 Err codemadness.org 70 i 14749 Err codemadness.org 70 i 14752 Err codemadness.org 70 i 14756 Err codemadness.org 70 i 14759 Err codemadness.org 70 i 14762 Err codemadness.org 70 i 14763 Err codemadness.org 70 i 14764 Err codemadness.org 70 i 14767 Err codemadness.org 70 i 14771 Err codemadness.org 70 i 14774 Err codemadness.org 70 i 14777 Err codemadness.org 70 i 14778 Err codemadness.org 70 i 14779 Err codemadness.org 70 i 14782 Err codemadness.org 70 i 14786 Err codemadness.org 70 i 14789 Err codemadness.org 70 i 14792 Err codemadness.org 70 i 14793 Err codemadness.org 70 i 14794 Err codemadness.org 70 i 14797 Err codemadness.org 70 i 14801 Err codemadness.org 70 i 14804 Err codemadness.org 70 i 14807 Err codemadness.org 70 i 14808 Err codemadness.org 70 i 14809 Err codemadness.org 70 i 14812 Err codemadness.org 70 i 14816 Err codemadness.org 70 i 14819 Err codemadness.org 70 i 14822 Err codemadness.org 70 i 14823 Err codemadness.org 70 i 14824 Err codemadness.org 70 i 14827 Err codemadness.org 70 i 14831 Err codemadness.org 70 i 14834 Err codemadness.org 70 i 14837 Err codemadness.org 70 i 14838 Err codemadness.org 70 i 14839 Err codemadness.org 70 i 14842 Err codemadness.org 70 i 14846 Err codemadness.org 70 i 14849 Err codemadness.org 70 i 14852 Err codemadness.org 70 i 14853

Err codemadness.org 70 i 14585 Blocks Err codemadness.org 70 i 14586
Err codemadness.org 70 i 14590 blocks Err codemadness.org 70 i 14591	Err codemadness.org 70 i 14593 Err codemadness.org 70 i 14594 MDEV-12700 Err codemadness.org 70 i 14595	Err codemadness.org 70 i 14597 Allow innodb_read_only startup withou... Err codemadness.org 70 i 14598	Err codemadness.org 70 i 14600 Stalled Err codemadness.org 70 i 14601
Err codemadness.org 70 i 14605 is blocked by Err codemadness.org 70 i 14606	Err codemadness.org 70 i 14608 Err codemadness.org 70 i 14609 ~~MDEV-9843~~ Err codemadness.org 70 i 14610	Err codemadness.org 70 i 14612 InnoDB hangs on startup between "Inno... Err codemadness.org 70 i 14613	Err codemadness.org 70 i 14615 Closed Err codemadness.org 70 i 14616
Err codemadness.org 70 i 14620 is blocked by Err codemadness.org 70 i 14621	Err codemadness.org 70 i 14623 Err codemadness.org 70 i 14624 ~~MDEV-13564~~ Err codemadness.org 70 i 14625	Err codemadness.org 70 i 14627 TRUNCATE TABLE and undo tablespace tr... Err codemadness.org 70 i 14628	Err codemadness.org 70 i 14630 Closed Err codemadness.org 70 i 14631
Err codemadness.org 70 i 14635 is blocked by Err codemadness.org 70 i 14636	Err codemadness.org 70 i 14638 Err codemadness.org 70 i 14639 ~~MDEV-13869~~ Err codemadness.org 70 i 14640	Err codemadness.org 70 i 14642 MariaDB slow start Err codemadness.org 70 i 14643	Err codemadness.org 70 i 14645 Closed Err codemadness.org 70 i 14646
Err codemadness.org 70 i 14650 is blocked by Err codemadness.org 70 i 14651	Err codemadness.org 70 i 14653 Err codemadness.org 70 i 14654 ~~MDEV-19514~~ Err codemadness.org 70 i 14655	Err codemadness.org 70 i 14657 Defer change buffer merge until pages... Err codemadness.org 70 i 14658	Err codemadness.org 70 i 14660 Closed Err codemadness.org 70 i 14661
Err codemadness.org 70 i 14665 is blocked by Err codemadness.org 70 i 14666	Err codemadness.org 70 i 14668 Err codemadness.org 70 i 14669 ~~MDEV-21216~~ Err codemadness.org 70 i 14670	Err codemadness.org 70 i 14672 InnoDB performs dirty read of TRX_SYS... Err codemadness.org 70 i 14673	Err codemadness.org 70 i 14675 Closed Err codemadness.org 70 i 14676
Err codemadness.org 70 i 14680 is blocked by Err codemadness.org 70 i 14681	Err codemadness.org 70 i 14683 Err codemadness.org 70 i 14684 ~~MDEV-23399~~ Err codemadness.org 70 i 14685	Err codemadness.org 70 i 14687 10.5 performance regression with IO-b... Err codemadness.org 70 i 14688	Err codemadness.org 70 i 14690 Closed Err codemadness.org 70 i 14691
Err codemadness.org 70 i 14695 PartOf Err codemadness.org 70 i 14696
Err codemadness.org 70 i 14700 includes Err codemadness.org 70 i 14701	Err codemadness.org 70 i 14703 Err codemadness.org 70 i 14704 MDEV-27022 Err codemadness.org 70 i 14705	Err codemadness.org 70 i 14707 slightly optimize crash recovery in I... Err codemadness.org 70 i 14708	Err codemadness.org 70 i 14710 Open Err codemadness.org 70 i 14711
Err codemadness.org 70 i 14715 Relates Err codemadness.org 70 i 14716
Err codemadness.org 70 i 14720 relates to Err codemadness.org 70 i 14721	Err codemadness.org 70 i 14723 Err codemadness.org 70 i 14724 ~~MDEV-12699~~ Err codemadness.org 70 i 14725	Err codemadness.org 70 i 14727 Improve crash recovery of corrupted d... Err codemadness.org 70 i 14728	Err codemadness.org 70 i 14730 Closed Err codemadness.org 70 i 14731
Err codemadness.org 70 i 14735 relates to Err codemadness.org 70 i 14736	Err codemadness.org 70 i 14738 Err codemadness.org 70 i 14739 MDEV-13542 Err codemadness.org 70 i 14740	Err codemadness.org 70 i 14742 Crashing on a corrupted page is unhel... Err codemadness.org 70 i 14743	Err codemadness.org 70 i 14745 Confirmed Err codemadness.org 70 i 14746
Err codemadness.org 70 i 14750 relates to Err codemadness.org 70 i 14751	Err codemadness.org 70 i 14753 Err codemadness.org 70 i 14754 ~~MDEV-13564~~ Err codemadness.org 70 i 14755	Err codemadness.org 70 i 14757 TRUNCATE TABLE and undo tablespace tr... Err codemadness.org 70 i 14758	Err codemadness.org 70 i 14760 Closed Err codemadness.org 70 i 14761
Err codemadness.org 70 i 14765 relates to Err codemadness.org 70 i 14766	Err codemadness.org 70 i 14768 Err codemadness.org 70 i 14769 ~~MDEV-14935~~ Err codemadness.org 70 i 14770	Err codemadness.org 70 i 14772 Remove bogus conditions related to no... Err codemadness.org 70 i 14773	Err codemadness.org 70 i 14775 Closed Err codemadness.org 70 i 14776
Err codemadness.org 70 i 14780 relates to Err codemadness.org 70 i 14781	Err codemadness.org 70 i 14783 Err codemadness.org 70 i 14784 ~~MDEV-18733~~ Err codemadness.org 70 i 14785	Err codemadness.org 70 i 14787 MariaDB slow start after crash recovery Err codemadness.org 70 i 14788	Err codemadness.org 70 i 14790 Closed Err codemadness.org 70 i 14791
Err codemadness.org 70 i 14795 relates to Err codemadness.org 70 i 14796	Err codemadness.org 70 i 14798 Err codemadness.org 70 i 14799 MDEV-19229 Err codemadness.org 70 i 14800	Err codemadness.org 70 i 14802 Increase the undo log tablespace duri... Err codemadness.org 70 i 14803	Err codemadness.org 70 i 14805 Stalled Err codemadness.org 70 i 14806
Err codemadness.org 70 i 14810 relates to Err codemadness.org 70 i 14811	Err codemadness.org 70 i 14813 Err codemadness.org 70 i 14814 ~~MDEV-9663~~ Err codemadness.org 70 i 14815	Err codemadness.org 70 i 14817 InnoDB assertion failure: *cursor->in... Err codemadness.org 70 i 14818	Err codemadness.org 70 i 14820 Closed Err codemadness.org 70 i 14821
Err codemadness.org 70 i 14825 relates to Err codemadness.org 70 i 14826	Err codemadness.org 70 i 14828 Err codemadness.org 70 i 14829 MDEV-14425 Err codemadness.org 70 i 14830	Err codemadness.org 70 i 14832 Change the InnoDB redo log format to ... Err codemadness.org 70 i 14833	Err codemadness.org 70 i 14835 In Progress Err codemadness.org 70 i 14836
Err codemadness.org 70 i 14840 relates to Err codemadness.org 70 i 14841	Err codemadness.org 70 i 14843 Err codemadness.org 70 i 14844 MDEV-26326 Err codemadness.org 70 i 14845	Err codemadness.org 70 i 14847 MDEV-24626 (remove synchronous page0 ... Err codemadness.org 70 i 14848	Err codemadness.org 70 i 14850 Open Err codemadness.org 70 i 14851

Err codemadness.org 70 i 14854

Err codemadness.org 70 i 14862 Err codemadness.org 70 i 14863

Err codemadness.org 70 i 14864 Err codemadness.org 70 i 14865 Err codemadness.org 70 i 14866 Err codemadness.org 70 i 14867 Err codemadness.org 70 i 14870 Err codemadness.org 70 i 14871 Err codemadness.org 70 i 14872

Err codemadness.org 70 i 14868 Description Err codemadness.org 70 i 14869

Err codemadness.org 70 i 14873 Err codemadness.org 70 i 14874 Err codemadness.org 70 i 14875 Err codemadness.org 70 i 14876 Err codemadness.org 70 i 14887 Err codemadness.org 70 i 14888

Err codemadness.org 70 i 14877

InnoDB startup unnecessarily waits for recovered redo log records to be applied to the data files.

Err codemadness.org 70 i 14878 Err codemadness.org 70 i 14879

In fact, normally while the function trx_sys_init_at_db_start() is executing, the pages that it is requesting from the buffer pool will have any recovered redo log applied to them in the background.

Err codemadness.org 70 i 14880 Err codemadness.org 70 i 14881

Basically, we only need to remove or refactor some calls in the InnoDB server startup. Some of this was performed in ~~MDEV-19514~~ and ~~MDEV-21216~~.

Err codemadness.org 70 i 14882 The crash recovery would ‘complete’ at the time of the next redo log checkpoint is written.

Err codemadness.org 70 i 14883 Err codemadness.org 70 i 14884

We should rewrite or remove recv_recovery_from_checkpoint_finish() so that it will not wait for any page flushing to complete. While doing this, we must also remove the buf_pool_t::flush_rbt and use the normal flushing mechanism that strictly obeys the ARIES protocol for write-ahead logging.

Err codemadness.org 70 i 14885

Err codemadness.org 70 i 14886

Err codemadness.org 70 i 14889 Err codemadness.org 70 i 14890

Err codemadness.org 70 i 14891 Err codemadness.org 70 i 14892 Err codemadness.org 70 i 14893 Err codemadness.org 70 i 14894 Err codemadness.org 70 i 14897 Err codemadness.org 70 i 14898 Err codemadness.org 70 i 14899

Err codemadness.org 70 i 14895 Comments Err codemadness.org 70 i 14896

Err codemadness.org 70 i 14900 Err codemadness.org 70 i 14901 Err codemadness.org 70 i 14902 Err codemadness.org 70 i 14913 Err codemadness.org 70 i 14916 Err codemadness.org 70 i 14927 Err codemadness.org 70 i 14930 Err codemadness.org 70 i 14941 Err codemadness.org 70 i 14944 Err codemadness.org 70 i 14955 Err codemadness.org 70 i 15235 Err codemadness.org 70 i 15246 Err codemadness.org 70 i 15461 Err codemadness.org 70 i 15472 Err codemadness.org 70 i 15475 Err codemadness.org 70 i 15486 Err codemadness.org 70 i 15489 Err codemadness.org 70 i 15500 Err codemadness.org 70 i 15503 Err codemadness.org 70 i 15514 Err codemadness.org 70 i 15517 Err codemadness.org 70 i 15528 Err codemadness.org 70 i 15533 Err codemadness.org 70 i 15544 Err codemadness.org 70 i 15547 Err codemadness.org 70 i 15558 Err codemadness.org 70 i 15911 Err codemadness.org 70 i 15922 Err codemadness.org 70 i 15925 Err codemadness.org 70 i 15936 Err codemadness.org 70 i 15941 Err codemadness.org 70 i 15952 Err codemadness.org 70 i 15957 Err codemadness.org 70 i 15968 Err codemadness.org 70 i 15971 Err codemadness.org 70 i 15982 Err codemadness.org 70 i 15989 Err codemadness.org 70 i 16000 Err codemadness.org 70 i 16003 Err codemadness.org 70 i 16014 Err codemadness.org 70 i 16017 Err codemadness.org 70 i 16028 Err codemadness.org 70 i 16033

Err codemadness.org 70 i 14903 Comment by Err codemadness.org 70 i 14904 Marko Mäkelä Err codemadness.org 70 i 14905 Err codemadness.org 70 i 14906 [ Err codemadness.org 70 i 14907 2018-01-16 Err codemadness.org 70 i 14908 Err codemadness.org 70 i 14909 ] Err codemadness.org 70 i 14910 Err codemadness.org 70 i 14911 Err codemadness.org 70 i 14912

Err codemadness.org 70 i 14914

If the aim of this task is to shorten the downtime after a crash, then as noted in ~~MDEV-9843~~, we should also remove the consistency checks of all .ibd files when crash recovery is needed.

Err codemadness.org 70 i 14915

Err codemadness.org 70 i 14917 Comment by Err codemadness.org 70 i 14918 Marko Mäkelä Err codemadness.org 70 i 14919 Err codemadness.org 70 i 14920 [ Err codemadness.org 70 i 14921 2018-02-13 Err codemadness.org 70 i 14922 Err codemadness.org 70 i 14923 ] Err codemadness.org 70 i 14924 Err codemadness.org 70 i 14925 Err codemadness.org 70 i 14926

Err codemadness.org 70 i 14928

~~MDEV-13869~~ removes the .ibd file scans when no redo log apply is needed.

Err codemadness.org 70 i 14929

Err codemadness.org 70 i 14931 Comment by Err codemadness.org 70 i 14932 Marko Mäkelä Err codemadness.org 70 i 14933 Err codemadness.org 70 i 14934 [ Err codemadness.org 70 i 14935 2018-09-05 Err codemadness.org 70 i 14936 Err codemadness.org 70 i 14937 ] Err codemadness.org 70 i 14938 Err codemadness.org 70 i 14939 Err codemadness.org 70 i 14940

Err codemadness.org 70 i 14942

In MariaDB Server 10.4, as part of removing the crash-upgrade support for the pre-~~MDEV-13564~~ TRUNCATE, it looks like we can safely remove the buf_pool_invalidate() call.

Err codemadness.org 70 i 14943

Err codemadness.org 70 i 14945 Comment by Err codemadness.org 70 i 14946 Marko Mäkelä Err codemadness.org 70 i 14947 Err codemadness.org 70 i 14948 [ Err codemadness.org 70 i 14949 2019-02-04 Err codemadness.org 70 i 14950 Err codemadness.org 70 i 14951 ] Err codemadness.org 70 i 14952 Err codemadness.org 70 i 14953 Err codemadness.org 70 i 14954

Err codemadness.org 70 i 14956

The buf_pool_invalidate() call was already removed as part of ~~MDEV-13564~~ (removing the old crash-upgrade logic in 10.4).

Err codemadness.org 70 i 14957 I tried the following patch:

Err codemadness.org 70 i 14958

Err codemadness.org 70 i 14959

Err codemadness.org 70 i 14960 Err codemadness.org 70 i 14961 Err codemadness.org 70 i 14962 Err codemadness.org 70 i 14963 Err codemadness.org 70 i 14966 Err codemadness.org 70 i 14967 Err codemadness.org 70 i 14968 Err codemadness.org 70 i 14971 Err codemadness.org 70 i 14972 Err codemadness.org 70 i 14973 Err codemadness.org 70 i 14976 Err codemadness.org 70 i 14977 Err codemadness.org 70 i 14978 Err codemadness.org 70 i 14981 Err codemadness.org 70 i 14982 Err codemadness.org 70 i 14983 Err codemadness.org 70 i 14986 Err codemadness.org 70 i 14987 Err codemadness.org 70 i 14988 Err codemadness.org 70 i 14991 Err codemadness.org 70 i 14992 Err codemadness.org 70 i 14993 Err codemadness.org 70 i 14996 Err codemadness.org 70 i 14997 Err codemadness.org 70 i 14998 Err codemadness.org 70 i 15001 Err codemadness.org 70 i 15002 Err codemadness.org 70 i 15003 Err codemadness.org 70 i 15006 Err codemadness.org 70 i 15007 Err codemadness.org 70 i 15008 Err codemadness.org 70 i 15011 Err codemadness.org 70 i 15012 Err codemadness.org 70 i 15013 Err codemadness.org 70 i 15016 Err codemadness.org 70 i 15017 Err codemadness.org 70 i 15018 Err codemadness.org 70 i 15021 Err codemadness.org 70 i 15022 Err codemadness.org 70 i 15023 Err codemadness.org 70 i 15026 Err codemadness.org 70 i 15027 Err codemadness.org 70 i 15028 Err codemadness.org 70 i 15031 Err codemadness.org 70 i 15032 Err codemadness.org 70 i 15033 Err codemadness.org 70 i 15036 Err codemadness.org 70 i 15037 Err codemadness.org 70 i 15038 Err codemadness.org 70 i 15041 Err codemadness.org 70 i 15042 Err codemadness.org 70 i 15043 Err codemadness.org 70 i 15047 Err codemadness.org 70 i 15048 Err codemadness.org 70 i 15049

Err codemadness.org 70 i 14964

diff --git a/storage/innobase/fil/fil0fil.cc b/storage/innobase/fil/fil0fil.cc

Err codemadness.org 70 i 14965

Err codemadness.org 70 i 14969

index 9abbc4a540a..3844c6ccbb7 100644

Err codemadness.org 70 i 14970

Err codemadness.org 70 i 14974

--- a/storage/innobase/fil/fil0fil.cc

Err codemadness.org 70 i 14975

Err codemadness.org 70 i 14979

+++ b/storage/innobase/fil/fil0fil.cc

Err codemadness.org 70 i 14980

Err codemadness.org 70 i 14984

@@ -3199,12 +3199,6 @@ fil_ibd_open(

Err codemadness.org 70 i 14985

Err codemadness.org 70 i 14989

                 } else if (err) *err = DB_SUCCESS;

Err codemadness.org 70 i 14990

Err codemadness.org 70 i 14994

Err codemadness.org 70 i 14995

Err codemadness.org 70 i 14999

                 mutex_exit(&fil_system.mutex);

Err codemadness.org 70 i 15000

Err codemadness.org 70 i 15004

Err codemadness.org 70 i 15005

Err codemadness.org 70 i 15009

-                if (space && validate && !srv_read_only_mode) {

Err codemadness.org 70 i 15010

Err codemadness.org 70 i 15014

-                        fsp_flags_try_adjust(space,

Err codemadness.org 70 i 15015

Err codemadness.org 70 i 15019

-                                             flags & ~FSP_FLAGS_MEM_MASK);

Err codemadness.org 70 i 15020

Err codemadness.org 70 i 15024

-                }

Err codemadness.org 70 i 15025

Err codemadness.org 70 i 15029

Err codemadness.org 70 i 15030

Err codemadness.org 70 i 15034

                 return space;

Err codemadness.org 70 i 15035

Err codemadness.org 70 i 15039

Err codemadness.org 70 i 15040

Err codemadness.org 70 i 15044

         mutex_exit(&fil_system.mutex);	Err	codemadness.org	70
i 15045

Err codemadness.org 70 i 15046

Err codemadness.org 70 i 15050

Err codemadness.org 70 i 15051

Err codemadness.org 70 i 15052

This would address the above comment regarding ~~MDEV-9843~~.

Err codemadness.org 70 i 15053 Err codemadness.org 70 i 15054

With this change, I got an anomaly that did not look familiar to me:

Err codemadness.org 70 i 15055

Err codemadness.org 70 i 15056

Err codemadness.org 70 i 15057 Err codemadness.org 70 i 15058 Err codemadness.org 70 i 15059 Err codemadness.org 70 i 15060 Err codemadness.org 70 i 15063 Err codemadness.org 70 i 15064 Err codemadness.org 70 i 15065 Err codemadness.org 70 i 15066 Err codemadness.org 70 i 15067 Err codemadness.org 70 i 15070 Err codemadness.org 70 i 15071 Err codemadness.org 70 i 15072 Err codemadness.org 70 i 15075 Err codemadness.org 70 i 15076 Err codemadness.org 70 i 15077 Err codemadness.org 70 i 15080 Err codemadness.org 70 i 15081 Err codemadness.org 70 i 15082 Err codemadness.org 70 i 15085 Err codemadness.org 70 i 15086 Err codemadness.org 70 i 15087 Err codemadness.org 70 i 15090 Err codemadness.org 70 i 15091 Err codemadness.org 70 i 15092 Err codemadness.org 70 i 15095 Err codemadness.org 70 i 15096 Err codemadness.org 70 i 15097 Err codemadness.org 70 i 15100 Err codemadness.org 70 i 15101 Err codemadness.org 70 i 15102 Err codemadness.org 70 i 15105 Err codemadness.org 70 i 15106 Err codemadness.org 70 i 15107 Err codemadness.org 70 i 15110 Err codemadness.org 70 i 15111 Err codemadness.org 70 i 15112 Err codemadness.org 70 i 15115 Err codemadness.org 70 i 15116 Err codemadness.org 70 i 15117 Err codemadness.org 70 i 15120 Err codemadness.org 70 i 15121 Err codemadness.org 70 i 15122 Err codemadness.org 70 i 15125 Err codemadness.org 70 i 15126 Err codemadness.org 70 i 15127 Err codemadness.org 70 i 15130 Err codemadness.org 70 i 15131 Err codemadness.org 70 i 15132 Err codemadness.org 70 i 15135 Err codemadness.org 70 i 15136 Err codemadness.org 70 i 15137 Err codemadness.org 70 i 15140 Err codemadness.org 70 i 15141 Err codemadness.org 70 i 15142 Err codemadness.org 70 i 15145 Err codemadness.org 70 i 15146 Err codemadness.org 70 i 15147 Err codemadness.org 70 i 15150 Err codemadness.org 70 i 15151 Err codemadness.org 70 i 15152 Err codemadness.org 70 i 15155 Err codemadness.org 70 i 15156 Err codemadness.org 70 i 15157 Err codemadness.org 70 i 15160 Err codemadness.org 70 i 15161 Err codemadness.org 70 i 15162 Err codemadness.org 70 i 15165 Err codemadness.org 70 i 15166 Err codemadness.org 70 i 15167 Err codemadness.org 70 i 15170 Err codemadness.org 70 i 15171 Err codemadness.org 70 i 15172 Err codemadness.org 70 i 15175 Err codemadness.org 70 i 15176 Err codemadness.org 70 i 15177 Err codemadness.org 70 i 15180 Err codemadness.org 70 i 15181 Err codemadness.org 70 i 15182 Err codemadness.org 70 i 15185 Err codemadness.org 70 i 15186 Err codemadness.org 70 i 15187 Err codemadness.org 70 i 15190 Err codemadness.org 70 i 15191 Err codemadness.org 70 i 15192 Err codemadness.org 70 i 15195 Err codemadness.org 70 i 15196 Err codemadness.org 70 i 15197 Err codemadness.org 70 i 15200 Err codemadness.org 70 i 15201 Err codemadness.org 70 i 15202 Err codemadness.org 70 i 15205 Err codemadness.org 70 i 15206 Err codemadness.org 70 i 15207 Err codemadness.org 70 i 15211 Err codemadness.org 70 i 15212 Err codemadness.org 70 i 15213

Err codemadness.org 70 i 15061 10.4 5b996782be6b752ce50a0ecaa222b0688aa9e75d Err codemadness.org 70 i 15062
Err codemadness.org 70 i 15068 rpl.rpl_semi_sync_skip_repl 'innodb,row' w32 [ pass ] 2184 Err codemadness.org 70 i 15069
Err codemadness.org 70 i 15073 Err codemadness.org 70 i 15074
Err codemadness.org 70 i 15078 MTR's internal check of the test case 'rpl.rpl_semi_sync_skip_repl' failed. Err codemadness.org 70 i 15079
Err codemadness.org 70 i 15083 This means that the test case does not preserve the state that existed Err codemadness.org 70 i 15084
Err codemadness.org 70 i 15088 before the test case was executed. Most likely the test case did not Err codemadness.org 70 i 15089
Err codemadness.org 70 i 15093 do a proper clean-up. It could also be caused by the previous test run Err codemadness.org 70 i 15094
Err codemadness.org 70 i 15098 by this thread, if the server wasn't restarted. Err codemadness.org 70 i 15099
Err codemadness.org 70 i 15103 This is the diff of the states of the servers before and after the Err codemadness.org 70 i 15104
Err codemadness.org 70 i 15108 test case was executed: Err codemadness.org 70 i 15109
Err codemadness.org 70 i 15113 mysqltest: Logging to '/dev/shm/10.4/mysql-test/var/32/tmp/check-mysqld_2.log'. Err codemadness.org 70 i 15114
Err codemadness.org 70 i 15118 mysqltest: Results saved in '/dev/shm/10.4/mysql-test/var/32/tmp/check-mysqld_2.result'. Err codemadness.org 70 i 15119
Err codemadness.org 70 i 15123 mysqltest: Connecting to server localhost:16641 (socket /dev/shm/10.4/mysql-test/var/tmp/32/mysqld.2.sock) as 'root', connection 'default', attempt 0 ... Err codemadness.org 70 i 15124
Err codemadness.org 70 i 15128 mysqltest: ... Connected. Err codemadness.org 70 i 15129
Err codemadness.org 70 i 15133 mysqltest: Start processing test commands from './include/check-testcase.test' ... Err codemadness.org 70 i 15134
Err codemadness.org 70 i 15138 mysqltest: ... Done processing test commands. Err codemadness.org 70 i 15139
Err codemadness.org 70 i 15143 --- /dev/shm/10.4/mysql-test/var/32/tmp/check-mysqld_2.result 2019-02-04 09:37:53.989594035 +0200 Err codemadness.org 70 i 15144
Err codemadness.org 70 i 15148 +++ /dev/shm/10.4/mysql-test/var/32/tmp/check-mysqld_2.reject 2019-02-04 09:37:56.357627721 +0200 Err codemadness.org 70 i 15149
Err codemadness.org 70 i 15153 @@ -665,6 +665,7 @@ Err codemadness.org 70 i 15154
Err codemadness.org 70 i 15158 def performance_schema utf8 utf8_general_ci NULL Err codemadness.org 70 i 15159
Err codemadness.org 70 i 15163 def test latin1 latin1_swedish_ci NULL Err codemadness.org 70 i 15164
Err codemadness.org 70 i 15168 tables_in_test Err codemadness.org 70 i 15169
Err codemadness.org 70 i 15173 +t1 Err codemadness.org 70 i 15174
Err codemadness.org 70 i 15178 tables_in_mysql Err codemadness.org 70 i 15179
Err codemadness.org 70 i 15183 mysql.columns_priv Err codemadness.org 70 i 15184
Err codemadness.org 70 i 15188 mysql.column_stats Err codemadness.org 70 i 15189
Err codemadness.org 70 i 15193 Err codemadness.org 70 i 15194
Err codemadness.org 70 i 15198 mysqltest: Result length mismatch Err codemadness.org 70 i 15199
Err codemadness.org 70 i 15203 Err codemadness.org 70 i 15204
Err codemadness.org 70 i 15208 not ok Err codemadness.org 70 i 15209 Err codemadness.org 70 i 15210

Err codemadness.org 70 i 15214

Err codemadness.org 70 i 15215

Err codemadness.org 70 i 15216

The problem is occasionally repeatable by running the test alone:

Err codemadness.org 70 i 15217

Err codemadness.org 70 i 15218

Err codemadness.org 70 i 15219 Err codemadness.org 70 i 15220 Err codemadness.org 70 i 15221 Err codemadness.org 70 i 15222 Err codemadness.org 70 i 15226 Err codemadness.org 70 i 15227 Err codemadness.org 70 i 15228

Err codemadness.org 70 i 15223

./mtr --big-test --repeat=100 --parallel=auto rpl.rpl_semi_sync_skip_repl{,,,}	Err	codemadness.org	70
i 15224

Err codemadness.org 70 i 15225

Err codemadness.org 70 i 15229

Err codemadness.org 70 i 15230

Err codemadness.org 70 i 15231

Without the patch, this problem does not occur.

Err codemadness.org 70 i 15232 Err codemadness.org 70 i 15233

Note: I did not test whether the crash recovery now actually executes in the background. That could already be the case. The above patch is only trying to remove a read of every .ibd file when any crash recovery was needed.

Err codemadness.org 70 i 15234

Err codemadness.org 70 i 15236 Comment by Err codemadness.org 70 i 15237 Marko Mäkelä Err codemadness.org 70 i 15238 Err codemadness.org 70 i 15239 [ Err codemadness.org 70 i 15240 2019-02-04 Err codemadness.org 70 i 15241 Err codemadness.org 70 i 15242 ] Err codemadness.org 70 i 15243 Err codemadness.org 70 i 15244 Err codemadness.org 70 i 15245

Err codemadness.org 70 i 15247

It seems that in order to properly fix this, we must get rid of the separate buf_pool->flush_rbt and this code:

Err codemadness.org 70 i 15248

Err codemadness.org 70 i 15249

Err codemadness.org 70 i 15250 Err codemadness.org 70 i 15251 Err codemadness.org 70 i 15252 Err codemadness.org 70 i 15253 Err codemadness.org 70 i 15256 Err codemadness.org 70 i 15257 Err codemadness.org 70 i 15258 Err codemadness.org 70 i 15261 Err codemadness.org 70 i 15262 Err codemadness.org 70 i 15263 Err codemadness.org 70 i 15266 Err codemadness.org 70 i 15267 Err codemadness.org 70 i 15268 Err codemadness.org 70 i 15271 Err codemadness.org 70 i 15272 Err codemadness.org 70 i 15273 Err codemadness.org 70 i 15276 Err codemadness.org 70 i 15277 Err codemadness.org 70 i 15278 Err codemadness.org 70 i 15281 Err codemadness.org 70 i 15282 Err codemadness.org 70 i 15283 Err codemadness.org 70 i 15286 Err codemadness.org 70 i 15287 Err codemadness.org 70 i 15288 Err codemadness.org 70 i 15291 Err codemadness.org 70 i 15292 Err codemadness.org 70 i 15293 Err codemadness.org 70 i 15296 Err codemadness.org 70 i 15297 Err codemadness.org 70 i 15298 Err codemadness.org 70 i 15301 Err codemadness.org 70 i 15302 Err codemadness.org 70 i 15303 Err codemadness.org 70 i 15306 Err codemadness.org 70 i 15307 Err codemadness.org 70 i 15308 Err codemadness.org 70 i 15311 Err codemadness.org 70 i 15312 Err codemadness.org 70 i 15313 Err codemadness.org 70 i 15316 Err codemadness.org 70 i 15317 Err codemadness.org 70 i 15318 Err codemadness.org 70 i 15321 Err codemadness.org 70 i 15322 Err codemadness.org 70 i 15323 Err codemadness.org 70 i 15326 Err codemadness.org 70 i 15327 Err codemadness.org 70 i 15328 Err codemadness.org 70 i 15331 Err codemadness.org 70 i 15332 Err codemadness.org 70 i 15333 Err codemadness.org 70 i 15336 Err codemadness.org 70 i 15337 Err codemadness.org 70 i 15338 Err codemadness.org 70 i 15341 Err codemadness.org 70 i 15342 Err codemadness.org 70 i 15343 Err codemadness.org 70 i 15346 Err codemadness.org 70 i 15347 Err codemadness.org 70 i 15348 Err codemadness.org 70 i 15351 Err codemadness.org 70 i 15352 Err codemadness.org 70 i 15353 Err codemadness.org 70 i 15356 Err codemadness.org 70 i 15357 Err codemadness.org 70 i 15358 Err codemadness.org 70 i 15361 Err codemadness.org 70 i 15362 Err codemadness.org 70 i 15363 Err codemadness.org 70 i 15366 Err codemadness.org 70 i 15367 Err codemadness.org 70 i 15368 Err codemadness.org 70 i 15371 Err codemadness.org 70 i 15372 Err codemadness.org 70 i 15373 Err codemadness.org 70 i 15376 Err codemadness.org 70 i 15377 Err codemadness.org 70 i 15378 Err codemadness.org 70 i 15381 Err codemadness.org 70 i 15382 Err codemadness.org 70 i 15383 Err codemadness.org 70 i 15386 Err codemadness.org 70 i 15387 Err codemadness.org 70 i 15388 Err codemadness.org 70 i 15391 Err codemadness.org 70 i 15392 Err codemadness.org 70 i 15393 Err codemadness.org 70 i 15396 Err codemadness.org 70 i 15397 Err codemadness.org 70 i 15398 Err codemadness.org 70 i 15401 Err codemadness.org 70 i 15402 Err codemadness.org 70 i 15403 Err codemadness.org 70 i 15406 Err codemadness.org 70 i 15407 Err codemadness.org 70 i 15408 Err codemadness.org 70 i 15411 Err codemadness.org 70 i 15412 Err codemadness.org 70 i 15413 Err codemadness.org 70 i 15416 Err codemadness.org 70 i 15417 Err codemadness.org 70 i 15418 Err codemadness.org 70 i 15421 Err codemadness.org 70 i 15422 Err codemadness.org 70 i 15423 Err codemadness.org 70 i 15426 Err codemadness.org 70 i 15427 Err codemadness.org 70 i 15428 Err codemadness.org 70 i 15432 Err codemadness.org 70 i 15433 Err codemadness.org 70 i 15434

Err codemadness.org 70 i 15254

/** Complete recovery from a checkpoint. */

Err codemadness.org 70 i 15255

Err codemadness.org 70 i 15259

void

Err codemadness.org 70 i 15260

Err codemadness.org 70 i 15264

recv_recovery_from_checkpoint_finish(void)

Err codemadness.org 70 i 15265

Err codemadness.org 70 i 15269

Err codemadness.org 70 i 15270

Err codemadness.org 70 i 15274

        /* Make sure that the recv_writer thread is done. This is

Err codemadness.org 70 i 15275

Err codemadness.org 70 i 15279

        required because it grabs various mutexes and we want to

Err codemadness.org 70 i 15280

Err codemadness.org 70 i 15284

        ensure that when we enable sync_order_checks there is no

Err codemadness.org 70 i 15285

Err codemadness.org 70 i 15289

        mutex currently held by any thread. */

Err codemadness.org 70 i 15290

Err codemadness.org 70 i 15294

        mutex_enter(&recv_sys->writer_mutex);

Err codemadness.org 70 i 15295

Err codemadness.org 70 i 15299

Err codemadness.org 70 i 15300

Err codemadness.org 70 i 15304

        /* Free the resources of the recovery system */

Err codemadness.org 70 i 15305

Err codemadness.org 70 i 15309

        recv_recovery_on = false;

Err codemadness.org 70 i 15310

Err codemadness.org 70 i 15314

Err codemadness.org 70 i 15315

Err codemadness.org 70 i 15319

        /* By acquring the mutex we ensure that the recv_writer thread

Err codemadness.org 70 i 15320

Err codemadness.org 70 i 15324

        won't trigger any more LRU batches. Now wait for currently

Err codemadness.org 70 i 15325

Err codemadness.org 70 i 15329

        in progress batches to finish. */

Err codemadness.org 70 i 15330

Err codemadness.org 70 i 15334

        buf_flush_wait_LRU_batch_end();

Err codemadness.org 70 i 15335

Err codemadness.org 70 i 15339

Err codemadness.org 70 i 15340

Err codemadness.org 70 i 15344

        mutex_exit(&recv_sys->writer_mutex);

Err codemadness.org 70 i 15345

Err codemadness.org 70 i 15349

Err codemadness.org 70 i 15350

Err codemadness.org 70 i 15354

        ulint count = 0;

Err codemadness.org 70 i 15355

Err codemadness.org 70 i 15359

        while (recv_writer_thread_active) {

Err codemadness.org 70 i 15360

Err codemadness.org 70 i 15364

                ++count;

Err codemadness.org 70 i 15365

Err codemadness.org 70 i 15369

                os_thread_sleep(100000);

Err codemadness.org 70 i 15370

Err codemadness.org 70 i 15374

                if (srv_print_verbose_log && count > 600) {

Err codemadness.org 70 i 15375

Err codemadness.org 70 i 15379

                        ib::info() << "Waiting for recv_writer to"

Err codemadness.org 70 i 15380

Err codemadness.org 70 i 15384

                                " finish flushing of buffer pool";

Err codemadness.org 70 i 15385

Err codemadness.org 70 i 15389

                        count = 0;

Err codemadness.org 70 i 15390

Err codemadness.org 70 i 15394

Err codemadness.org 70 i 15395

Err codemadness.org 70 i 15399

Err codemadness.org 70 i 15400

Err codemadness.org 70 i 15404

Err codemadness.org 70 i 15405

Err codemadness.org 70 i 15409

        recv_sys_debug_free();

Err codemadness.org 70 i 15410

Err codemadness.org 70 i 15414

Err codemadness.org 70 i 15415

Err codemadness.org 70 i 15419

        /* Free up the flush_rbt. */

Err codemadness.org 70 i 15420

Err codemadness.org 70 i 15424

        buf_flush_free_flush_rbt();

Err codemadness.org 70 i 15425

Err codemadness.org 70 i 15429

}	Err	codemadness.org	70
i 15430

Err codemadness.org 70 i 15431

Err codemadness.org 70 i 15435

Err codemadness.org 70 i 15436

Err codemadness.org 70 i 15437

This buffer pool flush is unnecessarily forcing crash recovery to wait for all changes to be written back to the files. This flush would necessarily happen on the next redo log checkpoint. We must be careful to ensure that buf_page_t::oldest_modification is correctly set during crash recovery. The unnecessary flush happens before this point:

Err codemadness.org 70 i 15438

Err codemadness.org 70 i 15439

Err codemadness.org 70 i 15440 Err codemadness.org 70 i 15441 Err codemadness.org 70 i 15442 Err codemadness.org 70 i 15443 Err codemadness.org 70 i 15446 Err codemadness.org 70 i 15447 Err codemadness.org 70 i 15448 Err codemadness.org 70 i 15452 Err codemadness.org 70 i 15453 Err codemadness.org 70 i 15454

Err codemadness.org 70 i 15444

2019-02-04 13:34:57 0 [Note] InnoDB: 128 out of 128 rollback segments are active.

Err codemadness.org 70 i 15445

Err codemadness.org 70 i 15449

2019-02-04 13:34:57 0 [Note] InnoDB: Starting in background the rollback of recovered transactions	Err	codemadness.org	70
i 15450

Err codemadness.org 70 i 15451

Err codemadness.org 70 i 15455

Err codemadness.org 70 i 15456

Err codemadness.org 70 i 15457

There is no call to log_checkpoint() before the server has started accepting connections.

Err codemadness.org 70 i 15458 Err codemadness.org 70 i 15459

So, the main thing that needs to be done seems to be the merging of buf_pool->flush_list and buf_pool->flush_rbt, which should be a good idea on its own merit, to improve the InnoDB page flushing performance.

Err codemadness.org 70 i 15460

Err codemadness.org 70 i 15462 Comment by Err codemadness.org 70 i 15463 Marko Mäkelä Err codemadness.org 70 i 15464 Err codemadness.org 70 i 15465 [ Err codemadness.org 70 i 15466 2019-02-04 Err codemadness.org 70 i 15467 Err codemadness.org 70 i 15468 ] Err codemadness.org 70 i 15469 Err codemadness.org 70 i 15470 Err codemadness.org 70 i 15471

Err codemadness.org 70 i 15473

Merging flush_list and flush_rbt could be part of MDEV-16526.

Err codemadness.org 70 i 15474

Err codemadness.org 70 i 15476 Comment by Err codemadness.org 70 i 15477 Marko Mäkelä Err codemadness.org 70 i 15478 Err codemadness.org 70 i 15479 [ Err codemadness.org 70 i 15480 2019-03-22 Err codemadness.org 70 i 15481 Err codemadness.org 70 i 15482 ] Err codemadness.org 70 i 15483 Err codemadness.org 70 i 15484 Err codemadness.org 70 i 15485

Err codemadness.org 70 i 15487

As part of this, we should probably prevent anything from being added to the adaptive hash index before crash recovery has been completed. Alternatively, we should not omit calls to btr_search_drop_page_hash_index(block) while redo log is being applied.

Err codemadness.org 70 i 15488

Err codemadness.org 70 i 15490 Comment by Err codemadness.org 70 i 15491 Marko Mäkelä Err codemadness.org 70 i 15492 Err codemadness.org 70 i 15493 [ Err codemadness.org 70 i 15494 2019-04-05 Err codemadness.org 70 i 15495 Err codemadness.org 70 i 15496 ] Err codemadness.org 70 i 15497 Err codemadness.org 70 i 15498 Err codemadness.org 70 i 15499

Err codemadness.org 70 i 15501

~~MDEV-19514~~ defers change buffer merge to the moment when a user thread is requesting access to the page. There is no need to incur extra I/O during crash recovery or when pages are being subjected to read-ahead.

Err codemadness.org 70 i 15502

Err codemadness.org 70 i 15504 Comment by Err codemadness.org 70 i 15505 Marko Mäkelä Err codemadness.org 70 i 15506 Err codemadness.org 70 i 15507 [ Err codemadness.org 70 i 15508 2019-04-09 Err codemadness.org 70 i 15509 Err codemadness.org 70 i 15510 ] Err codemadness.org 70 i 15511 Err codemadness.org 70 i 15512 Err codemadness.org 70 i 15513

Err codemadness.org 70 i 15515

In ~~MDEV-18733~~, we removed the calls to open and read each table if crash recovery was needed. This was safe given that ~~MDEV-14717~~ made RENAME operations inside InnoDB crash-safe.

Err codemadness.org 70 i 15516

Err codemadness.org 70 i 15518 Comment by Err codemadness.org 70 i 15519 Marko Mäkelä Err codemadness.org 70 i 15520 Err codemadness.org 70 i 15521 [ Err codemadness.org 70 i 15522 2019-04-12 Err codemadness.org 70 i 15523 Err codemadness.org 70 i 15524 ] Err codemadness.org 70 i 15525 Err codemadness.org 70 i 15526 Err codemadness.org 70 i 15527

Err codemadness.org 70 i 15529

I removed the call to buf_page_invalidate() in ~~MDEV-13564~~ without remembering that I had noticed it being seemingly necessary in this ticket.

Err codemadness.org 70 i 15530 Err codemadness.org 70 i 15531

While Thirunarayanan Balathandayuthapani was working on MDEV-19229, he noticed that we are actually performing a dirty read of the TRX_SYS page before reading or applying any redo log. The dirty reads must be removed in MDEV-19229 and deferred to after recv_recovery_from_checkpoint_start() has returned. Until then, we must call buf_pool_invalidate() to work around the bug.

Err codemadness.org 70 i 15532

Err codemadness.org 70 i 15534 Comment by Err codemadness.org 70 i 15535 Marko Mäkelä Err codemadness.org 70 i 15536 Err codemadness.org 70 i 15537 [ Err codemadness.org 70 i 15538 2019-11-05 Err codemadness.org 70 i 15539 Err codemadness.org 70 i 15540 ] Err codemadness.org 70 i 15541 Err codemadness.org 70 i 15542 Err codemadness.org 70 i 15543

Err codemadness.org 70 i 15545

As part of this work, we must remove the variable recv_lsn_checks_on and improve buf_page_check_lsn() so that any pending log records in recv_sys will be considered.

Err codemadness.org 70 i 15546

Err codemadness.org 70 i 15548 Comment by Err codemadness.org 70 i 15549 Marko Mäkelä Err codemadness.org 70 i 15550 Err codemadness.org 70 i 15551 [ Err codemadness.org 70 i 15552 2019-12-04 Err codemadness.org 70 i 15553 Err codemadness.org 70 i 15554 ] Err codemadness.org 70 i 15555 Err codemadness.org 70 i 15556 Err codemadness.org 70 i 15557

Err codemadness.org 70 i 15559

Here is a simple test case:

Err codemadness.org 70 i 15560

Err codemadness.org 70 i 15561

Err codemadness.org 70 i 15562 Err codemadness.org 70 i 15563 Err codemadness.org 70 i 15564 Err codemadness.org 70 i 15565 Err codemadness.org 70 i 15568 Err codemadness.org 70 i 15569 Err codemadness.org 70 i 15570 Err codemadness.org 70 i 15573 Err codemadness.org 70 i 15574 Err codemadness.org 70 i 15575 Err codemadness.org 70 i 15578 Err codemadness.org 70 i 15579 Err codemadness.org 70 i 15580 Err codemadness.org 70 i 15583 Err codemadness.org 70 i 15584 Err codemadness.org 70 i 15585 Err codemadness.org 70 i 15588 Err codemadness.org 70 i 15589 Err codemadness.org 70 i 15590 Err codemadness.org 70 i 15593 Err codemadness.org 70 i 15594 Err codemadness.org 70 i 15595 Err codemadness.org 70 i 15598 Err codemadness.org 70 i 15599 Err codemadness.org 70 i 15600 Err codemadness.org 70 i 15603 Err codemadness.org 70 i 15604 Err codemadness.org 70 i 15605 Err codemadness.org 70 i 15608 Err codemadness.org 70 i 15609 Err codemadness.org 70 i 15610 Err codemadness.org 70 i 15613 Err codemadness.org 70 i 15614 Err codemadness.org 70 i 15615 Err codemadness.org 70 i 15618 Err codemadness.org 70 i 15619 Err codemadness.org 70 i 15620 Err codemadness.org 70 i 15623 Err codemadness.org 70 i 15624 Err codemadness.org 70 i 15625 Err codemadness.org 70 i 15628 Err codemadness.org 70 i 15629 Err codemadness.org 70 i 15630 Err codemadness.org 70 i 15634 Err codemadness.org 70 i 15635 Err codemadness.org 70 i 15636

Err codemadness.org 70 i 15566

--source include/have_innodb.inc

Err codemadness.org 70 i 15567

Err codemadness.org 70 i 15571

--source include/have_sequence.inc

Err codemadness.org 70 i 15572

Err codemadness.org 70 i 15576

Err codemadness.org 70 i 15577

Err codemadness.org 70 i 15581

CREATE TABLE t1(a SERIAL, b CHAR(255) NOT NULL, c CHAR(255) NOT NULL)

Err codemadness.org 70 i 15582

Err codemadness.org 70 i 15586

ENGINE=InnoDB DEFAULT CHARSET utf8mb4;

Err codemadness.org 70 i 15587

Err codemadness.org 70 i 15591

Err codemadness.org 70 i 15592

Err codemadness.org 70 i 15596

INSERT INTO t1 SELECT (seq % 256) * 1048576 + (seq / 256),'',''

Err codemadness.org 70 i 15597

Err codemadness.org 70 i 15601

FROM seq_1_to_100000;

Err codemadness.org 70 i 15602

Err codemadness.org 70 i 15606

--let $shutdown_timeout=0

Err codemadness.org 70 i 15607

Err codemadness.org 70 i 15611

--source include/restart_mysqld.inc

Err codemadness.org 70 i 15612

Err codemadness.org 70 i 15616

SELECT now();

Err codemadness.org 70 i 15617

Err codemadness.org 70 i 15621

SELECT COUNT(*) FROM t1;

Err codemadness.org 70 i 15622

Err codemadness.org 70 i 15626

SELECT now();

Err codemadness.org 70 i 15627

Err codemadness.org 70 i 15631

DROP TABLE t1;	Err	codemadness.org	70
i 15632

Err codemadness.org 70 i 15633

Err codemadness.org 70 i 15637

Err codemadness.org 70 i 15638

Err codemadness.org 70 i 15639

And here is some instrumentation that attempts to artificially delay the last recovery batch by 10 seconds, so that it could finish some time after we have started executing SQL:

Err codemadness.org 70 i 15640

Err codemadness.org 70 i 15641

Err codemadness.org 70 i 15642 Err codemadness.org 70 i 15643 Err codemadness.org 70 i 15644 Err codemadness.org 70 i 15645 Err codemadness.org 70 i 15648 Err codemadness.org 70 i 15649 Err codemadness.org 70 i 15650 Err codemadness.org 70 i 15653 Err codemadness.org 70 i 15654 Err codemadness.org 70 i 15655 Err codemadness.org 70 i 15658 Err codemadness.org 70 i 15659 Err codemadness.org 70 i 15660 Err codemadness.org 70 i 15663 Err codemadness.org 70 i 15664 Err codemadness.org 70 i 15665 Err codemadness.org 70 i 15668 Err codemadness.org 70 i 15669 Err codemadness.org 70 i 15670 Err codemadness.org 70 i 15673 Err codemadness.org 70 i 15674 Err codemadness.org 70 i 15675 Err codemadness.org 70 i 15678 Err codemadness.org 70 i 15679 Err codemadness.org 70 i 15680 Err codemadness.org 70 i 15683 Err codemadness.org 70 i 15684 Err codemadness.org 70 i 15685 Err codemadness.org 70 i 15688 Err codemadness.org 70 i 15689 Err codemadness.org 70 i 15690 Err codemadness.org 70 i 15693 Err codemadness.org 70 i 15694 Err codemadness.org 70 i 15695 Err codemadness.org 70 i 15698 Err codemadness.org 70 i 15699 Err codemadness.org 70 i 15700 Err codemadness.org 70 i 15703 Err codemadness.org 70 i 15704 Err codemadness.org 70 i 15705 Err codemadness.org 70 i 15708 Err codemadness.org 70 i 15709 Err codemadness.org 70 i 15710 Err codemadness.org 70 i 15713 Err codemadness.org 70 i 15714 Err codemadness.org 70 i 15715 Err codemadness.org 70 i 15718 Err codemadness.org 70 i 15719 Err codemadness.org 70 i 15720 Err codemadness.org 70 i 15724 Err codemadness.org 70 i 15725 Err codemadness.org 70 i 15726

Err codemadness.org 70 i 15646

diff --git a/storage/innobase/log/log0recv.cc b/storage/innobase/log/log0recv.cc

Err codemadness.org 70 i 15647

Err codemadness.org 70 i 15651

index 5d41ff1fb03..585654028c7 100644

Err codemadness.org 70 i 15652

Err codemadness.org 70 i 15656

--- a/storage/innobase/log/log0recv.cc

Err codemadness.org 70 i 15657

Err codemadness.org 70 i 15661

+++ b/storage/innobase/log/log0recv.cc

Err codemadness.org 70 i 15662

Err codemadness.org 70 i 15666

@@ -2318,6 +2318,11 @@ void recv_apply_hashed_log_recs(bool last_batch)

Err codemadness.org 70 i 15667

Err codemadness.org 70 i 15671

                 mlog_init.mark_ibuf_exist(mtr);

Err codemadness.org 70 i 15672

Err codemadness.org 70 i 15676

Err codemadness.org 70 i 15677

Err codemadness.org 70 i 15681

Err codemadness.org 70 i 15682

Err codemadness.org 70 i 15686

+        if (last_batch) {

Err codemadness.org 70 i 15687

Err codemadness.org 70 i 15691

+                ib::info() << "sleep at the end of recovery batch";

Err codemadness.org 70 i 15692

Err codemadness.org 70 i 15696

+                os_thread_sleep(10000000);

Err codemadness.org 70 i 15697

Err codemadness.org 70 i 15701

+                ib::info() << "end of sleep and recovery batch";

Err codemadness.org 70 i 15702

Err codemadness.org 70 i 15706

+        }

Err codemadness.org 70 i 15707

Err codemadness.org 70 i 15711

         recv_sys.apply_log_recs = false;

Err codemadness.org 70 i 15712

Err codemadness.org 70 i 15716

         recv_sys.apply_batch_on = false;

Err codemadness.org 70 i 15717

Err codemadness.org 70 i 15721

 	Err	codemadness.org	70
i 15722

Err codemadness.org 70 i 15723

Err codemadness.org 70 i 15727

Err codemadness.org 70 i 15728

Err codemadness.org 70 i 15729

The output currently looks like this, for an invocation like this. I thought that it would be a good idea to disable log checkpoints, to slow down recovery further:

Err codemadness.org 70 i 15730

Err codemadness.org 70 i 15731

Err codemadness.org 70 i 15732 Err codemadness.org 70 i 15733 Err codemadness.org 70 i 15734 Err codemadness.org 70 i 15735 Err codemadness.org 70 i 15739 Err codemadness.org 70 i 15740 Err codemadness.org 70 i 15741

Err codemadness.org 70 i 15736

./mtr --mysqld=--debug=d,ib_log_checkpoint_avoid innodb.mdev-14481	Err	codemadness.org	70
i 15737

Err codemadness.org 70 i 15738

Err codemadness.org 70 i 15742

Err codemadness.org 70 i 15743

Err codemadness.org 70 i 15744

Err codemadness.org 70 i 15745

Err codemadness.org 70 i 15746 Err codemadness.org 70 i 15747 Err codemadness.org 70 i 15748 Err codemadness.org 70 i 15749 Err codemadness.org 70 i 15752 Err codemadness.org 70 i 15753 Err codemadness.org 70 i 15754 Err codemadness.org 70 i 15755 Err codemadness.org 70 i 15756 Err codemadness.org 70 i 15759 Err codemadness.org 70 i 15760 Err codemadness.org 70 i 15761 Err codemadness.org 70 i 15764 Err codemadness.org 70 i 15765 Err codemadness.org 70 i 15766 Err codemadness.org 70 i 15769 Err codemadness.org 70 i 15770 Err codemadness.org 70 i 15771 Err codemadness.org 70 i 15774 Err codemadness.org 70 i 15775 Err codemadness.org 70 i 15776 Err codemadness.org 70 i 15779 Err codemadness.org 70 i 15780 Err codemadness.org 70 i 15781 Err codemadness.org 70 i 15784 Err codemadness.org 70 i 15785 Err codemadness.org 70 i 15786 Err codemadness.org 70 i 15789 Err codemadness.org 70 i 15790 Err codemadness.org 70 i 15791 Err codemadness.org 70 i 15794 Err codemadness.org 70 i 15795 Err codemadness.org 70 i 15796 Err codemadness.org 70 i 15799 Err codemadness.org 70 i 15800 Err codemadness.org 70 i 15801 Err codemadness.org 70 i 15804 Err codemadness.org 70 i 15805 Err codemadness.org 70 i 15806 Err codemadness.org 70 i 15809 Err codemadness.org 70 i 15810 Err codemadness.org 70 i 15811 Err codemadness.org 70 i 15814 Err codemadness.org 70 i 15815 Err codemadness.org 70 i 15816 Err codemadness.org 70 i 15819 Err codemadness.org 70 i 15820 Err codemadness.org 70 i 15821 Err codemadness.org 70 i 15824 Err codemadness.org 70 i 15825 Err codemadness.org 70 i 15826 Err codemadness.org 70 i 15830 Err codemadness.org 70 i 15831 Err codemadness.org 70 i 15832

Err codemadness.org 70 i 15750 10.5 6b5cdd4ff745e3254cb05935bd1efa4b48a29549 Err codemadness.org 70 i 15751
Err codemadness.org 70 i 15757 CREATE TABLE t1(a SERIAL, b CHAR(255) NOT NULL, c CHAR(255) NOT NULL) Err codemadness.org 70 i 15758
Err codemadness.org 70 i 15762 ENGINE=InnoDB DEFAULT CHARSET utf8mb4; Err codemadness.org 70 i 15763
Err codemadness.org 70 i 15767 INSERT INTO t1 SELECT (seq % 256) * 1048576 + (seq / 256),'','' Err codemadness.org 70 i 15768
Err codemadness.org 70 i 15772 FROM seq_1_to_100000; Err codemadness.org 70 i 15773
Err codemadness.org 70 i 15777 # restart Err codemadness.org 70 i 15778
Err codemadness.org 70 i 15782 SELECT now(); Err codemadness.org 70 i 15783
Err codemadness.org 70 i 15787 now() Err codemadness.org 70 i 15788
Err codemadness.org 70 i 15792 2019-12-04 15:41:05 Err codemadness.org 70 i 15793
Err codemadness.org 70 i 15797 SELECT COUNT(*) FROM t1; Err codemadness.org 70 i 15798
Err codemadness.org 70 i 15802 COUNT(*) Err codemadness.org 70 i 15803
Err codemadness.org 70 i 15807 100000 Err codemadness.org 70 i 15808
Err codemadness.org 70 i 15812 SELECT now(); Err codemadness.org 70 i 15813
Err codemadness.org 70 i 15817 now() Err codemadness.org 70 i 15818
Err codemadness.org 70 i 15822 2019-12-04 15:41:06 Err codemadness.org 70 i 15823
Err codemadness.org 70 i 15827 DROP TABLE t1; Err codemadness.org 70 i 15828 Err codemadness.org 70 i 15829

Err codemadness.org 70 i 15833

Err codemadness.org 70 i 15834

Err codemadness.org 70 i 15835

We would hope the now() time stamps to prove that the SQL was running concurrently with the last crash recovery batch. Currently, that is not the case, but instead the 10-second sleep that our instrumentation introduced is delaying the InnoDB startup:

Err codemadness.org 70 i 15836

Err codemadness.org 70 i 15837

Err codemadness.org 70 i 15838 Err codemadness.org 70 i 15839 Err codemadness.org 70 i 15840 Err codemadness.org 70 i 15841 Err codemadness.org 70 i 15844 Err codemadness.org 70 i 15845 Err codemadness.org 70 i 15846 Err codemadness.org 70 i 15849 Err codemadness.org 70 i 15850 Err codemadness.org 70 i 15851 Err codemadness.org 70 i 15854 Err codemadness.org 70 i 15855 Err codemadness.org 70 i 15856 Err codemadness.org 70 i 15859 Err codemadness.org 70 i 15860 Err codemadness.org 70 i 15861 Err codemadness.org 70 i 15864 Err codemadness.org 70 i 15865 Err codemadness.org 70 i 15866 Err codemadness.org 70 i 15869 Err codemadness.org 70 i 15870 Err codemadness.org 70 i 15871 Err codemadness.org 70 i 15874 Err codemadness.org 70 i 15875 Err codemadness.org 70 i 15876 Err codemadness.org 70 i 15879 Err codemadness.org 70 i 15880 Err codemadness.org 70 i 15881 Err codemadness.org 70 i 15884 Err codemadness.org 70 i 15885 Err codemadness.org 70 i 15886 Err codemadness.org 70 i 15889 Err codemadness.org 70 i 15890 Err codemadness.org 70 i 15891 Err codemadness.org 70 i 15894 Err codemadness.org 70 i 15895 Err codemadness.org 70 i 15896 Err codemadness.org 70 i 15899 Err codemadness.org 70 i 15900 Err codemadness.org 70 i 15901 Err codemadness.org 70 i 15905 Err codemadness.org 70 i 15906 Err codemadness.org 70 i 15907

Err codemadness.org 70 i 15842

2019-12-04 15:40:53 0 [Note] InnoDB: Starting crash recovery from checkpoint LSN=58294800

Err codemadness.org 70 i 15843

Err codemadness.org 70 i 15847

2019-12-04 15:40:53 0 [Note] InnoDB: Starting a batch to recover 580 pages from redo log.

Err codemadness.org 70 i 15848

Err codemadness.org 70 i 15852

2019-12-04 15:40:53 0 [Note] InnoDB: Starting a batch to recover 311 pages from redo log.

Err codemadness.org 70 i 15853

Err codemadness.org 70 i 15857

2019-12-04 15:40:54 0 [Note] InnoDB: Starting a batch to recover 712 pages from redo log.

Err codemadness.org 70 i 15858

Err codemadness.org 70 i 15862

2019-12-04 15:40:54 0 [Note] InnoDB: Starting final batch to recover 307 pages from redo log.

Err codemadness.org 70 i 15863

Err codemadness.org 70 i 15867

2019-12-04 15:40:54 0 [Note] InnoDB: sleep at the end of recovery batch

Err codemadness.org 70 i 15868

Err codemadness.org 70 i 15872

2019-12-04 15:41:04 0 [Note] InnoDB: end of sleep and recovery batch

Err codemadness.org 70 i 15873

Err codemadness.org 70 i 15877

2019-12-04 15:41:05 0 [Note] InnoDB: 128 rollback segments are active.

Err codemadness.org 70 i 15878

Err codemadness.org 70 i 15882

2019-12-04 15:41:05 0 [Note] InnoDB: Removed temporary tablespace data file: "ibtmp1"

Err codemadness.org 70 i 15883

Err codemadness.org 70 i 15887

2019-12-04 15:41:05 0 [Note] InnoDB: Creating shared tablespace for temporary tables

Err codemadness.org 70 i 15888

Err codemadness.org 70 i 15892

2019-12-04 15:41:05 0 [Note] InnoDB: Setting file './ibtmp1' size to 12 MB. Physically writing the file full; Please wait ...

Err codemadness.org 70 i 15893

Err codemadness.org 70 i 15897

2019-12-04 15:41:05 0 [Note] InnoDB: File './ibtmp1' size is now 12 MB.

Err codemadness.org 70 i 15898

Err codemadness.org 70 i 15902

2019-12-04 15:41:05 0 [Note] InnoDB: 10.5.1 started; log sequence number 63689195; transaction id 35	Err	codemadness.org	70
i 15903

Err codemadness.org 70 i 15904

Err codemadness.org 70 i 15908

Err codemadness.org 70 i 15909

Err codemadness.org 70 i 15910

Err codemadness.org 70 i 15912 Comment by Err codemadness.org 70 i 15913 zhai weixiang Err codemadness.org 70 i 15914 Err codemadness.org 70 i 15915 [ Err codemadness.org 70 i 15916 2019-12-05 Err codemadness.org 70 i 15917 Err codemadness.org 70 i 15918 ] Err codemadness.org 70 i 15919 Err codemadness.org 70 i 15920 Err codemadness.org 70 i 15921

Err codemadness.org 70 i 15923

I used to implement a similar feature. just write a note of bug i hitted: during runtime , it may create a new page without reading from disk, so the pending redo log is not applied. If foreground thread modified the page in memory, and after that the background thread may apply redo to it and take it back to older version....

Err codemadness.org 70 i 15924

Err codemadness.org 70 i 15926 Comment by Err codemadness.org 70 i 15927 Marko Mäkelä Err codemadness.org 70 i 15928 Err codemadness.org 70 i 15929 [ Err codemadness.org 70 i 15930 2019-12-05 Err codemadness.org 70 i 15931 Err codemadness.org 70 i 15932 ] Err codemadness.org 70 i 15933 Err codemadness.org 70 i 15934 Err codemadness.org 70 i 15935

Err codemadness.org 70 i 15937

zhai weixiang, your comment reminds me of ~~MDEV-12699~~, which avoids unnecessary page reads during crash recovery. If a page is not read into the buffer pool, a change buffer merge (or the deletion of stale buffered changes) may be necessary. We refined that logic further in ~~MDEV-19514~~.

Err codemadness.org 70 i 15938 Err codemadness.org 70 i 15939

I think that the scenario that you mention should be prevented if a call to buf_page_create() from other than the recovery code will discard any buffered redo log for the page. Actually, in the scenario, there should have been a MLOG_INIT_FREE_PAGE record (~~MDEV-15528~~) for marking the page as free. As soon as it is durably written to the redo log, we can safely remove any buffered redo log for the page. Similarly, if recovery finds a MLOG_INIT_FREE_PAGE record, it can immediately discard any preceding log records for the page.

Err codemadness.org 70 i 15940

Err codemadness.org 70 i 15942 Comment by Err codemadness.org 70 i 15943 Marko Mäkelä Err codemadness.org 70 i 15944 Err codemadness.org 70 i 15945 [ Err codemadness.org 70 i 15946 2019-12-06 Err codemadness.org 70 i 15947 Err codemadness.org 70 i 15948 ] Err codemadness.org 70 i 15949 Err codemadness.org 70 i 15950 Err codemadness.org 70 i 15951

Err codemadness.org 70 i 15953

When we enable recovery in the background, we will also allow buffer pool resizing during recovery. It could be simplest to disallow the buffer pool from shrinking before recovery has been completed. The parsed redo log records are currently stored in the buffer pool, in BUF_BLOCK_STATE_MEMORY blocks.

Err codemadness.org 70 i 15954 Err codemadness.org 70 i 15955

If we allow recovery with innodb_read_only (MDEV-12700), the recovered redo log records would have to be buffered indefinitely, because the dirty pages would never be written back to the data files. If we allow dirty pages to be evicted from the buffer pool, we must be able to re-apply the records every time the affected page is reloaded to the buffer pool.

Err codemadness.org 70 i 15956

Err codemadness.org 70 i 15958 Comment by Err codemadness.org 70 i 15959 Marko Mäkelä Err codemadness.org 70 i 15960 Err codemadness.org 70 i 15961 [ Err codemadness.org 70 i 15962 2020-02-16 Err codemadness.org 70 i 15963 Err codemadness.org 70 i 15964 ] Err codemadness.org 70 i 15965 Err codemadness.org 70 i 15966 Err codemadness.org 70 i 15967

Err codemadness.org 70 i 15969

As part of this task, we must remove or rewrite most conditions on recv_recovery_is_on().

Err codemadness.org 70 i 15970

Err codemadness.org 70 i 15972 Comment by Err codemadness.org 70 i 15973 Marko Mäkelä Err codemadness.org 70 i 15974 Err codemadness.org 70 i 15975 [ Err codemadness.org 70 i 15976 2020-02-26 Err codemadness.org 70 i 15977 Err codemadness.org 70 i 15978 ] Err codemadness.org 70 i 15979 Err codemadness.org 70 i 15980 Err codemadness.org 70 i 15981

Err codemadness.org 70 i 15983

As part of this task, we should think what to do about innodb_force_recovery. If recovery is executed on the background, we would no longer be able to abort startup because of a corrupted page. We could still abort because of a corrupted log record.

Err codemadness.org 70 i 15984 Err codemadness.org 70 i 15985

If innodb_force_recovery is not set, the expectation should be that no data will be lost, and something could be done to fix the corruption (say, mount a file system where a data file was stored) and to restart the recovery. This could imply that innodb_force_recovery=0 (the default setting) must prevent log checkpoints from being executed until everything has been fully recovered. Users could explicitly SET GLOBAL innodb_force_recovery=1 to ‘unblock’ the database.

Err codemadness.org 70 i 15986 Err codemadness.org 70 i 15987

Executing recovery in the background might raise further the importance of page corruption handling (MDEV-13542).

Err codemadness.org 70 i 15988

Err codemadness.org 70 i 15990 Comment by Err codemadness.org 70 i 15991 Marko Mäkelä Err codemadness.org 70 i 15992 Err codemadness.org 70 i 15993 [ Err codemadness.org 70 i 15994 2020-08-03 Err codemadness.org 70 i 15995 Err codemadness.org 70 i 15996 ] Err codemadness.org 70 i 15997 Err codemadness.org 70 i 15998 Err codemadness.org 70 i 15999

Err codemadness.org 70 i 16001

The use of the predicate srv_startup_is_before_trx_rollback_phase to disable read-ahead in buf0rea.cc will likely have to be replaced in this task, because we could reset that predicate before the redo log apply completes. In fact, if we are running with innodb_read_only=ON, we could complete the rollback of recovered transactions in the buffer pool while redo log for some other pages might still not have been applied. (In that mode, we would not write anything to the redo log or to the data files; we could recovered pages in the buffer pool.)

Err codemadness.org 70 i 16002

Err codemadness.org 70 i 16004 Comment by Err codemadness.org 70 i 16005 Marko Mäkelä Err codemadness.org 70 i 16006 Err codemadness.org 70 i 16007 [ Err codemadness.org 70 i 16008 2020-10-28 Err codemadness.org 70 i 16009 Err codemadness.org 70 i 16010 ] Err codemadness.org 70 i 16011 Err codemadness.org 70 i 16012 Err codemadness.org 70 i 16013

Err codemadness.org 70 i 16015

This was blocked by ~~MDEV-23399~~.

Err codemadness.org 70 i 16016

Err codemadness.org 70 i 16018 Comment by Err codemadness.org 70 i 16019 Marko Mäkelä Err codemadness.org 70 i 16020 Err codemadness.org 70 i 16021 [ Err codemadness.org 70 i 16022 2021-10-27 Err codemadness.org 70 i 16023 Err codemadness.org 70 i 16024 ] Err codemadness.org 70 i 16025 Err codemadness.org 70 i 16026 Err codemadness.org 70 i 16027

Err codemadness.org 70 i 16029

Many preparations for this task were already done in ~~MDEV-23855~~ and some related work.

Err codemadness.org 70 i 16030 Err codemadness.org 70 i 16031

In the last batch in recv_sys_t::apply(bool last_batch), we would want to sort the buf_pool.flush_list instead of emptying it (buf_flush_sync()). That could possibly be done as a separate bug fix (to speed up startup in 10.5+ when crash recovery is needed).

Err codemadness.org 70 i 16032

Err codemadness.org 70 i 16034

[MDEV-26238] Remove inconsistent behaviour of --default-* options in my_print_defaults

Rucha Deodhar — Thu, 18 Nov 2021 18:46:07 +0000

Err codemadness.org 70 i 16110 Err codemadness.org 70 i 16111 Err codemadness.org 70 i 16120 Err codemadness.org 70 i 16121 Err codemadness.org 70 i 16122 Err codemadness.org 70 i 16123 Err codemadness.org 70 i 16124 Err codemadness.org 70 i 16125 Err codemadness.org 70 i 16126 Err codemadness.org 70 i 16127 Err codemadness.org 70 i 16128 Err codemadness.org 70 i 16129 Err codemadness.org 70 i 16130 Err codemadness.org 70 i 16131 Err codemadness.org 70 i 16132 Err codemadness.org 70 i 16135 Err codemadness.org 70 i 16136 Err codemadness.org 70 i 16137 Err codemadness.org 70 i 16138 Err codemadness.org 70 i 16139 Err codemadness.org 70 i 16140 Err codemadness.org 70 i 16141 Err codemadness.org 70 i 16142 Err codemadness.org 70 i 16144 Err codemadness.org 70 i 16145 Err codemadness.org 70 i 16146

Err codemadness.org 70 i 16112 Err codemadness.org 70 i 16113 [MDEV-26238] Remove inconsistent behaviour of --default-* options in my_print_defaults Err codemadness.org 70 i 16114 Err codemadness.org 70 i 16115 Created: 2021-07-26 Updated: 2021-11-18 Err codemadness.org 70 i 16116 Err codemadness.org 70 i 16117 Err codemadness.org 70 i 16118 Err codemadness.org 70 i 16119
Status:	Stalled
Project:	MariaDB Server
Component/s:	Err codemadness.org 70 i 16133 None Err codemadness.org 70 i 16134
Fix Version/s:	Err codemadness.org 70 i 16143 10.8

Err codemadness.org 70 i 16147 Err codemadness.org 70 i 16148

Err codemadness.org 70 i 16149 Err codemadness.org 70 i 16150 Err codemadness.org 70 i 16151 Err codemadness.org 70 i 16154 Err codemadness.org 70 i 16157 Err codemadness.org 70 i 16158 Err codemadness.org 70 i 16161 Err codemadness.org 70 i 16164 Err codemadness.org 70 i 16165 Err codemadness.org 70 i 16166 Err codemadness.org 70 i 16169 Err codemadness.org 70 i 16172 Err codemadness.org 70 i 16173 Err codemadness.org 70 i 16176 Err codemadness.org 70 i 16179 Err codemadness.org 70 i 16180 Err codemadness.org 70 i 16181 Err codemadness.org 70 i 16184 Err codemadness.org 70 i 16187 Err codemadness.org 70 i 16190 Err codemadness.org 70 i 16193 Err codemadness.org 70 i 16194 Err codemadness.org 70 i 16195 Err codemadness.org 70 i 16196 Err codemadness.org 70 i 16197 Err codemadness.org 70 i 16200 Err codemadness.org 70 i 16203 Err codemadness.org 70 i 16204 Err codemadness.org 70 i 16205 Err codemadness.org 70 i 16206 Err codemadness.org 70 i 16207 Err codemadness.org 70 i 16208 Err codemadness.org 70 i 16209

Err codemadness.org 70 i 16152 Type: Err codemadness.org 70 i 16153

Err codemadness.org 70 i 16155 Task Err codemadness.org 70 i 16156

Err codemadness.org 70 i 16159 Priority: Err codemadness.org 70 i 16160

Err codemadness.org 70 i 16162 Critical Err codemadness.org 70 i 16163

Err codemadness.org 70 i 16167 Reporter: Err codemadness.org 70 i 16168

Err codemadness.org 70 i 16170 Rucha Deodhar Err codemadness.org 70 i 16171

Err codemadness.org 70 i 16174 Assignee: Err codemadness.org 70 i 16175

Err codemadness.org 70 i 16177 Rucha Deodhar Err codemadness.org 70 i 16178

Err codemadness.org 70 i 16182 Resolution: Err codemadness.org 70 i 16183

Err codemadness.org 70 i 16185 Unresolved Err codemadness.org 70 i 16186

Err codemadness.org 70 i 16188 Votes: Err codemadness.org 70 i 16189

Err codemadness.org 70 i 16191 0 Err codemadness.org 70 i 16192

Err codemadness.org 70 i 16198 Labels: Err codemadness.org 70 i 16199

Err codemadness.org 70 i 16201 None Err codemadness.org 70 i 16202

Err codemadness.org 70 i 16210 Err codemadness.org 70 i 16211 Err codemadness.org 70 i 16212 Err codemadness.org 70 i 16213

Err codemadness.org 70 i 16214 Err codemadness.org 70 i 16215 Err codemadness.org 70 i 16216 Err codemadness.org 70 i 16217 Err codemadness.org 70 i 16218 Err codemadness.org 70 i 16219 Err codemadness.org 70 i 16220 Err codemadness.org 70 i 16223 Err codemadness.org 70 i 16247 Err codemadness.org 70 i 16248 Err codemadness.org 70 i 16249 Err codemadness.org 70 i 16250 Err codemadness.org 70 i 16251 Err codemadness.org 70 i 16252

Err codemadness.org 70 i 16221 Issue Links: Err codemadness.org 70 i 16222

Err codemadness.org 70 i 16224 Err codemadness.org 70 i 16225 Err codemadness.org 70 i 16226 Err codemadness.org 70 i 16229 Err codemadness.org 70 i 16230 Err codemadness.org 70 i 16231 Err codemadness.org 70 i 16234 Err codemadness.org 70 i 16238 Err codemadness.org 70 i 16241 Err codemadness.org 70 i 16244 Err codemadness.org 70 i 16245

Err codemadness.org 70 i 16227 Relates Err codemadness.org 70 i 16228
Err codemadness.org 70 i 16232 relates to Err codemadness.org 70 i 16233	Err codemadness.org 70 i 16235 Err codemadness.org 70 i 16236 ~~MDEV-25908~~ Err codemadness.org 70 i 16237	Err codemadness.org 70 i 16239 -e does not work for my_print_defaults Err codemadness.org 70 i 16240	Err codemadness.org 70 i 16242 Closed Err codemadness.org 70 i 16243

Err codemadness.org 70 i 16246

Err codemadness.org 70 i 16253 Err codemadness.org 70 i 16254

Err codemadness.org 70 i 16255 Err codemadness.org 70 i 16256 Err codemadness.org 70 i 16257 Err codemadness.org 70 i 16258 Err codemadness.org 70 i 16261 Err codemadness.org 70 i 16262 Err codemadness.org 70 i 16263

Err codemadness.org 70 i 16259 Description Err codemadness.org 70 i 16260

Err codemadness.org 70 i 16264 Err codemadness.org 70 i 16265 Err codemadness.org 70 i 16266 Err codemadness.org 70 i 16267 Err codemadness.org 70 i 16271 Err codemadness.org 70 i 16272

Err codemadness.org 70 i 16268

Fix options in my_print_defaults so that it is consistent with other tools.

Err codemadness.org 70 i 16269

Err codemadness.org 70 i 16270

Err codemadness.org 70 i 16273 Err codemadness.org 70 i 16274

Err codemadness.org 70 i 16275 Err codemadness.org 70 i 16276 Err codemadness.org 70 i 16277 Err codemadness.org 70 i 16278 Err codemadness.org 70 i 16281 Err codemadness.org 70 i 16282 Err codemadness.org 70 i 16283

Err codemadness.org 70 i 16279 Comments Err codemadness.org 70 i 16280

Err codemadness.org 70 i 16284 Err codemadness.org 70 i 16285 Err codemadness.org 70 i 16286 Err codemadness.org 70 i 16297 Err codemadness.org 70 i 16301

Err codemadness.org 70 i 16287 Comment by Err codemadness.org 70 i 16288 Rucha Deodhar Err codemadness.org 70 i 16289 Err codemadness.org 70 i 16290 [ Err codemadness.org 70 i 16291 2021-09-03 Err codemadness.org 70 i 16292 Err codemadness.org 70 i 16293 ] Err codemadness.org 70 i 16294 Err codemadness.org 70 i 16295 Err codemadness.org 70 i 16296

Err codemadness.org 70 i 16298

Patch:

Err codemadness.org 70 i 16299 https://github.com/MariaDB/server/commit/4492c869f313ef2ada94459707399e6d89ab46ac

Err codemadness.org 70 i 16300

Err codemadness.org 70 i 16302

[MDEV-24821] Encryption loading fails while running the suite

Thirunarayanan Balathandayuthapani — Thu, 18 Nov 2021 16:11:10 +0000

Err codemadness.org 70 i 16378 Err codemadness.org 70 i 16379 Err codemadness.org 70 i 16388 Err codemadness.org 70 i 16389 Err codemadness.org 70 i 16390 Err codemadness.org 70 i 16391 Err codemadness.org 70 i 16392 Err codemadness.org 70 i 16393 Err codemadness.org 70 i 16394 Err codemadness.org 70 i 16395 Err codemadness.org 70 i 16396 Err codemadness.org 70 i 16397 Err codemadness.org 70 i 16398 Err codemadness.org 70 i 16399 Err codemadness.org 70 i 16400 Err codemadness.org 70 i 16402 Err codemadness.org 70 i 16403 Err codemadness.org 70 i 16404 Err codemadness.org 70 i 16405 Err codemadness.org 70 i 16406 Err codemadness.org 70 i 16407 Err codemadness.org 70 i 16409 Err codemadness.org 70 i 16410 Err codemadness.org 70 i 16411 Err codemadness.org 70 i 16412 Err codemadness.org 70 i 16413 Err codemadness.org 70 i 16414 Err codemadness.org 70 i 16416 Err codemadness.org 70 i 16417 Err codemadness.org 70 i 16418

Err codemadness.org 70 i 16380 Err codemadness.org 70 i 16381 [MDEV-24821] Encryption loading fails while running the suite Err codemadness.org 70 i 16382 Err codemadness.org 70 i 16383 Created: 2021-02-09 Updated: 2021-11-18 Err codemadness.org 70 i 16384 Err codemadness.org 70 i 16385 Err codemadness.org 70 i 16386 Err codemadness.org 70 i 16387
Status:	Open
Project:	MariaDB Server
Component/s:	Err codemadness.org 70 i 16401 Tests
Affects Version/s:	Err codemadness.org 70 i 16408 10.5, 10.6
Fix Version/s:	Err codemadness.org 70 i 16415 10.5, 10.6

Err codemadness.org 70 i 16419 Err codemadness.org 70 i 16420

Err codemadness.org 70 i 16421 Err codemadness.org 70 i 16422 Err codemadness.org 70 i 16423 Err codemadness.org 70 i 16426 Err codemadness.org 70 i 16429 Err codemadness.org 70 i 16430 Err codemadness.org 70 i 16433 Err codemadness.org 70 i 16436 Err codemadness.org 70 i 16437 Err codemadness.org 70 i 16438 Err codemadness.org 70 i 16441 Err codemadness.org 70 i 16444 Err codemadness.org 70 i 16445 Err codemadness.org 70 i 16448 Err codemadness.org 70 i 16451 Err codemadness.org 70 i 16452 Err codemadness.org 70 i 16453 Err codemadness.org 70 i 16456 Err codemadness.org 70 i 16459 Err codemadness.org 70 i 16462 Err codemadness.org 70 i 16465 Err codemadness.org 70 i 16466 Err codemadness.org 70 i 16467 Err codemadness.org 70 i 16468 Err codemadness.org 70 i 16469 Err codemadness.org 70 i 16472 Err codemadness.org 70 i 16474 Err codemadness.org 70 i 16475 Err codemadness.org 70 i 16476 Err codemadness.org 70 i 16477 Err codemadness.org 70 i 16478 Err codemadness.org 70 i 16479 Err codemadness.org 70 i 16480

Err codemadness.org 70 i 16424 Type: Err codemadness.org 70 i 16425

Err codemadness.org 70 i 16427 Bug Err codemadness.org 70 i 16428

Err codemadness.org 70 i 16431 Priority: Err codemadness.org 70 i 16432

Err codemadness.org 70 i 16434 Critical Err codemadness.org 70 i 16435

Err codemadness.org 70 i 16439 Reporter: Err codemadness.org 70 i 16440

Err codemadness.org 70 i 16442 Thirunarayanan Balathandayuthapani Err codemadness.org 70 i 16443

Err codemadness.org 70 i 16446 Assignee: Err codemadness.org 70 i 16447

Err codemadness.org 70 i 16449 Sergei Golubchik Err codemadness.org 70 i 16450

Err codemadness.org 70 i 16454 Resolution: Err codemadness.org 70 i 16455

Err codemadness.org 70 i 16457 Unresolved Err codemadness.org 70 i 16458

Err codemadness.org 70 i 16460 Votes: Err codemadness.org 70 i 16461

Err codemadness.org 70 i 16463 0 Err codemadness.org 70 i 16464

Err codemadness.org 70 i 16470 Labels: Err codemadness.org 70 i 16471

Err codemadness.org 70 i 16473 affects-tests

Err codemadness.org 70 i 16481 Err codemadness.org 70 i 16482 Err codemadness.org 70 i 16483 Err codemadness.org 70 i 16484

Err codemadness.org 70 i 16485 Err codemadness.org 70 i 16486 Err codemadness.org 70 i 16487 Err codemadness.org 70 i 16488 Err codemadness.org 70 i 16489 Err codemadness.org 70 i 16490 Err codemadness.org 70 i 16491 Err codemadness.org 70 i 16492 Err codemadness.org 70 i 16493 Err codemadness.org 70 i 16494

Err codemadness.org 70 i 16495 Err codemadness.org 70 i 16496

Err codemadness.org 70 i 16497 Err codemadness.org 70 i 16498 Err codemadness.org 70 i 16499 Err codemadness.org 70 i 16500 Err codemadness.org 70 i 16503 Err codemadness.org 70 i 16504 Err codemadness.org 70 i 16505

Err codemadness.org 70 i 16501 Description Err codemadness.org 70 i 16502

Err codemadness.org 70 i 16506 Err codemadness.org 70 i 16507 Err codemadness.org 70 i 16508 Err codemadness.org 70 i 16509 Err codemadness.org 70 i 16637 Err codemadness.org 70 i 16638

Err codemadness.org 70 i 16510

In 10.6, encryption suite test case fails with Test requires plugin

Err codemadness.org 70 i 16511 Err codemadness.org 70 i 16512

Err codemadness.org 70 i 16513

Err codemadness.org 70 i 16514 Err codemadness.org 70 i 16515 Err codemadness.org 70 i 16516 Err codemadness.org 70 i 16517 Err codemadness.org 70 i 16520 Err codemadness.org 70 i 16521 Err codemadness.org 70 i 16522 Err codemadness.org 70 i 16525 Err codemadness.org 70 i 16526 Err codemadness.org 70 i 16527 Err codemadness.org 70 i 16530 Err codemadness.org 70 i 16531 Err codemadness.org 70 i 16532 Err codemadness.org 70 i 16535 Err codemadness.org 70 i 16536 Err codemadness.org 70 i 16537 Err codemadness.org 70 i 16540 Err codemadness.org 70 i 16541 Err codemadness.org 70 i 16542 Err codemadness.org 70 i 16545 Err codemadness.org 70 i 16546 Err codemadness.org 70 i 16547 Err codemadness.org 70 i 16550 Err codemadness.org 70 i 16551 Err codemadness.org 70 i 16552 Err codemadness.org 70 i 16555 Err codemadness.org 70 i 16556 Err codemadness.org 70 i 16557 Err codemadness.org 70 i 16560 Err codemadness.org 70 i 16561 Err codemadness.org 70 i 16562 Err codemadness.org 70 i 16565 Err codemadness.org 70 i 16566 Err codemadness.org 70 i 16567 Err codemadness.org 70 i 16570 Err codemadness.org 70 i 16571 Err codemadness.org 70 i 16572 Err codemadness.org 70 i 16575 Err codemadness.org 70 i 16576 Err codemadness.org 70 i 16577 Err codemadness.org 70 i 16581 Err codemadness.org 70 i 16582 Err codemadness.org 70 i 16583

Err codemadness.org 70 i 16518

encryption.innodb-compressed-blob '16k,cbc,crc32,innodb' [ skipped ]  Test requires file_key_management plugin

Err codemadness.org 70 i 16519

Err codemadness.org 70 i 16523

line

Err codemadness.org 70 i 16524

Err codemadness.org 70 i 16528

2021-02-09 18:35:21 0 [ERROR] InnoDB: cannot enable encryption, encryption plugin is not available

Err codemadness.org 70 i 16529

Err codemadness.org 70 i 16533

2021-02-09 18:35:21 0 [ERROR] Plugin 'InnoDB' init function returned error.

Err codemadness.org 70 i 16534

Err codemadness.org 70 i 16538

2021-02-09 18:35:21 0 [ERROR] Plugin 'InnoDB' registration as a STORAGE ENGINE failed.

Err codemadness.org 70 i 16539

Err codemadness.org 70 i 16543

^ Found warnings in /home/thiru/mariarepo/10.6/10.6-test/bld_sample-debug/mysql-test/var/log/mysqld.1.err

Err codemadness.org 70 i 16544

Err codemadness.org 70 i 16548

ok

Err codemadness.org 70 i 16549

Err codemadness.org 70 i 16553

Err codemadness.org 70 i 16554

Err codemadness.org 70 i 16558

encryption.innodb-checksum-algorithm '4k,cbc,innodb' w2 [ skipped ]  Test requires file_key_management plugin

Err codemadness.org 70 i 16559

Err codemadness.org 70 i 16563

encryption.innodb-checksum-algorithm '8k,cbc,innodb' w4 [ skipped ]  Test requires file_key_management plugin

Err codemadness.org 70 i 16564

Err codemadness.org 70 i 16568

encryption.innochecksum '8k,cbc,innodb,strict_crc32' w6 [ skipped ]  Test requires file_key_management plugin

Err codemadness.org 70 i 16569

Err codemadness.org 70 i 16573

encryption.innochecksum '16k,cbc,innodb,strict_full_crc32' w4 [ skipped ]  Test requires file_key_management plugin

Err codemadness.org 70 i 16574

Err codemadness.org 70 i 16578

encryption.innochecksum '4k,cbc,innodb,strict_full_crc32' w6 [ skipped ]  Test requires file_key_management plugin	Err	codemadness.org	70
i 16579

Err codemadness.org 70 i 16580

Err codemadness.org 70 i 16584

Err codemadness.org 70 i 16585

Err codemadness.org 70 i 16586 Err codemadness.org 70 i 16587

It fails only in 10.6. I debugged further to understand what went wrong.

Err codemadness.org 70 i 16588 Err codemadness.org 70 i 16589

mtr tool doesn't start the server with file_key_management.so. I used the verbose command to find out what went wrong.

Err codemadness.org 70 i 16590 Err codemadness.org 70 i 16591

Err codemadness.org 70 i 16592

Err codemadness.org 70 i 16593 Err codemadness.org 70 i 16594 Err codemadness.org 70 i 16595 Err codemadness.org 70 i 16596 Err codemadness.org 70 i 16599 Err codemadness.org 70 i 16600 Err codemadness.org 70 i 16601 Err codemadness.org 70 i 16604 Err codemadness.org 70 i 16605 Err codemadness.org 70 i 16606 Err codemadness.org 70 i 16609 Err codemadness.org 70 i 16610 Err codemadness.org 70 i 16611 Err codemadness.org 70 i 16614 Err codemadness.org 70 i 16615 Err codemadness.org 70 i 16616 Err codemadness.org 70 i 16619 Err codemadness.org 70 i 16620 Err codemadness.org 70 i 16621 Err codemadness.org 70 i 16624 Err codemadness.org 70 i 16625 Err codemadness.org 70 i 16626 Err codemadness.org 70 i 16630 Err codemadness.org 70 i 16631 Err codemadness.org 70 i 16632

Err codemadness.org 70 i 16597

> Read combinations file /home/thiru/mariarepo/10.6/10.6-test/mysql-test/include/have_innodb.combinations

Err codemadness.org 70 i 16598

Err codemadness.org 70 i 16602

> Read combinations file /home/thiru/mariarepo/10.6/10.6-test/mysql-test/suite/encryption/include/have_file_key_management_plugin.combinations

Err codemadness.org 70 i 16603

Err codemadness.org 70 i 16607

> Read combinations file /home/thiru/mariarepo/10.6/10.6-test/mysql-test/include/innodb_page_size_small.combinations

Err codemadness.org 70 i 16608

Err codemadness.org 70 i 16612

> Read combinations file /home/thiru/mariarepo/10.6/10.6-test/mysql-test/include/innodb_checksum_algorithm.combinations

Err codemadness.org 70 i 16613

Err codemadness.org 70 i 16617

Err codemadness.org 70 i 16618

Err codemadness.org 70 i 16622

worker[1] > mysqld_start:  [' --innodb-checksum-algorithm=crc32', '--innodb-page-size=16K', '--skip-innodb-read-only-compressed', '--innodb', '--innodb-cmpmem', '--innodb-cmp-per-index', '--innodb-trx', '--innodb-locks', '--innodb-lock-waits', '--innodb-metrics', '--innodb-buffer-pool-stats', '--innodb-buffer-page', '--innodb-buffer-page-lru', '--innodb-sys-columns', '--innodb-sys-fields', '--innodb-sys-foreign', '--innodb-sys-foreign-cols', '--innodb-sys-indexes', '--innodb-sys-tables', '--innodb-sys-virtual ']

Err codemadness.org 70 i 16623

Err codemadness.org 70 i 16627

	Err	codemadness.org	70
i 16628

Err codemadness.org 70 i 16629

Err codemadness.org 70 i 16633

Err codemadness.org 70 i 16634

Err codemadness.org 70 i 16635

Err codemadness.org 70 i 16636

Err codemadness.org 70 i 16639 Err codemadness.org 70 i 16640

Err codemadness.org 70 i 16641 Err codemadness.org 70 i 16642 Err codemadness.org 70 i 16643 Err codemadness.org 70 i 16644 Err codemadness.org 70 i 16647 Err codemadness.org 70 i 16648 Err codemadness.org 70 i 16649

Err codemadness.org 70 i 16645 Comments Err codemadness.org 70 i 16646

Err codemadness.org 70 i 16650 Err codemadness.org 70 i 16651 Err codemadness.org 70 i 16652 Err codemadness.org 70 i 16663 Err codemadness.org 70 i 16760 Err codemadness.org 70 i 16771 Err codemadness.org 70 i 16820 Err codemadness.org 70 i 16831 Err codemadness.org 70 i 17495

Err codemadness.org 70 i 16653 Comment by Err codemadness.org 70 i 16654 Marko Mäkelä Err codemadness.org 70 i 16655 Err codemadness.org 70 i 16656 [ Err codemadness.org 70 i 16657 2021-03-11 Err codemadness.org 70 i 16658 Err codemadness.org 70 i 16659 ] Err codemadness.org 70 i 16660 Err codemadness.org 70 i 16661 Err codemadness.org 70 i 16662

Err codemadness.org 70 i 16664

With the ~~MDEV-25105~~ changes, I am observing the following for

Err codemadness.org 70 i 16665

Err codemadness.org 70 i 16666

Err codemadness.org 70 i 16667 Err codemadness.org 70 i 16668 Err codemadness.org 70 i 16669 Err codemadness.org 70 i 16670 Err codemadness.org 70 i 16674 Err codemadness.org 70 i 16675 Err codemadness.org 70 i 16676

Err codemadness.org 70 i 16671

./mtr --parallel=14 encryption.innodb-checksum-algorithm	Err	codemadness.org	70
i 16672

Err codemadness.org 70 i 16673

Err codemadness.org 70 i 16677

Err codemadness.org 70 i 16678

Err codemadness.org 70 i 16679

Err codemadness.org 70 i 16680

Err codemadness.org 70 i 16681 Err codemadness.org 70 i 16682 Err codemadness.org 70 i 16683 Err codemadness.org 70 i 16684 Err codemadness.org 70 i 16687 Err codemadness.org 70 i 16688 Err codemadness.org 70 i 16689 Err codemadness.org 70 i 16692 Err codemadness.org 70 i 16693 Err codemadness.org 70 i 16694 Err codemadness.org 70 i 16697 Err codemadness.org 70 i 16698 Err codemadness.org 70 i 16699 Err codemadness.org 70 i 16702 Err codemadness.org 70 i 16703 Err codemadness.org 70 i 16704 Err codemadness.org 70 i 16707 Err codemadness.org 70 i 16708 Err codemadness.org 70 i 16709 Err codemadness.org 70 i 16712 Err codemadness.org 70 i 16713 Err codemadness.org 70 i 16714 Err codemadness.org 70 i 16717 Err codemadness.org 70 i 16718 Err codemadness.org 70 i 16719 Err codemadness.org 70 i 16722 Err codemadness.org 70 i 16723 Err codemadness.org 70 i 16724 Err codemadness.org 70 i 16727 Err codemadness.org 70 i 16728 Err codemadness.org 70 i 16729 Err codemadness.org 70 i 16732 Err codemadness.org 70 i 16733 Err codemadness.org 70 i 16734 Err codemadness.org 70 i 16737 Err codemadness.org 70 i 16738 Err codemadness.org 70 i 16739 Err codemadness.org 70 i 16742 Err codemadness.org 70 i 16743 Err codemadness.org 70 i 16744 Err codemadness.org 70 i 16747 Err codemadness.org 70 i 16748 Err codemadness.org 70 i 16749 Err codemadness.org 70 i 16753 Err codemadness.org 70 i 16754 Err codemadness.org 70 i 16755

Err codemadness.org 70 i 16685

encryption.innodb-checksum-algorithm '16k,cbc,innodb,strict_full_crc32' w8 [ skipped ]  Test requires file_key_management plugin

Err codemadness.org 70 i 16686

Err codemadness.org 70 i 16690

encryption.innodb-checksum-algorithm '8k,cbc,innodb,strict_full_crc32' w14 [ skipped ]  Test requires file_key_management plugin

Err codemadness.org 70 i 16691

Err codemadness.org 70 i 16695

encryption.innodb-checksum-algorithm '4k,cbc,innodb,strict_crc32' w9 [ skipped ]  Test requires file_key_management plugin

Err codemadness.org 70 i 16696

Err codemadness.org 70 i 16700

encryption.innodb-checksum-algorithm '4k,cbc,innodb,strict_full_crc32' w13 [ skipped ]  Test requires file_key_management plugin

Err codemadness.org 70 i 16701

Err codemadness.org 70 i 16705

encryption.innodb-checksum-algorithm '16k,cbc,innodb,strict_crc32' w10 [ skipped ]  Test requires file_key_management plugin

Err codemadness.org 70 i 16706

Err codemadness.org 70 i 16710

encryption.innodb-checksum-algorithm '8k,cbc,innodb,strict_crc32' w7 [ skipped ]  Test requires file_key_management plugin

Err codemadness.org 70 i 16711

Err codemadness.org 70 i 16715

encryption.innodb-checksum-algorithm '32k,ctr,innodb,strict_full_crc32' w3 [ pass ]   1580

Err codemadness.org 70 i 16716

Err codemadness.org 70 i 16720

encryption.innodb-checksum-algorithm '64k,ctr,innodb,strict_full_crc32' w2 [ pass ]   1585

Err codemadness.org 70 i 16721

Err codemadness.org 70 i 16725

encryption.innodb-checksum-algorithm '32k,cbc,innodb,strict_full_crc32' w12 [ pass ]   1580

Err codemadness.org 70 i 16726

Err codemadness.org 70 i 16730

encryption.innodb-checksum-algorithm '64k,cbc,innodb,strict_full_crc32' w6 [ pass ]   1582

Err codemadness.org 70 i 16731

Err codemadness.org 70 i 16735

encryption.innodb-checksum-algorithm '64k,ctr,innodb,strict_crc32' w5 [ pass ]   4712

Err codemadness.org 70 i 16736

Err codemadness.org 70 i 16740

encryption.innodb-checksum-algorithm '32k,ctr,innodb,strict_crc32' w11 [ pass ]   5694

Err codemadness.org 70 i 16741

Err codemadness.org 70 i 16745

encryption.innodb-checksum-algorithm '32k,cbc,innodb,strict_crc32' w1 [ pass ]   5681

Err codemadness.org 70 i 16746

Err codemadness.org 70 i 16750

encryption.innodb-checksum-algorithm '64k,cbc,innodb,strict_crc32' w4 [ pass ]   5738	Err	codemadness.org	70
i 16751

Err codemadness.org 70 i 16752

Err codemadness.org 70 i 16756

Err codemadness.org 70 i 16757

Err codemadness.org 70 i 16758

It appears that with larger page sizes, the problem is less likely to occur. We started to see this in 10.6, possibly after something was cleaned up in InnoDB so that it would start up or shut down faster.

Err codemadness.org 70 i 16759

Err codemadness.org 70 i 16761 Comment by Err codemadness.org 70 i 16762 Marko Mäkelä Err codemadness.org 70 i 16763 Err codemadness.org 70 i 16764 [ Err codemadness.org 70 i 16765 2021-03-17 Err codemadness.org 70 i 16766 Err codemadness.org 70 i 16767 ] Err codemadness.org 70 i 16768 Err codemadness.org 70 i 16769 Err codemadness.org 70 i 16770

Err codemadness.org 70 i 16772

I am seeing this also on 10.5 on a remote system that I am using to debug ~~MDEV-25121~~. The mysql-test/var directory is on a SSD with 4KiB block size.

Err codemadness.org 70 i 16773

Err codemadness.org 70 i 16774

Err codemadness.org 70 i 16775 Err codemadness.org 70 i 16776 Err codemadness.org 70 i 16777 Err codemadness.org 70 i 16778 Err codemadness.org 70 i 16781 Err codemadness.org 70 i 16782 Err codemadness.org 70 i 16783 Err codemadness.org 70 i 16784 Err codemadness.org 70 i 16785 Err codemadness.org 70 i 16788 Err codemadness.org 70 i 16789 Err codemadness.org 70 i 16790 Err codemadness.org 70 i 16793 Err codemadness.org 70 i 16794 Err codemadness.org 70 i 16795 Err codemadness.org 70 i 16798 Err codemadness.org 70 i 16799 Err codemadness.org 70 i 16800 Err codemadness.org 70 i 16803 Err codemadness.org 70 i 16804 Err codemadness.org 70 i 16805 Err codemadness.org 70 i 16808 Err codemadness.org 70 i 16809 Err codemadness.org 70 i 16810 Err codemadness.org 70 i 16814 Err codemadness.org 70 i 16815 Err codemadness.org 70 i 16816

Err codemadness.org 70 i 16779 mariadb-10.5.9 with some InnoDB changes Err codemadness.org 70 i 16780
Err codemadness.org 70 i 16786 encryption.innodb-compressed-blob '16k,cbc,innodb' w8 [ skipped ] Test requires file_key_management plugin Err codemadness.org 70 i 16787
Err codemadness.org 70 i 16791 line Err codemadness.org 70 i 16792
Err codemadness.org 70 i 16796 2021-03-17 3:18:02 0 [ERROR] InnoDB: cannot enable encryption, encryption plugin is not available Err codemadness.org 70 i 16797
Err codemadness.org 70 i 16801 2021-03-17 3:18:02 0 [ERROR] Plugin 'InnoDB' init function returned error. Err codemadness.org 70 i 16802
Err codemadness.org 70 i 16806 2021-03-17 3:18:02 0 [ERROR] Plugin 'InnoDB' registration as a STORAGE ENGINE failed. Err codemadness.org 70 i 16807
Err codemadness.org 70 i 16811 ^ Found warnings in /home/mariadb/mariadb-10.5.9/build/mysql-test/var/8/log/mysqld.1.err Err codemadness.org 70 i 16812 Err codemadness.org 70 i 16813

Err codemadness.org 70 i 16817

Err codemadness.org 70 i 16818

Err codemadness.org 70 i 16819

Err codemadness.org 70 i 16821 Comment by Err codemadness.org 70 i 16822 Marko Mäkelä Err codemadness.org 70 i 16823 Err codemadness.org 70 i 16824 [ Err codemadness.org 70 i 16825 2021-11-18 Err codemadness.org 70 i 16826 Err codemadness.org 70 i 16827 ] Err codemadness.org 70 i 16828 Err codemadness.org 70 i 16829 Err codemadness.org 70 i 16830

Err codemadness.org 70 i 16832

I got this on 10.6. It is as if the wrong parameters are being passed to the server for some reason:

Err codemadness.org 70 i 16833

Err codemadness.org 70 i 16834

Err codemadness.org 70 i 16835 Err codemadness.org 70 i 16836 Err codemadness.org 70 i 16837 Err codemadness.org 70 i 16838 Err codemadness.org 70 i 16841 Err codemadness.org 70 i 16842 Err codemadness.org 70 i 16843 Err codemadness.org 70 i 16844 Err codemadness.org 70 i 16845 Err codemadness.org 70 i 16848 Err codemadness.org 70 i 16849 Err codemadness.org 70 i 16850 Err codemadness.org 70 i 16853 Err codemadness.org 70 i 16854 Err codemadness.org 70 i 16855 Err codemadness.org 70 i 16858 Err codemadness.org 70 i 16859 Err codemadness.org 70 i 16860 Err codemadness.org 70 i 16863 Err codemadness.org 70 i 16864 Err codemadness.org 70 i 16865 Err codemadness.org 70 i 16868 Err codemadness.org 70 i 16869 Err codemadness.org 70 i 16870 Err codemadness.org 70 i 16873 Err codemadness.org 70 i 16874 Err codemadness.org 70 i 16875 Err codemadness.org 70 i 16878 Err codemadness.org 70 i 16879 Err codemadness.org 70 i 16880 Err codemadness.org 70 i 16883 Err codemadness.org 70 i 16884 Err codemadness.org 70 i 16885 Err codemadness.org 70 i 16888 Err codemadness.org 70 i 16889 Err codemadness.org 70 i 16890 Err codemadness.org 70 i 16893 Err codemadness.org 70 i 16894 Err codemadness.org 70 i 16895 Err codemadness.org 70 i 16898 Err codemadness.org 70 i 16899 Err codemadness.org 70 i 16900 Err codemadness.org 70 i 16903 Err codemadness.org 70 i 16904 Err codemadness.org 70 i 16905 Err codemadness.org 70 i 16908 Err codemadness.org 70 i 16909 Err codemadness.org 70 i 16910 Err codemadness.org 70 i 16913 Err codemadness.org 70 i 16914 Err codemadness.org 70 i 16915 Err codemadness.org 70 i 16918 Err codemadness.org 70 i 16919 Err codemadness.org 70 i 16920 Err codemadness.org 70 i 16923 Err codemadness.org 70 i 16924 Err codemadness.org 70 i 16925 Err codemadness.org 70 i 16928 Err codemadness.org 70 i 16929 Err codemadness.org 70 i 16930 Err codemadness.org 70 i 16933 Err codemadness.org 70 i 16934 Err codemadness.org 70 i 16935 Err codemadness.org 70 i 16938 Err codemadness.org 70 i 16939 Err codemadness.org 70 i 16940 Err codemadness.org 70 i 16943 Err codemadness.org 70 i 16944 Err codemadness.org 70 i 16945 Err codemadness.org 70 i 16948 Err codemadness.org 70 i 16949 Err codemadness.org 70 i 16950 Err codemadness.org 70 i 16953 Err codemadness.org 70 i 16954 Err codemadness.org 70 i 16955 Err codemadness.org 70 i 16958 Err codemadness.org 70 i 16959 Err codemadness.org 70 i 16960 Err codemadness.org 70 i 16963 Err codemadness.org 70 i 16964 Err codemadness.org 70 i 16965 Err codemadness.org 70 i 16968 Err codemadness.org 70 i 16969 Err codemadness.org 70 i 16970 Err codemadness.org 70 i 16973 Err codemadness.org 70 i 16974 Err codemadness.org 70 i 16975 Err codemadness.org 70 i 16978 Err codemadness.org 70 i 16979 Err codemadness.org 70 i 16980 Err codemadness.org 70 i 16983 Err codemadness.org 70 i 16984 Err codemadness.org 70 i 16985 Err codemadness.org 70 i 16988 Err codemadness.org 70 i 16989 Err codemadness.org 70 i 16990 Err codemadness.org 70 i 16993 Err codemadness.org 70 i 16994 Err codemadness.org 70 i 16995 Err codemadness.org 70 i 16998 Err codemadness.org 70 i 16999 Err codemadness.org 70 i 17000 Err codemadness.org 70 i 17003 Err codemadness.org 70 i 17004 Err codemadness.org 70 i 17005 Err codemadness.org 70 i 17008 Err codemadness.org 70 i 17009 Err codemadness.org 70 i 17010 Err codemadness.org 70 i 17013 Err codemadness.org 70 i 17014 Err codemadness.org 70 i 17015 Err codemadness.org 70 i 17018 Err codemadness.org 70 i 17019 Err codemadness.org 70 i 17020 Err codemadness.org 70 i 17023 Err codemadness.org 70 i 17024 Err codemadness.org 70 i 17025 Err codemadness.org 70 i 17028 Err codemadness.org 70 i 17029 Err codemadness.org 70 i 17030 Err codemadness.org 70 i 17033 Err codemadness.org 70 i 17034 Err codemadness.org 70 i 17035 Err codemadness.org 70 i 17038 Err codemadness.org 70 i 17039 Err codemadness.org 70 i 17040 Err codemadness.org 70 i 17043 Err codemadness.org 70 i 17044 Err codemadness.org 70 i 17045 Err codemadness.org 70 i 17048 Err codemadness.org 70 i 17049 Err codemadness.org 70 i 17050 Err codemadness.org 70 i 17053 Err codemadness.org 70 i 17054 Err codemadness.org 70 i 17055 Err codemadness.org 70 i 17058 Err codemadness.org 70 i 17059 Err codemadness.org 70 i 17060 Err codemadness.org 70 i 17063 Err codemadness.org 70 i 17064 Err codemadness.org 70 i 17065 Err codemadness.org 70 i 17068 Err codemadness.org 70 i 17069 Err codemadness.org 70 i 17070 Err codemadness.org 70 i 17073 Err codemadness.org 70 i 17074 Err codemadness.org 70 i 17075 Err codemadness.org 70 i 17078 Err codemadness.org 70 i 17079 Err codemadness.org 70 i 17080 Err codemadness.org 70 i 17083 Err codemadness.org 70 i 17084 Err codemadness.org 70 i 17085 Err codemadness.org 70 i 17088 Err codemadness.org 70 i 17089 Err codemadness.org 70 i 17090 Err codemadness.org 70 i 17093 Err codemadness.org 70 i 17094 Err codemadness.org 70 i 17095 Err codemadness.org 70 i 17098 Err codemadness.org 70 i 17099 Err codemadness.org 70 i 17100 Err codemadness.org 70 i 17103 Err codemadness.org 70 i 17104 Err codemadness.org 70 i 17105 Err codemadness.org 70 i 17108 Err codemadness.org 70 i 17109 Err codemadness.org 70 i 17110 Err codemadness.org 70 i 17113 Err codemadness.org 70 i 17114 Err codemadness.org 70 i 17115 Err codemadness.org 70 i 17118 Err codemadness.org 70 i 17119 Err codemadness.org 70 i 17120 Err codemadness.org 70 i 17123 Err codemadness.org 70 i 17124 Err codemadness.org 70 i 17125 Err codemadness.org 70 i 17128 Err codemadness.org 70 i 17129 Err codemadness.org 70 i 17130 Err codemadness.org 70 i 17133 Err codemadness.org 70 i 17134 Err codemadness.org 70 i 17135 Err codemadness.org 70 i 17138 Err codemadness.org 70 i 17139 Err codemadness.org 70 i 17140 Err codemadness.org 70 i 17143 Err codemadness.org 70 i 17144 Err codemadness.org 70 i 17145 Err codemadness.org 70 i 17148 Err codemadness.org 70 i 17149 Err codemadness.org 70 i 17150 Err codemadness.org 70 i 17153 Err codemadness.org 70 i 17154 Err codemadness.org 70 i 17155 Err codemadness.org 70 i 17158 Err codemadness.org 70 i 17159 Err codemadness.org 70 i 17160 Err codemadness.org 70 i 17163 Err codemadness.org 70 i 17164 Err codemadness.org 70 i 17165 Err codemadness.org 70 i 17168 Err codemadness.org 70 i 17169 Err codemadness.org 70 i 17170 Err codemadness.org 70 i 17173 Err codemadness.org 70 i 17174 Err codemadness.org 70 i 17175 Err codemadness.org 70 i 17178 Err codemadness.org 70 i 17179 Err codemadness.org 70 i 17180 Err codemadness.org 70 i 17183 Err codemadness.org 70 i 17184 Err codemadness.org 70 i 17185 Err codemadness.org 70 i 17188 Err codemadness.org 70 i 17189 Err codemadness.org 70 i 17190 Err codemadness.org 70 i 17193 Err codemadness.org 70 i 17194 Err codemadness.org 70 i 17195 Err codemadness.org 70 i 17198 Err codemadness.org 70 i 17199 Err codemadness.org 70 i 17200 Err codemadness.org 70 i 17203 Err codemadness.org 70 i 17204 Err codemadness.org 70 i 17205 Err codemadness.org 70 i 17208 Err codemadness.org 70 i 17209 Err codemadness.org 70 i 17210 Err codemadness.org 70 i 17213 Err codemadness.org 70 i 17214 Err codemadness.org 70 i 17215 Err codemadness.org 70 i 17218 Err codemadness.org 70 i 17219 Err codemadness.org 70 i 17220 Err codemadness.org 70 i 17223 Err codemadness.org 70 i 17224 Err codemadness.org 70 i 17225 Err codemadness.org 70 i 17228 Err codemadness.org 70 i 17229 Err codemadness.org 70 i 17230 Err codemadness.org 70 i 17233 Err codemadness.org 70 i 17234 Err codemadness.org 70 i 17235 Err codemadness.org 70 i 17238 Err codemadness.org 70 i 17239 Err codemadness.org 70 i 17240 Err codemadness.org 70 i 17243 Err codemadness.org 70 i 17244 Err codemadness.org 70 i 17245 Err codemadness.org 70 i 17248 Err codemadness.org 70 i 17249 Err codemadness.org 70 i 17250 Err codemadness.org 70 i 17253 Err codemadness.org 70 i 17254 Err codemadness.org 70 i 17255 Err codemadness.org 70 i 17258 Err codemadness.org 70 i 17259 Err codemadness.org 70 i 17260 Err codemadness.org 70 i 17263 Err codemadness.org 70 i 17264 Err codemadness.org 70 i 17265 Err codemadness.org 70 i 17268 Err codemadness.org 70 i 17269 Err codemadness.org 70 i 17270 Err codemadness.org 70 i 17273 Err codemadness.org 70 i 17274 Err codemadness.org 70 i 17275 Err codemadness.org 70 i 17278 Err codemadness.org 70 i 17279 Err codemadness.org 70 i 17280 Err codemadness.org 70 i 17283 Err codemadness.org 70 i 17284 Err codemadness.org 70 i 17285 Err codemadness.org 70 i 17288 Err codemadness.org 70 i 17289 Err codemadness.org 70 i 17290 Err codemadness.org 70 i 17293 Err codemadness.org 70 i 17294 Err codemadness.org 70 i 17295 Err codemadness.org 70 i 17298 Err codemadness.org 70 i 17299 Err codemadness.org 70 i 17300 Err codemadness.org 70 i 17303 Err codemadness.org 70 i 17304 Err codemadness.org 70 i 17305 Err codemadness.org 70 i 17308 Err codemadness.org 70 i 17309 Err codemadness.org 70 i 17310 Err codemadness.org 70 i 17313 Err codemadness.org 70 i 17314 Err codemadness.org 70 i 17315 Err codemadness.org 70 i 17318 Err codemadness.org 70 i 17319 Err codemadness.org 70 i 17320 Err codemadness.org 70 i 17323 Err codemadness.org 70 i 17324 Err codemadness.org 70 i 17325 Err codemadness.org 70 i 17328 Err codemadness.org 70 i 17329 Err codemadness.org 70 i 17330 Err codemadness.org 70 i 17333 Err codemadness.org 70 i 17334 Err codemadness.org 70 i 17335 Err codemadness.org 70 i 17338 Err codemadness.org 70 i 17339 Err codemadness.org 70 i 17340 Err codemadness.org 70 i 17343 Err codemadness.org 70 i 17344 Err codemadness.org 70 i 17345 Err codemadness.org 70 i 17348 Err codemadness.org 70 i 17349 Err codemadness.org 70 i 17350 Err codemadness.org 70 i 17353 Err codemadness.org 70 i 17354 Err codemadness.org 70 i 17355 Err codemadness.org 70 i 17358 Err codemadness.org 70 i 17359 Err codemadness.org 70 i 17360 Err codemadness.org 70 i 17363 Err codemadness.org 70 i 17364 Err codemadness.org 70 i 17365 Err codemadness.org 70 i 17368 Err codemadness.org 70 i 17369 Err codemadness.org 70 i 17370 Err codemadness.org 70 i 17373 Err codemadness.org 70 i 17374 Err codemadness.org 70 i 17375 Err codemadness.org 70 i 17378 Err codemadness.org 70 i 17379 Err codemadness.org 70 i 17380 Err codemadness.org 70 i 17383 Err codemadness.org 70 i 17384 Err codemadness.org 70 i 17385 Err codemadness.org 70 i 17388 Err codemadness.org 70 i 17389 Err codemadness.org 70 i 17390 Err codemadness.org 70 i 17393 Err codemadness.org 70 i 17394 Err codemadness.org 70 i 17395 Err codemadness.org 70 i 17398 Err codemadness.org 70 i 17399 Err codemadness.org 70 i 17400 Err codemadness.org 70 i 17403 Err codemadness.org 70 i 17404 Err codemadness.org 70 i 17405 Err codemadness.org 70 i 17408 Err codemadness.org 70 i 17409 Err codemadness.org 70 i 17410 Err codemadness.org 70 i 17413 Err codemadness.org 70 i 17414 Err codemadness.org 70 i 17415 Err codemadness.org 70 i 17418 Err codemadness.org 70 i 17419 Err codemadness.org 70 i 17420 Err codemadness.org 70 i 17423 Err codemadness.org 70 i 17424 Err codemadness.org 70 i 17425 Err codemadness.org 70 i 17429 Err codemadness.org 70 i 17430 Err codemadness.org 70 i 17431

Err codemadness.org 70 i 16839 10.6 aaef2e1d8c843d1e40b1ce0c5199c3abb3c5da28 Err codemadness.org 70 i 16840
Err codemadness.org 70 i 16846 worker[14] encryption.encryption_key_corruption Err codemadness.org 70 i 16847
Err codemadness.org 70 i 16851 worker[14] [ fail ] Err codemadness.org 70 i 16852
Err codemadness.org 70 i 16856 Test ended at 2021-11-18 17:50:27 Err codemadness.org 70 i 16857
Err codemadness.org 70 i 16861 worker[14] Err codemadness.org 70 i 16862
Err codemadness.org 70 i 16866 Err codemadness.org 70 i 16867
Err codemadness.org 70 i 16871 Server log from this test: Err codemadness.org 70 i 16872
Err codemadness.org 70 i 16876 ----------SERVER LOG START----------- Err codemadness.org 70 i 16877
Err codemadness.org 70 i 16881 $ /dev/shm/10.6m/sql/mariadbd --defaults-group-suffix=.1 --defaults-file=/dev/shm/10.6m/mysql-test/var/14/my.cnf --log-output=file --innodb-checksum-algorithm=innodb --innodb --innodb-cmpmem --innodb-cmp-per-index --innodb-trx --innodb-locks --innodb-lock-waits --innodb-metrics --innodb-buffer-pool-stats --innodb-buffer-page --innodb-buffer-page-lru --innodb-sys-columns --innodb-sys-fields --innodb-sys-foreign --innodb-sys-foreign-cols --innodb-sys-indexes --innodb-sys-tables --innodb-sys-virtual --plugin-load-add=example_key_management.so --loose-example-key-management --skip-innodb-read-only-compressed --innodb-encrypt-tables=1 --core-file --loose-debug-sync-timeout=300 Err codemadness.org 70 i 16882
Err codemadness.org 70 i 16886 2021-11-18 17:50:27 0 [Note] /dev/shm/10.6m/sql/mariadbd (server 10.6.6-MariaDB-debug-log) starting as process 82074 ... Err codemadness.org 70 i 16887
Err codemadness.org 70 i 16891 2021-11-18 17:50:27 0 [Warning] Could not increase number of max_open_files to more than 1024 (request: 32222) Err codemadness.org 70 i 16892
Err codemadness.org 70 i 16896 2021-11-18 17:50:27 0 [Warning] Changed limits: max_open_files: 1024 max_connections: 151 (was 151) table_cache: 421 (was 2000) Err codemadness.org 70 i 16897
Err codemadness.org 70 i 16901 2021-11-18 17:50:27 0 [Warning] Plugin 'example_key_management' is of maturity level experimental while the server is stable Err codemadness.org 70 i 16902
Err codemadness.org 70 i 16906 2021-11-18 17:50:27 0 [Note] Plugin 'partition' is disabled. Err codemadness.org 70 i 16907
Err codemadness.org 70 i 16911 2021-11-18 17:50:27 0 [Note] Plugin 'SEQUENCE' is disabled. Err codemadness.org 70 i 16912
Err codemadness.org 70 i 16916 2021-11-18 17:50:27 0 [ERROR] /dev/shm/10.6m/sql/mariadbd: Error while setting value 'innodb' to 'innodb-checksum-algorithm' Err codemadness.org 70 i 16917
Err codemadness.org 70 i 16921 2021-11-18 17:50:27 0 [ERROR] Parsing options for plugin 'InnoDB' failed. Err codemadness.org 70 i 16922
Err codemadness.org 70 i 16926 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_FT_CONFIG' is disabled. Err codemadness.org 70 i 16927
Err codemadness.org 70 i 16931 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_SYS_TABLESTATS' is disabled. Err codemadness.org 70 i 16932
Err codemadness.org 70 i 16936 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_FT_DELETED' is disabled. Err codemadness.org 70 i 16937
Err codemadness.org 70 i 16941 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_CMP' is disabled. Err codemadness.org 70 i 16942
Err codemadness.org 70 i 16946 2021-11-18 17:50:27 0 [Note] Plugin 'THREAD_POOL_WAITS' is disabled. Err codemadness.org 70 i 16947
Err codemadness.org 70 i 16951 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_CMP_RESET' is disabled. Err codemadness.org 70 i 16952
Err codemadness.org 70 i 16956 2021-11-18 17:50:27 0 [Note] Plugin 'THREAD_POOL_QUEUES' is disabled. Err codemadness.org 70 i 16957
Err codemadness.org 70 i 16961 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_SYS_FIELDS' is disabled. Err codemadness.org 70 i 16962
Err codemadness.org 70 i 16966 2021-11-18 17:50:27 0 [Note] Plugin 'FEEDBACK' is disabled. Err codemadness.org 70 i 16967
Err codemadness.org 70 i 16971 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_FT_INDEX_TABLE' is disabled. Err codemadness.org 70 i 16972
Err codemadness.org 70 i 16976 2021-11-18 17:50:27 0 [Note] Plugin 'THREAD_POOL_GROUPS' is disabled. Err codemadness.org 70 i 16977
Err codemadness.org 70 i 16981 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_CMP_PER_INDEX_RESET' is disabled. Err codemadness.org 70 i 16982
Err codemadness.org 70 i 16986 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_SYS_FOREIGN_COLS' is disabled. Err codemadness.org 70 i 16987
Err codemadness.org 70 i 16991 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_FT_INDEX_CACHE' is disabled. Err codemadness.org 70 i 16992
Err codemadness.org 70 i 16996 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_FT_BEING_DELETED' is disabled. Err codemadness.org 70 i 16997
Err codemadness.org 70 i 17001 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_SYS_FOREIGN' is disabled. Err codemadness.org 70 i 17002
Err codemadness.org 70 i 17006 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_CMPMEM_RESET' is disabled. Err codemadness.org 70 i 17007
Err codemadness.org 70 i 17011 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_FT_DEFAULT_STOPWORD' is disabled. Err codemadness.org 70 i 17012
Err codemadness.org 70 i 17016 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_SYS_TABLES' is disabled. Err codemadness.org 70 i 17017
Err codemadness.org 70 i 17021 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_SYS_TABLESPACES' is disabled. Err codemadness.org 70 i 17022
Err codemadness.org 70 i 17026 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_SYS_INDEXES' is disabled. Err codemadness.org 70 i 17027
Err codemadness.org 70 i 17031 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_SYS_VIRTUAL' is disabled. Err codemadness.org 70 i 17032
Err codemadness.org 70 i 17036 2021-11-18 17:50:27 0 [Note] Plugin 'user_variables' is disabled. Err codemadness.org 70 i 17037
Err codemadness.org 70 i 17041 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_TABLESPACES_ENCRYPTION' is disabled. Err codemadness.org 70 i 17042
Err codemadness.org 70 i 17046 2021-11-18 17:50:27 0 [Note] Plugin 'THREAD_POOL_STATS' is disabled. Err codemadness.org 70 i 17047
Err codemadness.org 70 i 17051 2021-11-18 17:50:27 0 [Note] Plugin 'unix_socket' is disabled. Err codemadness.org 70 i 17052
Err codemadness.org 70 i 17056 2021-11-18 17:50:27 0 [Warning] /dev/shm/10.6m/sql/mariadbd: unknown option '--loose-pam-debug' Err codemadness.org 70 i 17057
Err codemadness.org 70 i 17061 2021-11-18 17:50:27 0 [Warning] /dev/shm/10.6m/sql/mariadbd: unknown option '--loose-aria' Err codemadness.org 70 i 17062
Err codemadness.org 70 i 17066 2021-11-18 17:50:27 0 [Warning] /dev/shm/10.6m/sql/mariadbd: unknown option '--loose-aria' Err codemadness.org 70 i 17067
Err codemadness.org 70 i 17071 2021-11-18 17:50:27 0 [ERROR] /dev/shm/10.6m/sql/mariadbd: unknown option '----file-marker----' Err codemadness.org 70 i 17072
Err codemadness.org 70 i 17076 2021-11-18 17:50:27 0 [ERROR] Aborting Err codemadness.org 70 i 17077
Err codemadness.org 70 i 17081 ----------SERVER LOG END------------- Err codemadness.org 70 i 17082
Err codemadness.org 70 i 17086 Err codemadness.org 70 i 17087
Err codemadness.org 70 i 17091 Err codemadness.org 70 i 17092
Err codemadness.org 70 i 17096 worker[14] mysql-test-run: *** ERROR: Failed to start mysqld mysqld.1 with command /dev/shm/10.6m/sql/mariadbd --defaults-group-suffix=.1 --defaults-file=/dev/shm/10.6m/mysql-test/var/14/my.cnf --log-output=file --innodb-checksum-algorithm=innodb --innodb --innodb-cmpmem --innodb-cmp-per-index --innodb-trx --innodb-locks --innodb-lock-waits --innodb-metrics --innodb-buffer-pool-stats --innodb-buffer-page --innodb-buffer-page-lru --innodb-sys-columns --innodb-sys-fields --innodb-sys-foreign --innodb-sys-foreign-cols --innodb-sys-indexes --innodb-sys-tables --innodb-sys-virtual --plugin-load-add=example_key_management.so --loose-example-key-management --skip-innodb-read-only-compressed --innodb-encrypt-tables=1 --core-file --loose-debug-sync-timeout=300 Err codemadness.org 70 i 17097
Err codemadness.org 70 i 17101 Error happened at lib/mtr_report.pm line 695. Err codemadness.org 70 i 17102
Err codemadness.org 70 i 17106 mtr_report::mtr_error("Failed to start mysqld mysqld.1 with command /dev/shm/10.6m/s"...) called at /mariadb/10.6m/mysql-test/mariadb-test-run.pl line 2743 Err codemadness.org 70 i 17107
Err codemadness.org 70 i 17111 main::mysql_server_start(undef, My::Test=HASH(0x563f696343b8)) called at /mariadb/10.6m/mysql-test/mariadb-test-run.pl line 5413 Err codemadness.org 70 i 17112
Err codemadness.org 70 i 17116 main::start_servers(My::Test=HASH(0x563f696343b8)) called at /mariadb/10.6m/mysql-test/mariadb-test-run.pl line 3849 Err codemadness.org 70 i 17117
Err codemadness.org 70 i 17121 main::run_testcase(My::Test=HASH(0x563f696343b8), IO::Socket::INET=GLOB(0x563f69f5e150)) called at /mariadb/10.6m/mysql-test/mariadb-test-run.pl line 962 Err codemadness.org 70 i 17122
Err codemadness.org 70 i 17126 main::run_worker(51091, 14) called at /mariadb/10.6m/mysql-test/mariadb-test-run.pl line 475 Err codemadness.org 70 i 17127
Err codemadness.org 70 i 17131 main::main() called at /mariadb/10.6m/mysql-test/mariadb-test-run.pl line 347 Err codemadness.org 70 i 17132
Err codemadness.org 70 i 17136 worker[10] mysql-test-run: WARNING: Process [mysqld.1 - pid: 82192, winpid: 82192] died after mysql-test-run waited 0.13 seconds for /dev/shm/10.6m/mysql-test/var/10/run/mysqld.1.pid to be created. Err codemadness.org 70 i 17137
Err codemadness.org 70 i 17141 worker[10] encryption.encryption_key_corruption Err codemadness.org 70 i 17142
Err codemadness.org 70 i 17146 worker[10] [ fail ] Err codemadness.org 70 i 17147
Err codemadness.org 70 i 17151 Test ended at 2021-11-18 17:50:27 Err codemadness.org 70 i 17152
Err codemadness.org 70 i 17156 worker[10] Err codemadness.org 70 i 17157
Err codemadness.org 70 i 17161 Err codemadness.org 70 i 17162
Err codemadness.org 70 i 17166 Server log from this test: Err codemadness.org 70 i 17167
Err codemadness.org 70 i 17171 ----------SERVER LOG START----------- Err codemadness.org 70 i 17172
Err codemadness.org 70 i 17176 $ /dev/shm/10.6m/sql/mariadbd --defaults-group-suffix=.1 --defaults-file=/dev/shm/10.6m/mysql-test/var/10/my.cnf --log-output=file --innodb-checksum-algorithm=none --innodb --innodb-cmpmem --innodb-cmp-per-index --innodb-trx --innodb-locks --innodb-lock-waits --innodb-metrics --innodb-buffer-pool-stats --innodb-buffer-page --innodb-buffer-page-lru --innodb-sys-columns --innodb-sys-fields --innodb-sys-foreign --innodb-sys-foreign-cols --innodb-sys-indexes --innodb-sys-tables --innodb-sys-virtual --plugin-load-add=example_key_management.so --loose-example-key-management --skip-innodb-read-only-compressed --innodb-encrypt-tables=1 --core-file --loose-debug-sync-timeout=300 Err codemadness.org 70 i 17177
Err codemadness.org 70 i 17181 2021-11-18 17:50:27 0 [Note] /dev/shm/10.6m/sql/mariadbd (server 10.6.6-MariaDB-debug-log) starting as process 82196 ... Err codemadness.org 70 i 17182
Err codemadness.org 70 i 17186 2021-11-18 17:50:27 0 [Warning] Could not increase number of max_open_files to more than 1024 (request: 32222) Err codemadness.org 70 i 17187
Err codemadness.org 70 i 17191 2021-11-18 17:50:27 0 [Warning] Changed limits: max_open_files: 1024 max_connections: 151 (was 151) table_cache: 421 (was 2000) Err codemadness.org 70 i 17192
Err codemadness.org 70 i 17196 2021-11-18 17:50:27 0 [Warning] Plugin 'example_key_management' is of maturity level experimental while the server is stable Err codemadness.org 70 i 17197
Err codemadness.org 70 i 17201 2021-11-18 17:50:27 0 [Note] Plugin 'partition' is disabled. Err codemadness.org 70 i 17202
Err codemadness.org 70 i 17206 2021-11-18 17:50:27 0 [Note] Plugin 'SEQUENCE' is disabled. Err codemadness.org 70 i 17207
Err codemadness.org 70 i 17211 2021-11-18 17:50:27 0 [ERROR] /dev/shm/10.6m/sql/mariadbd: Error while setting value 'none' to 'innodb-checksum-algorithm' Err codemadness.org 70 i 17212
Err codemadness.org 70 i 17216 2021-11-18 17:50:27 0 [ERROR] Parsing options for plugin 'InnoDB' failed. Err codemadness.org 70 i 17217
Err codemadness.org 70 i 17221 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_FT_CONFIG' is disabled. Err codemadness.org 70 i 17222
Err codemadness.org 70 i 17226 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_SYS_TABLESTATS' is disabled. Err codemadness.org 70 i 17227
Err codemadness.org 70 i 17231 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_FT_DELETED' is disabled. Err codemadness.org 70 i 17232
Err codemadness.org 70 i 17236 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_CMP' is disabled. Err codemadness.org 70 i 17237
Err codemadness.org 70 i 17241 2021-11-18 17:50:27 0 [Note] Plugin 'THREAD_POOL_WAITS' is disabled. Err codemadness.org 70 i 17242
Err codemadness.org 70 i 17246 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_CMP_RESET' is disabled. Err codemadness.org 70 i 17247
Err codemadness.org 70 i 17251 2021-11-18 17:50:27 0 [Note] Plugin 'THREAD_POOL_QUEUES' is disabled. Err codemadness.org 70 i 17252
Err codemadness.org 70 i 17256 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_SYS_FIELDS' is disabled. Err codemadness.org 70 i 17257
Err codemadness.org 70 i 17261 2021-11-18 17:50:27 0 [Note] Plugin 'FEEDBACK' is disabled. Err codemadness.org 70 i 17262
Err codemadness.org 70 i 17266 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_FT_INDEX_TABLE' is disabled. Err codemadness.org 70 i 17267
Err codemadness.org 70 i 17271 2021-11-18 17:50:27 0 [Note] Plugin 'THREAD_POOL_GROUPS' is disabled. Err codemadness.org 70 i 17272
Err codemadness.org 70 i 17276 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_CMP_PER_INDEX_RESET' is disabled. Err codemadness.org 70 i 17277
Err codemadness.org 70 i 17281 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_SYS_FOREIGN_COLS' is disabled. Err codemadness.org 70 i 17282
Err codemadness.org 70 i 17286 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_FT_INDEX_CACHE' is disabled. Err codemadness.org 70 i 17287
Err codemadness.org 70 i 17291 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_FT_BEING_DELETED' is disabled. Err codemadness.org 70 i 17292
Err codemadness.org 70 i 17296 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_SYS_FOREIGN' is disabled. Err codemadness.org 70 i 17297
Err codemadness.org 70 i 17301 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_CMPMEM_RESET' is disabled. Err codemadness.org 70 i 17302
Err codemadness.org 70 i 17306 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_FT_DEFAULT_STOPWORD' is disabled. Err codemadness.org 70 i 17307
Err codemadness.org 70 i 17311 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_SYS_TABLES' is disabled. Err codemadness.org 70 i 17312
Err codemadness.org 70 i 17316 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_SYS_TABLESPACES' is disabled. Err codemadness.org 70 i 17317
Err codemadness.org 70 i 17321 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_SYS_INDEXES' is disabled. Err codemadness.org 70 i 17322
Err codemadness.org 70 i 17326 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_SYS_VIRTUAL' is disabled. Err codemadness.org 70 i 17327
Err codemadness.org 70 i 17331 2021-11-18 17:50:27 0 [Note] Plugin 'user_variables' is disabled. Err codemadness.org 70 i 17332
Err codemadness.org 70 i 17336 2021-11-18 17:50:27 0 [Note] Plugin 'INNODB_TABLESPACES_ENCRYPTION' is disabled. Err codemadness.org 70 i 17337
Err codemadness.org 70 i 17341 2021-11-18 17:50:27 0 [Note] Plugin 'THREAD_POOL_STATS' is disabled. Err codemadness.org 70 i 17342
Err codemadness.org 70 i 17346 2021-11-18 17:50:27 0 [Note] Plugin 'unix_socket' is disabled. Err codemadness.org 70 i 17347
Err codemadness.org 70 i 17351 2021-11-18 17:50:27 0 [Warning] /dev/shm/10.6m/sql/mariadbd: unknown option '--loose-pam-debug' Err codemadness.org 70 i 17352
Err codemadness.org 70 i 17356 2021-11-18 17:50:27 0 [Warning] /dev/shm/10.6m/sql/mariadbd: unknown option '--loose-aria' Err codemadness.org 70 i 17357
Err codemadness.org 70 i 17361 2021-11-18 17:50:27 0 [Warning] /dev/shm/10.6m/sql/mariadbd: unknown option '--loose-aria' Err codemadness.org 70 i 17362
Err codemadness.org 70 i 17366 2021-11-18 17:50:27 0 [ERROR] /dev/shm/10.6m/sql/mariadbd: unknown option '----file-marker----' Err codemadness.org 70 i 17367
Err codemadness.org 70 i 17371 2021-11-18 17:50:27 0 [ERROR] Aborting Err codemadness.org 70 i 17372
Err codemadness.org 70 i 17376 ----------SERVER LOG END------------- Err codemadness.org 70 i 17377
Err codemadness.org 70 i 17381 Err codemadness.org 70 i 17382
Err codemadness.org 70 i 17386 Err codemadness.org 70 i 17387
Err codemadness.org 70 i 17391 worker[10] mysql-test-run: *** ERROR: Failed to start mysqld mysqld.1 with command /dev/shm/10.6m/sql/mariadbd --defaults-group-suffix=.1 --defaults-file=/dev/shm/10.6m/mysql-test/var/10/my.cnf --log-output=file --innodb-checksum-algorithm=none --innodb --innodb-cmpmem --innodb-cmp-per-index --innodb-trx --innodb-locks --innodb-lock-waits --innodb-metrics --innodb-buffer-pool-stats --innodb-buffer-page --innodb-buffer-page-lru --innodb-sys-columns --innodb-sys-fields --innodb-sys-foreign --innodb-sys-foreign-cols --innodb-sys-indexes --innodb-sys-tables --innodb-sys-virtual --plugin-load-add=example_key_management.so --loose-example-key-management --skip-innodb-read-only-compressed --innodb-encrypt-tables=1 --core-file --loose-debug-sync-timeout=300 Err codemadness.org 70 i 17392
Err codemadness.org 70 i 17396 Error happened at lib/mtr_report.pm line 695. Err codemadness.org 70 i 17397
Err codemadness.org 70 i 17401 mtr_report::mtr_error("Failed to start mysqld mysqld.1 with command /dev/shm/10.6m/s"...) called at /mariadb/10.6m/mysql-test/mariadb-test-run.pl line 2743 Err codemadness.org 70 i 17402
Err codemadness.org 70 i 17406 main::mysql_server_start(My::Config::Group=HASH(0x563f696d71a0), My::Test=HASH(0x563f69610310)) called at /mariadb/10.6m/mysql-test/mariadb-test-run.pl line 5413 Err codemadness.org 70 i 17407
Err codemadness.org 70 i 17411 main::start_servers(My::Test=HASH(0x563f69610310)) called at /mariadb/10.6m/mysql-test/mariadb-test-run.pl line 3849 Err codemadness.org 70 i 17412
Err codemadness.org 70 i 17416 main::run_testcase(My::Test=HASH(0x563f69610310), IO::Socket::INET=GLOB(0x563f69f5e150)) called at /mariadb/10.6m/mysql-test/mariadb-test-run.pl line 962 Err codemadness.org 70 i 17417
Err codemadness.org 70 i 17421 main::run_worker(51091, 10) called at /mariadb/10.6m/mysql-test/mariadb-test-run.pl line 475 Err codemadness.org 70 i 17422
Err codemadness.org 70 i 17426 main::main() called at /mariadb/10.6m/mysql-test/mariadb-test-run.pl line 347 Err codemadness.org 70 i 17427 Err codemadness.org 70 i 17428

Err codemadness.org 70 i 17432

Err codemadness.org 70 i 17433

Err codemadness.org 70 i 17434

At the end of the test run, these two test failures were reported as follows:

Err codemadness.org 70 i 17435

Err codemadness.org 70 i 17436

Err codemadness.org 70 i 17437 Err codemadness.org 70 i 17438 Err codemadness.org 70 i 17439 Err codemadness.org 70 i 17440 Err codemadness.org 70 i 17443 Err codemadness.org 70 i 17444 Err codemadness.org 70 i 17445 Err codemadness.org 70 i 17448 Err codemadness.org 70 i 17449 Err codemadness.org 70 i 17450 Err codemadness.org 70 i 17453 Err codemadness.org 70 i 17454 Err codemadness.org 70 i 17455 Err codemadness.org 70 i 17458 Err codemadness.org 70 i 17459 Err codemadness.org 70 i 17460 Err codemadness.org 70 i 17463 Err codemadness.org 70 i 17464 Err codemadness.org 70 i 17465 Err codemadness.org 70 i 17468 Err codemadness.org 70 i 17469 Err codemadness.org 70 i 17470 Err codemadness.org 70 i 17473 Err codemadness.org 70 i 17474 Err codemadness.org 70 i 17475 Err codemadness.org 70 i 17478 Err codemadness.org 70 i 17479 Err codemadness.org 70 i 17480 Err codemadness.org 70 i 17483 Err codemadness.org 70 i 17484 Err codemadness.org 70 i 17485 Err codemadness.org 70 i 17489 Err codemadness.org 70 i 17490 Err codemadness.org 70 i 17491

Err codemadness.org 70 i 17441

Only  5881  of 5883 completed.

Err codemadness.org 70 i 17442

Err codemadness.org 70 i 17446

--------------------------------------------------------------------------

Err codemadness.org 70 i 17447

Err codemadness.org 70 i 17451

The servers were restarted 2067 times

Err codemadness.org 70 i 17452

Err codemadness.org 70 i 17456

Spent 11573.873 of 533 seconds executing testcases

Err codemadness.org 70 i 17457

Err codemadness.org 70 i 17461

Err codemadness.org 70 i 17462

Err codemadness.org 70 i 17466

Completed: All 5622 tests were successful.

Err codemadness.org 70 i 17467

Err codemadness.org 70 i 17471

Err codemadness.org 70 i 17472

Err codemadness.org 70 i 17476

198 tests were skipped, 177 by the test itself.

Err codemadness.org 70 i 17477

Err codemadness.org 70 i 17481

Err codemadness.org 70 i 17482

Err codemadness.org 70 i 17486

mysql-test-run: *** ERROR: Not all tests completed (only 5881 of 5883)	Err	codemadness.org	70
i 17487

Err codemadness.org 70 i 17488

Err codemadness.org 70 i 17492

Err codemadness.org 70 i 17493

Err codemadness.org 70 i 17494

Err codemadness.org 70 i 17496